[clang] [llvm] New calling convention preserve_none (PR #76868)

2024-01-17 Thread via cfe-commits
@@ -1056,6 +1056,23 @@ def CC_Intel_OCL_BI : CallingConv<[ CCDelegateTo ]>; +def CC_X86_64_Preserve_None : CallingConv<[ + // We don't preserve general registers, so all of them can be used to pass + // arguments except + // - RBPframe pointer + // - R10

[clang] [Clang][SME] Detect always_inline used with mismatched streaming attributes (PR #77936)

2024-01-17 Thread Jon Roelofs via cfe-commits
@@ -153,6 +155,11 @@ class AArch64TargetCodeGenInfo : public TargetCodeGenInfo { } return TargetCodeGenInfo::isScalarizableAsmOperand(CGF, Ty); } + + void checkFunctionCallABI(CodeGenModule , SourceLocation CallLoc, jroelofs wrote: where is this

[clang] [llvm] [RISCV] Update TargetAttr target-cpu override rule (PR #75804)

2024-01-17 Thread Michael Maitland via cfe-commits
@@ -482,5 +482,35 @@ ParsedTargetAttr RISCVTargetInfo::parseTargetAttr(StringRef Features) const { Ret.Tune = AttrString; } } + + StringRef MCPU = this->getTargetOpts().CPU; + StringRef MTune = this->getTargetOpts().TuneCPU; + + // attr-cpu override march only

[clang] [llvm] New calling convention preserve_none (PR #76868)

2024-01-17 Thread via cfe-commits
https://github.com/weiguozhi updated https://github.com/llvm/llvm-project/pull/76868 >From 90e14918a0eb13e2187f8548416ac72491d966c1 Mon Sep 17 00:00:00 2001 From: Guozhi Wei Date: Thu, 21 Dec 2023 19:04:44 + Subject: [PATCH 1/4] New calling convention preserve_none The new calling

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-01-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff de423cfe3d5de0110b4f55ff1742988b529be6d2 d47d92d074e6a4870849db79dec5adb197bed010 --

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-01-17 Thread M. Zeeshan Siddiqui via cfe-commits
https://github.com/codemzs edited https://github.com/llvm/llvm-project/pull/78503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: M. Zeeshan Siddiqui (codemzs) Changes Implements Core language changes based on [P1467R9](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p1467r9.html) Extended floating-point types

[clang] [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-01-17 Thread M. Zeeshan Siddiqui via cfe-commits
https://github.com/codemzs created https://github.com/llvm/llvm-project/pull/78503 Implements Core language changes based on [P1467R9](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p1467r9.html) Extended floating-point types and standard names. As per the proposal's definition the

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-17 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM The logic in CGExprCXX.cpp is a bit more complicated than I'd like, but I don't see any obvious way to simplify it. https://github.com/llvm/llvm-project/pull/76976 ___ cfe-commits

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-17 Thread Eli Friedman via cfe-commits
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer( return true; }; + const InitListExpr *ILE = dyn_cast(Init); + const CXXParenListInitExpr *CPLIE = dyn_cast(Init); + const StringLiteral *SL = dyn_cast(Init); // If the initializer is an

[clang-tools-extra] [clang] [clang-tidy] fix misc-const-correctnes false-positive for fold expressions (PR #78320)

2024-01-17 Thread Julian Schmidt via cfe-commits
@@ -382,7 +382,8 @@ Changes in existing checks using pointer to member function. Additionally, the check no longer emits a diagnostic when a variable that is not type-dependent is an operand of a type-dependent binary operator. Improved performance of the check through -

[clang-tools-extra] [clang] [clang-tidy] fix misc-const-correctnes false-positive for fold expressions (PR #78320)

2024-01-17 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/78320 >From 1951630fd6a0edc5258f5a775c95b9e9c30106df Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 28 Oct 2023 18:39:18 +0200 Subject: [PATCH 1/4] [clang-tidy]

[clang] [llvm] [CMake] Detect properly new linker introduced in Xcode 15 (PR #77806)

2024-01-17 Thread Eric Miotto via cfe-commits
https://github.com/edymtt updated https://github.com/llvm/llvm-project/pull/77806 >From c97e07011f2f780e29aa7cd5db9bfec8c3b4a6a8 Mon Sep 17 00:00:00 2001 From: Eric Miotto <1094986+edy...@users.noreply.github.com> Date: Thu, 11 Jan 2024 08:27:21 -0800 Subject: [PATCH] [CMake] Detect properly

[clang] [clang][PP] Add extension to predefine target OS macros (PR #74676)

2024-01-17 Thread Zixu Wang via cfe-commits
zixu-w wrote: > > We have provided a fix for zlib > > ([madler/zlib#895](https://github.com/madler/zlib/pull/895)) which was > > accepted by @madler. > > But nowhere released, not even in the repository :( Yeah... Not entirely familiar with the zlib development and contribution process, but

[lldb] [libunwind] [clang-tools-extra] [lld] [clang] [libcxx] [libc] [compiler-rt] [libcxxabi] [flang] [llvm] Fix a bug in Smith's algorithm used in complex div/mul. (PR #78330)

2024-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Zahira Ammarguellat (zahiraam) Changes This patch fixes a bug in Smith's algorithm (thanks to @andykaylor who detected it) and makes sure that last option in command line rules. --- Full diff:

[libcxx] [libcxxabi] [lldb] [flang] [clang-tools-extra] [clang] [llvm] [compiler-rt] [libunwind] [libc] [lld] Fix a bug in Smith's algorithm used in complex div/mul. (PR #78330)

2024-01-17 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/78330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Upstream XROS support in Clang (PR #78392)

2024-01-17 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/78392 >From 52ff81ffbce596fd89b296e7f4199be13f9402ff Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 16 Jan 2024 20:36:47 -0800 Subject: [PATCH 1/2] [clang] Upstream XROS support in Clang Upstream

[llvm] [clang] [CMake][PGO] Build Sema.cpp to generate profdata for PGO builds (PR #77347)

2024-01-17 Thread Tom Stellard via cfe-commits
@@ -26,9 +30,23 @@ if(LLVM_BUILD_INSTRUMENTED) message(STATUS "To enable merging PGO data LLVM_PROFDATA has to point to llvm-profdata") else() add_custom_target(generate-profdata - COMMAND "${Python3_EXECUTABLE}" ${CMAKE_CURRENT_SOURCE_DIR}/perf-helper.py

[llvm] [clang] [CMake][PGO] Build Sema.cpp to generate profdata for PGO builds (PR #77347)

2024-01-17 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/77347 >From 127e2ae83f33843cfb9c5cca314afa2fc9844239 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 6 Jan 2024 07:46:01 + Subject: [PATCH 1/7] [CMake][PGO] Use check-clang target to generate profdata for

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-17 Thread Richard Smith via cfe-commits
@@ -1357,6 +1363,19 @@ class Sema final { // VLAs). bool InConditionallyConstantEvaluateContext = false; +/// Whether we are currently in a context in which temporaries must be +/// lifetime-extended (Eg. in a for-range initializer). +bool

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-17 Thread Richard Smith via cfe-commits
@@ -9959,6 +9976,18 @@ class Sema final { return currentEvaluationContext().isImmediateFunctionContext(); } + bool isInLifetimeExtendingContext() const { +assert(!ExprEvalContexts.empty() && + "Must be in an expression evaluation context"); +return

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-17 Thread Richard Smith via cfe-commits
https://github.com/zygoloid commented: This looks good to me. https://github.com/llvm/llvm-project/pull/76361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-17 Thread Richard Smith via cfe-commits
https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/76361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][PP] Add extension to predefine target OS macros (PR #74676)

2024-01-17 Thread Mike Hommey via cfe-commits
glandium wrote: > We have provided a fix for zlib > ([madler/zlib#895](https://github.com/madler/zlib/pull/895)) which was > accepted by @madler. But nowhere released, not even in the repository :( https://github.com/llvm/llvm-project/pull/74676

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2024-01-17 Thread Philip Reames via cfe-commits
preames wrote: Not actively working on this. Anyone interested is welcome to pick up the patch. https://github.com/llvm/llvm-project/pull/74770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [driver] Respect the mode the driver is in for autocomplete (PR #74770)

2024-01-17 Thread Philip Reames via cfe-commits
https://github.com/preames closed https://github.com/llvm/llvm-project/pull/74770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Support MSPropertyRefExpr as placement arg to new-expression (PR #75883)

2024-01-17 Thread Erich Keane via cfe-commits
erichkeane wrote: > I’m curious, because I legitimately don’t know, is it common for CI on > windows to take 9 hours? > >

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-01-17 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: sorry, I keep missing notifications, will find a repro https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Emit atomic IR in place of optimized libcalls. (PR #73176)

2024-01-17 Thread via cfe-commits
https://github.com/Logikable updated https://github.com/llvm/llvm-project/pull/73176 >From 9dfcc46c600a0c4720553faf7e070862650792bc Mon Sep 17 00:00:00 2001 From: Sean Luchen Date: Fri, 17 Nov 2023 17:29:52 + Subject: [PATCH] [clang][CodeGen] Emit atomic IR in place of optimized libcalls.

[clang-tools-extra] [clang] [llvm] [AMDGPU] Reapply 'Sign extend simm16 in setreg intrinsic' (PR #78492)

2024-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Stanislav Mekhanoshin (rampitec) Changes We currently force users to use a negative contant in the intrinsic call. Changing it zext would break existing programs, so just sign extend an argument. --- Full diff:

[clang] [llvm] [clang-tools-extra] [AMDGPU] Reapply 'Sign extend simm16 in setreg intrinsic' (PR #78492)

2024-01-17 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec created https://github.com/llvm/llvm-project/pull/78492 We currently force users to use a negative contant in the intrinsic call. Changing it zext would break existing programs, so just sign extend an argument. >From 01af6c9d8e80b810bbdec35dee38b1cf5d73cfe0 Mon Sep

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/78200 >From e8c799b54c3e0b8088dbc19aaac0ef066baf136e Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Mon, 15 Jan 2024 22:24:34 +0400 Subject: [PATCH 1/6] add warning and test ---

[clang] [llvm] [flang] [clang-tools-extra] [flang] add SYSTEM runtime and lowering intrinsics support (PR #74309)

2024-01-17 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/74309 >From 14f8c3e38791cc6b06455b8beffe37a6f7105e03 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 4 Dec 2023 10:32:03 + Subject: [PATCH 01/18] Add SYSTEM runtime and lowering intrinsic support Calls

[clang] [clang-tools-extra] [clangd] Support parsing comments without ASTContext (PR #78491)

2024-01-17 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders updated https://github.com/llvm/llvm-project/pull/78491 >From 640318fcf475a82b5483889795e2bd906b7b3c9c Mon Sep 17 00:00:00 2001 From: Tom Praschan <13141438+tom-and...@users.noreply.github.com> Date: Sat, 18 Feb 2023 15:54:09 +0100 Subject: [PATCH] [clangd] Support

[clang] [clang-tools-extra] [clangd] Support parsing comments without ASTContext (PR #78491)

2024-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clangd Author: Tom Praschan (tom-anders) Changes This is in preparation for implementing doxygen parsing, see discussion in https://github.com/clangd/clangd/issues/529. (Old Phabricator review:

[clang-tools-extra] [clang] [clangd] Support parsing comments without ASTContext (PR #78491)

2024-01-17 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders edited https://github.com/llvm/llvm-project/pull/78491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [clang] Support parsing comments without ASTContext (PR #78491)

2024-01-17 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders created https://github.com/llvm/llvm-project/pull/78491 This is in preparation for implementing doxygen parsing, see discussion in https://github.com/clangd/clangd/issues/529. (Old Phabricator review: https://reviews.llvm.org/D143112) >From

[clang] [Clang] Support MSPropertyRefExpr as placement arg to new-expression (PR #75883)

2024-01-17 Thread via cfe-commits
Sirraide wrote: I’m curious, because I legitimately don’t know, is it common for CI on windows to take 9 hours? ![image](https://github.com/llvm/llvm-project/assets/74590115/203deb5a-b798-4ca2-8a6f-cc45a811d0f6) https://github.com/llvm/llvm-project/pull/75883

[llvm] [lld] [clang-tools-extra] [lld/ELF] Hint if R_X86_64_PC32 overflows and references a SHF_X86_64_LARGE section (PR #73045)

2024-01-17 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/73045 >From 0145020ef2a803ec797e42f95bacde05dc32eac1 Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Tue, 21 Nov 2023 14:01:04 -0800 Subject: [PATCH 1/2] [lld/ELF] Hint if R_X86_64_PC32 overflows and references

[clang] [llvm] [CMake] Detect properly new linker introduced in Xcode 15 (PR #77806)

2024-01-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/77806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake] Detect properly new linker introduced in Xcode 15 (PR #77806)

2024-01-17 Thread Louis Dionne via cfe-commits
@@ -211,10 +211,10 @@ if (NOT DEFINED LLVM_LINKER_DETECTED AND NOT WIN32) ) if(APPLE) -if("${stderr}" MATCHES "PROJECT:ld64") +if("${stderr}" MATCHES "PROGRAM:ld") ldionne wrote: Ahhh, now this all makes sense! I hadn't noticed that you

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/78200 >From e8c799b54c3e0b8088dbc19aaac0ef066baf136e Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Mon, 15 Jan 2024 22:24:34 +0400 Subject: [PATCH 1/5] add warning and test ---

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-17 Thread Alan Zhao via cfe-commits
https://github.com/alanzhao1 updated https://github.com/llvm/llvm-project/pull/76976 >From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001 From: Alan Zhao Date: Wed, 3 Jan 2024 12:29:21 -0800 Subject: [PATCH 1/9] [clang] Fix parenthesized list initialization of arrays not

[clang] [Clang][Sema] Print more static_assert exprs (PR #74852)

2024-01-17 Thread via cfe-commits
https://github.com/sethp updated https://github.com/llvm/llvm-project/pull/74852 >From f281d34a51f662c934f158e4770774b0dc3588a2 Mon Sep 17 00:00:00 2001 From: Seth Pellegrino Date: Thu, 7 Dec 2023 08:45:51 -0800 Subject: [PATCH 01/10] [Clang][Sema] Print more static_assert exprs This change

[lldb] [flang] [libcxx] [lld] [clang] [compiler-rt] [libcxxabi] [libunwind] [libc] [llvm] [clang-tools-extra] Fix a bug in Smith's algorithm used in complex div/mul. (PR #78330)

2024-01-17 Thread Andy Kaylor via cfe-commits
@@ -2780,24 +2781,24 @@ static void RenderFloatingPointOptions(const ToolChain , const Driver , case options::OPT_fcx_limited_range: { EmitComplexRangeDiag(D, Range, LangOptions::ComplexRangeKind::CX_Limited); Range =

[clang] [clang] Fix parenthesized list initialization of arrays not working with `new` (PR #76976)

2024-01-17 Thread Alan Zhao via cfe-commits
https://github.com/alanzhao1 updated https://github.com/llvm/llvm-project/pull/76976 >From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001 From: Alan Zhao Date: Wed, 3 Jan 2024 12:29:21 -0800 Subject: [PATCH 1/8] [clang] Fix parenthesized list initialization of arrays not

[clang-tools-extra] [libc] [lld] [llvm] [flang] [libcxxabi] [clang] [libunwind] [libcxx] [compiler-rt] [lldb] Fix a bug in Smith's algorithm used in complex div/mul. (PR #78330)

2024-01-17 Thread John McCall via cfe-commits
https://github.com/rjmccall commented: It's bad that we don't have a IR test that breaks when you change the IR output like this. Please add one. https://github.com/llvm/llvm-project/pull/78330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libc] [lldb] [clang] [llvm] [libunwind] [flang] [lld] [libcxxabi] [clang-tools-extra] [libcxx] [compiler-rt] Fix a bug in Smith's algorithm used in complex div/mul. (PR #78330)

2024-01-17 Thread John McCall via cfe-commits
@@ -978,7 +978,11 @@ ComplexPairTy ComplexExprEmitter::EmitBinDiv(const BinOpInfo ) { return EmitRangeReductionDiv(LHSr, LHSi, RHSr, RHSi); else if (Op.FPFeatures.getComplexRange() == LangOptions::CX_Limited) return EmitAlgebraicDiv(LHSr, LHSi, RHSr, RHSi); -

[libcxx] [flang] [lldb] [clang-tools-extra] [libc] [libunwind] [libcxxabi] [clang] [llvm] [compiler-rt] [lld] Fix a bug in Smith's algorithm used in complex div/mul. (PR #78330)

2024-01-17 Thread John McCall via cfe-commits
https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/78330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [llvm] [clang-tools-extra] [clang] [flang] add SYSTEM runtime and lowering intrinsics support (PR #74309)

2024-01-17 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/74309 >From 14f8c3e38791cc6b06455b8beffe37a6f7105e03 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 4 Dec 2023 10:32:03 + Subject: [PATCH 01/18] Add SYSTEM runtime and lowering intrinsic support Calls

[clang] [clang] Upstream XROS support in Clang (PR #78392)

2024-01-17 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/78392 >From d7c431e0fbc0ad006b9d37a4e3a43c61ce1f50b7 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 16 Jan 2024 20:36:47 -0800 Subject: [PATCH] [clang] Upstream XROS support in Clang Upstream XROS

[clang-tools-extra] [clang] [compiler-rt] [PGO] Reland PGO's Counter Reset and File Dumping APIs #76471 (PR #78285)

2024-01-17 Thread Qiongsi Wu via cfe-commits
qiongsiwu wrote: It seems that either the precommit CI has some problems, or there are existing `compiler-rt` breakages. https://github.com/llvm/llvm-project/pull/78037 is also failing the same test cases. The changes in #78037 does not look harmful either. I took a brief look at the current

[llvm] [clang-tools-extra] [clang] [AMDGPU][GFX12] Add Atomic cond_sub_u32 (PR #76224)

2024-01-17 Thread Mariusz Sikora via cfe-commits
https://github.com/mariusz-sikora-at-amd closed https://github.com/llvm/llvm-project/pull/76224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [llvm] [lld] [compiler-rt] [clang-tools-extra] [clang] [libc] [lldb] [flang] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-17 Thread Stanislav Mekhanoshin via cfe-commits
rampitec wrote: > > lgtm, but can still fix the -O0 thing > > But where do I get TM in the getAnalysisUsage? Found addUsedIfAvailable() which does the trick. https://github.com/llvm/llvm-project/pull/74537 ___ cfe-commits mailing list

[libcxx] [llvm] [lld] [compiler-rt] [clang-tools-extra] [clang] [libc] [lldb] [flang] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-17 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/74537 >From 7e382620cdc5999c645ed0746f242595f0294c58 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Mon, 4 Dec 2023 16:11:53 -0800 Subject: [PATCH 01/13] [AMDGPU] Use alias info to relax waitcounts for

[lldb] [clang] [clang] Upstream XROS support in Clang (PR #78392)

2024-01-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5aea6ba8f5f06e06887fe5c5c8740895907f6540 868dd57be1d046d2f66823662bca10323aec05a3 --

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-17 Thread via cfe-commits
cor3ntin wrote: @zygoloid Can you take another crack at this? If you have time to confirm the design maybe we could try to land it in Clang 18. Otherwise the plan is to be conservative. Thanks! https://github.com/llvm/llvm-project/pull/76361 ___

[lldb] [clang] [clang] Upstream XROS support in Clang (PR #78392)

2024-01-17 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/78392 >From 6f6d93b6cc413d54dbdec05f30ede00ffdb4 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 10 Jan 2024 17:35:47 -0800 Subject: [PATCH 1/2] [lldb] Upstream xros support in lldb Upstream

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/78200 >From e8c799b54c3e0b8088dbc19aaac0ef066baf136e Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Mon, 15 Jan 2024 22:24:34 +0400 Subject: [PATCH 1/4] add warning and test ---

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/78200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/78200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread Vlad Serebrennikov via cfe-commits
@@ -11792,6 +11792,32 @@ static bool CheckMultiVersionFunction(Sema , FunctionDecl *NewFD, OldDecl, Previous); } +static void CheckFunctionDeclarationAttributesUsage(Sema , +

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/78200 >From e8c799b54c3e0b8088dbc19aaac0ef066baf136e Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Mon, 15 Jan 2024 22:24:34 +0400 Subject: [PATCH 1/3] add warning and test ---

[clang] [coroutines][coro_lifetimebound] Detect lifetime issues with lambda captures (PR #77066)

2024-01-17 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Thanks for the patch! https://github.com/llvm/llvm-project/pull/77066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines][coro_lifetimebound] Detect lifetime issues with lambda captures (PR #77066)

2024-01-17 Thread Ilya Biryukov via cfe-commits
@@ -15841,13 +15841,24 @@ static void diagnoseImplicitlyRetainedSelf(Sema ) { << FixItHint::CreateInsertion(P.first, "self->"); } +bool Sema::IsGetReturnObject(const FunctionDecl *FD) { + return isa(FD) && FD->param_empty() && ilya-biryukov wrote:

[clang] [coroutines][coro_lifetimebound] Detect lifetime issues with lambda captures (PR #77066)

2024-01-17 Thread Ilya Biryukov via cfe-commits
@@ -11220,6 +11220,11 @@ class Sema final { VarDecl *buildCoroutinePromise(SourceLocation Loc); void CheckCompletedCoroutineBody(FunctionDecl *FD, Stmt *); + // Heuristically tells if the function is get_return_object by matching ilya-biryukov wrote: I

[clang] [coroutines][coro_lifetimebound] Detect lifetime issues with lambda captures (PR #77066)

2024-01-17 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/77066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines][coro_lifetimebound] Detect lifetime issues with lambda captures (PR #77066)

2024-01-17 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. I'm ok with the changes, but I left a suggestion about naming the function that I think we should follow. https://github.com/llvm/llvm-project/pull/77066 ___ cfe-commits mailing list

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-17 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Looks good overall. It's good that you wrote your own tests, but it would also be nice to mirror tests in `clang/unittests/libclang/LibclangTest.cpp` which test the same API. This way we can identify issues in binding layer itself (when C++ tests pass,

[clang] [clang][PP] Add extension to predefine target OS macros (PR #74676)

2024-01-17 Thread Zixu Wang via cfe-commits
zixu-w wrote: > > It looks like this breaks building at least `MultiSource` from > > https://github.com/llvm/llvm-test-suite/. The first failure I see is when > > building `llvm-test-suite/MultiSource/Applications/ClamAV/zlib_zutil.c` > > ``` > > In file included from > >

[clang] [Clang] Support MSPropertyRefExpr as placement arg to new-expression (PR #75883)

2024-01-17 Thread via cfe-commits
Sirraide wrote: > I'll commit it when I see the CI done, and can do the release notes conflict. > I wont bother re-running after conflict resolution. Alright, thanks! https://github.com/llvm/llvm-project/pull/75883 ___ cfe-commits mailing list

[clang] [Clang] Support MSPropertyRefExpr as placement arg to new-expression (PR #75883)

2024-01-17 Thread Erich Keane via cfe-commits
erichkeane wrote: > > Nope! Once the CI is done, feel free to Squash & Merge. > > I would but I don’t have commit access, so someone else would have to do that > for me. (Also, I do fear that in the time it takes for the CI jobs to > complete, we’ll have another merge conflict w/ the release

[clang] [Clang] Support MSPropertyRefExpr as placement arg to new-expression (PR #75883)

2024-01-17 Thread via cfe-commits
Sirraide wrote: > Nope! Once the CI is done, feel free to Squash & Merge. I would but I don’t have commit access, so someone else would have to do that for me. (Also, I do fear that in the time it takes for the CI jobs to complete, we’ll have another merge conflict w/ the release notes

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/78200 >From b080d04eb30254502ccd5d59d76b5197db1fa88d Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Mon, 15 Jan 2024 22:24:34 +0400 Subject: [PATCH 01/11] add warning and test ---

[clang-tools-extra] [lldb] [libc] [libcxx] [clang] [compiler-rt] [lld] [flang] [llvm] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-17 Thread Stanislav Mekhanoshin via cfe-commits
rampitec wrote: > lgtm, but can still fix the -O0 thing But where do I get TM in the getAnalysisUsage? https://github.com/llvm/llvm-project/pull/74537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [lldb] [libc] [libcxx] [clang] [compiler-rt] [lld] [flang] [llvm] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-17 Thread Stanislav Mekhanoshin via cfe-commits
@@ -707,7 +723,40 @@ void WaitcntBrackets::updateByEvent(const SIInstrInfo *TII, (TII->isDS(Inst) || TII->mayWriteLDSThroughDMA(Inst))) { // MUBUF and FLAT LDS DMA operations need a wait on vmcnt before LDS // written can be accessed. A load from LDS to

[libcxx] [compiler-rt] [clang] [clang-tools-extra] [libc] [flang] [lldb] [lld] [llvm] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-17 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/74537 >From 7e382620cdc5999c645ed0746f242595f0294c58 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Mon, 4 Dec 2023 16:11:53 -0800 Subject: [PATCH 01/12] [AMDGPU] Use alias info to relax waitcounts for

[clang] d525e2b - [Headers][X86] Add more descriptions to ia32intrin.h and immintrin.h (#77686)

2024-01-17 Thread via cfe-commits
Author: Paul T Robinson Date: 2024-01-17T09:31:15-08:00 New Revision: d525e2b31b999fb2c989fb0986332066466c61c7 URL: https://github.com/llvm/llvm-project/commit/d525e2b31b999fb2c989fb0986332066466c61c7 DIFF:

[clang] [Headers][X86] Add more descriptions to ia32intrin.h and immintrin.h (PR #77686)

2024-01-17 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/77686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Variadic 'dropAttrs' (PR #78476)

2024-01-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, that's a nice, easy change! https://github.com/llvm/llvm-project/pull/78476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread Aaron Ballman via cfe-commits
@@ -11792,6 +11792,26 @@ static bool CheckMultiVersionFunction(Sema , FunctionDecl *NewFD, OldDecl, Previous); } +static void CheckFunctionDeclarationAttributesUsage(Sema , +

[clang] Add Variadic 'dropAttrs' (PR #78476)

2024-01-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman deleted https://github.com/llvm/llvm-project/pull/78476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Variadic 'dropAttrs' (PR #78476)

2024-01-17 Thread Aaron Ballman via cfe-commits
@@ -7068,8 +7068,7 @@ static void checkAttributesAfterMerging(Sema , NamedDecl ) { if (WeakRefAttr *Attr = ND.getAttr()) { if (ND.isExternallyVisible()) { S.Diag(Attr->getLocation(), diag::err_attribute_weakref_not_static); - ND.dropAttr(); -

[clang] [clang-tools-extra] [Clang][NFC] Rename CXXMethodDecl::isPure -> is VirtualPure (PR #78463)

2024-01-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/78463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Variadic 'dropAttrs' (PR #78476)

2024-01-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/78476 >From 6790e56b001a29e8bba012514eb3b12cd486d505 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Wed, 17 Jan 2024 09:03:14 -0800 Subject: [PATCH 1/2] Add Variadic 'dropAttrs' As suggested in

[clang] Add Variadic 'dropAttrs' (PR #78476)

2024-01-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2cd013a7869a341a6536324c34f0c4e68bf01a38 6790e56b001a29e8bba012514eb3b12cd486d505 --

[clang] [clang-tools-extra] [Clang][NFC] Rename CXXMethodDecl::isPure -> is VirtualPure (PR #78463)

2024-01-17 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/78463 >From 95545827ee940b962540b1bc7e23baea714f915e Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 17 Jan 2024 17:28:38 +0100 Subject: [PATCH] [Clang][NFC] Rename CXXMethodDecl::isPure -> isPureVirtual To

[clang] [llvm] [clang-tools-extra] [flang] [flang] add SYSTEM runtime and lowering intrinsics support (PR #74309)

2024-01-17 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/74309 >From 14f8c3e38791cc6b06455b8beffe37a6f7105e03 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 4 Dec 2023 10:32:03 + Subject: [PATCH 01/18] Add SYSTEM runtime and lowering intrinsic support Calls

[clang] Add Variadic 'dropAttrs' (PR #78476)

2024-01-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes As suggested in https://github.com/llvm/llvm-project/pull/78200 This adds a variadic 'dropAttrs', which drops all attributes of any of the types specified. --- Full diff:

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread Erich Keane via cfe-commits
@@ -11792,6 +11792,26 @@ static bool CheckMultiVersionFunction(Sema , FunctionDecl *NewFD, OldDecl, Previous); } +static void CheckFunctionDeclarationAttributesUsage(Sema , +

[clang] Add Variadic 'dropAttrs' (PR #78476)

2024-01-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/78476 As suggested in https://github.com/llvm/llvm-project/pull/78200 This adds a variadic 'dropAttrs', which drops all attributes of any of the types specified. >From 6790e56b001a29e8bba012514eb3b12cd486d505 Mon

[flang] [clang] [llvm] [clang-tools-extra] [flang] add SYSTEM runtime and lowering intrinsics support (PR #74309)

2024-01-17 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/74309 >From 14f8c3e38791cc6b06455b8beffe37a6f7105e03 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 4 Dec 2023 10:32:03 + Subject: [PATCH 01/18] Add SYSTEM runtime and lowering intrinsic support Calls

[clang] [llvm] [RISCV] Add experimental support of Zaamo and Zalrsc (PR #77424)

2024-01-17 Thread James Y Knight via cfe-commits
jyknight wrote: There's two sets of atomic functions: `__atomic_*` are provided by libatomic, and might use locking, or not. `__sync_*` should always be lock-free. These are only used on certain architectures where it's guaranteed that the operation _can_ be implemented lock-free, but it's

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread Erich Keane via cfe-commits
@@ -11792,6 +11792,26 @@ static bool CheckMultiVersionFunction(Sema , FunctionDecl *NewFD, OldDecl, Previous); } +static void CheckFunctionDeclarationAttributesUsage(Sema , +

[llvm] [clang] [CMake] Detect properly new linker introduced in Xcode 15 (PR #77806)

2024-01-17 Thread Eric Miotto via cfe-commits
https://github.com/edymtt edited https://github.com/llvm/llvm-project/pull/77806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] fix captureVars assertion failure on capturesVariables (PR #76619)

2024-01-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM but please add a release note so users know about the bug fix. https://github.com/llvm/llvm-project/pull/76619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang-tools-extra] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-17 Thread Mircea Trofin via cfe-commits
mtrofin wrote: > > Would it be also possible to remove the dependency on > > [Abseil](https://github.com/abseil/abseil-py)? None of the existing scripts > > in LLVM use it and I don't think we should be introducing this dependency. > > It looks like Abseil is only used for flag parsing,

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-17 Thread Aaron Ballman via cfe-commits
@@ -11792,6 +11792,26 @@ static bool CheckMultiVersionFunction(Sema , FunctionDecl *NewFD, OldDecl, Previous); } +static void CheckFunctionDeclarationAttributesUsage(Sema , +

[llvm] [clang-tools-extra] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-17 Thread Mircea Trofin via cfe-commits
@@ -0,0 +1,6 @@ +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. mtrofin wrote: Ack - thanks for clarifying the directory structure; looking around, there doesn't seem to be much of a precedent either; so... how about

[clang-tools-extra] [clang] [Clang][NFC] Rename CXXMethodDecl::isPure -> is VirtualPure (PR #78463)

2024-01-17 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > I might suggest `isPureVirtual` as it better reflects the 'term of art' > (https://en.cppreference.com/w/cpp/language/abstract_class see 'A pure > virtual function is a). > > Else LG and SG TM. I have the same preference for `isPureVirtual` but otherwise LGTM.

<    1   2   3   4   5   6   >