[clang-tools-extra] [compiler-rt] [flang] [clang] [llvm] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-28 Thread Florian Hahn via cfe-commits
@@ -806,6 +806,19 @@ static unsigned getOpcodeForRecipe(VPRecipeBase &R) { /// Try to simplify recipe \p R. static void simplifyRecipe(VPRecipeBase &R, VPTypeAnalysis &TypeInfo) { + // Try to remove redundant blend recipes. + if (auto *Blend = dyn_cast(&R)) { +bool AllEq

[llvm] [flang] [compiler-rt] [clang-tools-extra] [clang] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-28 Thread Florian Hahn via cfe-commits
@@ -8999,6 +8963,18 @@ void LoopVectorizationPlanner::adjustRecipesForReductions( LinkVPBB->insert(FMulRecipe, CurrentLink->getIterator()); VecOp = FMulRecipe; } else { +auto *Blend = dyn_cast(CurrentLink); fhahn wrote: Done, tha

[llvm] [clang-tools-extra] [compiler-rt] [clang] [flang] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-28 Thread Florian Hahn via cfe-commits
@@ -8378,9 +8357,8 @@ void VPRecipeBuilder::fixHeaderPhis() { } } -VPRecipeOrVPValueTy VPRecipeBuilder::handleReplication(Instruction *I, - VFRange &Range, - VPlan &Pl

[llvm] [flang] [compiler-rt] [clang-tools-extra] [clang] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-28 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/76090 >From 7c31c8bc2acf60bd50cb6d63944ee8d4946b9638 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 4 May 2023 21:33:24 +0100 Subject: [PATCH 1/4] [VPlan] Replace VPRecieOrVPValue with VP2VP recipe simplification

[llvm] [libcxx] [lldb] [compiler-rt] [flang] [libc] [clang] [lld] [clang-tools-extra] [VPlan] Implement cloning of VPlans. (PR #73158)

2024-01-28 Thread Florian Hahn via cfe-commits
fhahn wrote: @Enna1 thanks, should be fixed by 1b37e8087e1e1ecf5aadd8da536ee17dc21832e2. Bot should be back to green https://github.com/llvm/llvm-project/pull/73158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2024-01-28 Thread Amir Ayupov via cfe-commits
aaupov wrote: This issue with incremental builds is explicitly mentioned in [HowToAddABuilder](https://llvm.org/docs/HowToAddABuilder.html): > Use CCache and NOT incremental builds Using ccache materially improves average build times. Incremental builds can be slightly faster, but introduce th

[llvm] [clang] [NVPTX} Add builtin support for 'globaltimer' (PR #79765)

2024-01-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-ir Author: Joseph Huber (jhuber6) Changes Summary: This patch adds support for `globaltimer` to match `clock` and `clock64`. See the PTX ISA reference fro details. This patch does not implement the `hi` or `lo` variants fo

[llvm] [clang] [NVPTX} Add builtin support for 'globaltimer' (PR #79765)

2024-01-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/79765 Summary: This patch adds support for `globaltimer` to match `clock` and `clock64`. See the PTX ISA reference fro details. This patch does not implement the `hi` or `lo` variants for brevity as they can be obtained

[libc] [clang-tools-extra] [lldb] [flang] [compiler-rt] [libcxx] [llvm] [libunwind] [clang] [lld] [X86] Use RORX over SHR imm (PR #77964)

2024-01-28 Thread Bryce Wilson via cfe-commits
https://github.com/Bryce-MW updated https://github.com/llvm/llvm-project/pull/77964 >From d4c312b9dbf447d0a53dda0e6cdc482bd908430b Mon Sep 17 00:00:00 2001 From: Bryce Wilson Date: Fri, 12 Jan 2024 16:01:32 -0600 Subject: [PATCH 01/16] [X86] Use RORX over SHR imm --- llvm/lib/Target/X86/X86In

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2024-01-28 Thread Amir Ayupov via cfe-commits
aaupov wrote: Status of the builders that reported breakage: - [reverse-iteration](https://lab.llvm.org/buildbot/#/builders/54): https://lab.llvm.org/buildbot/#/builders/54/builds/8671 broken, https://lab.llvm.org/buildbot/#/builders/54/builds/8672 green, breakage was unrelated (unresolved tes

[libc] [clang-tools-extra] [lldb] [flang] [compiler-rt] [libcxx] [llvm] [libunwind] [clang] [lld] [X86] Use RORX over SHR imm (PR #77964)

2024-01-28 Thread Bryce Wilson via cfe-commits
https://github.com/Bryce-MW updated https://github.com/llvm/llvm-project/pull/77964 >From d4c312b9dbf447d0a53dda0e6cdc482bd908430b Mon Sep 17 00:00:00 2001 From: Bryce Wilson Date: Fri, 12 Jan 2024 16:01:32 -0600 Subject: [PATCH 01/16] [X86] Use RORX over SHR imm --- llvm/lib/Target/X86/X86In

[libc] [clang-tools-extra] [mlir] [lldb] [flang] [compiler-rt] [libcxx] [llvm] [libunwind] [clang] [lld] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #79032)

2024-01-28 Thread Mark de Wever via cfe-commits
mordante wrote: > @mordante I guess the PR missed LLVM18 release. I'll update the release notes > accordingly. Is that OK? Yes. It would have been nice to get this in LLVM 18, but I don't feel it's critical to backport it. (Especially since it's a C++26 only feature and I expect very few peop

[clang] 26648da - [ExtractAPI] Use StringRef::starts_with (NFC)

2024-01-28 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-01-28T10:47:05-08:00 New Revision: 26648daeb2ea1e9443d214e3923583efba346603 URL: https://github.com/llvm/llvm-project/commit/26648daeb2ea1e9443d214e3923583efba346603 DIFF: https://github.com/llvm/llvm-project/commit/26648daeb2ea1e9443d214e3923583efba346603.diff L

[clang] d1427fb - [Edit] Use StringRef::consume_back (NFC)

2024-01-28 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-01-28T10:47:03-08:00 New Revision: d1427fb6d0e1dbe3b7dbf46c26e43ce96b9b56d5 URL: https://github.com/llvm/llvm-project/commit/d1427fb6d0e1dbe3b7dbf46c26e43ce96b9b56d5 DIFF: https://github.com/llvm/llvm-project/commit/d1427fb6d0e1dbe3b7dbf46c26e43ce96b9b56d5.diff L

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2024-01-28 Thread via cfe-commits
lntue wrote: > These are all annotated builders. I tried triggering rebuilds with clean > build dir through buildbot UI but it didn't have an effect. I don't think > it's a reasonable expectation that every change must configure cleanly from > an existing build directory. I'm sorry but I also

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-28 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: @steakhal, @cor3ntin, @erichkeane https://github.com/llvm/llvm-project/pull/79764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Andrey Ali Khan Bolshakov (bolshakov-a) Changes `OpaqueValueExpr` doesn't necessarily contain a source expression. Particularly, after #78041, it is used to carry the type and the value kind of a non-type template argume

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-28 Thread Andrey Ali Khan Bolshakov via cfe-commits
https://github.com/bolshakov-a created https://github.com/llvm/llvm-project/pull/79764 `OpaqueValueExpr` doesn't necessarily contain a source expression. Particularly, after #78041, it is used to carry the type and the value kind of a non-type template argument of floating-point type or referr

[libcxx] [clang] [SemaCXX] Implement CWG2137 (list-initialization from objects of the same type) (PR #77768)

2024-01-28 Thread Dimitry Andric via cfe-commits
DimitryAndric wrote: FWIW I think I just hit this when building llvm itself (though 15.0.6) with a recent clang, and getting: ```text /wrkdirs/usr/ports/devel/llvm15/work-default/llvm-project-15.0.7.src/llvm/tools/sancov/sancov.cpp:532:44: error: chosen constructor is explicit in copy-initiali

[flang] [compiler-rt] [clang-tools-extra] [clang] [llvm] [libc] [lldb] [mlir] [libcxx] [AArch64] add intrinsic to generate a bfi instruction (PR #79672)

2024-01-28 Thread Rama Malladi via cfe-commits
RamaMalladiAWS wrote: > Hello. Can you explain why this is needed, as opposed to using the equivalent > shift/and/ors? Hi @davemgreen, one of AWS customers requested for such an intrinsic to be made available so that they could consume it their IR directly. The reasoning they had was to use 1

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-28 Thread via cfe-commits
@@ -6375,12 +6383,16 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation Loc, FieldDecl *Field) { ImmediateCallVisitor V(getASTContext()); if (!NestedDefaultChecking) V.TraverseDecl(Field); - if (V.HasImmediateCalls) { + if (V.HasImmediateCalls || InLifetimeEx

[libcxx] [flang] [libc] [clang-tools-extra] [clang] [llvm] [compiler-rt] [libunwind] [lld] [lldb] [X86] Use RORX over SHR imm (PR #77964)

2024-01-28 Thread Simon Pilgrim via cfe-commits
@@ -4216,6 +4217,95 @@ MachineSDNode *X86DAGToDAGISel::emitPCMPESTR(unsigned ROpc, unsigned MOpc, return CNode; } +// When the consumer of a right shift (arithmetic or logical) wouldn't notice +// the difference if the instruction was a rotate right instead (because the +//

[clang] [Clang][NFC] Remove TemplateArgumentList::OnStack (PR #79760)

2024-01-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) Changes This removes on-stack `TemplateArgumentList`'s. They were primary used to pass an `ArrayRef` to `Sema::getTemplateInstantiationArgs`, which had a `const TemplateArgumentList*` par

[clang] [Clang][NFC] Remove TemplateArgumentList::OnStack (PR #79760)

2024-01-28 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/79760 This removes on-stack `TemplateArgumentList`'s. They were primary used to pass an `ArrayRef` to `Sema::getTemplateInstantiationArgs`, which had a `const TemplateArgumentList*` parameter for the innermost temp

[clang] Mention compilation database generator tool `basset` (PR #79758)

2024-01-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (i-ky) Changes Its operation principles differ from Bear, which allows it to capture compile commands when Bear is not able to. Full disclosure: I am the author of basset. --- Full diff: https://github.com/llvm/llvm-project/pull/797

[clang] Mention compilation database generator tool `basset` (PR #79758)

2024-01-28 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] Mention compilation database generator tool `basset` (PR #79758)

2024-01-28 Thread via cfe-commits
https://github.com/i-ky created https://github.com/llvm/llvm-project/pull/79758 Its operation principles differ from Bear, which allows it to capture compile commands when Bear is not able to. Full disclosure: I am the author of basset. >From 3166a7ff57893e34963b51770f2e711a2b28e7b6 Mon Sep 17

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-28 Thread Carl Peto via cfe-commits
carlos4242 wrote: I think unit testing the bug fix to this function (the copy that is in Sema) is going to be nearly impossible. To prove the point, I tried hard coding the wrong return value for many types just now... ``` switch (Kind) { case tok::kw_bool: case tok::kw_short: case to

[lldb] [clang] [llvm] [clang-tools-extra] [compiler-rt] [mlir] [libc] [flang] [OpenMP] atomic compare weak : Parser & AST support (PR #79475)

2024-01-28 Thread via cfe-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/79475 >From 6614e517cf0888b4502efc0af974d1612fa7a822 Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Thu, 25 Jan 2024 10:37:20 -0600 Subject: [PATCH 1/2] Changes to Support Parsing & Sema of atomic comp

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-01-28 Thread Timm Baeder via cfe-commits
tbaederr wrote: For reference, the generated code with this patch looks like this: ```c++ #if defined(GET_EVAL_PROTO) || defined(GET_LINK_PROTO) bool emitConstFloat(const Floating &, const SourceInfo &); #endif #ifdef GET_LINK_IMPL bool ByteCodeEmitter::emitConstFloat(const Floating &A0, const S

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-01-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes The Float print type is backed by the Floating class, which in turn uses APFloat, which might heap-allocate memory, so might be expensive to copy. Add an 'AsRef' bit to the ArgType tablegen class, which defi

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-01-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79753 The Float print type is backed by the Floating class, which in turn uses APFloat, which might heap-allocate memory, so might be expensive to copy. Add an 'AsRef' bit to the ArgType tablegen class, which defines

[clang] 916bd7d - [clang][Interp][NFC] Remove Root record from opcode emitter

2024-01-28 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-01-28T16:15:22+01:00 New Revision: 916bd7d3bb42627f52e2f8ed2f87e08db4960a72 URL: https://github.com/llvm/llvm-project/commit/916bd7d3bb42627f52e2f8ed2f87e08db4960a72 DIFF: https://github.com/llvm/llvm-project/commit/916bd7d3bb42627f52e2f8ed2f87e08db4960a72.diff LO

[clang] 3545486 - [clang][Interp][NFC] Make some variables in the opcode emitter const

2024-01-28 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-01-28T16:15:21+01:00 New Revision: 354548621fdbaead4832361d26922b91488e401a URL: https://github.com/llvm/llvm-project/commit/354548621fdbaead4832361d26922b91488e401a DIFF: https://github.com/llvm/llvm-project/commit/354548621fdbaead4832361d26922b91488e401a.diff LO

[clang] [Clang][Sema] fix deducing auto& from const int in template parameters is impossible in partial specializations (PR #79733)

2024-01-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/79733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 70e2253 - [clang][Interp][NFC] Remove unnecessary braces

2024-01-28 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-01-28T14:36:27+01:00 New Revision: 70e22537549c65d69ae97a311d821c6459b32289 URL: https://github.com/llvm/llvm-project/commit/70e22537549c65d69ae97a311d821c6459b32289 DIFF: https://github.com/llvm/llvm-project/commit/70e22537549c65d69ae97a311d821c6459b32289.diff LO

[clang] [Clang][Sema] fix deducing auto& from const int in template parameters is impossible in partial specializations (PR #79733)

2024-01-28 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/79733 >From af0b28a28f0bf46b22521c0b39d5200eb94838dd Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 28 Jan 2024 15:12:01 +0800 Subject: [PATCH] [Clang][Sema] fix deducing auto& from const int in template parameters

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Add (de)serialization support for them, like we do for Floating values. Unfortunately I wasn't able to eliminate the code duplication coming from the signed/unsigned split here. I was trying to avoid adding

[clang] [clang][Interp] Support arbitrary precision constants (PR #79747)

2024-01-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79747 Add (de)serialization support for them, like we do for Floating values. Unfortunately I wasn't able to eliminate the code duplication coming from the signed/unsigned split here. I was trying to avoid adding a t

[clang] [clang-tools-extra] [Clang][Sema] fix deducing auto& from const int in template parameters is impossible in partial specializations (PR #79733)

2024-01-28 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > Oh wow, thanks for this fix! It will need a Changelog entry. > > Does it fixes any of these issues? #68885 This patch can't fix #68885. I have looked into the code and the root cause maybe different (probably relate to ExprConst, I'm not sure). Need more work on that issue. h

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-28 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/76361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-01-28 Thread Raoul Wols via cfe-commits
https://github.com/rwols updated https://github.com/llvm/llvm-project/pull/79746 >From 6f95aba8dbdf2ac807216597e5ab7fc62af29770 Mon Sep 17 00:00:00 2001 From: Raoul Wols Date: Sun, 28 Jan 2024 14:14:29 +0100 Subject: [PATCH] [clangd] Prevent printing huge initializer lists in hover definitions

[clang] [clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-01-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1b37e8087e1e1ecf5aadd8da536ee17dc21832e2 27bc0b64e17afce3196eb8d8415a8c61619dfae2 --

[clang] [clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-01-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Raoul Wols (rwols) Changes Previously we checked whether we were dealing with a large initializer using TokenBuffer::expandedTokens. However, TokenBuffer does not contain the tokens of the preamble. This causes large arrays imported from

[clang] [clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-01-28 Thread Raoul Wols via cfe-commits
https://github.com/rwols created https://github.com/llvm/llvm-project/pull/79746 Previously we checked whether we were dealing with a large initializer using TokenBuffer::expandedTokens. However, TokenBuffer does not contain the tokens of the preamble. This causes large arrays imported from an

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2024-01-28 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Hi @aaupov I think this did break the AMD Hip build bot (another annotated builder). Are you looking into the potential issue? https://github.com/llvm/llvm-project/pull/69133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-28 Thread via cfe-commits
@@ -6375,12 +6383,16 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation Loc, FieldDecl *Field) { ImmediateCallVisitor V(getASTContext()); if (!NestedDefaultChecking) V.TraverseDecl(Field); - if (V.HasImmediateCalls) { + if (V.HasImmediateCalls || InLifetimeEx

[clang] [llvm] [RISCV] Relax march string order constraint (PR #78120)

2024-01-28 Thread Piyou Chen via cfe-commits
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/78120 >From aaee7cfdea325459d68bc4e7205d7e25ca045d1a Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Sun, 14 Jan 2024 19:41:59 -0800 Subject: [PATCH 1/9] [RISCV] Relax march string order constraint --- clang/test/Driver/

[flang] [clang] [llvm] [compiler-rt] [clang-tools-extra] [VPlan] Replace VPRecipeOrVPValue with VP2VP recipe simplification. (PR #76090)

2024-01-28 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/76090 >From 7c31c8bc2acf60bd50cb6d63944ee8d4946b9638 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 4 May 2023 21:33:24 +0100 Subject: [PATCH 1/3] [VPlan] Replace VPRecieOrVPValue with VP2VP recipe simplification

[libcxx] [lld] [clang] [libc] [compiler-rt] [flang] [lldb] [clang-tools-extra] [llvm] [VPlan] Implement cloning of VPlans. (PR #73158)

2024-01-28 Thread via cfe-commits
Enna1 wrote: Hi @fhahn I think this change introduce a memory leak in `VPlan::duplicate()`, see https://lab.llvm.org/buildbot/#/builders/168/builds/18308/steps/10/logs/stdio Can you take a look? https://github.com/llvm/llvm-project/pull/73158 ___ cf

[libc] [clang-tools-extra] [lldb] [flang] [mlir] [llvm] [clang] [compiler-rt] [libcxx] [AArch64] add intrinsic to generate a bfi instruction (PR #79672)

2024-01-28 Thread David Green via cfe-commits
davemgreen wrote: Hello. Can you explain why this is needed, as opposed to using the equivalent shift/and/ors? https://github.com/llvm/llvm-project/pull/79672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [llvm] [CMake] Add a linker test for -Bsymbolic-functions to AddLLVM (PR #79539)

2024-01-28 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/79539 >From 024e972034d5e6a91157feeba30cc76368819b8f Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 25 Jan 2024 16:20:47 -0500 Subject: [PATCH] [CMake] Add a linker test for -Bsymbolic-functions to AddLLVM Add a li

[clang-tools-extra] [clangd] Attempt to fix https://github.com/clangd/clangd/issues/1536 (PR #79448)

2024-01-28 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > However, this doesn't seem to change the behavior in vscode: I applied the patch locally, and it does have _an_ effect on the steps from #1536 (running `Auto fix` with code containing multiple diagnostics selected): * before, it would show a message saying no fixes are

[clang] [clang][NFC] resolve redundant predicates (PR #79701)

2024-01-28 Thread Yingchi Long via cfe-commits
https://github.com/inclyc edited https://github.com/llvm/llvm-project/pull/79701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] resolve redundant predicates (PR #79701)

2024-01-28 Thread Yingchi Long via cfe-commits
https://github.com/inclyc approved this pull request. Looks like an NFC patch https://github.com/llvm/llvm-project/pull/79701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] resolve redundant predicates (PR #79701)

2024-01-28 Thread Yingchi Long via cfe-commits
https://github.com/inclyc edited https://github.com/llvm/llvm-project/pull/79701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang][Sema] fix deducing auto& from const int in template parameters is impossible in partial specializations (PR #79733)

2024-01-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/79733 >From 9834d065580a668f94f74adaf8507ca672e9118f Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 28 Jan 2024 15:12:01 +0800 Subject: [PATCH] [Clang][Sema] fix deducing auto& from const int in template parameters

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-28 Thread via cfe-commits
yronglin wrote: For this case, should > > Should we also dump the sub-expr which in `CXXDefaultArgExpr`: for example: > > Consider: > > I think this makes sense, but it can be a separate patch, unless it helps for > testing. Cool! Let's do it in a separate patch. > FYI, we prefer merge comm

[compiler-rt] [clang] [llvm] [mlir] [flang] [libc] [lldb] [clang-tools-extra] [libcxx] [AArch64] add intrinsic to generate a bfi instruction (PR #79672)

2024-01-28 Thread Yingchi Long via cfe-commits
https://github.com/inclyc edited https://github.com/llvm/llvm-project/pull/79672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang] [llvm] [mlir] [flang] [libc] [lldb] [clang-tools-extra] [libcxx] intrinsic to generate a bfi instruction (PR #79672)

2024-01-28 Thread Yingchi Long via cfe-commits
@@ -2558,6 +2558,14 @@ def : Pat<(rotr GPR32:$Rn, (i64 imm0_31:$imm)), def : Pat<(rotr GPR64:$Rn, (i64 imm0_63:$imm)), (EXTRXrri GPR64:$Rn, GPR64:$Rn, imm0_63:$imm)>; +def SDT_AArch64BFI_32bit : SDTypeProfile<1, 2, [SDTCisVT<0, i32>, SDTCisVT<1, i32>, +

[mlir] [llvm] [libc] [clang] [libcxx] [lldb] [clang-tools-extra] [compiler-rt] [flang] intrinsic to generate a bfi instruction (PR #79672)

2024-01-28 Thread Yingchi Long via cfe-commits
https://github.com/inclyc edited https://github.com/llvm/llvm-project/pull/79672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libc] [libcxx] [lldb] [clang] [compiler-rt] [clang-tools-extra] [mlir] [flang] [llvm] intrinsic to generate a bfi instruction (PR #79672)

2024-01-28 Thread Yingchi Long via cfe-commits
https://github.com/inclyc commented: Also I kindly wonder if this intrinsic is necessary for optimization/codegen. Why not prefer inline assembly? https://github.com/llvm/llvm-project/pull/79672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-28 Thread via cfe-commits
@@ -6375,12 +6383,16 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation Loc, FieldDecl *Field) { ImmediateCallVisitor V(getASTContext()); if (!NestedDefaultChecking) V.TraverseDecl(Field); - if (V.HasImmediateCalls) { + if (V.HasImmediateCalls || InLifetimeEx

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-28 Thread via cfe-commits
@@ -6375,12 +6383,16 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation Loc, FieldDecl *Field) { ImmediateCallVisitor V(getASTContext()); if (!NestedDefaultChecking) V.TraverseDecl(Field); - if (V.HasImmediateCalls) { + if (V.HasImmediateCalls || InLifetimeEx

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-28 Thread via cfe-commits
cor3ntin wrote: > Should we also dump the sub-expr which in `CXXDefaultArgExpr`: for example: > Consider: > > ``` > struct A { > A(); > ~A(); > }; > > typedef int vec3[3]; > vec3 &f(const A &a = A{}); > > void foo() { > for (auto e : f()) {} > } > ``` > > Current AST Dump: > > ``` > F

<    1   2