hahnjo wrote:
As far as I can tell from
https://github.com/llvm/llvm-project/pull/76774#issuecomment-1914177330 above,
the last push only changed the default value of
`LoadExternalSpecializationsLazily`. In that case, my test results from
vgvassilev wrote:
> > The newest version of this patch still doesn't work correctly. Switching
> > the new `LoadExternalSpecializationsLazily` to disabled by default (somehow
> > the argument didn't work on its own) instead crashes, most of the cases
> > involving `MultiOnDiskHashTable`. I
HighCommander4 wrote:
@sam-mccall review ping :)
I would particularly appreciate feedback on whether I should plan to set aside
some time to implement the "deep lookup optimization" (from [this
comment](https://reviews.llvm.org/D93829#4258101)), or whether the 2.5%
increase in index memory
Author: Balázs Kéri
Date: 2024-01-29T10:04:17+01:00
New Revision: 9f80ecb308c989523cc32d4256f7ab61c5b788d7
URL:
https://github.com/llvm/llvm-project/commit/9f80ecb308c989523cc32d4256f7ab61c5b788d7
DIFF:
https://github.com/llvm/llvm-project/commit/9f80ecb308c989523cc32d4256f7ab61c5b788d7.diff
https://github.com/balazske closed
https://github.com/llvm/llvm-project/pull/78284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haojian Wu (hokein)
Changes
Fixes #54051
This patch implements the C++20 feature -- CTAD for alias templates.
It is an initial patch, which covers most of pieces, the major missing piece is
to implement the associated constraints
https://github.com/hokein ready_for_review
https://github.com/llvm/llvm-project/pull/77890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 commented:
Thanks, the approach in this patch looks pretty good to me.
My only feedback is to encapsulate the "hard coding" into a function like:
```
Option TryConvertToRename(const Diag *D, const Fix *F)
```
because I can imagine in the future coming across
https://github.com/cor3ntin approved this pull request.
Missing changelog, otherwise LGTM
https://github.com/llvm/llvm-project/pull/79788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/77890
>From becb1bdebc8d10296a5c9f1af64ebae5ca9b68b7 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Wed, 24 Jan 2024 14:55:03 +0100
Subject: [PATCH] [clang] Implement Class Template Argument Deduction (CTAD)
for type
@@ -2561,6 +2567,70 @@ bool SIMemoryLegalizer::expandAtomicCmpxchgOrRmw(const
SIMemOpInfo ,
return Changed;
}
+bool SIMemoryLegalizer::GFX9InsertWaitcntForPreciseMem(MachineFunction ) {
+ const GCNSubtarget = MF.getSubtarget();
+ const SIInstrInfo *TII =
@@ -2561,6 +2567,70 @@ bool SIMemoryLegalizer::expandAtomicCmpxchgOrRmw(const
SIMemOpInfo ,
return Changed;
}
+bool SIMemoryLegalizer::GFX9InsertWaitcntForPreciseMem(MachineFunction ) {
arsenm wrote:
can you just make this happen as a consequence of the
https://github.com/arsenm updated
https://github.com/llvm/llvm-project/pull/74056
>From 9be777d5b39852cf3c0b2538fd5f712922672caa Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Fri, 1 Dec 2023 18:00:13 +0900
Subject: [PATCH 1/2] Reapply "InstCombine: Introduce
SimplifyDemandedUseFPClass""
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Change AfterPlacementOperator to a boolean. Also add SBPO_None for never
inserting a space before a left parenthesis and deprecate SBPO_Never, which
meant never inserting a space except when after
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/79796
Change AfterPlacementOperator to a boolean. Also add SBPO_None for never
inserting a space before a left parenthesis and deprecate SBPO_Never, which
meant never inserting a space except when after new/delete.
HighCommander4 wrote:
Linking to the issue this is seeking to address for reference:
https://github.com/clangd/clangd/issues/1589
https://github.com/llvm/llvm-project/pull/78454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
davemgreen wrote:
OK. We would not usually add intrinsics like this without a strong motivating
case, that could not be optimized in some other way. It is better to use target
independent options when available, and inline assembly is available as a
fallback if it is really needed. But I
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/77890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/77890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1720,6 +1720,12 @@ void StmtPrinter::VisitInitListExpr(InitListExpr* Node) {
OS << "{";
for (unsigned i = 0, e = Node->getNumInits(); i != e; ++i) {
if (i) OS << ", ";
+// TODO: There is duplicated functionality in APValue::printPretty.
+// Would be good to
@@ -138,15 +138,9 @@ std::string getNamespaceScope(const Decl *D) {
std::string printDefinition(const Decl *D, PrintingPolicy PP,
const syntax::TokenBuffer ) {
- if (auto *VD = llvm::dyn_cast(D)) {
-if (auto *IE = VD->getInit()) {
- //
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/79746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/79746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/77890
>From 8f7d83aed173688ff1413b7c4445d4576efee872 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Wed, 24 Jan 2024 14:55:03 +0100
Subject: [PATCH] [clang] Implement Class Template Argument Deduction (CTAD)
for type
https://github.com/pileghoff updated
https://github.com/llvm/llvm-project/pull/79588
>From 38d96aba5818091d48c40a46738f5adbf881b2a8 Mon Sep 17 00:00:00 2001
From: Pil Eghoff
Date: Fri, 26 Jan 2024 13:30:17 +0100
Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion
---
ChuanqiXu9 wrote:
> The newest version of this patch still doesn't work correctly. Switching the
> new `LoadExternalSpecializationsLazily` to disabled by default (somehow the
> argument didn't work on its own) instead crashes, most of the cases involving
> `MultiOnDiskHashTable`. I suspect
501 - 526 of 526 matches
Mail list logo
