[llvm] [clang] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-01-30 Thread Jun Wang via cfe-commits
@@ -167,6 +167,10 @@ def FeatureCuMode : SubtargetFeature<"cumode", "Enable CU wavefront execution mode" >; +def FeaturePreciseMemory jwanggit86 wrote: End user needs this, so a clang command-line option has been added. There was a lot discussion on this.

[llvm] [clang] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-01-30 Thread Jun Wang via cfe-commits
@@ -641,6 +644,9 @@ class SIMemoryLegalizer final : public MachineFunctionPass { bool expandAtomicCmpxchgOrRmw(const SIMemOpInfo &MOI, MachineBasicBlock::iterator &MI); + bool GFX9InsertWaitcntForPreciseMem(MachineFunction &MF); -

[clang-tools-extra] [compiler-rt] [clang] clang::Linkage #71049 (PR #80064)

2024-01-30 Thread via cfe-commits
https://github.com/harbandana reopened https://github.com/llvm/llvm-project/pull/80064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [clang-tools-extra] clang::Linkage #71049 (PR #80064)

2024-01-30 Thread via cfe-commits
https://github.com/harbandana closed https://github.com/llvm/llvm-project/pull/80064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][test] Add fPIC when building shared library (PR #80065)

2024-01-30 Thread via cfe-commits
https://github.com/jyu2-git approved this pull request. LGTM. Thanks for fixing. https://github.com/llvm/llvm-project/pull/80065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [clang-tools-extra] clang::Linkage #71049 (PR #80064)

2024-01-30 Thread via cfe-commits
https://github.com/harbandana reopened https://github.com/llvm/llvm-project/pull/80064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [compiler-rt] clang::Linkage #71049 (PR #80064)

2024-01-30 Thread via cfe-commits
https://github.com/harbandana closed https://github.com/llvm/llvm-project/pull/80064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang-tools-extra] [llvm] [libc] [clang] [flang] Refactor clang::Linkage (PR #80063)

2024-01-30 Thread via cfe-commits
https://github.com/Kaur-sukhmani updated https://github.com/llvm/llvm-project/pull/80063 >From c0ba8ba70d545ad0cbeb9d90c3fb0826681c3c5f Mon Sep 17 00:00:00 2001 From: Sukhmani Date: Wed, 31 Jan 2024 03:06:36 +0530 Subject: [PATCH 1/2] Refactor clang::Linkage --- clang/lib/AST/APValue.cpp | 9

[compiler-rt] [clang] [clang-tools-extra] clang::Linkage #71049 (PR #80064)

2024-01-30 Thread via cfe-commits
https://github.com/harbandana reopened https://github.com/llvm/llvm-project/pull/80064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-30 Thread Joseph Huber via cfe-commits
jhuber6 wrote: This is related to the discussions at the https://github.com/llvm/llvm-project/issues/77018 issue. https://github.com/llvm/llvm-project/pull/80066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[compiler-rt] [clang] [clang-tools-extra] clang::Linkage #71049 (PR #80064)

2024-01-30 Thread via cfe-commits
https://github.com/harbandana closed https://github.com/llvm/llvm-project/pull/80064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: The standard GPU compilation process embeds each intermediate object file into the host file at the `.llvm.offloading` section so it can be linked later. We also use a sepcial section called something

[llvm] [clang] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: The standard GPU compilation process embeds each intermediate object file into the host file at the `.llvm.offloading` section so it can be linked later. We also use a sepcial section called so

[clang] [llvm] [LinkerWrapper] Support relocatable linking for offloading (PR #80066)

2024-01-30 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/80066 Summary: The standard GPU compilation process embeds each intermediate object file into the host file at the `.llvm.offloading` section so it can be linked later. We also use a sepcial section called something lik

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-30 Thread Louis Dionne via cfe-commits
ldionne wrote: > I am concerned that `-fstdlib-hardening=` may not map to libstdc++ preferred > enabling mechanism cleanly. There is a non-zero probability that GCC folks > would not add an option that just passes a `-D...` to cc1. Then this driver > option will feel like a libc++ specific fea

[lldb] [llvm] [libcxxabi] [libcxx] [libc] [lld] [clang] [flang] [msan] Unpoison indirect outputs for userspace using memset for large operands (PR #79924)

2024-01-30 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/79924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] Refactor clang::Linkage (PR #80063)

2024-01-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 143b510a8fefb0d203c9ac7e036aa9967dd8a2ef c0ba8ba70d545ad0cbeb9d90c3fb0826681c3c5f --

[compiler-rt] [clang] [clang-tools-extra] clang::Linkage #71049 (PR #80064)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-compiler-rt-sanitizer Author: None (harbandana) Changes --- Patch is 187.54 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/80064.diff 4 Files Affected: - (modified)

[llvm] [clang] [clang-tools-extra] Refactor clang::Linkage (PR #80063)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Kaur-sukhmani) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/80063.diff 1 Files Affected: - (modified) clang/lib/AST/APValue.cpp (+8-1) ``diff diff --git a/clang/lib/AST/APValue.cpp b/clang/lib/AST/A

[compiler-rt] [clang] [clang-tools-extra] clang::Linkage #71049 (PR #80064)

2024-01-30 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[llvm] [clang] [clang-tools-extra] Refactor clang::Linkage (PR #80063)

2024-01-30 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[llvm] [clang] Revert "[RISCV] Relax march string order constraint" (PR #79976)

2024-01-30 Thread David Blaikie via cfe-commits
dwblaikie wrote: Sure - wrote down my thoughts here: https://discourse.llvm.org/t/prs-without-approvals-muddy-the-waters/76656 (my understanding is that this (waiting for approval after sending out a review - and that all PRs are reviews until we figure out a way to differentiate them) is exi

[clang] [llvm] [clang-tools-extra] Refactor clang::Linkage (PR #80063)

2024-01-30 Thread via cfe-commits
https://github.com/Kaur-sukhmani created https://github.com/llvm/llvm-project/pull/80063 None >From c0ba8ba70d545ad0cbeb9d90c3fb0826681c3c5f Mon Sep 17 00:00:00 2001 From: Sukhmani Date: Wed, 31 Jan 2024 03:06:36 +0530 Subject: [PATCH] Refactor clang::Linkage --- clang/lib/AST/APValue.cpp |

[clang] [clang] Represent array refs as `TemplateArgument::Declaration` (PR #80050)

2024-01-30 Thread Erich Keane via cfe-commits
erichkeane wrote: > @AaronBallman @zygoloid There probably is a missing ODR-use marking > somewhere, if you have a clue [#78041 > (comment)](https://github.com/llvm/llvm-project/pull/78041#issuecomment-1917571069) > > Alas we do not seem to have a repro for the chromium-reported issue which >

[clang] [clang] Represent array refs as `TemplateArgument::Declaration` (PR #80050)

2024-01-30 Thread via cfe-commits
cor3ntin wrote: @AaronBallman @zygoloid There probably is a missing ODR-use marking somewhere, if you have a clue https://github.com/llvm/llvm-project/pull/78041#issuecomment-1917571069 Alas we do not seem to have a repro for the chromium-reported issue which make debugging it difficult. http

[clang] [clang] Represent array refs as `TemplateArgument::Declaration` (PR #80050)

2024-01-30 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/80050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2024-01-30 Thread via cfe-commits
https://github.com/WenleiHe commented: FWIW we've tried this with sampling PGO in the past. While on paper this seems like an obvious thing to do, in reality aggressively tuning down opt level for cold functions can lead to regression since profile isn't always accurate. That said, as long as

[clang] [clang] Represent array refs as `TemplateArgument::Declaration` (PR #80050)

2024-01-30 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Are there any release-notes that should be reverted with this? or at least modified, since this is reverting stuff? Also, can you please add the tests/regressions that were found that have lead to this partial revert? https://github.com/llvm/llvm-proj

[llvm] [lldb] [lld] [libc] [libcxx] [flang] [libcxxabi] [clang] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/79924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [lldb] [lld] [libc] [libcxx] [flang] [libcxxabi] [clang] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Vitaly Buka via cfe-commits
@@ -4552,16 +4552,22 @@ struct MemorySanitizerVisitor : public InstVisitor { } if (!ElemTy->isSized()) return; -Value *SizeVal = - IRB.CreateTypeSize(MS.IntptrTy, DL.getTypeStoreSize(ElemTy)); +auto Size = DL.getTypeStoreSize(ElemTy); +Value *Siz

[llvm] [lldb] [lld] [libc] [libcxx] [flang] [libcxxabi] [clang] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Vitaly Buka via cfe-commits
@@ -4552,16 +4552,22 @@ struct MemorySanitizerVisitor : public InstVisitor { } if (!ElemTy->isSized()) return; -Value *SizeVal = - IRB.CreateTypeSize(MS.IntptrTy, DL.getTypeStoreSize(ElemTy)); +auto Size = DL.getTypeStoreSize(ElemTy); +Value *Siz

[llvm] [clang] [CMake][PGO] Add option for using an external project to generate profile data (PR #78879)

2024-01-30 Thread Amir Ayupov via cfe-commits
@@ -11,11 +15,11 @@ if(LLVM_BUILD_INSTRUMENTED) add_lit_testsuite(generate-profraw "Generating clang PGO data" ${CMAKE_CURRENT_BINARY_DIR}/pgo-data/ EXCLUDE_FROM_CHECK_ALL -DEPENDS clang clear-profraw ${CLANG_PERF_TRAINING_DEPS} +DEPENDS clang clear-profraw ${

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-30 Thread David Blaikie via cfe-commits
@@ -346,6 +346,14 @@ class CGDebugInfo { const FieldDecl *BitFieldDecl, const llvm::DIDerivedType *BitFieldDI, llvm::ArrayRef PreviousFieldsDI, const RecordDecl *RD); + // A cache that maps artificial inlined function names used for + // __builtin_verbose_trap to

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-30 Thread David Blaikie via cfe-commits
@@ -3424,6 +3445,26 @@ llvm::DIMacroFile *CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent, return DBuilder.createTempMacroFile(Parent, Line, FName); } +llvm::DILocation *CGDebugInfo::CreateTrapFailureMessageFor( dwblaikie wrote: There's currentl

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-30 Thread David Blaikie via cfe-commits
@@ -3424,6 +3445,26 @@ llvm::DIMacroFile *CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent, return DBuilder.createTempMacroFile(Parent, Line, FName); } +llvm::DILocation *CGDebugInfo::CreateTrapFailureMessageFor( +llvm::DebugLoc TrapLocation, StringRef Prefix,

[llvm] [clang] [CMake][PGO] Add option for using an external project to generate profile data (PR #78879)

2024-01-30 Thread Amir Ayupov via cfe-commits
@@ -2,7 +2,7 @@ set(CMAKE_BUILD_TYPE RELEASE CACHE STRING "") set(CLANG_ENABLE_BOOTSTRAP ON CACHE BOOL "") set(LLVM_ENABLE_PROJECTS "clang;lld" CACHE STRING "") -set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi" CACHE STRING "") +set(LLVM_ENABLE_RUNTIMES "compiler-rt;lib

[clang] [clang][CFG] Change child order in Reverse Post Order (RPO) iteration. (PR #80030)

2024-01-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand closed https://github.com/llvm/llvm-project/pull/80030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2c5a0d3 - [clang][CFG] Change child order in Reverse Post Order (RPO) iteration. (#80030)

2024-01-30 Thread via cfe-commits
Author: Yitzhak Mandelbaum Date: 2024-01-30T16:09:16-05:00 New Revision: 2c5a0d392592982bb9c73cbc10c64390b9045873 URL: https://github.com/llvm/llvm-project/commit/2c5a0d392592982bb9c73cbc10c64390b9045873 DIFF: https://github.com/llvm/llvm-project/commit/2c5a0d392592982bb9c73cbc10c64390b9045873.

[clang] [clang][CFG] Change child order in Reverse Post Order (RPO) iteration. (PR #80030)

2024-01-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/80030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CFG] Change child order in Reverse Post Order (RPO) iteration. (PR #80030)

2024-01-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/80030 >From 4ea1f14cfd835308064579554c3b8f5ce71ef0c0 Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Mon, 29 Jan 2024 21:26:27 + Subject: [PATCH] [clang][CFG] Change child order in Reverse Post Order (RPO) it

[llvm] [clang] [CMake][PGO] Add option for using an external project to generate profile data (PR #78879)

2024-01-30 Thread Amir Ayupov via cfe-commits
aaupov wrote: I'm in favor of this change especially in context of CSSPGO profiling (https://github.com/llvm/llvm-project/pull/79942) and BOLT LBR profiling (https://github.com/llvm/llvm-project/pull/69133). https://github.com/llvm/llvm-project/pull/78879 __

[clang] [clang][dataflow] Drop block-relative cap on worklist iterations. (PR #80033)

2024-01-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand closed https://github.com/llvm/llvm-project/pull/80033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a385c37 - [clang][dataflow] Drop block-relative cap on worklist iterations. (#80033)

2024-01-30 Thread via cfe-commits
Author: Yitzhak Mandelbaum Date: 2024-01-30T16:05:25-05:00 New Revision: a385c379f8694f42d1efb88bb8c5a53fccb6a664 URL: https://github.com/llvm/llvm-project/commit/a385c379f8694f42d1efb88bb8c5a53fccb6a664 DIFF: https://github.com/llvm/llvm-project/commit/a385c379f8694f42d1efb88bb8c5a53fccb6a664.

[llvm] [clang-tools-extra] [clang] [AArch64] Implement -fno-plt for SelectionDAG/GlobalISel (PR #78890)

2024-01-30 Thread Fangrui Song via cfe-commits
@@ -1293,8 +1293,19 @@ bool AArch64CallLowering::lowerCall(MachineIRBuilder &MIRBuilder, !Subtarget.noBTIAtReturnTwice() && MF.getInfo()->branchTargetEnforcement()) Opc = AArch64::BLR_BTI; - else + else { +// For an intrinsic call (e.g. memset),

[clang] [clang][dataflow] Drop block-relative cap on worklist iterations. (PR #80033)

2024-01-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/80033 >From 221ceddcca1f045725216c09432216440d1c6b63 Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Tue, 30 Jan 2024 16:52:13 + Subject: [PATCH] [clang][dataflow] Drop block-relative cap on worklist iteratio

[libcxx] [llvm] [lld] [flang] [clang] [lldb] [libc] [libcxxabi] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Florian Mayer via cfe-commits
https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/79924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Drop block-relative cap on worklist iterations. (PR #80033)

2024-01-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/80033 >From bb93306b6fdefa6d00622386af93d3baef251c2c Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Tue, 30 Jan 2024 16:52:13 + Subject: [PATCH] [clang][dataflow] Drop block-relative cap on worklist iteratio

[clang] [llvm] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2024-01-30 Thread Nemanja Ivanovic via cfe-commits
nemanjai wrote: Fix in https://github.com/llvm/llvm-project/pull/80058 https://github.com/llvm/llvm-project/pull/68919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2024-01-30 Thread Zaara Syeda via cfe-commits
https://github.com/syzaara updated https://github.com/llvm/llvm-project/pull/67999 >From dced11bd242aba08158a5a0a399b2b0ea7381a69 Mon Sep 17 00:00:00 2001 From: Zaara Syeda Date: Thu, 28 Sep 2023 15:01:56 -0400 Subject: [PATCH 1/8] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX This patc

[clang] 66ef690 - [OpenACC] Better recover during clause parsing

2024-01-30 Thread via cfe-commits
Author: erichkeane Date: 2024-01-30T12:48:16-08:00 New Revision: 66ef6900f9f3aa4fab9f6e36af04f775948cdf9d URL: https://github.com/llvm/llvm-project/commit/66ef6900f9f3aa4fab9f6e36af04f775948cdf9d DIFF: https://github.com/llvm/llvm-project/commit/66ef6900f9f3aa4fab9f6e36af04f775948cdf9d.diff LO

[clang] 0dd0cbd - [OpenACC] Implement 'wait' clause parsing.

2024-01-30 Thread via cfe-commits
Author: erichkeane Date: 2024-01-30T12:48:16-08:00 New Revision: 0dd0cbd324ad13dd7b91edf69a2ca66a6a208c80 URL: https://github.com/llvm/llvm-project/commit/0dd0cbd324ad13dd7b91edf69a2ca66a6a208c80 DIFF: https://github.com/llvm/llvm-project/commit/0dd0cbd324ad13dd7b91edf69a2ca66a6a208c80.diff LO

[clang] [Preprocessor] Fix __has_builtin for CPU ID functions (PR #80058)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nemanja Ivanovic (nemanjai) Changes My recent commit (67c1c1d) made the CPU ID builtins target-independent so they can be used on PPC as well. However, that had the unintended consequence of changing the behaviour of __has_builtin in that

[clang] [Preprocessor] Fix __has_builtin for CPU ID functions (PR #80058)

2024-01-30 Thread Nemanja Ivanovic via cfe-commits
https://github.com/nemanjai created https://github.com/llvm/llvm-project/pull/80058 My recent commit (67c1c1d) made the CPU ID builtins target-independent so they can be used on PPC as well. However, that had the unintended consequence of changing the behaviour of __has_builtin in that it repo

[clang-tools-extra] [clangd] Add 'apply all clangd fixes' and 'apply all '_' fixes' QuickFixes (PR #79867)

2024-01-30 Thread Tor Shepherd via cfe-commits
https://github.com/torshepherd updated https://github.com/llvm/llvm-project/pull/79867 >From 0ed7667a5b48064a492f7f125a4002912a35fec7 Mon Sep 17 00:00:00 2001 From: Tor Shepherd Date: Mon, 29 Jan 2024 11:44:25 -0500 Subject: [PATCH 1/2] initial cut --- clang-tools-extra/clangd/Diagnostics.cpp

[llvm] [compiler-rt] [clang-tools-extra] [flang] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-30 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/77020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [compiler-rt] [clang-tools-extra] [flang] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-30 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/6] [llvm-exegesis] Add middle half repetition mode This

[clang] [llvm] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2024-01-30 Thread Nemanja Ivanovic via cfe-commits
nemanjai wrote: Sorry, I'll put up a patch for review shortly to fix this problem. https://github.com/llvm/llvm-project/pull/68919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add 'apply all clangd fixes' and 'apply all '_' fixes' QuickFixes (PR #79867)

2024-01-30 Thread Tor Shepherd via cfe-commits
https://github.com/torshepherd edited https://github.com/llvm/llvm-project/pull/79867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add 'apply all clangd fixes' and 'apply all '_' fixes' QuickFixes (PR #79867)

2024-01-30 Thread Tor Shepherd via cfe-commits
https://github.com/torshepherd edited https://github.com/llvm/llvm-project/pull/79867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 235f1e7 - [Clang] Fix typo in __fprintf_chk Prototype (#80012)

2024-01-30 Thread via cfe-commits
Author: Jinsong Ji Date: 2024-01-30T15:22:45-05:00 New Revision: 235f1e74fe240e414718c64d05bafc01d34c32cb URL: https://github.com/llvm/llvm-project/commit/235f1e74fe240e414718c64d05bafc01d34c32cb DIFF: https://github.com/llvm/llvm-project/commit/235f1e74fe240e414718c64d05bafc01d34c32cb.diff LO

[clang] [Clang] Fix typo in __fprintf_chk Prototype (PR #80012)

2024-01-30 Thread Jinsong Ji via cfe-commits
https://github.com/jsji closed https://github.com/llvm/llvm-project/pull/80012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add 'apply all clangd fixes' and 'apply all '_' fixes' QuickFixes (PR #79867)

2024-01-30 Thread Tor Shepherd via cfe-commits
torshepherd wrote: Hmm I noticed another mini-issue. Ideally we shouldn't have a 'fix all clangd' quick fix if all of the issues come from the same source, only the 'fix all _' option https://github.com/llvm/llvm-project/pull/79867 ___ cfe-commits ma

[clang] [llvm] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #79911)

2024-01-30 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/79911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #79911)

2024-01-30 Thread Brendan Sweeney via cfe-commits
https://github.com/mehnadnerd updated https://github.com/llvm/llvm-project/pull/79911 >From bfa9b7043d89de78e66f5073c3b34b66defdc2f4 Mon Sep 17 00:00:00 2001 From: brs Date: Thu, 19 Oct 2023 17:16:45 -0500 Subject: [PATCH] [RISCV][MC] MC layer support for the experimental zalasr extension ---

[clang] [llvm] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2024-01-30 Thread Lei Huang via cfe-commits
lei137 wrote: Hi Aokamal, This maco was not taken into account in the implementation. Can you please open a bug and assign the issue to nemanjai? Thank-you for reporting this. Regards, Lei From: Aokamal ***@***.***> Date: Tuesday, January 30, 2024 at 10:30 AM To: llvm/llvm-project ***@***.**

[clang] [lldb] [clang-tools-extra] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-30 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: #80050 opened. Nevertheless, a reproducer for future work would be appreciated. https://github.com/llvm/llvm-project/pull/78041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [llvm] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #79911)

2024-01-30 Thread Craig Topper via cfe-commits
@@ -0,0 +1,70 @@ +# RUN: llvm-mc %s -triple=riscv32 -mattr=+experimental-zalasr -riscv-no-aliases -show-encoding \ topperc wrote: It's not very obvious from the test names, but I think the convention for the `-valid.s` tests is usually that the `rv32` test cont

[clang] [clang] Represent array refs as `TemplateArgument::Declaration` (PR #80050)

2024-01-30 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: @erichkeane, @cor3ntin https://github.com/llvm/llvm-project/pull/80050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Represent array refs as `TemplateArgument::Declaration` (PR #80050)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andrey Ali Khan Bolshakov (bolshakov-a) Changes This returns (probably temporarily) array-referring NTTP behavior to which was prior to #78041 because ~~I'm fed up~~ have no time to fix regressions. --- Full diff: https://github.com/llvm/

[clang] [llvm] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #79911)

2024-01-30 Thread Brendan Sweeney via cfe-commits
@@ -0,0 +1,66 @@ +//===-- RISCVInstrInfoZalasr.td - RISC-V 'Zalasr' instructions ---*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Ident

[clang] [clang] Represent array refs as `TemplateArgument::Declaration` (PR #80050)

2024-01-30 Thread Andrey Ali Khan Bolshakov via cfe-commits
https://github.com/bolshakov-a created https://github.com/llvm/llvm-project/pull/80050 This returns (probably temporarily) array-referring NTTP behavior to which was prior to #78041 because ~~I'm fed up~~ have no time to fix regressions. >From 0ccf1c9eeec7641dfdca9f8a06499512f98ba6da Mon Sep 1

[clang] [clang-tools-extra] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-30 Thread via cfe-commits
eaeltsin wrote: > @eaeltsin, could you try out [that > branch](https://github.com/bolshakov-a/llvm-project/tree/avoid_regressions)? @bolshakov-a yes, this patch makes the "undefined symbol" linker error go away. Will you proceed with submitting? https://github.com/llvm/llvm-project/pull/78

[clang] [llvm] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #79911)

2024-01-30 Thread Brendan Sweeney via cfe-commits
@@ -145,6 +145,7 @@ // CHECK-NOT: __riscv_zacas {{.*$}} // CHECK-NOT: __riscv_zalrsc {{.*$}} // CHECK-NOT: __riscv_zcmop {{.*$}} +// CHECK-NOT: __riscv_zalasr {{.*$}} mehnadnerd wrote: Done, there was another place in the same file I fixed https://github.com/

[clang] [llvm] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #79911)

2024-01-30 Thread Brendan Sweeney via cfe-commits
https://github.com/mehnadnerd updated https://github.com/llvm/llvm-project/pull/79911 >From 1612df14bf52085ed1dd1a1c815a0515930c9d6e Mon Sep 17 00:00:00 2001 From: brs Date: Thu, 19 Oct 2023 17:16:45 -0500 Subject: [PATCH] [RISCV][MC] MC layer support for the experimental zalasr extension ---

[clang] [llvm] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #79911)

2024-01-30 Thread Craig Topper via cfe-commits
@@ -145,6 +145,7 @@ // CHECK-NOT: __riscv_zacas {{.*$}} // CHECK-NOT: __riscv_zalrsc {{.*$}} // CHECK-NOT: __riscv_zcmop {{.*$}} +// CHECK-NOT: __riscv_zalasr {{.*$}} topperc wrote: this list is roughly in alphabetical order, can you alphabetize zalasr above

[clang] [llvm] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #79911)

2024-01-30 Thread Brendan Sweeney via cfe-commits
https://github.com/mehnadnerd updated https://github.com/llvm/llvm-project/pull/79911 >From 7f60b4aae0d75aabad7ecf159a7cd09420af6998 Mon Sep 17 00:00:00 2001 From: brs Date: Thu, 19 Oct 2023 17:16:45 -0500 Subject: [PATCH] [RISCV][MC] MC layer support for the experimental zalasr extension ---

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Nico Weber via cfe-commits
nico wrote: My bot is happy again, thanks. Please run tests before committing :) https://github.com/llvm/llvm-project/pull/80035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2024-01-30 Thread David Li via cfe-commits
david-xl wrote: > How does this relate to the existing `shouldOptimizeForSize(Function&, ...)` > and `shouldOptimizeForSize(MachineFunction&, ...)` APIs which appear to > provide similar functionality at a first glance. If they are the same, then > we should have a plan in place to cleanup and

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > i.e. it helped with Clang :: Preprocessor/predefined-arch-macros.c but not > with: > > Failed Tests (2): Clang :: Driver/amdgpu-macros.cl Clang :: > Driver/target-id-macros.cl Pushed a fix, `check-clang` passes on my machine now. Let me know if it's still broken. https://gi

[clang] 6fecfbc - [AMDGPU] Correctly exclude the HIP host from arch macros

2024-01-30 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-01-30T13:45:01-06:00 New Revision: 6fecfbc7b62f54bd633e83c22630d7c2a3e5741e URL: https://github.com/llvm/llvm-project/commit/6fecfbc7b62f54bd633e83c22630d7c2a3e5741e DIFF: https://github.com/llvm/llvm-project/commit/6fecfbc7b62f54bd633e83c22630d7c2a3e5741e.diff

[clang] [clang][dataflow] fix assert in `Environment::getResultObjectLocation` (PR #79608)

2024-01-30 Thread via cfe-commits
@@ -2735,6 +2735,41 @@ TEST(TransferTest, ResultObjectLocationForDefaultInitExpr) { }); } +// This test ensures that CXXOperatorCallExpr returning prvalues are correctly +// handled by the transfer functions, especially that `getResultObjectLocation` +// correctly retur

[clang] [clang][dataflow] fix assert in `Environment::getResultObjectLocation` (PR #79608)

2024-01-30 Thread via cfe-commits
@@ -2735,6 +2735,41 @@ TEST(TransferTest, ResultObjectLocationForDefaultInitExpr) { }); } +// This test ensures that CXXOperatorCallExpr returning prvalues are correctly +// handled by the transfer functions, especially that `getResultObjectLocation` +// correctly retur

[clang] [clang][dataflow] fix assert in `Environment::getResultObjectLocation` (PR #79608)

2024-01-30 Thread via cfe-commits
https://github.com/martinboehme approved this pull request. https://github.com/llvm/llvm-project/pull/79608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] fix assert in `Environment::getResultObjectLocation` (PR #79608)

2024-01-30 Thread via cfe-commits
@@ -2735,6 +2735,41 @@ TEST(TransferTest, ResultObjectLocationForDefaultInitExpr) { }); } +// This test ensures that CXXOperatorCallExpr returning prvalues are correctly +// handled by the transfer functions, especially that `getResultObjectLocation` +// correctly retur

[clang] [clang][dataflow] fix assert in `Environment::getResultObjectLocation` (PR #79608)

2024-01-30 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/79608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [libc] [compiler-rt] [flang] [libcxx] [openmp] [clang] [libcxxabi] [lldb] [libunwind] [lld] [mlir] [clang] static operators should evaluate object argument (PR #68485)

2024-01-30 Thread Tianlan Zhou via cfe-commits
SuperSodaSea wrote: By the way, maybe we should add a clangd label to this PR? https://github.com/llvm/llvm-project/pull/68485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > i.e. it helped with Clang :: Preprocessor/predefined-arch-macros.c but not > with: > > Failed Tests (2): Clang :: Driver/amdgpu-macros.cl Clang :: > Driver/target-id-macros.cl Thanks, seeing it locally now. I'll try to fix it quick and revert if it's not working soon. https

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Nico Weber via cfe-commits
nico wrote: i.e. it helped with Clang :: Preprocessor/predefined-arch-macros.c but not with: Failed Tests (2): Clang :: Driver/amdgpu-macros.cl Clang :: Driver/target-id-macros.cl https://github.com/llvm/llvm-project/pull/80035 ___ cfe-commits

[llvm] [clang-tools-extra] [libc] [compiler-rt] [flang] [libcxx] [openmp] [clang] [libcxxabi] [lldb] [libunwind] [lld] [mlir] [clang] static operators should evaluate object argument (PR #68485)

2024-01-30 Thread Tianlan Zhou via cfe-commits
SuperSodaSea wrote: https://github.com/SuperSodaSea/llvm-project/blob/1ceaae47b2b43fd8fa5512e20e0b32a7e8f4ab5b/clang-tools-extra/clangd/InlayHints.cpp#L660-L664 ```diff if (const CXXMethodDecl *Method = dyn_cast_or_null(Callee.Decl)) - if (Method->isInstance() && -

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Nico Weber via cfe-commits
nico wrote: This is with that change: http://45.33.8.238/linux/129493/step_7.txt https://github.com/llvm/llvm-project/pull/80035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > This seems to break tests: http://45.33.8.238/linux/129493/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Is it still broken? I pushed a fix because I'm pretty sure the problem was not passing `-nogpulib` `-nogpuinc` so the test runs on machin

[clang] [clang][dataflow] Drop block-relative cap on worklist iterations. (PR #80033)

2024-01-30 Thread via cfe-commits
https://github.com/martinboehme approved this pull request. https://github.com/llvm/llvm-project/pull/80033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #80035)

2024-01-30 Thread Nico Weber via cfe-commits
nico wrote: This seems to break tests: http://45.33.8.238/linux/129493/step_7.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/80035 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [llvm] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2024-01-30 Thread Aaron Liu via cfe-commits
@@ -3520,6 +3520,27 @@ def fpass_plugin_EQ : Joined<["-"], "fpass-plugin=">, MetaVarName<"">, HelpText<"Load pass plugin from a dynamic shared object file (only with new pass manager).">, MarshallingInfoStringVector>; +defm tocdata : BoolOption<"m","tocdata", + CodeGenO

[llvm] [clang] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2024-01-30 Thread Aaron Liu via cfe-commits
@@ -3520,6 +3520,27 @@ def fpass_plugin_EQ : Joined<["-"], "fpass-plugin=">, MetaVarName<"">, HelpText<"Load pass plugin from a dynamic shared object file (only with new pass manager).">, MarshallingInfoStringVector>; +defm tocdata : BoolOption<"m","tocdata", + CodeGenO

[llvm] [clang] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2024-01-30 Thread Aaron Liu via cfe-commits
@@ -3520,6 +3520,27 @@ def fpass_plugin_EQ : Joined<["-"], "fpass-plugin=">, MetaVarName<"">, HelpText<"Load pass plugin from a dynamic shared object file (only with new pass manager).">, MarshallingInfoStringVector>; +defm tocdata : BoolOption<"m","tocdata", + CodeGenO

[clang] 626fe71 - [Clang] Fix test failing on systems without ROCm installed

2024-01-30 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-01-30T13:17:02-06:00 New Revision: 626fe71fa5ed79cbd41b7b29582560d7adb1220e URL: https://github.com/llvm/llvm-project/commit/626fe71fa5ed79cbd41b7b29582560d7adb1220e DIFF: https://github.com/llvm/llvm-project/commit/626fe71fa5ed79cbd41b7b29582560d7adb1220e.diff

[libunwind] [compiler-rt] [libcxx] [clang-tools-extra] [libcxxabi] [libc] [lld] [openmp] [mlir] [flang] [llvm] [clang] [lldb] [clang] static operators should evaluate object argument (PR #68485)

2024-01-30 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: CC @zyn0217 as the original author of that test case and @HighCommander4 as the original reviewer. https://github.com/llvm/llvm-project/pull/68485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[flang] [compiler-rt] [mlir] [lldb] [openmp] [lld] [libunwind] [libcxx] [libcxxabi] [llvm] [clang] [clang-tools-extra] [libc] [clang] static operators should evaluate object argument (PR #68485)

2024-01-30 Thread Tianlan Zhou via cfe-commits
SuperSodaSea wrote: It seems that clangd doesn't like the new usage for the static operator of the CXXOperatorCallExpr, so the hint is misplaced. I'm looking into **clang-tools-extra/clangd/InlayHints.cpp** now... https://github.com/llvm/llvm-project/pull/68485

[clang] [llvm] [clang][DependencyScanner] Remove unused -ivfsoverlay files (PR #73734)

2024-01-30 Thread Jan Svoboda via cfe-commits
@@ -4991,18 +4991,17 @@ ASTReader::ASTReadResult ASTReader::readUnhashedControlBlockImpl( F->PragmaDiagMappings.insert(F->PragmaDiagMappings.end(), Record.begin(), Record.end()); break; -case HEADER_SEARCH_ENTRY_USAGE: -

<    1   2   3   4   5   6   7   >