https://github.com/farzonl closed
https://github.com/llvm/llvm-project/pull/81902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nico wrote:
Is this causing these crashes? http://45.33.8.238/linux/130945/step_7.txt
https://github.com/llvm/llvm-project/pull/71098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand closed https://github.com/llvm/llvm-project/pull/81918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Yitzhak Mandelbaum
Date: 2024-02-15T16:19:10-05:00
New Revision: 60cb09ba4f0ad6602483b40625a272eeebdcdc45
URL:
https://github.com/llvm/llvm-project/commit/60cb09ba4f0ad6602483b40625a272eeebdcdc45
DIFF:
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From 5fdaa384ebc962429950b79098dee0581c74f4f3 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
alexey-bataev wrote:
I already told, that you don't need the changes neither in sema, nor in stmt
class. All function changes are in codegen, no other changes are required.
https://github.com/llvm/llvm-project/pull/72417
___
cfe-commits mailing list
@@ -0,0 +1,8 @@
+# RUN: llvm-mc -triple=amdgcn -mcpu=gfx1100 -disassemble -show-encoding < %s |
FileCheck %s
+# RUN: llvm-mc -triple=amdgcn -mcpu=gfx1200 -disassemble -show-encoding < %s |
FileCheck %s
+
+# CHECK: v_dot2_bf16_bf16 v5, v1, v2, 0x42c8
rampitec
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Joseph Huber (jhuber6)
Changes
Summary:
This is a massive patch because it reworks the entire build and
everything that depends on it. This is not split up because various bots
would fail otherwise. I will attempt to describe the
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/81921
Summary:
This is a massive patch because it reworks the entire build and
everything that depends on it. This is not split up because various bots
would fail otherwise. I will attempt to describe the necessary
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang
Author: None (CLRN)
Changes
This fix partially reverts
https://github.com/llvm/llvm-project/commit/a0b6747804e46665ecfd00295b60432bfe1775b6.
The serialization part is restored to the state prior to the
https://github.com/cjdb approved this pull request.
https://github.com/llvm/llvm-project/pull/81918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/CLRN created https://github.com/llvm/llvm-project/pull/81919
This fix partially reverts
https://github.com/llvm/llvm-project/commit/a0b6747804e46665ecfd00295b60432bfe1775b6.
The serialization part is restored to the state prior to the mentioned commit
as it causing issue
ddpagan wrote:
Ping.
https://github.com/llvm/llvm-project/pull/72417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 01/16] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
https://github.com/llvm-beanz closed
https://github.com/llvm/llvm-project/pull/71098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yitzhak Mandelbaum (ymand)
Changes
The commit was itself a crash fix, but inadvertently changed the behavior for
unions, which results in crashes.
---
Full diff: https://github.com/llvm/llvm-project/pull/81918.diff
2 Files Affected:
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Author: Yitzhak Mandelbaum (ymand)
Changes
The commit was itself a crash fix, but inadvertently changed the behavior for
unions, which results in crashes.
---
Full diff: https://github.com/llvm/llvm-project/pull/81918.diff
2 Files
https://github.com/ymand created https://github.com/llvm/llvm-project/pull/81918
The commit was itself a crash fix, but inadvertently changed the behavior for
unions, which results in crashes.
>From 86f1b2d4dded22eef613b9d92a4010e16fd1edc7 Mon Sep 17 00:00:00 2001
From: Yitzhak Mandelbaum
https://github.com/DavidGoldman closed
https://github.com/llvm/llvm-project/pull/76466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: David Goldman
Date: 2024-02-15T15:53:37-05:00
New Revision: edfc859af89e44207bf499b5d702aa26a7357da4
URL:
https://github.com/llvm/llvm-project/commit/edfc859af89e44207bf499b5d702aa26a7357da4
DIFF:
https://github.com/llvm/llvm-project/commit/edfc859af89e44207bf499b5d702aa26a7357da4.diff
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/81897
>From 2779a90bb248bd48840a17f72cdc68691a397577 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 15 Feb 2024 10:36:45 -0800
Subject: [PATCH] [clang] Move `AvailabilityInfo` into AST library
Previously
@@ -0,0 +1,25 @@
+// RUN: %clang_cc1 %s -fsyntax-only -verify=expected,cpp
+// RUN: %clang_cc1 -x c %s -fsyntax-only -verify=expected,c
+
+// Ensure that we correctly parse _Alignas as an extension in C++.
+_Alignas(64) int i1;
+_Alignas(long long) int i2;
+int volatile
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
We support '_Alignas' from C11 as an extension in C++. However, we were not
correctly parsing its use in local variable declarations. This patch addresses
that issue.
---
Full diff:
https://github.com/farzonl updated
https://github.com/llvm/llvm-project/pull/81902
>From 97022e196fdad0f4aff9e628607e3c24bef863df Mon Sep 17 00:00:00 2001
From: Farzon Lotfi
Date: Thu, 15 Feb 2024 13:46:55 -0500
Subject: [PATCH] [HLSL] add BuiltinsHLSL and set it up as target builtins.
1.
@@ -1519,38 +1543,53 @@ struct CounterCoverageMappingBuilder
}
// Create Branch Region around condition.
-createBranchRegion(S->getCond(), BodyCount,
- subtractCounters(CondCount, BodyCount));
+if (!llvm::EnableSingleByteCoverage)
+
https://github.com/bogner requested changes to this pull request.
Hm, on further thought tying the "HLSL" intrinsics to the DirectX backend as
target intrinsics like this is probably going to shoot us in the foot with
respect to SPIR-V. I think we need to rethink this, and if we are going with
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/81611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -603,14 +626,69 @@ class SIGfx12CacheControl : public SIGfx11CacheControl {
SIAtomicAddrSpace AddrSpace, SIMemOp Op,
bool IsVolatile,
bool IsNonTemporal) const
@@ -603,14 +626,69 @@ class SIGfx12CacheControl : public SIGfx11CacheControl {
SIAtomicAddrSpace AddrSpace, SIMemOp Op,
bool IsVolatile,
bool IsNonTemporal) const
@@ -603,14 +626,69 @@ class SIGfx12CacheControl : public SIGfx11CacheControl {
SIAtomicAddrSpace AddrSpace, SIMemOp Op,
bool IsVolatile,
bool IsNonTemporal) const
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/78836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2024-02-15T23:45:56+04:00
New Revision: df81055955d564dccfd43a9faeb2f54c8c998f68
URL:
https://github.com/llvm/llvm-project/commit/df81055955d564dccfd43a9faeb2f54c8c998f68
DIFF:
Endilll wrote:
Windows CI didn't pass due to unrelated test failure. Landing.
https://github.com/llvm/llvm-project/pull/78836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall wrote:
> @rjmccall fixed feedback
>
> > You should handle compound assignments.
>
> I believe I already support compound assignments (and PrePostIncDec), if I am
> not missing something?
Ah, maybe you are, sorry. I was expecting it in `CGExpr.cpp` and forgot that
that code was
zmodem wrote:
I think @rnk has the deepest knowledge here.
Just to double check, when you say "Eliminate the static asan runtime", you
mean the use case it was supporting will still keep working, but in a different
way right?
https://github.com/llvm/llvm-project/pull/81677
Author: Timm Bäder
Date: 2024-02-15T20:17:51+01:00
New Revision: 6a8ab129300bfdf7cc58e023b06e0aada4458205
URL:
https://github.com/llvm/llvm-project/commit/6a8ab129300bfdf7cc58e023b06e0aada4458205
DIFF:
https://github.com/llvm/llvm-project/commit/6a8ab129300bfdf7cc58e023b06e0aada4458205.diff
Author: Chris Bieneman
Date: 2024-02-15T13:16:21-06:00
New Revision: a1155f68f5d5c7013ca1deb312a2e1e4f71ef544
URL:
https://github.com/llvm/llvm-project/commit/a1155f68f5d5c7013ca1deb312a2e1e4f71ef544
DIFF:
rjmccall wrote:
There's no such thing as "this is impossible to do". Clang, as the frontend,
is responsible for emitting IR that has gets the effect we want. If that means
contorting the IR we generate to do ugly things like memcpying into a
temporary, that's our life.
I am not surprised
haoNoQ wrote:
Fix merged, thanks!
https://github.com/llvm/llvm-project/pull/81808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haoNoQ closed https://github.com/llvm/llvm-project/pull/81903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Ryosuke Niwa
Date: 2024-02-15T11:12:17-08:00
New Revision: efad1885bfbda7f456e0e6e1db660fe55515a4b9
URL:
https://github.com/llvm/llvm-project/commit/efad1885bfbda7f456e0e6e1db660fe55515a4b9
DIFF:
https://github.com/llvm/llvm-project/commit/efad1885bfbda7f456e0e6e1db660fe55515a4b9.diff
barcharcraz wrote:
> This is long description, but it does not explain WHY. Could you please add
> some explanation there?
Sure, the reason is to greatly simplify how asan works on windows, and to fix a
bunch of bugs with asan+static CRT. Before this change there was a bunch of
code that
https://github.com/haoNoQ approved this pull request.
This probably works thanks!
https://github.com/llvm/llvm-project/pull/81903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Fixing the test in https://github.com/llvm/llvm-project/pull/81903
https://github.com/llvm/llvm-project/pull/81808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ryosuke Niwa (rniwa)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/81903.diff
1 Files Affected:
- (modified) clang/test/Analysis/Checkers/WebKit/uncounted-obj-arg.cpp (+1-1)
``diff
diff --git
https://github.com/bogner approved this pull request.
https://github.com/llvm/llvm-project/pull/81902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/81849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/81903
None
>From e3a45512e1a10c341b7172ddd3c2c8d42368110b Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 15 Feb 2024 10:58:13 -0800
Subject: [PATCH] Fix uncounted-obj-arg.cpp for Windows.
---
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/81902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -167,6 +167,10 @@ def FeatureCuMode : SubtargetFeature<"cumode",
"Enable CU wavefront execution mode"
>;
+def FeaturePreciseMemory
jwanggit86 wrote:
Thanks for the suggestion. It looks it would work. However, I'm not sure the
extra overhead is worth it
farzonl wrote:
create handle test:
```
D:\projects\llvm-project>python ..\directx-llvm-build\bin\llvm-lit.py -sv
clang\test\CodeGenHLSL\builtins\create_handle.hlsl
llvm-lit.py: D:\projects\llvm-project\llvm\utils\lit\lit\llvm\config.py:57:
note: using lit tools: C:\Program Files\Git\usr\bin
llvmbot wrote:
@llvm/pr-subscribers-backend-directx
@llvm/pr-subscribers-hlsl
Author: Farzon Lotfi (farzonl)
Changes
1. This change moves hlsl specific builtins from Builtins.td to BuiltinsHLSL.td.
2. Adds changes to the build system to build BuiltinsHLSL.td.
3. Setups HLSL builtins as
https://github.com/farzonl created
https://github.com/llvm/llvm-project/pull/81902
1. This change moves hlsl specific builtins from Builtins.td to BuiltinsHLSL.td.
2. Adds changes to the build system to build BuiltinsHLSL.td.
3. Setups HLSL builtins as TargetBuiltins.
>From
haoNoQ wrote:
Oh, this sort of stuff usually happens because the default target triple in the
test is the target triple for the host machine, so you'll get different
target-specific compiler behavior on different buildbots, in particular
`sizeof(unsigned long)` may be different. You can add
@@ -1519,38 +1543,53 @@ struct CounterCoverageMappingBuilder
}
// Create Branch Region around condition.
-createBranchRegion(S->getCond(), BodyCount,
- subtractCounters(CondCount, BodyCount));
+if (!llvm::EnableSingleByteCoverage)
+
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/78836
>From c931f87fdabe83e1e3507f0e52ebb3201a41cb82 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sat, 20 Jan 2024 12:04:32 +0300
Subject: [PATCH 1/5] [clang] Stop reporting unresolved issues in
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Cyndy Ishida (cyndyishida)
Changes
Previously this class was only used by ExtractAPI, but it will soon also be
needed by InstallAPI. This patch should not change availability behavior but
just centralizes the information next to what
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/81897
Previously this class was only used by ExtractAPI, but it will soon also be
needed by InstallAPI. This patch should not change availability behavior but
just centralizes the information next to what already
https://github.com/llvm-beanz closed
https://github.com/llvm/llvm-project/pull/81782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chris B
Date: 2024-02-15T12:29:22-06:00
New Revision: e82659fff2f07b5ea1d94e0d8bcb9c540d6bede1
URL:
https://github.com/llvm/llvm-project/commit/e82659fff2f07b5ea1d94e0d8bcb9c540d6bede1
DIFF:
https://github.com/llvm/llvm-project/commit/e82659fff2f07b5ea1d94e0d8bcb9c540d6bede1.diff
LOG:
https://github.com/dmpots approved this pull request.
https://github.com/llvm/llvm-project/pull/81782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -42,20 +49,20 @@ int16_t3 abs(int16_t3);
_HLSL_AVAILABILITY(shadermodel, 6.2)
_HLSL_BUILTIN_ALIAS(__builtin_elementwise_abs)
int16_t4 abs(int16_t4);
+#endif
-_HLSL_AVAILABILITY(shadermodel, 6.2)
+_HLSL_16BIT_AVAILABILITY(shadermodel, 6.2)
dmpots wrote:
erichkeane wrote:
> I wonder if this should be a part of the Targets in CodeGen instead of here?
Hrm, this is a bad idea as the rest of mangling is in AST, but having mangling
outside of AST seems to be the problem here.
https://github.com/llvm/llvm-project/pull/81893
@@ -14,6 +14,7 @@
#ifndef LLVM_CLANG_BASIC_TARGETINFO_H
#define LLVM_CLANG_BASIC_TARGETINFO_H
+#include "clang/AST/Attr.h"
erichkeane wrote:
Basic shouldn't be referencing AST (IIRC, it shouldn't reference anything but
basic or llvm), this ends up being an
https://github.com/erichkeane commented:
I wonder if this should be a part of the Targets in CodeGen instead of here?
https://github.com/llvm/llvm-project/pull/81893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/81893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
> @rniwa the test you modified in this change seems to be failing on at least
> one bot. Can you take a look or revert if you need time to investigate?
>
> https://lab.llvm.org/buildbot/#/builders/123/builds/25095
Oh, interesting. I suppose this is due to:
```
# | error:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 8bda8cfae6aa3c32cca7997ab64771e6a78f3e61
81ff9395020405dfb123ac6872839432583e067f --
ellishg wrote:
LGTM, but I'm less familiar with the clang coverage code. So I'll give others
some time to accept.
https://github.com/llvm/llvm-project/pull/75425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
@llvm/pr-subscribers-clang-codegen
Author: Alexandros Lamprineas (labrinea)
Changes
Before this patch all of the 'target', 'target_version' and 'target_clones'
attributes were sharing a common mangling logic across different targets.
https://github.com/labrinea created
https://github.com/llvm/llvm-project/pull/81893
Before this patch all of the 'target', 'target_version' and 'target_clones'
attributes were sharing a common mangling logic across different targets.
However we would like to differenciate this logic,
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/81874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Erich Keane
Date: 2024-02-15T10:10:05-08:00
New Revision: 24144d726fefefb0245eb1c2700606002355f4fe
URL:
https://github.com/llvm/llvm-project/commit/24144d726fefefb0245eb1c2700606002355f4fe
DIFF:
https://github.com/llvm/llvm-project/commit/24144d726fefefb0245eb1c2700606002355f4fe.diff
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Piotr Zegar (PiotrZSL)
Changes
Properly ignore parentheses in bitwise operators.
Closes #81515
---
Full diff: https://github.com/llvm/llvm-project/pull/81890.diff
3 Files Affected:
- (modified)
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/81890
Properly ignore parentheses in bitwise operators.
Closes #81515
>From 3b8defafd16cd83e86c9922d7527217a470734a3 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Thu, 15 Feb 2024 17:53:49 +
Subject: [PATCH]
Author: Vlad Serebrennikov
Date: 2024-02-15T20:58:44+03:00
New Revision: 8bda8cfae6aa3c32cca7997ab64771e6a78f3e61
URL:
https://github.com/llvm/llvm-project/commit/8bda8cfae6aa3c32cca7997ab64771e6a78f3e61
DIFF:
@@ -885,16 +885,19 @@ bool Sema::DiagnoseUninstantiableTemplate(SourceLocation
PointOfInstantiation,
/// that the template parameter 'PrevDecl' is being shadowed by a new
/// declaration at location Loc. Returns true to indicate that this is
/// an error, and false otherwise.
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/79683
>From 0d4a6d155b5d70970b63f4337507098ea938f627 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 16 Jan 2024 08:05:33 -0500
Subject: [PATCH] Reapply "[Clang][Sema] Diagnose function/variable
https://github.com/bogner approved this pull request.
https://github.com/llvm/llvm-project/pull/81782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -42,20 +49,20 @@ int16_t3 abs(int16_t3);
_HLSL_AVAILABILITY(shadermodel, 6.2)
_HLSL_BUILTIN_ALIAS(__builtin_elementwise_abs)
int16_t4 abs(int16_t4);
+#endif
-_HLSL_AVAILABILITY(shadermodel, 6.2)
+_HLSL_16BIT_AVAILABILITY(shadermodel, 6.2)
llvm-beanz
@@ -0,0 +1,6 @@
+// RUN: %clang_cc1 -fsyntax-only -verify=c23 -std=c23 %s -Wpre-c2x-compat
+// RUN: %clang_cc1 -fsyntax-only -verify=c17 -std=c17 %s
+
+
AaronBallman wrote:
```suggestion
```
https://github.com/llvm/llvm-project/pull/73099
@@ -1382,6 +1382,20 @@ void DeclSpec::Finish(Sema , const PrintingPolicy
) {
ThreadStorageClassSpec = TSCS_unspecified;
ThreadStorageClassSpecLoc = SourceLocation();
}
+if (S.getLangOpts().C23 &&
+getConstexprSpecifier() ==
@@ -8569,6 +8571,37 @@ static bool checkForConflictWithNonVisibleExternC(Sema
, const T *ND,
return false;
}
+static bool CheckC23ConstexprVarType(Sema , SourceLocation VarLoc,
+ QualType T) {
+
+ if (T->isVariableArrayType()) {
+
@@ -0,0 +1,296 @@
+// RUN: %clang_cc1 -std=c2x -verify -triple x86_64 -pedantic -Wno-conversion
-Wno-constant-conversion -Wno-div-by-zero %s
+
+// Check that constexpr only applies to variables.
+constexpr void f0() {} // expected-error {{'constexpr' can only be used in
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/73099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13823,7 +13869,9 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr
*Init, bool DirectInit) {
VDecl->setStorageClass(SC_Extern);
// C99 6.7.8p4. All file scoped initializers need to be constant.
-if (!getLangOpts().CPlusPlus && !VDecl->isInvalidDecl())
@@ -8569,6 +8571,37 @@ static bool checkForConflictWithNonVisibleExternC(Sema
, const T *ND,
return false;
}
+static bool CheckC23ConstexprVarType(Sema , SourceLocation VarLoc,
+ QualType T) {
+
+ if (T->isVariableArrayType()) {
+
@@ -0,0 +1,86 @@
+// RUN: %clang_cc1 -std=c2x -verify -triple x86_64 -pedantic -Wno-conversion
-Wno-constant-conversion %s
AaronBallman wrote:
```suggestion
// RUN: %clang_cc1 -std=c23 -verify -triple x86_64 -pedantic -Wno-conversion
-Wno-constant-conversion
@@ -0,0 +1,296 @@
+// RUN: %clang_cc1 -std=c2x -verify -triple x86_64 -pedantic -Wno-conversion
-Wno-constant-conversion -Wno-div-by-zero %s
+
+// Check that constexpr only applies to variables.
+constexpr void f0() {} // expected-error {{'constexpr' can only be used in
@@ -2487,14 +2487,19 @@ bool VarDecl::mightBeUsableInConstantExpressions(const
ASTContext ) const {
if (!getType().isConstant(C) || getType().isVolatileQualified())
return false;
- // In C++, const, non-volatile variables of integral or enumeration types
- // can be
@@ -9237,6 +9282,22 @@ static FunctionDecl *CreateNewFunctionDecl(Sema
, Declarator ,
FunctionDecl *NewFD = nullptr;
bool isInline = D.getDeclSpec().isInlineSpecified();
+ ConstexprSpecKind ConstexprKind = D.getDeclSpec().getConstexprSpecifier();
+ if (ConstexprKind ==
@@ -1862,6 +1862,17 @@ class StringLiteral final
llvm_unreachable("Unsupported character width!");
}
+ // Get code unit but preserve sign info.
+ int64_t getCodeUnitS(size_t I, uint64_t BitWidth) const {
AaronBallman wrote:
CC @cor3ntin @tahonermann
dyung wrote:
@rniwa the test you modified in this change seems to be failing on at least one
bot. Can you take a look or revert if you need time to investigate?
https://lab.llvm.org/buildbot/#/builders/123/builds/25095
https://github.com/llvm/llvm-project/pull/81808
@@ -885,16 +885,19 @@ bool Sema::DiagnoseUninstantiableTemplate(SourceLocation
PointOfInstantiation,
/// that the template parameter 'PrevDecl' is being shadowed by a new
/// declaration at location Loc. Returns true to indicate that this is
/// an error, and false otherwise.
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/81874
>From 35700522a658571e2abad279f327f4160fdb6c9d Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Thu, 15 Feb 2024 08:41:58 -0800
Subject: [PATCH 1/3] [OpenACC][NFC] Implement basic OpenACC Sema
infrastructure
LW-archlinux wrote:
Commit 75f0d40507ea3f7c99dd3250ff0fbe6dab341910 breaks build for a multilib
32-bit clang build.
See https://github.com/llvm/llvm-project/issues/81880
https://github.com/llvm/llvm-project/pull/81227
___
cfe-commits mailing list
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 46122082a61ef5bb2871d2d9158739133ad0e113
2b4b7d8cbc02d44eb1c0302f9d92e42ef8d9aff4 --
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/81874
>From 35700522a658571e2abad279f327f4160fdb6c9d Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Thu, 15 Feb 2024 08:41:58 -0800
Subject: [PATCH 1/2] [OpenACC][NFC] Implement basic OpenACC Sema
infrastructure
101 - 200 of 374 matches
Mail list logo
