wangpc-pp wrote:
Can this be tested? I don't know what the affects are.
https://github.com/llvm/llvm-project/pull/82152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
> > > > > [do not merge] [runtime-cxxmodules] Rework our lazy template
> > > > > specialization deserialization mechanism
> > > > > [root-project/root#14495](https://github.com/root-project/root/pull/14495)
> > > >
> > > >
> > > > From
> > > >
https://github.com/francisvm approved this pull request.
https://github.com/llvm/llvm-project/pull/82152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chuanqi Xu
Date: 2024-02-18T15:15:28+08:00
New Revision: 1ecbab56dcbb78268c8d19af34a50591f90b12a0
URL:
https://github.com/llvm/llvm-project/commit/1ecbab56dcbb78268c8d19af34a50591f90b12a0
DIFF:
https://github.com/llvm/llvm-project/commit/1ecbab56dcbb78268c8d19af34a50591f90b12a0.diff
vgvassilev wrote:
> > > > [do not merge] [runtime-cxxmodules] Rework our lazy template
> > > > specialization deserialization mechanism
> > > > [root-project/root#14495](https://github.com/root-project/root/pull/14495)
> > >
> > >
> > > From
> > >
ChuanqiXu9 wrote:
> > > [do not merge] [runtime-cxxmodules] Rework our lazy template
> > > specialization deserialization mechanism
> > > [root-project/root#14495](https://github.com/root-project/root/pull/14495)
> >
> >
> > From
> >
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-backend-risc-v
@llvm/pr-subscribers-clang-codegen
Author: Kuba (Brecka) Mracek (kubamracek)
Changes
For Embedded Swift, let's unblock building for RISC-V boards (e.g. ESP32-C6).
This isn't trying to add full RISC-V support to
https://github.com/kubamracek created
https://github.com/llvm/llvm-project/pull/82152
For Embedded Swift, let's unblock building for RISC-V boards (e.g. ESP32-C6).
This isn't trying to add full RISC-V support to Swift / Embedded Swift, it's
just fixing the immediate blocker (not having
vgvassilev wrote:
> > [do not merge] [runtime-cxxmodules] Rework our lazy template specialization
> > deserialization mechanism
> > [root-project/root#14495](https://github.com/root-project/root/pull/14495)
>
> From
>
ChuanqiXu9 wrote:
> [do not merge] [runtime-cxxmodules] Rework our lazy template specialization
> deserialization mechanism root-project/root#14495
>From https://github.com/root-project/root/pull/14495, I see there is new reply
>saying the testing is actually fine. Do you think we still need
ChuanqiXu9 wrote:
@iains @mizvekov ping~
https://github.com/llvm/llvm-project/pull/75894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
(This is another example that the github review can't work well with the
reverted patches...)
@mordante I think you can add `// REQUIRES: x86-registered-target` to the test
if @kaz7 can't respond quickly. It will skip the test on targets other than
x86. And it should keep
@@ -5097,6 +5099,22 @@ class CoroutineSuspendExpr : public Expr {
return static_cast(SubExprs[SubExpr::Operand]);
}
+ SuspendReturnType getSuspendReturnType() const {
+auto *SuspendExpr = getSuspendExpr();
+assert(SuspendExpr);
+
+auto SuspendType =
@@ -232,16 +250,74 @@ static LValueOrRValue
emitSuspendExpression(CodeGenFunction , CGCoroData
auto *NullPtr = llvm::ConstantPointerNull::get(CGF.CGM.Int8PtrTy);
auto *SaveCall = Builder.CreateCall(CoroSave, {NullPtr});
+ const auto AwaitSuspendCanThrow =
+
@@ -1396,9 +1478,18 @@ static bool simplifySuspendPoint(CoroSuspendInst
*Suspend,
if (!SubFn)
return false;
- // Does not refer to the current coroutine, we cannot do anything with it.
- if (SubFn->getFrame() != CoroBegin)
-return false;
+ auto Frame =
@@ -5038,6 +5038,8 @@ class CoroutineSuspendExpr : public Expr {
OpaqueValueExpr *OpaqueValue = nullptr;
public:
+ enum SuspendReturnType { SuspendVoid, SuspendBool, SuspendHandle };
ChuanqiXu9 wrote:
nit: Add a comment to explain that the return type of
https://github.com/ChuanqiXu9 commented:
Thanks. This looks much better now.
Given the CoroAwaitSuspendInst is lowered before splitting coroutines, I think
we don't need to handle it specially in `CoroSplit` any more.
https://github.com/llvm/llvm-project/pull/79712
@@ -2013,6 +2104,10 @@ splitCoroutine(Function , SmallVectorImpl
,
buildCoroutineFrame(F, Shape, MaterializableCallback);
replaceFrameSizeAndAlignment(Shape);
+ IRBuilder<> Builder(M.getContext());
ChuanqiXu9 wrote:
```suggestion
IRBuilder<>
@@ -380,66 +380,7 @@ static Expr *maybeTailCall(Sema , QualType RetType, Expr
*E,
// __builtin_coro_resume so that the cleanup code are not inserted in-between
// the resume call and return instruction, which would interfere with the
// musttail call contract.
-
@@ -167,6 +167,47 @@ class CoroCloner {
} // end anonymous namespace
+// FIXME:
+// Lower the intrinisc earlier if coroutine frame doesn't escape
ChuanqiXu9 wrote:
```suggestion
// Lower the intrinisc in CoroEarly phase if coroutine frame doesn't escape
```
@@ -232,16 +250,74 @@ static LValueOrRValue
emitSuspendExpression(CodeGenFunction , CGCoroData
auto *NullPtr = llvm::ConstantPointerNull::get(CGF.CGM.Int8PtrTy);
auto *SaveCall = Builder.CreateCall(CoroSave, {NullPtr});
+ const auto AwaitSuspendCanThrow =
+
@@ -338,6 +414,71 @@ static QualType getCoroutineSuspendExprReturnType(const
ASTContext ,
}
#endif
+llvm::Function *
+CodeGenFunction::generateAwaitSuspendWrapper(Twine const ,
+ Twine const ,
+
@@ -232,16 +250,74 @@ static LValueOrRValue
emitSuspendExpression(CodeGenFunction , CGCoroData
auto *NullPtr = llvm::ConstantPointerNull::get(CGF.CGM.Int8PtrTy);
auto *SaveCall = Builder.CreateCall(CoroSave, {NullPtr});
+ const auto AwaitSuspendCanThrow =
+
@@ -173,19 +173,36 @@ static bool ResumeStmtCanThrow(const Stmt *S) {
return false;
}
+static bool AwaitSuspendStmtCanThrow(const Stmt *S) {
+ return ResumeStmtCanThrow(S);
+}
+
// Emit suspend expression which roughly looks like:
//
// auto && x = CommonExpr();
//
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/79712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/72050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
I'd like to land this in 2 weeks if no more comments come in.
https://github.com/llvm/llvm-project/pull/80687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/81985
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -657,10 +657,61 @@ static llvm::cl::opt
"instead of libm complex operations"),
llvm::cl::init(false));
+/// Return a string containing the given Fortran intrinsic name
+/// with the type of its arguments specified in
https://github.com/ChuanqiXu9 requested changes to this pull request.
This is not wanted. While we have a policy to revert patches if the patches
break existing codes, the C++20 modules support in clangd is literally broken:
https://github.com/clangd/clangd/issues/1293
Also the ability to
ChuanqiXu9 wrote:
@sam-mccall ping~. Let's see if we can make it in clang19.
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang
Author: David Tellenbach (dtellenbach)
Changes
Fix an issue that produces a wrong coverage mapping when using binary
conditional operators as show in the example below.
Before this patch:
```
1| 1|int
https://github.com/dtellenbach created
https://github.com/llvm/llvm-project/pull/82141
Fix an issue that produces a wrong coverage mapping when using binary
conditional operators as show in the example below.
Before this patch:
```
1| 1|int binary_cond(int x) {
2| 1| x = x
https://github.com/farzonl updated
https://github.com/llvm/llvm-project/pull/81190
>From 586ee65c5e820365a6fd150d7f246fbfa679ec3e Mon Sep 17 00:00:00 2001
From: Farzon Lotfi
Date: Thu, 8 Feb 2024 11:08:59 -0500
Subject: [PATCH] [HLSL] Implementation of dot intrinsic This change implements
https://github.com/SimplyDanny updated
https://github.com/llvm/llvm-project/pull/81420
From 34f24456bfe44720e72119c847ab54b181977361 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Sun, 11 Feb 2024 17:04:12 +0100
Subject: [PATCH] [clang-tidy] Add fix-its to
jhuber6 wrote:
Tested this one a few machines and it works as expected after some final tweaks.
FYI @jplehr and @Artem-B, this will change the CMake configuration required for
building and testing on the build bots. The new expected way to test each one
respectively would be the following
```
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From 63e4205a9f5cc3ea8a4ce0730b01d78b6c9bde42 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
@@ -3218,6 +3218,21 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions
, ArgList ,
bool IsIndexHeaderMap = false;
bool IsSysrootSpecified =
Args.hasArg(OPT__sysroot_EQ) || Args.hasArg(OPT_isysroot);
+
+ // Expand a leading `=` to the sysroot if one was passed
@@ -0,0 +1,43 @@
+//===--- DesignatedInitializers.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
Author: Danny Mösch
Date: 2024-02-17T19:37:39+01:00
New Revision: 5023fd09b43e9b7eee390a8552db7ebce6e2b15c
URL:
https://github.com/llvm/llvm-project/commit/5023fd09b43e9b7eee390a8552db7ebce6e2b15c
DIFF:
https://github.com/llvm/llvm-project/commit/5023fd09b43e9b7eee390a8552db7ebce6e2b15c.diff
@@ -3229,16 +3244,7 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions
, ArgList ,
IsIndexHeaderMap ? frontend::IndexHeaderMap : frontend::Angled;
bool IsFramework = A->getOption().matches(OPT_F);
-std::string Path = A->getValue();
-
-if
@@ -3218,6 +3218,21 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions
, ArgList ,
bool IsIndexHeaderMap = false;
bool IsSysrootSpecified =
Args.hasArg(OPT__sysroot_EQ) || Args.hasArg(OPT_isysroot);
+
+ // Expand a leading `=` to the sysroot if one was passed
@@ -3218,6 +3218,21 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions
, ArgList ,
bool IsIndexHeaderMap = false;
bool IsSysrootSpecified =
Args.hasArg(OPT__sysroot_EQ) || Args.hasArg(OPT_isysroot);
+
+ // Expand a leading `=` to the sysroot if one was passed
@@ -3218,6 +3218,21 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions
, ArgList ,
bool IsIndexHeaderMap = false;
bool IsSysrootSpecified =
Args.hasArg(OPT__sysroot_EQ) || Args.hasArg(OPT_isysroot);
+
+ // Expand a leading `=` to the sysroot if one was passed
@@ -3218,6 +3218,21 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions
, ArgList ,
bool IsIndexHeaderMap = false;
bool IsSysrootSpecified =
Args.hasArg(OPT__sysroot_EQ) || Args.hasArg(OPT_isysroot);
+
+ // Expand a leading `=` to the sysroot if one was passed
mordante wrote:
@kaz7 ping, can you have a look at the patch, I really like to reland this
patch.
https://github.com/llvm/llvm-project/pull/76451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Artem Tyurin (agentcooper)
Changes
Fixes #73399.
I initially tried to create a new `EntityKind` enum case to represent constants
as it makes it easier to use `Entity.getKind()` with the diagnostic message.
But in the end I've decided
https://github.com/agentcooper created
https://github.com/llvm/llvm-project/pull/82109
Fixes #73399.
I initially tried to create a new `EntityKind` enum case to represent constants
as it makes it easier to use `Entity.getKind()` with the diagnostic message.
But in the end I've decided
5chmidti wrote:
I'm closing this because it is not a good way to solve this. IMO, a good
approach would be to let users write the diagnostic severity they want to have
for all or for specific diagnostics groups in their clangd config file (like
described above). I've opened clangd/clangd#1937
https://github.com/5chmidti closed
https://github.com/llvm/llvm-project/pull/75706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/81506
>From 52b239153b2fc4f52e889ad2044daa6ed5cbc836 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 12 Feb 2024 17:44:38 +0300
Subject: [PATCH 01/11] Initial implementation
---
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/81506
>From 52b239153b2fc4f52e889ad2044daa6ed5cbc836 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 12 Feb 2024 17:44:38 +0300
Subject: [PATCH 01/10] Initial implementation
---
mgorny wrote:
I'm sorry for being late to the party but what's the rationale for removing
support for building manpages without myst-parser, that FWICS isn't used for
manpages at all? I don't see any answer neither in the commit message, nor in
this thread. It really feels like you've just
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny
55 matches
Mail list logo
