[clang] Reland "[clang][modules] Print library module manifest path." (PR #82160)

2024-02-27 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @mordante if we want this for 18, we need to land and backport it in this week. https://github.com/llvm/llvm-project/pull/82160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [cfi][CodeGen] Call SetLLVMFunctionAttributes{, ForDefinition} on __cf… (PR #78253)

2024-02-27 Thread Pavel Kosov via cfe-commits
kpdev wrote: @AaronBallman @kongy Hi! Could you please take a look at this patch? https://github.com/llvm/llvm-project/pull/78253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-02-27 Thread Mingming Liu via cfe-commits
minglotus-6 wrote: New changes since last review besides clang-formats 1. Merged profile format change from main branch. 2. In instrumentation pass, emit unsupported warnings for non-ELF object file formats. - Updated vtable_profile.ll and add vtable_prof_unsupported.ll as test cases.

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-02-27 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #83124)

2024-02-27 Thread via cfe-commits
https://github.com/mahtohappy updated https://github.com/llvm/llvm-project/pull/83124 >From 7f6bbd2a9e5ab162b0efb5c6dcca91e1d83a0bce Mon Sep 17 00:00:00 2001 From: mahtohappy Date: Tue, 27 Feb 2024 03:13:51 -0800 Subject: [PATCH] [Clang][Sema] placement new initializes typedef array with

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow a variable declaration in a trivial function. (PR #82291)

2024-02-27 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/82291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4d04a40 - [alpha.webkit.UncountedCallArgsChecker] Allow a variable declaration in a trivial function. (#82291)

2024-02-27 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-02-27T22:25:55-08:00 New Revision: 4d04a40adb68f284350831911a658715134c66d8 URL: https://github.com/llvm/llvm-project/commit/4d04a40adb68f284350831911a658715134c66d8 DIFF: https://github.com/llvm/llvm-project/commit/4d04a40adb68f284350831911a658715134c66d8.diff

[clang] Disable FTZ/DAZ when compiling shared libraries by default. (PR #80475)

2024-02-27 Thread Matt Arsenault via cfe-commits
arsenm wrote: > So overall, the practical effect of the `denormal-fp-math` attribute being > set incorrectly doesn't appear to matter. It matters more for AMDGPU, where we need to care because some instructions just don't respect denormals. We legalize some operations differently depending

[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

2024-02-27 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [transforms] Inline simple variadic functions (PR #81058)

2024-02-27 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm commented: Title should be rephrased; this doesn't have anything to do with inlining https://github.com/llvm/llvm-project/pull/81058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-02-27 Thread Tony Tye via cfe-commits
t-tye wrote: I am not clear why new functions need to be added for this, as I think there are existing functions that already do this. https://github.com/llvm/llvm-project/pull/79236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [InstallAPI] Hookup Input files & basic ASTVisitor (PR #82552)

2024-02-27 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/82552 >From a7d0c1cf15764ee2ccbeb609fbaf014fdbde81b1 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Wed, 21 Feb 2024 14:56:02 -0800 Subject: [PATCH] [InstallAPI] Hookup Input files & basic ASTVisitor This

[clang] [OpenMP] Parse and Sema support for declare target in local scope (PR #83223)

2024-02-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sandeep Kosuri (sandeepkosuri) Changes - adds Parse and Sema support for the `declare target` directive inside a function scope. --- Full diff: https://github.com/llvm/llvm-project/pull/83223.diff 5 Files Affected: - (modified)

[clang] [OpenMP] Parse and Sema support for declare target in local scope (PR #83223)

2024-02-27 Thread Sandeep Kosuri via cfe-commits
https://github.com/sandeepkosuri created https://github.com/llvm/llvm-project/pull/83223 - adds Parse and Sema support for the `declare target` directive inside a function scope. >From cbf1b4409e379309ae3d942b3dbec0964b9ee0d1 Mon Sep 17 00:00:00 2001 From: Sandeep Kosuri Date: Tue, 27 Feb

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #83124)

2024-02-27 Thread via cfe-commits
mahtohappy wrote: @shafik I'm not aware of which cases it was catching before, I was hoping testing will reveal those testcases. I agree with your thinking that we might be breaking something and and don't have test coverage for it. I'll leave this condition as it is and add a separate check

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #83124)

2024-02-27 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Can you explain which cases the `if (!ArraySize)` condition was catching before and why the change does not effect those cases? My fear is that we are breaking other cases but we don't have test coverage for those cases and we are missing those breaks.

[clang] [Clang][HTO] Add clang attribute for propagating llvm-level information (PR #83059)

2024-02-27 Thread William Moses via cfe-commits
https://github.com/wsmoses reopened https://github.com/llvm/llvm-project/pull/83059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][HTO] Add clang attribute for propagating llvm-level information (PR #83059)

2024-02-27 Thread William Moses via cfe-commits
wsmoses wrote: Hm actually reopening, for some reason the metadata isn't being pushed at O0. https://github.com/llvm/llvm-project/pull/83059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][DebugInfo] Use CGDebugInfo::createFile in CGDebugInfo::CreateCompileUnit (#83174) (PR #83175)

2024-02-27 Thread David Blaikie via cfe-commits
dwblaikie wrote: Some test coverage would be good to help demonstrate the issue/fix https://github.com/llvm/llvm-project/pull/83175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add 'apply all clangd fixes' and 'apply all '_' fixes' QuickFixes (PR #79867)

2024-02-27 Thread Tor Shepherd via cfe-commits
https://github.com/torshepherd updated https://github.com/llvm/llvm-project/pull/79867 >From 94dee94becb7d79b087e183754602e08a5c4669d Mon Sep 17 00:00:00 2001 From: Tor Shepherd Date: Mon, 29 Jan 2024 11:44:25 -0500 Subject: [PATCH] [clangd] Add fix-all CodeActions ---

[clang] [attributes][analyzer] Generalize [[clang::suppress]] to declarations. (PR #80371)

2024-02-27 Thread Artem Dergachev via cfe-commits
haoNoQ wrote: Yes I like this perspective: "Schrödinger's need-for-pre-commit-approval" isn't a great way to communicate  I'll be more clear in the future. https://github.com/llvm/llvm-project/pull/80371 ___ cfe-commits mailing list

[clang] [clang][analyzer]Add C++ polymorphic ptr arithmetic checker (PR #82977)

2024-02-27 Thread Artem Dergachev via cfe-commits
haoNoQ wrote: Hi! I wonder if path-sensitive analysis is useful here at all. If you simply warn every time you see arithmetic performed on a pointer to a class with at least one virtual method, wouldn't that be quite accurate most of the time? At a glance, such operation only makes sense when

[clang] [llvm] [RISCV] Remove experimental from Zacas. (PR #83195)

2024-02-27 Thread Craig Topper via cfe-commits
topperc wrote: > LGTM. > > Will it be in LLVM 18? Or we need more time to examine its robustness? The bar for LLVM 18 is pretty high at this point. I doubt this qualifies. https://github.com/llvm/llvm-project/pull/83195 ___ cfe-commits mailing list

[clang] [llvm] [RISCV] Remove experimental from Zacas. (PR #83195)

2024-02-27 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp approved this pull request. LGTM. Will it be in LLVM 18? Or we need more time to examine its robustness? https://github.com/llvm/llvm-project/pull/83195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

2024-02-27 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,165 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 +; RUN: llc < %s -mtriple=i686-unknown-unknown --relocation-model=pic -enable-tlsdesc | FileCheck %s --check-prefix=X86 +; RUN: llc < %s

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

2024-02-27 Thread Fangrui Song via cfe-commits
@@ -18515,17 +18515,17 @@ X86TargetLowering::LowerGlobalAddress(SDValue Op, SelectionDAG ) const { return LowerGlobalOrExternal(Op, DAG, /*ForCall=*/false); } -static SDValue -GetTLSADDR(SelectionDAG , SDValue Chain, GlobalAddressSDNode *GA, - SDValue *InGlue,

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

2024-02-27 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,165 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 +; RUN: llc < %s -mtriple=i686-unknown-unknown --relocation-model=pic -enable-tlsdesc | FileCheck %s --check-prefix=X86 MaskRay wrote:

[clang] [InstallAPI] Hookup Input files & basic ASTVisitor (PR #82552)

2024-02-27 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/82552 >From b0cc1eeba893c24d5358cb49189da2e287daf972 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Wed, 21 Feb 2024 14:56:02 -0800 Subject: [PATCH 1/2] [InstallAPI] Hookup Input files & basic ASTVisitor This

[clang] [Driver][RISCV] Forward --no-relax option to linker for RISC-V on *BS… (PR #83216)

2024-02-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/83216 >From 4409a37ff160edb3c41c7650c181a5c9a60c397b Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Tue, 27 Feb 2024 21:07:09 -0500 Subject: [PATCH] [Driver][RISCV] Forward --no-relax option to linker for RISC-V on

[clang] [Driver][RISCV] Forward --no-relax option to linker for RISC-V on *BS… (PR #83216)

2024-02-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bfcf7a0707592ccc7fd9e805aeb36c4da3f315a6 e9dca00cb002d223b4148d648f4f31b4cfc31d63 --

[clang] [Driver][RISCV] Forward --no-relax option to linker for RISC-V on *BS… (PR #83216)

2024-02-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Brad Smith (brad0) Changes …D and Haiku Based on https://github.com/llvm/llvm-project/pull/76432 --- Full diff: https://github.com/llvm/llvm-project/pull/83216.diff 4 Files Affected: - (modified)

[clang] [Driver][RISCV] Forward --no-relax option to linker for RISC-V on *BS… (PR #83216)

2024-02-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/83216 …D and Haiku Based on https://github.com/llvm/llvm-project/pull/76432 >From e9dca00cb002d223b4148d648f4f31b4cfc31d63 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Tue, 27 Feb 2024 21:07:09 -0500 Subject:

[clang] [clang][dataflow] Correctly treat empty initializer lists for unions. (PR #82986)

2024-02-27 Thread Yitzhak Mandelbaum via cfe-commits
@@ -2392,14 +2392,88 @@ TEST(TransferTest, InitListExprAsUnion) { } F; public: - constexpr target() : F{nullptr} {} + constexpr target() : F{nullptr} { +int *null = nullptr; +F.b; // Make sure we reference 'b' so it is modeled. +

[clang] [clang][dataflow] Correctly treat empty initializer lists for unions. (PR #82986)

2024-02-27 Thread Yitzhak Mandelbaum via cfe-commits
@@ -2392,14 +2392,88 @@ TEST(TransferTest, InitListExprAsUnion) { } F; public: - constexpr target() : F{nullptr} {} + constexpr target() : F{nullptr} { +int *null = nullptr; +F.b; // Make sure we reference 'b' so it is modeled. +

[clang] [clang][dataflow] Correctly treat empty initializer lists for unions. (PR #82986)

2024-02-27 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/82986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Correctly treat empty initializer lists for unions. (PR #82986)

2024-02-27 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/82986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] fix host min/max in header (PR #82956)

2024-02-27 Thread Yaxun Liu via cfe-commits
@@ -1306,15 +1306,73 @@ float min(float __x, float __y) { return __builtin_fminf(__x, __y); } __DEVICE__ double min(double __x, double __y) { return __builtin_fmin(__x, __y); } -#if !defined(__HIPCC_RTC__) && !defined(__OPENMP_AMDGCN__) -__host__ inline static int min(int

[clang] [Driver] Allow -fbasic-block-address-map for AArch64 ELF (PR #82662)

2024-02-27 Thread Daniel Hoekwater via cfe-commits
https://github.com/dhoekwater closed https://github.com/llvm/llvm-project/pull/82662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e9e7aea - [Driver] Allow -fbasic-block-address-map for AArch64 ELF (#82662)

2024-02-27 Thread via cfe-commits
Author: Daniel Hoekwater Date: 2024-02-27T17:34:48-08:00 New Revision: e9e7aeadaf0ce9d66ff352856fd2d1005b0f7d74 URL: https://github.com/llvm/llvm-project/commit/e9e7aeadaf0ce9d66ff352856fd2d1005b0f7d74 DIFF:

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81418)

2024-02-27 Thread Nathan Chancellor via cfe-commits
nathanchance wrote: For what it's worth, this change adds several instances of `-Wenum-enum-conversion` for the Linux kernel: https://github.com/ClangBuiltLinux/linux/issues/2002. I assume this is intentional given the nature of the change as a whole but neither the tests nor the release

[clang] [InstallAPI] Hookup Input files & basic ASTVisitor (PR #82552)

2024-02-27 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/82552 >From b0cc1eeba893c24d5358cb49189da2e287daf972 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Wed, 21 Feb 2024 14:56:02 -0800 Subject: [PATCH 1/2] [InstallAPI] Hookup Input files & basic ASTVisitor This

[clang] [LLVM][DWARF] Enable pubnames for -glldb when expliti flag is passed (PR #83206)

2024-02-27 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo closed https://github.com/llvm/llvm-project/pull/83206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5." (PR #83214)

2024-02-27 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo closed https://github.com/llvm/llvm-project/pull/83214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dba2dd2 - Revert "[CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5." (#83214)

2024-02-27 Thread via cfe-commits
Author: Alexander Yermolovich Date: 2024-02-27T17:26:06-08:00 New Revision: dba2dd2c487d7bed7ad3b76a67fdfce464f0edbf URL: https://github.com/llvm/llvm-project/commit/dba2dd2c487d7bed7ad3b76a67fdfce464f0edbf DIFF:

[clang] bcbce80 - Revert "[HIP] fix host min/max in header (#82956)"

2024-02-27 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2024-02-27T20:19:07-05:00 New Revision: bcbce807d76a30388b366d14051c5f80e9724dab URL: https://github.com/llvm/llvm-project/commit/bcbce807d76a30388b366d14051c5f80e9724dab DIFF:

[clang] Revert "[CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5." (PR #83214)

2024-02-27 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/83214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][HTO] Add clang attribute for propagating llvm-level information (PR #83059)

2024-02-27 Thread William Moses via cfe-commits
wsmoses wrote: Okay, the AnnotateAttr doesn't create LLVM string attributes, it creates LLVM metadata, but that should sufice, closing. https://github.com/llvm/llvm-project/pull/83059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][HTO] Add clang attribute for propagating llvm-level information (PR #83059)

2024-02-27 Thread William Moses via cfe-commits
https://github.com/wsmoses closed https://github.com/llvm/llvm-project/pull/83059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5." (PR #83214)

2024-02-27 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM

[clang] Revert "[CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5." (PR #83214)

2024-02-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Alexander Yermolovich (ayermolo) Changes Reverts llvm/llvm-project#82840 --- Full diff: https://github.com/llvm/llvm-project/pull/83214.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/Clang.cpp (+3-4) -

[clang] [LLVM][DWARF] Enable pubnames for -glldb when expliti flag is passed (PR #83206)

2024-02-27 Thread Alexander Yermolovich via cfe-commits
ayermolo wrote: revert https://github.com/llvm/llvm-project/pull/83214 https://github.com/llvm/llvm-project/pull/83206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5." (PR #83214)

2024-02-27 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo created https://github.com/llvm/llvm-project/pull/83214 Reverts llvm/llvm-project#82840 >From 58007120dfbc69ccfdf04ae1eb71b30e3582b435 Mon Sep 17 00:00:00 2001 From: Alexander Yermolovich <43973793+ayerm...@users.noreply.github.com> Date: Tue, 27 Feb 2024 16:40:45

[clang] [LLVM][DWARF] Enable pubnames for -glldb when expliti flag is passed (PR #83206)

2024-02-27 Thread Alexander Yermolovich via cfe-commits
ayermolo wrote: > I don't know if this is correct. > > Maybe just add a triple to the problematic clang invocation for now and have > this reviewed by a local expert while trunk isn't broken? ok https://github.com/llvm/llvm-project/pull/83206 ___

[clang] [Clang][DebugInfo] Use CGDebugInfo::createFile in CGDebugInfo::CreateCompileUnit (#83174) (PR #83175)

2024-02-27 Thread Adrian Prantl via cfe-commits
@@ -628,9 +628,8 @@ void CGDebugInfo::CreateCompileUnit() { // file was specified with an absolute path. if (CSKind) CSInfo.emplace(*CSKind, Checksum); - llvm::DIFile *CUFile = DBuilder.createFile( - remapDIPath(MainFileName), remapDIPath(getCurrentDirname()),

[clang] [Clang][DebugInfo] Use CGDebugInfo::createFile in CGDebugInfo::CreateCompileUnit (#83174) (PR #83175)

2024-02-27 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl commented: Can you add a test for this? https://github.com/llvm/llvm-project/pull/83175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM][DWARF] Enable pubnames for -glldb when expliti flag is passed (PR #83206)

2024-02-27 Thread Nico Weber via cfe-commits
nico wrote: I don't know if this is correct. Maybe just add a triple to the problematic clang invocation for now and have this reviewed by a local expert while trunk isn't broken? https://github.com/llvm/llvm-project/pull/83206 ___ cfe-commits

[clang] [llvm] [Clang] Correct __builtin_dynamic_object_size for subobject types (PR #83204)

2024-02-27 Thread Bill Wendling via cfe-commits
https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/83204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5. (PR #82840)

2024-02-27 Thread Alexander Yermolovich via cfe-commits
ayermolo wrote: https://github.com/llvm/llvm-project/pull/83206 https://github.com/llvm/llvm-project/pull/82840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM][DWARF] Enable pubnames for -glldb when expliti flag is passed (PR #83206)

2024-02-27 Thread Alexander Yermolovich via cfe-commits
ayermolo wrote: Test passes on mac ![image](https://github.com/llvm/llvm-project/assets/43973793/61f4843c-63b3-4bc7-ba1f-67ea41a59c44) https://github.com/llvm/llvm-project/pull/83206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [LLVM][DWARF] Enable pubnames for -glldb when expliti flag is passed (PR #83206)

2024-02-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexander Yermolovich (ayermolo) Changes This is a fix for https://github.com/llvm/llvm-project/pull/82840. On mac tunning is by default LLDB. If the flag was passed in to clang after that PR it would not have been passed in by the driver.

[clang] [LLVM][DWARF] Enable pubnames for -glldb when expliti flag is passed (PR #83206)

2024-02-27 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo created https://github.com/llvm/llvm-project/pull/83206 This is a fix for https://github.com/llvm/llvm-project/pull/82840. On mac tunning is by default LLDB. If the flag was passed in to clang after that PR it would not have been passed in by the driver. >From

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5. (PR #82840)

2024-02-27 Thread Alexander Yermolovich via cfe-commits
ayermolo wrote: > It's been a few hours. Time to revert and analyze offline? I think I have a fix. Just takes forever to setup and build on my laptop to test it. Basically I think mac defaults to LLDB tuning, and test that fails explicitly passes the flag in.

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5. (PR #82840)

2024-02-27 Thread Nico Weber via cfe-commits
nico wrote: It's been a few hours. Time to revert and analyze offline? https://github.com/llvm/llvm-project/pull/82840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Correct __builtin_dynamic_object_size for subobject types (PR #83204)

2024-02-27 Thread Bill Wendling via cfe-commits
bwendling wrote: The first PR attempt was here: https://github.com/llvm/llvm-project/pull/78526 It was NACK'ed because it used the LLVM IR representation of the structure, which wasn't appropriate. To solve that issue, I chose to expand the `llvm.objectsize()` builtin to contain the size and

[clang] [llvm] [Clang] Correct __builtin_dynamic_object_size for subobject types (PR #83204)

2024-02-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-clang Author: Bill Wendling (bwendling) Changes The second argument of __builtin_dynamic_object_size controls whether it returns the size of the whole object or the closest surrounding object. For this struct:

[clang] [llvm] [MC/DC][Coverage] Loosen the limit of NumConds from 6 (PR #82448)

2024-02-27 Thread Alan Phipps via cfe-commits
@@ -1201,19 +1197,22 @@ void CodeGenPGO::emitMCDCCondBitmapUpdate(CGBuilderTy , const Expr *S, // Extract the ID of the condition we are setting in the bitmap. const auto = BranchStateIter->second; assert(Branch.ID >= 0 && "Condition has no ID!"); +

[clang] [llvm] [MC/DC][Coverage] Loosen the limit of NumConds from 6 (PR #82448)

2024-02-27 Thread Alan Phipps via cfe-commits
@@ -983,7 +979,7 @@ void CodeGenPGO::mapRegionCounters(const Decl *D) { // for most embedded applications. Setting a maximum value prevents the // bitmap footprint from growing too large without the user's knowledge. In // the future, this value could be adjusted with a

[clang] [compiler-rt] [llvm] [InstrProf] Single byte counters in coverage (PR #75425)

2024-02-27 Thread Petr Hosek via cfe-commits
@@ -1282,8 +1283,14 @@ class SegmentBuilder { // value for that area. // We add counts of the regions of the same kind as the active region // to handle the both situations. - if (I->Kind == Active->Kind) -Active->ExecutionCount +=

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow a variable declaration in a trivial function. (PR #82291)

2024-02-27 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82291 >From 0a8cfb11a601e7a6ec59489b8ac15c40136002b2 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 17 Feb 2024 18:12:16 -0800 Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Allow a variable

[clang] [compiler-rt] [llvm] [InstrProf] Single byte counters in coverage (PR #75425)

2024-02-27 Thread via cfe-commits
https://github.com/gulfemsavrun edited https://github.com/llvm/llvm-project/pull/75425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow a variable declaration in a trivial function. (PR #82291)

2024-02-27 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/82291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow a variable declaration in a trivial function. (PR #82291)

2024-02-27 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. LGTM, looks straightforward! https://github.com/llvm/llvm-project/pull/82291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/83077 >From d4384c5ac52596eeab512574111e499f230b7db7 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Sun, 25 Feb 2024 20:08:09 -0500 Subject: [PATCH] [HLSL] Implementation lerp intrinsic This is the start of

[clang] [compiler-rt] [llvm] [InstrProf] Single byte counters in coverage (PR #75425)

2024-02-27 Thread NAKAMURA Takumi via cfe-commits
@@ -1503,38 +1527,53 @@ struct CounterCoverageMappingBuilder } // Create Branch Region around condition. -createBranchRegion(S->getCond(), BodyCount, - subtractCounters(CondCount, BodyCount)); +if (!llvm::EnableSingleByteCoverage) +

[clang] [llvm] [RISCV] Remove experimental from Zacas. (PR #83195)

2024-02-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Craig Topper (topperc) Changes Document that we don't use the double compare and swap instructions due to ABI concerns. --- Patch is 21.20 KiB, truncated to 20.00 KiB below, full version:

[clang] [llvm] [RISCV] Remove experimental from Zacas. (PR #83195)

2024-02-27 Thread Craig Topper via cfe-commits
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/83195 Document that we don't use the double compare and swap instructions due to ABI concerns. >From 8ed68475b43008d9c7baff7f275026cc7ada5993 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Tue, 27 Feb 2024

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/83077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

2024-02-27 Thread Erich Keane via cfe-commits
@@ -2258,6 +2258,94 @@ class ExtractTypeForDeductionGuide } }; +// Build a deduction guide with the specified parameter types. +FunctionTemplateDecl * +buildDeductionGuide(Sema , TemplateDecl *OriginalTemplate, +TemplateParameterList *TemplateParams, +

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

2024-02-27 Thread Erich Keane via cfe-commits
@@ -10598,10 +10598,36 @@ QualType Sema::DeduceTemplateSpecializationFromInitializer( if (TemplateName.isDependent()) return SubstAutoTypeDependent(TSInfo->getType()); - // We can only perform deduction for class templates. + // We can only perform deduction for

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

2024-02-27 Thread Erich Keane via cfe-commits
@@ -10598,10 +10598,36 @@ QualType Sema::DeduceTemplateSpecializationFromInitializer( if (TemplateName.isDependent()) return SubstAutoTypeDependent(TSInfo->getType()); - // We can only perform deduction for class templates. + // We can only perform deduction for

[clang] [clang][fat-lto-objects] Make module flags match non-FatLTO pipelines (PR #83159)

2024-02-27 Thread Paul Kirth via cfe-commits
@@ -1036,7 +1041,8 @@ void EmitAssemblyHelper::RunOptimizationPipeline( if (!actionRequiresCodeGen(Action) && CodeGenOpts.VerifyModule) MPM.addPass(VerifierPass()); - if (Action == Backend_EmitBC || Action == Backend_EmitLL) { + if (Action == Backend_EmitBC || Action

[clang] Turn 'counted_by' into a type attribute and parse it into 'CountAttributedType' (PR #78000)

2024-02-27 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: No additional comments from me, if the other reviewers are happy, I'm happy with where this is/is going. https://github.com/llvm/llvm-project/pull/78000 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [InstallAPI] Hookup Input files & basic ASTVisitor (PR #82552)

2024-02-27 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/82552 >From b0cc1eeba893c24d5358cb49189da2e287daf972 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Wed, 21 Feb 2024 14:56:02 -0800 Subject: [PATCH] [InstallAPI] Hookup Input files & basic ASTVisitor This

[clang] [llvm] [openmp] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)

2024-02-27 Thread Ethan Luis McDonough via cfe-commits
https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/76587 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/18] Add profiling functions to libomptarget

[clang] [clang][test] Add test for incompatible cv-qualified reference types in conversion function template (PR #81950)

2024-02-27 Thread Duo Wang via cfe-commits
wdunicornpro wrote: @zygoloid Sorry about the abrupt ping but I figured you might have the best knowledge about that part of code. Do you have any thoughts on this? https://github.com/llvm/llvm-project/pull/81950 ___ cfe-commits mailing list

[clang] [Clang] [Sema] Handle `this` in `__restrict`-qualified member functions properly (PR #83187)

2024-02-27 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/83187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test] Add test for incompatible cv-qualified reference types in conversion function template (PR #81950)

2024-02-27 Thread Duo Wang via cfe-commits
https://github.com/wdunicornpro edited https://github.com/llvm/llvm-project/pull/81950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Allow -fbasic-block-address-map for AArch64 ELF (PR #82662)

2024-02-27 Thread Daniel Hoekwater via cfe-commits
https://github.com/dhoekwater updated https://github.com/llvm/llvm-project/pull/82662 >From 11c8f1f843de68c35e8e33f992765df1bbcdbfb9 Mon Sep 17 00:00:00 2001 From: Daniel Hoekwater Date: Thu, 22 Feb 2024 17:39:15 + Subject: [PATCH] [Driver] Allow -fbasic-block-address-map for AArch64 ELF

[clang] [Driver] Allow -fbasic-block-address-map for AArch64 ELF (PR #82662)

2024-02-27 Thread Daniel Hoekwater via cfe-commits
@@ -1,4 +1,5 @@ // RUN: %clang -### -target x86_64 -fbasic-block-address-map %s -S 2>&1 | FileCheck -check-prefix=CHECK-PRESENT %s +// RUN: %clang -### -target aarch64 -fbasic-block-address-map %s -S 2>&1 | FileCheck -check-prefix=CHECK-PRESENT %s dhoekwater

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5. (PR #82840)

2024-02-27 Thread Alexander Yermolovich via cfe-commits
ayermolo wrote: > Looks this breaks tests on macOS: http://45.33.8.238/macm1/79435/step_7.txt > > Please take a look and revert for now if it takes a while to fix. > Looks this breaks tests on macOS: http://45.33.8.238/macm1/79435/step_7.txt > > Please take a look and revert for now if it

[clang] [Clang] [Sema] Handle `__restrict`-qualified member functions properly (PR #83187)

2024-02-27 Thread via cfe-commits
Sirraide wrote: CC @shafik, @AaronBallman https://github.com/llvm/llvm-project/pull/83187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Handle `__restrict`-qualified member functions properly (PR #83187)

2024-02-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes When resolving the type of `this` inside a member function, we were attaching all qualifiers present on the member function to the class type and then making it a pointer; however, `__restrict`, unlike `const` and

[clang] [Clang] [Sema] Handle `__restrict`-qualified member functions properly (PR #83187)

2024-02-27 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/83187 When resolving the type of `this` inside a member function, we were attaching all qualifiers present on the member function to the class type and then making it a pointer; however, `__restrict`, unlike `const`

[clang] [llvm] Modify BoundsSan to improve debuggability (PR #65972)

2024-02-27 Thread Oskar Wirga via cfe-commits
oskarwirga wrote: > @oskarwirga I'd like to use this feature but without counter, preserving > ubsan IDs > > Also I think in the current the counter has limited use: in optimized code, > after inlining, it will have a lot of same ids, like 0, 1 from different > functions. > > So I propose

[clang] [llvm] Modify BoundsSan to improve debuggability (PR #65972)

2024-02-27 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: oskarwirga@ I'd like to use this feature but without counter, preserving ubsan IDs Also I think in the current the counter has limited use: in optimized code, after inlining, it will have a lot of same ids, like 0, 1 from different functions. So I propose to undo that part

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5. (PR #82840)

2024-02-27 Thread Nico Weber via cfe-commits
nico wrote: Looks this breaks tests on macOS: http://45.33.8.238/macm1/79435/step_7.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/82840 ___ cfe-commits mailing list

[clang] [clang] Extend define-target-os-macros to support XROS. (PR #82833)

2024-02-27 Thread via cfe-commits
github-actions[bot] wrote: @rohit-rao Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[clang] [clang] Extend define-target-os-macros to support XROS. (PR #82833)

2024-02-27 Thread Leonard Grey via cfe-commits
https://github.com/speednoisemovement closed https://github.com/llvm/llvm-project/pull/82833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e5ed7b6 - [clang] Extend define-target-os-macros to support XROS. (#82833)

2024-02-27 Thread via cfe-commits
Author: rohit-rao Date: 2024-02-27T15:23:00-05:00 New Revision: e5ed7b6e2fd368b722b6359556cd0125881e7638 URL: https://github.com/llvm/llvm-project/commit/e5ed7b6e2fd368b722b6359556cd0125881e7638 DIFF: https://github.com/llvm/llvm-project/commit/e5ed7b6e2fd368b722b6359556cd0125881e7638.diff

[clang] [compiler-rt] [llvm] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2024-02-27 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 converted_to_draft https://github.com/llvm/llvm-project/pull/66825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >