[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

2024-02-29 Thread Ryosuke Niwa via cfe-commits
@@ -171,6 +151,24 @@ class UncountedLocalVarsChecker std::optional IsUncountedPtr = isUncountedPtr(ArgType); if (IsUncountedPtr && *IsUncountedPtr) { + + ASTContext = V->getASTContext(); + for (DynTypedNodeList ancestors = ctx.getParents(*V);

[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

2024-02-29 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82229 >From fd171b82d03b29926984b5b835ad9c0ccf197536 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 19 Feb 2024 01:07:13 -0800 Subject: [PATCH 1/4] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object

[clang] [X86][AArch64][PowerPC] __builtin_cpu_supports accepts unknown options. (PR #83515)

2024-02-29 Thread via cfe-commits
https://github.com/DanielKristofKiss approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/83515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][doc] fix documentation for clang-format (PR #83415)

2024-02-29 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/83415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Don't do casting of atomic FP loads/stores in FE. (PR #83446)

2024-02-29 Thread Matt Arsenault via cfe-commits
@@ -1410,13 +1414,14 @@ RValue AtomicInfo::ConvertIntToValueOrAtomic(llvm::Value *IntVal, auto *ValTy = AsValue ? CGF.ConvertTypeForMem(ValueTy) : getAtomicAddress().getElementType(); -if (ValTy->isIntegerTy()) { -

[clang] [clang][Documentation] fix documentation for clang-format (PR #83415)

2024-02-29 Thread Owen Pan via cfe-commits
owenca wrote: Hi, you need to edit `clang/include/clang/Format/Format.h` and then run `clang/docs/tools/dump_format_style.py` to regenerate `clang/docs/ClangFormatStyleOptions.rst`. https://github.com/llvm/llvm-project/pull/83415 ___ cfe-commits

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

2024-02-29 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 012b697 - [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (#83288)

2024-02-29 Thread via cfe-commits
Author: Balázs Kéri Date: 2024-03-01T08:21:57+01:00 New Revision: 012b697e7c3633ae17639b086414fd6c02127810 URL: https://github.com/llvm/llvm-project/commit/012b697e7c3633ae17639b086414fd6c02127810 DIFF: https://github.com/llvm/llvm-project/commit/012b697e7c3633ae17639b086414fd6c02127810.diff

[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

2024-02-29 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82229 >From fd171b82d03b29926984b5b835ad9c0ccf197536 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 19 Feb 2024 01:07:13 -0800 Subject: [PATCH 1/3] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object

[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

2024-02-29 Thread Ryosuke Niwa via cfe-commits
@@ -70,15 +71,27 @@ bool isSingleton(const FunctionDecl *F); class TrivialFunctionAnalysis { public: /// \returns true if \p D is a "trivial" function. - bool isTrivial(const Decl *D) const { return isTrivialImpl(D, TheCache); } + bool isTrivial(const Decl *D) const { +

[clang] [FMV] Use lexicographic order of feature names when mangling. (PR #83464)

2024-02-29 Thread via cfe-commits
https://github.com/DanielKristofKiss approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/83464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Replace Style.isCpp() with IsCpp (PR #83533)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/83533.diff 5 Files Affected: - (modified) clang/lib/Format/FormatToken.h (+2-2) - (modified) clang/lib/Format/TokenAnnotator.cpp (+18-21) -

[clang] [clang-format][NFC] Replace Style.isCpp() with IsCpp (PR #83533)

2024-02-29 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/83533 None >From a643963e818a9c6c4abea93c15f8c48f7291a837 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 29 Feb 2024 23:07:58 -0800 Subject: [PATCH] [clang-format][NFC] Replace Style.isCpp() with IsCpp ---

[clang] [clang][Sema] Warn on self move for inlined static cast (PR #76646)

2024-02-29 Thread Timm Baeder via cfe-commits
@@ -18843,17 +18843,26 @@ void Sema::DiagnoseSelfMove(const Expr *LHSExpr, const Expr *RHSExpr, LHSExpr = LHSExpr->IgnoreParenImpCasts(); RHSExpr = RHSExpr->IgnoreParenImpCasts(); - // Check for a call expression + // Check for a call expression or static_cast

[clang] [clang-tools-extra] [clang-tidy] Add new check `modernize-use-designated-initializers` (PR #80541)

2024-02-29 Thread Danny Mösch via cfe-commits
SimplyDanny wrote: Thank you for the fast fix, @PiotrZSL! https://github.com/llvm/llvm-project/pull/80541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] RISCV vector calling convention (1/2) (PR #77560)

2024-02-29 Thread Shao-Ce SUN via cfe-commits
sunshaoce wrote: I tried compiling it and then got two warnings. ``` llvm-project/clang/lib/CodeGen/CGDebugInfo.cpp:1408:11: warning: enumeration value 'CC_RISCVVectorCall' not handled in switch [-Wswitch] 1408 | switch (CC) { | ^~ 1 warning generated. [3629/3776] Building

[clang-tools-extra] [clangd] Remove calls to getFileLoc() in declToSym() (PR #83532)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Nathan Ridge (HighCommander4) Changes toHalfOpenFileRange() already handles translating macro locations to file locations, and it can provide a better result by knowing about both ends of the range. Fixes

[clang-tools-extra] [clangd] Remove calls to getFileLoc() in declToSym() (PR #83532)

2024-02-29 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/83532 toHalfOpenFileRange() already handles translating macro locations to file locations, and it can provide a better result by knowing about both ends of the range. Fixes

[clang] [compiler-rt] [AArch64] Implement __builtin_cpu_supports, compiler-rt tests. (PR #82378)

2024-02-29 Thread via cfe-commits
eaeltsin wrote: Thanks @ilinpv ! https://github.com/llvm/llvm-project/pull/82378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-02-29 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/83380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-02-29 Thread Owen Pan via cfe-commits
@@ -16710,7 +16705,7 @@ TEST_F(FormatTest, ConfigurableSpaceBeforeParens) { verifyFormat("typedef void (*cb)(int);", SpaceFuncDef); verifyFormat("T A::operator()();", SpaceFuncDef); verifyFormat("X A::operator++(T);", SpaceFuncDef); - // verifyFormat("T A::operator() ()

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-02-29 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/83380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-02-29 Thread Owen Pan via cfe-commits
@@ -16671,9 +16667,8 @@ TEST_F(FormatTest, ConfigurableSpaceBeforeParens) { SpaceFuncDecl); verifyFormat("int f () throw(Deprecated);", SpaceFuncDecl); verifyFormat("typedef void (*cb)(int);", SpaceFuncDecl); - // FIXME these tests regressed behaviour. -

[clang] 8116dfb - [InstallAPI] Use unique identifiers for input buffers (#83523)

2024-02-29 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-02-29T21:42:43-08:00 New Revision: 8116dfb8b58a65e78e341f09f5728d345f086b7b URL: https://github.com/llvm/llvm-project/commit/8116dfb8b58a65e78e341f09f5728d345f086b7b DIFF: https://github.com/llvm/llvm-project/commit/8116dfb8b58a65e78e341f09f5728d345f086b7b.diff

[clang] [InstallAPI] Use unique identifiers for input buffers (PR #83523)

2024-02-29 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/83523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] RISCV vector calling convention (1/2) (PR #77560)

2024-02-29 Thread Brandon Wu via cfe-commits
4vtomat wrote: ping https://github.com/llvm/llvm-project/pull/77560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstallAPI] Use unique identifiers for input buffers (PR #83523)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/83523.diff 1 Files Affected: - (modified) clang/lib/InstallAPI/Frontend.cpp (+4-2) ``diff diff --git

[clang] [InstallAPI] Use unique identifiers for input buffers (PR #83523)

2024-02-29 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/83523 None >From 82521efd33c253b34da149b5dfe6bbb7823589c1 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Thu, 29 Feb 2024 21:04:58 -0800 Subject: [PATCH] [InstallAPI] Use unique name for input buffers ---

[clang] [llvm] [AMDGPU] Add code model (#70760) test for amdgpu target. (PR #71019)

2024-02-29 Thread Pravin Jagtap via cfe-commits
https://github.com/pravinjagtap closed https://github.com/llvm/llvm-project/pull/71019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PseudoProbe] Mix and reorder block and call probe ID in lexical order (PR #75092)

2024-02-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cf68c0427d9d3816eefcfe7d3d648a98146c07cf 6641409c4ee90807e48023ea071be016f52c11ff --

[clang] [llvm] [PseudoProbe] Mix and reorder block and call probe ID in lexical order (PR #75092)

2024-02-29 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm updated https://github.com/llvm/llvm-project/pull/75092 >From e6f735a336f87659ee3236fc795ad4b7107dff4d Mon Sep 17 00:00:00 2001 From: wlei Date: Sun, 10 Dec 2023 18:30:42 -0800 Subject: [PATCH 1/5] [PseudoProbe] Mix and reorder block and call probe ID in lexical

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83520)

2024-02-29 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/83520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PseudoProbe] Mix and reorder block and call probe ID in lexical order (PR #75092)

2024-02-29 Thread Lei Wang via cfe-commits
wlei-llvm wrote: > > > LGTM. I'd also have a change that errors out on huge staleness go in > > > together with this one.. > > > > > > Was thinking to use a separate diff for that, feels non-trivial to do it, > > but I'm also good for doing in this. > > Just pushed one version for this, it

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83520)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl @llvm/pr-subscribers-backend-directx @llvm/pr-subscribers-clang Author: Farzon Lotfi (farzonl) Changes - Builtins.td - add the round builtin - CGBuiltin.cpp - add the builtin to DirectX intrinsic mapping hlsl_intrinsics.h - add the round api -

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83520)

2024-02-29 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/83520 - Builtins.td - add the round builtin - CGBuiltin.cpp - add the builtin to DirectX intrinsic mapping hlsl_intrinsics.h - add the round api - SemaChecking.cpp - add type checks for builtin - IntrinsicsDirectX.td

[clang] [llvm] [PseudoProbe] Mix and reorder block and call probe ID in lexical order (PR #75092)

2024-02-29 Thread via cfe-commits
WenleiHe wrote: > > LGTM. I'd also have a change that errors out on huge staleness go in > > together with this one.. > > Was thinking to use a separate diff for that, feels non-trivial to do it, but > I'm also good for doing in this. > > Just pushed one version for this, it use heuristics

[clang] [llvm] [PseudoProbe] Mix and reorder block and call probe ID in lexical order (PR #75092)

2024-02-29 Thread Lei Wang via cfe-commits
wlei-llvm wrote: > LGTM. I'd also have a change that errors out on huge staleness go in together > with this one.. Was thinking to use a separate diff for that, feels non-trivial to do it, but I'm also good for doing in this. Just pushed one version for this, it use heuristics to check

[clang] [llvm] [PseudoProbe] Mix and reorder block and call probe ID in lexical order (PR #75092)

2024-02-29 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm updated https://github.com/llvm/llvm-project/pull/75092 >From e6f735a336f87659ee3236fc795ad4b7107dff4d Mon Sep 17 00:00:00 2001 From: wlei Date: Sun, 10 Dec 2023 18:30:42 -0800 Subject: [PATCH 1/4] [PseudoProbe] Mix and reorder block and call probe ID in lexical

[clang] [Clang][Sema] Fix incorrect rejection default construction of union with nontrivial member (PR #82407)

2024-02-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/82407 >From 5fcaeaddccc0f7e370bf7bebce113d8d52e1b1bd Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Tue, 20 Feb 2024 11:22:39 -0800 Subject: [PATCH] [Clang][Sema] Fix incorrect rejection default construction of

[clang] [compiler-rt] [AArch64] Implement __builtin_cpu_supports, compiler-rt tests. (PR #82378)

2024-02-29 Thread Pavel Iliin via cfe-commits
ilinpv wrote: Fix on review https://github.com/llvm/llvm-project/pull/83515 The documentation is coming next. https://github.com/llvm/llvm-project/pull/82378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [X86][AArch64][PowerPC] __builtin_cpu_supports accepts unknown options. (PR #83515)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Pavel Iliin (ilinpv) Changes The patch fixes https://github.com/llvm/llvm-project/issues/83407 modifing __builtin_cpu_supports behaviour so that it returns false if unsupported features names provided

[clang] [X86][AArch64][PowerPC] __builtin_cpu_supports accepts unknown options. (PR #83515)

2024-02-29 Thread Pavel Iliin via cfe-commits
https://github.com/ilinpv created https://github.com/llvm/llvm-project/pull/83515 The patch fixes https://github.com/llvm/llvm-project/issues/83407 modifing __builtin_cpu_supports behaviour so that it returns false if unsupported features names provided in parameter and issue a warning.

[clang] [Clang][Sema]: Diagnose lambda to bool implicit casts (PR #83152)

2024-02-29 Thread Fangrui Song via cfe-commits
MaskRay wrote: Created #83497 as a follow-up to suppress the diagnostic for certain template instantiation uses. I made one change to unblock our internal users ``` #ifdef __clang__ #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wpointer-bool-conversion" #endif //

[clang] [llvm] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2024-02-29 Thread Felix via cfe-commits
https://github.com/orcguru closed https://github.com/llvm/llvm-project/pull/66316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement __builtin_{clzg,ctzg} (PR #83431)

2024-02-29 Thread Eli Friedman via cfe-commits
@@ -3157,7 +3177,15 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, if (Result->getType() != ResultType) efriedma-quic wrote: I was more thinking of the opposite: we don't need to make the result of the clz defined if

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-02-29 Thread Jun Wang via cfe-commits
jwanggit86 wrote: @jayfoad After trying the patch you provided above, it appears that this feature can indeed be done in SIInsertWaitcnt instead of SIMemoryLegalizer. Code has been updated accordingly. Pls take a look. https://github.com/llvm/llvm-project/pull/79236

[clang] [clang] Implement __builtin_{clzg,ctzg} (PR #83431)

2024-02-29 Thread via cfe-commits
@@ -3157,7 +3177,15 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, if (Result->getType() != ResultType) overmighty wrote: Since in the additions below I check if the argument itself is zero instead of checking the

[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

2024-02-29 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/82229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

2024-02-29 Thread Artem Dergachev via cfe-commits
@@ -171,6 +151,24 @@ class UncountedLocalVarsChecker std::optional IsUncountedPtr = isUncountedPtr(ArgType); if (IsUncountedPtr && *IsUncountedPtr) { + + ASTContext = V->getASTContext(); + for (DynTypedNodeList ancestors = ctx.getParents(*V);

[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

2024-02-29 Thread Artem Dergachev via cfe-commits
@@ -70,15 +71,27 @@ bool isSingleton(const FunctionDecl *F); class TrivialFunctionAnalysis { public: /// \returns true if \p D is a "trivial" function. - bool isTrivial(const Decl *D) const { return isTrivialImpl(D, TheCache); } + bool isTrivial(const Decl *D) const { +

[clang] [llvm] [Hexagon] Add Loop Alignment pass. (PR #83379)

2024-02-29 Thread Sumanth Gundapaneni via cfe-commits
https://github.com/sgundapa closed https://github.com/llvm/llvm-project/pull/83379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ca9d2e9 - [Hexagon] Add Loop Alignment pass. (#83379)

2024-02-29 Thread via cfe-commits
Author: Sumanth Gundapaneni Date: 2024-02-29T16:57:33-06:00 New Revision: ca9d2e923b28adec9ae1754f0bb61b2e8ada025e URL: https://github.com/llvm/llvm-project/commit/ca9d2e923b28adec9ae1754f0bb61b2e8ada025e DIFF:

[clang] [clang] Implement __builtin_{clzg,ctzg} (PR #83431)

2024-02-29 Thread Eli Friedman via cfe-commits
@@ -3157,7 +3177,15 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, if (Result->getType() != ResultType) efriedma-quic wrote: Not sure if the way this is handling isCLZForZeroUndef() is what you want?

[clang] [clang] Implement __builtin_{clzg,ctzg} (PR #83431)

2024-02-29 Thread Eli Friedman via cfe-commits
@@ -2212,6 +2212,54 @@ static bool SemaBuiltinPopcountg(Sema , CallExpr *TheCall) { return false; } +/// Checks that __builtin_{clzg,ctzg} was called with a first argument, which is +/// an unsigned integer, and an optional second argument, which is promoted to +/// an

[clang] [clang] Implement __builtin_{clzg,ctzg} (PR #83431)

2024-02-29 Thread Eli Friedman via cfe-commits
@@ -662,6 +662,12 @@ def Clz : Builtin, BitShort_Int_Long_LongLongTemplate { // FIXME: Add int clzimax(uintmax_t) efriedma-quic wrote: Probably; it's unlikely we're going to add them at this point. https://github.com/llvm/llvm-project/pull/83431

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-02-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/83497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-02-29 Thread Fangrui Song via cfe-commits
MaskRay wrote: @vinayakdsci https://github.com/llvm/llvm-project/pull/83497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-02-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/83497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes I have seen internal pieces of code that uses a template type parameter to accept std::function, a closure type, or any callable type. The diagnostic added in #83152 would require adaptation to the template,

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-02-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/83497 I have seen internal pieces of code that uses a template type parameter to accept std::function, a closure type, or any callable type. The diagnostic added in #83152 would require adaptation to the template,

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-02-29 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/83378 >From 908e41485a148539b3d0699c55291f4f4e819858 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Wed, 28 Feb 2024 14:15:48 -0800 Subject: [PATCH 1/2] [InstallAPI] Collect frontend attributes during &

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. https://github.com/llvm/llvm-project/pull/83476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Shafik Yaghmour via cfe-commits
@@ -17615,31 +17615,28 @@ class SequenceChecker : public ConstEvaluatedExprVisitor { return VisitExpr(CCE); // In C++11, list initializations are sequenced. -SmallVector Elts; -SequenceTree::Seq Parent = Region; -for

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/83476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: LGTM after addressing comment. https://github.com/llvm/llvm-project/pull/83476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class layout is statically known (PR #81335)

2024-02-29 Thread via cfe-commits
AtariDreams wrote: @rjmccall I do not have merge permissions or whatever it is called. https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Douglas Deslauriers via cfe-commits
https://github.com/vapdrs updated https://github.com/llvm/llvm-project/pull/83476 >From cc14e7a3320c36295514b75108e4da481d2f6b99 Mon Sep 17 00:00:00 2001 From: Douglas Deslauriers Date: Thu, 29 Feb 2024 20:18:34 + Subject: [PATCH] [clang] Sequence C++20 Parenthesized List Init

[clang] Fix implementation of [temp.param]p14's first sentence. (PR #83487)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes The first sentence says: If a template-parameter of a class template, variable template, or alias template has a default template-argument, each subsequent template-parameter shall either have a default

[clang] Fix implementation of [temp.param]p14's first sentence. (PR #83487)

2024-02-29 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/83487 The first sentence says: If a template-parameter of a class template, variable template, or alias template has a default template-argument, each subsequent template-parameter shall either have a default

[clang] [llvm] [Hexagon] Add Loop Alignment pass. (PR #83379)

2024-02-29 Thread Ikhlas Ajbar via cfe-commits
https://github.com/iajbar approved this pull request. https://github.com/llvm/llvm-project/pull/83379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-29 Thread Joshua Cranmer via cfe-commits
@@ -1847,19 +1847,33 @@ floating point semantic models: precise (the default), strict, and fast. * ``16`` - Forces ``_Float16`` operations to be emitted without using excess precision arithmetic. -.. option:: -fcx-limited-range: - - This option enables the naive

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-29 Thread Joshua Cranmer via cfe-commits
@@ -982,13 +1022,18 @@ ComplexPairTy ComplexExprEmitter::EmitBinDiv(const BinOpInfo ) { llvm::Value *OrigLHSi = LHSi; if (!LHSi) LHSi = llvm::Constant::getNullValue(RHSi->getType()); -if (Op.FPFeatures.getComplexRange() == LangOptions::CX_Fortran) +

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-29 Thread Joshua Cranmer via cfe-commits
@@ -283,9 +283,46 @@ class ComplexExprEmitter ComplexPairTy EmitComplexBinOpLibCall(StringRef LibCallName, const BinOpInfo ); - QualType getPromotionType(QualType Ty) { + QualType HigherPrecisionTypeForComplexArithmetic(QualType

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-02-29 Thread Joshua Cranmer via cfe-commits
@@ -1847,19 +1847,50 @@ floating point semantic models: precise (the default), strict, and fast. * ``16`` - Forces ``_Float16`` operations to be emitted without using excess precision arithmetic. +.. option:: -fcomplex-arithmetic=: + + This option specifies the

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Douglas Deslauriers via cfe-commits
@@ -17626,6 +17626,25 @@ class SequenceChecker : public ConstEvaluatedExprVisitor { for (unsigned I = 0; I < Elts.size(); ++I) Tree.merge(Elts[I]); } + + void VisitCXXParenListInitExpr(const CXXParenListInitExpr *PLIE) { +// C++20 parenthesized list

[clang] [llvm] [CMAKE] Enable FatLTO as a build option for LLVM (PR #80480)

2024-02-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/80480 >From 0c010db4bdf8808d95895db1ba4112fcb04f2d8b Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 22 Aug 2023 15:24:03 + Subject: [PATCH 1/2] [CMAKE] Enable FatLTO as a build option for LLVM ---

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Douglas Deslauriers via cfe-commits
@@ -17626,6 +17626,25 @@ class SequenceChecker : public ConstEvaluatedExprVisitor { for (unsigned I = 0; I < Elts.size(); ++I) Tree.merge(Elts[I]); } + + void VisitCXXParenListInitExpr(const CXXParenListInitExpr *PLIE) { +// C++20 parenthesized list

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Douglas Deslauriers via cfe-commits
https://github.com/vapdrs updated https://github.com/llvm/llvm-project/pull/83476 >From 85958bdf181b0cb79716a35bc4f3248e8f31c527 Mon Sep 17 00:00:00 2001 From: Douglas Deslauriers Date: Thu, 29 Feb 2024 20:18:34 + Subject: [PATCH] [clang] Sequence C++20 Parenthesized List Init

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-02-29 Thread Cyndy Ishida via cfe-commits
@@ -16,6 +16,74 @@ using namespace llvm::MachO; namespace clang::installapi { +GlobalRecord *FrontendRecordsSlice::addGlobal( +StringRef Name, RecordLinkage Linkage, GlobalRecord::Kind GV, +const clang::AvailabilityInfo Avail, const Decl *D, const HeaderType Access,

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Douglas Deslauriers via cfe-commits
https://github.com/vapdrs edited https://github.com/llvm/llvm-project/pull/83476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-02-29 Thread Cyndy Ishida via cfe-commits
@@ -0,0 +1,86 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: sed -e "s|DSTROOT|%/t|g" %t/inputs.json.in > %t/inputs.json + +/// Check multiple targets are captured. cyndyishida wrote: Thanks for calling this out, forgot to remove.

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-02-29 Thread Cyndy Ishida via cfe-commits
@@ -16,6 +16,74 @@ using namespace llvm::MachO; namespace clang::installapi { +GlobalRecord *FrontendRecordsSlice::addGlobal( +StringRef Name, RecordLinkage Linkage, GlobalRecord::Kind GV, +const clang::AvailabilityInfo Avail, const Decl *D, const HeaderType Access,

[clang] [llvm] [Hexagon] Add Loop Alignment pass. (PR #83379)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sumanth Gundapaneni (sgundapa) Changes Inspect a basic block and if its single basic block loop with a small number of instructions, set the Loop Alignment to 32 bytes. This will avoid the cache line break in the first packet of loop

[clang] [llvm] [Hexagon] Add Loop Alignment pass. (PR #83379)

2024-02-29 Thread Sumanth Gundapaneni via cfe-commits
https://github.com/sgundapa updated https://github.com/llvm/llvm-project/pull/83379 >From 973d204ae0d8370704f1613e5206ac330a40e8f4 Mon Sep 17 00:00:00 2001 From: Sumanth Gundapaneni Date: Wed, 28 Feb 2024 12:23:35 -0800 Subject: [PATCH] [Hexagon] Add Loop Alignment pass. Inspect a basic block

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-02-29 Thread Juergen Ributzka via cfe-commits
@@ -16,6 +16,74 @@ using namespace llvm::MachO; namespace clang::installapi { +GlobalRecord *FrontendRecordsSlice::addGlobal( +StringRef Name, RecordLinkage Linkage, GlobalRecord::Kind GV, +const clang::AvailabilityInfo Avail, const Decl *D, const HeaderType Access,

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-02-29 Thread Juergen Ributzka via cfe-commits
@@ -16,6 +16,74 @@ using namespace llvm::MachO; namespace clang::installapi { +GlobalRecord *FrontendRecordsSlice::addGlobal( +StringRef Name, RecordLinkage Linkage, GlobalRecord::Kind GV, +const clang::AvailabilityInfo Avail, const Decl *D, const HeaderType Access,

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-02-29 Thread Juergen Ributzka via cfe-commits
@@ -16,6 +16,74 @@ using namespace llvm::MachO; namespace clang::installapi { +GlobalRecord *FrontendRecordsSlice::addGlobal( +StringRef Name, RecordLinkage Linkage, GlobalRecord::Kind GV, +const clang::AvailabilityInfo Avail, const Decl *D, const HeaderType Access,

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-02-29 Thread Juergen Ributzka via cfe-commits
@@ -0,0 +1,86 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: sed -e "s|DSTROOT|%/t|g" %t/inputs.json.in > %t/inputs.json + +/// Check multiple targets are captured. ributzka wrote: What do you mean with multiple targets here?

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-02-29 Thread Juergen Ributzka via cfe-commits
@@ -16,6 +16,74 @@ using namespace llvm::MachO; namespace clang::installapi { +GlobalRecord *FrontendRecordsSlice::addGlobal( +StringRef Name, RecordLinkage Linkage, GlobalRecord::Kind GV, +const clang::AvailabilityInfo Avail, const Decl *D, const HeaderType Access,

[clang-tools-extra] 21be2fb - [clang-tidy][NFC] Fix buffer overflow in modernize-use-designated-initializers

2024-02-29 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2024-02-29T20:53:30Z New Revision: 21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85 URL: https://github.com/llvm/llvm-project/commit/21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85 DIFF: https://github.com/llvm/llvm-project/commit/21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85.diff LOG:

[clang] [clang-tools-extra] [clang-tidy] Add new check `modernize-use-designated-initializers` (PR #80541)

2024-02-29 Thread Piotr Zegar via cfe-commits
Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny =?utf-8?q?Mösch?= , Danny

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Richard Smith via cfe-commits
https://github.com/zygoloid commented: Thanks! [I'm not sure when I'll have time to circle back to this, so I'd be happy for someone else to finish the review and approve.] https://github.com/llvm/llvm-project/pull/83476 ___ cfe-commits mailing list

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Richard Smith via cfe-commits
https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/83476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Richard Smith via cfe-commits
@@ -17626,6 +17626,25 @@ class SequenceChecker : public ConstEvaluatedExprVisitor { for (unsigned I = 0; I < Elts.size(); ++I) Tree.merge(Elts[I]); } + + void VisitCXXParenListInitExpr(const CXXParenListInitExpr *PLIE) { +// C++20 parenthesized list

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Richard Smith via cfe-commits
@@ -17626,6 +17626,25 @@ class SequenceChecker : public ConstEvaluatedExprVisitor { for (unsigned I = 0; I < Elts.size(); ++I) Tree.merge(Elts[I]); } + + void VisitCXXParenListInitExpr(const CXXParenListInitExpr *PLIE) { +// C++20 parenthesized list

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-29 Thread Vinayak Dev via cfe-commits
vinayakdsci wrote: > Aside from some grammatical changes to the release note, the changes LGTM! Thank you so much! I have made changes to the Release Notes as you suggested. Thanks for your review! > Do you need someone to land this on your behalf once those changes are made? Yes, I don't

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Douglas Deslauriers (vapdrs) Changes Parenthesized list intializers are sequenced operations, see C++20 [decl.init]p17.5 and [decl.init]p17.6.2.2 for more details. Fixes #83474 --- Full diff:

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-02-29 Thread Douglas Deslauriers via cfe-commits
https://github.com/vapdrs created https://github.com/llvm/llvm-project/pull/83476 Parenthesized list intializers are sequenced operations, see C++20 [decl.init]p17.5 and [decl.init]p17.6.2.2 for more details. Fixes #83474 >From 82e371bdcde2da8336b8679fff941f8b0a0394ae Mon Sep 17 00:00:00

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-29 Thread Vinayak Dev via cfe-commits
https://github.com/vinayakdsci updated https://github.com/llvm/llvm-project/pull/81127 >From d4df9a7bef0f993d0c092af5f5af61202dc3effe Mon Sep 17 00:00:00 2001 From: Vinayak Dev Date: Thu, 8 Feb 2024 17:29:44 +0530 Subject: [PATCH] [Clang][Sema]: Allow copy constructor side effects ---

  1   2   3   4   >