https://github.com/sjoerdmeijer approved this pull request.
Thanks for the quick fix.
This looks okay to me. But let's see if @DavidSpickett has more comments before
merging this.
https://github.com/llvm/llvm-project/pull/84485
___
cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/84499
>From 81945389b60e95019ff916d356127119183e8198 Mon Sep 17 00:00:00 2001
From: Yitzhak Mandelbaum
Date: Fri, 8 Mar 2024 15:19:14 +
Subject: [PATCH] [clang][dataflow] Refactor processing of terminator element
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cb6f657a70f7a8d6ecd4fcc2101550a7400f94a7
210a2b83d3647c97ad4fc5eab9e0d9c68a5711a4 --
@@ -0,0 +1,167 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,167 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,167 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
ymand wrote:
Terminator cleanup split out into
https://github.com/llvm/llvm-project/pull/84499
https://github.com/llvm/llvm-project/pull/82950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Author: Yitzhak Mandelbaum (ymand)
Changes
This patch vastly simplifies the code handling terminators, without changing any
behavior. Additionally, the simplification unblocks our ability to address a
(simple) FIXME in the code to invoke
https://github.com/ymand created https://github.com/llvm/llvm-project/pull/84499
This patch vastly simplifies the code handling terminators, without changing any
behavior. Additionally, the simplification unblocks our ability to address a
(simple) FIXME in the code to invoke `transferBranch`,
https://github.com/devnexen updated
https://github.com/llvm/llvm-project/pull/83675
>From 1b2fec2c9a41be4ad216d7032189f561eed3f751 Mon Sep 17 00:00:00 2001
From: David Carlier
Date: Sat, 2 Mar 2024 14:56:15 +
Subject: [PATCH 1/3] [clang][StaticAnalyzer] Adding getentropy to
jhuber6 wrote:
> There are many `--no-offload-new-driver` test changes. They can be
> pre-committed to make this default flip modify fewer files.
Done
https://github.com/llvm/llvm-project/pull/84420
___
cfe-commits mailing list
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/84420
>From 3e2846b721ba17d44a05d7d97b377fa3a43c8cef Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Thu, 7 Mar 2024 15:48:00 -0600
Subject: [PATCH] [Offload] Move HIP and CUDA to new driver by default
Summary:
Author: Joseph Huber
Date: 2024-03-08T09:07:00-06:00
New Revision: cb6f657a70f7a8d6ecd4fcc2101550a7400f94a7
URL:
https://github.com/llvm/llvm-project/commit/cb6f657a70f7a8d6ecd4fcc2101550a7400f94a7
DIFF:
https://github.com/llvm/llvm-project/commit/cb6f657a70f7a8d6ecd4fcc2101550a7400f94a7.diff
ymand wrote:
> > Draft to demo how we can pull out the boolean model. Let's discuss
> > specifics of namings, location, etc.
>
> Not sure -- do you mean let's wordsmith names now, or do you mean we should
> discuss naming and location, but that should happen after we've talked about
> the
cor3ntin wrote:
@andreasfertig Will you need us to merge that for you?
https://github.com/llvm/llvm-project/pull/84193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84473
>From 870e6a6def8c17859ffbb30906f91912268f872d Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 11:55:42 +0100
Subject: [PATCH 1/5] [Clang] Fix dependence of DREs in lambdas with an
explicit
Sirraide wrote:
Also, just checked, #84425 apparently was a symptom of this as well, because
that one’s also fixed now.
https://github.com/llvm/llvm-project/pull/84473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/jthackray updated
https://github.com/llvm/llvm-project/pull/84485
>From 40c20f5b4413bd8aac0249d4d1fc4fb4ce8c6438 Mon Sep 17 00:00:00 2001
From: Jonathan Thackray
Date: Fri, 8 Mar 2024 13:39:35 +
Subject: [PATCH 1/2] [ARM][AArch64] Add support for Arm Cortex A78AE CPU
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84473
>From 870e6a6def8c17859ffbb30906f91912268f872d Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 11:55:42 +0100
Subject: [PATCH 1/4] [Clang] Fix dependence of DREs in lambdas with an
explicit
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/84481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sirraide wrote:
Ok, looks like `this` is fixed now as well.
https://github.com/llvm/llvm-project/pull/84473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide ready_for_review
https://github.com/llvm/llvm-project/pull/84473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -100,6 +100,12 @@ Improvements to clang-tidy
New checks
^^
+- New :doc:`readability-math-missing-parentheses
+ ` check.
+
+ Checks for mathematical expressions that involve operators
+ of different priorities.
PiotrZSL wrote:
`Check for missing
https://github.com/erichkeane commented:
Ah, this used to be a really small class, at one point it was an unsigned plus
a handful of array-refs, so it made sense to pass by value. It seems to have
grown a decent bit to the point that pass-by-const-ref now makes sense.
@@ -0,0 +1,42 @@
+// RUN: %check_clang_tidy %s readability-math-missing-parentheses %t
+
+// FIXME: Add something that triggers the check here.
+void f(){
+//CHECK-MESSAGES: :[[@LINE+2]]:13: warning: add parantheses to clarify the
precedence of operations
@@ -0,0 +1,167 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,167 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,167 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,167 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,167 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/84481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL requested changes to this pull request.
In short, manual code parsing is not allowed, for that e got AST already.
Sad thing is that you already wrote all those parsing functions, because this
check can be implemented in 60 lines of code.
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84473
>From 870e6a6def8c17859ffbb30906f91912268f872d Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 11:55:42 +0100
Subject: [PATCH 1/3] [Clang] Fix dependence of DREs in lambdas with an
explicit
firewave wrote:
Maybe add `+=` to the tests as well? I have also seen it reported with that.
https://github.com/llvm/llvm-project/pull/84489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
steakhal wrote:
> This functionality could
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -1158,6 +1173,118 @@ void
erichkeane wrote:
> The clang-format check fails due to a change in `clang/docs/ReleaseNotes.
> rst`, which isn't mine. What's the protocol? Shall I fix the format issue, or
> can my change be merged anyway?
Nope, don't worry about that one. That bot is being weird, feel free to merge
@@ -1158,6 +1173,118 @@ void StreamChecker::evalUngetc(const FnDescription
*Desc, const CallEvent ,
C.addTransition(StateFailed);
}
+ProgramStateRef
+StreamChecker::ensurePtrNotNull(SVal PtrVal, const Expr *PtrExpr,
+CheckerContext ,
@@ -510,6 +517,14 @@ class StreamChecker : public Checkerhttps://github.com/llvm/llvm-project/pull/83027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1158,6 +1173,118 @@ void StreamChecker::evalUngetc(const FnDescription
*Desc, const CallEvent ,
C.addTransition(StateFailed);
}
+ProgramStateRef
+StreamChecker::ensurePtrNotNull(SVal PtrVal, const Expr *PtrExpr,
+CheckerContext ,
@@ -1158,6 +1173,118 @@ void StreamChecker::evalUngetc(const FnDescription
*Desc, const CallEvent ,
C.addTransition(StateFailed);
}
+ProgramStateRef
+StreamChecker::ensurePtrNotNull(SVal PtrVal, const Expr *PtrExpr,
+CheckerContext ,
@@ -1158,6 +1173,118 @@ void StreamChecker::evalUngetc(const FnDescription
*Desc, const CallEvent ,
C.addTransition(StateFailed);
}
+ProgramStateRef
+StreamChecker::ensurePtrNotNull(SVal PtrVal, const Expr *PtrExpr,
+CheckerContext ,
@@ -234,6 +235,9 @@ class StreamChecker : public Checkerhttps://github.com/llvm/llvm-project/pull/83027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/balazske commented:
This functionality could be added to this checker, but to
`StdLibraryFunctionsChecker` too, and probably will be added at a time (summary
of `getdelim` is not accurate now in that checker). The same bug condition is
checked by two different checkers in
https://github.com/balazske edited
https://github.com/llvm/llvm-project/pull/83027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
weliveindetail wrote:
> Do you mind incorporating this patch so that we avoid churn?
Sure. Essentially, this drops lazy creation of the executor and makes it
dependent on the frontend action explicitly. Fine for me. We can still expose
explicit setup/tear-down.
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Congcong Cai (HerrCai0907)
Changes
Fixes: #84480
We assuem assignemnt at most of time, operator overloading means the value is
assigned to the other variable, then clang-tidy should suppress warning even if
this operator overloading
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/84489
>From 265db5ee772772bef4099cc97b69995cfa67b3f2 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 8 Mar 2024 22:15:20 +0800
Subject: [PATCH] [clang-tidy]avoid bugprone-unused-return-value false positive
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/84489
Fixes: #84480
We assuem assignemnt at most of time, operator overloading means the value is
assigned to the other variable, then clang-tidy should suppress warning even if
this operator overloading match
jthackray wrote:
> Also does this address the -mcpu=native part of #84450 as well?
I've added a host id (0xd42) to llvm/lib/TargetParser/Host.cpp, so I think so
(unless there's something else required).
https://github.com/llvm/llvm-project/pull/84485
DavidSpickett wrote:
Also does this address the -mcpu=native part of
https://github.com/llvm/llvm-project/issues/84450 as well?
https://github.com/llvm/llvm-project/pull/84485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jthackray wrote:
> Should this be added to the release notes? (so it doesn't get forgotten in a
> mad scramble in a few months time)
Sure, happy to do that.
https://github.com/llvm/llvm-project/pull/84485
___
cfe-commits mailing list
DavidSpickett wrote:
Should this be added to the release notes? (so it doesn't get forgotten in a
mad scramble in a few months time)
https://github.com/llvm/llvm-project/pull/84485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
steakhal wrote:
I had to push a fixup commit, because I forgot about one switch-case.
https://github.com/llvm/llvm-project/commit/f07157eb2e8212068cb9469d77f9bc3779ef2ea4
I pushed it already to fix the build bot, but let me know if you disagree with
the fix.
Author: Balazs Benics
Date: 2024-03-08T14:55:10+01:00
New Revision: f07157eb2e8212068cb9469d77f9bc3779ef2ea4
URL:
https://github.com/llvm/llvm-project/commit/f07157eb2e8212068cb9469d77f9bc3779ef2ea4
DIFF:
https://github.com/llvm/llvm-project/commit/f07157eb2e8212068cb9469d77f9bc3779ef2ea4.diff
https://github.com/gigaroby updated
https://github.com/llvm/llvm-project/pull/84346
>From 4b0ef9a83db7f8309ea0d8f79fabbfbad50ae6f8 Mon Sep 17 00:00:00 2001
From: Roberto Bampi
Date: Thu, 7 Mar 2024 18:10:56 +0100
Subject: [PATCH 1/2] [clang-format] Add --fail-on-incomplete-format.
At the
https://github.com/jthackray edited
https://github.com/llvm/llvm-project/pull/84485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-arm
Author: Jonathan Thackray (jthackray)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/84485.diff
13 Files Affected:
- (modified) clang/test/Driver/aarch64-mcpu.c (+2)
- (modified) clang/test/Driver/arm-cortex-cpus-2.c
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
vgvassilev wrote:
I was currently touching this area to fix a problem of @jeaye reported on irc.
Do you mind incorporating this patch so that we avoid churn?
```diff
diff --git a/clang/include/clang/Interpreter/Interpreter.h
https://github.com/jthackray created
https://github.com/llvm/llvm-project/pull/84485
None
>From 40c20f5b4413bd8aac0249d4d1fc4fb4ce8c6438 Mon Sep 17 00:00:00 2001
From: Jonathan Thackray
Date: Fri, 8 Mar 2024 13:39:35 +
Subject: [PATCH] [ARM][AArch64] Add support for Arm Cortex A78AE CPU
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
NagyDonat wrote:
I feel that I'm getting bogged down in this area with changes that are more
general than what's strictly necessary...
I'm not familiar with the unittest framework and if unittests were necessary
for
firewave wrote:
> Why can't we make "filter" use a full regex that supports negative
> expressions instead?
How do you do that? I thought `llvm::RegEx` doesn't support negative
expressions.
https://github.com/llvm/llvm-project/pull/82416
___
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Bhuminjay Soni (11happy)
Changes
**Overview:**
This pull request fixes #80850 where author suggests adding a
readability check to detect missing parentheses around mathematical expressions
when operators of different priorities are
https://github.com/11happy created
https://github.com/llvm/llvm-project/pull/84481
**Overview:**
This pull request fixes #80850 where author suggests adding a readability
check to detect missing parentheses around mathematical expressions when
operators of different priorities are used.
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/77890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Haojian Wu
Date: 2024-03-08T14:24:03+01:00
New Revision: 7415524b45392651969374c067041daa82dc89e7
URL:
https://github.com/llvm/llvm-project/commit/7415524b45392651969374c067041daa82dc89e7
DIFF:
https://github.com/llvm/llvm-project/commit/7415524b45392651969374c067041daa82dc89e7.diff
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
https://github.com/steakhal edited
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=
Message-ID:
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -109,6 +136,33 @@ int *potentialAfterTheEndPtr(int idx) {
// [idx].
}
+int overflowOrUnderflow(int arg) {
+ // expected-note@+2 {{Assuming 'arg' is < 0}}
+ // expected-note@+1 {{Taking false branch}}
+ if (arg >= 0)
+
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/84333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Congcong Cai
Date: 2024-03-08T21:18:58+08:00
New Revision: 912ea6e335ca6174b3433fd960ed8b592794361b
URL:
https://github.com/llvm/llvm-project/commit/912ea6e335ca6174b3433fd960ed8b592794361b
DIFF:
https://github.com/llvm/llvm-project/commit/912ea6e335ca6174b3433fd960ed8b592794361b.diff
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/steakhal commented:
Looks good to me, but I'd be more eased if had seen some unittests for this
matter.
You could use AST-matchers selecting different FunctionDecls and query them
using this
@@ -2515,6 +2518,57 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent , CharKind CK) const {
+
@@ -529,3 +529,42 @@ void nocrash_on_locint_offset(void *addr, void* from,
struct S s) {
size_t iAdd = (size_t) addr;
memcpy(((void *) &(s.f)), from, iAdd);
}
+
+#if defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
+/* present in both glibc 2.25 and musl
@@ -2515,6 +2518,57 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent , CharKind CK) const {
+
@@ -219,6 +221,7 @@ class CStringChecker : public Checker< eval::Call,
void evalSnprintf(CheckerContext , const CallEvent ) const;
void evalSprintfCommon(CheckerContext , const CallEvent ,
bool IsBounded, bool IsBuiltin) const;
+ void
@@ -2515,6 +2518,57 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent , CharKind CK) const {
+
@@ -2516,6 +2518,47 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent ) const {
+ DestinationArgExpr Buffer =
@@ -2515,6 +2518,57 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent , CharKind CK) const {
+
@@ -2515,6 +2518,57 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent , CharKind CK) const {
@@ -529,3 +529,42 @@ void nocrash_on_locint_offset(void *addr, void* from,
struct S s) {
size_t iAdd = (size_t) addr;
memcpy(((void *) &(s.f)), from, iAdd);
}
+
+#if defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
+/* present in both glibc 2.25 and musl
@@ -165,6 +165,8 @@ class CStringChecker : public Checker< eval::Call,
{{CDM::CLibrary, {"explicit_bzero"}, 2}, ::evalBzero},
{{CDM::CLibrary, {"sprintf"}, 2}, ::evalSprintf},
{{CDM::CLibrary, {"snprintf"}, 2}, ::evalSnprintf},
+ {{CDM::CLibrary,
https://github.com/steakhal requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/83675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/83675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/84446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Balazs Benics
Date: 2024-03-08T13:57:27+01:00
New Revision: 7457e2c1535acd548d2619dfb34eb93d27d15908
URL:
https://github.com/llvm/llvm-project/commit/7457e2c1535acd548d2619dfb34eb93d27d15908
DIFF:
https://github.com/llvm/llvm-project/commit/7457e2c1535acd548d2619dfb34eb93d27d15908.diff
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Sirraide)
Changes
This is still WIP, but I figured I’d open a pr anyway to share what I’ve
discovered so far. In short, dependence of captures in lambdas with an explicit
object parameter is all kinds of broken at the moment.
https://github.com/Sirraide converted_to_draft
https://github.com/llvm/llvm-project/pull/84473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide created
https://github.com/llvm/llvm-project/pull/84473
This is still WIP, but I figured I’d open a pr anyway to share what I’ve
discovered so far. In short, dependence of captures in lambdas with an explicit
object parameter is all kinds of broken at the moment.
https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/84400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Joseph Huber
Date: 2024-03-08T06:54:52-06:00
New Revision: 4d1d1271b8612c72e0020c9d9f42d2ef70f717e7
URL:
https://github.com/llvm/llvm-project/commit/4d1d1271b8612c72e0020c9d9f42d2ef70f717e7
DIFF:
https://github.com/llvm/llvm-project/commit/4d1d1271b8612c72e0020c9d9f42d2ef70f717e7.diff
@@ -6,7 +6,9 @@ typedef enum EnumA {
} EnumA;
enum EnumB {
- B
+ B,
AaronBallman wrote:
It might be good to capture some of what I wrote in the review summary as a
comment here so it's clear why this is correct in both C and C++.
@@ -264,11 +264,14 @@ namespace {
}
QualType Expr::getEnumCoercedType(const ASTContext ) const {
- if (isa(this->getType()))
-return this->getType();
- else if (const auto *ECD = this->getEnumConstantDecl())
-return Ctx.getTypeDeclType(cast(ECD->getDeclContext()));
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/84068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
Hmm, the rules are different between C and C++, but I think we may be okay. In
C++:
https://eel.is/c++draft/enum#dcl.enum-5.sentence-6
Following the closing brace of an enum-specifier, each enumerator has the type
of its enumeration.
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -41,12 +41,8 @@ class CallDescription {
/// - We also accept calls where the number of arguments or parameters is
///greater than the specified value.
/// For the exact heuristics,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
NagyDonat wrote:
Currently MallocChecker doesn't use this `CDM::CLibrary` mode in the
`CallDescription` for `malloc` -- because before this commit it would've been
incorrect to use it. I'm planning to ensure that
https://github.com/Szelethus edited
https://github.com/llvm/llvm-project/pull/84469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -41,12 +41,8 @@ class CallDescription {
/// - We also accept calls where the number of arguments or parameters is
///greater than the specified value.
/// For the exact heuristics, see CheckerContext::isCLibraryFunction().
-/// Note that functions whose
@@ -87,9 +87,11 @@ bool CheckerContext::isCLibraryFunction(const FunctionDecl
*FD,
if (!II)
return false;
- // Look through 'extern "C"' and anything similar invented in the future.
- // If this function is not in TU directly, it is not a C library function.
- if
301 - 400 of 487 matches
Mail list logo
