[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

2024-03-10 Thread YAMAMOTO Takashi via cfe-commits
yamt wrote: > Given that we don't need `setjmpTableSize` anymore and `setjmpTable` doesn't > change, we don't need the whole block here from line 1463 ~ line 1503 doing > SSA updates anymore: i get errors like the following if i simply put the SSA update things in `!EnableWasmAltSjLj` block.

[clang] [clang-format] Add Options to break inside the TableGen DAGArg. (PR #83149)

2024-03-10 Thread Hirofumi Nakamura via cfe-commits
https://github.com/hnakamura5 updated https://github.com/llvm/llvm-project/pull/83149 >From becb28f6daa1fed9cabe40375a7ed863207b6bd2 Mon Sep 17 00:00:00 2001 From: hnakamura5 Date: Wed, 28 Feb 2024 01:10:12 +0900 Subject: [PATCH 1/3] [clang-format] Add Options to break inside the TableGen

[clang] [llvm] [RISCV] Support RISC-V Profiles in -march option (PR #76357)

2024-03-10 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/76357 >From 8dc42f5c90ba369a145868f8c1a9a8cb3e988cb0 Mon Sep 17 00:00:00 2001 From: wangpc Date: Mon, 25 Dec 2023 18:52:36 +0800 Subject: [PATCH] [RISCV] Support RISC-V Profiles in -march option This PR implements

[clang] [clang-format] Add Options to break inside the TableGen DAGArg. (PR #83149)

2024-03-10 Thread Hirofumi Nakamura via cfe-commits
https://github.com/hnakamura5 edited https://github.com/llvm/llvm-project/pull/83149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add Options to break inside the TableGen DAGArg. (PR #83149)

2024-03-10 Thread Hirofumi Nakamura via cfe-commits
https://github.com/hnakamura5 updated https://github.com/llvm/llvm-project/pull/83149 >From becb28f6daa1fed9cabe40375a7ed863207b6bd2 Mon Sep 17 00:00:00 2001 From: hnakamura5 Date: Wed, 28 Feb 2024 01:10:12 +0900 Subject: [PATCH 1/2] [clang-format] Add Options to break inside the TableGen

[clang] 3f6bc1a - [C++20] [Moduls] Avoid computing odr hash for functions from comparing constraint expression

2024-03-10 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-03-11T11:39:21+08:00 New Revision: 3f6bc1adf805681293c2ef0b93b708ff52244c00 URL: https://github.com/llvm/llvm-project/commit/3f6bc1adf805681293c2ef0b93b708ff52244c00 DIFF: https://github.com/llvm/llvm-project/commit/3f6bc1adf805681293c2ef0b93b708ff52244c00.diff

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-10 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/77092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7dfa839 - [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (#77092)

2024-03-10 Thread via cfe-commits
Author: Amirreza Ashouri Date: 2024-03-11T04:23:23+01:00 New Revision: 7dfa8398354e435cdee5a8ea6d6b17d1e4557733 URL: https://github.com/llvm/llvm-project/commit/7dfa8398354e435cdee5a8ea6d6b17d1e4557733 DIFF:

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-10 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/77092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

2024-03-10 Thread YAMAMOTO Takashi via cfe-commits
yamt wrote: > @yamt, do you want to submit a PR to emscripten adding new library functions? > I can do that too, but given that this is your code, if you want to do it > it'd be good. About where to add them... to make the transition smooth, >

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-03-10 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/79712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f786881 - [coroutine] Implement llvm.coro.await.suspend intrinsic (#79712)

2024-03-10 Thread via cfe-commits
Author: fpasserby Date: 2024-03-11T10:00:00+08:00 New Revision: f78688134026686288a8d310b493d9327753a022 URL: https://github.com/llvm/llvm-project/commit/f78688134026686288a8d310b493d9327753a022 DIFF: https://github.com/llvm/llvm-project/commit/f78688134026686288a8d310b493d9327753a022.diff

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-03-10 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I'll merge this since I find you may not have commit access. https://github.com/llvm/llvm-project/pull/79712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Turn NodeBuilderContext into a class (PR #84638)

2024-03-10 Thread Diego A. Estrada Rivera via cfe-commits
diego-est wrote: I added the appropriate functions and moved the class members into private. Additionally I ran `make check-all` to make sure the now-private members wouldn't cause any issues with the rest of the codebase, all the checks passed. https://github.com/llvm/llvm-project/pull/84638

[clang] [analyzer] Turn NodeBuilderContext into a class (PR #84638)

2024-03-10 Thread Diego A. Estrada Rivera via cfe-commits
https://github.com/diego-est updated https://github.com/llvm/llvm-project/pull/84638 >From 114e22388508cd1ef5174bdda041564691b58032 Mon Sep 17 00:00:00 2001 From: Sunglas Date: Sat, 9 Mar 2024 12:23:43 -0400 Subject: [PATCH 1/2] [analyzer] Turn NodeBuilderContext into a class ---

[clang] [C++20][Coroutines] lambda-coroutine with promise_type ctor. (PR #84519)

2024-03-10 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/84519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use timeTraceAsyncProfilerBegin for Source span (PR #83961)

2024-03-10 Thread Takuto Ikuta via cfe-commits
atetubou wrote: @ZequanWu could you take a look this? https://github.com/llvm/llvm-project/pull/83961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-03-10 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM then. Thanks. https://github.com/llvm/llvm-project/pull/79712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

2024-03-10 Thread YAMAMOTO Takashi via cfe-commits
yamt wrote: > > In terms of getting this landed and tested, I wonder which path we should > > take: > > > > 1. Land this now, without tests, then update emscripten then come back and > > flip the default, at which point the existing tests will get updated. > > 2. Duplicate/update the the

[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

2024-03-10 Thread YAMAMOTO Takashi via cfe-commits
@@ -1738,10 +1792,16 @@ void WebAssemblyLowerEmscriptenEHSjLj::handleLongjmpableCallsForWasmSjLj( BasicBlock *ThenBB = BasicBlock::Create(C, "if.then", ); BasicBlock *EndBB = BasicBlock::Create(C, "if.end", ); Value *EnvP = IRB.CreateBitCast(Env, getAddrPtrType(),

[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

2024-03-10 Thread YAMAMOTO Takashi via cfe-commits
@@ -999,25 +1017,43 @@ bool WebAssemblyLowerEmscriptenEHSjLj::runOnModule(Module ) { // Register __wasm_longjmp function, which calls __builtin_wasm_longjmp. FunctionType *FTy = FunctionType::get( IRB.getVoidTy(), {Int8PtrTy, IRB.getInt32Ty()}, false); -

[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

2024-03-10 Thread YAMAMOTO Takashi via cfe-commits
@@ -1291,19 +1327,29 @@ bool WebAssemblyLowerEmscriptenEHSjLj::runSjLjOnFunction(Function ) { Type *IntPtrTy = getAddrIntType(); Constant *size = ConstantInt::get(IntPtrTy, 40); IRB.SetInsertPoint(SetjmpTableSize); - auto *SetjmpTable = IRB.CreateMalloc(IntPtrTy,

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

2024-03-10 Thread Phoebe Wang via cfe-commits
phoebewang wrote: Gentle ping~ https://github.com/llvm/llvm-project/pull/83136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

2024-03-10 Thread YAMAMOTO Takashi via cfe-commits
@@ -1291,19 +1327,29 @@ bool WebAssemblyLowerEmscriptenEHSjLj::runSjLjOnFunction(Function ) { Type *IntPtrTy = getAddrIntType(); Constant *size = ConstantInt::get(IntPtrTy, 40); IRB.SetInsertPoint(SetjmpTableSize); - auto *SetjmpTable = IRB.CreateMalloc(IntPtrTy,

[clang] [llvm] [WebAssembly] Implement an alternative translation for -wasm-enable-sjlj (PR #84137)

2024-03-10 Thread YAMAMOTO Takashi via cfe-commits
@@ -1291,19 +1327,29 @@ bool WebAssemblyLowerEmscriptenEHSjLj::runSjLjOnFunction(Function ) { Type *IntPtrTy = getAddrIntType(); Constant *size = ConstantInt::get(IntPtrTy, 40); IRB.SetInsertPoint(SetjmpTableSize); - auto *SetjmpTable = IRB.CreateMalloc(IntPtrTy,

[clang] [llvm] [CodeGen][AArch64][FMV] PAC the stub_helper's frame on arm64e (PR #84704)

2024-03-10 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,58 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals --include-generated-funcs +// RUN: %clang_cc1 -triple arm64e-apple-ios -target-feature +ls64 -target-feature

[clang] [llvm] [CodeGen][AArch64][FMV] PAC the stub_helper's frame on arm64e (PR #84704)

2024-03-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jon Roelofs (jroelofs) Changes ... and apply default function attributes so that the resolver will also be PAC'd (once more `arm64e` patches land upstream). --- Full diff: https://github.com/llvm/llvm-project/pull/84704.diff 6 Files

[clang] [llvm] [CodeGen][AArch64][FMV] PAC the stub_helper's frame on arm64e (PR #84704)

2024-03-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Jon Roelofs (jroelofs) Changes ... and apply default function attributes so that the resolver will also be PAC'd (once more `arm64e` patches land upstream). --- Full diff: https://github.com/llvm/llvm-project/pull/84704.diff 6

[clang] [llvm] [CodeGen][AArch64][FMV] PAC the stub_helper's frame on arm64e (PR #84704)

2024-03-10 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs created https://github.com/llvm/llvm-project/pull/84704 ... and apply default function attributes so that the resolver will also be PAC'd (once more `arm64e` patches land upstream). >From b352a41e1788819afbb15a5b6d79cbf2968dc5dc Mon Sep 17 00:00:00 2001 From: Jon

[clang] [llvm] BPF address space insn (PR #84410)

2024-03-10 Thread via cfe-commits
@@ -0,0 +1,52 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4 +; RUN: opt --bpf-check-and-opt-ir -S -mtriple=bpf-pc-linux < %s | FileCheck %s + +; Generated from the following C code: +; +; extern int __uptr *magic1(); +;

[clang] [clang-format][NFC] Eliminate the IsCpp parameter in all functions (PR #84599)

2024-03-10 Thread Owen Pan via cfe-commits
owenca wrote: > Then I'd go back to `Style.isCpp()`. That would still require passing `Style.isCpp()` as the parameter to the `FormatToken` (and other) functions. > What happens if you use libFormat concurrently? Can you elaborate? Doesn't each process get its own copy of the globals of a

[clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-03-10 Thread Stephan Bergmann via cfe-commits
stbergmann wrote: This change started to cause ``` $ cat test.cc template struct P { ~P() { p->f(); } T * p; }; struct X; struct B { virtual ~B(); }; struct S: B { P x; }; ``` ``` $ clang++ -std=c++23 -fsyntax-only test.cc test.cc:2:13: error: member access into incomplete type 'X' 2

[clang] [compiler-rt] [clang][UBSan] Add implicit conversion check for bitfields (PR #75481)

2024-03-10 Thread Axel Lundberg via cfe-commits
https://github.com/Zonotora updated https://github.com/llvm/llvm-project/pull/75481 >From cd64144a4cf18adba1494871bfd9da1b0bf0a489 Mon Sep 17 00:00:00 2001 From: Zonotora Date: Sat, 16 Dec 2023 19:33:21 +0100 Subject: [PATCH 1/3] [clang] Extract negativity check lambda to function ---

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-10 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/77092 >From ed94371b8e2293642731b72948883c2ec20bd09d Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Wed, 3 Jan 2024 23:23:14 +0330 Subject: [PATCH 1/4] [clang] Fix behavior of

[clang] [clang][analyzer] Improve BlockInCriticalSectionsChecker (PR #80029)

2024-03-10 Thread Endre Fülöp via cfe-commits
gamesh411 wrote: As keeping the trivial change that this PR was before, and thanks to the fact that the checker needed a major overhaul, I have increased the scope of this change to support the use cases mentioned by @balazske. That is why I am re-requesting a review.

[clang] [clang][analyzer] Improve BlockInCriticalSectionsChecker (PR #80029)

2024-03-10 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 edited https://github.com/llvm/llvm-project/pull/80029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-10 Thread Amirreza Ashouri via cfe-commits
@@ -249,6 +249,12 @@ Bug Fixes in This Version - Clang now doesn't produce false-positive warning `-Wconstant-logical-operand` for logical operators in C23. + Fixes (`#64356 `_). +- ``__is_trivially_relocatable`` no longer

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-10 Thread Amirreza Ashouri via cfe-commits
https://github.com/AMP999 updated https://github.com/llvm/llvm-project/pull/77092 >From ed94371b8e2293642731b72948883c2ec20bd09d Mon Sep 17 00:00:00 2001 From: Amirreza Ashouri Date: Wed, 3 Jan 2024 23:23:14 +0330 Subject: [PATCH 1/3] [clang] Fix behavior of

[clang] [clang][analyzer] Add note tags to alpha.unix.BlockInCriticalSection (PR #80029)

2024-03-10 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/80029 From 346e2296869e750c7ec5bd75cf05f80a23b70569 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Tue, 30 Jan 2024 11:33:30 +0100 Subject: [PATCH] [clang][analyzer] Improve

[clang] [clang-format][NFC] Eliminate the IsCpp parameter in all functions (PR #84599)

2024-03-10 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: Then I'd go back to `Style.isCpp()`. What happens if you use libFormat concurrently? https://github.com/llvm/llvm-project/pull/84599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] New calling convention preserve_none (PR #76868)

2024-03-10 Thread Caleb Helbling via cfe-commits
calebh wrote: We have another use case for this calling convention - micropatching. See my coworker's blog post on how this would work: https://www.philipzucker.com/permutation_compile/ Is there a reason why r10 isn't included in the list of registers for x64? Having support for additional

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-10 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 ready_for_review https://github.com/llvm/llvm-project/pull/82947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-10 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/82947 From f1d957413bcc81e9ced06ad40570859769f4c1c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 25 Feb 2024 20:20:59 -0500 Subject: [PATCH 1/6] [clang-tidy] Improved

[clang] [clang-repl] Expose CreateExecutor() and ResetExecutor() in extended Interpreter interface (PR #84460)

2024-03-10 Thread Stefan Gränitz via cfe-commits
https://github.com/weliveindetail updated https://github.com/llvm/llvm-project/pull/84460 From 10f8d3eb040a5838d84d8a84fe636c7c2a7d196b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?= Date: Fri, 8 Mar 2024 00:08:56 +0100 Subject: [PATCH 1/3] [clang-repl] Expose

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-10 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 converted_to_draft https://github.com/llvm/llvm-project/pull/82947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstCombine] Canonicalize `(sitofp x)` -> `(uitofp x)` if `x >= 0` (PR #82404)

2024-03-10 Thread via cfe-commits
goldsteinn wrote: > It looks like you need to update `Headers/__clang_hip_math.hip` in clang. Fixed. Thats what I get for not running clang tests :/ https://github.com/llvm/llvm-project/pull/82404 ___ cfe-commits mailing list

[clang] [llvm] [InstCombine] Canonicalize `(sitofp x)` -> `(uitofp x)` if `x >= 0` (PR #82404)

2024-03-10 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/82404 >From 08fddf10b8d78f5cf866dcb687009f20cfb85bd3 Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Tue, 20 Feb 2024 12:51:02 -0600 Subject: [PATCH] [InstCombine] Canonicalize `(sitofp x)` -> `(uitofp x)` if

[clang] [clang-format] Fix a bug in annotating function declaration names (PR #76206)

2024-03-10 Thread Matt Mundell via cfe-commits
mattmundell wrote: Thanks @owenca, I added an argument name instead ([cb983df](https://github.com/greenbone/gvmd/pull/2112/commits/cb983dfada959f0f73bfed7a438e5c79898408d6)). https://github.com/llvm/llvm-project/pull/76206 ___ cfe-commits mailing

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-10 Thread Félix-Antoine Constantin via cfe-commits
felix642 wrote: Thank you for the quick review @PiotrZSL. I've implemented the proposed changes and rebased on top of main. We can wait a few days to see if someone else has some comments to add and then we should be ready to merge https://github.com/llvm/llvm-project/pull/82947

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-10 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 ready_for_review https://github.com/llvm/llvm-project/pull/82947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-10 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/82947 From f1d957413bcc81e9ced06ad40570859769f4c1c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 25 Feb 2024 20:20:59 -0500 Subject: [PATCH 1/5] [clang-tidy] Improved

[clang-tools-extra] [clang-tidy] Improved modernize-use-using by fixing a false-negative (PR #82947)

2024-03-10 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/82947 From d1cbed0e2e83bd3544067fd25d7e811f1ab3f095 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Sun, 25 Feb 2024 20:20:59 -0500 Subject: [PATCH 1/4] [clang-tidy] Improved

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-03-10 Thread via cfe-commits
https://github.com/guillem-bartina-sonarsource updated https://github.com/llvm/llvm-project/pull/84515 >From 473e8bbeaa8bcb4fb313a5cc75cc7a5de5367879 Mon Sep 17 00:00:00 2001 From: guillem-bartina-sonarsource Date: Fri, 8 Mar 2024 17:16:56 +0100 Subject: [PATCH] [clang][Sema] Refine

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-03-10 Thread via cfe-commits
https://github.com/guillem-bartina-sonarsource edited https://github.com/llvm/llvm-project/pull/84515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-03-10 Thread via cfe-commits
@@ -1398,11 +1398,16 @@ void Sema::ActOnEndOfTranslationUnit() { if (FD->getDescribedFunctionTemplate()) Diag(DiagD->getLocation(), diag::warn_unused_template) << /*function=*/0 << DiagD << DiagRange; - else -

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-03-10 Thread via cfe-commits
fpasserby wrote: > Thanks. This looks good to me except few nit comments. > > Have you tested on a real world workloads? I've tested it on seastar and libcppcoro tests and on the example from #72006. https://github.com/llvm/llvm-project/pull/79712

[clang] [analyzer] Turn NodeBuilderContext into a class (PR #84638)

2024-03-10 Thread Balazs Benics via cfe-commits
https://github.com/steakhal requested changes to this pull request. See my previous reply. https://github.com/llvm/llvm-project/pull/84638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [analyzer] Turn NodeBuilderContext into a class (PR #84638)

2024-03-10 Thread Balazs Benics via cfe-commits
steakhal wrote: Thanks for the PR. I think it would make sense to not expose data members in a class' public api. We might need some member functions along the way to make this possible. https://github.com/llvm/llvm-project/pull/84638 ___ cfe-commits

[clang] [Clang] [Parser] Support [[omp::assume]] (PR #84582)

2024-03-10 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/84582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-03-10 Thread via cfe-commits
@@ -1227,12 +1227,11 @@ C++14 implementation status -(7): In Clang 3.7 and later, sized deallocation is only enabled -if the user passes the -fsized-deallocation flag. The user must -supply definitions of the sized deallocation functions, either by providing them

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-03-10 Thread via cfe-commits
https://github.com/cor3ntin commented: The `__cpp_sized_deallocation` feature test macro should be set to 201309L https://github.com/llvm/llvm-project/pull/83774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-03-10 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/83774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-10 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/77092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix behavior of `__is_trivially_relocatable(volatile int)` (PR #77092)

2024-03-10 Thread via cfe-commits
@@ -249,6 +249,12 @@ Bug Fixes in This Version - Clang now doesn't produce false-positive warning `-Wconstant-logical-operand` for logical operators in C23. + Fixes (`#64356 `_). +- ``__is_trivially_relocatable`` no longer

[clang] [Clang][Sema] Fix a bug on type constraint checking (PR #84671)

2024-03-10 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/84671 >From fba48b8ca75113fc8226e065c85ce276a4e9ed6b Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 10 Mar 2024 16:11:18 +0800 Subject: [PATCH] [Clang][Sema] Fix a bug on type constraint checking ---

[clang] [Clang][Sema] Fix a bug on type constraint checking (PR #84671)

2024-03-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qizhi Hu (jcsxky) Changes Try to fix https://github.com/llvm/llvm-project/issues/84368 [temp.friend]p1: Similarly, each specialization of the `task` class template has the class template specialization `taskint` as a friend, and has all

[clang] [Clang][Sema] Fix a bug on type constraint checking (PR #84671)

2024-03-10 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky created https://github.com/llvm/llvm-project/pull/84671 Try to fix https://github.com/llvm/llvm-project/issues/84368 [temp.friend]p1: Similarly, each specialization of the `task` class template has the class template specialization `task` as a friend, and has all