[clang] 9936ac3 - [docs] Prefer --gcc-install-dir= to deprecated GCC_INSTALL_PREFIX (#85458)

2024-03-18 Thread via cfe-commits
Author: Fangrui Song Date: 2024-03-18T13:11:44-07:00 New Revision: 9936ac308332796bf16024ce30a4aa1fba2cce66 URL: https://github.com/llvm/llvm-project/commit/9936ac308332796bf16024ce30a4aa1fba2cce66 DIFF: https://github.com/llvm/llvm-project/commit/9936ac308332796bf16024ce30a4aa1fba2cce66.diff

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #81545)

2024-03-18 Thread William Junda Huang via cfe-commits
huangjd wrote: My concern to enable this feature by default is that there are some less known syntax (probably from other supported languages or extensions) that has a MemberExpr but actually emitting something unexpected, which could cause a crash. I am testing this feature on some real-life

[clang] [clang-format] Add --fail-on-incomplete-format. (PR #84346)

2024-03-18 Thread Roberto Bampi via cfe-commits
gigaroby wrote: I think the documentation failure is related to https://github.com/llvm/llvm-project/commit/0c423af59c971ddf1aa12d94529edf8293608157 but I might be wrong. https://github.com/llvm/llvm-project/pull/84346 ___ cfe-commits mailing list

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-03-18 Thread Adrian Prantl via cfe-commits
@@ -8,8 +8,8 @@ struct S0 { // CHECK-LABEL: define dso_local void @_Z3fS0v // CHECK:alloca %struct.S0, align 4 // CHECK-NEXT:[[TMP0:%.*]] = alloca %struct.S0, align 4 -// CHECK: call void @llvm.dbg.declare(metadata ptr [[TMP0]], metadata

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-03-18 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/85665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-03-18 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl requested changes to this pull request. https://github.com/llvm/llvm-project/pull/85665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstallAPI] Verify that declarations in headers map to exports found in dylib (PR #85348)

2024-03-18 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/85348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Coroutines: Properly Check if `await_suspend` return type convertible to `std::coroutine_handle<>` (PR #85684)

2024-03-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines Author: Yuxuan Chen (yuxuanchen1997) Changes This patch aims to fix https://github.com/llvm/llvm-project/issues/77111 The original issue is crash-on-invalid. However, Clang currently accepts programs where `await_suspend` returns a type

[clang] [Clang] Coroutines: Properly Check if `await_suspend` return type convertible to `std::coroutine_handle<>` (PR #85684)

2024-03-18 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 created https://github.com/llvm/llvm-project/pull/85684 This patch aims to fix https://github.com/llvm/llvm-project/issues/77111 The original issue is crash-on-invalid. However, Clang currently accepts programs where `await_suspend` returns a type that's

[clang] [WebAssembly] Change the default linker for `wasm32-wasip2` (PR #84569)

2024-03-18 Thread Alex Crichton via cfe-commits
https://github.com/alexcrichton updated https://github.com/llvm/llvm-project/pull/84569 >From 99ca952b60344d2ff683d05d8baa423aa11da83a Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Fri, 8 Mar 2024 13:36:18 -0800 Subject: [PATCH 1/2] [WebAssembly] Change the default linker for

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #81545)

2024-03-18 Thread David Blaikie via cfe-commits
dwblaikie wrote: Reading LLVM IR lit CHECK lines from clang codegen is a bit difficult - could you include some simple examples (perhaps from the new clang tests in this patch) showing the DWARF output just as comments in this review for something more easily glanceable? As for flags - I

[clang] [WebAssembly] Change the default linker for `wasm32-wasip2` (PR #84569)

2024-03-18 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode approved this pull request. Looks good! https://github.com/llvm/llvm-project/pull/84569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Change the default linker for `wasm32-wasip2` (PR #84569)

2024-03-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7d55b916a5e5091ff21d6fea4aaa54efe73535a7 d1a1b22da3e1361a34f2d4fa8a2f9ef361f109ee --

[clang] [WebAssembly] Change the default linker for `wasm32-wasip2` (PR #84569)

2024-03-18 Thread Alex Crichton via cfe-commits
alexcrichton wrote: At @sunfishcode's request I've pushed up a second commit which pass the path to `wasm-ld` to `wasm-component-ld`, and in testing it I also added the ability for `-fuse-ld=lld` to explicitly request that `wasm-ld` is used, regardless of target.

[clang] [WebAssembly] Change the default linker for `wasm32-wasip2` (PR #84569)

2024-03-18 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/84569 >From 99ca952b60344d2ff683d05d8baa423aa11da83a Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Fri, 8 Mar 2024 13:36:18 -0800 Subject: [PATCH 1/2] [WebAssembly] Change the default linker for `wasm32-wasip2`

[clang] [WebAssembly] Change the default linker for `wasm32-wasip2` (PR #84569)

2024-03-18 Thread Alex Crichton via cfe-commits
https://github.com/alexcrichton updated https://github.com/llvm/llvm-project/pull/84569 >From 99ca952b60344d2ff683d05d8baa423aa11da83a Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Fri, 8 Mar 2024 13:36:18 -0800 Subject: [PATCH 1/2] [WebAssembly] Change the default linker for

[clang] [llvm] [openmp] [OpenMP] Increment kernel args version, used by runtime for detecting dyn_ptr. (PR #85363)

2024-03-18 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert approved this pull request. LG. https://github.com/llvm/llvm-project/pull/85363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add soft-float ABI (PR #84146)

2024-03-18 Thread via cfe-commits
https://github.com/Prabhuk approved this pull request. https://github.com/llvm/llvm-project/pull/84146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add soft-float ABI (PR #84146)

2024-03-18 Thread via cfe-commits
Prabhuk wrote: Verified that the reproducer for the original crash fails before the revert patch: https://github.com/llvm/llvm-project/pull/82032/commits/13bf4429ba2e33f9069f632c974d8fdf121acefa and toolchain built with current patch *does not fail* against the reproducer. Though I haven't

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #84014)

2024-03-18 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/84014 >From bdefe754c14c5e050ebf2b9c82eca458041564a4 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 5 Mar 2024 05:35:16 -0800 Subject: [PATCH 01/10] [clang-cl] Fix value of __FUNCTION__ in MSVC mode.

[clang] [clang][dataflow] Make optional checker work for types derived from optional. (PR #84138)

2024-03-18 Thread Yitzhak Mandelbaum via cfe-commits
@@ -129,19 +215,19 @@ auto inPlaceClass() { auto isOptionalNulloptConstructor() { return cxxConstructExpr( - hasOptionalType(), + hasOptionalOrDerivedType(), ymand wrote: Here and below -- now that this matcher is more expensive, please move

[clang] [clang] Set correct FPOptions if attribute 'optnone' presents (PR #85605)

2024-03-18 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: I have uploaded your patch and compared the attributes generated from your patch and the little test case from https://github.com/llvm/llvm-project/issues/62098. The attributes generated are different. Therefore, the expected optimizations from this patch are going to be

[clang] [clang][dataflow] Make optional checker work for types derived from optional. (PR #84138)

2024-03-18 Thread Yitzhak Mandelbaum via cfe-commits
@@ -64,39 +64,117 @@ static bool hasOptionalClassName(const CXXRecordDecl ) { return false; } +static const CXXRecordDecl *getOptionalBaseClass(const CXXRecordDecl *RD) { + if (RD == nullptr) +return nullptr; + if (hasOptionalClassName(*RD)) +return RD; + + if

[clang] [clang][dataflow] Make optional checker work for types derived from optional. (PR #84138)

2024-03-18 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/84138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Make optional checker work for types derived from optional. (PR #84138)

2024-03-18 Thread Yitzhak Mandelbaum via cfe-commits
@@ -119,20 +119,28 @@ QualType getPublicType(const Expr *E) { return Ty; } - QualType Ty = getPublicType(Cast->getSubExpr()); - - // Is `Ty` the type of `*this`? In this special case, we can upcast to the - // base class even if the base is non-public. - bool

[clang] [clang][dataflow] Make optional checker work for types derived from optional. (PR #84138)

2024-03-18 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/84138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-18 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/85623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add soft-float ABI (PR #84146)

2024-03-18 Thread via cfe-commits
Prabhuk wrote: Apologies that this had slipped out of my radar. I am trying this patch now agains the reproducer from the original failure. I'll update the results here in a few hours. Thank you. https://github.com/llvm/llvm-project/pull/84146 ___

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #84014)

2024-03-18 Thread Aaron Ballman via cfe-commits
@@ -855,7 +865,14 @@ void DeclPrinter::VisitFunctionDecl(FunctionDecl *D) { Out << Proto << " -> "; Proto.clear(); } - AFT->getReturnType().print(Out, Policy, Proto); + if (!Policy.SuppressTagKeyword && Policy.SuppressScope && +

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #84014)

2024-03-18 Thread Aaron Ballman via cfe-commits
@@ -1022,7 +1039,13 @@ void DeclPrinter::VisitVarDecl(VarDecl *D) { ? D->getIdentifier()->deuglifiedName() : D->getName(); - printDeclType(T, Name); + if (!Policy.SuppressTagKeyword && Policy.SuppressScope && + !Policy.SuppressUnwrittenScope)

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #84014)

2024-03-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/84014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #84014)

2024-03-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I spotted some simplifications that can be applied. If precommit CI comes back green, then I think this is basically ready to go. https://github.com/llvm/llvm-project/pull/84014 ___ cfe-commits mailing list

[clang] [clang] Set correct FPOptions if attribute 'optnone' presents (PR #85605)

2024-03-18 Thread John McCall via cfe-commits
rjmccall wrote: > > Hmm. Is there some sort of optimization in IRGen that we need to suppress > > here, or is it something in LLVM code gen? Presumably normal LLVM > > optimization passes all just skip `optnone` functions. > > The issue #62098 demonstrates such case. Okay. So if I

[clang] [clang][dataflow] Make optional checker work for types derived from optional. (PR #84138)

2024-03-18 Thread via cfe-commits
martinboehme wrote: Forgot to push a fixup commit -- now added. https://github.com/llvm/llvm-project/pull/84138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Make optional checker work for types derived from optional. (PR #84138)

2024-03-18 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/84138 >From 209aac483514f6d041486f36e6dabec78598fcec Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 12 Mar 2024 15:56:41 + Subject: [PATCH 1/2] [clang][dataflow] Make optional checker work for types

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-03-18 Thread Aaron Ballman via cfe-commits
@@ -7639,6 +7639,8 @@ def err_attribute_arm_mve_polymorphism : Error< "'__clang_arm_mve_strict_polymorphism' attribute can only be applied to an MVE/NEON vector type">; def err_attribute_webassembly_funcref : Error< "'__funcref' attribute can only be applied to a function

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-03-18 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,27 @@ +// RUN: %clang_cc1 -std=c2x -verify %s + +/* WG14 N3006: Full + * Underspecified object declarations + */ + +struct S1 { int x, y; };// expected-note {{previous definition is here}} +union U1 { int a; double b; }; // expected-note {{previous definition

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-03-18 Thread Aaron Ballman via cfe-commits
@@ -7813,6 +7813,32 @@ Sema::BuildCompoundLiteralExpr(SourceLocation LParenLoc, TypeSourceInfo *TInfo, diag::err_variable_object_no_init)) return ExprError(); } + } else if (LangOpts.C23 && AaronBallman

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-03-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! I think there's something here worth considering: how an implementation handles use of underspecified declarations is left implementation-defined. I think we want to diagnose many of the situations it covers, but I

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-03-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/79845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

2024-03-18 Thread via cfe-commits
sjanel wrote: The [amc](https://github.com/AmadeusITGroup/amc) library defining drop-in replacement for vector-like containers handling trivially relocatability optimizations would love to see this kind of improvement, as currently the users need to manually tell the compiler which types are

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-03-18 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/85672 >From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Mon, 18 Mar 2024 10:19:38 -0700 Subject: [PATCH 1/4] [clang][CodeGen] Omit pre-opt link when post-opt link

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-03-18 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/85672 >From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Mon, 18 Mar 2024 10:19:38 -0700 Subject: [PATCH 1/3] [clang][CodeGen] Omit pre-opt link when post-opt link

[clang] [cmake] Disable FatLTO in clang build for Fuchsia (PR #85677)

2024-03-18 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/85677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 457f762 - [cmake] Disable FatLTO in clang build for Fuchsia (#85677)

2024-03-18 Thread via cfe-commits
Author: Paul Kirth Date: 2024-03-18T11:29:42-07:00 New Revision: 457f762651e331341872abccbb7d7724c89cbf50 URL: https://github.com/llvm/llvm-project/commit/457f762651e331341872abccbb7d7724c89cbf50 DIFF: https://github.com/llvm/llvm-project/commit/457f762651e331341872abccbb7d7724c89cbf50.diff

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2024-03-18 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: Any other comments? Do the changes look good? https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Disable FatLTO in clang build for Fuchsia (PR #85677)

2024-03-18 Thread Andres Villegas via cfe-commits
https://github.com/avillega approved this pull request. https://github.com/llvm/llvm-project/pull/85677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Disable FatLTO in clang build for Fuchsia (PR #85677)

2024-03-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul Kirth (ilovepi) Changes We're seeing an issue on Macs, which shouldn't be using this config, so we will temporarily disable this while we investigate. --- Full diff: https://github.com/llvm/llvm-project/pull/85677.diff 1 Files

[clang] [cmake] Disable FatLTO in clang build for Fuchsia (PR #85677)

2024-03-18 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/85677 We're seeing an issue on Macs, which shouldn't be using this config, so we will temporarily disable this while we investigate. >From 56e6059431398d126420b3595d58c3c19e20613b Mon Sep 17 00:00:00 2001 From: Paul

[clang] [clang] Set correct FPOptions if attribute 'optnone' presents (PR #85605)

2024-03-18 Thread Serge Pavlov via cfe-commits
spavloff wrote: > Hmm. Is there some sort of optimization in IRGen that we need to suppress > here, or is it something in LLVM code gen? Presumably normal LLVM > optimization passes all just skip `optnone` functions. The issue https://github.com/llvm/llvm-project/issues/62098 demonstrates

[clang] [HIP] do not link runtime for -r (PR #85675)

2024-03-18 Thread Siu Chi Chan via cfe-commits
https://github.com/scchan approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/85675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver,AArch64] Remove AArch32-specific -m[no-]unaligned-access (PR #85441)

2024-03-18 Thread Peter Smith via cfe-commits
smithp35 wrote: > > If possible I would prefer to keep -m[no-]unaligned-access for AArch64. > > The history of this option name derives from Arm's proprietary compiler > >

[clang] [clang-format][NFC] Eliminate the IsCpp parameter in all functions (PR #84599)

2024-03-18 Thread Benjamin Kramer via cfe-commits
d0k wrote: This is now breaking multithreaded IDE use cases, can you explain why this change is necessary? https://github.com/llvm/llvm-project/pull/84599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [HIP] do not link runtime for -r (PR #85675)

2024-03-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 705788c84623b4f1dab72a108e039a0de2d53cf6 6d6b362fbf965706108362a55c894588e80ad778 --

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-03-18 Thread Amy Kwan via cfe-commits
@@ -16570,32 +16570,53 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned BuiltinID, #include "llvm/TargetParser/PPCTargetParser.def" auto GenAIXPPCBuiltinCpuExpr = [&](unsigned SupportMethod, unsigned FieldIdx, - unsigned CompOp, +

[clang] [HIP] do not link runtime for -r (PR #85675)

2024-03-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/85675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] do not link runtime for -r (PR #85675)

2024-03-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Yaxun (Sam) Liu (yxsamliu) Changes since it will cause duplicate symbols when the partially linked object is linked again. Change-Id: I2aea39ad0d57d3dc80b6aff395d9506ab9ebbf4d --- Full diff:

[clang] [HIP] do not link runtime for -r (PR #85675)

2024-03-18 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/85675 since it will cause duplicate symbols when the partially linked object is linked again. Change-Id: I2aea39ad0d57d3dc80b6aff395d9506ab9ebbf4d >From 6d6b362fbf965706108362a55c894588e80ad778 Mon Sep 17 00:00:00

[clang] [WebAssembly] Change the default linker for `wasm32-wasip2` (PR #84569)

2024-03-18 Thread Sam Clegg via cfe-commits
https://github.com/sbc100 approved this pull request. https://github.com/llvm/llvm-project/pull/84569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AsmPrinter,X86] Hard code AT syntax input for module-level inline assembly for MSVC triples (PR #85668)

2024-03-18 Thread Fangrui Song via cfe-commits
MaskRay wrote: Thanks. Fixing it on the Chromium feels nicer to me as well. This should work around the code if you run into more code needing this :) Personally I suspect not, since module-level inline asm with instructions are very rarely used (non-instruction directives are uses more).

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-03-18 Thread via cfe-commits
b-sumner wrote: This seems like it could have a significant hit on performance. Have the runtime performance effects been measured? https://github.com/llvm/llvm-project/pull/85672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-03-18 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j updated https://github.com/llvm/llvm-project/pull/85672 >From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Mon, 18 Mar 2024 10:19:38 -0700 Subject: [PATCH 1/2] [clang][CodeGen] Omit pre-opt link when post-opt link

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-03-18 Thread zhijian lin via cfe-commits
https://github.com/diggerlin updated https://github.com/llvm/llvm-project/pull/82809 >From 557e7163d744890aadfa703a81a0c4f2cd112517 Mon Sep 17 00:00:00 2001 From: zhijian Date: Fri, 23 Feb 2024 13:23:18 -0500 Subject: [PATCH 1/5] Implement a subset of builtin_cpu_supports() features ---

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-03-18 Thread Amy Kwan via cfe-commits
@@ -141,46 +149,98 @@ PPC_LNX_CPU("power10",47) #define AIX_BUILTIN_PPC_TRUE 1 #define AIX_BUILTIN_PPC_FALSE 0 #define USE_SYS_CONF 2 - - // Supported COMPARE_OP values. - #define COMP_EQ 0 - + #define SYS_CALL 3 #endif // The value of SUPPORT_METHOD can be

[clang] [Driver] -fsanitize=undefined: don't expand to signed-integer-overflow if -fwrapv (PR #85501)

2024-03-18 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/85501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AsmPrinter,X86] Hard code AT syntax input for module-level inline assembly for MSVC triples (PR #85668)

2024-03-18 Thread via cfe-commits
https://github.com/zmodem commented: https://g-issues.chromium.org/issues/330163686#comment5 suggested maybe the fix should be on the Chromium side https://github.com/llvm/llvm-project/pull/85668 ___ cfe-commits mailing list

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-03-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Jacob Lambert (lamb-j) Changes Currently, when the -relink-builtin-bitcodes-postop option is used we link builtin bitcodes twice: once before optimization, and again after optimization. With this change, we omit the pre-opt

[clang] [clang][CodeGen] Omit pre-opt link when post-opt is link requested (PR #85672)

2024-03-18 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j created https://github.com/llvm/llvm-project/pull/85672 Currently, when the -relink-builtin-bitcodes-postop option is used we link builtin bitcodes twice: once before optimization, and again after optimization. With this change, we omit the pre-opt linking when the

[clang] [clang] Add `__has_extension(swiftcc)` support (PR #85347)

2024-03-18 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. Yeah, it's fine with me. https://github.com/llvm/llvm-project/pull/85347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver,AArch64] Remove AArch32-specific -m[no-]unaligned-access (PR #85441)

2024-03-18 Thread Fangrui Song via cfe-commits
MaskRay wrote: > If possible I would prefer to keep -m[no-]unaligned-access for AArch64. > > The history of this option name derives from Arm's proprietary compiler >

[clang] [clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-03-18 Thread via cfe-commits
https://github.com/AtariDreams reopened https://github.com/llvm/llvm-project/pull/81367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-03-18 Thread via cfe-commits
https://github.com/AtariDreams closed https://github.com/llvm/llvm-project/pull/81367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AsmPrinter,X86] Hard code AT syntax input for module-level inline assembly for MSVC triples (PR #85668)

2024-03-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/85668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver,AArch64] Remove AArch32-specific -m[no-]unaligned-access (PR #85441)

2024-03-18 Thread Jon Roelofs via cfe-commits
jroelofs wrote: > If Apple platforms need this option, I can keep it recognized but only for > Apple. I don't see any projects that use `-m(no-)unaligned-access`, but it could be that I don't have permissions on ones that do. I'll give our qualification team a heads-up if/when you land it,

[clang] [WebAssembly] Change the default linker for `wasm32-wasip2` (PR #84569)

2024-03-18 Thread Alex Crichton via cfe-commits
alexcrichton wrote: ping @sbc100, happy to answer any more questions if you have them! I was tentatively hoping this could get backported to an 18.1.x release so we could get a wasi-sdk release with p1/p2/etc https://github.com/llvm/llvm-project/pull/84569

[clang] [llvm] [AsmPrinter,X86] Hard code AT syntax input for module-level inline assembly for MSVC triples (PR #85668)

2024-03-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Fangrui Song (MaskRay) Changes clang-cl is conflating input assembly syntax with output assembly syntax. It expects ATT syntax input but Intel syntax output. This conflicts with clang -c -masm=intel users that do expect -masm=intel

[clang] [llvm] [AsmPrinter,X86] Hard code AT syntax input for module-level inline assembly for MSVC triples (PR #85668)

2024-03-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/85668 clang-cl is conflating input assembly syntax with output assembly syntax. It expects AT syntax input but Intel syntax output. This conflicts with clang -c -masm=intel users that do expect -masm=intel to control

[clang] [clang] Better bitfield access units (PR #65742)

2024-03-18 Thread John McCall via cfe-commits
rjmccall wrote: Yeah, we don't need to care about the actual bit offset of the zero-width bit-field as long as we honor the non-interference properties across it. I'll take a look at the patch, thanks. https://github.com/llvm/llvm-project/pull/65742

[clang] [clang] Set correct FPOptions if attribute 'optnone' presents (PR #85605)

2024-03-18 Thread Serge Pavlov via cfe-commits
https://github.com/spavloff updated https://github.com/llvm/llvm-project/pull/85605 >From 5049e0209e240f0f8a3ccb6e248d55d1480b7bad Mon Sep 17 00:00:00 2001 From: Serge Pavlov Date: Mon, 18 Mar 2024 13:20:15 +0700 Subject: [PATCH] [clang] Set correct FPOptions if attribute 'optnone' presents

[clang] 280c7a9 - [Clang] Fix preprocessing device only in HIP mode

2024-03-18 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-03-18T12:12:17-05:00 New Revision: 280c7a9526a9ae7f959117c9cec94f8c8887f15c URL: https://github.com/llvm/llvm-project/commit/280c7a9526a9ae7f959117c9cec94f8c8887f15c DIFF: https://github.com/llvm/llvm-project/commit/280c7a9526a9ae7f959117c9cec94f8c8887f15c.diff

[clang] [clang] Better bitfield access units (PR #65742)

2024-03-18 Thread Nathan Sidwell via cfe-commits
urnathan wrote: @rjmccall here is a rebase an update, which I think addresses all your comments. I did make some material changes though: 1) I removed the Volatile handling. I was always a little uncomfortable with it because it didn't affect the access units of a non-volatile bitfield that

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-03-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir @llvm/pr-subscribers-clang Author: John Brawn (john-brawn-arm) Changes Currently we use DW_OP_plus_uconst to handle the bitfield offset and handle the bitfield size by choosing a type size that matches, but this doesn't work if either offset

[clang] [llvm] [DebugInfo] Use DW_op_bit_piece for structured bindings of bitfields (PR #85665)

2024-03-18 Thread John Brawn via cfe-commits
https://github.com/john-brawn-arm created https://github.com/llvm/llvm-project/pull/85665 Currently we use DW_OP_plus_uconst to handle the bitfield offset and handle the bitfield size by choosing a type size that matches, but this doesn't work if either offset or size aren't byte-aligned.

[clang] [clang][analyzer] Improve BlockInCriticalSectionsChecker (PR #80029)

2024-03-18 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 closed https://github.com/llvm/llvm-project/pull/80029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 705788c - [clang][analyzer] Improve BlockInCriticalSectionsChecker (#80029)

2024-03-18 Thread via cfe-commits
Author: Endre Fülöp Date: 2024-03-18T17:56:15+01:00 New Revision: 705788c84623b4f1dab72a108e039a0de2d53cf6 URL: https://github.com/llvm/llvm-project/commit/705788c84623b4f1dab72a108e039a0de2d53cf6 DIFF: https://github.com/llvm/llvm-project/commit/705788c84623b4f1dab72a108e039a0de2d53cf6.diff

[clang] [clang-format] Fix clang-format issue with 'new' and 'delete' keywords in C files (PR #85470)

2024-03-18 Thread via cfe-commits
@@ -11450,6 +11450,11 @@ TEST_F(FormatTest, UnderstandsNewAndDelete) { "void new (link p);\n" "void delete (link p);"); + verifyFormat("{ p->delete(); }\n" + "{ p->new(); }", + "{ p->delete (); }\n" + "{

[clang] [llvm] [DXIL] implement dot intrinsic lowering for integers (PR #85662)

2024-03-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-llvm-ir Author: Farzon Lotfi (farzonl) Changes this implements part 1 of 2 for #83626 - `CGBuiltin.cpp` - modified to have seperate cases for signed and unsigned integers. - `SemaChecking.cpp` - modified to prevent

[clang] [llvm] [DXIL] implement dot intrinsic lowering for integers (PR #85662)

2024-03-18 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/85662 this implements part 1 of 2 for #83626 - `CGBuiltin.cpp` - modified to have seperate cases for signed and unsigned integers. - `SemaChecking.cpp` - modified to prevent the generation of a double dot product

[clang] [clang] Correct Microsoft mangling of lifetime extended temporary objects. (PR #85529)

2024-03-18 Thread David Majnemer via cfe-commits
@@ -54,6 +54,12 @@ ABI Changes in This Version inline member function that contains a static local variable with a dynamic initializer is declared with ``__declspec(dllimport)``. (#GH83616). +- Fixed Microsoft name mangling of lifetime extended temporary objects. This +

[clang] [clang][AArch64] Enable fp128 for aarch64 linux target (PR #85070)

2024-03-18 Thread Pranav Kant via cfe-commits
pranavk wrote: I have same opinion as @lntue and Nick. https://github.com/llvm/llvm-project/pull/85070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add `__has_extension(swiftcc)` support (PR #85347)

2024-03-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I'm happy enough with the changes so long as Swift folks are okay with the change in behavior for existing code. CC @compnerd @rjmccall for opinions (I'll leave the approval to one of them). https://github.com/llvm/llvm-project/pull/85347

[clang] [Doc][HLSL] Add documentation for root signature. (PR #83933)

2024-03-18 Thread Xiang Li via cfe-commits
https://github.com/python3kgae updated https://github.com/llvm/llvm-project/pull/83933 >From b134854e7e183a1113ee6ae5c5f7b7910270c987 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Mon, 4 Mar 2024 16:39:41 -0800 Subject: [PATCH 01/11] [DOC][HLSL] Add documentation for root signature This patch

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-03-18 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: You can try to run preprocessor and then manually reduce the expanded code after preprocessor https://github.com/llvm/llvm-project/pull/82497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-03-18 Thread Akash Banerjee via cfe-commits
TIFitis wrote: Ping for review. https://github.com/llvm/llvm-project/pull/80343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] -fsanitize=undefined: don't expand to signed-integer-overflow if -fwrapv (PR #85501)

2024-03-18 Thread Fangrui Song via cfe-commits
MaskRay wrote: "Squash and merge" uses the description instead of the commit message, so the commit message is not useful. The commit message is due to spr. https://github.com/llvm/llvm-project/pull/85501 ___ cfe-commits mailing list

[clang] [OpenMP] Remove complex reduction variable support (PR #82497)

2024-03-18 Thread Akash Banerjee via cfe-commits
TIFitis wrote: @alexey-bataev I'm facing issues adding the test to Clang tests as it uses the complex.h header files. From what I can tell header files don't seem to be supported. Is there any way to add the test you provided to the Clang tests or a different one which can still check for the

[clang] [clang][dataflow] Model assignment to derived class from base. (PR #85064)

2024-03-18 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. Thanks! At this point all of my comments are addressed, and I am happy with the patch. https://github.com/llvm/llvm-project/pull/85064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][dataflow] Model assignment to derived class from base. (PR #85064)

2024-03-18 Thread Gábor Horváth via cfe-commits
@@ -212,8 +212,23 @@ TEST(TransferTest, CopyRecordFromDerivedToBase) { // [[p]] } )"; + auto SyntheticFieldCallback = [](QualType Ty) -> llvm::StringMap { +CXXRecordDecl *ADecl = nullptr; +if (Ty.getAsString() == "A") + ADecl =

[clang-tools-extra] 12b802a - [clang-tidy]bugprone-unused-return-value ignore `++` and `--` operator overloading (#84922)

2024-03-18 Thread via cfe-commits
Author: Congcong Cai Date: 2024-03-18T23:56:36+08:00 New Revision: 12b802ac0bc6ddf0742aa3fe8caecd8204d70ca5 URL: https://github.com/llvm/llvm-project/commit/12b802ac0bc6ddf0742aa3fe8caecd8204d70ca5 DIFF: https://github.com/llvm/llvm-project/commit/12b802ac0bc6ddf0742aa3fe8caecd8204d70ca5.diff

[clang-tools-extra] [clang-tidy]bugprone-unused-return-value ignore `++` and `--` operator overloading (PR #84922)

2024-03-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/84922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   >