https://github.com/erichkeane commented:
A quick few things I noticed, not nearly a thorough review.
https://github.com/llvm/llvm-project/pull/87130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/84184
>From 23f4208fb9978370f59cae16db0747acb3e2c906 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 6 Mar 2024 18:01:35 +0300
Subject: [PATCH 1/7] [clang] Factor out OpenACC part of `Sema`
This patch
https://github.com/AaronBallman approved this pull request.
LGTM, but I think the next steps are two-fold: add a second `Sema` class for
something else (perhaps OpenMP?) and add a base class for accessing commonly
used functionality (`getASTContext()`, `Diag()`, etc).
https://github.com/urnathan converted_to_draft
https://github.com/llvm/llvm-project/pull/87090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/urnathan created
https://github.com/llvm/llvm-project/pull/87238
This fixes #87227 My change to bitfield access unit allocation (#65742) causes
an ICE for a corner case of vbase allocation: a class where an unshared (i.e.
not the nearly-empty base optimization) vbase is
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/87233
>From d8d875271bd47b71701143afb06ea654546e2b7c Mon Sep 17 00:00:00 2001
From: Yitzhak Mandelbaum
Date: Mon, 1 Apr 2024 12:13:39 +
Subject: [PATCH] [clang][dataflow] Refactor `widen` API to be explicit about
AaronBallman wrote:
> > I looked at the OpenCL spec for C standard library support and was
> > surprised that 1) it's only talking about C99 so it's unclear what happens
> > for C11 (clause 6 says "This document describes the modifications and
> > restrictions to C99 and C11 in OpenCL C" but
AaronBallman wrote:
> Last time I checked, neither GCC nor Clang allowed T[0] to match a partial
> specialization for `is_array` so the extension isn't very well extended
> :)
Oh, I agree, I am learning to loathe this extension the more I look into this.
Did you see this lovely bit:
> Oh
jwakely wrote:
Last time I checked, neither GCC nor Clang allowed T[0] to match a partial
specialization for `is_array` so the extension isn't very well extended :)
https://github.com/llvm/llvm-project/pull/86652
___
cfe-commits mailing list
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/87233
>From b7f63ed7ca3c503f55eccc215f0a66368e2c5e5e Mon Sep 17 00:00:00 2001
From: Yitzhak Mandelbaum
Date: Mon, 1 Apr 2024 12:13:39 +
Subject: [PATCH] [clang][dataflow] Refactor `widen` API to be explicit about
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a1a8bb1d3ae9a535526aba9514e87f76e2d040fa
6889df911a11fc5c27149f138176166aef3e1f73 --
AaronBallman wrote:
> As I've just commented at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114479
> the `__is_array` intrinsic exists to optimize `std::is_array` and so should
> match its existing behaviour. If you want to change the behaviour of
> `std::is_array` then please do so via an
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yitzhak Mandelbaum (ymand)
Changes
The previous API relied on pointer equality of inputs and outputs to signal
whether a change occured. This was too subtle and led to bugs in practice. It
was also very limiting: the override could not
https://github.com/ymand created https://github.com/llvm/llvm-project/pull/87233
The previous API relied on pointer equality of inputs and outputs to signal
whether a change occured. This was too subtle and led to bugs in practice. It
was also very limiting: the override could not return an
urnathan wrote:
#65742 is committed, so MIPS' TargetInfo will need adjusting to propagate the
unaligned capability. See 7df79ababee8
https://github.com/llvm/llvm-project/pull/85174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
84299df301dc07ea83fa8378051103195c3a7c65...f8e130df9e602662444280346b71a82347ae8a29
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
This was the paper that added Universal Character Names to C.
---
Full diff: https://github.com/llvm/llvm-project/pull/87228.diff
3 Files Affected:
- (added) clang/test/C/C99/n717.c (+69)
- (added)
bzEq wrote:
> due to backward compatibility, it needs to be expanded into series of rlwimi
> in 32-bit environment
Why must be 'series of rlwimi'?
Why don't we just expand it following what ISA describes and let legalizer
generates code sequence under 32-bit mode?
```
n ← sh5 || sh0:4
r ←
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?=
Message-ID:
In-Reply-To:
@@ -10895,6 +10899,132 @@ bool VectorExprEvaluator::VisitUnaryOperator(const
UnaryOperator *E) {
return Success(APValue(ResultElements.data(),
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?=
Message-ID:
In-Reply-To:
@@ -10895,6 +10899,132 @@ bool VectorExprEvaluator::VisitUnaryOperator(const
UnaryOperator *E) {
return Success(APValue(ResultElements.data(),
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?=
Message-ID:
In-Reply-To:
@@ -10895,6 +10899,132 @@ bool VectorExprEvaluator::VisitUnaryOperator(const
UnaryOperator *E) {
return Success(APValue(ResultElements.data(),
zyn0217 wrote:
Friendly ping @cor3ntin and @erichkeane if you're back in the offices.
https://github.com/llvm/llvm-project/pull/82310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ecnelises updated
https://github.com/llvm/llvm-project/pull/86783
>From b886dcf2da25417d9f8cd75ff4aa58686e35139d Mon Sep 17 00:00:00 2001
From: Qiu Chaofan
Date: Wed, 27 Mar 2024 17:11:04 +0800
Subject: [PATCH] [PowerPC] Implement 32-bit expansion for rldimi
rldimi is
ChuanqiXu9 wrote:
I think the support for modules in clangd is pretty important. I posted
https://discourse.llvm.org/t/rfc-directions-for-modules-support-in-clangd/78072
and let's see if we can make some progress.
https://github.com/llvm/llvm-project/pull/66462
Author: Chuanqi Xu
Date: 2024-04-01T16:16:03+08:00
New Revision: ef0291e5f4451abbafab0c839bf51a6382f735f3
URL:
https://github.com/llvm/llvm-project/commit/ef0291e5f4451abbafab0c839bf51a6382f735f3
DIFF:
https://github.com/llvm/llvm-project/commit/ef0291e5f4451abbafab0c839bf51a6382f735f3.diff
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/86129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Congcong Cai
Date: 2024-04-01T15:53:57+08:00
New Revision: 3365d62179011aad6da3e4cbcb31044eec3462a2
URL:
https://github.com/llvm/llvm-project/commit/3365d62179011aad6da3e4cbcb31044eec3462a2
DIFF:
https://github.com/llvm/llvm-project/commit/3365d62179011aad6da3e4cbcb31044eec3462a2.diff
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/84851
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
I'd like to land this patch in next week if no objection comes in.
https://github.com/llvm/llvm-project/pull/85050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
> > Got it. I've renamed the flag as `-fexperimental-modules-reduced-bmi`.
>
> Thanks.
>
> > I feel the suggestion like let users to use `-Xclang` options look odd..
>
> I think the point here is that we want **expert** users to try this out (with
> understanding that it
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86629
>From b8a69cbd9e0ee0aa35b38b7e3a78048cbe61447e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 16 Mar 2024 23:30:10 +0800
Subject: [PATCH 1/9] [clangd] Support go-to-definition on type hints. The core
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86629
>From b8a69cbd9e0ee0aa35b38b7e3a78048cbe61447e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 16 Mar 2024 23:30:10 +0800
Subject: [PATCH 1/8] [clangd] Support go-to-definition on type hints. The core
301 - 332 of 332 matches
Mail list logo