@@ -10,12 +10,19 @@
include(ExtendPath)
+# The generated headers will be placed in clang's resource directory if
present.
+if(${OPENMP_STANDALONE_BUILD})
+ set(LIBOMP_HEADERS_INTDIR ${CMAKE_CURRENT_BINARY_DIR})
+else()
+ set(LIBOMP_HEADERS_INTDIR
@@ -10,12 +10,19 @@
include(ExtendPath)
+# The generated headers will be placed in clang's resource directory if
present.
+if(${OPENMP_STANDALONE_BUILD})
+ set(LIBOMP_HEADERS_INTDIR ${CMAKE_CURRENT_BINARY_DIR})
+else()
+ set(LIBOMP_HEADERS_INTDIR
@@ -10,12 +10,19 @@
include(ExtendPath)
+# The generated headers will be placed in clang's resource directory if
present.
+if(${OPENMP_STANDALONE_BUILD})
+ set(LIBOMP_HEADERS_INTDIR ${CMAKE_CURRENT_BINARY_DIR})
+else()
+ set(LIBOMP_HEADERS_INTDIR
https://github.com/mikerice1969 closed
https://github.com/llvm/llvm-project/pull/87842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Mike Rice
Date: 2024-04-08T12:53:30-07:00
New Revision: aa6a089c367e024921bae050b8999a7bc4d58f76
URL:
https://github.com/llvm/llvm-project/commit/aa6a089c367e024921bae050b8999a7bc4d58f76
DIFF:
https://github.com/llvm/llvm-project/commit/aa6a089c367e024921bae050b8999a7bc4d58f76.diff
haoNoQ wrote:
I never realized that scan-build makes a "short list" of flags to pass through
and throws away the rest. This is terrifying. It only works because most
compiler flags are recognized because they're prefixed with `-f`, `-W`, etc.;
but it's fascinating that it even works.
This
https://github.com/Trass3r updated
https://github.com/llvm/llvm-project/pull/87626
>From 4bbe58d6027081adfe446a09c6c837542fa196f3 Mon Sep 17 00:00:00 2001
From: Andreas Hollandt
Date: Tue, 4 Oct 2022 12:05:39 +0200
Subject: [PATCH 1/2] demangle OptFunction trace names
This improves
https://github.com/haoNoQ approved this pull request.
https://github.com/llvm/llvm-project/pull/88017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/87761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -16,4 +16,12 @@ typedef unsigned __INTPTR_TYPE__ uintptr_t;
#error Every target should have __INTPTR_TYPE__
#endif
+#ifdef __INTPTR_MAX__
+#define INTPTR_MAX__INTPTR_MAX__
+#endif
+
+#ifdef __UINTPTR_MAX__
+#define UINTPTR_MAX __UINTPTR_MAX__
+#endif
+
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/88007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -16,4 +16,12 @@ typedef unsigned __INTPTR_TYPE__ uintptr_t;
#error Every target should have __INTPTR_TYPE__
#endif
+#ifdef __INTPTR_MAX__
+#define INTPTR_MAX__INTPTR_MAX__
+#endif
+
+#ifdef __UINTPTR_MAX__
+#define UINTPTR_MAX __UINTPTR_MAX__
+#endif
+
@@ -16,4 +16,12 @@ typedef unsigned __INTPTR_TYPE__ uintptr_t;
#error Every target should have __INTPTR_TYPE__
#endif
+#ifdef __INTPTR_MAX__
+#define INTPTR_MAX__INTPTR_MAX__
+#endif
+
+#ifdef __UINTPTR_MAX__
+#define UINTPTR_MAX __UINTPTR_MAX__
+#endif
+
https://github.com/jplehr commented:
The changes seem reasonable to me.
https://github.com/llvm/llvm-project/pull/88007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jplehr edited https://github.com/llvm/llvm-project/pull/88007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fahadnayyar approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
> IIRC there is a case where `omp.h` as well as other headers are installed
> into clang's directory.
These are currently installed into clang's directory, this patch just puts it
in the resource directory for the build.
https://github.com/llvm/llvm-project/pull/88007
carlosgalvezp wrote:
> the user may not have the ability to change the definition of the macro to be
> able to appease the check
My understanding of this PR is that the user would only need to change what
they pass into the macro, not the macro itself, or? E.g.
```cpp
-MY_MACRO(foo)
@@ -10,12 +10,19 @@
include(ExtendPath)
+# The generated headers will be placed in clang's resource directory if
present.
+if(${OPENMP_STANDALONE_BUILD})
+ set(LIBOMP_HEADERS_INTDIR ${CMAKE_CURRENT_BINARY_DIR})
+else()
+ set(LIBOMP_HEADERS_INTDIR
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Joseph Huber (jhuber6)
Changes
Summary:
These headers are a part of the compiler's resource directory once
installed. However, they are currently placed in the binary directory
temporarily. This makes it more difficult to use the compiler
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/88007
>From 0dbfd89b69197df8201b772b88654810e689cced Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 8 Apr 2024 10:01:06 -0500
Subject: [PATCH] [Libomp] Place generated OpenMP headers into build resource
https://github.com/alexey-bataev approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/87842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/88019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/87869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2024-04-08T22:37:48+04:00
New Revision: fd2ffc1cbf51a75884369ec9253f47ae2fdba83c
URL:
https://github.com/llvm/llvm-project/commit/fd2ffc1cbf51a75884369ec9253f47ae2fdba83c
DIFF:
Author: Vlad Serebrennikov
Date: 2024-04-08T22:36:41+04:00
New Revision: 125c9cf1b2f5d1b33884ddcd33ce983b2e927d2f
URL:
https://github.com/llvm/llvm-project/commit/125c9cf1b2f5d1b33884ddcd33ce983b2e927d2f
DIFF:
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/87752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
I'll land after presubmit checks
https://github.com/llvm/llvm-project/pull/87761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/87761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1230,11 +1230,26 @@ CodeGenFunction::EmitCXXForRangeStmt(const
CXXForRangeStmt ,
JumpDest LoopExit = getJumpDestInCurrentScope("for.end");
LexicalScope ForScope(*this, S.getSourceRange());
+ const DeclStmt *RangeDS = cast(S.getRangeStmt());
+ const VarDecl
https://github.com/vitalybuka commented:
Fail i386
```
UBSan-AddressSanitizer-i386 ::
TestCases/ImplicitConversion/bitfield-conversion.c
UBSan-Standalone-i386 :: TestCases/ImplicitConversion/bitfield-conversion.c
```
https://github.com/llvm/llvm-project/pull/87761
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/88017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
I hte this behavior, but it is to standard.
https://github.com/llvm/llvm-project/pull/87752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -385,6 +390,187 @@ getFieldsGlobalsAndFuncs(const Stmt , FieldSet ,
}
}
+namespace {
+
+// Visitor that builds a map from record prvalues to result objects.
+// This traverses the body of the function to be analyzed; for each result
+// object that it encounters, it
@@ -556,6 +763,10 @@ void Environment::pushCallInternal(const FunctionDecl
*FuncDecl,
const VarDecl *Param = *ParamIt;
setStorageLocation(*Param, createObject(*Param, Args[ArgIndex]));
}
+
+ ResultObjectMap = std::make_shared(
Xazax-hun wrote:
I
https://github.com/Xazax-hun commented:
I know it is not exactly what we need, but I found
`Expr::skipRValueSubobjectAdjustments` in the compiler. I think it might be a
good idea to take a look just in case there is something we forgot to cover,
and maybe in the future we could look for
@@ -385,6 +390,187 @@ getFieldsGlobalsAndFuncs(const Stmt , FieldSet ,
}
}
+namespace {
+
+// Visitor that builds a map from record prvalues to result objects.
+// This traverses the body of the function to be analyzed; for each result
+// object that it encounters, it
https://github.com/Xazax-hun edited
https://github.com/llvm/llvm-project/pull/87320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/87876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2024-04-08T21:55:53+04:00
New Revision: 93e2a9ab1b28e1b89d30b89dc2d5bb6f8cc66dc9
URL:
https://github.com/llvm/llvm-project/commit/93e2a9ab1b28e1b89d30b89dc2d5bb6f8cc66dc9
DIFF:
https://github.com/SimplyDanny updated
https://github.com/llvm/llvm-project/pull/87832
From 229e1cb251139a32fc2e944b8d0f4d402987820f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Fri, 5 Apr 2024 23:41:50 +0200
Subject: [PATCH 1/5] [clang-tidy] Ignore non-forwarded
rjmccall wrote:
It'll be tested in a follow-up commit which actually adds parsing and Sema
support for these as qualifiers. That should be sufficient rather than adding
a whole unit-test apparatus. Daniil is just trying to avoid landing this in a
single massive commit.
@@ -0,0 +1,25 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s
--check-prefixes CHECK
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/87876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/87876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TIFitis wrote:
@jsjodin @jdoerfert Hi, this patch has been sitting for a while now. Would be
great to get it reviewed and accepted. Thanks.
https://github.com/llvm/llvm-project/pull/80343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Eli Friedman (efriedma-quic)
Changes
This reverts commit e770153865c53c4fd72a68f23acff33c24e42a08.
This wasn't reviewed, and the functionality in question was intentionally
rejected the last time it was discussed in
https://github.com/efriedma-quic created
https://github.com/llvm/llvm-project/pull/88019
This reverts commit e770153865c53c4fd72a68f23acff33c24e42a08.
This wasn't reviewed, and the functionality in question was intentionally
rejected the last time it was discussed in
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ziqing Luo (ziqingluo-90)
Changes
Compiler options recognizable to ccc-analyzer are stored in maps. An option
missing in the map will be dropped by ccc-analyzer. This causes a build error
in one of our projects that only happens in
https://github.com/ziqingluo-90 created
https://github.com/llvm/llvm-project/pull/88017
Compiler options recognizable to ccc-analyzer are stored in maps. An option
missing in the map will be dropped by ccc-analyzer. This causes a build error
in one of our projects that only happens in
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/87912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2024-04-08T21:32:38+04:00
New Revision: d345f6a25343f926f55e70b442dfa507ba31b597
URL:
https://github.com/llvm/llvm-project/commit/d345f6a25343f926f55e70b442dfa507ba31b597
DIFF:
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/87912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AMP999 wrote:
@fahadnayyar, does this PR address llvm#86997?
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ding Fei (danix800)
Changes
Use refactored `CheckForConstantInitializer()` to skip checking expr with error.
---
Full diff: https://github.com/llvm/llvm-project/pull/88014.diff
4 Files Affected:
- (modified)
https://github.com/danix800 created
https://github.com/llvm/llvm-project/pull/88014
Use refactored `CheckForConstantInitializer()` to skip checking expr with error.
>From fbd0780923d40b0d8290280731239a722a7af7a9 Mon Sep 17 00:00:00 2001
From: dingfei
Date: Tue, 9 Apr 2024 00:26:03 +0800
vgvassilev wrote:
In https://github.com/llvm/llvm-project/issues/87151 is more context.
https://github.com/llvm/llvm-project/pull/87281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
> > > @erichkeane, thank you. What's the process of including this in the next
> > > release?
> >
> >
> > After CI is complete, you can click "Squash and Merge" below (if you
> > cannot, let us know and someone can do it for you), and it'll be included
> > in the 19.1
vgvassilev wrote:
> > @erichkeane, thank you. What's the process of including this in the next
> > release?
>
> After CI is complete, you can click "Squash and Merge" below (if you cannot,
> let us know and someone can do it for you), and it'll be included in the 19.1
> release this summer.
erichkeane wrote:
> @erichkeane, thank you. What's the process of including this in the next
> release?
After CI is complete, you can click "Squash and Merge" below (if you cannot,
let us know and someone can do it for you), and it'll be included in the 19.1
release this summer.
https://github.com/python3kgae closed
https://github.com/llvm/llvm-project/pull/83933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
python3kgae wrote:
> I think we need to break this PR up into different parts going to different
> places.
>
> Documenting the RootSignature grammar and usage in the Clang docs makes sense.
>
> I think documentation of the RootSignature binary format probably should live
> with the DirectX
vgvassilev wrote:
@erichkeane, thank you. What's the process of including this in the next
release?
https://github.com/llvm/llvm-project/pull/87281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/87281
>From 94f1c8653903cc3db55abd641c68a9dd11f05df3 Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Mon, 1 Apr 2024 15:01:33 +
Subject: [PATCH 1/5] Revert "Remove extra switch from 0323938d"
This
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/87281
>From 94f1c8653903cc3db55abd641c68a9dd11f05df3 Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Mon, 1 Apr 2024 15:01:33 +
Subject: [PATCH 1/5] Revert "Remove extra switch from 0323938d"
This
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/87281
>From 94f1c8653903cc3db55abd641c68a9dd11f05df3 Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Mon, 1 Apr 2024 15:01:33 +
Subject: [PATCH 01/11] Revert "Remove extra switch from 0323938d"
This
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/87281
>From 94f1c8653903cc3db55abd641c68a9dd11f05df3 Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Mon, 1 Apr 2024 15:01:33 +
Subject: [PATCH 01/10] Revert "Remove extra switch from 0323938d"
This
@@ -250,87 +238,47 @@ raw_ostream& DeclPrinter::Indent(unsigned Indentation) {
return Out;
}
-// For CLANG_ATTR_LIST_CanPrintOnLeft macro.
-#include "clang/Basic/AttrLeftSideCanPrintList.inc"
+static DeclPrinter::AttrPosAsWritten getPosAsWritten(const Attr *A,
+
@@ -250,87 +238,50 @@ raw_ostream& DeclPrinter::Indent(unsigned Indentation) {
return Out;
}
-// For CLANG_ATTR_LIST_CanPrintOnLeft macro.
-#include "clang/Basic/AttrLeftSideCanPrintList.inc"
+static DeclPrinter::AttrPosAsWritten getPosAsWritten(const Attr *A,
+
@@ -250,87 +238,50 @@ raw_ostream& DeclPrinter::Indent(unsigned Indentation) {
return Out;
}
-// For CLANG_ATTR_LIST_CanPrintOnLeft macro.
-#include "clang/Basic/AttrLeftSideCanPrintList.inc"
+static DeclPrinter::AttrPosAsWritten getPosAsWritten(const Attr *A,
+
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/87281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/87281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -250,87 +238,47 @@ raw_ostream& DeclPrinter::Indent(unsigned Indentation) {
return Out;
}
-// For CLANG_ATTR_LIST_CanPrintOnLeft macro.
-#include "clang/Basic/AttrLeftSideCanPrintList.inc"
+static DeclPrinter::AttrPosAsWritten getPosAsWritten(const Attr *A,
+
@@ -250,87 +238,47 @@ raw_ostream& DeclPrinter::Indent(unsigned Indentation) {
return Out;
}
-// For CLANG_ATTR_LIST_CanPrintOnLeft macro.
-#include "clang/Basic/AttrLeftSideCanPrintList.inc"
+static DeclPrinter::AttrPosAsWritten getPosAsWritten(const Attr *A,
+
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/87281
>From 94f1c8653903cc3db55abd641c68a9dd11f05df3 Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Mon, 1 Apr 2024 15:01:33 +
Subject: [PATCH 1/9] Revert "Remove extra switch from 0323938d"
This
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clangd
Author: Jan Svoboda (jansvoboda11)
Changes
Clang uses the `HeaderFileInfo` struct to track bits of information on header
files, which gets used throughout the compiler. We also use this to compute the
set of affecting
https://github.com/jansvoboda11 ready_for_review
https://github.com/llvm/llvm-project/pull/87848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/87848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -688,22 +689,45 @@ class Environment {
/// and functions referenced in `FuncDecl`. `FuncDecl` must have a body.
void initFieldsGlobalsAndFuncs(const FunctionDecl *FuncDecl);
+ static PrValueToResultObject
+ buildResultObjectMap(DataflowAnalysisContext *DACtx,
+
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/87983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/87849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apache-hb updated
https://github.com/llvm/llvm-project/pull/86426
>From 245a21512d8658225b17b91b8af4764f54084e01 Mon Sep 17 00:00:00 2001
From: Elliot <35050275+apache...@users.noreply.github.com>
Date: Sun, 24 Mar 2024 03:03:47 -0400
Subject: [PATCH 1/8] Match against all
@@ -271,12 +271,6 @@ The primary goal of experimental support is to assist in
the process of ratifica
``experimental-ztso``
LLVM implements the `v0.1 proposed specification
jansvoboda11 wrote:
CC @ilyakuteev
https://github.com/llvm/llvm-project/pull/87849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Jan Svoboda (jansvoboda11)
Changes
When writing out a PCM, we compute the set of module maps that did affect the
compilation and we strip the rest to make the output independent of them. The
most common way to read a module map
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/87849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 ready_for_review
https://github.com/llvm/llvm-project/pull/87849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz requested changes to this pull request.
I think we need to break this PR up into different parts going to different
places.
Documenting the RootSignature grammar and usage in the Clang docs makes sense.
I think documentation of the RootSignature binary format
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/87848
>From ee56548604be9473f33cd809c901886f37a3d8e9 Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Fri, 5 Apr 2024 15:12:39 -0700
Subject: [PATCH 1/3] [clang][modules] Do not resolve `HeaderFileInfo`
@@ -0,0 +1,114 @@
+// UNSUPPORTED: asserts
+// REQUIRES: asserts
+// ^ this attempts to say "don't actually run this test", because it's broken
sethp wrote:
Sounds good, I'll take a look at it when I get a chance.
https://github.com/llvm/llvm-project/pull/87799
@@ -206,23 +221,42 @@ class StdVariantChecker : public Checker {
if (!ThisMemRegion)
return;
+// Get the first type alternative of the std::variant instance.
+assert((ThisSVal.getType(C.getASTContext())->isPointerType() ||
+
@@ -2261,6 +2261,8 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred,
Bldr.takeNodes(Pred);
const auto *C = cast(S);
ExplodedNodeSet dstExpr;
+ // Point of interes: maybe my cast somehow will not get visited or will
NagyDonat
@@ -286,6 +332,21 @@ class StdVariantChecker : public Checker {
C.emitReport(std::move(R));
return true;
}
+
+ // TODO Implement modeling of std::variant's emplace method.
+ // Currently when this method call is encountered we just
+ // stop the modeling of that
@@ -206,23 +221,42 @@ class StdVariantChecker : public Checker {
if (!ThisMemRegion)
return;
+// Get the first type alternative of the std::variant instance.
+assert((ThisSVal.getType(C.getASTContext())->isPointerType() ||
+
@@ -231,16 +265,22 @@ class StdVariantChecker : public Checker {
// Get the mem region of the argument std::variant and look up the type
// information that we know about it.
const MemRegion *ArgMemRegion = Call.getArgSVal(0).getAsRegion();
-const QualType
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/87886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -51,27 +47,29 @@ removeInformationStoredForDeadInstances(const CallEvent
,
}
template
-void handleConstructorAndAssignment(const CallEvent , CheckerContext ,
+bool handleConstructorAndAssignment(const CallEvent , CheckerContext ,
SVal
@@ -265,16 +305,22 @@ class StdVariantChecker : public Checker {
}
QualType RetrievedCanonicalType = RetrievedType.getCanonicalType();
-QualType StoredCanonicalType = StoredType->getCanonicalType();
-if (RetrievedCanonicalType == StoredCanonicalType)
+
https://github.com/NagyDonat commented:
Thanks for working on this checker and improving its behavior!
I started a review of this commit, but I didn't get too far yet; I'll continue
reviewing on the next days. So far I read the code under `Checkers/`and added
some minor stylistic remarks, but
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/85899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 389 matches
Mail list logo
