[clang] 4d6e67f - Fix build issue committed in 26fee0ff12

Author: erichkeane Date: 2024-04-08T09:08:21-07:00 New Revision: 4d6e67f677bdf40360e6aaba171bcdec93990b01 URL: https://github.com/llvm/llvm-project/commit/4d6e67f677bdf40360e6aaba171bcdec93990b01 DIFF: https://github.com/llvm/llvm-project/commit/4d6e67f677bdf40360e6aaba171bcdec93990b01.diff

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

kovdan01 wrote: Although functions in this file use different code styles for function arguments (both `camelCase` and `PascalCase`), I've changed the code style for function arguments of newly added functions to `PascalCase` as described in

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

kovdan01 wrote: > Are there unittests where we could exercise these types? @Michael137 Could you clarify a bit, what is the correct place for such a unit test? As for `ASTContext` methods similar to newly proposed `getPointerAuthType` (like `getQualifiedType` and `getCVRQualifiedType`), I've

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

@@ -251,15 +423,16 @@ class Qualifiers { } // Deserialize qualifiers from an opaque representation. - static Qualifiers fromOpaqueValue(unsigned opaque) { + static Qualifiers fromOpaqueValue(uint64_t Opaque) { Qualifiers Qs; -Qs.Mask = opaque; +Qs.Mask =

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/87821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 26fee0f - [OpenACC] Implement Sema work for OpenACC Clauses (#87821)

Author: Erich Keane Date: 2024-04-08T09:05:09-07:00 New Revision: 26fee0ff1251fa70babaf419c08383e7ec71c56c URL: https://github.com/llvm/llvm-project/commit/26fee0ff1251fa70babaf419c08383e7ec71c56c DIFF: https://github.com/llvm/llvm-project/commit/26fee0ff1251fa70babaf419c08383e7ec71c56c.diff

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/87821 >From ca5f957bb002d79997e630cdf1aaad5703ea2ba4 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 5 Apr 2024 10:53:47 -0700 Subject: [PATCH 1/6] [OpenACC] Implement Sema work for OpenACC Clauses Now that

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

@@ -138,6 +140,165 @@ using CanQualType = CanQual; #define TYPE(Class, Base) class Class##Type; #include "clang/AST/TypeNodes.inc" +/// Pointer-authentication qualifiers. +class PointerAuthQualifier { + enum : uint32_t { +EnabledShift = 0, +EnabledBits = 1, +

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

@@ -138,6 +140,165 @@ using CanQualType = CanQual; #define TYPE(Class, Base) class Class##Type; #include "clang/AST/TypeNodes.inc" +/// Pointer-authentication qualifiers. +class PointerAuthQualifier { + enum : uint32_t { +EnabledShift = 0, +EnabledBits = 1, +

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

@@ -138,6 +140,165 @@ using CanQualType = CanQual; #define TYPE(Class, Base) class Class##Type; #include "clang/AST/TypeNodes.inc" +/// Pointer-authentication qualifiers. +class PointerAuthQualifier { + enum : uint32_t { +EnabledShift = 0, +EnabledBits = 1, +

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

@@ -138,6 +140,165 @@ using CanQualType = CanQual; #define TYPE(Class, Base) class Class##Type; #include "clang/AST/TypeNodes.inc" +/// Pointer-authentication qualifiers. +class PointerAuthQualifier { + enum : uint32_t { +EnabledShift = 0, +EnabledBits = 1, +

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

mgorny wrote: Yeah, it built this time for me too. Thanks, again! https://github.com/llvm/llvm-project/pull/87505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/84384 >From ef23d427b48687b62da9e1062886ddfcc1649b6a Mon Sep 17 00:00:00 2001 From: John McCall Date: Mon, 16 Dec 2019 20:31:25 -0500 Subject: [PATCH 1/5] Abstract serialization fixes for the Apple Clang changes.

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -1204,15 +1238,16 @@ Parser::OpenACCDirectiveParseInfo Parser::ParseOpenACCDirective() { Diag(Tok, diag::err_expected) << tok::l_paren; } - // Parses the list of clauses, if present. - ParseOpenACCClauseList(DirKind); + // Parses the list of clauses, if present,

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

https://github.com/alexey-bataev approved this pull request. LG with a nit https://github.com/llvm/llvm-project/pull/87821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/87821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

frasercrmck wrote: > Thanks. Unfortunately, I'm still getting a build failure: > > ``` > [1792/1922] cd /tmp/portage/dev-libs/libclc-19.0.0./work/libclc_build && > /usr/lib/llvm/17/bin/llvm-spirv --spirv-max-version=1.1 -o spirv-mesa3d-.spv > builtins.link.spirv-mesa3d- > FAILED:

[libclc] b439140 - [libclc] Fix more spirv build dependencies

Author: Fraser Cormack Date: 2024-04-08T16:51:30+01:00 New Revision: b439140e2982dd77ef28a9069e16ae77bbe2bc5a URL: https://github.com/llvm/llvm-project/commit/b439140e2982dd77ef28a9069e16ae77bbe2bc5a DIFF:

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

erichkeane wrote: Build failure is completely unrelated, but I think this does everything you've asked for @alexey-bataev . Let me know what you think! https://github.com/llvm/llvm-project/pull/87821 ___ cfe-commits mailing list

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

mgorny wrote: Thanks. Unfortunately, I'm still getting a build failure: ``` [1792/1922] cd /tmp/portage/dev-libs/libclc-19.0.0./work/libclc_build && /usr/lib/llvm/17/bin/llvm-spirv --spirv-max-version=1.1 -o spirv-mesa3d-.spv builtins.link.spirv-mesa3d- FAILED: spirv-mesa3d-.spv

[clang] Update __cpp_concepts macro (PR #87998)

@@ -110,6 +110,11 @@ C++20 Feature Support templates (`P1814R0 `_). (#GH54051). +- __cpp_concepts macro now updated to `202002L`, as we are confident that, + modulo a handful of bugs and core issues, that our concepts implementation is +

[clang] Update __cpp_concepts macro (PR #87998)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/87998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update __cpp_concepts macro (PR #87998)

https://github.com/AaronBallman approved this pull request. LGTM, feel free to take or leave my suggestion on the release note. https://github.com/llvm/llvm-project/pull/87998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] Avoid overflow when dumping unsigned integer values (PR #85060)

https://github.com/ealcdan updated https://github.com/llvm/llvm-project/pull/85060 >From f6196cf0d073c6637fde463cd4fd3f252051d7da Mon Sep 17 00:00:00 2001 From: Daniel Alcaide Nombela Date: Wed, 13 Mar 2024 11:28:34 +0100 Subject: [PATCH] [clang-tidy] Avoid overflow when dumping unsigned

[clang-tools-extra] [clang-tidy] Avoid overflow when dumping unsigned integer values (PR #85060)

ealcdan wrote: Thanks for the review. I'm adding a test that checks that no '-1' is returned for misc-throw-by-value-catch-by-reference.MaxSize, that should pass even when no value is dumped for the option by default. I also added a test that sets 2⁶⁰ as a value for that option, and checks

[clang-tools-extra] [clang-tidy] Avoid overflow when dumping unsigned integer values (PR #85060)

https://github.com/ealcdan updated https://github.com/llvm/llvm-project/pull/85060 >From 6ca7a38e44f0b666458a1a991d0120c19a4f5fe9 Mon Sep 17 00:00:00 2001 From: Daniel Alcaide Nombela Date: Wed, 13 Mar 2024 11:28:34 +0100 Subject: [PATCH] [clang-tidy] Avoid overflow when dumping unsigned

[clang] [clang][CodeGen] Fix shift-exponent ubsan check for signed _BitInt (PR #88004)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Björn Pettersson (bjope) Changes Commit 5f87957fefb21d454f2f (pull-requst #80515) corrected some codegen problems related to _BitInt types being used as shift exponents. But it did not fix it properly

[clang] [clang][CodeGen] Fix shift-exponent ubsan check for signed _BitInt (PR #88004)

https://github.com/bjope created https://github.com/llvm/llvm-project/pull/88004 Commit 5f87957fefb21d454f2f (pull-requst #80515) corrected some codegen problems related to _BitInt types being used as shift exponents. But it did not fix it properly for the special case when the shift count

[clang-tools-extra] [clang-tidy] Allow renaming macro arguments (PR #87792)

https://github.com/AaronBallman commented: I am not certain we want to allow this without some kind of option. The trouble is: the user may not have the ability to change the definition of the macro to be able to appease the check. However, the clang-tidy folks may have different

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

Pol Marcet =?utf-8?q?Sardà?= , Pol Marcet =?utf-8?q?Sardà?= , Pol Marcet =?utf-8?q?Sardà?= Message-ID: In-Reply-To: @@ -0,0 +1,99 @@ +// RUN: %clang_cc1 -verify -std=c++2a -fsyntax-only %s +// expected-no-diagnostics + +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__

[clang] [flang] [flang][Frontend] Implement printing defined macros via -dM (PR #87627)

https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/87627 >From f4917dcf99664442d262226cd1ce1058646d7a55 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 3 Apr 2024 17:09:24 -0500 Subject: [PATCH 1/8] [flang][Frontend] Implement printing defined macros

[clang] [Sema][NFC] Cleanups after 843cc474f (PR #87996)

https://github.com/cor3ntin approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/87996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid overflow when dumping unsigned integer values (PR #85060)

https://github.com/ealcdan updated https://github.com/llvm/llvm-project/pull/85060 >From 278a9a649db880c20db19213b93d3470c0b17cd3 Mon Sep 17 00:00:00 2001 From: Daniel Alcaide Nombela Date: Wed, 13 Mar 2024 11:28:34 +0100 Subject: [PATCH] [clang-tidy] Avoid overflow when dumping unsigned

[clang-tools-extra] [clang-tidy] rename designated initializers (PR #86976)

https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/86976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 1107b47 - [clang-tidy] rename designated initializers (#86976)

Author: Edwin Vane Date: 2024-04-08T11:22:19-04:00 New Revision: 1107b47dcd145518c7b811bf10e2b848782b0478 URL: https://github.com/llvm/llvm-project/commit/1107b47dcd145518c7b811bf10e2b848782b0478 DIFF: https://github.com/llvm/llvm-project/commit/1107b47dcd145518c7b811bf10e2b848782b0478.diff

[clang-tools-extra] [clang-tidy] rename designated initializers (PR #86976)

AaronBallman wrote: > @AaronBallman Ready to go? Yup, it was already accepted by the code owners. Based on our chat during office hours, I'm guessing you need help landing these changes. I'll go ahead and land them on your behalf. Feel free to let us know if we accept something and you can't

[clang] Update __cpp_concepts macro (PR #87998)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/87998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

Pol Marcet =?utf-8?q?Sardà?= , Pol Marcet =?utf-8?q?Sardà?= , Pol Marcet =?utf-8?q?Sardà?= Message-ID: In-Reply-To: @@ -0,0 +1,99 @@ +// RUN: %clang_cc1 -verify -std=c++2a -fsyntax-only %s +// expected-no-diagnostics + +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__

[clang] [clang][Sema] Track trivial-relocatability as a type trait (PR #84621)

AaronBallman wrote: > Do you mean that you would reject a proposal that adds Clang-specific trait > (with another name) that implements P1144's semantics? So long as it checks all the boxes in our usual [criteria](https://clang.llvm.org/get_involved.html#criteria) for extensions, I'd see no

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/87821 >From ca5f957bb002d79997e630cdf1aaad5703ea2ba4 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 5 Apr 2024 10:53:47 -0700 Subject: [PATCH 1/5] [OpenACC] Implement Sema work for OpenACC Clauses Now that

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -82,22 +119,22 @@ bool SemaOpenACC::ActOnStartStmtDirective(OpenACCDirectiveKind K, return diagnoseConstructAppertainment(*this, K, StartLoc, /*IsStmt=*/true); } -StmtResult SemaOpenACC::ActOnEndStmtDirective(OpenACCDirectiveKind K, -

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -11077,16 +11077,65 @@ OMPClause *TreeTransform::TransformOMPXBareClause(OMPXBareClause *C) { //===--===// // OpenACC transformation

[libclc] [llvm] [WIP] Libclc tests (PR #87989)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/87989 >From b87c2862491aed03f883d6b124a845b0d7c47699 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Wed, 3 Apr 2024 16:09:30 +0100 Subject: [PATCH 1/4] [libclc] Refactor build system to allow in-tree builds

[clang] Update __cpp_concepts macro (PR #87998)

https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/87998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -37,6 +37,32 @@ bool diagnoseConstructAppertainment(SemaOpenACC , OpenACCDirectiveKind K, } return false; } + +bool doesClauseApplyToDirective(OpenACCDirectiveKind DirectiveKind, +OpenACCClauseKind ClauseKind) { + switch (ClauseKind) {

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -82,22 +119,22 @@ bool SemaOpenACC::ActOnStartStmtDirective(OpenACCDirectiveKind K, return diagnoseConstructAppertainment(*this, K, StartLoc, /*IsStmt=*/true); } -StmtResult SemaOpenACC::ActOnEndStmtDirective(OpenACCDirectiveKind K, -

[clang-tools-extra] [clang-tidy] Avoid overflow when dumping unsigned integer values (PR #85060)

https://github.com/ealcdan updated https://github.com/llvm/llvm-project/pull/85060 >From 12a841c53b5a42fd1954fd81a3aad76c9ccbd45d Mon Sep 17 00:00:00 2001 From: Daniel Alcaide Nombela Date: Wed, 13 Mar 2024 11:28:34 +0100 Subject: [PATCH] [clang-tidy] Avoid overflow when dumping unsigned

[clang] Update __cpp_concepts macro (PR #87998)

@@ -544,16 +544,8 @@ C++20 implementation status https://wg21.link/p0848r3;>P0848R3 - - -Clang 16 (Partial) -Because of other concepts implementation deficits, the __cpp_concepts macro is not yet set to 202002L.

[clang] [clang][NFC] Adjust TBAA Base Info API (PR #73263)

https://github.com/AaronBallman approved this pull request. LGTM, sorry for this falling off my radar! https://github.com/llvm/llvm-project/pull/73263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Update __cpp_concepts macro (PR #87998)

@@ -544,16 +544,8 @@ C++20 implementation status https://wg21.link/p0848r3;>P0848R3 - - -Clang 16 (Partial) -Because of other concepts implementation deficits, the __cpp_concepts macro is not yet set to 202002L.

[clang] Update __cpp_concepts macro (PR #87998)

@@ -110,6 +110,11 @@ C++20 Feature Support templates (`P1814R0 `_). (#GH54051). +- __cpp_concepts macro now updated to `202002L`, as we are confident that, + modulo a handful of bugs and core issues, that our concepts implementation is

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -82,22 +119,22 @@ bool SemaOpenACC::ActOnStartStmtDirective(OpenACCDirectiveKind K, return diagnoseConstructAppertainment(*this, K, StartLoc, /*IsStmt=*/true); } -StmtResult SemaOpenACC::ActOnEndStmtDirective(OpenACCDirectiveKind K, -

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -11077,16 +11077,65 @@ OMPClause *TreeTransform::TransformOMPXBareClause(OMPXBareClause *C) { //===--===// // OpenACC transformation

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -37,6 +37,32 @@ bool diagnoseConstructAppertainment(SemaOpenACC , OpenACCDirectiveKind K, } return false; } + +bool doesClauseApplyToDirective(OpenACCDirectiveKind DirectiveKind, +OpenACCClauseKind ClauseKind) { + switch (ClauseKind) {

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -11077,16 +11077,65 @@ OMPClause *TreeTransform::TransformOMPXBareClause(OMPXBareClause *C) { //===--===// // OpenACC transformation

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -37,6 +37,32 @@ bool diagnoseConstructAppertainment(SemaOpenACC , OpenACCDirectiveKind K, } return false; } + +bool doesClauseApplyToDirective(OpenACCDirectiveKind DirectiveKind, +OpenACCClauseKind ClauseKind) { + switch (ClauseKind) {

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/87821 >From ca5f957bb002d79997e630cdf1aaad5703ea2ba4 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 5 Apr 2024 10:53:47 -0700 Subject: [PATCH 1/3] [OpenACC] Implement Sema work for OpenACC Clauses Now that

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

frasercrmck wrote: > > > > ``` > > > > set( spv_suffix ${arch_suffix}.spv ) > > > > add_custom_command( OUTPUT "${spv_suffix}" > > > > COMMAND ${LLVM_SPIRV} ${spvflags} -o "${spv_suffix}" > > > > ${builtins_opt_lib_tgt} > > > > DEPENDS ${builtins_link_lib_tgt} ) > >

[libclc] f46f646 - [libclc] Fix spirv build dependencies

Author: Fraser Cormack Date: 2024-04-08T15:48:15+01:00 New Revision: f46f6465062bd6ddc96e3838c50e1a0f85f92dd4 URL: https://github.com/llvm/llvm-project/commit/f46f6465062bd6ddc96e3838c50e1a0f85f92dd4 DIFF:

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -37,6 +37,32 @@ bool diagnoseConstructAppertainment(SemaOpenACC , OpenACCDirectiveKind K, } return false; } + +bool doesClauseApplyToDirective(OpenACCDirectiveKind DirectiveKind, +OpenACCClauseKind ClauseKind) { + switch (ClauseKind) {

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -82,22 +119,22 @@ bool SemaOpenACC::ActOnStartStmtDirective(OpenACCDirectiveKind K, return diagnoseConstructAppertainment(*this, K, StartLoc, /*IsStmt=*/true); } -StmtResult SemaOpenACC::ActOnEndStmtDirective(OpenACCDirectiveKind K, -

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -11077,16 +11077,65 @@ OMPClause *TreeTransform::TransformOMPXBareClause(OMPXBareClause *C) { //===--===// // OpenACC transformation

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

ckandeler wrote: ping https://github.com/llvm/llvm-project/pull/69704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

ckandeler wrote: ping https://github.com/llvm/llvm-project/pull/67802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update __cpp_concepts macro (PR #87998)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes After discussion with a few others, and seeing the state of our concepts support, I believe it is worth trying to see if we can update this for Clang19. The forcing function is that libstdc++'s expected

[clang] Update __cpp_concepts macro (PR #87998)

https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/87998 After discussion with a few others, and seeing the state of our concepts support, I believe it is worth trying to see if we can update this for Clang19. The forcing function is that libstdc++'s header is

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

frasercrmck wrote: > > > ``` > > > set( spv_suffix ${arch_suffix}.spv ) > > > add_custom_command( OUTPUT "${spv_suffix}" > > > COMMAND ${LLVM_SPIRV} ${spvflags} -o "${spv_suffix}" > > > ${builtins_opt_lib_tgt} > > > DEPENDS ${builtins_link_lib_tgt} ) > > > ``` > > >

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

rjodinchr wrote: > > ``` > > set( spv_suffix ${arch_suffix}.spv ) > > add_custom_command( OUTPUT "${spv_suffix}" > > COMMAND ${LLVM_SPIRV} ${spvflags} -o "${spv_suffix}" > > ${builtins_opt_lib_tgt} > > DEPENDS ${builtins_link_lib_tgt} ) > > ``` > > > > > > > >

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

frasercrmck wrote: > ``` > set( spv_suffix ${arch_suffix}.spv ) > add_custom_command( OUTPUT "${spv_suffix}" > COMMAND ${LLVM_SPIRV} ${spvflags} -o "${spv_suffix}" > ${builtins_opt_lib_tgt} > DEPENDS ${builtins_link_lib_tgt} ) > ``` > > I think that ought to be

[clang] XFAIL clang/Driver/test/compress.c on AIX (PR #87269)

@@ -1,5 +1,9 @@ +// XFAIL: system-aix + // REQUIRES: zlib +// XFAIL: target={{.*}}-aix{{.*}} alisonzhang4 wrote: That seems correct, I've removed `// XFAIL: target={{.*}}-aix{{.*}}` https://github.com/llvm/llvm-project/pull/87269

[clang-tools-extra] [clang-tidy] rename designated initializers (PR #86976)

revane wrote: @AaronBallman Ready to go? https://github.com/llvm/llvm-project/pull/86976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Allow renaming macro arguments (PR #87792)

revane wrote: @AaronBallman What do you think? https://github.com/llvm/llvm-project/pull/87792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Avoid guessing unexpanded packs' size in getFullyPackExpandedSize (PR #87768)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/87768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema][NFC] Cleanups after 843cc474f (PR #87996)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes I forgot to tidy up these lines that should've been done in the previous commit, specifically: 1. Merge two `CodeSynthesisContext`s into one in `CheckTemplateIdType`. 2. Remove some gratuitous `Sema::`

[clang] [Sema][NFC] Cleanups after 843cc474f (PR #87996)

https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/87996 I forgot to tidy up these lines that should've been done in the previous commit, specifically: 1. Merge two `CodeSynthesisContext`s into one in `CheckTemplateIdType`. 2. Remove some gratuitous `Sema::`

[clang] [clang] Add CodeGen tests for CWG 6xx issues (PR #87876)

@@ -0,0 +1,25 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -

[clang] [clang] Add CodeGen tests for CWG 6xx issues (PR #87876)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/87876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add CodeGen tests for CWG 6xx issues (PR #87876)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/87876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -11077,16 +11077,65 @@ OMPClause *TreeTransform::TransformOMPXBareClause(OMPXBareClause *C) { //===--===// // OpenACC transformation

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

zyn0217 wrote: > Still crash on > > ```c++ > template constexpr auto x = F(); > template constexpr int a() { return 1; } > > template > struct A { > using Func = decltype( > [](T) { > return x<[] constexpr { return a(); }>; > // return x<[] constexpr { return b(); }>;

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -4003,20 +4003,11 @@ class TreeTransform { return getSema().CreateRecoveryExpr(BeginLoc, EndLoc, SubExprs, Type); } - StmtResult RebuildOpenACCComputeConstruct(OpenACCDirectiveKind K, -SourceLocation BeginLoc, -

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -82,22 +119,22 @@ bool SemaOpenACC::ActOnStartStmtDirective(OpenACCDirectiveKind K, return diagnoseConstructAppertainment(*this, K, StartLoc, /*IsStmt=*/true); } -StmtResult SemaOpenACC::ActOnEndStmtDirective(OpenACCDirectiveKind K, -

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

@@ -37,6 +37,32 @@ bool diagnoseConstructAppertainment(SemaOpenACC , OpenACCDirectiveKind K, } return false; } + +bool doesClauseApplyToDirective(OpenACCDirectiveKind DirectiveKind, +OpenACCClauseKind ClauseKind) { + switch (ClauseKind) {

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

mgorny wrote: ``` set( spv_suffix ${arch_suffix}.spv ) add_custom_command( OUTPUT "${spv_suffix}" COMMAND ${LLVM_SPIRV} ${spvflags} -o "${spv_suffix}" ${builtins_opt_lib_tgt} DEPENDS ${builtins_link_lib_tgt} ) ``` I think that ought to be `DEPENDS

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f6357bb4283e72d1248b9c7eb67d98bea71d5f50 27da3822961873340af021a5cbf136a155b5f110 --

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/87821 >From ca5f957bb002d79997e630cdf1aaad5703ea2ba4 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 5 Apr 2024 10:53:47 -0700 Subject: [PATCH 1/2] [OpenACC] Implement Sema work for OpenACC Clauses Now that

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

mgorny wrote: Thanks. This seems to fix that problem. However, now I'm seeing missing dep in build ordering: ``` [1793/1922] cd /tmp/portage/dev-libs/libclc-19.0.0./work/libclc_build && /usr/lib/llvm/17/bin/llvm-spirv --spirv-max-version=1.1 -o spirv-mesa3d-.spv

[clang] [clang-tools-extra] [clang-tidy][dataflow] Add `bugprone-null-check-after-dereference` check (PR #84166)

@@ -217,34 +231,72 @@ void matchDereferenceExpr(const Stmt *stmt, Env.assume(Env.arena().makeNot(getVal(kIsNull, *RootValue).formula())); } -void matchCastExpr(const CastExpr *cond, const MatchFinder::MatchResult , - NullPointerAnalysisModel::TransferArgs

[clang] [clang-tools-extra] [clang-tidy][dataflow] Add `bugprone-null-check-after-dereference` check (PR #84166)

@@ -110,6 +110,12 @@ New checks Detects error-prone Curiously Recurring Template Pattern usage, when the CRTP can be constructed outside itself and the derived class. +- New :doc:`bugprone-null-check-after-dereference + ` check. + + This check identifies redundant

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

martinboehme wrote: I think all comments should be addressed. @Xazax-hun Should be ready for further review. @ymand LMK if you have any additional comments. https://github.com/llvm/llvm-project/pull/87320 ___ cfe-commits mailing list

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

https://github.com/PiotrZSL approved this pull request. LGTM, Would be good to run it on llvm or any other code base, and check what it found. https://github.com/llvm/llvm-project/pull/84481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base clas

sdkrystian wrote: > Sorry, I'm not really getting the question here. Obviously that 2nd error is > invalid and we shouldn't be emitting it, and doing the `::z` lookup inside of > `A` seems wrong to me. But I'm not sure I get the issue. We currently emit the second error. I'm asking if we

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

@@ -385,6 +388,185 @@ getFieldsGlobalsAndFuncs(const Stmt , FieldSet , } } +namespace { + +// Visitor that builds a map from record prvalues to result objects. +// This traverses the body of the function to be analyzed; for each result +// object that it encounters, it

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

@@ -460,25 +460,35 @@ class TransferVisitor : public ConstStmtVisitor { // So make sure we have a value if we didn't propagate one above. if (S->isPRValue() && S->getType()->isRecordType()) { if (Env.getValue(*S) == nullptr) { -Value *Val =

[clang] [Clang] Reduce the size of Decl and classes derived from it (PR #87361)

@@ -268,17 +268,34 @@ class alignas(8) Decl { /// } /// void A::f(); // SemanticDC == namespace 'A' ///// LexicalDC == global namespace - llvm::PointerUnion DeclCtx; + llvm::PointerIntPair< erichkeane wrote: I don't think it ends

[clang] [Clang] Reduce the size of Decl and classes derived from it (PR #87361)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/87361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reduce the size of Decl and classes derived from it (PR #87361)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/87361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/87320 >From 2d2aa88aab3e47e41588397471a90c03bb55d900 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 2 Apr 2024 08:00:00 + Subject: [PATCH 1/2] [clang][dataflow] Propagate locations from result

[clang] [clang-tools-extra] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base clas

erichkeane wrote: > @erichkeane PR updated. > > When we encounter a class member access expression with a > nested-name-specifier that is invalid, should we simply ignore it and instead > use the type of the object expression as the lookup context? This is the > current behavior, but it

[clang] f139387 - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2024-04-08T14:31:46+01:00 New Revision: f139387fb6e76a5249e8d7c2d124565e6b566ef4 URL: https://github.com/llvm/llvm-project/commit/f139387fb6e76a5249e8d7c2d124565e6b566ef4 DIFF: https://github.com/llvm/llvm-project/commit/f139387fb6e76a5249e8d7c2d124565e6b566ef4.diff

<    1   2   3   4   >