https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/87933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
And `final` as well as `override`? (This is why I'm not convinced we should be
backporting anything -- the problem is with printing in general and will crop
up in various places, so we're not really fixing a regression so much as
playing whack-a-mole with a few cases.)
mstorsjo wrote:
This seems to have had an unexpected effect. In a build where I don't use the
new path style, I used to get the old path style returned like this:
```
$ clang -target x86_64-w64-mingw32 -print-runtime-dir
/home/martin/clang-nightly/lib/clang/19/lib/windows
```
However after this
https://github.com/AaronBallman approved this pull request.
LGTM! Do you need someone to land this on your behalf?
https://github.com/llvm/llvm-project/pull/74510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vgvassilev wrote:
Maybe you can open a PR against the branch?
https://github.com/llvm/llvm-project/pull/87281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
revane wrote:
Indeed. I can add some tests to make sure nested macros aren't affected but my
thought was since this change allows renaming _arguments_ (i.e. not the macro
parameters) then it was safe since the code is not really "inside a macro".
There are already other means to filter out
giulianobelinassi wrote:
We would like this fixed in 18.1 as well. We are expanding to support C++ and
we will hit this bug at some point.
https://github.com/llvm/llvm-project/pull/87281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/85786
>From 239b404203c66ab5336ffdfb45969a50c439a1c0 Mon Sep 17 00:00:00 2001
From: Piyou Chen
Date: Tue, 19 Mar 2024 06:22:17 -0700
Subject: [PATCH 01/10] [RISCV][FMV] Support target_clones
---
https://github.com/jamieschmeiser approved this pull request.
LGTM, thanks
https://github.com/llvm/llvm-project/pull/87626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vgvassilev wrote:
Great idea! That’d make sense to me.
https://github.com/llvm/llvm-project/pull/87281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
giulianobelinassi wrote:
> > > > > @erichkeane, thank you. What's the process of including this in the
> > > > > next release?
> > > >
> > > >
> > > > After CI is complete, you can click "Squash and Merge" below (if you
> > > > cannot, let us know and someone can do it for you), and it'll be
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88042
>From e850ae0982efbb7cec7c33d6b927844d89128743 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 8 Apr 2024 09:46:08 -0400
Subject: [PATCH 1/3] [Clang][Sema] Implement approved resolution for
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88042
Unicorn! GitHub
body {
background-color: #f1f1f1;
margin: 0;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
}
.container { margin: 50px
jhuber6 wrote:
> I should have mentioned, I'm building with GCC 9.3.0. Most of my team uses
> this compiler.
Yeah, that's fine for building LLVM but in the future we'll probably require
building the offloading runtime with an up-to-date clang. I think for now I can
just restrict this patch
https://github.com/Sirraide closed
https://github.com/llvm/llvm-project/pull/84473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Sirraide
Date: 2024-04-09T14:52:52+02:00
New Revision: 38824f285f1459cb890337d2df1a3cafd3fd109d
URL:
https://github.com/llvm/llvm-project/commit/38824f285f1459cb890337d2df1a3cafd3fd109d
DIFF:
https://github.com/llvm/llvm-project/commit/38824f285f1459cb890337d2df1a3cafd3fd109d.diff
sdkrystian wrote:
@cor3ntin Should I just move the test from
`test/CXX/expr/expr.prim/expr.prim.id/expr.prim.id.qual/p3.cpp` to
`test/CXX/drs/dr28xx.cpp`?
https://github.com/llvm/llvm-project/pull/88042
___
cfe-commits mailing list
vgvassilev wrote:
Ok. Fair enough.
https://github.com/llvm/llvm-project/pull/87281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/84473
>From 870e6a6def8c17859ffbb30906f91912268f872d Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 8 Mar 2024 11:55:42 +0100
Subject: [PATCH 01/10] [Clang] Fix dependence of DREs in lambdas with an
explicit
@@ -12,6 +12,7 @@
#ifndef __LIBUNWIND_EXT__
#define __LIBUNWIND_EXT__
+#ifndef __wasm__
trcrsired wrote:
wasm has its own exception handling mechanism. i do not know why
__USING_WASM_EXCEPTION__ is not defined, because the author of the code did not
change
trcrsired wrote:
> @trcrsired Could you please describe what bits of libunwind WASM uses? It
> seems to me almost all of the functionality is stripped out?
>
> Could you also provide instructions to build and test libunwind under WASM so
> we could add CI coverage? And so I can test this
Sirraide wrote:
It’s been about week, so I’m going to merge this now.
https://github.com/llvm/llvm-project/pull/84473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -39,3 +40,5 @@ extern void *__libunwind_cet_get_registers(unw_cursor_t *);
extern void *__libunwind_cet_get_jump_target(void);
trcrsired wrote:
there are no registers. so what would you expect for cet_get_jump_target? there
is no setjmp/longjmp
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/83855
>From eb5ebe31657fc82fe3810beff8d4cfff2201bf54 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Fri, 1 Mar 2024 13:56:32 +0100
Subject: [PATCH 01/13] [Clang] [Sema] Strip `__restrict` in cv-qualifier-list
of
@@ -5052,6 +5052,21 @@ void Sema::InstantiateFunctionDefinition(SourceLocation
PointOfInstantiation,
Function->setInnerLocStart(PatternDecl->getInnerLocStart());
Function->setRangeEnd(PatternDecl->getEndLoc());
+ // Propagate '__restrict' properly.
+ if (auto MD =
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/87541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Krystian Stasiowski
Date: 2024-04-09T08:31:52-04:00
New Revision: 4657ab1c968e486e9f45329daa07340ebcf3bffd
URL:
https://github.com/llvm/llvm-project/commit/4657ab1c968e486e9f45329daa07340ebcf3bffd
DIFF:
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/87541
>From 6ad6b5e698c3ae6fd8e881582fcfa4c8bb231da4 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 3 Apr 2024 14:33:27 -0400
Subject: [PATCH 1/4] [Clang][Sema] Fix crash when 'this' is used in a
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Halkenhäuser (mhalk)
Changes
Follow-up to discussion: https://github.com/llvm/llvm-project/pull/87761
As discussed after landing the original PR:
Since fails could happen w.r.t. checking `!6`, these checks should be removed.
---
https://github.com/mhalk created https://github.com/llvm/llvm-project/pull/88116
Follow-up to discussion: https://github.com/llvm/llvm-project/pull/87761
As discussed after landing the original PR:
Since fails could happen w.r.t. checking `!6`, these checks should be removed.
From
@@ -661,6 +680,10 @@ namespace dr553 {
}
// dr554: na
+
+// dr555: na
AaronBallman wrote:
Avoiding copying tests is a good idea, that just means we need to come up with
different tests. ;-)
CWG466 is solely about cv-qualification and pseudo destructors.
psteinfeld wrote:
I should have mentioned, I'm building with GCC 9.3.0. Most of my team uses
this compiler.
https://github.com/llvm/llvm-project/pull/88007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-llvm-ir
Author: None (Lukacma)
Changes
According to the specification in
https://github.com/ARM-software/acle/pull/309 this adds the intrinsics:
```
void svzero_za64_vg1x2(uint32_t slice)
__arm_streaming __arm_inout("za");
void
https://github.com/Lukacma created
https://github.com/llvm/llvm-project/pull/88114
According to the specification in
https://github.com/ARM-software/acle/pull/309 this adds the intrinsics:
```
void svzero_za64_vg1x2(uint32_t slice)
__arm_streaming __arm_inout("za");
void
hnakamura5 wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/87983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hnakamura5 closed
https://github.com/llvm/llvm-project/pull/87983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Hirofumi Nakamura
Date: 2024-04-09T21:17:01+09:00
New Revision: bf0b21aa685264c65a2d7fd4a8b86e3c42dfd729
URL:
https://github.com/llvm/llvm-project/commit/bf0b21aa685264c65a2d7fd4a8b86e3c42dfd729
DIFF:
@@ -661,6 +680,10 @@ namespace dr553 {
}
// dr554: na
+
+// dr555: na
Endilll wrote:
Ah, I confused this with CWG550, which is a duplicate.
I still would like to avoid copying tests, though.
https://github.com/llvm/llvm-project/pull/87909
https://github.com/mhalk edited https://github.com/llvm/llvm-project/pull/87761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,94 @@
+// RUN: %clang -x c++ -fsanitize=implicit-bitfield-conversion -target
x86_64-linux -S -emit-llvm -o - %s | FileCheck %s
--check-prefixes=CHECK,CHECK-BITFIELD-CONVERSION
+// RUN: %clang -x c++ -fsanitize=implicit-integer-conversion -target
x86_64-linux -S
AaronBallman wrote:
> > > > @erichkeane, thank you. What's the process of including this in the
> > > > next release?
> > >
> > >
> > > After CI is complete, you can click "Squash and Merge" below (if you
> > > cannot, let us know and someone can do it for you), and it'll be included
> > >
@@ -661,6 +680,10 @@ namespace dr553 {
}
// dr554: na
+
+// dr555: na
AaronBallman wrote:
https://cplusplus.github.io/CWG/issues/555.html is not a duplicate, it's marked
CD5 not dup?
https://github.com/llvm/llvm-project/pull/87909
https://github.com/wangpc-pp updated
https://github.com/llvm/llvm-project/pull/83774
>From 1e556e00e59377c76c168293d6c2678f7a874742 Mon Sep 17 00:00:00 2001
From: wangpc
Date: Fri, 14 Jul 2023 10:38:14 +0800
Subject: [PATCH 1/2] [clang] Enable sized deallocation by default in C++14
onwards
Sirraide wrote:
Just added the deleted message to the ODR hash as well. Not too familiar w/ ODR
checking though, so I wasn’t sure whether to include it only if `SkipBody` is
`false`.
https://github.com/llvm/llvm-project/pull/86526
___
cfe-commits
AMP999 wrote:
@shafik, gentle ping!
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Bäder
Date: 2024-04-09T12:36:28+02:00
New Revision: 5d7d6ad663f80fbc6161da1175476bb663301c46
URL:
https://github.com/llvm/llvm-project/commit/5d7d6ad663f80fbc6161da1175476bb663301c46
DIFF:
https://github.com/llvm/llvm-project/commit/5d7d6ad663f80fbc6161da1175476bb663301c46.diff
Lukacma wrote:
I noticed that file names and file location are using sme2 as prefix. Shouldn't
we use sme2p1 prefix for this intrinsic ?
https://github.com/llvm/llvm-project/pull/88105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AaronBallman wrote:
Thank you for improving test run times, that's really appreciated!
https://github.com/llvm/llvm-project/pull/87842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/budimirarandjelovicsyrmia updated
https://github.com/llvm/llvm-project/pull/70024
From c77435557c7b933f4e997b0fed64b37bb98fd8dd Mon Sep 17 00:00:00 2001
From: budimirarandjelovicsyrmia
Date: Fri, 5 Apr 2024 15:20:37 +0200
Subject: [PATCH] [clang] Catch missing format
Author: Timm Bäder
Date: 2024-04-09T12:36:28+02:00
New Revision: 321f8312b98620131ebb3b71fe15c0d6b2267488
URL:
https://github.com/llvm/llvm-project/commit/321f8312b98620131ebb3b71fe15c0d6b2267488
DIFF:
https://github.com/llvm/llvm-project/commit/321f8312b98620131ebb3b71fe15c0d6b2267488.diff
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Momchil Velikov (momchil-velikov)
Changes
According to the specification in
https://github.com/ARM-software/acle/pull/309 this adds the intrinsics
void svmopa_za16[_f16]_m(uint64_t tile, svbool_t pn, svbool_t pm,
llvmbot wrote:
@llvm/pr-subscribers-llvm-ir
Author: Momchil Velikov (momchil-velikov)
Changes
According to the specification in
https://github.com/ARM-software/acle/pull/309 this adds the intrinsics
void svmopa_za16[_f16]_m(uint64_t tile, svbool_t pn, svbool_t pm,
https://github.com/momchil-velikov created
https://github.com/llvm/llvm-project/pull/88105
According to the specification in
https://github.com/ARM-software/acle/pull/309 this adds the intrinsics
void svmopa_za16[_f16]_m(uint64_t tile, svbool_t pn, svbool_t pm,
Author: Chuanqi Xu
Date: 2024-04-09T17:50:23+08:00
New Revision: 45aec9a0b54e6d87abf75e960c96f59408edc706
URL:
https://github.com/llvm/llvm-project/commit/45aec9a0b54e6d87abf75e960c96f59408edc706
DIFF:
https://github.com/llvm/llvm-project/commit/45aec9a0b54e6d87abf75e960c96f59408edc706.diff
https://github.com/budimirarandjelovicsyrmia updated
https://github.com/llvm/llvm-project/pull/70024
From 24d342d4d3a432a6f8e1e01e410a6e9dbeb5e0dd Mon Sep 17 00:00:00 2001
From: budimirarandjelovicsyrmia
Date: Fri, 5 Apr 2024 15:20:37 +0200
Subject: [PATCH] [clang] Catch missing format
@@ -7238,10 +7238,15 @@ void Clang::ConstructJob(Compilation , const
JobAction ,
Args.addOptInFlag(CmdArgs, options::OPT_frelaxed_template_template_args,
options::OPT_fno_relaxed_template_template_args);
- // -fsized-deallocation is off by default, as
https://github.com/ealcdan updated
https://github.com/llvm/llvm-project/pull/85060
>From 681f04d6cff2c1b2000deaee2f209dd73c1fc42d Mon Sep 17 00:00:00 2001
From: Daniel Alcaide Nombela
Date: Wed, 13 Mar 2024 11:28:34 +0100
Subject: [PATCH] [clang-tidy] Avoid overflow when dumping unsigned
Endilll wrote:
> Do we now have enough information to pass a source range as well?
Yes, `TypeLoc` inside `TypeSourceInfo` has two `SourceLocation` object that
represent the range.
In order to limit the scope of the PR, I'm not refactoring
`RequireCompleteType` and friends to accept
tbaederr wrote:
Do we now have enough information to pass a source range as well?
https://github.com/llvm/llvm-project/pull/88097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frasercrmck updated
https://github.com/llvm/llvm-project/pull/87622
>From 47cd6ddbf292fd8a50534e091ac64ebee3c40ee5 Mon Sep 17 00:00:00 2001
From: Fraser Cormack
Date: Wed, 3 Apr 2024 16:09:30 +0100
Subject: [PATCH 1/3] [libclc] Refactor build system to allow in-tree builds
Author: Simon Pilgrim
Date: 2024-04-09T09:59:57+01:00
New Revision: 4ae33c52f794dbd64924dd006570cdc409c297bc
URL:
https://github.com/llvm/llvm-project/commit/4ae33c52f794dbd64924dd006570cdc409c297bc
DIFF:
https://github.com/llvm/llvm-project/commit/4ae33c52f794dbd64924dd006570cdc409c297bc.diff
Sirraide wrote:
> did you see this comment? [#86526
> (review)](https://github.com/llvm/llvm-project/pull/86526#pullrequestreview-1976690810)
Thanks for reminding me; I did see that one but ended up forgetting about it
because I was sick for pretty much all of last week; I’ll take a look at
https://github.com/ecnelises closed
https://github.com/llvm/llvm-project/pull/86783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Qiu Chaofan
Date: 2024-04-09T16:43:49+08:00
New Revision: a4558a4a53eda8d170bbd2c358d383bb0a13f91f
URL:
https://github.com/llvm/llvm-project/commit/a4558a4a53eda8d170bbd2c358d383bb0a13f91f
DIFF:
https://github.com/llvm/llvm-project/commit/a4558a4a53eda8d170bbd2c358d383bb0a13f91f.diff
@@ -0,0 +1,94 @@
+// RUN: %clang -x c++ -fsanitize=implicit-bitfield-conversion -target
x86_64-linux -S -emit-llvm -o - %s | FileCheck %s
--check-prefixes=CHECK,CHECK-BITFIELD-CONVERSION
+// RUN: %clang -x c++ -fsanitize=implicit-integer-conversion -target
x86_64-linux -S
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/88097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Phoebe Wang (phoebewang)
Changes
Fixes #62449
---
Full diff: https://github.com/llvm/llvm-project/pull/88101.diff
2 Files Affected:
- (modified) clang/lib/Driver/ToolChains/Clang.cpp (+20-8)
- (added)
https://github.com/phoebewang created
https://github.com/llvm/llvm-project/pull/88101
Fixes #62449
>From 66c4383e58cab7cf893edfa3f3507be166116fa6 Mon Sep 17 00:00:00 2001
From: Phoebe Wang
Date: Tue, 9 Apr 2024 16:08:55 +0800
Subject: [PATCH] [SEH] Ignore async exception flag when the
https://github.com/frasercrmck updated
https://github.com/llvm/llvm-project/pull/87622
>From 47cd6ddbf292fd8a50534e091ac64ebee3c40ee5 Mon Sep 17 00:00:00 2001
From: Fraser Cormack
Date: Wed, 3 Apr 2024 16:09:30 +0100
Subject: [PATCH 1/2] [libclc] Refactor build system to allow in-tree builds
frasercrmck wrote:
CC @mgorny - I was unsure whether you are actively using and interested
`libclc` or you were just looking after build bots or some other reason. I've
successfully built the SPIR-V libraries out-of-tree but another pair of eyes
can't hurt.
I was wondering - if we `libclc`
https://github.com/frasercrmck updated
https://github.com/llvm/llvm-project/pull/87622
>From 47cd6ddbf292fd8a50534e091ac64ebee3c40ee5 Mon Sep 17 00:00:00 2001
From: Fraser Cormack
Date: Wed, 3 Apr 2024 16:09:30 +0100
Subject: [PATCH] [libclc] Refactor build system to allow in-tree builds
The
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/88097
>From 3bc2d71cbe5e5613b430968fe84023a736072e54 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 9 Apr 2024 10:20:10 +0300
Subject: [PATCH 1/2] [clang] Improve source location in binary type traits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c7db450e5c1a83ea768765dcdedfd50f3358d418
3bc2d71cbe5e5613b430968fe84023a736072e54 --
Author: Vassil Vassilev
Date: 2024-04-09T07:26:48Z
New Revision: 9391ff8c86007562d40c240ea082b7c0cbf35947
URL:
https://github.com/llvm/llvm-project/commit/9391ff8c86007562d40c240ea082b7c0cbf35947
DIFF:
https://github.com/llvm/llvm-project/commit/9391ff8c86007562d40c240ea082b7c0cbf35947.diff
@@ -897,7 +897,20 @@ Instruction *InstCombinerImpl::visitTrunc(TruncInst
) {
}
}
- return nullptr;
+ bool Changed = false;
+ if (!Trunc.hasNoSignedWrap() &&
+ ComputeMaxSignificantBits(Src, /*Depth=*/0, ) <= DestWidth) {
+Trunc.setHasNoSignedWrap(true);
+
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This patch takes advantage of a recent NFC change that refactored
`EvaluateBinaryTypeTrait()` to accept `TypeSourceInfo` instead of `QualType`
c7db450e5c1a83ea768765dcdedfd50f3358d418.
Before:
```
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/88097
This patch takes advantage of a recent NFC change that refactored
`EvaluateBinaryTypeTrait()` to accept `TypeSourceInfo` instead of `QualType`
c7db450e5c1a83ea768765dcdedfd50f3358d418.
Before:
```
@@ -897,7 +897,20 @@ Instruction *InstCombinerImpl::visitTrunc(TruncInst
) {
}
}
- return nullptr;
+ bool Changed = false;
+ if (!Trunc.hasNoSignedWrap() &&
+ ComputeMaxSignificantBits(Src, /*Depth=*/0, ) <= DestWidth) {
+Trunc.setHasNoSignedWrap(true);
+
https://github.com/danix800 closed
https://github.com/llvm/llvm-project/pull/76619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Ding Fei
Date: 2024-04-09T15:11:29+08:00
New Revision: dbb9749862481ad6aa82c96f6889b2ebba6f6062
URL:
https://github.com/llvm/llvm-project/commit/dbb9749862481ad6aa82c96f6889b2ebba6f6062
DIFF:
https://github.com/llvm/llvm-project/commit/dbb9749862481ad6aa82c96f6889b2ebba6f6062.diff
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/87541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
Thanks for the new tests. did you see this comment?
https://github.com/llvm/llvm-project/pull/86526#pullrequestreview-1976690810
https://github.com/llvm/llvm-project/pull/86526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/85564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/87953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
Give @hubert-reinterpretcast a few days to possibly review, otherwise LGTM
https://github.com/llvm/llvm-project/pull/87930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
cor3ntin wrote:
This needs a release note and a test in test/CXX/drs/dr28xx.cpp (and a rerun of
www/make_cxx_dr_status )
https://github.com/llvm/llvm-project/pull/88042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/mydeveloperday approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11444,9 +11444,12 @@ static void DiagnoseBadShiftValues(Sema& S, ExprResult
, ExprResult ,
llvm::APSInt Right = RHSResult.Val.getInt();
if (Right.isNegative()) {
-S.DiagRuntimeBehavior(Loc, RHS.get(),
- S.PDiag(diag::warn_shift_negative)
@@ -897,7 +897,20 @@ Instruction *InstCombinerImpl::visitTrunc(TruncInst
) {
}
}
- return nullptr;
+ bool Changed = false;
+ if (!Trunc.hasNoSignedWrap() &&
+ ComputeMaxSignificantBits(Src, /*Depth=*/0, ) <= DestWidth) {
+Trunc.setHasNoSignedWrap(true);
+
301 - 389 of 389 matches
Mail list logo
