[clang] [ARM64EC] Fix arm_neon.h on ARM64EC. (PR #88572)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Eli Friedman (efriedma-quic) Changes Since 97fe519d, in ARM64EC mode, we don't define `__aarch64__`. Fix various preprocessor guards to account for this. --- Full diff: https://github.com/llvm/llvm-project/pull/88572.diff 3 Files

[clang] [ARM64EC] Fix arm_neon.h on ARM64EC. (PR #88572)

2024-04-12 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic created https://github.com/llvm/llvm-project/pull/88572 Since 97fe519d, in ARM64EC mode, we don't define `__aarch64__`. Fix various preprocessor guards to account for this. >From 1931103205e566ef49bbfa96272b3304c89f7d2d Mon Sep 17 00:00:00 2001 From: Eli

[clang] [clang-format] revert to string << string handling to previous default (PR #88490)

2024-04-12 Thread Björn Schäpers via cfe-commits
@@ -5598,10 +5598,34 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine , // FIXME: Breaking after newlines seems useful in general. Turn this into an // option and recognize more cases like endl etc, and break independent of // what comes after operator

[clang] [clang-format] revert to string << string handling to previous default (PR #88490)

2024-04-12 Thread Björn Schäpers via cfe-commits
@@ -2193,6 +2193,41 @@ struct FormatStyle { /// \version 3.7 bool BreakBeforeTernaryOperators; + /// Different ways to Break Between Chevrons. + enum BreakChevronOperatorStyle : int8_t { +/// Break using ColumnLimit rules. +/// \code +/// os << "a" <<

[clang] [clang-format] revert to string << string handling to previous default (PR #88490)

2024-04-12 Thread Björn Schäpers via cfe-commits
@@ -2193,6 +2193,41 @@ struct FormatStyle { /// \version 3.7 bool BreakBeforeTernaryOperators; + /// Different ways to Break Between Chevrons. + enum BreakChevronOperatorStyle : int8_t { +/// Break using ColumnLimit rules. +/// \code +/// os << "a" <<

[clang] [clang-format] revert to string << string handling to previous default (PR #88490)

2024-04-12 Thread Björn Schäpers via cfe-commits
@@ -5598,10 +5598,34 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine , // FIXME: Breaking after newlines seems useful in general. Turn this into an // option and recognize more cases like endl etc, and break independent of // what comes after operator

[clang] [clang-format] revert to string << string handling to previous default (PR #88490)

2024-04-12 Thread Björn Schäpers via cfe-commits
@@ -2193,6 +2193,41 @@ struct FormatStyle { /// \version 3.7 bool BreakBeforeTernaryOperators; + /// Different ways to Break Between Chevrons. + enum BreakChevronOperatorStyle : int8_t { +/// Break using ColumnLimit rules. +/// \code +/// os << "a" <<

[clang] [clang-format] revert to string << string handling to previous default (PR #88490)

2024-04-12 Thread Björn Schäpers via cfe-commits
@@ -5598,10 +5598,34 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine , // FIXME: Breaking after newlines seems useful in general. Turn this into an // option and recognize more cases like endl etc, and break independent of // what comes after operator

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

2024-04-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: The precommit CI failures are real; I'm still investigating what's going sideways. https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-04-12 Thread Jan Svoboda via cfe-commits
@@ -1125,6 +1125,54 @@ class YAMLVFSWriter { void write(llvm::raw_ostream ); }; +/// File system that tracks the number of calls to the underlying file system. +/// This is particularly useful when wrapped around \c RealFileSystem to add +/// lightweight tracking of

[clang] [libc] [llvm] Fix typos (PR #88565)

2024-04-12 Thread Michael Jones via cfe-commits
michaelrj-google wrote: Libc change LGTM https://github.com/llvm/llvm-project/pull/88565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] Fix typos (PR #88565)

2024-04-12 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/88565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce `SemaCUDA` (PR #88559)

2024-04-12 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Went ahead and applied this locally. Runs some trivial CUDA / HIP programs so I'd say it's fine. I'll wait until @Artem-B or @yxsamliu chime in however as they're the main contributors to this part. https://github.com/llvm/llvm-project/pull/88559

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes LLVM-based tools often use the `llvm::vfs::FileSystem` instrastructure to access the file system. This patch adds new kind of a VFS that performs lightweight tracing of file system operations on an

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-04-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 ready_for_review https://github.com/llvm/llvm-project/pull/88326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-04-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/88326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add txtpb to the list of supported TextProto extensions (PR #88355)

2024-04-12 Thread via cfe-commits
github-actions[bot] wrote: @jingw Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] Add txtpb to the list of supported TextProto extensions (PR #88355)

2024-04-12 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/88355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6dbd4bb - Add txtpb to the list of supported TextProto extensions (#88355)

2024-04-12 Thread via cfe-commits
Author: Jing Wang Date: 2024-04-12T21:41:06+02:00 New Revision: 6dbd4bb3b4c00d62bf1552e54e4370c6816ea060 URL: https://github.com/llvm/llvm-project/commit/6dbd4bb3b4c00d62bf1552e54e4370c6816ea060 DIFF: https://github.com/llvm/llvm-project/commit/6dbd4bb3b4c00d62bf1552e54e4370c6816ea060.diff

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-04-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/88326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][clang] Trace VFS calls (PR #88326)

2024-04-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/88326 >From b395e907fcb3895941b58e0d00ef69f14b07c4ae Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 12 Apr 2024 10:47:13 -0700 Subject: [PATCH] [llvm][support] Implement tracing virtual file system ---

[clang] a9111d4 - [clang] Remove unused variable in test

2024-04-12 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-04-12T12:37:11-07:00 New Revision: a9111d4a26514e169ca57c11e6533ca7c5408832 URL: https://github.com/llvm/llvm-project/commit/a9111d4a26514e169ca57c11e6533ca7c5408832 DIFF: https://github.com/llvm/llvm-project/commit/a9111d4a26514e169ca57c11e6533ca7c5408832.diff

[clang] [clang] Implement `__is_pointer_interconvertible_base_of()` (PR #88473)

2024-04-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/88473 >From 84907542cecbe76b1971a50642d39ec4d1078687 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Fri, 12 Apr 2024 08:18:06 +0300 Subject: [PATCH 1/5] [clang] Implement

[clang] Rework the printing of attributes (PR #87281)

2024-04-12 Thread Kim Gräsman via cfe-commits
kimgr wrote: Ah, that's the expected output -- I can't do anything about that :). See https://github.com/llvm/llvm-project/issues/56517. https://github.com/llvm/llvm-project/pull/87281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Rework the printing of attributes (PR #87281)

2024-04-12 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > @vgvassilev I did expect the input to be valid, yes: > > ``` > template > class FinalTemplate final {}; > ``` > > Is it not? The snippet as visualized in github seems to have one too many `final`s: `template class final FinalTemplate final {}`

[clang] Rework the printing of attributes (PR #87281)

2024-04-12 Thread Kim Gräsman via cfe-commits
kimgr wrote: @vgvassilev I did expect the input to be valid, yes: ``` template class FinalTemplate final {}; ``` Is it not? https://github.com/llvm/llvm-project/pull/87281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [libc] [llvm] Fix typos (PR #88565)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-llvm-analysis Author: Victor Toni (ViToni) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/88565.diff 7 Files Affected: - (modified)

[clang] [libc] [llvm] Fix typos (PR #88565)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libc Author: Victor Toni (ViToni) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/88565.diff 7 Files Affected: - (modified) clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp (+1-1) - (modified) libc/src/__support/str_to_float.h

[clang] [libc] [llvm] Fix typos (PR #88565)

2024-04-12 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [libc] [llvm] Fix typos (PR #88565)

2024-04-12 Thread Victor Toni via cfe-commits
https://github.com/ViToni created https://github.com/llvm/llvm-project/pull/88565 None >From 7e172bc788e3434b27bd2a6712b24d206b92628f Mon Sep 17 00:00:00 2001 From: Victor Toni Date: Fri, 12 Apr 2024 21:17:12 +0200 Subject: [PATCH] Fix typos ---

[clang] [clang] Introduce `SemaCUDA` (PR #88559)

2024-04-12 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > Have you run the CUDA / HIP tests in the external test suite or anything? > > No, just `check-clang` target. You think it's necessary to run something else > before merging? If so, you should point me out to what to run, and preferably > give some instructions, as CUDA

[clang] [clang] Introduce `SemaCUDA` (PR #88559)

2024-04-12 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Have you run the CUDA / HIP tests in the external test suite or anything? No, just `check-clang` target. You think it's necessary to run something else before merging? If so, you should point me out to what to run, and preferably give some instructions, as CUDA development is

[clang] [clang] Introduce `SemaCUDA` (PR #88559)

2024-04-12 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,304 @@ +//===- SemaCUDA.h - Semantic Analysis for CUDA constructs -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang] Introduce `SemaCUDA` (PR #88559)

2024-04-12 Thread Joseph Huber via cfe-commits
jhuber6 wrote: I definitely like moving things out of Sema, since it's so big it always brings my LSP to its knees. Have you run the CUDA / HIP tests in the external test suite or anything? https://github.com/llvm/llvm-project/pull/88559 ___

[clang] [clang] Introduce `SemaCUDA` (PR #88559)

2024-04-12 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,304 @@ +//===- SemaCUDA.h - Semantic Analysis for CUDA constructs -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang] Introduce `SemaCUDA` (PR #88559)

2024-04-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/88559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce `SemaCUDA` (PR #88559)

2024-04-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Generally LGTM, though I'd like someone more familiar with CUDA to sign off as well. https://github.com/llvm/llvm-project/pull/88559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

2024-04-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce `SemaCUDA` (PR #88559)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch moves CUDA-related `Sema` function into new `SemaCUDA` class, following the recent example of SYCL, OpenACC, and HLSL. This is a part of the effort to split Sema. Additional context can be

[clang-tools-extra] [clang-tidy] Export fixes from check_clang_tidy.py (PR #88186)

2024-04-12 Thread Edwin Vane via cfe-commits
https://github.com/revane updated https://github.com/llvm/llvm-project/pull/88186 >From 0c1f7d83c765a6c829543db9719420f7bf7eb02d Mon Sep 17 00:00:00 2001 From: Edwin Vane Date: Tue, 9 Apr 2024 16:07:52 -0400 Subject: [PATCH] [clang-tidy] Export fixes from check_clang_tidy.py Makes it possible

[clang-tools-extra] [clang-tidy] Export fixes from check_clang_tidy.py (PR #88186)

2024-04-12 Thread Edwin Vane via cfe-commits
https://github.com/revane updated https://github.com/llvm/llvm-project/pull/88186 >From b9cc1681c73a8af31df38e5f96cf19f14dbc0ccd Mon Sep 17 00:00:00 2001 From: Edwin Vane Date: Tue, 9 Apr 2024 16:07:52 -0400 Subject: [PATCH] [clang-tidy] Export fixes from check_clang_tidy.py Makes it possible

[clang-tools-extra] [clang-tidy] Export fixes from check_clang_tidy.py (PR #88186)

2024-04-12 Thread Edwin Vane via cfe-commits
@@ -298,7 +318,19 @@ def parse_arguments(): type=csv, help="comma-separated list of FileCheck suffixes", ) -parser.add_argument("-std", type=csv, default=["c++11-or-later"]) +parser.add_argument( +"-export", revane wrote:

[clang-tools-extra] [clang-tidy] Export fixes from check_clang_tidy.py (PR #88186)

2024-04-12 Thread Edwin Vane via cfe-commits
@@ -88,6 +99,7 @@ def __init__(self, args, extra_args): self.has_check_fixes = False self.has_check_messages = False self.has_check_notes = False +self.export = args.export revane wrote: Done

[clang-tools-extra] [clang-tidy] Export fixes from check_clang_tidy.py (PR #88186)

2024-04-12 Thread Edwin Vane via cfe-commits
https://github.com/revane updated https://github.com/llvm/llvm-project/pull/88186 >From b01f3305c350afb543afb37cc9f8b98be3ccb06c Mon Sep 17 00:00:00 2001 From: Edwin Vane Date: Tue, 9 Apr 2024 16:07:52 -0400 Subject: [PATCH] [clang-tidy] Export fixes from check_clang_tidy.py Makes it possible

[clang] Reapply "[Clang][Sema] Fix crash when 'this' is used in a dependent class scope function template specialization that instantiates to a static member function (#87541)" (PR #88311)

2024-04-12 Thread Jordan Rupprecht via cfe-commits
rupprecht wrote: Still seeing a few more failures, although the original repro is now working. ```c++ struct Base { int BaseFunc(int x) { return 0; } int val; }; template struct Foo : Base { template int bar(X x) { return BaseFunc(val); // OK } template <>

[clang] [NFC][Clang] Fix static analyzer concern (PR #88179)

2024-04-12 Thread via cfe-commits
https://github.com/elizabethandrews closed https://github.com/llvm/llvm-project/pull/88179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b074f25 - [NFC][Clang] Fix static analyzer concern (#88179)

2024-04-12 Thread via cfe-commits
Author: elizabethandrews Date: 2024-04-12T14:41:49-04:00 New Revision: b074f25329501487e312b59e463a2d5f743090f8 URL: https://github.com/llvm/llvm-project/commit/b074f25329501487e312b59e463a2d5f743090f8 DIFF:

[clang] [llvm] [AArch64] Add intrinsics for 16-bit non-widening FMLA/FMLS (PR #88553)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Momchil Velikov (momchil-velikov) Changes --- Patch is 108.24 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/88553.diff 6 Files Affected: - (modified)

[clang] [llvm] [AArch64] Add intrinsics for 16-bit non-widening FMLA/FMLS (PR #88553)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Momchil Velikov (momchil-velikov) Changes --- Patch is 108.24 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/88553.diff 6 Files Affected: - (modified) clang/include/clang/Basic/arm_sme.td

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

2024-04-12 Thread Artem Chikin via cfe-commits
https://github.com/artemcm updated https://github.com/llvm/llvm-project/pull/88152 >From 12621dc6344335375ac1a5c806d778f1ed15a5ce Mon Sep 17 00:00:00 2001 From: Ben Langmuir Date: Tue, 9 Apr 2024 11:22:44 -0700 Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC Allow

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Joseph Huber via cfe-commits
jhuber6 wrote: I'm wondering if it would be better to make this something that the toolchains handle in `TranslateArgs`. That way we can prevent it from being added at all. Although I don't know how that would allow us to override stuff. There's not really a way to "override" flags like this

[clang-tools-extra] [clang-tidy] Export fixes from check_clang_tidy.py (PR #88186)

2024-04-12 Thread Piotr Zegar via cfe-commits
@@ -88,6 +99,7 @@ def __init__(self, args, extra_args): self.has_check_fixes = False self.has_check_messages = False self.has_check_notes = False +self.export = args.export PiotrZSL wrote: export_fixes

[clang-tools-extra] [clang-tidy] Export fixes from check_clang_tidy.py (PR #88186)

2024-04-12 Thread Piotr Zegar via cfe-commits
@@ -298,7 +318,19 @@ def parse_arguments(): type=csv, help="comma-separated list of FileCheck suffixes", ) -parser.add_argument("-std", type=csv, default=["c++11-or-later"]) +parser.add_argument( +"-export", PiotrZSL wrote:

[clang-tools-extra] [clang-tidy] Export fixes from check_clang_tidy.py (PR #88186)

2024-04-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL requested changes to this pull request. Rename this from -export to -export-fixes, because that's what it is, and could land. https://github.com/llvm/llvm-project/pull/88186 ___ cfe-commits mailing list

[clang-tools-extra] [clang-tidy] Export fixes from check_clang_tidy.py (PR #88186)

2024-04-12 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/88186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Headers meant to be included multiple times can be completely invisible in clang module builds (PR #83660)

2024-04-12 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: Wow that's a _ton_ of PCM files. Why are your headers `textual` if they're only meant to be included once? Do they need to inherit the includer's preprocessor environment or something like that? https://github.com/llvm/llvm-project/pull/83660

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

2024-04-12 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: I'd like for @vsapsai to chime in. As an alternative approach: could we turn these into member variables, make them non-atomic and take care to update the stats of the superior `FileManager` whenever an inferior `FileManager` goes out of scope? (e.g. after implicitly

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

2024-04-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C99] Claim conformance for _Complex support (PR #88161)

2024-04-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/88161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0318ce8 - [C99] Claim conformance for _Complex support (#88161)

2024-04-12 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-04-12T14:15:22-04:00 New Revision: 0318ce8552896df7b180ee5481463eada65c755e URL: https://github.com/llvm/llvm-project/commit/0318ce8552896df7b180ee5481463eada65c755e DIFF: https://github.com/llvm/llvm-project/commit/0318ce8552896df7b180ee5481463eada65c755e.diff

[clang] Improve stack usage to increase template instantiation depth (PR #88546)

2024-04-12 Thread Erich Keane via cfe-commits
@@ -6113,8 +6113,10 @@ static bool TryOCLZeroOpaqueTypeInitialization(Sema , InitializationSequence::InitializationSequence( Sema , const InitializedEntity , const InitializationKind , MultiExprArg Args, bool TopLevelOfInitList, bool TreatUnavailableAsInvalid) -:

[clang] Improve stack usage to increase template instantiation depth (PR #88546)

2024-04-12 Thread Erich Keane via cfe-commits
@@ -203,6 +203,10 @@ Non-comprehensive list of changes in this release - ``__typeof_unqual__`` is available in all C modes as an extension, which behaves like ``typeof_unqual`` from C23, similar to ``__typeof__`` and ``typeof``. +- Improved stack usage with C++

[clang] Improve stack usage to increase template instantiation depth (PR #88546)

2024-04-12 Thread Erich Keane via cfe-commits
@@ -1057,16 +1057,15 @@ bool OverloadCandidateSet::OperatorRewriteInfo::shouldAddReversed( void OverloadCandidateSet::destroyCandidates() { for (iterator i = begin(), e = end(); i != e; ++i) { for (auto : i->Conversions) - C.~ImplicitConversionSequence(); +

[clang] [analyzer] Harden security.cert.env.InvalidPtr checker fn matching (PR #88536)

2024-04-12 Thread Ilya A. Kriveshko via cfe-commits
iillyyaa wrote: @steakhal, thank you for the quick turnaround with the fix! > @iillyyaa, do you wish this crash fix to be backported to clang-18? Or you > are fine with only having it in clang-19? A backport for the next point release of 18 would be very much appreciated. We are using the

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-12 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: Fixed https://github.com/llvm/llvm-project/pull/87623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-12 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -152,9 +152,11 @@ uint64_t DebugHandlerBase::getBaseTypeSize(const DIType *Ty) { unsigned Tag = DDTy->getTag(); if (Tag != dwarf::DW_TAG_member && Tag != dwarf::DW_TAG_typedef && - Tag != dwarf::DW_TAG_const_type && Tag != dwarf::DW_TAG_volatile_type && +

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-12 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -5361,7 +5383,56 @@ static bool IsReconstitutableType(QualType QT) { return T.Reconstitutable; } -std::string CGDebugInfo::GetName(const Decl *D, bool Qualified) const { +bool CGDebugInfo::HasReconstitutableArgs( +ArrayRef Args) const { + return llvm::all_of(Args,

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-12 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -310,6 +310,23 @@ namespace llvm { DINode::DIFlags Flags = DINode::FlagZero, DINodeArray Annotations = nullptr); +/// Create debugging information entry for a typedef. +/// \param Ty

[clang] [clang][AIX] set OpenMP include path (PR #88545)

2024-04-12 Thread Jake Egan via cfe-commits
https://github.com/jakeegan updated https://github.com/llvm/llvm-project/pull/88545 >From 4be38409fa322765c21a94759a78a23700e1a54d Mon Sep 17 00:00:00 2001 From: Jake Egan Date: Fri, 12 Apr 2024 11:36:25 -0400 Subject: [PATCH 1/2] [clang][AIX] set OpenMP include path ---

[clang] Improve stack usage to increase template instantiation depth (PR #88546)

2024-04-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 33779b861d748ed18b8d4f9cbad3a84deaa95e9f a89ea6c2b409d41be25f52f32c8523bc06734847 --

[clang] [NFC][Clang] Fix static analyzer concern (PR #88179)

2024-04-12 Thread via cfe-commits
elizabethandrews wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/88179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve stack usage to increase template instantiation depth (PR #88546)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes We were crashing due to stack exhaustion on rather reasonable C++ template code. After some investigation, I found that we have a stack-allocated object that was huge: `InitializationSequence` was

[clang] [clang][AIX] set OpenMP include path (PR #88545)

2024-04-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 01d9528ef989610e968386ea1f270698015d2410 4be38409fa322765c21a94759a78a23700e1a54d --

[clang] [clang][AIX] set OpenMP include path (PR #88545)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-powerpc @llvm/pr-subscribers-clang-driver Author: Jake Egan (jakeegan) Changes Add include directory for omp.h at `/opt/IBM/openxlCSDK/include/openmp`. --- Full diff: https://github.com/llvm/llvm-project/pull/88545.diff 3 Files Affected: -

[clang] [clang][AIX] set OpenMP include path (PR #88545)

2024-04-12 Thread Jake Egan via cfe-commits
https://github.com/jakeegan created https://github.com/llvm/llvm-project/pull/88545 Add include directory for omp.h at `/opt/IBM/openxlCSDK/include/openmp`. >From 4be38409fa322765c21a94759a78a23700e1a54d Mon Sep 17 00:00:00 2001 From: Jake Egan Date: Fri, 12 Apr 2024 11:36:25 -0400 Subject:

[clang] [C99] Claim conformance for _Complex support (PR #88161)

2024-04-12 Thread Joshua Cranmer via cfe-commits
https://github.com/jcranmer-intel approved this pull request. https://github.com/llvm/llvm-project/pull/88161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

2024-04-12 Thread via cfe-commits
yujincheng08 wrote: I accidentially found this PR also fixes an issue I encountered. Before: https://godbolt.org/z/E6cehd3oh Afeter: https://godbolt.org/z/MMfq84rcK and the false error was ``` In module 'bar' imported from /app/foo.cc:3: h.hpp:6:34: error: 'S::s' from module 'bar.' is not

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Artem Belevich via cfe-commits
@@ -6867,8 +6867,14 @@ void Clang::ConstructJob(Compilation , const JobAction , CmdArgs.push_back("-nogpulib"); if (Arg *A = Args.getLastArg(options::OPT_fcf_protection_EQ)) { -CmdArgs.push_back( -Args.MakeArgString(Twine("-fcf-protection=") +

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B commented: LGTM in principle. https://github.com/llvm/llvm-project/pull/88402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/88402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Artem Belevich via cfe-commits
@@ -6867,8 +6867,14 @@ void Clang::ConstructJob(Compilation , const JobAction , CmdArgs.push_back("-nogpulib"); if (Arg *A = Args.getLastArg(options::OPT_fcf_protection_EQ)) { -CmdArgs.push_back( -Args.MakeArgString(Twine("-fcf-protection=") +

[clang] ANDROID: x86_64: Set default max-page-size to 16kB (PR #87413)

2024-04-12 Thread via cfe-commits
https://github.com/pirama-arumuga-nainar closed https://github.com/llvm/llvm-project/pull/87413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2620ccc - ANDROID: x86_64: Set default max-page-size to 16kB (#87413)

2024-04-12 Thread via cfe-commits
Author: Kalesh Singh Date: 2024-04-12T10:43:59-07:00 New Revision: 2620ccc3cdebcaa53b96b5f4d79ffe3951534e07 URL: https://github.com/llvm/llvm-project/commit/2620ccc3cdebcaa53b96b5f4d79ffe3951534e07 DIFF: https://github.com/llvm/llvm-project/commit/2620ccc3cdebcaa53b96b5f4d79ffe3951534e07.diff

[clang] [clang][deps] Cache `VFS::getRealPath()` (PR #68645)

2024-04-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/68645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a11a432 - [clang][deps] Cache `VFS::getRealPath()` (#68645)

2024-04-12 Thread via cfe-commits
Author: Jan Svoboda Date: 2024-04-12T10:34:42-07:00 New Revision: a11a4324bb27c01e7a005e1a7f49fb8284098e8c URL: https://github.com/llvm/llvm-project/commit/a11a4324bb27c01e7a005e1a7f49fb8284098e8c DIFF: https://github.com/llvm/llvm-project/commit/a11a4324bb27c01e7a005e1a7f49fb8284098e8c.diff

[clang] [clang][deps] Cache `VFS::getRealPath()` (PR #68645)

2024-04-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/68645 >From 3b89f001adf027b2128c72c7b907b41717ce1e4c Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Mon, 9 Oct 2023 10:14:22 -0700 Subject: [PATCH 01/13] [clang][deps] Cache `VFS::getRealPath()` ---

[clang] c11976f - [clang][deps] Create separate unittest directory

2024-04-12 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-04-12T10:32:58-07:00 New Revision: c11976f525f3b9b9dc6080f0b23d2ef1ec5fe8fd URL: https://github.com/llvm/llvm-project/commit/c11976f525f3b9b9dc6080f0b23d2ef1ec5fe8fd DIFF: https://github.com/llvm/llvm-project/commit/c11976f525f3b9b9dc6080f0b23d2ef1ec5fe8fd.diff

[clang] fe59cb2 - [clang][deps] NFCI: Extract `FilenameForLookup` into new function

2024-04-12 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-04-12T10:32:58-07:00 New Revision: fe59cb256289d9f2f6ebe75571389f3cc90bbdec URL: https://github.com/llvm/llvm-project/commit/fe59cb256289d9f2f6ebe75571389f3cc90bbdec DIFF: https://github.com/llvm/llvm-project/commit/fe59cb256289d9f2f6ebe75571389f3cc90bbdec.diff

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

2024-04-12 Thread John McCall via cfe-commits
rjmccall wrote: It's my patch, so me signing off isn't very meaningful. https://github.com/llvm/llvm-project/pull/84384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][clang] Don't enable -mrelax-all for -O0 on RISC-V (PR #88538)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Craig Topper (topperc) Changes -O0 implies -mrelax-all as an assembler compile time optimization. -mrelax-all allows the assembler to complete layout in 2 passes instead of doing iterative branch

[clang] [RISCV][clang] Don't enable -mrelax-all for -O0 on RISC-V (PR #88538)

2024-04-12 Thread Craig Topper via cfe-commits
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/88538 -O0 implies -mrelax-all as an assembler compile time optimization. -mrelax-all allows the assembler to complete layout in 2 passes instead of doing iterative branch relaxation. Jump offsets larger than +/-1MiB

[clang] [clang-format] Fix a regression in ContinuationIndenter (PR #88414)

2024-04-12 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/88414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d61edec - [clang-format] Fix a regression in ContinuationIndenter (#88414)

2024-04-12 Thread via cfe-commits
Author: Owen Pan Date: 2024-04-12T10:12:24-07:00 New Revision: d61edecbfd099143e0e2617505fec921524938f8 URL: https://github.com/llvm/llvm-project/commit/d61edecbfd099143e0e2617505fec921524938f8 DIFF: https://github.com/llvm/llvm-project/commit/d61edecbfd099143e0e2617505fec921524938f8.diff

[clang] [analyzer] Harden security.cert.env.InvalidPtr checker fn matching (PR #88536)

2024-04-12 Thread Balazs Benics via cfe-commits
steakhal wrote: @iillyyaa, do you wish this crash fix to be backported to clang-18? Or you are fine with only having it in clang-19? https://github.com/llvm/llvm-project/pull/88536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [analyzer] Harden security.cert.env.InvalidPtr checker fn matching (PR #88536)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes Fixes #88181 I'm also hardening an llvm::cast along the way. Here is the full stack trace of the original crash: https://godbolt.org/z/jn93q39b5 --- Full diff:

[clang] [analyzer] Harden security.cert.env.InvalidPtr checker fn matching (PR #88536)

2024-04-12 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/88536 Fixes #88181 I'm also hardening an llvm::cast along the way. Here is the full stack trace of the original crash: https://godbolt.org/z/jn93q39b5 >From 915ab37028067fb38ffa69ae5c9726bb8c971436 Mon Sep 17

[clang] [clang] Implement `__is_pointer_interconvertible_base_of()` (PR #88473)

2024-04-12 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/88473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][OpenMP] Fix casting of atomic update of ptr types (PR #88215)

2024-04-12 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/88215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3652b2a - [clang][CodeGen][OpenMP] Fix casting of atomic update of ptr types (#88215)

2024-04-12 Thread via cfe-commits
Author: Mike Rice Date: 2024-04-12T10:01:01-07:00 New Revision: 3652b2a877c3691b524a19bc38b338f1ba1dde37 URL: https://github.com/llvm/llvm-project/commit/3652b2a877c3691b524a19bc38b338f1ba1dde37 DIFF: https://github.com/llvm/llvm-project/commit/3652b2a877c3691b524a19bc38b338f1ba1dde37.diff

[clang] [clang][CodeGen][OpenMP] Fix casting of atomic update of ptr types (PR #88215)

2024-04-12 Thread Mike Rice via cfe-commits
mikerice1969 wrote: > We should really fix using cmpxchg here. Can you open an IR issue for it? Sure, I'll look into it and follow-up. Thanks for the review! https://github.com/llvm/llvm-project/pull/88215 ___ cfe-commits mailing list

<    1   2   3   4   >