[clang] [BoundsSafety] WIP: Make 'counted_by' work for pointer fields; late parsing for 'counted_by' on decl attr position (PR #87596)

2024-04-12 Thread Yeoul Na via cfe-commits
rapidsna wrote: > This should be fine, because count is declared before use—unless I'm getting > type attributes confused with field attributes.. `struct size_unknown *__counted_by(count) buf` indicates that `buf` has `sizeof(struct size_unknown) * count`

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

2024-04-12 Thread Artem Chikin via cfe-commits
https://github.com/artemcm updated https://github.com/llvm/llvm-project/pull/88152 >From c2b2cd03e1d8f92b1df814e6312158b8820b790d Mon Sep 17 00:00:00 2001 From: Ben Langmuir Date: Tue, 9 Apr 2024 11:22:44 -0700 Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC Allow

[clang] [clang/DependencyScanning/ModuleDepCollector] Refactor part of `makeCommonInvocationForModuleBuild` into its own function, NFC (PR #88447)

2024-04-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM. I assume you'll call `resetBenignCodeGenOptions()` from `ModuleDepCollector::applyDiscoveredDependencies()` in a follow-up, non-NFC patch, right? (So that it applies to the primary invocation, i.e. the actual PCH.) Maybe

[clang-tools-extra] 54a6798 - [clang-tidy] Simplify RenamerClangTidyCheck API (#88268)

2024-04-12 Thread via cfe-commits
Author: Edwin Vane Date: 2024-04-12T12:49:25-04:00 New Revision: 54a6798e0a3630e705ed32dbbd63414a16331085 URL: https://github.com/llvm/llvm-project/commit/54a6798e0a3630e705ed32dbbd63414a16331085 DIFF: https://github.com/llvm/llvm-project/commit/54a6798e0a3630e705ed32dbbd63414a16331085.diff

[clang-tools-extra] [clang-tidy] Simplify RenamerClangTidyCheck API (PR #88268)

2024-04-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/88268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-12 Thread Yitzhak Mandelbaum via cfe-commits
@@ -62,6 +62,52 @@ FieldSet getObjectFields(QualType Type); bool containsSameFields(const FieldSet , const RecordStorageLocation::FieldToLoc ); +/// Returns the fields of a `RecordDecl` that are initialized by an +/// `InitListExpr`, in the order in

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-12 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/88534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-12 Thread Yitzhak Mandelbaum via cfe-commits
@@ -62,6 +62,52 @@ FieldSet getObjectFields(QualType Type); bool containsSameFields(const FieldSet , const RecordStorageLocation::FieldToLoc ); +/// Returns the fields of a `RecordDecl` that are initialized by an +/// `InitListExpr`, in the order in

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-12 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/88534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST][RecoveryExpr] Fix a crash on c89/c90 invalid InitListExpr (#88008) (PR #88014)

2024-04-12 Thread Ding Fei via cfe-commits
danix800 wrote: ping @Endilll https://github.com/llvm/llvm-project/pull/88014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-12 Thread Samira Bazuzi via cfe-commits
bazuzi wrote: @ymand Can you review and merge? https://github.com/llvm/llvm-project/pull/88534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Samira Bazuzi (bazuzi) Changes Exposes the collection functionality, but does not alter it beyond using a return value instead of output parameters. Also relocates underlying and related functions and a class from DataflowEnvironment's

[clang] [llvm] [clang][deps] Cache `VFS::getRealPath()` (PR #68645)

2024-04-12 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Expose fields, globals, and functions referenced. (PR #88534)

2024-04-12 Thread Samira Bazuzi via cfe-commits
https://github.com/bazuzi created https://github.com/llvm/llvm-project/pull/88534 Exposes the collection functionality, but does not alter it beyond using a return value instead of output parameters. Also relocates underlying and related functions and a class from DataflowEnvironment's files

[clang] [analyzer] Support `PointerType` in `getCXXRecordDecl` for `ContainerModeling` (PR #87787)

2024-04-12 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/87787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Support `PointerType` in `getCXXRecordDecl` for `ContainerModeling` (PR #87787)

2024-04-12 Thread via cfe-commits
github-actions[bot] wrote: @shenjunjiekoda Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with

[clang] [clang][analyzer] Support `PointerType` in `getCXXRecordDecl` for `ContainerModeling` (PR #87787)

2024-04-12 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/87787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 05d8b5e - [analyzer] Support `PointerType` in `getCXXRecordDecl` for `ContainerModeling` (#87787)

2024-04-12 Thread via cfe-commits
Author: JOSTAR Date: 2024-04-12T18:15:33+02:00 New Revision: 05d8b5e62d7a1cf2f94582346d6fd2d39667a26b URL: https://github.com/llvm/llvm-project/commit/05d8b5e62d7a1cf2f94582346d6fd2d39667a26b DIFF: https://github.com/llvm/llvm-project/commit/05d8b5e62d7a1cf2f94582346d6fd2d39667a26b.diff LOG:

[clang] 8d468c1 - NFC: Make clang resource headers an interface library (#88317)

2024-04-12 Thread via cfe-commits
Author: Evan Wilde Date: 2024-04-12T09:05:59-07:00 New Revision: 8d468c132eed7ffe34d601b224220efd51655eb3 URL: https://github.com/llvm/llvm-project/commit/8d468c132eed7ffe34d601b224220efd51655eb3 DIFF: https://github.com/llvm/llvm-project/commit/8d468c132eed7ffe34d601b224220efd51655eb3.diff

[clang] NFC: Make clang resource headers an interface library (PR #88317)

2024-04-12 Thread Evan Wilde via cfe-commits
https://github.com/etcwilde closed https://github.com/llvm/llvm-project/pull/88317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [BoundsSafety] WIP: Make 'counted_by' work for pointer fields; late parsing for 'counted_by' on decl attr position (PR #87596)

2024-04-12 Thread Bill Wendling via cfe-commits
@@ -4997,7 +5087,11 @@ void Parser::ParseStructUnionBody(SourceLocation RecordLoc, ParsedAttributes attrs(AttrFactory); // If attributes exist after struct contents, parse them. - MaybeParseGNUAttributes(attrs); + MaybeParseGNUAttributes(attrs, ); + +

[clang] [BoundsSafety] WIP: Make 'counted_by' work for pointer fields; late parsing for 'counted_by' on decl attr position (PR #87596)

2024-04-12 Thread Bill Wendling via cfe-commits
bwendling wrote: FYI: I'm planning on having a separate `test/Sema/attr-counted-by-for-pointers.c` test file for pointers and rename the current file something like `test/Sema/attr-counted-by-for-flexible-array-members.c`.

[clang] [BoundsSafety] WIP: Make 'counted_by' work for pointer fields; late parsing for 'counted_by' on decl attr position (PR #87596)

2024-04-12 Thread Bill Wendling via cfe-commits
@@ -0,0 +1,54 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +#define __counted_by(f) __attribute__((counted_by(f))) + +struct size_unknown; + +struct at_pointer { + int count; + struct size_unknown *__counted_by(count) buf; // expected-error{{'counted_by' cannot be

[clang] [llvm] [ValueTracking] Convert `isKnownNonZero` to use SimplifyQuery (PR #85863)

2024-04-12 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/85863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e0a6287 - [ValueTracking] Convert `isKnownNonZero` to use SimplifyQuery (#85863)

2024-04-12 Thread via cfe-commits
Author: Yingwei Zheng Date: 2024-04-12T23:47:20+08:00 New Revision: e0a628715a8464e220c8ba9e9aaaf2561139198a URL: https://github.com/llvm/llvm-project/commit/e0a628715a8464e220c8ba9e9aaaf2561139198a DIFF: https://github.com/llvm/llvm-project/commit/e0a628715a8464e220c8ba9e9aaaf2561139198a.diff

[clang] [clang-format] revert to string << string handling to previous default (PR #88490)

2024-04-12 Thread via cfe-commits
https://github.com/mydeveloperday updated https://github.com/llvm/llvm-project/pull/88490 >From 1c11c3edd0005a729561d84b9a815279b356e8db Mon Sep 17 00:00:00 2001 From: mydeveloperday Date: Fri, 12 Apr 2024 10:32:19 +0100 Subject: [PATCH 1/6] [clang-format] revery to string << string handling

[clang] [Clang] Fix __is_trivially_equaltiy_comparable documentation (PR #88528)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nikolas Klauser (philnik777) Changes Currently `__is_trivially_equality_comparable` is documented to return true if comparing the value representation is equivalent to calling the comparison operator, which is not quite what the trait

[clang] [Clang] Fix __is_trivially_equaltiy_comparable documentation (PR #88528)

2024-04-12 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/88528 Currently `__is_trivially_equality_comparable` is documented to return true if comparing the value representation is equivalent to calling the comparison operator, which is not quite what the trait actually

[clang] [clang] Implement `__is_pointer_interconvertible_base_of()` (PR #88473)

2024-04-12 Thread Vlad Serebrennikov via cfe-commits
@@ -19710,6 +19710,27 @@ bool Sema::IsLayoutCompatible(QualType T1, QualType T2) const { return isLayoutCompatible(getASTContext(), T1, T2); } +//===-- Pointer interconvertibility // + +bool

[clang] [clang] Implement `__is_pointer_interconvertible_base_of()` (PR #88473)

2024-04-12 Thread Vlad Serebrennikov via cfe-commits
@@ -19710,6 +19710,27 @@ bool Sema::IsLayoutCompatible(QualType T1, QualType T2) const { return isLayoutCompatible(getASTContext(), T1, T2); } +//===-- Pointer interconvertibility // + +bool

[clang] [clang] Implement `__is_pointer_interconvertible_base_of()` (PR #88473)

2024-04-12 Thread Vlad Serebrennikov via cfe-commits
@@ -6082,6 +6082,22 @@ static bool EvaluateBinaryTypeTrait(Sema , TypeTrait BTT, const TypeSourceI Self.Diag(Rhs->getTypeLoc().getBeginLoc(), diag::err_vla_unsupported) << 1 << tok::kw___is_layout_compatible; return Self.IsLayoutCompatible(LhsT, RhsT); +

[clang] [clang] Implement `__is_pointer_interconvertible_base_of()` (PR #88473)

2024-04-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/88473 >From 84907542cecbe76b1971a50642d39ec4d1078687 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Fri, 12 Apr 2024 08:18:06 +0300 Subject: [PATCH 1/4] [clang] Implement

[clang] [AArch64][PAC][clang][ELF] Support PAuth ABI core info (PR #85235)

2024-04-12 Thread Daniil Kovalev via cfe-commits
kovdan01 wrote: @MaskRay A kind reminder regarding the PR - please let me know if latest updates address your previous comments and if there are other issues still present. https://github.com/llvm/llvm-project/pull/85235 ___ cfe-commits mailing list

[clang] [llvm] [RISCV] Add B extension (PR #76893)

2024-04-12 Thread Kito Cheng via cfe-commits
kito-cheng wrote: Jeff told me it's still need wait TSC vote for the ratification, anyway it will ratify this month. https://github.com/llvm/llvm-project/pull/76893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] XFAIL clang/Driver/test/compress.c on AIX (PR #87269)

2024-04-12 Thread via cfe-commits
azhan92 wrote: @MaskRay, thanks, so would it be better for me to change the XFAIL to UNSUPPORTED in this case? https://github.com/llvm/llvm-project/pull/87269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-04-12 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos edited https://github.com/llvm/llvm-project/pull/84983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-04-12 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos edited https://github.com/llvm/llvm-project/pull/84983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement `__is_pointer_interconvertible_base_of()` (PR #88473)

2024-04-12 Thread Vlad Serebrennikov via cfe-commits
@@ -1740,7 +1740,7 @@ void is_layout_compatible(int n) static_assert(!__is_layout_compatible(void, int)); static_assert(__is_layout_compatible(void, const void)); static_assert(__is_layout_compatible(void, volatile void)); - static_assert(__is_layout_compatible(const

[clang] [Clang] Fix AST dump for {CXXDefaultArgExpr, CXXDefaultInitExpr} (PR #88269)

2024-04-12 Thread via cfe-commits
yronglin wrote: > LGTM again, thanks for the extra work to get JSON dumping as well! Thanks for your review! https://github.com/llvm/llvm-project/pull/88269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] a27ab3f - [Flang][AMDGPU] Add rocm-path flag (#88190)

2024-04-12 Thread via cfe-commits
Author: Dominik Adamski Date: 2024-04-12T16:41:34+02:00 New Revision: a27ab3f54377a0addeef1ec9ba7c826fd885a304 URL: https://github.com/llvm/llvm-project/commit/a27ab3f54377a0addeef1ec9ba7c826fd885a304 DIFF:

[clang] [flang] [Flang][AMDGPU] Add rocm-path flag (PR #88190)

2024-04-12 Thread Dominik Adamski via cfe-commits
https://github.com/DominikAdamski closed https://github.com/llvm/llvm-project/pull/88190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Support `PointerType` in `getCXXRecordDecl` for `ContainerModeling` (PR #87787)

2024-04-12 Thread via cfe-commits
shenjunjiekoda wrote: > Looks clean to me, even though I haven't checked how the ContainerModeling > checker works. Dear @steakhal , I hope this message finds you well. I find my pull request (PR#87787) submitted a week ago, which has been approved but not yet merged into the LLVM base

[clang] [Clang] Fix AST dump for {CXXDefaultArgExpr, CXXDefaultInitExpr} (PR #88269)

2024-04-12 Thread via cfe-commits
https://github.com/yronglin closed https://github.com/llvm/llvm-project/pull/88269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Export fixes from check_clang_tidy.py (PR #88186)

2024-04-12 Thread Edwin Vane via cfe-commits
revane wrote: @AaronBallman Other reviewers you would suggest? https://github.com/llvm/llvm-project/pull/88186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Simplify RenamerClangTidyCheck API (PR #88268)

2024-04-12 Thread Edwin Vane via cfe-commits
revane wrote: @AaronBallman I can't land this PR. https://github.com/llvm/llvm-project/pull/88268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][OpenMP] Fix casting of atomic update of ptr types (PR #88215)

2024-04-12 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. We should really fix using cmpxchg here. Can you open an IR issue for it? https://github.com/llvm/llvm-project/pull/88215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [flang] [Flang][AMDGPU] Add rocm-path flag (PR #88190)

2024-04-12 Thread Dominik Adamski via cfe-commits
@@ -345,7 +345,13 @@ void Flang::AddAMDGPUTargetArgs(const ArgList , // Check ROCm path if specified const ToolChain = getToolChain(); - TC.getDeviceLibs(Args); + std::string HIPVersion; + llvm::raw_string_ostream HIPInfo(HIPVersion); + TC.printVerboseInfo(HIPInfo);

[clang] [flang] [Flang][AMDGPU] Add rocm-path flag (PR #88190)

2024-04-12 Thread Dominik Adamski via cfe-commits
@@ -201,3 +201,16 @@ ! RUN: -nogpulibc %s 2>&1 \ ! RUN: | FileCheck --check-prefix=NO-LIBC-GPU-AMDGPU %s ! NO-LIBC-GPU-AMDGPU-NOT: "-lcgpu-amdgpu" + +! RUN: rm -rf %t/Inputs +! RUN: mkdir -p %t/Inputs +! RUN: cp -r %S/../../../clang/test/Driver/Inputs/rocm

[clang] [flang] [Flang][AMDGPU] Add rocm-path flag (PR #88190)

2024-04-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/88190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][OpenMP] Fix casting of atomic update of ptr types (PR #88215)

2024-04-12 Thread Matt Arsenault via cfe-commits
@@ -851,6 +852,16 @@ int main(void) { // CHECK: call{{.*}} @__kmpc_flush( #pragma omp atomic seq_cst rix = dv / rix; + +// CHECK: [[LD_CPX:%.+]] = load atomic ptr, ptr @cpx monotonic +// CHECK: br label %[[CONT:.+]] +// CHECK: [[CONT]] +// CHECK: [[PHI:%.+]] = phi ptr +//

[clang] [flang] [Flang][AMDGPU] Add rocm-path flag (PR #88190)

2024-04-12 Thread Dominik Adamski via cfe-commits
https://github.com/DominikAdamski updated https://github.com/llvm/llvm-project/pull/88190 >From 44def17f36e8e27eb4232681e5ae7eff5de6d90f Mon Sep 17 00:00:00 2001 From: Dominik Adamski Date: Tue, 9 Apr 2024 14:35:26 -0500 Subject: [PATCH 1/5] [Flang][AMDGPU] Add rocm-path flag ROCm

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-04-12 Thread Doug Wyatt via cfe-commits
@@ -4429,6 +4433,210 @@ class FunctionNoProtoType : public FunctionType, public llvm::FoldingSetNode { } }; +// -- + +class Decl; +class CXXMethodDecl; +class FunctionEffectSet; + +/// Represents

[clang] [clang-format] revert to string << string handling to previous default (PR #88490)

2024-04-12 Thread via cfe-commits
https://github.com/mydeveloperday updated https://github.com/llvm/llvm-project/pull/88490 >From 1c11c3edd0005a729561d84b9a815279b356e8db Mon Sep 17 00:00:00 2001 From: mydeveloperday Date: Fri, 12 Apr 2024 10:32:19 +0100 Subject: [PATCH 1/5] [clang-format] revery to string << string handling

[clang] [OpenACC] Implement 'if' clause for Compute Constructs (PR #88411)

2024-04-12 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/88411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] revert to string << string handling to previous default (PR #88490)

2024-04-12 Thread via cfe-commits
https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/88490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] revery to string << string handling back to previous default behaviour (PR #88490)

2024-04-12 Thread via cfe-commits
https://github.com/mydeveloperday updated https://github.com/llvm/llvm-project/pull/88490 >From 1c11c3edd0005a729561d84b9a815279b356e8db Mon Sep 17 00:00:00 2001 From: mydeveloperday Date: Fri, 12 Apr 2024 10:32:19 +0100 Subject: [PATCH 1/4] [clang-format] revery to string << string handling

[clang] [flang] [Flang][AMDGPU] Add rocm-path flag (PR #88190)

2024-04-12 Thread Joseph Huber via cfe-commits
@@ -201,3 +201,16 @@ ! RUN: -nogpulibc %s 2>&1 \ ! RUN: | FileCheck --check-prefix=NO-LIBC-GPU-AMDGPU %s ! NO-LIBC-GPU-AMDGPU-NOT: "-lcgpu-amdgpu" + +! RUN: rm -rf %t/Inputs +! RUN: mkdir -p %t/Inputs +! RUN: cp -r %S/../../../clang/test/Driver/Inputs/rocm

[clang] [Clang] Fix AST dump for {CXXDefaultArgExpr, CXXDefaultInitExpr} (PR #88269)

2024-04-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM again, thanks for the extra work to get JSON dumping as well! https://github.com/llvm/llvm-project/pull/88269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] revery to string << string handling back to previous default behaviour (PR #88490)

2024-04-12 Thread via cfe-commits
https://github.com/mydeveloperday updated https://github.com/llvm/llvm-project/pull/88490 >From 1c11c3edd0005a729561d84b9a815279b356e8db Mon Sep 17 00:00:00 2001 From: mydeveloperday Date: Fri, 12 Apr 2024 10:32:19 +0100 Subject: [PATCH 1/3] [clang-format] revery to string << string handling

[clang] [AMDGPU] add macro `__AMDGCN_CDNA_VERSION__` (PR #88293)

2024-04-12 Thread Matt Arsenault via cfe-commits
arsenm wrote: "CDNA version" isn't even a defined, technical concept, much less a useful one. We should be not be expanding the set of device macros, and strongly discouraging further use. https://github.com/llvm/llvm-project/pull/88293 ___

[clang] [AMDGPU] add macro `__AMDGCN_CDNA_VERSION__` (PR #88293)

2024-04-12 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/88293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Matt Arsenault via cfe-commits
@@ -6867,8 +6867,14 @@ void Clang::ConstructJob(Compilation , const JobAction , CmdArgs.push_back("-nogpulib"); if (Arg *A = Args.getLastArg(options::OPT_fcf_protection_EQ)) { -CmdArgs.push_back( -Args.MakeArgString(Twine("-fcf-protection=") +

[clang] Rework the printing of attributes (PR #87281)

2024-04-12 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > I can confirm that the double space comes from this PR; > > ```diff > diff --git a/clang/unittests/AST/DeclPrinterTest.cpp > b/clang/unittests/AST/DeclPrinterTest.cpp > index c24e442621c9..c2d02e74a62c 100644 > --- a/clang/unittests/AST/DeclPrinterTest.cpp > +++

[clang] [OpenACC] Implement 'if' clause for Compute Constructs (PR #88411)

2024-04-12 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/88411 >From 408f39f8ed0ee121aeaeb15c02603bb127e8cb73 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Wed, 10 Apr 2024 07:56:30 -0700 Subject: [PATCH 1/5] [OpenACC] Implement 'if' clause for Compute Constructs Like

[clang] [OpenACC] Implement 'if' clause for Compute Constructs (PR #88411)

2024-04-12 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/88411 >From 408f39f8ed0ee121aeaeb15c02603bb127e8cb73 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Wed, 10 Apr 2024 07:56:30 -0700 Subject: [PATCH 1/4] [OpenACC] Implement 'if' clause for Compute Constructs Like

[clang] [flang] [Flang][AMDGPU] Add rocm-path flag (PR #88190)

2024-04-12 Thread Dominik Adamski via cfe-commits
https://github.com/DominikAdamski updated https://github.com/llvm/llvm-project/pull/88190 >From 44def17f36e8e27eb4232681e5ae7eff5de6d90f Mon Sep 17 00:00:00 2001 From: Dominik Adamski Date: Tue, 9 Apr 2024 14:35:26 -0500 Subject: [PATCH 1/4] [Flang][AMDGPU] Add rocm-path flag ROCm

[clang] [OpenACC] Implement 'if' clause for Compute Constructs (PR #88411)

2024-04-12 Thread Erich Keane via cfe-commits
erichkeane wrote: > General question. Should there be some support in > clang/tools/libclang/CIndex.cpp? Sorry, I only just saw this! I guess I don't have a good idea what the CIndex stuff does. I see there is quite a bit of this 'Enqueue' functionality in CIndex.cpp, but it isn't clear

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,39 @@ +// Check that -fcf-protection does not get passed to the device-side +// compilation. + +// RUN: %clang -### -x cuda --target=x86_64-unknown-linux-gnu -nogpulib \ +// RUN: -nogpuinc --offload-arch=sm_52 -fcf-protection=full -c %s 2>&1 \ +// RUN: | FileCheck %s

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Joseph Huber via cfe-commits
@@ -6867,8 +6867,14 @@ void Clang::ConstructJob(Compilation , const JobAction , CmdArgs.push_back("-nogpulib"); if (Arg *A = Args.getLastArg(options::OPT_fcf_protection_EQ)) { -CmdArgs.push_back( -Args.MakeArgString(Twine("-fcf-protection=") +

[clang] [flang] [Flang][AMDGPU] Add rocm-path flag (PR #88190)

2024-04-12 Thread Dominik Adamski via cfe-commits
https://github.com/DominikAdamski updated https://github.com/llvm/llvm-project/pull/88190 >From 44def17f36e8e27eb4232681e5ae7eff5de6d90f Mon Sep 17 00:00:00 2001 From: Dominik Adamski Date: Tue, 9 Apr 2024 14:35:26 -0500 Subject: [PATCH 1/4] [Flang][AMDGPU] Add rocm-path flag ROCm

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,39 @@ +// Check that -fcf-protection does not get passed to the device-side +// compilation. + +// RUN: %clang -### -x cuda --target=x86_64-unknown-linux-gnu -nogpulib \ +// RUN: -nogpuinc --offload-arch=sm_52 -fcf-protection=full -c %s 2>&1 \ +// RUN: | FileCheck %s

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,39 @@ +// Check that -fcf-protection does not get passed to the device-side +// compilation. + +// RUN: %clang -### -x cuda --target=x86_64-unknown-linux-gnu -nogpulib \ +// RUN: -nogpuinc --offload-arch=sm_52 -fcf-protection=full -c %s 2>&1 \ +// RUN: | FileCheck %s

[clang] [Offload] Do not pass `-fcf-protection=` for offloading (PR #88402)

2024-04-12 Thread Matt Arsenault via cfe-commits
@@ -6867,8 +6867,14 @@ void Clang::ConstructJob(Compilation , const JobAction , CmdArgs.push_back("-nogpulib"); if (Arg *A = Args.getLastArg(options::OPT_fcf_protection_EQ)) { -CmdArgs.push_back( -Args.MakeArgString(Twine("-fcf-protection=") +

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

2024-04-12 Thread Michael Buch via cfe-commits
Michael137 wrote: LGTM, but would like @rjmccall or @AaronBallman (or another code-owner) to give final approval https://github.com/llvm/llvm-project/pull/84384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

2024-04-12 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/84384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

2024-04-12 Thread Michael Buch via cfe-commits
@@ -251,15 +423,16 @@ class Qualifiers { } // Deserialize qualifiers from an opaque representation. - static Qualifiers fromOpaqueValue(unsigned opaque) { + static Qualifiers fromOpaqueValue(uint64_t Opaque) { Qualifiers Qs; -Qs.Mask = opaque; +Qs.Mask =

[clang] [OpenACC] Implement 'if' clause for Compute Constructs (PR #88411)

2024-04-12 Thread Erich Keane via cfe-commits
@@ -11099,6 +11099,19 @@ OpenACCClause *TreeTransform::TransformOpenACCClause( ParsedClause.setDefaultDetails( cast(OldClause)->getDefaultClauseKind()); break; + case OpenACCClauseKind::If: { +Expr *Cond = const_cast( +

[clang] [flang] [Flang][AMDGPU] Add rocm-path flag (PR #88190)

2024-04-12 Thread Joseph Huber via cfe-commits
@@ -345,7 +345,13 @@ void Flang::AddAMDGPUTargetArgs(const ArgList , // Check ROCm path if specified const ToolChain = getToolChain(); - TC.getDeviceLibs(Args); + std::string HIPVersion; + llvm::raw_string_ostream HIPInfo(HIPVersion); + TC.printVerboseInfo(HIPInfo);

[clang] [Clang][Sema] placement new initializes typedef array with correct size (PR #83124)

2024-04-12 Thread via cfe-commits
mahtohappy wrote: Hi Please Review this. @Endilll @cor3ntin @AaronBallman https://github.com/llvm/llvm-project/pull/83124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for some CWG 5xx issues (PR #87909)

2024-04-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/87909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5ebeaf2 - [clang] Add tests for some CWG 5xx issues (#87909)

2024-04-12 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-04-12T16:02:57+04:00 New Revision: 5ebeaf211551f9410e17b1134126daadd8b163ac URL: https://github.com/llvm/llvm-project/commit/5ebeaf211551f9410e17b1134126daadd8b163ac DIFF:

[clang] [CMake][Release] Disable PGO (PR #88465)

2024-04-12 Thread Tom Stellard via cfe-commits
tstellar wrote: > I'm assuming this is a stop-gap, and the plan is to eventually fix the issue > and reenable PGO in the release cache? Yes, I would like to fix this at some point, but not sure when I'll get to it. https://github.com/llvm/llvm-project/pull/88465

[clang] [clang] Add tests for some CWG 5xx issues (PR #87909)

2024-04-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/87909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 33779b8 - Reword a diagnostic; NFC

2024-04-12 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-04-12T07:43:39-04:00 New Revision: 33779b861d748ed18b8d4f9cbad3a84deaa95e9f URL: https://github.com/llvm/llvm-project/commit/33779b861d748ed18b8d4f9cbad3a84deaa95e9f DIFF: https://github.com/llvm/llvm-project/commit/33779b861d748ed18b8d4f9cbad3a84deaa95e9f.diff

[clang] [llvm] [CLANG][LLVM][AArch64]Add SME2.1 intrinsics for MOVAZ tile to vector,… (PR #88499)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: None (CarolineConcatto) Changes … single According to the specification in ARM-software/acle#309 this adds the intrinsics // And similarly for u8. svint8_t svreadz_hor_za8_s8(uint64_t tile, uint32_t slice) __arm_streaming

[clang] [llvm] [CLANG][LLVM][AArch64]Add SME2.1 intrinsics for MOVAZ tile to vector,… (PR #88499)

2024-04-12 Thread via cfe-commits
https://github.com/CarolineConcatto created https://github.com/llvm/llvm-project/pull/88499 … single According to the specification in ARM-software/acle#309 this adds the intrinsics // And similarly for u8. svint8_t svreadz_hor_za8_s8(uint64_t tile, uint32_t slice) __arm_streaming

[clang] [Clang][AArch64] Extend diagnostics when warning non/streaming about … (PR #88380)

2024-04-12 Thread Sander de Smalen via cfe-commits
@@ -3756,12 +3756,11 @@ def err_sme_definition_using_za_in_non_sme_target : Error< def err_sme_definition_using_zt0_in_non_sme2_target : Error< "function using ZT0 state requires 'sme2'">; def warn_sme_streaming_pass_return_vl_to_non_streaming : Warning< - "passing a

[clang] [Clang][AArch64] Extend diagnostics when warning non/streaming about … (PR #88380)

2024-04-12 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm commented: Left two nits, but otherwise looks good. https://github.com/llvm/llvm-project/pull/88380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Extend diagnostics when warning non/streaming about … (PR #88380)

2024-04-12 Thread Sander de Smalen via cfe-commits
@@ -3756,12 +3756,11 @@ def err_sme_definition_using_za_in_non_sme_target : Error< def err_sme_definition_using_zt0_in_non_sme2_target : Error< "function using ZT0 state requires 'sme2'">; def warn_sme_streaming_pass_return_vl_to_non_streaming : Warning< - "passing a

[clang] [Clang][AArch64] Extend diagnostics when warning non/streaming about … (PR #88380)

2024-04-12 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/88380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] revery to string << string handling back to previous default behaviour (PR #88490)

2024-04-12 Thread via cfe-commits
https://github.com/mydeveloperday updated https://github.com/llvm/llvm-project/pull/88490 >From 1c11c3edd0005a729561d84b9a815279b356e8db Mon Sep 17 00:00:00 2001 From: mydeveloperday Date: Fri, 12 Apr 2024 10:32:19 +0100 Subject: [PATCH 1/2] [clang-format] revery to string << string handling

[clang] [Clang] Reduce the size of Decl and classes derived from it (PR #87361)

2024-04-12 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/87361 >From b8a626116b0719c1acf75e9e7300df8e2bf82f99 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 2 Apr 2024 18:00:05 +0200 Subject: [PATCH 1/3] [Clang] Reduce the size of Decl and classes derived from

[clang] c39df49 - [clang][NFC] Refactor `CUDAFunctionTarget`

2024-04-12 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-04-12T13:06:59+03:00 New Revision: c39df496d73621238ba87de235d9a61e2b2203b9 URL: https://github.com/llvm/llvm-project/commit/c39df496d73621238ba87de235d9a61e2b2203b9 DIFF:

[clang-tools-extra] [clangd] Support go-to-definition on type hints. The core part (PR #86629)

2024-04-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/86629 >From b8a69cbd9e0ee0aa35b38b7e3a78048cbe61447e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sat, 16 Mar 2024 23:30:10 +0800 Subject: [PATCH 01/10] [clangd] Support go-to-definition on type hints. The core

[clang] [llvm] [ARM] Armv8-R does not require fp64 or neon. (PR #88287)

2024-04-12 Thread Chris Copeland via cfe-commits
https://github.com/chrisnc updated https://github.com/llvm/llvm-project/pull/88287 >From 58f4d1acb3a88ec0b7d623fd7607d355f6dfe2c3 Mon Sep 17 00:00:00 2001 From: Chris Copeland Date: Fri, 5 Apr 2024 22:40:46 -0700 Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon. ---

[clang] [llvm] [HLSL][SPIRV] Add any intrinsic lowering (PR #88325)

2024-04-12 Thread Vyacheslav Levytskyy via cfe-commits
https://github.com/VyacheslavLevytskyy approved this pull request. https://github.com/llvm/llvm-project/pull/88325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] revery to string << string handling back to previous default behaviour (PR #88490)

2024-04-12 Thread via cfe-commits
mydeveloperday wrote: Other related issues #44363 , #59797 https://github.com/llvm/llvm-project/pull/88490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] revery to string << string handling back to previous default behaviour (PR #88490)

2024-04-12 Thread via cfe-commits
mydeveloperday wrote: Fixes #88483 https://github.com/llvm/llvm-project/pull/88490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] revery to string << string handling back to previous default behaviour (PR #88490)

2024-04-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ff9bc3a0fa4e3790c437e62450903bf399df37f9 1c11c3edd0005a729561d84b9a815279b356e8db --

[clang] [clang-format] revery to string << string handling back to previous default behaviour (PR #88490)

2024-04-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: MyDeveloperDay (mydeveloperday) Changes Fixes 88433 A change made to the handling of chevron operators causes a large amount of flux in code bases that were previously using clang-format, this fix reverts that change to the default

<    1   2   3   4   >