https://github.com/AlexVlx updated
https://github.com/llvm/llvm-project/pull/88182
>From 426e74cabb003eb5dc83adf347a5800d49bc87b7 Mon Sep 17 00:00:00 2001
From: Alex Voicu
Date: Mon, 18 Mar 2024 11:49:12 +
Subject: [PATCH 1/8] Start migrating away from the embedded assumption that
the
@@ -8343,58 +8343,52 @@ bool
Sema::CheckTemplateTemplateArgument(TemplateTemplateParmDecl *Param,
// C++1z [temp.arg.template]p3: (DR 150)
// A template-argument matches a template template-parameter P when P
// is at least as specialized as the template-argument A.
https://github.com/Troy-Butler updated
https://github.com/llvm/llvm-project/pull/89512
>From f03466fa44a3c7210e7590e6305bc0c9f9aeb446 Mon Sep 17 00:00:00 2001
From: Troy-Butler
Date: Sat, 20 Apr 2024 15:13:09 -0400
Subject: [PATCH 1/4] Fix Definition-Declaration Mismatches
Signed-off-by:
https://github.com/erichkeane commented:
Also needs a release note, entry into breaking changes, and a post on mailing
list or whatever for the 'breaking change' subscribers to pay attention to.
https://github.com/llvm/llvm-project/pull/89807
___
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 78eb2c2cba5ad0f9a36ec1959371527313a76bbe
22b67d30ca087d6a912183039c87fd1790eedfe4 --
@@ -8343,58 +8343,52 @@ bool
Sema::CheckTemplateTemplateArgument(TemplateTemplateParmDecl *Param,
// C++1z [temp.arg.template]p3: (DR 150)
// A template-argument matches a template template-parameter P when P
// is at least as specialized as the template-argument A.
@@ -6561,7 +6561,7 @@ void Clang::ConstructJob(Compilation , const JobAction
,
if (const Arg *A =
Args.getLastArg(options::OPT_fvisibility_global_new_delete_hidden)) {
D.Diag(diag::warn_drv_deprecated_arg)
-<< A->getAsString(Args)
+<<
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/89807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
We probably need to attach this to ClangABI as well, this is an ABI breaking
change.
https://github.com/llvm/llvm-project/pull/89807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/hekota created
https://github.com/llvm/llvm-project/pull/89809
Fixes #89802
>From 22b67d30ca087d6a912183039c87fd1790eedfe4 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Tue, 23 Apr 2024 00:49:28 -0700
Subject: [PATCH] Add environment parameter to clang availability
mstorsjo wrote:
> > I would suggest we revert this - and at least collect all the observed side
> > effects and declare them before considering relanding it.
>
> That sounds good to me. Do you have a list of PRs to revert?
Not sure if there are follow-up fixes, sorry, but the discussed PRs
@@ -2922,7 +2922,7 @@ static bool handleFloatFloatBinOp(EvalInfo , const
BinaryOperator *E,
// If during the evaluation of an expression, the result is not
// mathematically defined [...], the behavior is undefined.
// FIXME: C++ rules require us to not conform to
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
This patch will finally allow us to mark C++17 support in clang as complete.
This is a continuation of the review process from an [old PR in
phab](https://reviews.llvm.org/D109496).
Recap: The original
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/89807
This patch will finally allow us to mark C++17 support in clang as complete.
This is a continuation of the review process from an [old PR in
phab](https://reviews.llvm.org/D109496).
Recap: The original patch
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/89731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Haojian Wu
Date: 2024-04-23T21:09:36+02:00
New Revision: dc8f6a8cdad427345a60f5142411617df521c303
URL:
https://github.com/llvm/llvm-project/commit/dc8f6a8cdad427345a60f5142411617df521c303
DIFF:
https://github.com/llvm/llvm-project/commit/dc8f6a8cdad427345a60f5142411617df521c303.diff
https://github.com/HazardyKnusperkeks approved this pull request.
I don't see a use case for that comment, and thus I see no problem in removing
it.
https://github.com/llvm/llvm-project/pull/89228
___
cfe-commits mailing list
nico wrote:
> I would suggest we revert this - and at least collect all the observed side
> effects and declare them before considering relanding it.
That sounds good to me. Do you have a list of PRs to revert?
> ... then we do still get the old name embedded.
Sure. The motivation on our
@@ -147,19 +147,25 @@ void
WebAssemblyTargetInfo::setFeatureEnabled(llvm::StringMap ,
bool WebAssemblyTargetInfo::initFeatureMap(
llvm::StringMap , DiagnosticsEngine , StringRef CPU,
const std::vector ) const {
- if (CPU == "bleeding-edge") {
-
@@ -1792,6 +1792,11 @@ class TargetInfo : public TransferrableTargetInfo,
/// Whether to support HIP image/texture API's.
virtual bool hasHIPImageSupport() const { return true; }
+ /// The minimum offset between two objects to avoid false sharing.
+ virtual unsigned
@@ -1792,6 +1792,11 @@ class TargetInfo : public TransferrableTargetInfo,
/// Whether to support HIP image/texture API's.
virtual bool hasHIPImageSupport() const { return true; }
+ /// The minimum offset between two objects to avoid false sharing.
https://github.com/jyknight edited
https://github.com/llvm/llvm-project/pull/89446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jyknight commented:
I think having the on-by-default diagnostic before we release this
functionality is critically important -- but the primarily-useful part of that
is going to be for the public libc++ APIs which expose these values (and, that
already landed in mainline).
@@ -147,19 +147,25 @@ void
WebAssemblyTargetInfo::setFeatureEnabled(llvm::StringMap ,
bool WebAssemblyTargetInfo::initFeatureMap(
llvm::StringMap , DiagnosticsEngine , StringRef CPU,
const std::vector ) const {
- if (CPU == "bleeding-edge") {
-
https://github.com/tlively approved this pull request.
https://github.com/llvm/llvm-project/pull/80923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tlively edited
https://github.com/llvm/llvm-project/pull/80923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/89706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday closed
https://github.com/llvm/llvm-project/pull/78176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mydeveloperday wrote:
I'm ok with removing it if @owenca and @HazardyKnusperkeks are.
https://github.com/llvm/llvm-project/pull/89228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1441,6 +1441,10 @@ void HeaderSearch::MarkFileModuleHeader(FileEntryRef FE,
HFI.isCompilingModuleHeader |= isCompilingModuleHeader;
}
+void HeaderSearch::EnteredTextualFile(FileEntryRef File) {
+ getFileInfo(File).isCompilingModuleHeader = true;
https://github.com/tlively approved this pull request.
https://github.com/llvm/llvm-project/pull/89778
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tlively approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/89777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/89706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smanna12 updated
https://github.com/llvm/llvm-project/pull/89801
>From 326b428c826e866feb538b9dcd33a9df957f9f69 Mon Sep 17 00:00:00 2001
From: "Manna, Soumi"
Date: Tue, 23 Apr 2024 10:37:01 -0700
Subject: [PATCH 1/2] [Clang] [NFC] Prevent null pointer dereference in
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vassil Vassilev (vgvassilev)
Changes
The IdResolver chain is the main way for C to implement lookup rules. Every new
partial translation unit caused clang to exit the top-most scope which in turn
cleaned up the IdResolver chain. That was
https://github.com/vgvassilev created
https://github.com/llvm/llvm-project/pull/89804
The IdResolver chain is the main way for C to implement lookup rules. Every new
partial translation unit caused clang to exit the top-most scope which in turn
cleaned up the IdResolver chain. That was not an
Sirraide wrote:
And moreover, `getParamDecl()` already asserts that the index is in bounds.
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -89,6 +89,19 @@ sections with improvements to Clang's support for those
languages.
C++ Language Changes
+C++17 Feature Support
+^
+- Clang now exposes ``__GCC_DESTRUCTIVE_SIZE`` and ``__GCC_CONSTRUCTIVE_SIZE``
+ predefined macros
https://github.com/Sirraide commented:
A pr that just adds assertions and nothing else seems like a very weird thing
to do. Moreover, a few lines above in the same function, we return if this
isn’t a copy/move ctor/assignment operator, which always has at least one
parameter; I don’t think it
zmodem wrote:
> Does this address
> https://discourse.llvm.org/t/coro-pre-split-handling-of-the-suspend-edge/75043?
> Could you add a note there in that direction - a few folks were looking at
> going at the direction @jyknight was suggesting there, and it'd be good to
> have closure on the
@@ -592,6 +592,48 @@ class AttrSubjectMatcherAggregateRule
{
def SubjectMatcherForNamed : AttrSubjectMatcherAggregateRule;
+// Late Attribute parsing mode enum
+class LateAttrParseKind {
+ int Kind = val;
+}
+
+// Never late parsed
+def LateAttrParseNever :
jhuber6 wrote:
Note that this doesn't affect OpenMP or HIP. The former uses the
`clang-linker-wrapper` while the latter calls `lld` directly.
https://github.com/llvm/llvm-project/pull/89803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-backend-amdgpu
Author: Joseph Huber (jhuber6)
Changes
Summary:
The AMDGPU toolchain simply took the short name to get the link job
instead of using the common utilities that respect options like
`-fuse-ld`. Any linker that
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/89803
Summary:
The AMDGPU toolchain simply took the short name to get the link job
instead of using the common utilities that respect options like
`-fuse-ld`. Any linker that isn't `ld.lld` will fail, however we should
mahtohappy wrote:
Hi @ilovepi Sure. Looking at this.
https://github.com/llvm/llvm-project/pull/89036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
I think we're seeing some build failures after this patch, and it isn't clear
to me that this is a bug in the source, so I'd appreciate it if you could take
a look.
```
FAILED:
obj/src/media/audio/tools/signal_generator/signal_generator.signal_generator.cc.o
chrisnc wrote:
Updated to fix the conflict with the ARM.td refactor. Ready for review.
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
delcypher wrote:
@AaronBallman Thanks for the feedback
> We should probably add a release note to tell users about the new command
> line option, unless you think it makes more sense to do so after something
> uses `LateAttrParseExperimentalExt`?
I had a think about it and I'll add a release
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From 0a3a3c29b599df0cc6e3066b3388151fdb313cc2 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
Specifying
@@ -4781,6 +4782,7 @@ CodeGenModule::CreateRuntimeFunction(llvm::FunctionType
*FTy, StringRef Name,
}
}
setDSOLocal(F);
+ markRegisterParameterAttributes(F);
efriedma-quic wrote:
This really shouldn't work this way: we should go
MaskRay wrote:
My recollection of the past discussions is that we want users to switch to the
new hierarchy.
*BSD, Linux, and z/OS have migrated but I am not familiar with the Windows
ecosystems.
`ToolChain::getCompilerRT` detects both the old and new compiler-rt directory.
Does it not work
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/89309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/89734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/chrulski-intel approved this pull request.
https://github.com/llvm/llvm-project/pull/88438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -89,6 +89,19 @@ sections with improvements to Clang's support for those
languages.
C++ Language Changes
+C++17 Feature Support
+^
+- Clang now exposes ``__GCC_DESTRUCTIVE_SIZE`` and ``__GCC_CONSTRUCTIVE_SIZE``
+ predefined macros
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
…nctionDefinition
In the lambda function within clang::Sema::InstantiateFunctionDefinition, the
return value of a function that may return null is now checked before
dereferencing to avoid potential null pointer
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/89801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smanna12 created
https://github.com/llvm/llvm-project/pull/89801
…nctionDefinition
In the lambda function within clang::Sema::InstantiateFunctionDefinition, the
return value of a function that may return null is now checked before
dereferencing to avoid potential null
@@ -89,6 +89,19 @@ sections with improvements to Clang's support for those
languages.
C++ Language Changes
+C++17 Feature Support
+^
+- Clang now exposes ``__GCC_DESTRUCTIVE_SIZE`` and ``__GCC_CONSTRUCTIVE_SIZE``
+ predefined macros
@@ -592,6 +592,48 @@ class AttrSubjectMatcherAggregateRule
{
def SubjectMatcherForNamed : AttrSubjectMatcherAggregateRule;
+// Late Attribute parsing mode enum
+class LateAttrParseKind {
+ int Kind = val;
+}
+
+// Never late parsed
+def LateAttrParseNever :
@@ -220,8 +230,28 @@ void Parser::ParseGNUAttributes(ParsedAttributes ,
continue;
}
+ bool LateParse = false;
+ if (!LateAttrs)
+LateParse = false;
+ else {
AaronBallman wrote:
Can remove a level of indentation here by
@@ -1822,28 +1822,100 @@ void WriteSemanticSpellingSwitch(const std::string
,
OS << " }\n";
}
+enum class LateAttrParseKind { Never = 0, Standard = 1, ExperimentalExt = 2 };
+
+static LateAttrParseKind getLateAttrParseKind(const Record *Attr) {
+ // This function
@@ -1822,28 +1822,100 @@ void WriteSemanticSpellingSwitch(const std::string
,
OS << " }\n";
}
+enum class LateAttrParseKind { Never = 0, Standard = 1, ExperimentalExt = 2 };
AaronBallman wrote:
```suggestion
// Note: these values need to match the values
@@ -220,8 +230,28 @@ void Parser::ParseGNUAttributes(ParsedAttributes ,
continue;
}
+ bool LateParse = false;
+ if (!LateAttrs)
+LateParse = false;
+ else {
+if (LateAttrs->lateAttrParseExperimentalExtOnly()) {
+ // The
@@ -1822,28 +1822,100 @@ void WriteSemanticSpellingSwitch(const std::string
,
OS << " }\n";
}
+enum class LateAttrParseKind { Never = 0, Standard = 1, ExperimentalExt = 2 };
+
+static LateAttrParseKind getLateAttrParseKind(const Record *Attr) {
+ // This function
@@ -592,6 +592,48 @@ class AttrSubjectMatcherAggregateRule
{
def SubjectMatcherForNamed : AttrSubjectMatcherAggregateRule;
+// Late Attribute parsing mode enum
+class LateAttrParseKind {
+ int Kind = val;
+}
AaronBallman wrote:
```suggestion
//
@@ -592,6 +592,48 @@ class AttrSubjectMatcherAggregateRule
{
def SubjectMatcherForNamed : AttrSubjectMatcherAggregateRule;
+// Late Attribute parsing mode enum
+class LateAttrParseKind {
+ int Kind = val;
+}
+
+// Never late parsed
+def LateAttrParseNever :
https://github.com/AaronBallman commented:
We should probably add a release note to tell users about the new command line
option, unless you think it makes more sense to do so after something uses
`LateAttrParseExperimentalExt`?
One concern I have is that nothing is testing the new parsing
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/88596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8547,15 +8547,25 @@ static const RecordDecl
*GetEnclosingNamedOrTopAnonRecord(const FieldDecl *FD) {
return RD;
}
-static bool
-CheckCountExpr(Sema , FieldDecl *FD, Expr *E,
- llvm::SmallVectorImpl ) {
+static bool CheckCountedByAttrOnField(
+Sema ,
dschuff wrote:
I think "generic" is the default CPU so object files will have it enabled by
default. You can still specify "mvp" as the CPU as before to avoid it.
https://github.com/llvm/llvm-project/pull/80923
___
cfe-commits mailing list
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/89078
>From c611122688657287e8285edd9a2875e4975d26dd Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Wed, 17 Apr 2024 16:15:39 +0200
Subject: [PATCH 1/9] [Clang] Disallow explicit object parameters in more
contexts
https://github.com/AlexVlx updated
https://github.com/llvm/llvm-project/pull/89796
>From 662f160418c704f45e57e751168903d774b74303 Mon Sep 17 00:00:00 2001
From: Alex Voicu
Date: Tue, 23 Apr 2024 17:41:25 +0100
Subject: [PATCH 1/2] Add initial support for AMDGCN flavoured SPIRV.
---
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/89078
>From c611122688657287e8285edd9a2875e4975d26dd Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Wed, 17 Apr 2024 16:15:39 +0200
Subject: [PATCH 1/8] [Clang] Disallow explicit object parameters in more
contexts
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c793f4a4dab058cee4f283100946a1bb8e465f59
662f160418c704f45e57e751168903d774b74303 --
Sirraide wrote:
Alright, it took me a bit, but I’ve figured out how to continue issuing the
‘... cannot appear in a non-member function’ diagnostic where appropriate. This
also handles `friend` declarations now because I had forgotten about that; I’ve
also added a few more tests for
@@ -5,7 +5,7 @@
void f(this); // expected-error{{variable has incomplete type 'void'}} \
// expected-error{{invalid use of 'this' outside of a non-static
member function}}
-void g(this auto); // expected-error{{an explicit object parameter cannot
appear in a
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Alex Voicu (AlexVlx)
Changes
This change seeks to add support for vendor flavoured SPIRV - more
specifically, AMDGCN flavoured SPIRV. The aim is to generate SPIRV that carries
some extra bits of information that are only usable
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/89078
>From c611122688657287e8285edd9a2875e4975d26dd Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Wed, 17 Apr 2024 16:15:39 +0200
Subject: [PATCH 1/7] [Clang] Disallow explicit object parameters in more
contexts
https://github.com/AlexVlx created
https://github.com/llvm/llvm-project/pull/89796
This change seeks to add support for vendor flavoured SPIRV - more
specifically, AMDGCN flavoured SPIRV. The aim is to generate SPIRV that carries
some extra bits of information that are only usable by AMDGCN
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/89078
>From c611122688657287e8285edd9a2875e4975d26dd Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Wed, 17 Apr 2024 16:15:39 +0200
Subject: [PATCH 1/6] [Clang] Disallow explicit object parameters in more
contexts
@@ -1371,14 +1371,23 @@ class Parser : public CodeCompletionHandler {
};
// A list of late-parsed attributes. Used by ParseGNUAttributes.
- class LateParsedAttrList: public SmallVector {
+ class LateParsedAttrList : public SmallVector {
rapidsna wrote:
https://github.com/tex3d approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/89788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rapidsna approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2101,9 +2173,21 @@ bool PragmaClangAttributeSupport::isAttributedSupported(
return SpecifiedResult;
// Opt-out rules:
- // An attribute requires delayed parsing (LateParsed is on)
- if (Attribute.getValueAsBit("LateParsed"))
+
+ // An attribute requires delayed
pogo59 wrote:
> It's been like that for maybe 2-3 years now and no one has complained about it
As a downstream vendor I can tell you we work around things all the time
without bothering to try to fix things upstream (I try to encourage more
engagement, but I can't control what people actually
@@ -89,13 +89,23 @@ static StringRef normalizeAttrName(StringRef Name) {
return Name;
}
-/// isAttributeLateParsed - Return true if the attribute has arguments that
-/// require late parsing.
-static bool isAttributeLateParsed(const IdentifierInfo ) {
+/// returns true iff
pogo59 wrote:
> what gets emitted as embedded directive, when the compiler doesn't see either
> of them at compile time (with e.g. distributed build systems), while they
> might be available at link time.
This is exactly the scenario we had. I will double-check that it is solved by
my patch,
https://github.com/llvm-beanz updated
https://github.com/llvm/llvm-project/pull/89788
>From a44bb91986dcde7265666391c6aa46bc0876070d Mon Sep 17 00:00:00 2001
From: Chris Bieneman
Date: Tue, 23 Apr 2024 11:13:09 -0500
Subject: [PATCH 1/2] [HLSL] Correctly set `__HLSL_ENABLE_16_BIT`
The
@@ -807,12 +807,18 @@ template <> struct MappingTraits {
FormatStyle PredefinedStyle;
if (getPredefinedStyle(StyleName, Style.Language, ) &&
Style == PredefinedStyle) {
- IO.mapOptional("# BasedOnStyle", StyleName);
https://github.com/topperc updated
https://github.com/llvm/llvm-project/pull/89684
>From c28f21fb93f31661f8313259f0103dc1af44f4a7 Mon Sep 17 00:00:00 2001
From: Craig Topper
Date: Mon, 22 Apr 2024 13:19:26 -0700
Subject: [PATCH 1/2] [RISCV] Split code that tablegen needs out of
RISCVISAInfo.
@@ -2922,7 +2922,7 @@ static bool handleFloatFloatBinOp(EvalInfo , const
BinaryOperator *E,
// If during the evaluation of an expression, the result is not
// mathematically defined [...], the behavior is undefined.
// FIXME: C++ rules require us to not conform to
mstorsjo wrote:
> Commit
> [b876596](https://github.com/llvm/llvm-project/commit/b876596a76cdc183439b36455d26883b67f8ee51)
> corrected default compiler-rt library names for many targets
Are you sure it's this change? There are reports of similar changes showing up
in
@@ -1149,6 +1149,13 @@ std::string Triple::normalize(StringRef Str) {
}
}
+ // For 3-component triples, the middle component is used to set Vendor;
+ // while if it is "none", we'd prefer to set OS.
+ // This is for some baremetal cases, such as "arm-none-elf".
+ if
https://github.com/damyanp approved this pull request.
https://github.com/llvm/llvm-project/pull/89788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Chris B (llvm-beanz)
Changes
The preprocessor define `__HLSL_ENABLE_16_BIT` should be set to 1 if native
16-bit types are enabled and not set if they are not.
Previously we were setting the value to match the HLSL active language
tru wrote:
It's been like that for maybe 2-3 years now and no one has complained about it,
so I think that change is solid. I can suggest a CMake change, but last time it
was discussed I think @maskray was against a new variable, but since we might
need to have some different behaviour it
https://github.com/llvm-beanz created
https://github.com/llvm/llvm-project/pull/89788
The preprocessor define `__HLSL_ENABLE_16_BIT` should be set to 1 if native
16-bit types are enabled and not set if they are not.
Previously we were setting the value to match the HLSL active language
201 - 300 of 489 matches
Mail list logo