https://github.com/ellishg updated
https://github.com/llvm/llvm-project/pull/90925
>From 4760ebce0ff7725f4bb75f5107f551d867e4db6d Mon Sep 17 00:00:00 2001
From: Ellis Hoag
Date: Thu, 2 May 2024 17:47:38 -0700
Subject: [PATCH 1/3] [modules] Accept equivalent module caches from different
symlink
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/85672
>From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Mon, 18 Mar 2024 10:19:38 -0700
Subject: [PATCH 1/7] [clang][CodeGen] Omit pre-opt link when post-opt link
request
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/90933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/90934
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8588,31 +8588,71 @@ static const RecordDecl
*GetEnclosingNamedOrTopAnonRecord(const FieldDecl *FD) {
return RD;
}
-static bool
-CheckCountExpr(Sema &S, FieldDecl *FD, Expr *E,
- llvm::SmallVectorImpl &Decls) {
+enum class CountedByInvalidPointeeTypeKind {
@@ -1,3 +1,10 @@
+# Checkout as native, commit as LF except in specific circumstances
+* text=auto
+*.bat text eol=crlf
+*.rc text eol=crlf
+*.sln text eol=crlf
MaskRay wrote:
Do we need `.sln`? There is only one file in `clang/tools/clang-format-vs`.
There are
dwblaikie wrote:
> > Comment in the code should probably mention this as a FIXME and include a
> > reference to the issue?
>
> Sure, added in
> [f78949a](https://github.com/llvm/llvm-project/commit/f78949a07e33017a798c410a102c95455685a9b1)
Thanks!
> > Also, there's another bug here - the DW_
jhuber6 wrote:
Going to land this soon.
@jplehr @estewart08 @ronlieb Applied this on the AMD fork, here the diff.
https://gist.github.com/jhuber6/e856fbe9c73acea13b6d30b20605c73e
https://github.com/llvm/llvm-project/pull/87009
___
cfe-commits mailing
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/86318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -79,3 +79,16 @@ float V7 = []() -> float {
0x0.01p0F);
}();
// CHECK: @V7 = {{.*}} float 1.00e+00
+
+template struct L {
+ constexpr L() : value(V) {}
+ float value;
+};
+
+#pragma STDC FENV_ROUND FE_DOWNWARD
erichkeane wrote:
>Does this test ad
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/90304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1 @@
+dos-style-eol.txt
ldrumm wrote:
Thanks `text eol=crlf`. Updated in 64350b342a09ba69803a541a89b5681a12925ff0
https://github.com/llvm/llvm-project/pull/86318
___
cfe-commits mailing list
cfe-commits@lists.
https://github.com/ilinpv closed https://github.com/llvm/llvm-project/pull/90928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Pavel Iliin
Date: 2024-05-03T18:07:17+01:00
New Revision: 804202292b7601feee5c091a3a6df6124f4d61e1
URL:
https://github.com/llvm/llvm-project/commit/804202292b7601feee5c091a3a6df6124f4d61e1
DIFF:
https://github.com/llvm/llvm-project/commit/804202292b7601feee5c091a3a6df6124f4d61e1.diff
L
@@ -79,3 +79,16 @@ float V7 = []() -> float {
0x0.01p0F);
}();
// CHECK: @V7 = {{.*}} float 1.00e+00
+
+template struct L {
+ constexpr L() : value(V) {}
+ float value;
+};
+
+#pragma STDC FENV_ROUND FE_DOWNWARD
spavloff wrote:
> Does the FENV_ROUN
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/90933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kyulee-com edited
https://github.com/llvm/llvm-project/pull/90934
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -839,17 +839,15 @@ static bool checkHeaderSearchOptions(const
HeaderSearchOptions &HSOpts,
DiagnosticsEngine *Diags,
const LangOptions &LangOpts,
const Preprocesso
https://github.com/ellishg updated
https://github.com/llvm/llvm-project/pull/90925
>From 4760ebce0ff7725f4bb75f5107f551d867e4db6d Mon Sep 17 00:00:00 2001
From: Ellis Hoag
Date: Thu, 2 May 2024 17:47:38 -0700
Subject: [PATCH 1/2] [modules] Accept equivalent module caches from different
symlink
@@ -8057,3 +8057,70 @@ requirement:
}
}];
}
+
+def DocCatNonBlockingNonAllocating : DocumentationCategory<"Performance
Constraint Attributes"> {
+ let Content = [{
cjappl wrote:
It may be good to mention what the flag is that you use to enable these
war
erichkeane wrote:
> This seems to break the version of libstdc++ we use in our sysroot: (Details
> on https://crbug.com/338536261)
>
> ```
> ../../build/linux/debian_bullseye_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/stl_iterator.h:1718:20:
> error: use 'tem
https://github.com/dougsonos ready_for_review
https://github.com/llvm/llvm-project/pull/84983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/89727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1 @@
+dos-style-eol.txt
MaskRay wrote:
missing text=auto eol=crlf ?
https://github.com/llvm/llvm-project/pull/86318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
Author: Fangrui Song
Date: 2024-05-03T09:39:17-07:00
New Revision: ac46eeaea8bc987e8a858a29d3b3e9e6539a81a8
URL:
https://github.com/llvm/llvm-project/commit/ac46eeaea8bc987e8a858a29d3b3e9e6539a81a8
DIFF:
https://github.com/llvm/llvm-project/commit/ac46eeaea8bc987e8a858a29d3b3e9e6539a81a8.diff
jyu2-git wrote:
> > Looks broken
> > https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/9/logs/stdio
>
> This is special build from this PR see `git status` here
> https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/6/logs/stdio
Hi @vitalybuka, thanks for looking it up.
zmodem wrote:
This seems to break the version of libstdc++ we use in our sysroot: (Details on
https://crbug.com/338536261)
```
../../build/linux/debian_bullseye_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/stl_iterator.h:1718:20:
error: use 'template' keyword t
https://github.com/topperc closed
https://github.com/llvm/llvm-project/pull/90879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Craig Topper
Date: 2024-05-03T09:29:27-07:00
New Revision: 0faf494200860c307ba473114df6e50f7da1b52a
URL:
https://github.com/llvm/llvm-project/commit/0faf494200860c307ba473114df6e50f7da1b52a
DIFF:
https://github.com/llvm/llvm-project/commit/0faf494200860c307ba473114df6e50f7da1b52a.diff
https://github.com/5chmidti closed
https://github.com/llvm/llvm-project/pull/88737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Julian Schmidt
Date: 2024-05-03T18:23:13+02:00
New Revision: 8d946c71712daeabf6636ff3844fa49e4638324b
URL:
https://github.com/llvm/llvm-project/commit/8d946c71712daeabf6636ff3844fa49e4638324b
DIFF:
https://github.com/llvm/llvm-project/commit/8d946c71712daeabf6636ff3844fa49e4638324b.diff
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/88737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dougsonos edited
https://github.com/llvm/llvm-project/pull/84983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dougsonos edited
https://github.com/llvm/llvm-project/pull/84983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dougsonos edited
https://github.com/llvm/llvm-project/pull/84983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
ping
https://github.com/llvm/llvm-project/pull/90686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -79,3 +79,16 @@ float V7 = []() -> float {
0x0.01p0F);
}();
// CHECK: @V7 = {{.*}} float 1.00e+00
+
+template struct L {
+ constexpr L() : value(V) {}
+ float value;
+};
+
+#pragma STDC FENV_ROUND FE_DOWNWARD
erichkeane wrote:
> In this snippet
@@ -79,3 +79,16 @@ float V7 = []() -> float {
0x0.01p0F);
}();
// CHECK: @V7 = {{.*}} float 1.00e+00
+
+template struct L {
+ constexpr L() : value(V) {}
+ float value;
+};
+
+#pragma STDC FENV_ROUND FE_DOWNWARD
spavloff wrote:
In this snippet `Val
@@ -79,3 +79,16 @@ float V7 = []() -> float {
0x0.01p0F);
}();
// CHECK: @V7 = {{.*}} float 1.00e+00
+
+template struct L {
+ constexpr L() : value(V) {}
+ float value;
+};
+
+#pragma STDC FENV_ROUND FE_DOWNWARD
erichkeane wrote:
Ah, I see that git
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/90877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldrumm wrote:
> There are a bunch of tests that fail if you don't.
Yes. Even better than that: this patch just uncovered a [legitimate bug in the
C++ AST parser tests for clang
> Our instructions tell people they need to disable autocrlf
I didn't see that. Shall I remove that instruction now,
https://github.com/spavloff updated
https://github.com/llvm/llvm-project/pull/90877
>From 5d906b537636ca0d8706a8a888dd78edfbec684f Mon Sep 17 00:00:00 2001
From: Serge Pavlov
Date: Thu, 2 May 2024 22:28:05 +0700
Subject: [PATCH 1/5] [clang] Use constant rounding mode for floating literals
Conv
vitalybuka wrote:
> Looks broken
> https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/9/logs/stdio
This is special build from this PR see `git status` here
https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/6/logs/stdio
https://github.com/llvm/llvm-project/pull/90935
pogo59 wrote:
@mstorsjo On reflection I agree that a build-time choice for handling this is
not appropriate. It really wants to be target-based. Latest version (a) falls
back to old style for Windows/PS as well as AIX, (b) adds a driver option to
influence that default.
@MaskRay @tru @nico PT
https://github.com/NagyDonat created
https://github.com/llvm/llvm-project/pull/90974
This commit explicitly specifies the matching mode (C library function, any
non-method function, or C++ method) for the `CallDescription`s constructed in
various checkers.
Some code was simplified to use `Cal
https://github.com/vitalybuka requested changes to this pull request.
Looks broken
https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/9/logs/stdio
https://github.com/llvm/llvm-project/pull/90935
___
cfe-commits mailing list
cfe-commits@list
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/89775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -330,8 +330,12 @@ namespace {
class PPC32_SVR4_ABIInfo : public DefaultABIInfo {
bool IsSoftFloatABI;
bool IsRetSmallStructInRegABI;
+ // Size of GPR in bits.
+ static const unsigned RegLen = 32;
diggerlin wrote:
suggest change RegLen to GPRBits as
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/89019
>From 89a5bbcc89c1e43ac7f2e60f3c234c2c42928c86 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Wed, 17 Apr 2024 12:24:56 +0800
Subject: [PATCH 1/7] [clang] Distinguish unresolved templates in
UnresolvedLookupE
https://github.com/michaelmaitland updated
https://github.com/llvm/llvm-project/pull/89019
>From 89a5bbcc89c1e43ac7f2e60f3c234c2c42928c86 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Wed, 17 Apr 2024 12:24:56 +0800
Subject: [PATCH 1/7] [clang] Distinguish unresolved templates in
Unresolve
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/89019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mjklemm wrote:
> and for addressing my comments
More than happy to! Still learning how to be a proper Flang developer, so I'm
thankful for all the comments!
https://github.com/llvm/llvm-project/pull/90886
___
cfe-commits mailing list
cfe-commits@lis
@@ -79,3 +79,16 @@ float V7 = []() -> float {
0x0.01p0F);
}();
// CHECK: @V7 = {{.*}} float 1.00e+00
+
+template struct L {
+ constexpr L() : value(V) {}
+ float value;
+};
+
+#pragma STDC FENV_ROUND FE_DOWNWARD
erichkeane wrote:
I meant something
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -std=c++20 -emit-module-interface %s -triple
x86_64-linux-gnu -DTEST=1 -verify
+// RUN: %clang_cc1 -std=c++20 -emit-module-interface %s -triple
x86_64-linux-gnu -DTEST=2 -verify
+
+module;
+export module x;
+#include "version.h"
+#if TEST ==
https://github.com/spavloff updated
https://github.com/llvm/llvm-project/pull/90877
>From 5d906b537636ca0d8706a8a888dd78edfbec684f Mon Sep 17 00:00:00 2001
From: Serge Pavlov
Date: Thu, 2 May 2024 22:28:05 +0700
Subject: [PATCH 1/4] [clang] Use constant rounding mode for floating literals
Conv
https://github.com/banach-space approved this pull request.
LGTM, thanks for working on this and for addressing my comments 🙏🏻
https://github.com/llvm/llvm-project/pull/90886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
yronglin wrote:
> My reading is that
>
> ```c++
> #define SOME_MACRO
> module foo SOME_MACRO;
> ```
>
> SOME_MACRO is expanded
If this is the case, the current processing in the
`Preprocessor::LexAfterModuleDecl` function is incorrect. The implementation in
this PR treats the tokens between
zyn0217 wrote:
> This is introducing a new type that has a pretty subtle difference vs others.
> Can we have some documentation in the internals manual explaining the
> difference?
>
> Code wise, I think this looks fine.
Yeah, I added some explanation to the document of `UnresolvedLookupExpr`
@@ -0,0 +1,8 @@
+! REQUIRES: system-windows
+!
+! RUN: %clang --driver-mode=flang -### %s -Ltest 2>&1 | FileCheck %s
banach-space wrote:
[nit] `test` -> `random_test_dir` or something else that will make this stand
out a bit more (makes parsing tests a bit easie
@@ -0,0 +1,8 @@
+! REQUIRES: system-windows
+!
+! RUN: %clang --driver-mode=flang -### %s -Ltest 2>&1 | FileCheck %s
+!
+! Test that user provided paths come before the Flang runtimes and compiler-rt
+! CHECK: "-libpath:test"
banach-space wrote:
Wondering how to
https://github.com/banach-space approved this pull request.
LGTM, thanks!
I've left some nits, feel free to ignore
https://github.com/llvm/llvm-project/pull/90758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/banach-space edited
https://github.com/llvm/llvm-project/pull/90758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/89019
>From 89a5bbcc89c1e43ac7f2e60f3c234c2c42928c86 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Wed, 17 Apr 2024 12:24:56 +0800
Subject: [PATCH 1/6] [clang] Distinguish unresolved templates in
UnresolvedLookupE
Author: erichkeane
Date: 2024-05-03T07:51:25-07:00
New Revision: 01e91a2dde497b71b0b85d5ec0f101a21e9c892c
URL:
https://github.com/llvm/llvm-project/commit/01e91a2dde497b71b0b85d5ec0f101a21e9c892c
DIFF:
https://github.com/llvm/llvm-project/commit/01e91a2dde497b71b0b85d5ec0f101a21e9c892c.diff
LO
https://github.com/smithp35 approved this pull request.
LGTM, thanks for the confirmation.
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
@@ -13530,9 +13530,12 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr
*Init, bool DirectInit) {
}
if (VDecl->isInvalidDecl()) {
-CorrectDelayedTyposInExpr(Init, VDecl);
+ExprResult Res = CorrectDelayedTyposInExpr(Init, VDecl);
+std::vector SubExprs;
--
llvm-beanz wrote:
> I don't know if the pre-commit testing guarantees that. Configuration
> settings will permit the files to be checked out in either Unix (`\n`) or
> Windows (`\r\n`) line-endings.
Today on Windows you basically have to check out LLVM as unix line endings.
There are a bunch
soukatch wrote:
@AaronBallman would it be possible to get an approval while all the checks are
green? Thanks!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
yronglin wrote:
> I think the approach looks good.
>
> Do we have existing tests for the use of `module` as an identifier outside of
> a module declaration?
IIUC, do you mean something looks like the following? I didn't find it in the
test case:
```
void foo() {
int module = 0;
}
```
https
Author: erichkeane
Date: 2024-05-03T07:20:41-07:00
New Revision: 054f7c0565410f246f3e003ec18684bd526de64c
URL:
https://github.com/llvm/llvm-project/commit/054f7c0565410f246f3e003ec18684bd526de64c
DIFF:
https://github.com/llvm/llvm-project/commit/054f7c0565410f246f3e003ec18684bd526de64c.diff
LO
@@ -0,0 +1,52 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+// RUN: split-file %s %t
+
+// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/A.cppm -triple
x86_64-linux-gnu -verify
+// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/B.cppm -triple
x86_64-linux-gnu -verify
@@ -151,6 +151,11 @@ New checks
Enforces consistent style for enumerators' initialization, covering three
styles: none, first only, or all initialized explicitly.
+- New :doc:`readability-unnecessary-external-linkage
+ ` check.
+
+ Detects variable and function can be ma
@@ -0,0 +1,80 @@
+//===--- UnnecessaryExternalLinkageCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,80 @@
+//===--- UnnecessaryExternalLinkageCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,26 @@
+.. title:: clang-tidy - readability-unnecessary-external-linkage
+
+readability-unnecessary-external-linkage
+
+
+Detects variable and function can be marked as static.
+
+Static functions and variables are scoped to a sing
@@ -0,0 +1,80 @@
+//===--- UnnecessaryExternalLinkageCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86265
>From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 22 Mar 2024 17:34:08 +0800
Subject: [PATCH 1/6] [Sema] Preserve ContainsUnexpandedParameterPack in
TransformL
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/86265
>From 6e7b38b3e3f781e11db2fa5d552fdfb6123609df Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 22 Mar 2024 17:34:08 +0800
Subject: [PATCH 1/5] [Sema] Preserve ContainsUnexpandedParameterPack in
TransformL
@@ -0,0 +1,52 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+// RUN: split-file %s %t
+
+// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/A.cppm -triple
x86_64-linux-gnu -verify
+// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/B.cppm -triple
x86_64-linux-gnu -verify
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin commented:
I think the approach looks good.
Do we have existing tests for the use of `module` as an identifier outside of a
module declaration?
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
c
cor3ntin wrote:
> Dose this [note](https://eel.is/c++draft/cpp.module#note-1) have a conflict
> with P3034R1?
>
> ```
> [Note 1: Each identifier currently defined as a macro name is replaced by its
> replacement list of preprocessing tokens. — end note]
> ```
My reading is that
```cpp
#defin
https://github.com/chrisnc edited
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
Yup, working on it :)
https://github.com/llvm/llvm-project/pull/90500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/90500
>From 1b3476db3208ccb0b425ff604755349437d28863 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 25 Apr 2024 08:17:21 -0400
Subject: [PATCH 1/3] [Clang][Sema] Earlier type checking for builtin unar
https://github.com/erichkeane commented:
I'm still OK with this, but @shafik : Please ensure this has the test coverage
you asked for.
https://github.com/llvm/llvm-project/pull/90500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
chrisnc wrote:
@smithp35 thanks! Yes, I iterated on the specific direction here after the
feedback about not changing the behavior of `-mcpu=cortex-r52`, but the first
comment in the thread reflects the initial state, so I'll change that. I
believe the cortex-r82 is AArch64-only, and so is not
sdkrystian wrote:
@erichkeane Release note added
https://github.com/llvm/llvm-project/pull/90500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/90500
>From 1b3476db3208ccb0b425ff604755349437d28863 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 25 Apr 2024 08:17:21 -0400
Subject: [PATCH 1/3] [Clang][Sema] Earlier type checking for builtin unar
yronglin wrote:
Dose this [note](https://eel.is/c++draft/cpp.module#note-1) have a conflict
with P3034R1?
```
[Note 1: Each identifier currently defined as a macro name is replaced by its
replacement list of preprocessing tokens. — end note]
```
https://github.com/llvm/llvm-project/pull/90574
@@ -1056,6 +1083,25 @@ void CoroCloner::create() {
// Set up the new entry block.
replaceEntryBlock();
+ // Turn symmetric transfers into musttail calls.
+ for (CallInst *ResumeCall : Shape.SymmetricTransfers) {
+ResumeCall = cast(VMap[ResumeCall]);
+ResumeCall->
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2686,18 +2693,31 @@ bool Parser::ParseModuleName(
}
Diag(Tok, diag::err_module_expected_ident) << IsImport;
- SkipUntil(tok::semi);
+ SkipUntil(tok::semi, StopBeforeMatch);
return true;
}
-// Record this part of the module path.
-
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/90500
>From 1b3476db3208ccb0b425ff604755349437d28863 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 25 Apr 2024 08:17:21 -0400
Subject: [PATCH 1/2] [Clang][Sema] Earlier type checking for builtin unar
Author: erichkeane
Date: 2024-05-03T06:51:54-07:00
New Revision: bd909d2e6f2692685664c3f3b4db6047b2fb9441
URL:
https://github.com/llvm/llvm-project/commit/bd909d2e6f2692685664c3f3b4db6047b2fb9441
DIFF:
https://github.com/llvm/llvm-project/commit/bd909d2e6f2692685664c3f3b4db6047b2fb9441.diff
LO
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/90574
>From 1dcb4c3ac1efaf3a6a4317751e23089a6c8ccac1 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Tue, 30 Apr 2024 17:18:26 +0800
Subject: [PATCH 1/4] =?UTF-8?q?[Clang]=20Implement=20P3034R1=20Module=20De?=
=?UTF-8?
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/90574
>From 1dcb4c3ac1efaf3a6a4317751e23089a6c8ccac1 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Tue, 30 Apr 2024 17:18:26 +0800
Subject: [PATCH 1/4] =?UTF-8?q?[Clang]=20Implement=20P3034R1=20Module=20De?=
=?UTF-8?
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/90500
>From 1b3476db3208ccb0b425ff604755349437d28863 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 25 Apr 2024 08:17:21 -0400
Subject: [PATCH] [Clang][Sema] Earlier type checking for builtin unary
o
@@ -2803,7 +2803,207 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef,
TypeAliasTemplateDecl *AliasTemplate) {
return {Template, AliasRhsTemplateArgs};
}
-// Build deduction guides for a type alias template.
+// Build deduction guides for a type alias template from the given unde
201 - 300 of 395 matches
Mail list logo