https://github.com/DanielKristofKiss approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
This is introducing a new type that has a pretty subtle difference vs others.
Can we have some documentation in the internals manual explaining the
difference?
Code wise, I think this looks fine.
https://github.com/llvm/llvm-project/pull/89019
___
Author: erichkeane
Date: 2024-05-03T06:33:35-07:00
New Revision: a13c5140a2a26923f3e7bf3684409425ff54de6f
URL:
https://github.com/llvm/llvm-project/commit/a13c5140a2a26923f3e7bf3684409425ff54de6f
DIFF:
https://github.com/llvm/llvm-project/commit/a13c5140a2a26923f3e7bf3684409425ff54de6f.diff
LO
zyn0217 wrote:
@cor3ntin @erichkeane Any chance we can move forward with this review? I
appreciate your feedback!
https://github.com/llvm/llvm-project/pull/89019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/DavidTruby updated
https://github.com/llvm/llvm-project/pull/90758
>From 0afdbb7dac3a3a051661d5747c8c6470a13f1e0c Mon Sep 17 00:00:00 2001
From: David Truby
Date: Wed, 1 May 2024 19:41:47 +0100
Subject: [PATCH 1/2] [clang][flang][windows] Prefer user-provided library
paths (
Author: Hans Wennborg
Date: 2024-05-03T15:09:58+02:00
New Revision: 9c8b0d4ef6308ca0a74151c14c01f972e8db8cda
URL:
https://github.com/llvm/llvm-project/commit/9c8b0d4ef6308ca0a74151c14c01f972e8db8cda
DIFF:
https://github.com/llvm/llvm-project/commit/9c8b0d4ef6308ca0a74151c14c01f972e8db8cda.diff
@@ -0,0 +1,55 @@
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm
-disable-llvm-passes -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -fmath-errno -ffp-contract=on
@@ -0,0 +1,55 @@
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm
-disable-llvm-passes -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -fmath-errno -ffp-contract=on
@@ -0,0 +1,55 @@
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm
-disable-llvm-passes -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -fmath-errno -ffp-contract=on
https://github.com/erichkeane approved this pull request.
I think I'm ok with this, please give others a day or two to sign off as well.
https://github.com/llvm/llvm-project/pull/90894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: None (whisperity)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90965.diff
5 Files Affected:
- (modified)
clang-tools-extra/docs/clang-tidy/checks/bugprone/bad-signal-to-kill-thread.rst
(+2)
- (modified)
cla
https://github.com/whisperity created
https://github.com/llvm/llvm-project/pull/90965
None
>From 9cbd497b178a4a652f1666bca737e8ab9d2cbd00 Mon Sep 17 00:00:00 2001
From: Whisperity
Date: Fri, 3 May 2024 14:47:29 +0200
Subject: [PATCH] [clang-tidy][NFC] Document CERT rule coverage and aliases fo
@@ -2686,18 +2693,31 @@ bool Parser::ParseModuleName(
}
Diag(Tok, diag::err_module_expected_ident) << IsImport;
- SkipUntil(tok::semi);
+ SkipUntil(tok::semi, StopBeforeMatch);
return true;
}
-// Record this part of the module path.
-
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/90066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cor3ntin
Date: 2024-05-03T14:10:54+02:00
New Revision: 642117105d4f7944b7944f9b2a6ba9993fb68ed9
URL:
https://github.com/llvm/llvm-project/commit/642117105d4f7944b7944f9b2a6ba9993fb68ed9
DIFF:
https://github.com/llvm/llvm-project/commit/642117105d4f7944b7944f9b2a6ba9993fb68ed9.diff
LOG:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 10aab63c9cb49d3ddfbe2cf8992de433efeef6f1
0b472f255ca8f9279e58f25e2350cd0eb31baad7 --
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/90574
>From 1dcb4c3ac1efaf3a6a4317751e23089a6c8ccac1 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Tue, 30 Apr 2024 17:18:26 +0800
Subject: [PATCH 1/3] =?UTF-8?q?[Clang]=20Implement=20P3034R1=20Module=20De?=
=?UTF-8?
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/90574
>From 1dcb4c3ac1efaf3a6a4317751e23089a6c8ccac1 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Tue, 30 Apr 2024 17:18:26 +0800
Subject: [PATCH 1/2] =?UTF-8?q?[Clang]=20Implement=20P3034R1=20Module=20De?=
=?UTF-8?
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/90898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sebastiankreutzer wrote:
Can't reproduce the buildbot failures, will try to find the cause.
https://github.com/llvm/llvm-project/pull/90959
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
@@ -275,6 +275,13 @@ Response HandleFunction(Sema &SemaRef, const FunctionDecl
*Function,
TemplateArgs->asArray(),
/*Final=*/false);
+if (RelativeToPrimary &&
+(Function->getTemplateSpeciali
llvmbot wrote:
@llvm/pr-subscribers-xray
Author: Sebastian Kreutzer (sebastiankreutzer)
Changes
This PR introduces shared library (DSO) support for XRay based on a revised
version of the implementation outlined in [this
RFC](https://discourse.llvm.org/t/rfc-upstreaming-dso-instrumentatio
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/sebastiankreutzer created
https://github.com/llvm/llvm-project/pull/90959
This PR introduces shared library (DSO) support for XRay based on a revised
version of the implementation outlined in [this
RFC](https://discourse.llvm.org/t/rfc-upstreaming-dso-instrumentation-support
mjklemm wrote:
> Do you know the meaning for Classic Flang?
The way `-print-resource-dir` now works should be consistent with how Classic
Flang works. If that's not the right response, I guess I got my wires crossed
and you need to explain it to me. :-)
https://github.com/llvm/llvm-project/
@@ -5474,7 +5474,7 @@ def print_prog_name_EQ : Joined<["-", "--"],
"print-prog-name=">,
Visibility<[ClangOption, CLOption]>;
def print_resource_dir : Flag<["-", "--"], "print-resource-dir">,
HelpText<"Print the resource directory pathname">,
- Visibility<[ClangOption, CLO
https://github.com/mjklemm updated
https://github.com/llvm/llvm-project/pull/90886
>From 1a994159025f127f0f7d11da80b74035788d52c9 Mon Sep 17 00:00:00 2001
From: Michael Klemm
Date: Thu, 2 May 2024 14:50:45 +0200
Subject: [PATCH 1/7] Enable -print-resource-dir also for Flang
---
clang/include/
Author: Youngsuk Kim
Date: 2024-05-03T05:45:17-05:00
New Revision: 2933ef2da9103122a52066a1c680046d1bdacaed
URL:
https://github.com/llvm/llvm-project/commit/2933ef2da9103122a52066a1c680046d1bdacaed
DIFF:
https://github.com/llvm/llvm-project/commit/2933ef2da9103122a52066a1c680046d1bdacaed.diff
Author: Youngsuk Kim
Date: 2024-05-03T05:18:27-05:00
New Revision: 1efc1918502bd8c9cf2431af38d754878eac071a
URL:
https://github.com/llvm/llvm-project/commit/1efc1918502bd8c9cf2431af38d754878eac071a
DIFF:
https://github.com/llvm/llvm-project/commit/1efc1918502bd8c9cf2431af38d754878eac071a.diff
banach-space wrote:
> > How does this compare to GFortran and Classic Flang? Anything resembling
> > this flag?
>
> GFortran does not have it, but Classic Flang does. So, it's closing a gap to
> Classic Flang here as well.
Do you know the meaning for Classic Flang? Would be great to make "LLV
https://github.com/whisperity closed
https://github.com/llvm/llvm-project/pull/90868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: whisperity
Date: 2024-05-03T12:11:50+02:00
New Revision: 6086f694df10b57b75ed05494832f61e1e2ad59f
URL:
https://github.com/llvm/llvm-project/commit/6086f694df10b57b75ed05494832f61e1e2ad59f
DIFF:
https://github.com/llvm/llvm-project/commit/6086f694df10b57b75ed05494832f61e1e2ad59f.diff
LO
@@ -0,0 +1,3 @@
+! RUN: %flang -print-resource-dir -resource-dir=%S/Inputs/resource_dir \
+! RUN: | FileCheck -check-prefix=PRINT-RESOURCE-DIR
-DFILE=%S/Inputs/resource_dir %s
banach-space wrote:
> So, my feeling is that this refactoring should take place in a
Author: David Spickett
Date: 2024-05-03T09:56:23Z
New Revision: fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b
URL:
https://github.com/llvm/llvm-project/commit/fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b
DIFF:
https://github.com/llvm/llvm-project/commit/fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b.diff
LOG
@@ -5474,7 +5474,7 @@ def print_prog_name_EQ : Joined<["-", "--"],
"print-prog-name=">,
Visibility<[ClangOption, CLOption]>;
def print_resource_dir : Flag<["-", "--"], "print-resource-dir">,
HelpText<"Print the resource directory pathname">,
- Visibility<[ClangOption, CLO
@@ -275,6 +275,13 @@ Response HandleFunction(Sema &SemaRef, const FunctionDecl
*Function,
TemplateArgs->asArray(),
/*Final=*/false);
+if (RelativeToPrimary &&
+(Function->getTemplateSpeciali
smithp35 wrote:
Apologies I read the comments, rather than go through the code. It looks the
code has already made the v8-r imply a generic CPU.
So it looks like the code is doing what my proposal states so no objections
from me and apologies for the noise.
https://github.com/llvm/llvm-projec
https://github.com/RKSimon approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2803,7 +2803,207 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef,
TypeAliasTemplateDecl *AliasTemplate) {
return {Template, AliasRhsTemplateArgs};
}
-// Build deduction guides for a type alias template.
+// Build deduction guides for a type alias template from the given unde
smithp35 wrote:
I can chime in with an opinion but unfortunately I think it may be different to
everyone elses!
This is a bit of an awkward situation as I think we have to balance several
things:
* Consistency between v8-R and AArch32 (ARM) and AArch64 (more consistent the
better)
* Consisten
ilya-biryukov wrote:
Adding @kadircet to continue the review where Sam left off.
Unfortunately, Sam does not have the capacity to finish this review.
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -std=c++2a -verify -ast-dump -ast-dump-decl-types
-ast-dump-filter "deduction guide" %s | FileCheck %s --strict-whitespace
+// RUN: %clang_cc1 -std=c++2a -verify -ast-dump -ast-dump-decl-types
-Wno-c++11-narrowing -ast-dump-filter "deduction g
@@ -261,6 +261,13 @@ AG ag = {1};
// CHECK: | `-BuiltinType {{.*}} 'int'
// CHECK: `-ParmVarDecl {{.*}} 'int'
+template
+using BG = G;
+BG bg = {1.0};
+// CHECK-LABEL: Dumping
+// CHECK: FunctionTemplateDecl
hokein wrote:
It is not possible to use the `
@@ -2803,7 +2803,207 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef,
TypeAliasTemplateDecl *AliasTemplate) {
return {Template, AliasRhsTemplateArgs};
}
-// Build deduction guides for a type alias template.
+// Build deduction guides for a type alias template from the given unde
@@ -2803,7 +2803,207 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef,
TypeAliasTemplateDecl *AliasTemplate) {
return {Template, AliasRhsTemplateArgs};
}
-// Build deduction guides for a type alias template.
+// Build deduction guides for a type alias template from the given unde
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/90894
>From 40365147f7aabeaaefd7e9bf6f2b96d6f7135992 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 3 May 2024 10:53:54 +0200
Subject: [PATCH 1/2] Refactor: Extract the core deduction-guide construction
implement
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/90918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3479,13 +3479,24 @@ PathDiagnosticPieceRef
MallocBugVisitor::VisitNode(const ExplodedNode *N,
// original reference count is positive, we should not report use-after-frees
// on objects deleted in such destructors. This can probably be improved
// through better shar
https://github.com/steakhal commented:
Hah!
I've just debugged an identical case last week, wrt. llvm intrusive pointers,
which also used std::atomics inside for the refcount and lead to a Leak FP.
When I dag into the case, I realized that the root cause is that we can't track
the value of the
https://github.com/ostannard updated
https://github.com/llvm/llvm-project/pull/90832
>From b562b354a7bb955c3c46cd79753fd3d2d72d48fe Mon Sep 17 00:00:00 2001
From: Oliver Stannard
Date: Tue, 30 Apr 2024 11:40:18 +0100
Subject: [PATCH 1/3] [AArch64] Diagnose more functions when FP not enabled
Wh
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/70280
>From 95180e1765fea3ec6de822d0b9926056d0d12404 Mon Sep 17 00:00:00 2001
From: knightXun
Date: Thu, 26 Oct 2023 09:25:58 +0800
Subject: [PATCH 1/3] [clang][Sema] Resolving Panic Caused by Inconsistent
Arguments
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/70280
>From 95180e1765fea3ec6de822d0b9926056d0d12404 Mon Sep 17 00:00:00 2001
From: knightXun
Date: Thu, 26 Oct 2023 09:25:58 +0800
Subject: [PATCH 1/3] [clang][Sema] Resolving Panic Caused by Inconsistent
Arguments
github-actions[bot] wrote:
@zwuis Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build, y
https://github.com/Pierre-vh edited
https://github.com/llvm/llvm-project/pull/78572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/89713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: YanzuoLiu
Date: 2024-05-03T10:20:42+02:00
New Revision: 8480c93e36b33c237540e20c97cda8fb3d196f1f
URL:
https://github.com/llvm/llvm-project/commit/8480c93e36b33c237540e20c97cda8fb3d196f1f
DIFF:
https://github.com/llvm/llvm-project/commit/8480c93e36b33c237540e20c97cda8fb3d196f1f.diff
LOG
https://github.com/Pierre-vh edited
https://github.com/llvm/llvm-project/pull/78572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@rnk @sam-mccall Should we still merge this?
https://github.com/llvm/llvm-project/pull/82815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
This was fixed by https://github.com/llvm/llvm-project/pull/82310
https://github.com/llvm/llvm-project/pull/80802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/80802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davemgreen wrote:
Rust
(https://github.com/rust-lang/rust/blob/79734f1db8dbe322192dea32c0f6b80ab14c4c1d/compiler/rustc_codegen_llvm/src/llvm_util.rs#L229)
and zig
(https://github.com/ziglang/zig/blob/44db92d1ca90c9cfdfb29fe46f04ff8f11c80901/lib/std/Target/aarch64.zig#L43)
are two examples of
cor3ntin wrote:
Closing that as an alternative solution was committed
https://github.com/llvm/llvm-project/pull/67089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/67089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haojian Wu (hokein)
Changes
With the commit d5308949cf884d8e4b971d51a8b4f73584c4adec, we now preserve the
initializer for invalid decls with the recovery-expr.
However there is a chance that the original init expr is a typo-expr, we shoul
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Haojian Wu (hokein)
Changes
With the commit d5308949cf884d8e4b971d51a8b4f73584c4adec, we now preserve the
initializer for invalid decls with the recovery-expr.
However there is a chance that the original init expr is a typo-ex
cor3ntin wrote:
I think we should apply @ChuanqiXu9 suggestion and merge that without tests. At
worse it's harmless, at best it solves an actual issue for users. We have
precedent for not being able to test resource exhaustion fixes.
https://github.com/llvm/llvm-project/pull/79875
___
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/90948
With the commit d5308949cf884d8e4b971d51a8b4f73584c4adec, we now preserve the
initializer for invalid decls with the recovery-expr.
However there is a chance that the original init expr is a typo-expr, we should
cor3ntin wrote:
@MaskRay @zmodem Can we close this?
https://github.com/llvm/llvm-project/pull/67084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/67900
>From b5e64ac8d36fef66cb8ef698f74997616d2957bc Mon Sep 17 00:00:00 2001
From: David Stone
Date: Sat, 30 Sep 2023 22:57:34 -0600
Subject: [PATCH 1/2] [clang][Modules] Make `Module::Requirement` a struct
`Module:
jthackray wrote:
> The command-line names or FEAT_ names should probably be what we are aiming
> for if we are changing them one-way or the other.
Yes, standardising on FEAT_* names would be good to match the TRM, so we avoid
the
AEK_PREDRES/FEAT_SPECRES, AEK_PERFMON/FEAT_PMUv3, etc. mismatche
https://github.com/luolent updated
https://github.com/llvm/llvm-project/pull/90391
>From 54c6c6b7d71f5ff293412f5f91e9f880480284f8 Mon Sep 17 00:00:00 2001
From: luolent
Date: Sat, 27 Apr 2024 22:17:58 +0300
Subject: [PATCH] llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3804: lacking
() for cl
davemgreen wrote:
@tmatheson-arm reached out and we have a bit of a conversation internally. I do
think that there is too much going on in this one pr to be sensible to review,
but from what I've looked at my main points I think are:
- Some AEK names get renamed in ways I would not expect them
https://github.com/mjklemm updated
https://github.com/llvm/llvm-project/pull/90886
>From 1a994159025f127f0f7d11da80b74035788d52c9 Mon Sep 17 00:00:00 2001
From: Michael Klemm
Date: Thu, 2 May 2024 14:50:45 +0200
Subject: [PATCH 1/6] Enable -print-resource-dir also for Flang
---
clang/include/
@@ -5474,7 +5474,7 @@ def print_prog_name_EQ : Joined<["-", "--"],
"print-prog-name=">,
Visibility<[ClangOption, CLOption]>;
def print_resource_dir : Flag<["-", "--"], "print-resource-dir">,
HelpText<"Print the resource directory pathname">,
- Visibility<[ClangOption, CLO
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a370d57b9ff9e385e9a51bf6b1d366890f4091cd
1bb5ed2ebd9e1b40fe581b719181681f71f78fa2 --
https://github.com/mjklemm updated
https://github.com/llvm/llvm-project/pull/90886
>From 1a994159025f127f0f7d11da80b74035788d52c9 Mon Sep 17 00:00:00 2001
From: Michael Klemm
Date: Thu, 2 May 2024 14:50:45 +0200
Subject: [PATCH 1/5] Enable -print-resource-dir also for Flang
---
clang/include/
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/90830
>From ec7ddff8aedaa9d42796b5f952ff7ca77465dfd1 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 2 May 2024 15:44:45 +0800
Subject: [PATCH 1/4] [clang-tidy] new check readability-mark-static
Add new che
ssahasra wrote:
> Should we also rename the MMRA to `amdgpu-fence-as` (remove OpenCL from the
> name) ?
Even the "fence" prefix is not entirely correct. The same tags also make sense
on a load-acquire or store-release, which are "fence like" instructions, or
"operations with implicit fences".
@@ -2900,7 +2900,7 @@ defm clangir : BoolFOption<"clangir",
PosFlag,
NegFlag LLVM
pipeline to compile">,
BothFlags<[], [ClangOption, CC1Option], "">>;
-def emit_cir : Flag<["-"], "emit-cir">, Visibility<[CC1Option]>,
+def emit_cir : Flag<["-"], "emit-cir">, Visibility<[C
@@ -0,0 +1,3 @@
+! RUN: %flang -print-resource-dir -resource-dir=%S/Inputs/resource_dir \
+! RUN: | FileCheck -check-prefix=PRINT-RESOURCE-DIR
-DFILE=%S/Inputs/resource_dir %s
mjklemm wrote:
I'll make the variable a bit clearer in the next update. That's a goo
@@ -0,0 +1,5 @@
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s |
FileCheck %s
+
+// CHECK: CIRGenModule::buildTopLevelDecl
+
+void foo() {}
lanza wrote:
Kind of a shitty test, but actually having something testable triples the size
@@ -4408,6 +4409,54 @@ Target-Specific Extensions
Clang supports some language features conditionally on some targets.
+AMDGPU Language Extensions
+--
+
+__builtin_amdgcn_fence
+^^
+
+``__builtin_amdgcn_fence`` emits a fence for all
@@ -0,0 +1,3 @@
+! RUN: %flang -print-resource-dir -resource-dir=%S/Inputs/resource_dir \
+! RUN: | FileCheck -check-prefix=PRINT-RESOURCE-DIR
-DFILE=%S/Inputs/resource_dir %s
+! PRINT-RESOURCE-DIR: [[FILE]]
mjklemm wrote:
It does not. The `/Inputs/resource_di
@@ -18365,6 +18366,30 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned
BuiltinID,
return nullptr;
}
+void CodeGenFunction::AddAMDGCNAddressSpaceMMRA(llvm::Instruction *Inst,
+const CallExpr *E,
+
@@ -18365,6 +18366,30 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned
BuiltinID,
return nullptr;
}
+void CodeGenFunction::AddAMDGCNAddressSpaceMMRA(llvm::Instruction *Inst,
+const CallExpr *E,
+
https://github.com/lanza updated https://github.com/llvm/llvm-project/pull/90831
>From e57548737a72c5308e23fb442774b9bd9eca0bfa Mon Sep 17 00:00:00 2001
From: Nathan Lanza
Date: Thu, 2 May 2024 07:55:36 +
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8?q
mjklemm wrote:
> How does this compare to GFortran and Classic Flang? Anything resembling this
> flag?
GFortran does not have it, but Classic Flang does. So, it's closing a gap to
Classic Flang here as well.
https://github.com/llvm/llvm-project/pull/90886
@@ -0,0 +1,42 @@
+//===--- CIRGenModule.h - Per-Module state for CIR gen --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,28 @@
+//===--- CIRGenTypeCache.h - Commonly used LLVM types and info -*- C++
--*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/lanza updated https://github.com/llvm/llvm-project/pull/90831
>From e57548737a72c5308e23fb442774b9bd9eca0bfa Mon Sep 17 00:00:00 2001
From: Nathan Lanza
Date: Thu, 2 May 2024 07:55:36 +
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF-8?q
@@ -5474,7 +5474,7 @@ def print_prog_name_EQ : Joined<["-", "--"],
"print-prog-name=">,
Visibility<[ClangOption, CLOption]>;
def print_resource_dir : Flag<["-", "--"], "print-resource-dir">,
HelpText<"Print the resource directory pathname">,
- Visibility<[ClangOption, CLO
@@ -0,0 +1,3 @@
+! RUN: %flang -print-resource-dir -resource-dir=%S/Inputs/resource_dir \
+! RUN: | FileCheck -check-prefix=PRINT-RESOURCE-DIR
-DFILE=%S/Inputs/resource_dir %s
+! PRINT-RESOURCE-DIR: [[FILE]]
banach-space wrote:
I have a suspicion that this woul
@@ -0,0 +1,3 @@
+! RUN: %flang -print-resource-dir -resource-dir=%S/Inputs/resource_dir \
+! RUN: | FileCheck -check-prefix=PRINT-RESOURCE-DIR
-DFILE=%S/Inputs/resource_dir %s
banach-space wrote:
You should be able to avoid repeating "%S/Inputs/resource_dir" if
@@ -250,6 +247,25 @@ void Driver::setDriverMode(StringRef Value) {
Diag(diag::err_drv_unsupported_option_argument) << OptName << Value;
}
+void Driver::setResourceDirectory() {
+ // Compute the path to the resource directory, depending on the driver mode.
+ switch (Mode)
banach-space wrote:
> > What's the definition of "resource dir" for Fortran?
>
> I'd like to at least have it point to where the MODULE files live.
>
> When I look at what clang emits, then Flang's resource directory should
> rather point to the place, where Flang has its `lib` and `include`
301 - 395 of 395 matches
Mail list logo
