[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/91007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

@@ -0,0 +1,88 @@ +//===--- CIRGenAction.cpp - LLVM Code generation Frontend Action -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

@@ -0,0 +1,59 @@ +//===- CIRGenerator.h - CIR Generation from Clang AST -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

@@ -0,0 +1,61 @@ +//=== CIRGenAction.h - CIR Code Generation Frontend Action -*- C++ -*--===// ChuanqiXu9 wrote: Should we move this header to `CIR` or `FrontendAction`? Currently it lives in `CIRFrontendAction` but its implementation file lives in

[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

@@ -42,6 +47,14 @@ CreateFrontendBaseAction(CompilerInstance ) { StringRef Action("unknown"); (void)Action; + auto UseCIR = CI.getFrontendOpts().UseClangIRPipeline; + auto Act = CI.getFrontendOpts().ProgramAction; + auto EmitsCIR = Act == EmitCIR; + + if (!UseCIR &&

[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

@@ -0,0 +1,88 @@ +//===--- CIRGenAction.cpp - LLVM Code generation Frontend Action -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/91007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

https://github.com/ChuanqiXu9 commented: BTW, it will be helpful to create subscribing team to help people to get informed in time. (I just saw the patch accidently.) https://github.com/llvm/llvm-project/pull/91007 ___ cfe-commits mailing list

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

MaskRay wrote: > > @MaskRay Got it. > > The problem with that solution is that if you use --target you won't get > > the correct arch. This would be a problem for any cross compilation. For > > example, say you cross compile from zLinux (which wouldn't have the config > > file), the arch

[clang] [clang/www/get_started.html] Use newer `cmake` syntax (PR #93503)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Samuel Marks (SamuelMarks) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/93503.diff 1 Files Affected: - (modified) clang/www/get_started.html (+8-8) ``diff diff --git a/clang/www/get_started.html

[clang] [clang/www/get_started.html] Use newer `cmake` syntax (PR #93503)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [clang/www/get_started.html] Use newer `cmake` syntax (PR #93503)

https://github.com/SamuelMarks created https://github.com/llvm/llvm-project/pull/93503 None >From bcdc355e9585e35f128a1b3ec71655d47bbf6986 Mon Sep 17 00:00:00 2001 From: Samuel Marks <807580+samuelma...@users.noreply.github.com> Date: Tue, 28 May 2024 00:49:37 -0400 Subject: [PATCH]

[clang] cc1: Report an error for multiple actions unless separated by -main-file-name (PR #91140)

MaskRay wrote: > I don't really understand the rationale for this, and it's kind of annoying. > Most of the compiler's flags behave in the "last one wins" fashion (such as > `-O2` and `-O0`) and it's always been convenient to add the flag you want at > the end. Why treat action flags any

[clang-tools-extra] 988cee7 - [unittest] Fix target triple

Author: Fangrui Song Date: 2024-05-27T20:29:52-07:00 New Revision: 988cee7f96d6ba56dd465b9b2f3cfade3b6e2a3f URL: https://github.com/llvm/llvm-project/commit/988cee7f96d6ba56dd465b9b2f3cfade3b6e2a3f DIFF: https://github.com/llvm/llvm-project/commit/988cee7f96d6ba56dd465b9b2f3cfade3b6e2a3f.diff

[clang] [llvm] pull (PR #93500)

https://github.com/cratelschen closed https://github.com/llvm/llvm-project/pull/93500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] pull (PR #93500)

https://github.com/cratelschen converted_to_draft https://github.com/llvm/llvm-project/pull/93500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] pull (PR #93500)

llvmbot wrote: @llvm/pr-subscribers-llvm-support @llvm/pr-subscribers-clang Author: cratelschen (cratelschen) Changes --- Patch is 34.00 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/93500.diff 7 Files Affected: - (modified)

[clang] [llvm] pull (PR #93500)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [llvm] pull (PR #93500)

https://github.com/cratelschen created https://github.com/llvm/llvm-project/pull/93500 None >From 421aa0371f834b6ebfad204c85f65695f8de2ae7 Mon Sep 17 00:00:00 2001 From: CratelsChen Date: Wed, 10 Apr 2024 19:54:19 +0800 Subject: [PATCH 1/6] =?UTF-8?q?=E6=96=B0=E5=A2=9E=20kickoff=20=E6=96=87?=

[clang] [CodeGen] Hidden visibility for prof version var (PR #93496)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (gulfemsavrun) Changes This patch adds hidden visibility to the variable that is used by the single byte counters mode in source-based code coverage. --- Full diff: https://github.com/llvm/llvm-project/pull/93496.diff 1

[clang] [CodeGen] Hidden visibility for prof version var (PR #93496)

https://github.com/gulfemsavrun created https://github.com/llvm/llvm-project/pull/93496 This patch adds hidden visibility to the variable that is used by the single byte counters mode in source-based code coverage. >From 1e0625be05a30118eeadd1d65df675da4cddc313 Mon Sep 17 00:00:00 2001 From:

[clang] a4f75ec - [C++20] [Modules] Don't record implicitly declarations to BMI by default (#93459)

Author: Chuanqi Xu Date: 2024-05-28T09:36:30+08:00 New Revision: a4f75ec730ee573fc35a51264a907b1f05b53e3b URL: https://github.com/llvm/llvm-project/commit/a4f75ec730ee573fc35a51264a907b1f05b53e3b DIFF: https://github.com/llvm/llvm-project/commit/a4f75ec730ee573fc35a51264a907b1f05b53e3b.diff

[clang] [C++20] [Modules] Don't record implicitly declarations to BMI by default (PR #93459)

https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/93459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Be const-correct with all uses of `Module *`. (PR #93493)

ChuanqiXu9 wrote: > > Can you make sure that at every place this PR touches `const` makes sense? > > I found out recently that we can be quite good at pretending that something > > is `const`, all the way down until we realize we need a `const_cast`, > > because modification is required in

[clang] [clang-tools-extra] [libcxx] [clang][Modules] Remove unnecessary includes of `Module.h` (PR #93417)

@@ -159,7 +159,8 @@ class APINotesManager { ArrayRef getCurrentModuleReaders() const { bool HasPublic = CurrentModuleReaders[ReaderKind::Public]; bool HasPrivate = CurrentModuleReaders[ReaderKind::Private]; -assert((!HasPrivate || HasPublic) && "private module

[clang] [Clang][AArch64][ARM]: Fix Inefficient loads/stores of _BitInt(N) (PR #93495)

https://github.com/hassnaaHamdi updated https://github.com/llvm/llvm-project/pull/93495 >From 6b7cc14e5dcca7416c549bd156585e2a61d4d883 Mon Sep 17 00:00:00 2001 From: Hassnaa Hamdi Date: Tue, 28 May 2024 01:04:00 + Subject: [PATCH] [Clang][AArch64][ARM]: Fix Inefficient loads/stores of

[clang] [Clang][AArch64][ARM]: Fix Inefficient loads/stores of _BitInt(N) (PR #93495)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Hassnaa Hamdi (hassnaaHamdi) Changes - Update clang codegen for loads/stores to read/write the legal in-memory representation for _BitInt(N = 128) and _BitInt(N = 64). - AArch64: for _BitInt(N = 128) the machine type is the smallest

[clang] [Clang][AArch64][ARM]: Fix Inefficient loads/stores of _BitInt(N) (PR #93495)

llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-backend-arm Author: Hassnaa Hamdi (hassnaaHamdi) Changes - Update clang codegen for loads/stores to read/write the legal in-memory representation for _BitInt(N = 128) and _BitInt(N = 64). - AArch64: for _BitInt(N =

[clang] [Clang][AArch64][ARM]: Fix Inefficient loads/stores of _BitInt(N) (PR #93495)

https://github.com/hassnaaHamdi created https://github.com/llvm/llvm-project/pull/93495 - Update clang codegen for loads/stores to read/write the legal in-memory representation for _BitInt(N <= 128) and _BitInt(N <= 64). - AArch64: for _BitInt(N <= 128) the machine type is the smallest

[clang] [clang-format] Fix a bug in formatting goto labels in macros (PR #92494)

llvmbot wrote: /pull-request llvm/llvm-project#93494 https://github.com/llvm/llvm-project/pull/92494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in formatting goto labels in macros (PR #92494)

owenca wrote: /cherry-pick d89f20058b45e3836527e816af7ed7372e1d554d https://github.com/llvm/llvm-project/pull/92494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in formatting goto labels in macros (PR #92494)

https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/92494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Profile profraw generation for GPU instrumentation #76587 (PR #93365)

https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/93365 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/28] Add profiling functions to libomptarget

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

MaskRay wrote: #78065 for Hurd is a good example for clang testing. https://github.com/llvm/llvm-project/pull/87845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Be const-correct with all uses of `Module *`. (PR #93493)

davidstone wrote: Yes. Is there anything else you want to see in this PR before it can be merged? (I don't have merge permissions). This is the type of PR likely to get lots of conflicts if it stays open for long, so I'd like to get it wrapped up as fast as possible.

[clang] 435ea21 - [Driver] Remove unneeded *-linux-gnu after D158183

Author: Fangrui Song Date: 2024-05-27T16:16:30-07:00 New Revision: 435ea21c897f94b5a3777a9f152e4c5bb4a371a3 URL: https://github.com/llvm/llvm-project/commit/435ea21c897f94b5a3777a9f152e4c5bb4a371a3 DIFF: https://github.com/llvm/llvm-project/commit/435ea21c897f94b5a3777a9f152e4c5bb4a371a3.diff

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

@@ -1,82 +0,0 @@ -#===--===## Endilll wrote: I decided to keep it intact out of caution, and asked on Discord instead whether this file is still needed.

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/93318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1de1ee9 - [clang][ci] Move libc++ testing into the main PR pipeline (#93318)

Author: Vlad Serebrennikov Date: 2024-05-28T02:25:15+04:00 New Revision: 1de1ee9cbabd641d50c5d2ac416392494b4ed30b URL: https://github.com/llvm/llvm-project/commit/1de1ee9cbabd641d50c5d2ac416392494b4ed30b DIFF:

[clang] [clang] Be const-correct with all uses of `Module *`. (PR #93493)

Endilll wrote: Sounds like you have a plan after this PR, which is good. I was worried that you're just applying `const` where it doesn't cause issues _today_. Such approach to const-correctness has been failing us (it leads to `const_cast`s down the usage chain).

[clang] dba2aa2 - [clang-format] Add LeftWithLastLine to AlignEscapedNewlines option (#93402)

Author: Owen Pan Date: 2024-05-27T15:20:58-07:00 New Revision: dba2aa265c5f2ef774c2812cf6ffdea8dd784e09 URL: https://github.com/llvm/llvm-project/commit/dba2aa265c5f2ef774c2812cf6ffdea8dd784e09 DIFF: https://github.com/llvm/llvm-project/commit/dba2aa265c5f2ef774c2812cf6ffdea8dd784e09.diff

[clang] [clang-format] Add LeftWithLastLine to AlignEscapedNewlines option (PR #93402)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/93402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Code implementing SpacesInParensOptions.ExceptDoubleParentheses logic (PR #93439)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/93439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Code implementing SpacesInParensOptions.ExceptDoubleParentheses logic (PR #93439)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/93439 >From ac03e1506b5ea0d00038501c4f41d5b30c8fa2b3 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 26 May 2024 22:01:48 -0700 Subject: [PATCH 1/2] Code implementing the

[clang] [clang] Be const-correct with all uses of `Module *`. (PR #93493)

davidstone wrote: > Can you make sure that at every place this PR touches `const` makes sense? I > found out recently that we can be quite good at pretending that something is > `const`, all the way down until we realize we need a `const_cast`, because > modification is required in that one

[clang] [clang] Be const-correct with all uses of `Module *`. (PR #93493)

davidstone wrote: > Can you make sure that at every place this PR touches `const` makes sense? I > found out recently that we can be quite good at pretending that something is > `const`, all the way down until we realize we need a `const_cast`, because > modification is required in that one

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

MaskRay wrote: > [llvm] Add triples for managarm I suggest that you split the patch into LLVM target triple part and a clang part. That's a convention to support new targets. https://github.com/llvm/llvm-project/pull/87845 ___ cfe-commits mailing

[clang] [clang] Be const-correct with all uses of `Module *`. (PR #93493)

Endilll wrote: Can you make sure that at every place this PR touches `const` makes sense? I found out recently that we can be quite good at pretending that something is `const`, all the way down until we realize we need a `const_cast`, because modification is required in that one place.

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/87845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

@@ -279,8 +280,10 @@ class Triple { Amplification, OpenCL, OpenHOS, +Kernel, +Mlibc, MaskRay wrote: I don't know how Mlibc is intended to be used but LLVM LTO warns about differing target triples.

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

@@ -279,8 +280,10 @@ class Triple { Amplification, OpenCL, OpenHOS, +Kernel, MaskRay wrote: Why is a generic term `Kernel` added? I am concerned that it would cause confusion to users of other OSes. Does your OS need a different target

[clang] Code implementing SpacesInParensOptions.ExceptDoubleParentheses logic (PR #93439)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/93439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Code implementing SpacesInParensOptions.ExceptDoubleParentheses logic (PR #93439)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/93439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

MaskRay wrote: Some older `ToolChain`s were probably contributed with a lot of `CmdArgs.push_back` uncovered by tests. They are not good examples to follow. For new `ToolChain`s, we ensure that all constructed `CmdArgs.push_back` are covered. This allows refactoring by someone who is

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

@@ -2562,7 +2566,10 @@ void Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes( static const char *const RISCV64LibDirs[] = {"/lib64", "/lib"}; static const char *const RISCV64Triples[] = {"riscv64-unknown-linux-gnu",

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

@@ -529,9 +530,379 @@ bool SystemZTargetCodeGenInfo::isVectorTypeBased(const Type *Ty, return false; } +//===--===// +// z/OS XPLINK ABI Implementation

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

@@ -529,9 +530,379 @@ bool SystemZTargetCodeGenInfo::isVectorTypeBased(const Type *Ty, return false; } +//===--===// +// z/OS XPLINK ABI Implementation

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

@@ -529,9 +530,379 @@ bool SystemZTargetCodeGenInfo::isVectorTypeBased(const Type *Ty, return false; } +//===--===// +// z/OS XPLINK ABI Implementation

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

https://github.com/redstar edited https://github.com/llvm/llvm-project/pull/91384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

@@ -529,9 +530,379 @@ bool SystemZTargetCodeGenInfo::isVectorTypeBased(const Type *Ty, return false; } +//===--===// +// z/OS XPLINK ABI Implementation

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

@@ -529,9 +530,379 @@ bool SystemZTargetCodeGenInfo::isVectorTypeBased(const Type *Ty, return false; } +//===--===// +// z/OS XPLINK ABI Implementation

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

https://github.com/redstar commented: Sorry, I left some more comments. In addition, there is no test involving a union. That is especially interesting for the complex-like structures. E.g. ``` union Float2 { float a; float b; }; struct Elem { float a; Float2 b; }; Elem calc(Elem);

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

@@ -529,9 +530,379 @@ bool SystemZTargetCodeGenInfo::isVectorTypeBased(const Type *Ty, return false; } +//===--===// +// z/OS XPLINK ABI Implementation

[clang] [clang] Be const-correct with all uses of `Module *`. (PR #93493)

llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: David Stone (davidstone) Changes --- Patch is 129.44 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/93493.diff 59 Files Affected: - (modified)

[clang] [clang] Be const-correct with all uses of `Module *`. (PR #93493)

llvmbot wrote: @llvm/pr-subscribers-clang Author: David Stone (davidstone) Changes --- Patch is 129.44 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/93493.diff 59 Files Affected: - (modified)

[clang] fix(91536): clang 18.1 parser crash (PR #93490)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #91536 --- Full diff: https://github.com/llvm/llvm-project/pull/93490.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) clang/lib/Sema/SemaExprCXX.cpp (+3-3) -

[clang] fix(91536): clang 18.1 parser crash (PR #93490)

https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/93490 Fixes #91536 >From a20c395f5d44f98363172216256c8ce61e96ffbe Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 27 May 2024 23:25:53 +0300 Subject: [PATCH] fix(91536): skip explicit 'this' check in

[clang] [clang] Macro for constant rounding mode (PR #92699)

efriedma-quic wrote: Oh, I somehow thought the macro was part of the spec; reading again, I guess it isn't, it's just an attempt to implement the spec. We probably want some feedback from libc implementers to check if this is what they want. I don't really want to end up in a situation where

[clang] [llvm] [mlir] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

@@ -368,7 +368,8 @@ CodeGenModule::CodeGenModule(ASTContext , IntTy = llvm::IntegerType::get(LLVMContext, C.getTargetInfo().getIntWidth()); IntPtrTy = llvm::IntegerType::get(LLVMContext, C.getTargetInfo().getMaxPointerWidth()); - Int8PtrTy =

[clang-tools-extra] [clangd] Add config option to allow detection of unused system headers (PR #87208)

vvd170501 wrote: Ping. @kadircet, can you merge this, please? Or are additional approvals required? https://github.com/llvm/llvm-project/pull/87208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Add LeftWithLastLine to AlignEscapedNewlines option (PR #93402)

https://github.com/HazardyKnusperkeks approved this pull request. Nice https://github.com/llvm/llvm-project/pull/93402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format]: Annotate colons found in inline assembly (PR #92617)

https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/92617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

@@ -803,6 +803,46 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState , bool DryRun, return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while, tok::kw_switch); }; + // Detecting functions is brittle. It would

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

@@ -803,6 +803,46 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState , bool DryRun, return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while, tok::kw_switch); }; + // Detecting functions is brittle. It would

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

@@ -6157,6 +6157,12 @@ bool TokenAnnotator::canBreakBefore(const AnnotatedLine , return !(Previous && (Previous->is(tok::kw_for) || Previous->isIf())); } + if (Left.isOneOf(tok::r_paren, TT_TrailingAnnotation) && HazardyKnusperkeks wrote: Is this

[clang] [llvm] [mlir] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/88182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

@@ -368,7 +368,8 @@ CodeGenModule::CodeGenModule(ASTContext , IntTy = llvm::IntegerType::get(LLVMContext, C.getTargetInfo().getIntWidth()); IntPtrTy = llvm::IntegerType::get(LLVMContext, C.getTargetInfo().getMaxPointerWidth()); - Int8PtrTy =

[clang] [clang] Macro for constant rounding mode (PR #92699)

jcranmer-intel wrote: Overall, I'm not opposed to this patch. This new macro should probably be mentioned somewhere in the clang user documentation. > The way this requirement is formulated indicates that it could be implemented > using preprocessor facility. Such implementation would

[clang] [llvm] [mlir] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

@@ -368,7 +368,8 @@ CodeGenModule::CodeGenModule(ASTContext , IntTy = llvm::IntegerType::get(LLVMContext, C.getTargetInfo().getIntWidth()); IntPtrTy = llvm::IntegerType::get(LLVMContext, C.getTargetInfo().getMaxPointerWidth()); - Int8PtrTy =

[clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

gulfemsavrun wrote: Ok, thanks for your analysis @aaronmondal! https://github.com/llvm/llvm-project/pull/92865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

@@ -7525,25 +7525,21 @@ static Attr *getCCTypeAttr(ASTContext , ParsedAttr ) { std::optional Sema::ActOnEffectExpression(Expr *CondExpr, StringRef AttributeName) { - auto BadExpr = [&]() { -Diag(CondExpr->getExprLoc(), diag::err_attribute_argument_type) -<< ("'"

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

@@ -1,82 +0,0 @@ -#===--===## ldionne wrote: `clang/utils/ci/run-buildbot` can be removed too, I think. https://github.com/llvm/llvm-project/pull/93318

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

@@ -54,3 +54,68 @@ cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \ echo "--- ninja" # Targets are not escaped as they are passed as separate arguments. ninja -C "${BUILD_DIR}" -k 0 ${targets} + ldionne wrote: It seems that we disagree on the approach

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

@@ -7525,25 +7525,21 @@ static Attr *getCCTypeAttr(ASTContext , ParsedAttr ) { std::optional Sema::ActOnEffectExpression(Expr *CondExpr, StringRef AttributeName) { - auto BadExpr = [&]() { -Diag(CondExpr->getExprLoc(), diag::err_attribute_argument_type) -<< ("'"

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

@@ -7525,25 +7525,21 @@ static Attr *getCCTypeAttr(ASTContext , ParsedAttr ) { std::optional Sema::ActOnEffectExpression(Expr *CondExpr, StringRef AttributeName) { - auto BadExpr = [&]() { -Diag(CondExpr->getExprLoc(), diag::err_attribute_argument_type) -<< ("'"

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

@@ -7525,25 +7525,21 @@ static Attr *getCCTypeAttr(ASTContext , ParsedAttr ) { std::optional Sema::ActOnEffectExpression(Expr *CondExpr, StringRef AttributeName) { - auto BadExpr = [&]() { -Diag(CondExpr->getExprLoc(), diag::err_attribute_argument_type) -<< ("'"

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

@@ -7525,25 +7525,21 @@ static Attr *getCCTypeAttr(ASTContext , ParsedAttr ) { std::optional Sema::ActOnEffectExpression(Expr *CondExpr, StringRef AttributeName) { - auto BadExpr = [&]() { -Diag(CondExpr->getExprLoc(), diag::err_attribute_argument_type) -<< ("'"

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

dougsonos wrote: > @dougsonos Just merged a pr that diagnoses unexpanded parameter packs when an > attribute is parsed, so could you double-check if that call to > `DiagnoseUnexpandedParameterPack` is still necessary? I just re-merged main to the branch and verified that the call to

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Profile profraw generation for GPU instrumentation #76587 (PR #93365)

https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/93365 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/27] Add profiling functions to libomptarget

[clang] [Clang] Static and explicit object member functions with the same parameter-type-lists (PR #93430)

@@ -7636,7 +7651,16 @@ Sema::AddMethodCandidate(CXXMethodDecl *Method, DeclAccessPair FoundDecl, // exist for each argument an implicit conversion sequence // (13.3.3.1) that converts that argument to the corresponding // parameter of F. - QualType

[clang] [Clang] Static and explicit object member functions with the same parameter-type-lists (PR #93430)

@@ -16333,7 +16387,7 @@ ExprResult Sema::FixOverloadedFunctionReference(Expr *E, DeclAccessPair Found, assert(UnOp->getOpcode() == UO_AddrOf && "Can only take the address of an overloaded function"); if (CXXMethodDecl *Method = dyn_cast(Fn)) { - if

[clang] [Clang] Static and explicit object member functions with the same parameter-type-lists (PR #93430)

@@ -209,6 +209,9 @@ C++23 Feature Support - Added a ``__reference_converts_from_temporary`` builtin, completing the necessary compiler support for `P2255R2: Type trait to determine if a reference binds to a temporary `_. +- Implemented `P2797R0:

[clang] [Clang] Static and explicit object member functions with the same parameter-type-lists (PR #93430)

@@ -5834,9 +5852,12 @@ Sema::ConvertArgumentsForCall(CallExpr *Call, Expr *Fn, // C99 6.5.2.2p7 - the arguments are implicitly converted, as if by // assignment, to the types of the corresponding parameter, ... + + bool AddressOf =

[clang] [Clang] Static and explicit object member functions with the same parameter-type-lists (PR #93430)

@@ -5813,6 +5813,24 @@ static TypoCorrection TryTypoCorrectionForCall(Sema , Expr *Fn, return TypoCorrection(); } +static bool isParenthetizedAndQualifiedAddressOfExpr(Expr *Fn) { + if (!isa(Fn)) +return false; + + Fn = Fn->IgnoreParens(); + auto *UO = dyn_cast(Fn);

[clang] [Clang] Static and explicit object member functions with the same parameter-type-lists (PR #93430)

https://github.com/Sirraide commented: Just a few minor things I noticed https://github.com/llvm/llvm-project/pull/93430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Static and explicit object member functions with the same parameter-type-lists (PR #93430)

https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/93430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Update identifier-length.rst (PR #93467)

https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/93467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [clang][Modules] Remove unnecessary includes of `Module.h` (PR #93417)

@@ -42,7 +41,11 @@ #include #include -namespace clang::clangd { +namespace clang { + +class Module; davidstone wrote: Specifically I'm following the guidance at: https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible

[clang] [clang-tools-extra] [libcxx] [clang][Modules] Remove unnecessary includes of `Module.h` (PR #93417)

@@ -42,7 +41,11 @@ #include #include -namespace clang::clangd { +namespace clang { + +class Module; davidstone wrote: Is that a clangd preference or llvm-wide? I see a lot of forward declarations in other parts of the code so I want to understand when I

[clang] [clang-tools-extra] [libcxx] [clang][Modules] Remove unnecessary includes of `Module.h` (PR #93417)

@@ -159,7 +159,8 @@ class APINotesManager { ArrayRef getCurrentModuleReaders() const { bool HasPublic = CurrentModuleReaders[ReaderKind::Public]; bool HasPrivate = CurrentModuleReaders[ReaderKind::Private]; -assert((!HasPrivate || HasPublic) && "private module

  1   2   3   >