necto wrote:
> Uh that FN seems really bad. Have you measured this change? Can we relax the
> canonicalization to only unwrap base class regions, or only apply to classes
> within the stdlib?
relaxed in 744272e
https://github.com/llvm/llvm-project/pull/106240
_
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/105648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Arseniy Zaostrovnykh
Date: 2024-08-28T08:36:59+02:00
New Revision: 190449a5d2a9ddfc2180dce11714a4443f0f29f0
URL:
https://github.com/llvm/llvm-project/commit/190449a5d2a9ddfc2180dce11714a4443f0f29f0
DIFF:
https://github.com/llvm/llvm-project/commit/190449a5d2a9ddfc2180dce11714a4443f0f29f
https://github.com/necto updated
https://github.com/llvm/llvm-project/pull/106240
>From 0c86e46516466f9513652a04ba87aa2a018ff6b8 Mon Sep 17 00:00:00 2001
From: Arseniy Zaostrovnykh
Date: Tue, 27 Aug 2024 17:52:25 +0200
Subject: [PATCH 1/3] [analyzer] Fix false positive for mutexes inheriting
m
https://github.com/steakhal requested changes to this pull request.
Uh that FN seems really bad. Have you measured this change?
Can we relax the canonicalization to only unwrap base class regions, or only
apply to classes within the stdlib?
https://github.com/llvm/llvm-project/pull/106240
_
https://github.com/necto updated
https://github.com/llvm/llvm-project/pull/106240
>From 0c86e46516466f9513652a04ba87aa2a018ff6b8 Mon Sep 17 00:00:00 2001
From: Arseniy Zaostrovnykh
Date: Tue, 27 Aug 2024 17:52:25 +0200
Subject: [PATCH 1/2] [analyzer] Fix false positive for mutexes inheriting
m
pirama-arumuga-nainar wrote:
FYI, this PR causes https://github.com/llvm/llvm-project/issues/105569.
https://github.com/llvm/llvm-project/pull/99439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Park (mpark)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/106338.diff
1 Files Affected:
- (modified) clang/lib/AST/ComputeDependence.cpp (+1-1)
``diff
diff --git a/clang/lib/AST/ComputeDependence.
https://github.com/mpark created
https://github.com/llvm/llvm-project/pull/106338
None
>From 76b247844ba302fc9b62431d1abaa4720372e51f Mon Sep 17 00:00:00 2001
From: Michael Park
Date: Tue, 27 Aug 2024 22:32:58 -0700
Subject: [PATCH] [NFC] Comment fix: "does specify state that" -> "does specify
@@ -1,98 +1,83 @@
// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \
// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \
// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \
-// RUN: --check-prefixes=CHECK,DXIL_CHECK,DXIL_NATIVE_HALF,NATIVE_
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/105930
>From ff7bbba695a727da01ee51fcb0c1126380f6bb7f Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sat, 24 Aug 2024 10:08:23 +0200
Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/105930
>From 6ae18c6da6dff942ad8524d7e3aa2565369e8cfb Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sat, 24 Aug 2024 10:08:23 +0200
Subject: [PATCH] [clang][HLSL] Update DXIL/SPIRV hybird CodeGen tests to use
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/106335
>From b86ebec082a82da967528819e9df7bd16c502b34 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Wed, 28 Aug 2024 00:34:12 -0300
Subject: [PATCH] [clang] mangle placeholder for deduced type as a
template-pr
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
As agreed on https://github.com/itanium-cxx-abi/cxx-abi/issues/109 these
placeholders should be mangled as a `template-prefix` production.
```
::=
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/106335
As agreed on https://github.com/itanium-cxx-abi/cxx-abi/issues/109 these
placeholders should be mangled as a `template-prefix` production.
```
::=# global
template
::=
@@ -1,98 +1,83 @@
// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \
// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \
// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \
-// RUN: --check-prefixes=CHECK,DXIL_CHECK,DXIL_NATIVE_HALF,NATIVE_
https://github.com/bogner edited
https://github.com/llvm/llvm-project/pull/106181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -799,6 +799,19 @@ static bool
IsEquivalentExceptionSpec(StructuralEquivalenceContext &Context,
return true;
}
+// Determine structural equivalence of two instances of
+// HLSLAttributedResourceType::Attributes
+static bool
+IsStructurallyEquivalent(StructuralEquivalenceC
@@ -6155,6 +6155,53 @@ class BTFTagAttributedType : public Type, public
llvm::FoldingSetNode {
}
};
+class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode {
+public:
+ struct Attributes {
+// Data gathered from HLSL resource attributes
+uint8_
@@ -702,6 +704,10 @@ ParsedAST::build(llvm::StringRef Filename, const
ParseInputs &Inputs,
log("Execute() failed when building AST for {0}: {1}", MainInput.getFile(),
toString(std::move(Err)));
+ // Disable the macro collector for the remainder of this function,
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Nathan Ridge (HighCommander4)
Changes
Fixes https://github.com/llvm/llvm-project/issues/99617
---
Full diff: https://github.com/llvm/llvm-project/pull/106329.diff
4 Files Affected:
- (modified) clang-tools-extra/clangd/Colle
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/106329
Fixes https://github.com/llvm/llvm-project/issues/99617
>From c5b3ae9c2cad6a0b0ada0ebb6adca117a3bfa012 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Tue, 27 Aug 2024 22:50:42 -0400
Subject: [PATCH] [
owenca wrote:
Please give a more descriptive title.
https://github.com/llvm/llvm-project/pull/106305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -579,6 +579,14 @@ TEST_F(FormatTestJS, GoogScopes) {
"});");
}
+TEST_F(FormatTestJS, GoogAnonymousClass) {
owenca wrote:
Please add a `TokenAnnotatorTest` to test the annotation of the braces instead
of (preferred), or in addition to, this
llvmbot wrote:
/pull-request llvm/llvm-project#106326
https://github.com/llvm/llvm-project/pull/106013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
/cherry-pick 656d5aa95825515a55ded61f19d41053c850c82d
https://github.com/llvm/llvm-project/pull/106013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/106175
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-08-27T19:14:16-07:00
New Revision: fac7e87d6634a153450bbc6dd147245d7b534a16
URL:
https://github.com/llvm/llvm-project/commit/fac7e87d6634a153450bbc6dd147245d7b534a16
DIFF:
https://github.com/llvm/llvm-project/commit/fac7e87d6634a153450bbc6dd147245d7b534a16.diff
LOG:
Author: Owen Pan
Date: 2024-08-27T19:13:27-07:00
New Revision: 656d5aa95825515a55ded61f19d41053c850c82d
URL:
https://github.com/llvm/llvm-project/commit/656d5aa95825515a55ded61f19d41053c850c82d
DIFF:
https://github.com/llvm/llvm-project/commit/656d5aa95825515a55ded61f19d41053c850c82d.diff
LOG:
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/106013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
> Quick update, all clang/cxx-library tests pass with the change but when I
> test it on my real project with modules I see crash or assert in
> [ASTDeclMerger::MergeDefinitionData](https://github.com/llvm/llvm-project/blob/main/clang/lib/Serialization/ASTReaderDecl.cpp#L2081)
Author: Harini0924
Date: 2024-08-27T18:52:08-07:00
New Revision: 815bf0f190383e14068f191bb0d16d62fbb6f8b3
URL:
https://github.com/llvm/llvm-project/commit/815bf0f190383e14068f191bb0d16d62fbb6f8b3
DIFF:
https://github.com/llvm/llvm-project/commit/815bf0f190383e14068f191bb0d16d62fbb6f8b3.diff
LO
https://github.com/Harini0924 closed
https://github.com/llvm/llvm-project/pull/106267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
delcypher wrote:
@bwendling @kees Apologies for taking so long to get this change upstream. We
spent quite a lot of time experimenting with different implementations that
ended up not working out. Our internal version of this patch is larger because
`counted_by` is allowed in many more context
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Dan Liew (delcypher)
Changes
Previously using the `counted_by` or `counted_by_or_null` attribute on a
pointer with an incomplete pointee type was forbidden. Unfortunately this
prevented a situation like the following from being allowed.
andykaylor wrote:
This may not be as bad as I thought. After looking more closely at the one test
case that was failing with this change, it turned out that the failure was
happening because the test contained a pragma to turn contraction off but
checks to verify that the fma was generated any
haoNoQ wrote:
Oh that's just a whitespace change. Would you like me to make a manual PR or
were you looking into it anyway?
https://github.com/llvm/llvm-project/pull/102226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/andykaylor updated
https://github.com/llvm/llvm-project/pull/105746
>From 973e7fb1a09f5479f88616e19642a71edc977b4a Mon Sep 17 00:00:00 2001
From: Andy Kaylor
Date: Thu, 22 Aug 2024 15:35:07 -0700
Subject: [PATCH 1/2] Honor pragmas with -ffp-contract=fast, depecate
fast-honor
https://github.com/andykaylor reopened
https://github.com/llvm/llvm-project/pull/105746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
Failed to cherry-pick: 030ee841a9c9fbbd6e7c001e751737381da01f7b
https://github.com/llvm/llvm-project/actions/runs/10588122990
Please manually backport the fix and push it to your github fork. Once this is
done, please create a [pull
request](https://github.com/llvm/llvm-proje
haoNoQ wrote:
/cherry-pick 030ee841a9c9fbbd6e7c001e751737381da01f7b
https://github.com/llvm/llvm-project/pull/102226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Yeah. For the unbalanced {{ I actually committed a change to fail in
release builds as well by printing an error message as formatv() output.
The only issue with debug only is that many folks build tablegen in release
mode, so those bad uses may not get flagged. But as long as the
llvmbot wrote:
Failed to cherry-pick: 3ddd7a6df3ef85cbfe3f5fc0294817638275d4df
https://github.com/llvm/llvm-project/actions/runs/10588027221
Please manually backport the fix and push it to your github fork. Once this is
done, please create a [pull
request](https://github.com/llvm/llvm-proje
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Joshua Batista (bob80905)
Changes
This PR adds `StructuredBuffer` to `HLSLExternalSemaSource.cpp`, by copying the
logic from RWBuffer but just replacing the name with StructuredBuffer. The
change now allows StructuredBuffers to be defined
https://github.com/bob80905 ready_for_review
https://github.com/llvm/llvm-project/pull/106316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/106316
>From 7089ee170132c4a7529f6729919641f1db462566 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 27 Aug 2024 17:26:58 -0700
Subject: [PATCH 1/2] add StructuredBuffer to hlsl external sema source
---
cl
haoNoQ wrote:
/cherry-pick 3ddd7a6df3ef85cbfe3f5fc0294817638275d4df
https://github.com/llvm/llvm-project/pull/102226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haoNoQ milestoned
https://github.com/llvm/llvm-project/pull/102226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
haoNoQ wrote:
Yeah I think we really gotta cherry-pick this revert, because failing tests on
release branches are somewhat scary (cf.
https://green.lab.llvm.org/job/llvm.org/job/clang-stage1-RA-release-branch/69/console).
I don't know how it's usually done but let me try to push some buttons,
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/106316
>From 7089ee170132c4a7529f6729919641f1db462566 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 27 Aug 2024 17:26:58 -0700
Subject: [PATCH] add StructuredBuffer to hlsl external sema source
---
clang/
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/106316
>From 7089ee170132c4a7529f6729919641f1db462566 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Tue, 27 Aug 2024 17:26:58 -0700
Subject: [PATCH] add StructuredBuffer to hlsl external sema source
---
clang/
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/106316
This PR adds `StructuredBuffer` to `HLSLExternalSemaSource.cpp`, by copying the
logic from RWBuffer but just replacing the name with StructuredBuffer. The
change now allows StructuredBuffers to be defined in H
darkfeline wrote:
@HazardyKnusperkeks @owenca @sam-mccall tagging some people based on git
history; apologies if you aren't the right person
https://github.com/llvm/llvm-project/pull/106305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
xbjfk wrote:
Thanks guys, could one of you merge it for me, since I dont have commit access?
https://github.com/llvm/llvm-project/pull/66593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/106181
>From 11a6b3aac44889d39911a6704a9a963f29e92388 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Mon, 26 Aug 2024 12:13:09 -0700
Subject: [PATCH 1/7] Add HLSLAttributedResourceType - WIP
---
clang/include/clang
@@ -799,6 +799,19 @@ static bool
IsEquivalentExceptionSpec(StructuralEquivalenceContext &Context,
return true;
}
+// Determine structural equivalence of two instances of
+// HLSLAttributedResourceType::Attributes
+static bool
+IsStructurallyEquivalent(StructuralEquivalenceC
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/66593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
Having this enabled guarded by NDEBUG seems like a good option. There is
already some things already like this isn't there? I kind of remember that
using imbalanced `{` / `}` pair of something like that was checked only in
assert builds?
https://github.com/llvm/llvm-project/p
yronglin wrote:
Thank you for your review! I have reverted the modification of ASTContext.
https://github.com/llvm/llvm-project/pull/105996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
@@ -5312,6 +5314,147 @@ bool Compiler::VisitComplexUnaryOperator(const
UnaryOperator *E) {
return true;
}
+template
+bool Compiler::VisitVectorUnaryOperator(const UnaryOperator *E) {
+ const Expr *SubExpr = E->getSubExpr();
+ assert(SubExpr->getType()->isVectorType());
+
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/106312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 approved this pull request.
https://github.com/llvm/llvm-project/pull/106181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahmedbougacha wrote:
In the meantime, let's do #106312
https://github.com/llvm/llvm-project/pull/106304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5312,6 +5314,147 @@ bool Compiler::VisitComplexUnaryOperator(const
UnaryOperator *E) {
return true;
}
+template
+bool Compiler::VisitVectorUnaryOperator(const UnaryOperator *E) {
+ const Expr *SubExpr = E->getSubExpr();
+ assert(SubExpr->getType()->isVectorType());
+
https://github.com/bob80905 edited
https://github.com/llvm/llvm-project/pull/106181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -799,6 +799,19 @@ static bool
IsEquivalentExceptionSpec(StructuralEquivalenceContext &Context,
return true;
}
+// Determine structural equivalence of two instances of
+// HLSLAttributedResourceType::Attributes
+static bool
+IsStructurallyEquivalent(StructuralEquivalenceC
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-backend-aarch64
Author: Ahmed Bougacha (ahmedbougacha)
Changes
This is a partial revert of c66e1d6f3429. Even though that
allowed us to declare v9.2-a support without picking up SVE2
in both the backend and the driver, the fro
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/105996
>From 0e4c511107f76da085a8019cf2eca78c3a5a0754 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Mon, 26 Aug 2024 02:09:31 +0800
Subject: [PATCH 1/5] [Clang][Interp] Implement constexpr vector unary
operators +, -
https://github.com/ahmedbougacha milestoned
https://github.com/llvm/llvm-project/pull/106312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ahmedbougacha created
https://github.com/llvm/llvm-project/pull/106312
This is a partial revert of c66e1d6f3429. Even though that
allowed us to declare v9.2-a support without picking up SVE2
in both the backend and the driver, the frontend itself still
enabled SVE via the arc
7726
-Original Message-
From:
Sent: Tue, 27 Aug 2024 16:50:05 -0700
To: 5103850...@txt.att.net
Subject: =?utf-8?q?cfe-commits_Digest=2C_Vol_206=2C_Issue_2183?=
>Send cfe-commits mailing list submissions to
> cfe-commits@lists.llvm.org
>
>To subscribe or unsubscribe via the
7726
-Original Message-
From:
Sent: Tue, 27 Aug 2024 16:22:22 -0700
To: 5103850...@txt.att.net
Subject: =?utf-8?q?cfe-commits_Digest=2C_Vol_206=2C_Issue_2182?=
>Send cfe-commits mailing list submissions to
> cfe-commits@lists.llvm.org
>
>To subscribe or unsubscribe via the
7726
-Original Message-
From:
Sent: Tue, 27 Aug 2024 15:59:38 -0700
To: 5103850...@txt.att.net
Subject: =?utf-8?q?cfe-commits_Digest=2C_Vol_206=2C_Issue_2180?=
>Send cfe-commits mailing list submissions to
> cfe-commits@lists.llvm.org
>
>To subscribe or unsubscribe via the
https://github.com/pow2clk approved this pull request.
Oops. I approved on my underprivileged laptop account 😳
https://github.com/llvm/llvm-project/pull/104544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
@@ -7459,6 +7459,13 @@ QualType
TreeTransform::TransformBTFTagAttributedType(
llvm_unreachable("Unexpected TreeTransform for BTFTagAttributedType");
}
+template
+QualType TreeTransform::TransformHLSLAttributedResourceType(
+TypeLocBuilder &TLB, HLSLAttributedResourceTy
@@ -6155,6 +6155,53 @@ class BTFTagAttributedType : public Type, public
llvm::FoldingSetNode {
}
};
+class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode {
+public:
+ struct Attributes {
+// Data gathered from HLSL resource attributes
+uint8_
@@ -6,7 +6,7 @@
// RUN: %clang_cc1 -std=c++23 -pedantic-errors -verify=expected %s
// RUN: %clang_cc1 -std=c++2c -pedantic-errors -verify=expected %s
-namespace cwg2917 { // cwg2917: 20 open 2024-07-30
+namespace cwg2917 { // cwg2917: 20 review 2024-07-30
Endi
@@ -6155,6 +6155,53 @@ class BTFTagAttributedType : public Type, public
llvm::FoldingSetNode {
}
};
+class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode {
+public:
+ struct Attributes {
+// Data gathered from HLSL resource attributes
+uint8_
@@ -6155,6 +6155,53 @@ class BTFTagAttributedType : public Type, public
llvm::FoldingSetNode {
}
};
+class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode {
+public:
+ struct Attributes {
+// Data gathered from HLSL resource attributes
+uint8_
@@ -2048,6 +2049,24 @@ void TypePrinter::printBTFTagAttributedAfter(const
BTFTagAttributedType *T,
printAfter(T->getWrappedType(), OS);
}
+void TypePrinter::printHLSLAttributedResourceBefore(
+const HLSLAttributedResourceType *T, raw_ostream &OS) {
+ printBefore(T->get
https://github.com/bogner approved this pull request.
A few nitpicks, but otherwise LGTM!
https://github.com/llvm/llvm-project/pull/106181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
@@ -6155,6 +6155,53 @@ class BTFTagAttributedType : public Type, public
llvm::FoldingSetNode {
}
};
+class HLSLAttributedResourceType : public Type, public llvm::FoldingSetNode {
+public:
+ struct Attributes {
+// Data gathered from HLSL resource attributes
+uint8_
https://github.com/bogner edited
https://github.com/llvm/llvm-project/pull/106181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
I did 2 sets of experiments, but data wise I am inconclusive if this causes a
real compile time regression.
1. Build MLIR verbose and capture all mlir-gen command lines to a file:
ninja -C build check-mlir --verbose | tee build_log.txt
grep "NATIVE/bin/mlir-tblgen " build_l
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: None (darkfeline)
Changes
Broken by
https://github.com/llvm/llvm-project/commit/625841c3be4dbaab089c01217726a2906f3a8103
---
Full diff: https://github.com/llvm/llvm-project/pull/106305.diff
1 Files Affected:
- (modified) clang/t
https://github.com/darkfeline created
https://github.com/llvm/llvm-project/pull/106305
Broken by
https://github.com/llvm/llvm-project/commit/625841c3be4dbaab089c01217726a2906f3a8103
>From d45413868d1026e75b725369eec2184b1b61275e Mon Sep 17 00:00:00 2001
From: Allen Li <>
Date: Tue, 27 Aug 2024
https://github.com/ahmedbougacha created
https://github.com/llvm/llvm-project/pull/106304
In the tablegen definitions, we have now split the lists of extensions enabled
by default for an arch version from the features that are required.
However, the frontend (in `AArch64TargetInfo::setFeatureE
@@ -5695,6 +5696,15 @@ static bool EvaluateUnaryTypeTrait(Sema &Self, TypeTrait
UTT,
return true;
return false;
}
+ case UTT_IsIntangibleType:
+assert(Self.getLangOpts().HLSL && "intangible types are HLSL-only
feature");
+if (!T->isVoidType() && !T->isI
https://github.com/pow3clk edited
https://github.com/llvm/llvm-project/pull/104544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pow3clk approved this pull request.
One more question, but it looks good to me!
https://github.com/llvm/llvm-project/pull/104544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -6,7 +6,7 @@
// RUN: %clang_cc1 -std=c++23 -pedantic-errors -verify=expected %s
// RUN: %clang_cc1 -std=c++2c -pedantic-errors -verify=expected %s
-namespace cwg2917 { // cwg2917: 20 open 2024-07-30
+namespace cwg2917 { // cwg2917: 20 review 2024-07-30
Sirr
https://github.com/benlangmuir approved this pull request.
Seems reasonable
https://github.com/llvm/llvm-project/pull/106271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/106271
>From f5f761adf9ec2f150e32dc42cd70143b5d91bd7a Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Tue, 27 Aug 2024 09:34:01 -0700
Subject: [PATCH 1/5] [clang] `TargetInfo` does not own `TargetOptions`
---
c
AlexMaclean wrote:
@arsenm, @goldsteinn when you have a minute could you take another look at
this? I think I've addressed all the issues you've raised.
https://github.com/llvm/llvm-project/pull/97762
___
cfe-commits mailing list
cfe-commits@lists.ll
@@ -11427,6 +11427,19 @@ static void AnalyzeImplicitConversions(
return;
}
+ if (auto *OutArgE = dyn_cast(E)) {
+// The base expression is only used to initialize the parameter for
+// arguments to `inout` parameters, so we only traverse down the base
+// ex
@@ -8511,7 +8514,7 @@ static void HandleHLSLParamModifierAttr(QualType &CurType,
return;
if (Attr.getSemanticSpelling() == HLSLParamModifierAttr::Keyword_inout ||
Attr.getSemanticSpelling() == HLSLParamModifierAttr::Keyword_out)
-CurType = S.getASTContext().getL
@@ -302,9 +302,8 @@ class TargetInfo : public TransferrableTargetInfo,
/// \param Opts - The options to use to initialize the target. The target may
/// modify the options to canonicalize the target feature information to
match
/// what the backend expects.
- static Tar
@@ -17292,43 +17292,43 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/2913.html";>2913
-open
+tentatively ready
Grammar for deduction-guide has requires-clause in the
wrong position
Not resolved
https
@@ -17292,43 +17292,43 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/2913.html";>2913
-open
+tentatively ready
Grammar for deduction-guide has requires-clause in the
wrong position
Not resolved
https
@@ -6,7 +6,7 @@
// RUN: %clang_cc1 -std=c++23 -pedantic-errors -verify=expected %s
// RUN: %clang_cc1 -std=c++2c -pedantic-errors -verify=expected %s
-namespace cwg2917 { // cwg2917: 20 open 2024-07-30
+namespace cwg2917 { // cwg2917: 20 review 2024-07-30
Endi
1 - 100 of 557 matches
Mail list logo
