[clang-tools-extra] Extend call hierarchy for field and non-local variables (PR #113900)

2024-11-02 Thread via cfe-commits
github-actions[bot] wrote: @timon-ul Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang-tools-extra] Extend call hierarchy for field and non-local variables (PR #113900)

2024-11-02 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/113900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] e102338 - Support call hierarchy for fields and non-local variables (#113900)

2024-11-02 Thread via cfe-commits
Author: timon-ul Date: 2024-11-03T01:38:25-05:00 New Revision: e102338b6e2f9ec1a882bdfb91eb4e364c7b6478 URL: https://github.com/llvm/llvm-project/commit/e102338b6e2f9ec1a882bdfb91eb4e364c7b6478 DIFF: https://github.com/llvm/llvm-project/commit/e102338b6e2f9ec1a882bdfb91eb4e364c7b6478.diff LOG:

[clang-tools-extra] Extend call hierarchy for field and non-local variables (PR #113900)

2024-11-02 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. https://github.com/llvm/llvm-project/pull/113900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Allow -fuse-lld=lld-link when lto is enabled on *windows-msvc targets (PR #113966)

2024-11-02 Thread Zhaoshi Zheng via cfe-commits
https://github.com/zhaoshiz updated https://github.com/llvm/llvm-project/pull/113966 >From 5259a3b00fe1b841e8548443036a943b169970dc Mon Sep 17 00:00:00 2001 From: Zhaoshi Zheng Date: Mon, 28 Oct 2024 14:35:35 -0700 Subject: [PATCH 1/4] [clang][Driver] Allow -fuse-lld=lld-link when lto is enabl

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/114661 >From 311c752356617d768f0bdc8599e765ae42272329 Mon Sep 17 00:00:00 2001 From: chomosuke Date: Sat, 2 Nov 2024 09:18:38 + Subject: [PATCH] Add quick fix to automatically adds NOLINTNEXTLINE comment above c

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
https://github.com/ideasman42 edited https://github.com/llvm/llvm-project/pull/112792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
https://github.com/ideasman42 edited https://github.com/llvm/llvm-project/pull/112792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
@@ -205,14 +288,60 @@ uses the function `buffer-file-name'." (delete-file temp-file) (when (buffer-name temp-buffer) (kill-buffer temp-buffer) +;;;###autoload +(defun clang-format-git-diffs (&optional style assume-file-name) ideasman42 wrote:

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
@@ -205,14 +288,60 @@ uses the function `buffer-file-name'." (delete-file temp-file) (when (buffer-name temp-buffer) (kill-buffer temp-buffer) +;;;###autoload +(defun clang-format-git-diffs (&optional style assume-file-name) + "The same as 'clang-format-buffer

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
https://github.com/ideasman42 edited https://github.com/llvm/llvm-project/pull/112792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
https://github.com/ideasman42 edited https://github.com/llvm/llvm-project/pull/112792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
https://github.com/ideasman42 edited https://github.com/llvm/llvm-project/pull/112792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
https://github.com/ideasman42 edited https://github.com/llvm/llvm-project/pull/112792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
https://github.com/ideasman42 requested changes to this pull request. Note that I'm not a regular clang contributor, I just submitted a small improvement to clang-format, and maintain some emacs packages in elpa & melpa. Overall the PR looks like it needs more attention to detail, as far

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
@@ -132,18 +132,97 @@ is a zero-based file offset, assuming ‘utf-8-unix’ coding." (lambda (byte &optional _quality _coding-system) (byte-to-position (1+ byte) -;;;###autoload -(defun clang-format-region (start end &optional style assume-file-name) - "Use clang-

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
@@ -132,18 +132,97 @@ is a zero-based file offset, assuming ‘utf-8-unix’ coding." (lambda (byte &optional _quality _coding-system) (byte-to-position (1+ byte) -;;;###autoload -(defun clang-format-region (start end &optional style assume-file-name) - "Use clang-

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
@@ -132,18 +132,97 @@ is a zero-based file offset, assuming ‘utf-8-unix’ coding." (lambda (byte &optional _quality _coding-system) (byte-to-position (1+ byte) -;;;###autoload -(defun clang-format-region (start end &optional style assume-file-name) - "Use clang-

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
@@ -132,18 +132,97 @@ is a zero-based file offset, assuming ‘utf-8-unix’ coding." (lambda (byte &optional _quality _coding-system) (byte-to-position (1+ byte) -;;;###autoload -(defun clang-format-region (start end &optional style assume-file-name) - "Use clang-

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Campbell Barton via cfe-commits
@@ -132,18 +132,97 @@ is a zero-based file offset, assuming ‘utf-8-unix’ coding." (lambda (byte &optional _quality _coding-system) (byte-to-position (1+ byte) -;;;###autoload -(defun clang-format-region (start end &optional style assume-file-name) - "Use clang-

[clang-tools-extra] [clang-tidy] Improved readability redundant casting with enums (PR #111424)

2024-11-02 Thread via cfe-commits
=?utf-8?q?F=C3=A9lix-Antoine?= Constantin, =?utf-8?q?F=C3=A9lix-Antoine?= Constantin Message-ID: In-Reply-To: @@ -222,6 +222,12 @@ Changes in existing checks by adding the option `UseUpperCaseLiteralSuffix` to select the case of the literal suffix in fixes. +- Improved :

[clang] [clang][Driver] Allow -fuse-lld=lld-link when lto is enabled on *windows-msvc targets (PR #113966)

2024-11-02 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,9 @@ +// RUN: %clang --target=aarch64-pc-windows-msvc -O3 -flto -fuse-ld=lld -### %s 2>&1 | FileCheck %s +// RUN: %clang --target=aarch64-pc-windows-msvc -O3 -flto=thin -fuse-ld=lld -### %s 2>&1 | FileCheck %s +// MaskRay wrote: delete `^//$` lines

[clang] [clang][Driver] Allow -fuse-lld=lld-link when lto is enabled on *windows-msvc targets (PR #113966)

2024-11-02 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/113966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [XRay][AArch64] Support -fxray-shared (PR #114431)

2024-11-02 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/114431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [XRay][AArch64] Support -fxray-shared (PR #114431)

2024-11-02 Thread Fangrui Song via cfe-commits
@@ -67,8 +67,12 @@ XRayArgs::XRayArgs(const ToolChain &TC, const ArgList &Args) { false)) { XRayShared = true; -// DSO instrumentation is currently limited to x86_64 -if (Triple.getArch() != llvm::Triple::x86_64) { +// DSO instrumentation is

[clang] [compiler-rt] [XRay][AArch64] Support -fxray-shared (PR #114431)

2024-11-02 Thread Fangrui Song via cfe-commits
@@ -67,8 +67,12 @@ XRayArgs::XRayArgs(const ToolChain &TC, const ArgList &Args) { false)) { XRayShared = true; -// DSO instrumentation is currently limited to x86_64 -if (Triple.getArch() != llvm::Triple::x86_64) { +// DSO instrumentation is

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread via cfe-commits
goldsteinn wrote: @luke957 as well also can probably review the elisp code for quality. https://github.com/llvm/llvm-project/pull/112792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't re-annotate CaseLabelColon as ConditionalExpr (PR #114639)

2024-11-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot1` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/3422 Here is the relevan

[clang] [clang] Diagnose for implicit boolean conversions in assignments (PR #114687)

2024-11-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8129ba6c70aef54d87893adeb34e76f84fa69fe3 b8244b346c7a97c2eb35ccfea23675b8df4f046e --e

[clang] [clang] Diagnose for implicit boolean conversions in assignments (PR #114687)

2024-11-02 Thread Philipp Rados via cfe-commits
https://github.com/PhilippRados edited https://github.com/llvm/llvm-project/pull/114687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose for implicit boolean conversions in assignments (PR #114687)

2024-11-02 Thread Philipp Rados via cfe-commits
https://github.com/PhilippRados created https://github.com/llvm/llvm-project/pull/114687 This is an unfinished implementation of #33528. I have a couple of questions since I'm new to the codebase: This warning should be issued for both C and C++. For C++ it is pretty straightforward since I c

[clang] [clang] Move VFS overlays from `HeaderSearchOptions` to `FileSystemOptions` (PR #86534)

2024-11-02 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/86534 >From d49ef2de83b37156ab73c0028676d9b0425ef2ed Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Mon, 25 Mar 2024 10:15:33 -0700 Subject: [PATCH] [clang] Move VFS overlays from `HeaderSearchOptions` to `File

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

2024-11-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #100921 --- Full diff: https://github.com/llvm/llvm-project/pull/114684.diff 2 Files Affected: - (modified) clang/lib/Parse/ParseExpr.cpp (+3) - (modified) clang/test/AST/ast-dump-recovery.cpp (

[clang] [Clang] enhance error recovery with RecoveryExpr for trailing commas in call arguments (PR #114684)

2024-11-02 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/114684 Fixes #100921 >From d95d0fdb22ae2ad162f89cb211f313cea6c6474a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 2 Nov 2024 23:54:35 +0200 Subject: [PATCH] [Clang] enhance error recovery with RecoveryExpr

[clang] [clang-format] Don't re-annotate CaseLabelColon as ConditionalExpr (PR #114639)

2024-11-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux` running on `systemz-1` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/4185 Here is the relevant piece of the build log fo

[clang-tools-extra] [clang-tidy] Create a check for signed and unsigned integers comparison (PR #113144)

2024-11-02 Thread via cfe-commits
@@ -0,0 +1,192 @@ +//===--- UseIntegerSignComparisonCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-11-02 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod updated https://github.com/llvm/llvm-project/pull/109362 >From f4e51ecd076a73d1ebc7a439001d0ed22071b019 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Mon, 8 Jul 2024 01:48:46 +0100 Subject: [PATCH 1/2] [Clang][TableGen] Add explicit symbol visibility macros to c

[clang] 25af8f5 - [clang-format][doc] Fix a typo

2024-11-02 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-11-02T14:48:35-07:00 New Revision: 25af8f535edd59ec12a404954db233e2e65e8d9b URL: https://github.com/llvm/llvm-project/commit/25af8f535edd59ec12a404954db233e2e65e8d9b DIFF: https://github.com/llvm/llvm-project/commit/25af8f535edd59ec12a404954db233e2e65e8d9b.diff LOG:

[clang-tools-extra] [clang-tidy] Create a check for signed and unsigned integers comparison (PR #113144)

2024-11-02 Thread via cfe-commits
https://github.com/qt-tatiana updated https://github.com/llvm/llvm-project/pull/113144 >From 34ee6f5836efe3acddbdd1c9810af358b8c4f981 Mon Sep 17 00:00:00 2001 From: Tatiana Borisova Date: Thu, 17 Oct 2024 18:00:08 +0200 Subject: [PATCH 1/8] [clang-tidy] Create a check for signed and unsigned i

[clang] df232d4 - [clang-format] Don't re-annotate CaseLabelColon as ConditionalExpr (#114639)

2024-11-02 Thread via cfe-commits
Author: Owen Pan Date: 2024-11-02T14:42:41-07:00 New Revision: df232d46f5b62220073f106e960575b9cf6cc39d URL: https://github.com/llvm/llvm-project/commit/df232d46f5b62220073f106e960575b9cf6cc39d DIFF: https://github.com/llvm/llvm-project/commit/df232d46f5b62220073f106e960575b9cf6cc39d.diff LOG:

[clang] [clang-format] Don't re-annotate CaseLabelColon as ConditionalExpr (PR #114639)

2024-11-02 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/114639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [emacs][clang-format] Add elisp API for clang-format on git diffs (PR #112792)

2024-11-02 Thread Owen Pan via cfe-commits
owenca wrote: @ideasman42 can you review this PR? Thanks! https://github.com/llvm/llvm-project/pull/112792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix clang-format-test.el past 625841c (PR #106398)

2024-11-02 Thread Owen Pan via cfe-commits
owenca wrote: > Race condition! Will update the other PR. @dklimkin can you link to "the other PR"? Should we revert this one now? cc @mydeveloperday @HazardyKnusperkeks https://github.com/llvm/llvm-project/pull/106398 ___ cfe-commits mailing list cf

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clangd Author: Richard Li (chomosuke) Changes For some other lsp / linters. They will offer a "Ignore this error for this line" code actions for warnings. I find that convenient as I don't have to type the comment

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke ready_for_review https://github.com/llvm/llvm-project/pull/114661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/114661 >From 311c752356617d768f0bdc8599e765ae42272329 Mon Sep 17 00:00:00 2001 From: chomosuke Date: Sat, 2 Nov 2024 09:18:38 + Subject: [PATCH] Add quick fix to automatically adds NOLINTNEXTLINE comment above c

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/114661 >From 35cbe235a9b1b40b23b0910eb1bfa42c488ab54e Mon Sep 17 00:00:00 2001 From: chomosuke Date: Sat, 2 Nov 2024 09:18:38 + Subject: [PATCH] Add quick fix to automatically adds NOLINTNEXTLINE comment above c

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/114661 >From 581004de1006ce232ad5dbbed9f8af8eb2f312ae Mon Sep 17 00:00:00 2001 From: chomosuke Date: Sat, 2 Nov 2024 09:18:38 + Subject: [PATCH] Add quick fix to automatically adds NOLINTNEXTLINE comment above c

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/114661 >From 97a830bdf1b3eb1eb352561ef38f95e8baa4e0b9 Mon Sep 17 00:00:00 2001 From: chomosuke Date: Sat, 2 Nov 2024 09:18:38 + Subject: [PATCH] Add quick fix to automatically adds NOLINTNEXTLINE comment above c

[clang-tools-extra] Nolint fix (PR #114663)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke closed https://github.com/llvm/llvm-project/pull/114663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add bugprone-undefined-sprintf-overlap (PR #114244)

2024-11-02 Thread Chris Cotter via cfe-commits
https://github.com/ccotter updated https://github.com/llvm/llvm-project/pull/114244 >From fd914cc82688b122654d2d7ada72007541b197c0 Mon Sep 17 00:00:00 2001 From: Chris Cotter Date: Wed, 30 Oct 2024 10:54:49 -0400 Subject: [PATCH 1/5] Add bugprone-sprintf-overlap --- .../bugprone/BugproneTidyM

[clang] [clang][NFC] Spell out DynTypedNode instead of auto (PR #114427)

2024-11-02 Thread Chris Cotter via cfe-commits
ccotter wrote: While working on #114244, I noticed the use of `auto` in `memberHasSameNameAsBoundNode`. The only other place I could find using `auto` with `Nodes.getNode` was in the second file I changed. https://github.com/llvm/llvm-project/pull/114427 ___

[clang-tools-extra] Nolint fix (PR #114663)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/114663 >From 7b70b905e5a9942f592316b407135975977c93cb Mon Sep 17 00:00:00 2001 From: chomosuke Date: Fri, 16 Aug 2024 13:31:21 + Subject: [PATCH 01/20] Fixing one error --- clang-tools-extra/clangd/ClangdServer

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-11-02 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @AaronBallman, ping. https://github.com/llvm/llvm-project/pull/109362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-11-02 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @fsfod, can you rebase? https://github.com/llvm/llvm-project/pull/109362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] SemaFunctionEffects: When verifying a function, ignore any trailing 'requires' clause. (PR #114266)

2024-11-02 Thread Chris Apple via cfe-commits
@@ -1259,6 +1263,12 @@ class Analyzer { return true; } +bool TraverseStmt(Stmt *Statement) { + if (Statement != TrailingRequiresClause) cjappl wrote: Could consider leaving a comment here saying why you skip trailing requires clauses (some

[clang] [clang] SemaFunctionEffects: When verifying a function, ignore any trailing 'requires' clause. (PR #114266)

2024-11-02 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/114266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] SemaFunctionEffects: When verifying a function, ignore any trailing 'requires' clause. (PR #114266)

2024-11-02 Thread Chris Apple via cfe-commits
https://github.com/cjappl commented: for whatever it's worth - LGTM. Leaving to more experienced heads in this area to actually approve. Good sleuthing! https://github.com/llvm/llvm-project/pull/114266 ___ cfe-commits mailing list cfe-commits@lists.

[clang-tools-extra] [clang-tidy] New option `CompilationArgsToRemoveRegex` to remove arguments from the command line (PR #111453)

2024-11-02 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/111453 From 5cdc27e543b0f4dea3dd3848d974a27614aea713 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Mon, 7 Oct 2024 19:22:44 -0400 Subject: [PATCH 1/2] [clang-tidy] New option to rem

[clang-tools-extra] [clang-tidy] New option `CompilationArgsToRemoveRegex` to remove arguments from the command line (PR #111453)

2024-11-02 Thread Félix-Antoine Constantin via cfe-commits
@@ -106,6 +106,9 @@ Improvements to clang-tidy - Improved :program:`run-clang-tidy.py` script. Fixed minor shutdown noise happening on certain platforms when interrupting the script. +- Improved :program:`clang-tidy` by adding the option `CompilationArgsToRemoveRegex` -

[clang] [clang][bytecode][NFC] Switch BitcastBuffer to SmallVector (PR #114677)

2024-11-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/114677 >From 9583cf5edac75e25c47f7ad2cb52a3b3bb95442b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 2 Nov 2024 16:59:41 +0100 Subject: [PATCH] [clang][bytecode][NFC] Switch BitcastBuffer to S

[clang-tools-extra] [clang-tidy] Improved readability redundant casting with enums (PR #111424)

2024-11-02 Thread Félix-Antoine Constantin via cfe-commits
felix642 wrote: > sounds better as the commit description. I agree, thank you for the suggestion. >The CI failure is probably because the implicit type for E3 is not unsigned >int on Windows. You are right. I could not find a way to make this test platform independent. I would either have to i

[clang] [clang][bytecode][NFC] Switch BitcastBuffer to SmallVector (PR #114677)

2024-11-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This is a little easier to work with since we are guaranteed that the item type of the vector is byte sized and not something else. --- Full diff: https://github.com/llvm/llvm-project/pull/114677.diff 1 Fi

[clang-tools-extra] [clang-tidy] Improved readability redundant casting with enums (PR #111424)

2024-11-02 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 updated https://github.com/llvm/llvm-project/pull/111424 From a786f626beb418cf6b8847c6250f0490b60affdb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?= Date: Mon, 7 Oct 2024 15:27:36 -0400 Subject: [PATCH 1/3] [clang-tidy] Improved readabil

[clang] [clang] SemaFunctionEffects: When verifying a function, ignore any trailing 'requires' clause. (PR #114266)

2024-11-02 Thread Doug Wyatt via cfe-commits
dougsonos wrote: I was able to (manually) extract a reduction from libc++ and write a test that exposed the issue / verified that it's fixed. It's also here: https://godbolt.org/z/9absooo6G https://github.com/llvm/llvm-project/pull/114266 ___ cfe-com

[clang] [clang] SemaFunctionEffects: When verifying a function, ignore any trailing 'requires' clause. (PR #114266)

2024-11-02 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/114266 >From 6a8a3f21eb23b8b7d63bd8b0fb6e2e85ff1951df Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Wed, 30 Oct 2024 09:53:58 -0700 Subject: [PATCH 1/2] [clang] SemaFunctionEffects: When verifying a function, igno

[clang] [clang][bytecode][NFC] Switch BitcastBuffer to SmallVector (PR #114677)

2024-11-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/114677 This is a little easier to work with since we are guaranteed that the item type of the vector is byte sized and not something else. >From eabd705ce8a970250363d05622c8547580c496d4 Mon Sep 17 00:00:00 2001 From:

[clang] [clang] Fix a typo in clangs README (PR #114410)

2024-11-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-darwin` running on `doug-worker-3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/4425 Here is the r

[clang] [clang] Fix a typo in clangs README (PR #114410)

2024-11-02 Thread Jon Roelofs via cfe-commits
jroelofs wrote: sure! https://github.com/llvm/llvm-project/pull/114410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a typo in clangs README (PR #114410)

2024-11-02 Thread via cfe-commits
github-actions[bot] wrote: @PhilippRados Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a b

[clang] [clang] Fix a typo in clangs README (PR #114410)

2024-11-02 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/114410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ad0a1b9 - [clang] Fix a typo in clangs README (#114410)

2024-11-02 Thread via cfe-commits
Author: Philipp Rados Date: 2024-11-02T08:19:28-07:00 New Revision: ad0a1b90adccd3a9b8fdfbe5923a6ebe9ca2e1a3 URL: https://github.com/llvm/llvm-project/commit/ad0a1b90adccd3a9b8fdfbe5923a6ebe9ca2e1a3 DIFF: https://github.com/llvm/llvm-project/commit/ad0a1b90adccd3a9b8fdfbe5923a6ebe9ca2e1a3.diff

[clang] [clang] Fix a typo in clangs README (PR #114410)

2024-11-02 Thread Philipp Rados via cfe-commits
PhilippRados wrote: @jroelofs can you merge this? https://github.com/llvm/llvm-project/pull/114410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-11-02 Thread kadir çetinkaya via cfe-commits
@@ -228,54 +223,30 @@ class StandalonePrerequisiteModules : public PrerequisiteModules { return BuiltModuleNames.contains(ModuleName); } - void addModuleFile(llvm::StringRef ModuleName, - llvm::StringRef ModuleFilePath) { -RequiredModules.emplac

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-11-02 Thread kadir çetinkaya via cfe-commits
@@ -228,54 +223,30 @@ class StandalonePrerequisiteModules : public PrerequisiteModules { return BuiltModuleNames.contains(ModuleName); } - void addModuleFile(llvm::StringRef ModuleName, - llvm::StringRef ModuleFilePath) { -RequiredModules.emplac

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-11-02 Thread kadir çetinkaya via cfe-commits
@@ -482,6 +482,42 @@ void func() { EXPECT_EQ(Result.signatures[0].parameters[0].labelString, "int a"); } +TEST_F(PrerequisiteModulesTests, ReusablePrerequisiteModulesTest) { kadircet wrote: can you also add some tests demonstrating behavior in presence of s

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-11-02 Thread kadir çetinkaya via cfe-commits
@@ -316,36 +287,169 @@ llvm::Error buildModuleFile(llvm::StringRef ModuleName, if (Clang->getDiagnostics().hasErrorOccurred()) return llvm::createStringError("Compilation failed"); - BuiltModuleFiles.addModuleFile(ModuleName, Inputs.CompileCommand.Output); - return llv

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-11-02 Thread kadir çetinkaya via cfe-commits
@@ -316,36 +287,169 @@ llvm::Error buildModuleFile(llvm::StringRef ModuleName, if (Clang->getDiagnostics().hasErrorOccurred()) return llvm::createStringError("Compilation failed"); - BuiltModuleFiles.addModuleFile(ModuleName, Inputs.CompileCommand.Output); - return llv

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-11-02 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/106683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-11-02 Thread kadir çetinkaya via cfe-commits
@@ -316,36 +287,169 @@ llvm::Error buildModuleFile(llvm::StringRef ModuleName, if (Clang->getDiagnostics().hasErrorOccurred()) return llvm::createStringError("Compilation failed"); - BuiltModuleFiles.addModuleFile(ModuleName, Inputs.CompileCommand.Output); - return llv

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-11-02 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet requested changes to this pull request. thanks I think this LG in terms of module-builder interfaces, but I think we can make some more changes to implementation to ensure it's easier to maintain going forward. speaking of maintenance, @HighCommander4 is definitely

[clang] [clang][CodeGen] `sret` args should always point to the `alloca` AS, so use that (PR #114062)

2024-11-02 Thread Alex Voicu via cfe-commits
@@ -1672,10 +1672,11 @@ CodeGenTypes::GetFunctionType(const CGFunctionInfo &FI) { // Add type for sret argument. if (IRFunctionArgs.hasSRetArg()) { -QualType Ret = FI.getReturnType(); -unsigned AddressSpace = CGM.getTypes().getTargetAddressSpace(Ret); +auto Ad

[clang] [clang] Merge some delarations which currently have different attributes (PR #79349)

2024-11-02 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/79349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't re-annotate CaseLabelColon as ConditionalExpr (PR #114639)

2024-11-02 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/114639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Nolint fix (PR #114663)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke edited https://github.com/llvm/llvm-project/pull/114663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Nolint fix (PR #114663)

2024-11-02 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] Nolint fix (PR #114663)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke created https://github.com/llvm/llvm-project/pull/114663 None >From 7b70b905e5a9942f592316b407135975977c93cb Mon Sep 17 00:00:00 2001 From: chomosuke Date: Fri, 16 Aug 2024 13:31:21 + Subject: [PATCH 01/19] Fixing one error --- clang-tools-extra/clangd/Clangd

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/114661 >From f52c645a8b0a3664c2520e70b46e248c984037ae Mon Sep 17 00:00:00 2001 From: chomosuke Date: Sat, 2 Nov 2024 09:18:38 + Subject: [PATCH] Add quick fix to automatically adds NOLINTNEXTLINE comment above c

[clang] 2804762 - [clang][NFC] Use const reference for IndirectLocalPath if possible.

2024-11-02 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2024-11-02T12:09:52+01:00 New Revision: 2804762e2643c793d12eeabf422b81f4de80ceea URL: https://github.com/llvm/llvm-project/commit/2804762e2643c793d12eeabf422b81f4de80ceea DIFF: https://github.com/llvm/llvm-project/commit/2804762e2643c793d12eeabf422b81f4de80ceea.diff LO

[clang-tools-extra] 0edaba1 - [clang-tidy] fix crash in altera-id-dependent-backward-branch (#113833)

2024-11-02 Thread via cfe-commits
Author: Julian Schmidt Date: 2024-11-02T12:08:35+01:00 New Revision: 0edaba1b29f8eee011e5fdf387d6c786ec6cb52f URL: https://github.com/llvm/llvm-project/commit/0edaba1b29f8eee011e5fdf387d6c786ec6cb52f DIFF: https://github.com/llvm/llvm-project/commit/0edaba1b29f8eee011e5fdf387d6c786ec6cb52f.diff

[clang-tools-extra] [clang-tidy] fix crash in altera-id-dependent-backward-branch (PR #113833)

2024-11-02 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti closed https://github.com/llvm/llvm-project/pull/113833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Extend bugprone-use-after-move check to handle std::optional::reset() and std::any::reset() (PR #114255)

2024-11-02 Thread Julian Schmidt via cfe-commits
@@ -279,7 +281,7 @@ void UseAfterMoveFinder::getDeclRefs( if (DeclRef && BlockMap->blockContainingStmt(DeclRef) == Block) { // Ignore uses of a standard smart pointer that don't dereference the // pointer. - if (Operator || !isStandardSmartP

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/114661 >From 7b70b905e5a9942f592316b407135975977c93cb Mon Sep 17 00:00:00 2001 From: chomosuke Date: Fri, 16 Aug 2024 13:31:21 + Subject: [PATCH 01/19] Fixing one error --- clang-tools-extra/clangd/ClangdServer

[clang] 67c8b0e - [clang][NFC] Remove an unnecessary variable in CheckExprLifetime.cpp

2024-11-02 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2024-11-02T12:00:18+01:00 New Revision: 67c8b0efbe5c783f39556be2ee841441b50600b5 URL: https://github.com/llvm/llvm-project/commit/67c8b0efbe5c783f39556be2ee841441b50600b5 DIFF: https://github.com/llvm/llvm-project/commit/67c8b0efbe5c783f39556be2ee841441b50600b5.diff LO

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114660)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke edited https://github.com/llvm/llvm-project/pull/114660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114661)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke created https://github.com/llvm/llvm-project/pull/114661 For some other lsp / linters. They will offer a "Ignore this error for this line" code actions for warnings. I find that convenient as I don't have to type the comment myself and copy the name of the diagnost

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114660)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke closed https://github.com/llvm/llvm-project/pull/114660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114660)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke edited https://github.com/llvm/llvm-project/pull/114660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add quick fix to automatically adds NOLINTNEXTLINE comment (PR #114660)

2024-11-02 Thread Richard Li via cfe-commits
https://github.com/chomosuke converted_to_draft https://github.com/llvm/llvm-project/pull/114660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >