[clang] [llvm] [clang][DebugInfo] Emit unified (Itanium) mangled name to structor declarations (PR #154142)

2025-08-20 Thread Michael Buch via cfe-commits
@@ -125,8 +125,11 @@ DEBUGOPT(DebugNameTable, 2, 0, Compatible) /// Whether to use DWARF base address specifiers in .debug_ranges. DEBUGOPT(DebugRangesBaseAddress, 1, 0, Compatible) +/// Whether to add linkage names to constructor/destructor declarations. +DEBUGOPT(DebugStruct

[clang] [clang-format] Add an option to format integer and float literal case (PR #151590)

2025-08-20 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--- NumericLiteralCaseFixer.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [clang-format] Add an option to format integer and float literal case (PR #151590)

2025-08-20 Thread via cfe-commits
@@ -0,0 +1,35 @@ +//===--- NumericLiteralCaseFixer.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[clang] [clang-format] Add an option to format integer and float literal case (PR #151590)

2025-08-20 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--- NumericLiteralCaseFixer.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [clang-format] Add an option to format integer and float literal case (PR #151590)

2025-08-20 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--- NumericLiteralCaseFixer.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [clang-format] Add an option to format integer and float literal case (PR #151590)

2025-08-20 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--- NumericLiteralCaseFixer.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [clang-format] Add an option to format integer and float literal case (PR #151590)

2025-08-20 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--- NumericLiteralCaseFixer.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [clang-format] Add an option to format integer and float literal case (PR #151590)

2025-08-20 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--- NumericLiteralCaseFixer.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [clang-format] Add an option to format integer and float literal case (PR #151590)

2025-08-20 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--- NumericLiteralCaseFixer.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [clang-format] Add an option to format integer and float literal case (PR #151590)

2025-08-20 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--- NumericLiteralCaseFixer.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[clang] [clang] Remove hasValue() check in `RecordExprEvaluator::VisitCXXConstructExpr()` (PR #154610)

2025-08-20 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/154610 >From 50ef42d9f70323c91463bc27e7b14c9a3e126ede Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 20 Aug 2025 22:40:17 +0200 Subject: [PATCH] Test --- clang/lib/AST/ExprConstant.cpp

[clang] [clang] Remove hasValue() check in `RecordExprEvaluator::VisitCXXConstructExpr()` (PR #154610)

2025-08-20 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/154610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo][test] Move debug-info tests from CodeGenCXX to DebugInfo directory (PR #154538)

2025-08-20 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/154538 >From af6ed337ad9bcbe80a7b50d724a5bca37faf7022 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 20 Aug 2025 14:26:44 +0100 Subject: [PATCH 1/4] [clang][DebugInfo][test] Move debug-info tests from CodeG

[clang] [clang-tools-extra] [clang] Include explicit object methods in overload suggestions (PR #154041)

2025-08-20 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/154041 >From 471fa8c60c27a99ce029b1168679a6c5b0271108 Mon Sep 17 00:00:00 2001 From: Mythreya Kuricheti Date: Sat, 16 Aug 2025 15:48:02 -0700 Subject: [PATCH 1/5] [clang] Include explicit object methods in overload

[clang] [compiler-rt] Change compiler-rt lib search path for Hexagon-linux (PR #154530)

2025-08-20 Thread via cfe-commits
@@ -547,11 +548,8 @@ HexagonToolChain::getSmallDataThreshold(const ArgList &Args) { } std::string HexagonToolChain::getCompilerRTPath() const { - SmallString<128> Dir(getDriver().SysRoot); - llvm::sys::path::append(Dir, "usr", "lib"); - if (!SelectedMultilibs.empty()) { -

[clang] [compiler-rt] Change compiler-rt lib search path for Hexagon-linux (PR #154530)

2025-08-20 Thread via cfe-commits
@@ -594,6 +592,9 @@ void HexagonToolChain::getHexagonLibraryPaths(const ArgList &Args, LibPaths.push_back(LibDirCpu); LibPaths.push_back(LibDir); } + if (getTriple().isMusl()) { +LibPaths.push_back(getCompilerRTPath()); + } } quic-k wrote: if

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-08-20 Thread Rana Pratap Reddy via cfe-commits
@@ -0,0 +1,731 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-- -target-cpu gfx1100 %s -emit-llvm -o - | FileCheck %s + +typedef int int8 __attribute__((ext_vector_type(8))); +typedef flo

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-08-20 Thread Rana Pratap Reddy via cfe-commits
@@ -160,6 +163,27 @@ static Value *EmitAMDGCNBallotForExec(CodeGenFunction &CGF, const CallExpr *E, return Call; } +template ranapratap55 wrote: resolved. https://github.com/llvm/llvm-project/pull/140210 ___ cf

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-08-20 Thread Rana Pratap Reddy via cfe-commits
@@ -112,11 +112,12 @@ bool SemaAMDGPU::CheckAMDGCNBuiltinFunctionCall(unsigned BuiltinID, case AMDGPU::BI__builtin_amdgcn_image_load_mip_3d_v4f16_i32: case AMDGPU::BI__builtin_amdgcn_image_load_mip_cube_v4f32_i32: case AMDGPU::BI__builtin_amdgcn_image_load_mip_cube_v4f16

[clang] [clang-tools-extra] [clang] Include explicit object methods in overload suggestions (PR #154041)

2025-08-20 Thread Mythreya Kuricheti via cfe-commits
@@ -1428,10 +1428,18 @@ void ResultBuilder::AddResult(Result R, DeclContext *CurContext, AdjustResultPriorityForDecl(R); + // Account for explicit object parameter + const auto getQualifiers = [&](const CXXMethodDecl *MethodDecl) { MythreyaK wrote: Wasn

[clang] [clang-tools-extra] [clang] Include explicit object methods in overload suggestions (PR #154041)

2025-08-20 Thread Mythreya Kuricheti via cfe-commits
@@ -3410,9 +3418,36 @@ static void AddQualifierToCompletionString(CodeCompletionBuilder &Result, Result.AddTextChunk(Result.getAllocator().CopyString(PrintedNNS)); } +// Sets the function qualifiers completion string by inspecting the explicit +// object +static void AddC

[clang] [clang-tools-extra] [clang] Include explicit object methods in overload suggestions (PR #154041)

2025-08-20 Thread Mythreya Kuricheti via cfe-commits
MythreyaK wrote: Thanks for the review! I have 2 remaining questions, 1. With this PR, these 2 show up as overloads, though not sure if they should be considered overloads. It's convenient, but wanted to double-check. ```cpp void foo2(int a); void foo2(this const S& self, float a

[clang] [clang-tools-extra] [clang] Include explicit object methods in overload suggestions (PR #154041)

2025-08-20 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/154041 >From 471fa8c60c27a99ce029b1168679a6c5b0271108 Mon Sep 17 00:00:00 2001 From: Mythreya Kuricheti Date: Sat, 16 Aug 2025 15:48:02 -0700 Subject: [PATCH 1/4] [clang] Include explicit object methods in overload

[clang] [Clang][Codegen][NFC] Apply rule of three to some classes (PR #154671)

2025-08-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Shafik Yaghmour (shafik) Changes Static analysis flagged these classes as having implemented the destructor but not applying rule of three. This could lead to accidental misuse and so it makes sense to apply it. --- Full diff: https:

[clang] [Clang][Codegen][NFC] Apply rule of three to some classes (PR #154671)

2025-08-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes Static analysis flagged these classes as having implemented the destructor but not applying rule of three. This could lead to accidental misuse and so it makes sense to apply it. --- Full diff: https://gi

[clang] [Clang][Codegen][NFC] Apply rule of three to some classes (PR #154671)

2025-08-20 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik created https://github.com/llvm/llvm-project/pull/154671 Static analysis flagged these classes as having implemented the destructor but not applying rule of three. This could lead to accidental misuse and so it makes sense to apply it. >From 41d7218a6586834482ea6

[clang] Do not trigger -Wmissing-noreturn on lambdas prior to C++23 (PR #154545)

2025-08-20 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/154545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3baddbb - Do not trigger -Wmissing-noreturn on lambdas prior to C++23 (#154545)

2025-08-20 Thread via cfe-commits
Author: Carlos Galvez Date: 2025-08-21T07:30:57+02:00 New Revision: 3baddbbb0a698102073635f7559336f92bc7fe83 URL: https://github.com/llvm/llvm-project/commit/3baddbbb0a698102073635f7559336f92bc7fe83 DIFF: https://github.com/llvm/llvm-project/commit/3baddbbb0a698102073635f7559336f92bc7fe83.diff

[clang] [Clang][X86] Replace F16C `vcvtph2ps/256` intrinsics with `(convert|shuffle)vector` builtins (PR #152911)

2025-08-20 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Thank you for the quick response! Will try that out. https://github.com/llvm/llvm-project/pull/152911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-08-20 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,731 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-- -target-cpu gfx1100 %s -emit-llvm -o - | FileCheck %s + +typedef int int8 __attribute__((ext_vector_type(8))); +typedef flo

[clang] [clang-tools-extra] [clang] Include explicit object methods in overload suggestions (PR #154041)

2025-08-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/154041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[Utils] Add new --update-tests flag to llvm-lit" (PR #153821)

2025-08-20 Thread Luke Lau via cfe-commits
lukel97 wrote: > > > > Thanks for relanding this, it's super useful. It seems to rerun > > > > update_test_[checks.py](http://checks.py) on tests that weren't > > > > failing, which can cause some spurious diffs that are just UTC regens. > > > > Is it possible to restrict this to only update t

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-20 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code linter clang-tidy found issues in your code. :warning: You can test this locally with the following command: ``bash git diff -U0 origin/main..HEAD -- clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp | python3 clang-to

[clang] [clang-tools-extra] [clang] Include explicit object methods in overload suggestions (PR #154041)

2025-08-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks for the update, just minor comments remaining and then I think this is good to merge. https://github.com/llvm/llvm-project/pull/154041 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [clang-tools-extra] [clang] Include explicit object methods in overload suggestions (PR #154041)

2025-08-20 Thread Nathan Ridge via cfe-commits
@@ -413,6 +413,37 @@ class ResultBuilder { bool IsImpossibleToSatisfy(const NamedDecl *ND) const; //@} }; + +void AddFunctionTypeQuals(CodeCompletionBuilder &Result, HighCommander4 wrote: nit: can we move this closer to where it's used? (we can make it `st

[clang] [clang-tools-extra] [clang] Include explicit object methods in overload suggestions (PR #154041)

2025-08-20 Thread Nathan Ridge via cfe-commits
@@ -3410,9 +3418,36 @@ static void AddQualifierToCompletionString(CodeCompletionBuilder &Result, Result.AddTextChunk(Result.getAllocator().CopyString(PrintedNNS)); } +// Sets the function qualifiers completion string by inspecting the explicit +// object +static void AddC

[clang] [llvm] Reland "[Utils] Add new --update-tests flag to llvm-lit" (PR #153821)

2025-08-20 Thread Henrik G. Olsson via cfe-commits
hnrklssn wrote: > > > Thanks for relanding this, it's super useful. It seems to rerun > > > update_test_[checks.py](http://checks.py) on tests that weren't failing, > > > which can cause some spurious diffs that are just UTC regens. Is it > > > possible to restrict this to only update the test

[clang] [clang-format] Add option AllowShortRecordsOnASingleLine (PR #154580)

2025-08-20 Thread via cfe-commits
=?utf-8?q?Tomáš?= Slanina Message-ID: In-Reply-To: owenca wrote: Looks like we got an inconsistency in formatting short (including empty) records. With 20.1.8 we have: ``` $ cat a.cc struct foo {}; struct bar { int i; } $ clang-format a.cc struct foo {}; struct bar { int i; } ``` Have you i

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From 9c1c60147968df4d411f013378618b5d72313456 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 02:02:16 +0300 Subject: [PATCH 01/30] test clang-tidy violation --- .../clang-tidy/performan

[clang] [llvm] Reland "[Utils] Add new --update-tests flag to llvm-lit" (PR #153821)

2025-08-20 Thread Luke Lau via cfe-commits
lukel97 wrote: > > Thanks for relanding this, it's super useful. It seems to rerun > > update_test_[checks.py](http://checks.py) on tests that weren't failing, > > which can cause some spurious diffs that are just UTC regens. Is it > > possible to restrict this to only update the tests that fa

[clang] [WIP][AMDGPU] Support for type inferring image load/store builtins for AMDGPU (PR #140210)

2025-08-20 Thread Rana Pratap Reddy via cfe-commits
@@ -0,0 +1,731 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-- -target-cpu gfx1100 %s -emit-llvm -o - | FileCheck %s + +typedef int int8 __attribute__((ext_vector_type(8))); +typedef flo

[clang] [clang-format] Add option to omit wrapping for empty records (PR #151970)

2025-08-20 Thread via cfe-commits
=?utf-8?q?Tomáš?= Slanina , =?utf-8?q?Tomáš?= Slanina , =?utf-8?q?Tomáš?= Slanina , =?utf-8?q?Tomáš?= Slanina , =?utf-8?q?Tomáš?= Slanina , =?utf-8?q?Tomáš?= Slanina , =?utf-8?q?Tomáš?= Slanina , =?utf-8?q?Tomáš?= Slanina , =?utf-8?q?Tomáš?= Slanina , =?utf-8?q?Tomáš?= Slanina Message-ID: In-Reply

[clang] [CIR][Dialect] Add SourceLangAttr (PR #152511)

2025-08-20 Thread via cfe-commits
seven-mile wrote: @bcardosolopes Yes, I don't have access, please help me get the patch committed😉. CI test should be triggerred now. https://github.com/llvm/llvm-project/pull/152511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
@@ -47,6 +47,7 @@ namespace clang { DIAG_SIZE_ANALYSIS = 100, DIAG_SIZE_REFACTORING = 1000, DIAG_SIZE_INSTALLAPI= 100, + DIAG_SIZE_CODEGEN = 10, Sirraide wrote: Maybe preallocate more than 10 so we don’t have to bump t

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
@@ -0,0 +1,26 @@ +//==--- DiagnosticCodeGenKinds.td - CodeGen Diagnostics ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
@@ -30,6 +30,7 @@ def CLASS_REMARK: DiagClass; def CLASS_WARNING : DiagClass; def CLASS_EXTENSION : DiagClass; def CLASS_ERROR : DiagClass; +def CLASS_TRAP : DiagClass; Sirraide wrote: Hmm, I wonder if we really need a new diagnostic class for t

[clang] [CIR][Dialect] Add SourceLangAttr (PR #152511)

2025-08-20 Thread via cfe-commits
https://github.com/seven-mile updated https://github.com/llvm/llvm-project/pull/152511 >From f501e18cd33bf54d9c91dd772fb3db6f7ee52335 Mon Sep 17 00:00:00 2001 From: seven-mile Date: Thu, 7 Aug 2025 14:10:08 + Subject: [PATCH 1/5] [CIR][Dialect] Add SourceLangAttr --- .../include/clang/CIR

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
@@ -1813,6 +1813,7 @@ void ScalarExprEmitter::EmitBinOpCheck( SanitizerHandler Check; SmallVector StaticData; SmallVector DynamicData; + std::unique_ptr RTDB = nullptr; Sirraide wrote: Actually, this is in a function—I thought it was at class scope for

[clang] [Clang][X86] Replace F16C `vcvtph2ps/256` intrinsics with `(convert|shuffle)vector` builtins (PR #152911)

2025-08-20 Thread Phoebe Wang via cfe-commits
phoebewang wrote: We don't guarantee builtins compatibility. You should use intrinsic `_mm256_mask_cvtph_ps` instead. Please taking care of the difference in arguments order. https://github.com/llvm/llvm-project/pull/152911 ___ cfe-commits mailing li

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
@@ -1534,6 +1535,72 @@ inline DiagnosticBuilder DiagnosticsEngine::Report(unsigned DiagID) { return Report(SourceLocation(), DiagID); } +//===--===// +// RuntimeTrapDiagnosticBuilder +//===-

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/154618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
@@ -33,6 +33,7 @@ #include "clang/AST/StmtVisitor.h" #include "clang/Basic/Builtins.h" #include "clang/Basic/CodeGenOptions.h" +#include "clang/Basic/DiagnosticParse.h" Sirraide wrote: I don’t think we should be including `DiagnosticParse.h` in codegen. https

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
@@ -1824,6 +1825,12 @@ class CodeGenModule : public CodeGenTypeCache { return PAlign; } + /// Helper function to construct a RuntimeTrapDiagnosticBuilder + [[nodiscard]] std::unique_ptr + RuntimeDiag(unsigned DiagID) { +return std::make_unique(&getDiags(), DiagID)

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
@@ -1813,6 +1813,7 @@ void ScalarExprEmitter::EmitBinOpCheck( SanitizerHandler Check; SmallVector StaticData; SmallVector DynamicData; + std::unique_ptr RTDB = nullptr; Sirraide wrote: I don’t think this is the right place to cache and reuse these. If w

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
@@ -30,4 +30,5 @@ #include "clang/Basic/DiagnosticAnalysisKinds.inc" #include "clang/Basic/DiagnosticRefactoringKinds.inc" #include "clang/Basic/DiagnosticInstallAPIKinds.inc" +#include "clang/Basic/DiagnosticCodeGenKinds.inc" Sirraide wrote: I don’t really li

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
https://github.com/Sirraide commented: Reusing the existing diagnostics machinery for this sgtm. https://github.com/llvm/llvm-project/pull/154618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-20 Thread via cfe-commits
@@ -3721,7 +3722,8 @@ static void emitCheckHandlerCall(CodeGenFunction &CGF, void CodeGenFunction::EmitCheck( ArrayRef> Checked, SanitizerHandler CheckHandler, ArrayRef StaticArgs, -ArrayRef DynamicArgs) { +ArrayRef DynamicArgs, +std::unique_ptr RTDB) { ---

[clang] [Headers][X86] Allow integer/fp absolute intrinsics to be used in constexpr (PR #154662)

2025-08-20 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,h -- clang/lib/Headers/avx2intrin.h clang/lib/Headers/avx5

[clang] [Headers][X86] Allow integer/fp absolute intrinsics to be used in constexpr (PR #154662)

2025-08-20 Thread Ye Tian via cfe-commits
https://github.com/TianYe717 created https://github.com/llvm/llvm-project/pull/154662 This PR fixes [issue](https://github.com/llvm/llvm-project/issues/153556) >From 0bc4ac3e846ab621cee5a7686e4d313ccd7889b7 Mon Sep 17 00:00:00 2001 From: Ye Tian <939808...@qq.com> Date: Thu, 21 Aug 2025 11:01:5

[clang] [Headers][X86] Allow FMA3/FMA4 vector intrinsics to be used in constexpr (PR #154558)

2025-08-20 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/154558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Diagnostics] Prevent incorrect clang-format reformatting in some headers related to Clang diagnostics (PR #154628)

2025-08-20 Thread via cfe-commits
@@ -14,6 +14,7 @@ #ifndef LLVM_CLANG_BASIC_ALLDIAGNOSTICS_H #define LLVM_CLANG_BASIC_ALLDIAGNOSTICS_H +// clang-format off Sirraide wrote: Imo the ‘fix’ for this is to just reformat this section of the file because the formatting is... all sorts of wrong her

[clang-tools-extra] [clang-tidy] Add `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-08-20 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook updated https://github.com/llvm/llvm-project/pull/150791 >From 20eb165f1abd9bf7976a2c401579a1284258e13e Mon Sep 17 00:00:00 2001 From: Victor Chernyakin Date: Sat, 26 Jul 2025 11:52:19 -0700 Subject: [PATCH 1/6] [clang-tidy] Stop ignoring `-std` argument in `check

[clang-tools-extra] [clang-reorder-fields] Support designated initializers (PR #142150)

2025-08-20 Thread Alexander Shaposhnikov via cfe-commits
alexander-shaposhnikov wrote: I've added a couple of comments, but overall this looks reasonable to me, thank your for your patience https://github.com/llvm/llvm-project/pull/142150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [CIR] Handle FunctionToPointerDecay casts (#153657) (PR #154060)

2025-08-20 Thread Justin Riddell via cfe-commits
Arghnews wrote: @andykaylor thank you for the suggestion, have rebased and rerun with latest and it works fine now Have updated the tests - I wasn't sure how closely the test should watch the cir output (whether too close a match is an issue, or not), so please check. I force pushed anyway so

[clang] [CIR] Handle FunctionToPointerDecay casts (#153657) (PR #154060)

2025-08-20 Thread Justin Riddell via cfe-commits
@@ -0,0 +1,25 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o - | FileCheck %s Arghnews wrote: Thanks for the suggestion, rebased and it works now https://github.com/llvm/llvm-project/pull/154060 ___

[clang] [CIR] Handle FunctionToPointerDecay casts (#153657) (PR #154060)

2025-08-20 Thread Justin Riddell via cfe-commits
https://github.com/Arghnews updated https://github.com/llvm/llvm-project/pull/154060 >From c3ef9b7dbad67be0fa24b228dd445a4b8a28d280 Mon Sep 17 00:00:00 2001 From: Justin Riddell Date: Thu, 21 Aug 2025 02:59:44 +0100 Subject: [PATCH] [CIR] Handle FunctionToPointerDecay casts (#153657) Add upstr

[clang] [CIR][NFC] Use Op::create to create CIR operations in CIRGenBuilder (PR #154540)

2025-08-20 Thread Sirui Mu via cfe-commits
Lancern wrote: > LGTM! Any chance you could backport this to incubator? Yes, I will backport this later. https://github.com/llvm/llvm-project/pull/154540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [CIR][NFC] Use Op::create to create CIR operations in CIRGenBuilder (PR #154540)

2025-08-20 Thread Sirui Mu via cfe-commits
https://github.com/Lancern closed https://github.com/llvm/llvm-project/pull/154540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 91569fa - [CIR][NFC] Use Op::create to create CIR operations in CIRGenBuilder (#154540)

2025-08-20 Thread via cfe-commits
Author: Sirui Mu Date: 2025-08-21T09:46:45+08:00 New Revision: 91569fa0303cd4a0213380da2b1fa63539833af9 URL: https://github.com/llvm/llvm-project/commit/91569fa0303cd4a0213380da2b1fa63539833af9 DIFF: https://github.com/llvm/llvm-project/commit/91569fa0303cd4a0213380da2b1fa63539833af9.diff LOG:

[clang] [llvm] Singleton hack of fixing static initialisation order ficaso (PR #154541)

2025-08-20 Thread via cfe-commits
https://github.com/Dalmurii updated https://github.com/llvm/llvm-project/pull/154541 >From 4bc8f7c83dfd53cc1984d722e78fbc1f19fbf991 Mon Sep 17 00:00:00 2001 From: ae2f Date: Wed, 20 Aug 2025 22:26:09 +0900 Subject: [PATCH 1/5] Fix of [Static Initialization Order Fiasco Issue](https://github.co

[clang] [llvm] Singleton hack of fixing static initialisation order ficaso (PR #154541)

2025-08-20 Thread via cfe-commits
Dalmurii wrote: Opening another PR might be a proper fix. https://github.com/llvm/llvm-project/pull/154541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [mlir] [openmp] [NFC][CMake] quote ${CMAKE_SYSTEM_NAME} consistently (PR #154537)

2025-08-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-s390x-linux` running on `systemz-1` while building `clang-tools-extra,clang,compiler-rt,libcxx,libcxxabi,libunwind,lldb,llvm,mlir,offload,openmp,third-party` at step 5 "ninja check 1". Full details are available at: ht

[libclc] [libclc] Only create a target per each compile command for cmake MSVC generator (PR #154479)

2025-08-20 Thread Wenju He via cfe-commits
https://github.com/wenju-he edited https://github.com/llvm/llvm-project/pull/154479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Only create a target per each compile command for cmake MSVC generator (PR #154479)

2025-08-20 Thread Wenju He via cfe-commits
@@ -132,6 +124,33 @@ function(link_bc) ) endfunction() +# Create a custom target for each bitcode file, which is the output of a custom +# command. This is required for parallel compilation of the custom commands that +# generate the bitcode files when using the CMake MSVC

[libclc] [libclc] Only create a target per each compile command for cmake MSVC generator (PR #154479)

2025-08-20 Thread Wenju He via cfe-commits
@@ -335,19 +348,28 @@ function(add_libclc_builtin_set) endif() endforeach() + set( builtins_comp_lib_tgt builtins.comp.${ARG_ARCH_SUFFIX} ) + if ( CMAKE_GENERATOR MATCHES "Visual Studio" ) wenju-he wrote: > Perhaps a comment above this to explain what

[clang] [llvm] [X86] Set .llvmbc and .llvmcmd to exclude sections (PR #151910)

2025-08-20 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I think `-ffat-lto-objects` uses exclude metadata, but I'm not overly > > familiar with what that's intended to do. > > Effect of exclude kind: > https://discourse.llvm.org/t/end-to-end-fembed-bitcode-llvmbc-and-llvmcmd/56265/14?u=haohaiwen I know what the exclude option th

[libclc] [libclc] Only create a target per each compile command for cmake MSVC generator (PR #154479)

2025-08-20 Thread Wenju He via cfe-commits
https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/154479 >From 75b5f46b2858b399482082eabd1388167aaa58e4 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Wed, 20 Aug 2025 07:57:54 +0200 Subject: [PATCH 1/3] [libclc] Only create a target per each compile command for cmak

[clang] [llvm] [X86] Set .llvmbc and .llvmcmd to exclude sections (PR #151910)

2025-08-20 Thread Haohai Wen via cfe-commits
HaohaiWen wrote: > I think `-ffat-lto-objects` uses exclude metadata, but I'm not overly > familiar with what that's intended to do. Effect of exclude kind: https://discourse.llvm.org/t/end-to-end-fembed-bitcode-llvmbc-and-llvmcmd/56265/14?u=haohaiwen https://github.com/llvm/llvm-project/pull

[clang] 8cb6bfe - [RISCV] Reduce ManualCodeGen for RVV intrinsics with rounding mode. NFC

2025-08-20 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2025-08-20T17:53:46-07:00 New Revision: 8cb6bfe05a26e40dee21d6107655baacc03540a9 URL: https://github.com/llvm/llvm-project/commit/8cb6bfe05a26e40dee21d6107655baacc03540a9 DIFF: https://github.com/llvm/llvm-project/commit/8cb6bfe05a26e40dee21d6107655baacc03540a9.diff

[libclc] [libclc] Only create a target per each compile command for cmake MSVC generator (PR #154479)

2025-08-20 Thread Wenju He via cfe-commits
https://github.com/wenju-he edited https://github.com/llvm/llvm-project/pull/154479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Do not trigger -Wmissing-noreturn on lambdas prior to C++23 (PR #154545)

2025-08-20 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/154545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add CIR vtable attribute (PR #154415)

2025-08-20 Thread Bruno Cardoso Lopes via cfe-commits
@@ -496,6 +496,72 @@ def CIR_GlobalViewAttr : CIR_Attr<"GlobalView", "global_view", [ }]; } +//===--===// +// VTableAttr +//===--===// + +

[clang] [clang] Upstream `clang::CodeGen::getConstantSignedPointer` (PR #154453)

2025-08-20 Thread Ahmed Bougacha via cfe-commits
@@ -126,6 +126,12 @@ uint16_t getPointerAuthDeclDiscriminator(CodeGenModule &CGM, GlobalDecl GD); uint16_t getPointerAuthTypeDiscriminator(CodeGenModule &CGM, QualType FunctionType); +/// Return a signed constant pointer. +llvm::Consta

[clang] [clang] Upstream `clang::CodeGen::getConstantSignedPointer` (PR #154453)

2025-08-20 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha approved this pull request. We should be able to eventually remove this one, `getPointerAuthDeclDiscriminator`, and `getPointerAuthTypeDiscriminator`, which gradually got picked up, it looks like. For this one specifically, we'd want to have a way of doing the

[clang] [clang] Upstream `clang::CodeGen::getConstantSignedPointer` (PR #154453)

2025-08-20 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/154453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] do not diagnose array types within implicit instantiations of a template (PR #132924)

2025-08-20 Thread St. Muench via cfe-commits
stmuench wrote: @5chmidti @vbvictor many thanks for you suggestions, I incorporated all of them https://github.com/llvm/llvm-project/pull/132924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [CIR] Upstream GotoSolver pass (PR #154596)

2025-08-20 Thread Bruno Cardoso Lopes via cfe-commits
@@ -0,0 +1,52 @@ +#include "PassDetail.h" bcardosolopes wrote: You need LLVM header here! https://github.com/llvm/llvm-project/pull/154596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [CIR] Add CIR vtable attribute (PR #154415)

2025-08-20 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM, minor suggestion https://github.com/llvm/llvm-project/pull/154415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add CIR vtable attribute (PR #154415)

2025-08-20 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/154415 >From f5e0612b8ce090ac7f075307c802f5e4e3704d50 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Mon, 18 Aug 2025 13:51:11 -0700 Subject: [PATCH 1/5] [CIR] Add CIR vtable attribute This adds the #cir.vtable a

[clang-tools-extra] [clang-tidy] Add `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-08-20 Thread Victor Chernyakin via cfe-commits
@@ -374,15 +373,23 @@ def parse_arguments() -> Tuple[argparse.Namespace, List[str]]: parser.add_argument( "-std", type=csv, -default=["c++11-or-later"], +default=None, help="Passed to clang. Special -or-later values are expanded.",

[clang] [CIR] Add CIR vtable attribute (PR #154415)

2025-08-20 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/154415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream GotoSolver pass (PR #154596)

2025-08-20 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/154596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream GotoSolver pass (PR #154596)

2025-08-20 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM after nit https://github.com/llvm/llvm-project/pull/154596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream GotoSolver pass (PR #154596)

2025-08-20 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/154596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Singleton hack of fixing static initialisation order ficaso (PR #154541)

2025-08-20 Thread Eli Friedman via cfe-commits
@@ -30,18 +30,18 @@ constexpr StringRef AssumptionAttrKey = "llvm.assume"; /// A set of known assumption strings that are accepted without warning and /// which can be recommended as typo correction. -LLVM_ABI extern StringSet<> KnownAssumptionStrings; +LLVM_ABI extern StringS

[clang] [llvm] Singleton hack of fixing static initialisation order ficaso (PR #154541)

2025-08-20 Thread Eli Friedman via cfe-commits
@@ -160,7 +160,7 @@ inlineCostFeatureToMlFeature(InlineCostFeatureIndex Feature) { return static_cast(static_cast(Feature)); } -LLVM_ABI extern std::vector FeatureMap; +LLVM_ABI extern std::vector &getFeatureMap(); efriedma-quic wrote: ```suggestion LLVM_A

[clang] [CIR][NFC] Use Op::create to create CIR operations in CIRGenBuilder (PR #154540)

2025-08-20 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM! Any chance you could backport this to incubator? https://github.com/llvm/llvm-project/pull/154540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [CIR] Add CIR vtable attribute (PR #154415)

2025-08-20 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/154415 >From f5e0612b8ce090ac7f075307c802f5e4e3704d50 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Mon, 18 Aug 2025 13:51:11 -0700 Subject: [PATCH 1/4] [CIR] Add CIR vtable attribute This adds the #cir.vtable a

[clang] [CIR] Run LoweringPrepare pass only for non CIR output (PR #154107)

2025-08-20 Thread Bruno Cardoso Lopes via cfe-commits
@@ -110,9 +110,10 @@ class CIRGenConsumer : public clang::ASTConsumer { if (!FEOptions.ClangIRDisablePasses) { // Setup and run CIR pipeline. + bool EnableLoweringPrepare = Action != CIRGenAction::OutputType::EmitCIR; bcardosolopes wrote: Altho

[clang] [clang-tools-extra] [lldb] [lldb] Add missing case statements for SubstBuiltinTemplatePack (PR #154606)

2025-08-20 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/154606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >