[clang] [clang] Post-commit review for #150028 (PR #155351)

2025-08-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/155351 >From df9f96c18433d509abba6b7b3a8128b5510fe824 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 26 Aug 2025 05:57:47 +0200 Subject: [PATCH] [clang] Post-commit review for #150028 1) Ret

[clang] [clang] Create PointerToBoolean casts for C casts (PR #155368)

2025-08-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/155368 >From cfe28648d256469e871e79fe44bad7eb1819aaa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 26 Aug 2025 09:

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-26 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. LGTM, but please address others comments https://github.com/llvm/llvm-project/pull/154618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] Add error check for HeuristicResolver (PR #155561)

2025-08-26 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK edited https://github.com/llvm/llvm-project/pull/155561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][Hurd] Enable __float128 support on x86 on Hurd (PR #153925)

2025-08-26 Thread Pino Toscano via cfe-commits
pinotree wrote: Hi @MaskRay, would it be possible to take a look at this? Thanks in advance! https://github.com/llvm/llvm-project/pull/153925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] Add error check for HeuristicResolver (PR #155561)

2025-08-26 Thread Mythreya Kuricheti via cfe-commits
@@ -31,6 +36,69 @@ template using ResolveFnT = std::function( const HeuristicResolver *, InputNode)>; +struct DiagsConsumer : DiagnosticConsumer { + struct PrettyDiagnostic { +unsigned int ID; +DiagnosticsEngine::Level DiagLevel; +llvm::SmallString<64> Messag

[clang] Add error check for HeuristicResolver (PR #155561)

2025-08-26 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/155561 >From e2e72a40e9833a28d79221a3f1e9acd616c068ec Mon Sep 17 00:00:00 2001 From: Mythreya Kuricheti Date: Tue, 26 Aug 2025 23:19:26 -0700 Subject: [PATCH 1/2] Add error check for HeuristicResolver --- .../unitt

[clang] [clang] Make sure EvalInfo pointer isn't null (PR #155563)

2025-08-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes It can be null, when called via CheckICE(). Accidentally introduced via #119366 Fixes #155507 --- Full diff: https://github.com/llvm/llvm-project/pull/155563.diff 2 Files Affected: - (modified) clang/lib/

[clang] [Clang][Driver][Hurd] Enable __float128 support on x86 on Hurd (PR #153925)

2025-08-26 Thread Pino Toscano via cfe-commits
https://github.com/pinotree updated https://github.com/llvm/llvm-project/pull/153925 >From aacf49110820029b101196bad3b81d82c37aa5fe Mon Sep 17 00:00:00 2001 From: Pino Toscano Date: Sat, 16 Aug 2025 06:56:17 +0200 Subject: [PATCH] [Clang][Driver][Hurd] Enable __float128 support on x86 on Hurd

[clang] [clang] Make sure EvalInfo pointer isn't null (PR #155563)

2025-08-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/155563 It can be null, when called via CheckICE(). Accidentally introduced via #119366 Fixes #155507 >From c9fea1a7b715623f6e50aa5341232208cd441de2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date:

[clang] Add error check for HeuristicResolver (PR #155561)

2025-08-26 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/155561 >From e2e72a40e9833a28d79221a3f1e9acd616c068ec Mon Sep 17 00:00:00 2001 From: Mythreya Kuricheti Date: Tue, 26 Aug 2025 23:19:26 -0700 Subject: [PATCH] Add error check for HeuristicResolver --- .../unittests

[clang] Add error check for HeuristicResolver (PR #155561)

2025-08-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mythreya Kuricheti (MythreyaK) Changes Fixes #155545. --- Full diff: https://github.com/llvm/llvm-project/pull/155561.diff 1 Files Affected: - (modified) clang/unittests/Sema/HeuristicResolverTest.cpp (+73-2) ``diff diff --gi

[clang] Add error check for HeuristicResolver (PR #155561)

2025-08-26 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK created https://github.com/llvm/llvm-project/pull/155561 Fixes #155545. >From 7304a9afa9b9379e395f1dc7a0e5f6a331b0e455 Mon Sep 17 00:00:00 2001 From: Mythreya Kuricheti Date: Tue, 26 Aug 2025 23:19:26 -0700 Subject: [PATCH] Add error check for HeuristicResolver --

[clang-tools-extra] [clang-doc] lower filename length limit by 5 (PR #155511)

2025-08-26 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/155511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Shard out SemaTests into their own binary (PR #155548)

2025-08-26 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Additional context can be found in the discussion starting at https://github.com/llvm/llvm-project/pull/134195#issuecomment-3020305073 https://github.com/llvm/llvm-project/pull/155548 ___ cfe-commits mailing list cfe-commits@list

[clang] [llvm] Openmp 6.0 allow default clause on the target directive (PR #154942)

2025-08-26 Thread Shilei Tian via cfe-commits
@@ -0,0 +1,51 @@ + +// RUN: %clang_cc1 -verify -fopenmp -fopenmp-version=60 -DOMP60 %s -Wuninitialized + +// RUN: %clang_cc1 -verify -fopenmp-simd -fopenmp-version=60 -DOMP60 %s -Wuninitialized + +// RUN: %clang_cc1 -verify -fopenmp -fopenmp-version=52 -DOMP52 %s -Wuninitialize

[clang] [clang][Sema] Shard out SemaTests into their own binary (PR #155548)

2025-08-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nathan Ridge (HighCommander4) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/155548.diff 1 Files Affected: - (modified) clang/unittests/Sema/CMakeLists.txt (+4-1) ``diff diff --git a/clang/unittests/Sema/CM

[clang] [clang][Sema] Shard out SemaTests into their own binary (PR #155548)

2025-08-26 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/155548 None >From 893813ce1e131f5a2948f0ab9745c87b67baf33e Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Wed, 27 Aug 2025 00:28:40 -0400 Subject: [PATCH] [clang][Sema] Shard out SemaTests into their own bin

[clang-tools-extra] [clangd] Add option: --limit-hover-contents (PR #155105)

2025-08-26 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Some high-level feedback: 1. Hovers contain a variety of types of content (types, values, definitions, initializers, documentation, etc.). This limit applies specifically to macro expansions; therefore, it should have a more specific name, e.g. "limit hover macro expans

[clang-tools-extra] [clangd] Retrieve documentation for member function instance from index (PR #153337)

2025-08-26 Thread Nathan Ridge via cfe-commits
@@ -1887,7 +1887,19 @@ class CodeCompleteFlow { for (auto &Cand : C.first) { if (Cand.SemaResult && Cand.SemaResult->Kind == CodeCompletionResult::RK_Declaration) { -auto ID = clangd::getSymbolID(Cand.SemaResult->getDeclaration()); +

[clang] [clang-format] allow short function body on a single line (PR #151428)

2025-08-26 Thread Lidong Yan via cfe-commits
https://github.com/brandb97 updated https://github.com/llvm/llvm-project/pull/151428 >From 3a0a246803cdf295c99765bfffd5905c2a94ab38 Mon Sep 17 00:00:00 2001 From: Lidong Yan Date: Tue, 26 Aug 2025 19:40:05 +0800 Subject: [PATCH] [clang-format] allow short function body on a single line When se

[clang-tools-extra] [clangd] Retrieve documentation for member function instance from index (PR #153337)

2025-08-26 Thread Nathan Ridge via cfe-commits
@@ -1887,7 +1887,19 @@ class CodeCompleteFlow { for (auto &Cand : C.first) { if (Cand.SemaResult && Cand.SemaResult->Kind == CodeCompletionResult::RK_Declaration) { -auto ID = clangd::getSymbolID(Cand.SemaResult->getDeclaration()); +

[clang-tools-extra] [clangd] Retrieve documentation for member function instance from index (PR #153337)

2025-08-26 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/153337 >From e0fac464e943ae144ecf70664288af9dbd3f05b5 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 12 Aug 2025 22:54:32 -0400 Subject: [PATCH] [clangd] Retrieve documentation for member function instan

[clang] [llvm] [AMDGPU][Clang] Allow amdgpu-waves-per-eu attribute to lower target occupancy range (PR #138284)

2025-08-26 Thread Shilei Tian via cfe-commits
shiltian wrote: Looking at this now, it doesn't seem the same as it was at the start. For the latest changes, I think @arsenm made it clear that waves-per-eu values should always give way to the values calculated from flat-workgroup-size if they differ, since flat-workgroup-size is ABI and wav

[clang-tools-extra] f44eaf4 - [clang][HeuristicResolver] Resolve explicit object parameter to enclosing record type (#155143)

2025-08-26 Thread via cfe-commits
Author: Mythreya Kuricheti Date: 2025-08-26T23:54:50-04:00 New Revision: f44eaf47dc1357959d14cbf5f278c82e554689b2 URL: https://github.com/llvm/llvm-project/commit/f44eaf47dc1357959d14cbf5f278c82e554689b2 DIFF: https://github.com/llvm/llvm-project/commit/f44eaf47dc1357959d14cbf5f278c82e554689b2.

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/155143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/155143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Nathan Ridge via cfe-commits
@@ -41,7 +41,7 @@ template void expectResolution(llvm::StringRef Code, ResolveFnT ResolveFn, const InputMatcher &IM, const OutputMatchers &...OMS) { - auto TU = tooling::buildASTFromCodeWithArgs(Code, {"-std=c++23"}); + auto TU = tooling::buildASTFromCod

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Mythreya Kuricheti via cfe-commits
@@ -41,7 +41,7 @@ template void expectResolution(llvm::StringRef Code, ResolveFnT ResolveFn, const InputMatcher &IM, const OutputMatchers &...OMS) { - auto TU = tooling::buildASTFromCodeWithArgs(Code, {"-std=c++23"}); + auto TU = tooling::buildASTFromCod

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/155143 >From c1cdb3909c0bb55ce21d339f087c1e38616fec3f Mon Sep 17 00:00:00 2001 From: Mythreya Kuricheti Date: Sat, 23 Aug 2025 23:57:18 -0700 Subject: [PATCH 1/8] [clang] Heuristic resolution for explicit object par

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 commented: Updates look good to me, just one outstanding issue. https://github.com/llvm/llvm-project/pull/155143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Nathan Ridge via cfe-commits
@@ -41,7 +41,7 @@ template void expectResolution(llvm::StringRef Code, ResolveFnT ResolveFn, const InputMatcher &IM, const OutputMatchers &...OMS) { - auto TU = tooling::buildASTFromCodeWithArgs(Code, {"-std=c++23"}); + auto TU = tooling::buildASTFromCod

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/155143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] VisitCallExpr constexpr immediate shifts (#154293) (PR #155542)

2025-08-26 Thread Justin Riddell via cfe-commits
https://github.com/Arghnews edited https://github.com/llvm/llvm-project/pull/155542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] VisitCallExpr constexpr immediate shifts (#154293) (PR #155542)

2025-08-26 Thread Justin Riddell via cfe-commits
@@ -11644,64 +11679,181 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr *E) { for (unsigned EltNum = 0; EltNum < SourceLen; ++EltNum) { APSInt LHS = SourceLHS.getVectorElt(EltNum).getInt(); - APSInt RHS = SourceRHS.getVectorElt(EltNum).getInt(); -

[clang] [Headers][X86] VisitCallExpr constexpr immediate shifts (#154293) (PR #155542)

2025-08-26 Thread Justin Riddell via cfe-commits
https://github.com/Arghnews updated https://github.com/llvm/llvm-project/pull/155542 >From 759f06ff21d819986603ca50b2ba213ce68d3368 Mon Sep 17 00:00:00 2001 From: Justin Riddell Date: Wed, 27 Aug 2025 04:04:37 +0100 Subject: [PATCH] [Headers][X86] VisitCallExpr constexpr immediate shifts (#154

[clang] [Headers][X86] VisitCallExpr constexpr immediate shifts (#154293) (PR #155542)

2025-08-26 Thread Justin Riddell via cfe-commits
https://github.com/Arghnews updated https://github.com/llvm/llvm-project/pull/155542 >From 409524a751457ca230fd70daeca107b339e3bb82 Mon Sep 17 00:00:00 2001 From: Justin Riddell Date: Wed, 27 Aug 2025 03:58:29 +0100 Subject: [PATCH] [Headers][X86] VisitCallExpr constexpr immediate shifts (#154

[clang] [Headers][X86] VisitCallExpr constexpr immediate shifts (#154293) (PR #155542)

2025-08-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,c,cpp -- clang/test/CodeGen/X86/shift-immediate-constexpr.

[clang] [Headers][X86] VisitCallExpr constexpr immediate shifts (#154293) (PR #155542)

2025-08-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Justin Riddell (Arghnews) Changes Implement VectorExprEvaluator::VisitCallExpr constexpr support for left, right, arithmetic shift for MMX/SSE/AVX2/AVX512 intrinsics ### **NOTE**: currently incomplete, asking a question with what I've got

[clang] [Headers][X86] VisitCallExpr constexpr immediate shifts (#154293) (PR #155542)

2025-08-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Justin Riddell (Arghnews) Changes Implement VectorExprEvaluator::VisitCallExpr constexpr support for left, right, arithmetic shift for MMX/SSE/AVX2/AVX512 intrinsics ### **NOTE**: currently incomplete, asking a question with what I'

[clang] [Headers][X86] VisitCallExpr constexpr immediate shifts (#154293) (PR #155542)

2025-08-26 Thread Justin Riddell via cfe-commits
https://github.com/Arghnews created https://github.com/llvm/llvm-project/pull/155542 Implement VectorExprEvaluator::VisitCallExpr constexpr support for left, right, arithmetic shift for MMX/SSE/AVX2/AVX512 intrinsics ### **NOTE**: currently incomplete, asking a question with what I've got so f

[clang] [llvm] [AMDGPU][Clang] Allow amdgpu-waves-per-eu attribute to lower target occupancy range (PR #138284)

2025-08-26 Thread Dhruva Chakrabarti via cfe-commits
@@ -216,41 +216,30 @@ define internal i32 @bitcasted_function() { ret i32 0 } -define internal void @called_from_invalid_bounds_0() { -; CHECK-LABEL: define internal void @called_from_invalid_bounds_0 -; CHECK-SAME: () #[[ATTR1]] { -; CHECK-NEXT:ret void -; +define inter

[clang] [llvm] [NVPTX] Support i256 load/store with 256-bit vector load (PR #155198)

2025-08-26 Thread Alex MacLean via cfe-commits
@@ -3085,9 +3089,114 @@ SDValue NVPTXTargetLowering::LowerVASTART(SDValue Op, SelectionDAG &DAG) const { MachinePointerInfo(SV)); } +/// ReplaceVectorLoad - Convert vector loads into multi-output scalar loads. +static std::optional> +replaceLoadVector(SD

[clang] Remove trailing whitespace in DiagnosticSemaKinds.td. NFC (PR #155482)

2025-08-26 Thread Stanislav Mekhanoshin via cfe-commits
rampitec wrote: * **#155482** https://app.graphite.dev/github/pr/llvm/llvm-project/155482?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/155

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Yanzuo Liu via cfe-commits
@@ -301,9 +302,34 @@ std::vector HeuristicResolverImpl::resolveMemberExpr( return {}; } + // check if member expr is in the context of an explicit object method + // If so, it's safe to assume the templated arg is of type of the record + const auto ExplicitMemberHeur

[clang] [clang-tools-extra] [lld] [llvm] [llvm] Add subcommand support for OptTable (PR #155026)

2025-08-26 Thread Prabhu Rajasekaran via cfe-commits
https://github.com/Prabhuk updated https://github.com/llvm/llvm-project/pull/155026 >From 3584c6aacac629c51c4d1e8e08258c0c24f3a165 Mon Sep 17 00:00:00 2001 From: prabhukr Date: Tue, 19 Aug 2025 15:48:47 -0700 Subject: [PATCH 01/10] [OptTable] Subcommand support. TODO: Add tests. --- clang-too

[clang] [Clang] Add template argument support for {con,de}structor attributes. (PR #151400)

2025-08-26 Thread Jordan R AW via cfe-commits
ajordanr-google wrote: It seems all comments so far have been addressed here. Re-requesting appropriate reviewers. https://github.com/llvm/llvm-project/pull/151400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [llvm] [RISCV] Implement MC support for Zvfbfa extension (PR #151106)

2025-08-26 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/151106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Remove unused OutputsPaths from FullDependencyConsumer (PR #155523)

2025-08-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Naveen Seth Hanig (naveen-seth) Changes The OutputPaths field of FullDependencyConsumer is not used, and the resulting TranslationUnitDeps has no corresponding field. This change removes the unused member. It was added in commit f978ea4,

[clang] [clang-scan-deps] Remove unused OutputsPaths from FullDependencyConsumer (PR #155523)

2025-08-26 Thread Naveen Seth Hanig via cfe-commits
https://github.com/naveen-seth created https://github.com/llvm/llvm-project/pull/155523 The OutputPaths field of FullDependencyConsumer is not used, and the resulting TranslationUnitDeps has no corresponding field. This change removes the unused member. It was added in commit f978ea4, and thi

[clang] Remove trailing whitespace in DiagnosticSemaKinds.td. NFC (PR #155482)

2025-08-26 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec ready_for_review https://github.com/llvm/llvm-project/pull/155482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Implement MC support for Zvfbfa extension (PR #151106)

2025-08-26 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/151106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove some "DeprecatedSmallSet is deprecated" warnings from the build (PR #155407)

2025-08-26 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: Does this resolve *all* of the warnings, or just some of them? If there are still warnings it is probably better to revert the deprecation change entirely https://github.com/llvm/llvm-project/pull/155407 ___ cfe-commits mailing list

[clang] [llvm] [InstCombine] Strip leading zero indices from GEP (PR #155415)

2025-08-26 Thread Nikita Popov via cfe-commits
nikic wrote: @zyw-bot csmith-fuzz https://github.com/llvm/llvm-project/pull/155415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Implement MC support for Zvfbfa extension (PR #151106)

2025-08-26 Thread Craig Topper via cfe-commits
topperc wrote: I think we should accept this patch. The spec has is in internal review at RVI https://lists.riscv.org/g/tech-unprivileged/message/1085 as of last week. What's here looks pretty minimal and wouldn't be hard to remove if RVI changes direction. https://github.com/llvm/llvm-projec

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Nathan Ridge via cfe-commits
@@ -256,6 +256,21 @@ QualType HeuristicResolverImpl::simplifyType(QualType Type, const Expr *E, } } } +// check if member expr is in the context of an explicit object method HighCommander4 wrote: I would reword / expand on this as: ```c

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Nathan Ridge via cfe-commits
@@ -256,6 +256,21 @@ QualType HeuristicResolverImpl::simplifyType(QualType Type, const Expr *E, } } } +// check if member expr is in the context of an explicit object method +if (!T.Type.isNull() && +(T.Type->isUndeducedAutoType() || T.Type->i

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-26 Thread Nathan Ridge via cfe-commits
@@ -302,33 +317,17 @@ std::vector HeuristicResolverImpl::resolveMemberExpr( return {}; } - // check if member expr is in the context of an explicit object method - // If so, it's safe to assume the templated arg is of type of the record - const auto ExplicitMemberHeu

[clang] [clang] Remove hasValue() check in `RecordExprEvaluator::VisitCXXConstructExpr()` (PR #154610)

2025-08-26 Thread via cfe-commits
h-vetinari wrote: > Failed to cherry-pick: 8b3d4bd For completeness, this was done in https://github.com/llvm/llvm-project/commit/3263ad76c4301692416e40bee7043996a59a https://github.com/llvm/llvm-project/pull/154610 ___ cfe-commits mailing list c

[clang] [clang-format] Add option AllowShortRecordOnASingleLine (PR #154580)

2025-08-26 Thread Tomáš Slanina via cfe-commits
https://github.com/itzexpoexpo edited https://github.com/llvm/llvm-project/pull/154580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Complex Unary plus and minus with promoted type (PR #155486)

2025-08-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This change adds support for Complex unary plus and minus expressions with promoted type Issue: https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/pull

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-26 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/154618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] AST: fix getAs canonicalization of leaf types (PR #155028)

2025-08-26 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155028 >From 63542d5cdeccb17b9125430d0a984f45d58e208c Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Fri, 22 Aug 2025 19:10:05 -0300 Subject: [PATCH 1/2] meat and potatoes --- clang/include/clang/AST/Type.h

[clang] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-08-26 Thread Eli Friedman via cfe-commits
@@ -12504,6 +12514,14 @@ void Sema::CheckImplicitConversion(Expr *E, QualType T, SourceLocation CC, IntRange TargetRange = IntRange::forTargetOfCanonicalType(Context, Target); if (LikelySourceRange->Width > TargetRange.Width) { +// Check if target is a wrapping OBT -

[clang-tools-extra] [clang-doc] lower filename length limit by 5 (PR #155511)

2025-08-26 Thread Erick Velez via cfe-commits
https://github.com/evelez7 updated https://github.com/llvm/llvm-project/pull/155511 >From fc4ad9db12ba7aac2be9e45ee0ab483338c28fa7 Mon Sep 17 00:00:00 2001 From: Erick Velez Date: Tue, 26 Aug 2025 15:30:33 -0700 Subject: [PATCH] [clang-doc] lower filename length limit by 5 The previous limit d

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-26 Thread Dan Liew via cfe-commits
@@ -1,9 +1,32 @@ // RUN: %clang_cc1 -triple arm64-apple-macosx14.0.0 -O0 -debug-info-kind=standalone -dwarf-version=5 \ -// RUN: -fsanitize=signed-integer-overflow -fsanitize-trap=signed-integer-overflow -emit-llvm %s -o - | FileCheck %s +// RUN: -fsanitize=signed-integer-overf

[clang] [clang] Fix clang module build by declaring new textual header (PR #155510)

2025-08-26 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan auto_merge_enabled https://github.com/llvm/llvm-project/pull/155510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] allow short function body on a single line (PR #151428)

2025-08-26 Thread Lidong Yan via cfe-commits
@@ -251,10 +251,15 @@ class LineJoiner { : Limit - TheLine->Last->TotalLength; if (TheLine->Last->is(TT_FunctionLBrace) && -TheLine->First == TheLine->Last && -!Style.BraceWrapping.SplitEmptyFunction && -NextLine.First->is(tok::r_bra

[clang] [clang-tools-extra] [lld] [llvm] [llvm] Add subcommand support for OptTable (PR #155026)

2025-08-26 Thread Prabhu Rajasekaran via cfe-commits
https://github.com/Prabhuk updated https://github.com/llvm/llvm-project/pull/155026 >From 3584c6aacac629c51c4d1e8e08258c0c24f3a165 Mon Sep 17 00:00:00 2001 From: prabhukr Date: Tue, 19 Aug 2025 15:48:47 -0700 Subject: [PATCH 1/9] [OptTable] Subcommand support. TODO: Add tests. --- clang-tools

[clang] [llvm] [clang][driver][arm][macho] Default to -mframe-pointer=non-leaf. (PR #154216)

2025-08-26 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli updated https://github.com/llvm/llvm-project/pull/154216 >From ab60c69a2c0ca5a06a6b5fa0f54e3a759ab37392 Mon Sep 17 00:00:00 2001 From: Francesco Petrogalli Date: Mon, 18 Aug 2025 10:01:25 -0700 Subject: [PATCH] [clang][driver][arm][macho] Default to -mframe-point

[clang-tools-extra] [clang-doc] lower filename length limit by 5 (PR #155511)

2025-08-26 Thread Erick Velez via cfe-commits
evelez7 wrote: * **#155511** https://app.graphite.dev/github/pr/llvm/llvm-project/155511?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1555

[clang] [llvm] [NVPTX] Support i256 load/store with 256-bit vector load (PR #155198)

2025-08-26 Thread Drew Kersnar via cfe-commits
https://github.com/dakersnar approved this pull request. LGTM with some small questions and nits https://github.com/llvm/llvm-project/pull/155198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] Fix unique_ptr aggregate initialization false positives (PR #155131)

2025-08-26 Thread via cfe-commits
https://github.com/vidur2 updated https://github.com/llvm/llvm-project/pull/155131 >From f903652135758b6a7a20d15565177304add16e2c Mon Sep 17 00:00:00 2001 From: vidur2 Date: Thu, 14 Aug 2025 17:28:36 -0400 Subject: [PATCH 1/4] initial malloc change check --- .../StaticAnalyzer/Checkers/Malloc

[clang] [llvm] [NVPTX] Support i256 load/store with 256-bit vector load (PR #155198)

2025-08-26 Thread Drew Kersnar via cfe-commits
https://github.com/dakersnar edited https://github.com/llvm/llvm-project/pull/155198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] lower filename length limit by 5 (PR #155511)

2025-08-26 Thread Petr Hosek via cfe-commits
@@ -778,7 +778,7 @@ static void populateSymbolInfo(SymbolInfo &I, const T *D, const FullComment *C, Mangler->mangleCXXVTable(CXXD, MangledStream); else MangledStream << D->getNameAsString(); - if (MangledName.size() > 255) + if (MangledName.size() > 250) --

[clang] Fix unique_ptr aggregate initialization false positives (PR #155131)

2025-08-26 Thread via cfe-commits
vidur2 wrote: Ok, I made the changes https://github.com/llvm/llvm-project/pull/155131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5313d68 - [clang] Fix clang module build by declaring new textual header (#155510)

2025-08-26 Thread via cfe-commits
Author: Steven Wu Date: 2025-08-26T22:51:44Z New Revision: 5313d6895cd1153109f35cfdb60fbb6348f68cb9 URL: https://github.com/llvm/llvm-project/commit/5313d6895cd1153109f35cfdb60fbb6348f68cb9 DIFF: https://github.com/llvm/llvm-project/commit/5313d6895cd1153109f35cfdb60fbb6348f68cb9.diff LOG: [cl

[clang] [clang] Fix clang module build by declaring new textual header (PR #155510)

2025-08-26 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan closed https://github.com/llvm/llvm-project/pull/155510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-08-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,162 @@ +// TODO: When Clang adds support for decimal floating point types, enable these tests by: +//1. Removing all the #if 0 + #endif guards. +//2. Removing all occurrences of the string "DISABLED-" in this file. +//3. Deleting this message. + +// RUN: %c

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-26 Thread Thurston Dang via cfe-commits
thurstond wrote: > @thurstond I implemented a -fsanitize-debug-trap-reasons= flag takes an enum > value. It takes either none, basic (what we had before this patch), or > detailed (the new behavior added by this patch). For compatibility I kept the > binary forms of the flags around and made t

[clang-tools-extra] [clang-doc] lower filename length limit by 5 (PR #155511)

2025-08-26 Thread Paul Kirth via cfe-commits
ilovepi wrote: > LGTM, but I thought we had a unit test for this? Am I misremembering? Looking at the source: I am wrong and we never had one. https://github.com/llvm/llvm-project/pull/155511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [llvm] [NVPTX] Support i256 load/store with 256-bit vector load (PR #155198)

2025-08-26 Thread Drew Kersnar via cfe-commits
@@ -3085,9 +3089,114 @@ SDValue NVPTXTargetLowering::LowerVASTART(SDValue Op, SelectionDAG &DAG) const { MachinePointerInfo(SV)); } +/// ReplaceVectorLoad - Convert vector loads into multi-output scalar loads. +static std::optional> +replaceLoadVector(SD

[clang] [llvm] [NVPTX] Support i256 load/store with 256-bit vector load (PR #155198)

2025-08-26 Thread Drew Kersnar via cfe-commits
@@ -5126,11 +5235,34 @@ static SDValue combinePackingMovIntoStore(SDNode *N, ST->getMemoryVT(), ST->getMemOperand()); } -static SDValue PerformStoreCombine(SDNode *N, - TargetLowering::DAGCombinerInfo &DCI)

[clang] [llvm] [NVPTX] Support i256 load/store with 256-bit vector load (PR #155198)

2025-08-26 Thread Drew Kersnar via cfe-commits
@@ -3085,9 +3089,114 @@ SDValue NVPTXTargetLowering::LowerVASTART(SDValue Op, SelectionDAG &DAG) const { MachinePointerInfo(SV)); } +/// ReplaceVectorLoad - Convert vector loads into multi-output scalar loads. dakersnar wrote: Nit: now

[clang-tools-extra] [clang-doc] lower filename length limit by 5 (PR #155511)

2025-08-26 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM, but I thought we had a unit test for this? Am I misremembering? https://github.com/llvm/llvm-project/pull/155511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-08-26 Thread Eli Friedman via cfe-commits
@@ -405,6 +405,9 @@ ArgType::matchesType(ASTContext &C, QualType argTy) const { argTy = PT->getPointeeType(); } + if (const auto *OBT = argTy->getAs()) +argTy = OBT->getUnderlyingType(); efriedma-quic wrote: Probably the documentation should mentio

[clang] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-08-26 Thread Eli Friedman via cfe-commits
@@ -3189,16 +3227,21 @@ ScalarExprEmitter::EmitScalarPrePostIncDec(const UnaryOperator *E, LValue LV, // Note that signed integer inc/dec with width less than int can't // overflow because of promotion rules; we're just eliding a few steps // here. -} els

[clang] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-08-26 Thread Eli Friedman via cfe-commits
@@ -1480,6 +1480,14 @@ class DeclRefExpr final return DeclRefExprBits.IsImmediateEscalating; } + bool isOverflowBehaviorDiscarded() const { efriedma-quic wrote: Is there some description of what this bit is supposed to mean? As far as I can tell, it

[clang] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-08-26 Thread Eli Friedman via cfe-commits
@@ -199,6 +233,19 @@ static bool CanElideOverflowCheck(const ASTContext &Ctx, const BinOpInfo &Op) { if (!Op.mayHaveIntegerOverflow()) return true; + const UnaryOperator *UO = dyn_cast(Op.E); + if (UO && Ctx.isUnaryOverflowPatternExcluded(UO)) +return true; + + c

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-26 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: LGTM from my perspective. Its worth noting that I'm not one of the normal maintainers of UBSan though. My team is just eager for this feature for our embedded/kernel users. I'll defer to @vitalybuka and @thurstond since they deal with this part of the code

[clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

2025-08-26 Thread Paul Kirth via cfe-commits
@@ -1,9 +1,32 @@ // RUN: %clang_cc1 -triple arm64-apple-macosx14.0.0 -O0 -debug-info-kind=standalone -dwarf-version=5 \ -// RUN: -fsanitize=signed-integer-overflow -fsanitize-trap=signed-integer-overflow -emit-llvm %s -o - | FileCheck %s +// RUN: -fsanitize=signed-integer-overf

[clang] [AMDGCN] Add missing gfx1250 clang tests. NFC. (PR #155478)

2025-08-26 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec closed https://github.com/llvm/llvm-project/pull/155478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] lower filename length limit by 5 (PR #155511)

2025-08-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) Changes The previous limit did not take into account filename extensions. Since the extensions we use (.yaml, .json, .html, .md) are at most 5 characters, we can lower the limit by 5. Also add some tests t

[clang-tools-extra] [clang-doc] lower filename length limit by 5 (PR #155511)

2025-08-26 Thread Erick Velez via cfe-commits
https://github.com/evelez7 ready_for_review https://github.com/llvm/llvm-project/pull/155511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] lower filename length limit by 5 (PR #155511)

2025-08-26 Thread Erick Velez via cfe-commits
https://github.com/evelez7 created https://github.com/llvm/llvm-project/pull/155511 The previous limit did not take into account filename extensions. Since the extensions we use (.yaml, .json, .html, .md) are at most 5 characters, we can lower the limit by 5. Also add some tests to make sure th

[clang] [clang] Fix clang module build by declaring new textual header (PR #155510)

2025-08-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Steven Wu (cachemeifyoucan) Changes Add `clang/Basic/ABIVersions.def` introduced in #151995 to textual header to fix clang module build. --- Full diff: https://github.com/llvm/llvm-project/pull/155510.diff 1 Files Affected: - (modifie

[clang] [clang] Fix clang module build by declaring new textual header (PR #155510)

2025-08-26 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan created https://github.com/llvm/llvm-project/pull/155510 Add `clang/Basic/ABIVersions.def` introduced in #151995 to textual header to fix clang module build. >From 9d4b745b2845d913eb1bab4e4e4ed5952efde27c Mon Sep 17 00:00:00 2001 From: Steven Wu Date: Tue, 2

[clang] [clang-tools-extra] [lld] [llvm] [llvm] Add subcommand support for OptTable (PR #155026)

2025-08-26 Thread Prabhu Rajasekaran via cfe-commits
https://github.com/Prabhuk updated https://github.com/llvm/llvm-project/pull/155026 >From 3584c6aacac629c51c4d1e8e08258c0c24f3a165 Mon Sep 17 00:00:00 2001 From: prabhukr Date: Tue, 19 Aug 2025 15:48:47 -0700 Subject: [PATCH 1/8] [OptTable] Subcommand support. TODO: Add tests. --- clang-tools

[clang] [clang] Fix crash when `__builtin_function_start` is given an invalid first parameter (PR #155506)

2025-08-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/test/SemaCXX/gh113323.cpp clang/lib/Sema/SemaCh

[clang] [clang-format] Add option AllowShortRecordOnASingleLine (PR #154580)

2025-08-26 Thread Tomáš Slanina via cfe-commits
https://github.com/itzexpoexpo edited https://github.com/llvm/llvm-project/pull/154580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >