[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

aaronmondal added subscribers: MaskRay, phosek, compnerd, aaronmondal. aaronmondal added a comment. Herald added a subscriber: Enna1. Herald added a project: All. Hmm I tried to fiddle around with this but I'm out of my depth here. Pulling in @MaskRay @compnerd @phosek in the hopes that one of

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. I think unless conflicts arise creating an issue similar to this https://github.com/llvm/llvm-project/issues/60600 with the `cherry-pick` line set to this commit should be enough. (See also https://llvm.org/docs/GitHub.html). Repository: rG LLVM Github Monorepo

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. > I cannot say there was much choice. The only real choice was to postpone the > split and magnify the problem in the future. As for the ifdefs, this might be > possible in the device-libs but I do not see how to do it the Builtins.def. Hmm maybe ifdefs in the

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. Well, I can already feel the pain that distro maintainers having to build the next ROCm releases  I wonder what the better course of action is here: 1. Port this patch to Clang 16 so that users with new hardware will be able to build ROCm 5.5, but make it

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. > It shall be complimented by the device-lib change in the corresponding > release, so it is not that simple. @rampitec I'm not sure I understand. Does this mean that this is breaking in a way that Clang 17 won't be able to build ROCm 5.4? I thought it was like

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added subscribers: jhuber6, aaronmondal. aaronmondal added a comment. Would it be possible to backport this to Clang 16? If https://github.com/RadeonOpenCompute/ROCm-Device-Libs/commit/8dc779e19cbf2ccfd3307b60f7db57cf4203a5be makes it into ROCm 5.5 no distro would be able to build

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a subscriber: aaron.ballman. aaronmondal added a comment. Ok so I went over https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations#testing-for-the-presence-of-a-header-__has_include (thanks, @aaron.ballman ) and through the commit history for the

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a comment. This would also allow e.g. the ROCm packages to `FORCE_ON` hsa and enjoy the benefits of the LLVM configuration  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143768/new/ https://reviews.llvm.org/D143768

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a comment. Fun fact I now know that libxml2 also struggles with this  The following would roughly be how zlib and others handle it: if (CLANG_ENABLE_HSA) if (CLANG_ENABLE_HSA STREQUAL FORCE_ON) find_package(hsa-runtime... REQUIRED) else() find_package

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a comment. Ah yeah my bad  Hmm somehow I keep getting confused by this. I'll check how other deps handle this, maybe there is a better way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143768/new/

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a comment. Does this address the case where we have HSA headers present on the system? Since this only seems to modify link time behavior, I think building with this flag would still include "hsa/hsa.h" if they were present. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

aaronmondal added a comment. Porting to bazel in https://reviews.llvm.org/D143344 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commits mailing list

[PATCH] D131388: [docs] Add "Standard C++ Modules"

aaronmondal requested changes to this revision. aaronmondal added a comment. This revision now requires changes to proceed. I just noticed that there probably needs to be one change. The doc sometimes describes `-fprebuilt-module-interface`, which is not a valid option. I think the occurrences

[PATCH] D131388: [docs] Add "Standard C++ Modules"

aaronmondal accepted this revision. aaronmondal added a comment. Thanks for addressing my comment. I think I overlooked the part about `-fmodules-embed-all-files`  I'm fine with this revision  CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/

[PATCH] D131388: [docs] Add "Standard C++ Modules"

aaronmondal added a comment. @ChuanqiXu Thanks a lot for this! We are currently implementing this module logic in the Bazel ruleset rules_ll . This page helps clarify the differences between clang modules and C++ modules a lot. If I knew about this earlier

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

AaronSiddharthaMondal added a comment. Ahh I didn't know that. After fixing my settings it is now linked correctly. No need to revert. Thanks a lot for the help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123074/new/

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

AaronSiddharthaMondal added a comment. @aaron.ballman There may have been something wrong with the commit. On GitHub it does not link to my user account. Would it be possible to change that? The github name is aaronmondal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

AaronSiddharthaMondal added a comment. In D123074#3430355 , @aaron.ballman wrote: > In D123074#3430351 , @aaron.ballman > wrote: > >> LGTM, thank you for the fix! > > If you need me to commit on your behalf,

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

AaronSiddharthaMondal created this revision. AaronSiddharthaMondal added a reviewer: aaron.ballman. AaronSiddharthaMondal added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. AaronSiddharthaMondal requested review of this revision.