[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. In D102273#2866532 , @vsavchenko wrote: > Great! Thanks for addressing all of the comments! Thank you for the review! Can you take care of merging it? I don't have the required permission. Repository: rG LLVM Github

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. @vsavchenko any update on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273 ___ cfe-commits mailing list

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/ https://reviews.llvm.org/D102273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra added a comment. In D102517#2789450 , @goncharov wrote: > Sorry, had to revert it as this fails under sanitizer : > https://lab.llvm.org/buildbot/#/builders/5/builds/8150 Thanks! I missed adding "Ident_abstract" in the Parser initialize

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra updated this revision to Diff 348806. AbbasSabra added a comment. Updating D102517 : [clang]Fix use-of-uninitialized-value detected by the sanitizer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra added a comment. Thanks for the review! Can you take care of merging the patch? I don't have access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra updated this revision to Diff 347955. AbbasSabra added a comment. Updating D102517 : [clang] Apply code review: while loop instead of for loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra added a comment. > Does MS use this in any library headers or such I didn't check if they do. But if any codebase does use "abstract" and they are trying to use clang-cl they would face a parsing error. My use case was running static analysis on code that uses this feature. Such an

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra updated this revision to Diff 347018. AbbasSabra marked 3 inline comments as done. AbbasSabra added a comment. Updating D102517 : [clang]Apply code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. Note: I don't have the right to re-run the failed build/test. I assume that it is not related to my change since the test compile and runs omp code(Static analyzer doesn't run on that test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added a comment. Herald added a subscriber: manas. In D102273#2766531 , @NoQ wrote: > I've just been patching up clang-tidy's infinite loop checker and the problem > sounds s similar. Maybe we should move clang-tidy's alias analysis into

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra added a comment. In D102280#2762760 , @steakhal wrote: > I think it's good to go. Thank you! Great! can you take care of merging it? I don't have accesss. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra added a comment. > Well, and how can I build them on Linux xD Ah, I don't think they are meant to be built on Linux :D Especially if they rely on Window specific features like SEH. If they do they will disable these features on Linux build. > How do you use clang exactly? I

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra created this revision. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://docs.microsoft.com/en-us/cpp/extensions/abstract-cpp-component-extensions?view=msvc-160 Repository: rG LLVM Github Monorepo

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345482. AbbasSabra added a comment. Updating D102273 : [analyzer] Update comments + fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return FD->getType()->isReferenceType(); +} else { + assert(false && "Unknown captured variable"); +} vsavchenko wrote: > AbbasSabra wrote:

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345471. AbbasSabra marked 7 inline comments as done. AbbasSabra added a comment. Updating D102273 : [analyzer] Apply code review part 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return FD->getType()->isReferenceType(); +} else { + assert(false && "Unknown captured variable"); +} vsavchenko wrote: > But actually, it's

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345435. AbbasSabra marked 4 inline comments as done. AbbasSabra added a comment. Updating D102273 : [analyzer] Apply code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra added a comment. In D102280#2759167 , @steakhal wrote: > Do you have any good (mature, big enough) open-source projects for these msvc > constructs? https://github.com/microsoft/winfile and https://github.com/chakra-core/ChakraCore seem to

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra updated this revision to Diff 345422. AbbasSabra added a comment. Updating D102280 : [analyzer] rename test file + make sure that statements after "__leave" are not reached Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra marked 2 inline comments as done. AbbasSabra added a comment. > Please, add these reviewers for your upcoming [analyzer] patches. Thanks, I was planning to add reviewers after making sure that the pre-checks are green. > Nice to see some fixes for visual c++ stuff. Thanks for the

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra updated this revision to Diff 345381. AbbasSabra added a comment. Updating D102280 : [analyzer] Apply code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102280/new/

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, zzheng, szepet, baloghadamsoftware, xazax.hun. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra added a comment. Gentle reminder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/ https://reviews.llvm.org/D80669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra added a comment. In D80669#2058824 , @NoQ wrote: > Fair! Thanks for the review! May you please take care of merging this one too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra updated this revision to Diff 266689. AbbasSabra added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/ https://reviews.llvm.org/D80669 Files: clang/lib/StaticAnalyzer/Core/LoopWidening.cpp

[PATCH] D80671: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. AbbasSabra abandoned this revision. Repository: rG LLVM

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. AbbasSabra edited the summary of this revision. AbbasSabra

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra added a comment. Great! Can someone take care of merging it? I believe I don't have access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 ___

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra updated this revision to Diff 265253. AbbasSabra added a comment. Fix code review 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 Files: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra marked 2 inline comments as done. AbbasSabra added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:167 + const bool isParm = VD->getKind() == Decl::ParmVar; + // Reference parameters are assumed as escaped variables.

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra updated this revision to Diff 265095. AbbasSabra added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 Files: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra requested review of this revision. AbbasSabra added a comment. What you both said makes sense. Now, reference parameters are escaped and value parameters are treated as the local variables. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra updated this revision to Diff 265090. AbbasSabra added a comment. Fix code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 Files: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra created this revision. AbbasSabra added a reviewer: szepet. Herald added subscribers: ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, zzheng, rnkovacs, baloghadamsoftware, xazax.hun. Herald added a project: clang. When loop counter is a