[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

abhinavgaba added subscribers: dreachem, kkwli0. abhinavgaba added a comment. > In target data we already put a and b in use_device_addr. That indicates all > use of a and b will be the corresponding device addresses. Therefore, in > target directive, we should use is_device_address instead of

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

abhinavgaba added a comment. In D141627#4049085 , @tianshilei1992 wrote: > FWIW, I think `has_device_addr(b[0])` is not trying to take the value of > `b[0]` in this case. Instead, it's just to take the address of the first > element of `b`. Only

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

abhinavgaba added a comment. In D141627#4048584 , @tianshilei1992 wrote: > I agree that b is not right here, but that doesn’t matter because I stepped > into the runtime library and it crashed when processing a. > > And why are they treated as to?

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

abhinavgaba added a comment. In D134268#4048357 , @tianshilei1992 wrote: > Hi there, I'm trying to fix > https://github.com/llvm/llvm-project/issues/59160. The faulty case is > basically like the following: > > void xoo() { > short a[10], b[10];

[PATCH] D134268: [Clang][OpenMP] Codegen generation for has_device_addr claues.

abhinavgaba accepted this revision. abhinavgaba added a comment. This revision is now accepted and ready to land. Thanks, Jennifer. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134268/new/ https://reviews.llvm.org/D134268

[PATCH] D134268: [Clang][OpenMP] Codegen generation for has_device_addr claues.

abhinavgaba added inline comments. Comment at: clang/test/OpenMP/target_has_device_addr_codegen.cpp:351 +// CHECK: omp_offload.failed: +// CHECK-NEXT:call void @{{__omp_offloading_[0-9a-z]+_[0-9a-z]+}}_main_l145(i32* [[TMP2]]) #[[ATTR5:[0-9]+]] +// CHECK-NEXT:br

[PATCH] D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues.

abhinavgaba added inline comments. Comment at: clang/test/OpenMP/target_has_device_addr_codegen.cpp:317 +// CHECK-NEXT:store [10 x i32]* [[AA]], [10 x i32]** [[RAA]], align 8 +// CHECK-NEXT:[[TMP2:%.*]] = load i32*, i32** [[K]], align 8 +// CHECK-NEXT:[[TMP3:%.*]] =

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

abhinavgaba accepted this revision. abhinavgaba added a comment. Thanks for the fix, Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105562/new/ https://reviews.llvm.org/D105562 ___ cfe-commits

[PATCH] D104424: [Sema] Fix for PR50741

abhinavgaba added a comment. Thanks for fixing this, @chrish_ericsson_atx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424 ___ cfe-commits mailing list

[PATCH] D104424: [Sema] Fix for PR50741

abhinavgaba added a comment. @erichkeane, can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424 ___ cfe-commits mailing list

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

abhinavgaba added inline comments. Comment at: clang/test/AST/ast-dump-implicit-members.clcpp:10 + +// CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept' +// CHECK: CXXConstructorDecl {{.*}} implicit constexpr S 'void (const __generic S &)

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

abhinavgaba added inline comments. Comment at: clang/test/AST/ast-dump-implicit-members.clcpp:10 + +// CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept' +// CHECK: CXXConstructorDecl {{.*}} implicit constexpr S 'void (const __generic S &)

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

abhinavgaba added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:7 + +// XFAIL: clang + Thanks for the fixes, Alexey. Are you planning on handling this case separately? Repository: rG LLVM

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

abhinavgaba accepted this revision. abhinavgaba added a comment. This revision is now accepted and ready to land. Thanks for the changes, Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86119/new/ https://reviews.llvm.org/D86119

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

abhinavgaba added a comment. Thanks for the changes, Alexey! I tried the patch locally, and it looks stable. It handled several tests I tried, including the following case involving array section on a pointer to pointer base, and nested mappers with `PTR_AND_OBJ` maps successfully: #include

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

abhinavgaba added a comment. The patch currently asserts for the following: #include typedef struct { int a; double *b; } C; #pragma omp declare mapper(default: C s) map(s.a, s.b[0:2])

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

abhinavgaba added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:8 // RUN: touch %t.dir/foo.h -// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX -Xclang -verify -fsyntax-only %s 2>&1 | FileCheck %s +// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

abhinavgaba added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:8 // RUN: touch %t.dir/foo.h -// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX -Xclang -verify -fsyntax-only %s 2>&1 | FileCheck %s +// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

abhinavgaba added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5974 + SmallVectorImpl ) override {} +}; + Overloading `CompleteType(TagDecl*)` is causing a warning: virtual void