[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. nvm i found the file in one of the previous commits. https://github.com/llvm/llvm-project/pull/68735 for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. @alexfanqi can you please upload the file (tsan_rtl_riscv64.S) with the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 ___

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SANITIZER_LIMIT_FRAME_SIZE

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SANITIZER_LIMIT_FRAME_SIZE

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. Another test that failed: compiler-rt/test/tsan/signal_thread.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 ___ cfe-commits

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. In D145214#4650928 , @alexfanqi wrote: > In D145214#4650189 , @hiraditya > wrote: > >> I tested it on a licheepi board (riscv64 debian) and all the tests modified >> in this patch

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. I tested it on a licheepi board (riscv64 debian) and all the tests passed. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:223 +elseif(arch MATCHES "riscv64") + add_asm_sources(TSAN_ASM_SOURCES +tsan_rtl_riscv64.S hiraditya wrote: > I'm getting error with this line for some reason.

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:223 +elseif(arch MATCHES "riscv64") + add_asm_sources(TSAN_ASM_SOURCES +tsan_rtl_riscv64.S I'm getting error with this line for some reason. Unknown cmake

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. ping: @jrtc27 @asb do you have any pending feedback for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 ___ cfe-commits

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. Herald added subscribers: wangpc, sunshaoce. @alexfanqi are you still actively working on this? maybe we can move it to github then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/

[PATCH] D159338: [clangd][tests] Bump timeouts in TUSchedulerTests to 60 secs

hiraditya added a comment. not sure if this is the right way to fix these tests. The problem is if a device is constraiend, this will further slow down the device and create more backlogs. Can we allow a way to skip these tests based on a flag/environment variable? Repository: rG LLVM

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya added a comment. In D158566#4633847 , @kadircet wrote: > In D158566#4616417 , @ilya-biryukov > wrote: > >> Open question: I also feel like the best option here is to fix the tests, >> but I'm not sure

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya added a comment. > I'm marking as requiring changes mostly for the latter comment about > CLANG_INCLUDE_TESTS. Added CLANG_INCLUDE_TESTS to the conditional. btw when CLANG_INCLUDE_TESTS is OFF, `ninja check-clang-tools` target doesn't get created so adding CLANG_INCLUDE_TESTS here

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya updated this revision to Diff 553738. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 Files: clang-tools-extra/clangd/CMakeLists.txt Index: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya added a subscriber: nridge. hiraditya added a comment. Added previously reported issues shared by @nridge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 ___ cfe-commits mailing list

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya updated this revision to Diff 552543. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 Files: clang-tools-extra/clangd/CMakeLists.txt Index:

[PATCH] D158534: [clang-tidy] Disable trivially-destructible check for darwin

hiraditya abandoned this revision. hiraditya added a comment. In D158534#4607719 , @PiotrZSL wrote: > 626849c71e85d546a004cc91866beab610222194 > didn't > fix this issue already ? ah

[PATCH] D158534: [clang-tidy] Disable trivially-destructible check for darwin

hiraditya created this revision. hiraditya added reviewers: PiotrZSL, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. hiraditya requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. For fat binaries

[PATCH] D157331: [clang] Implement C23

hiraditya added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) aaron.ballman wrote: > enh wrote: > > ZijunZhao wrote: > > > cor3ntin wrote: > > > >

[PATCH] D157331: [clang] Implement C23

hiraditya added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > hiraditya wrote: > > xbolva00 wrote: > > > yabinc wrote: > > > > enh wrote: > > >

[PATCH] D157331: [clang] Implement C23

hiraditya added inline comments. Comment at: clang/test/Headers/stdckdint.cpp:1 +// RUN: %clang_cc1 -emit-llvm -fgnuc-version=4.2.1 -std=gnu++11 %s -o - | FileCheck %s + seems like we don't have a -std=gnu23, or -std=c23 standard flag for this in clang yet.

[PATCH] D157331: [clang] Implement C23

hiraditya added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) xbolva00 wrote: > yabinc wrote: > > enh wrote: > > > enh wrote: > > > > enh wrote: > > > > >

[PATCH] D157331: [clang] Implement C23

hiraditya added a comment. For the record, the documentation for stdckdint.h is here: https://open-std.org/JTC1/SC22/WG14/www/docs/n3096.pdf#page=330 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331

[PATCH] D157331: [clang] Implement C23

hiraditya added inline comments. Comment at: clang/lib/Headers/stdckdint.h:1 +/*=== stdckdint.h - Standard header for checking integer + *-=== nit: format. Comment at: clang/test/Headers/stdckdint.cpp:1 +// RUN:

[PATCH] D155339: Enable zba and zbs for RISCV64 Android

hiraditya added inline comments. Comment at: clang/test/Driver/riscv-features.c:13 +// ANDROID: "-target-feature" "+zba" // ANDROID: "-target-feature" "+zbb" MaskRay wrote: > If the features are adjacent, test them on one line. `// ANDROID: >

[PATCH] D155339: Enable zba and zbs for riscv android

hiraditya created this revision. hiraditya added reviewers: enh, pirama, srhines. Herald added subscribers: luke, VincentWu, danielkiss, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

hiraditya added a comment. In D152279#4406896 , @MaskRay wrote: > In D152279#4405901 , @asb wrote: > >> One of the key things we've been discussing on this at the LLVM call is that >> we probably want to keep

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added a comment. > Is there more context on why Android enables the frame pointer? From what i gathered, this is more of an effort to have parity such that existing build flag overrides continue to be consistent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 522252. hiraditya added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521835. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { hiraditya wrote: > enh wrote: > > (where? is

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521833. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test/Driver/frame-pointer.c Index:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:424 + if (Triple.isAndroid()) { +// AArch64 has frame pointers enabled for non-leaf functions. +switch (Triple.getArch()) { enh wrote: > (where? is it simpler to just add

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 521826. hiraditya added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya created this revision. hiraditya added reviewers: enh, danalbert, pirama, srhines. Herald added subscribers: VincentWu, danielkiss, vkmr, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. hiraditya

[PATCH] D149980: Remove unused basic_android_tree/mipsel-linux-android

hiraditya created this revision. hiraditya added reviewers: danalbert, enh, pirama, srhines. Herald added subscribers: danielkiss, atanasyan, jrtc27, arichardson, sdardis. Herald added a project: All. hiraditya requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D146565: [clang] Remove mips target triple for Android

hiraditya added a comment. llvm/test/CodeGen/Mips/ removed here: https://reviews.llvm.org/rG805f51f9fedf90d2aa0ad46c61cb4c9c0c5bcfe9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146565/new/ https://reviews.llvm.org/D146565

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

hiraditya added a comment. https://lists.riscv.org/g/sig-toolchains/message/548 has a proposal where X27 is one of the registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

hiraditya added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:62 -MF.getFunction(), -"Shadow Call Stack cannot be combined with Save/Restore LibCalls."}); return; ❤ Repository: rG LLVM Github Monorepo

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. Thanks for putting the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

hiraditya updated this revision to Diff 505378. hiraditya added a comment. Folded D145979 here CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145999/new/ https://reviews.llvm.org/D145999 Files: clang/test/Driver/sanitizer-ld.c

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

hiraditya added inline comments. Comment at: clang/test/Driver/riscv-fixed-x-register.c:343 + +// Check that x18 is reserved on Android by default +// RUN: %clang --target=riscv64-linux-android -### %s 2> %t MaskRay wrote: > MaskRay wrote: > > asb wrote: > > >

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

hiraditya created this revision. hiraditya added reviewers: enh, asb. Herald added subscribers: jobnoorman, luke, VincentWu, abrachet, danielkiss, vkmr, frasercrmck, evandro, phosek, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

hiraditya accepted this revision. hiraditya added a comment. LGTM, thanks for putting this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143692/new/ https://reviews.llvm.org/D143692 ___

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

hiraditya updated this revision to Diff 495641. hiraditya added a comment. Updated the failing testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131230/new/ https://reviews.llvm.org/D131230 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

hiraditya reopened this revision. hiraditya added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jobnoorman. reopening to update the failing testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131230/new/

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

hiraditya added a comment. thanks for reverting it. i'll take care of the test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131230/new/ https://reviews.llvm.org/D131230 ___ cfe-commits mailing

[PATCH] D130374: [Passes] add a tail-call-elim pass near the end of the opt pipeline

hiraditya added a comment. Thanks for clarifying! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130374/new/ https://reviews.llvm.org/D130374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130374: [Passes] add a tail-call-elim pass near the end of the opt pipeline

hiraditya added a comment. In D130374#3675677 , @vdsered wrote: > Just JFYI :) > Yes, probably not worth it that is interesting. do we know why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130374/new/

[PATCH] D130374: [Passes] add a tail-call-elim pass near the end of the opt pipeline

hiraditya added a comment. Thanks a lot for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130374/new/ https://reviews.llvm.org/D130374 ___ cfe-commits mailing list

[PATCH] D123640: [NFC] Make comment consistent with allow|ignore list renamings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f7b14898fe3: [NFC] Make comment consistent with allow|ignore list renamings (authored by hiraditya). Repository: rG LLVM Github Monorepo

[PATCH] D123640: Make comment consistent with allow|ignore list renamings

hiraditya created this revision. hiraditya added a reviewer: thakis. Herald added a project: All. hiraditya requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123640

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

hiraditya added a comment. Herald added a project: All. Is there a plan to revive this? this is quite necessary for one of my use cases. can we at least have '-fno-instrument-functions'? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37624/new/ https://reviews.llvm.org/D37624

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f00aa502d79: Add no_instrument_function attribute to Objective C methods as well (authored by hiraditya). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya updated this revision to Diff 377934. hiraditya added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 Files: clang/include/clang/Basic/Attr.td clang/test/CodeGen/instrument-objc-method.m

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya updated this revision to Diff 377895. hiraditya added a comment. Herald added a subscriber: jdoerfert. Added SemaObjc test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 Files: clang/include/clang/Basic/Attr.td

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya updated this revision to Diff 377752. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 Files: clang/include/clang/Basic/Attr.td clang/test/CodeGen/instrument-objc-method.m Index: clang/test/CodeGen/instrument-objc-method.m

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya updated this revision to Diff 377751. hiraditya added a comment. Testcase ready. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 Files: clang/include/clang/Basic/Attr.td clang/test/CodeGen/instrument-objc-method.m Index:

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya added a comment. Still working on adding the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 ___ cfe-commits mailing list

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya created this revision. hiraditya added a reviewer: rjmccall. Herald added a reviewer: aaron.ballman. hiraditya requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are several methods where we do not want function

[PATCH] D96685: [WIP] Add noexcept clang-tidy codemod

hiraditya created this revision. hiraditya requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96685 Files: clang-tools-extra/clang-tidy/modernize/AddNoexceptCheck.cpp

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

hiraditya added a comment. cc: @t.p.northover does this fix look reasonable for PR37240? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits mailing list

[PATCH] D83788: Removed unused variable in clang

hiraditya added a comment. Not sure why this didnt get closed after the patch is merged in: https://reviews.llvm.org/rG4fd91b0f946f49370a3ab33c480a807a3f48b247 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788

[PATCH] D83788: Removed unused variable in clang

hiraditya accepted this revision. hiraditya added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

hiraditya added a comment. Herald added a subscriber: danielkiss. do we have a plan to follow up on this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___

[PATCH] D82832: Correctly generate invert xor value for Binary Atomics of int size > 64

hiraditya added a comment. Nice find! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82832/new/ https://reviews.llvm.org/D82832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

hiraditya added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:801 +if (Branch->isUnconditional()) + if (ReturnInst *Ret = dyn_cast( + Branch->getSuccessor(0)->getFirstNonPHIOrDbg())) can we use isa<>

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

hiraditya added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do danlark wrote: > lichray wrote: > > mclow.lists wrote: > > > I have been asked

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. The test case is in another patch so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72873/new/ https://reviews.llvm.org/D72873

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

hiraditya added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:821 llvm::itostr(CGM.getCodeGenOpts().XRayInstructionThreshold)); + if (CGM.getCodeGenOpts().XRayIgnoreLoops) { +Fn->addFnAttr("xray-ignore-loops"); we

[PATCH] D22834: Added 'inline' attribute to basic_string's destructor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb839888af8f2: Added inline attribute to basic_strings destructor (authored by hiraditya). Herald added subscribers:

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

hiraditya added a comment. Can we add a test to verify cfi instructions are present without debug flag. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits

[PATCH] D53514: os_log: make buffer size an integer constant expression.

hiraditya closed this revision. hiraditya added a comment. Herald added a project: clang. closed in r345828, 314fbfa1c4c6665c54a220eefb10a6f23010a352 Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

hiraditya added a comment. it will be great to merge this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

hiraditya added a comment. Thanks for addressing the feedback @emmettneyman , LGTM, deferring to other reviewers for final call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mailing list

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

hiraditya added inline comments. Comment at: test/Import/cxx-noexcept-expr/test.cpp:1 +// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s | FileCheck %s + Can we add a line/comment to explain what this test does? Same for the input

[PATCH] D50796: [ASTImporter] Add test for IfStmt

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. LGTM, thanks for the test. Repository: rC Clang https://reviews.llvm.org/D50796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50766: Fix false positive unsequenced access and modification warning in array subscript expression.

hiraditya added inline comments. Comment at: lib/Sema/SemaChecking.cpp:11678 // Forget that LHS and RHS are sequenced. They are both unsequenced // with respect to other stuff. +Tree.merge(LHSRegion); Is this comment still relevant? Repository:

[PATCH] D50674: [libc++] Add missing #include in C11 features tests

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. Good catch! Repository: rCXX libc++ https://reviews.llvm.org/D50674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

hiraditya added a comment. In https://reviews.llvm.org/D50699#1198770, @owenpan wrote: > Test case: > F6937162: BreakBeforeBinaryOperators.cpp Please add a testcase in the source and add checks to verify the changes. Repository: rC Clang

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

hiraditya added a comment. Herald added a subscriber: ldionne. Any updates on this one? I like @mclow.lists idea of removing it from __locale. Repository: rCXX libc++ https://reviews.llvm.org/D47987 ___ cfe-commits mailing list

[PATCH] D45935: Add dump method for selectors

This revision was automatically updated to reflect the committed changes. Closed by commit rL333657: Add dump method for selectors (authored by hiraditya, committed by ). Changed prior to commit: https://reviews.llvm.org/D45935?vs=143493=149294#toc Repository: rL LLVM

[PATCH] D30035: Add const to function parameters

hiraditya abandoned this revision. hiraditya added a comment. Merged with https://reviews.llvm.org/D30268 https://reviews.llvm.org/D30035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45601: Warn on bool* to bool conversion

hiraditya abandoned this revision. hiraditya added a comment. It appears this warning may not be always useful because there will be false positives. https://reviews.llvm.org/D45601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45601: Warn on bool* to bool conversion

hiraditya added a comment. The bug which motivated this warning is: https://github.com/jemalloc/jemalloc/commit/4df483f0fd76a64e116b1c4f316f8b941078114d#diff-7b26b977303fe92c093a2245b0eaf255 https://reviews.llvm.org/D45601 ___ cfe-commits mailing

[PATCH] D45601: Warn on bool* to bool conversion

hiraditya updated this revision to Diff 142776. hiraditya added a comment. Warn on bool* to bool conversion during a call only. https://reviews.llvm.org/D45601 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/SemaCXX/warn-bool-ptr-to-bool.cpp Index:

[PATCH] D45601: Warn on bool* to bool conversion

hiraditya added a comment. I'll probably make this warning for function arguments only (when bool* is passed to a function accepting bool). Many conditionals use bool* -> bool conversion as pointed out by @Quuxplusone and @aaron.ballman https://reviews.llvm.org/D45601

[PATCH] D45601: Warn on bool* to bool conversion

hiraditya created this revision. hiraditya added reviewers: Eugene.Zelenko, rsmith. We found conversion from bool* to bool to be a common source of bug, so we have implemented this warning. Sample use case: int bar(bool b) { return b; } int baz() { bool *b; bar(b);

[PATCH] D36423: [libc++] Introsort based sorting function

hiraditya added a comment. Ping! https://reviews.llvm.org/D36423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34224: [NFC] remove trailing WS

hiraditya closed this revision. hiraditya added a comment. Closed by commit: https://reviews.llvm.org/rL311283 https://reviews.llvm.org/D34224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36423: [libc++] Introsort based sorting function

hiraditya added a comment. Results with the patch. Before: Run on (8 X 3900 MHz CPU s) 2017-08-20 15:11:41 --- BenchmarkTime CPU Iterations

[PATCH] D34224: [NFC] remove trailing WS

hiraditya created this revision. https://reviews.llvm.org/D34224 Files: include/memory Index: include/memory === --- include/memory +++ include/memory @@ -724,7 +724,7 @@ struct __has_element_type : false_type {}; template

[PATCH] D30268: Avoid copy of __atoms when char_type is char

This revision was automatically updated to reflect the committed changes. Closed by commit rL305427: [locale] Avoid copy of __atoms when char_type is char (authored by hiraditya). Changed prior to commit: https://reviews.llvm.org/D30268?vs=102566=102621#toc Repository: rL LLVM

[PATCH] D30268: Avoid copy of __atoms when char_type is char

hiraditya updated this revision to Diff 102566. hiraditya added a comment. Addressed comments from Eric. https://reviews.llvm.org/D30268 Files: libcxx/benchmarks/stringstream.bench.cpp libcxx/include/__config libcxx/include/locale Index: libcxx/include/locale

[PATCH] D30268: Avoid copy of __atoms when char_type is char

hiraditya added a comment. Ping https://reviews.llvm.org/D30268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30268: Avoid copy of __atoms when char_type is char

hiraditya added a comment. Ping https://reviews.llvm.org/D30268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30268: Avoid copy of __atoms when char_type is char

hiraditya added a comment. This revision now requires changes to proceed. Ping https://reviews.llvm.org/D30268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >