Re: [PATCH] D16278: ASTMatcher for ParenExpr node.

adek05 updated this revision to Diff 45344. adek05 added a comment. @aaron.ballman comments. If it looks good, please commit it for me :) http://reviews.llvm.org/D16278 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

Re: [PATCH] D16286: [clang-tidy] Readability check for redundant parenthesis in return expression.

adek05 updated this revision to Diff 45228. adek05 added a comment. @LegalizeAdulthood, @Eugene.Zelenko and @omtcyf0 comments http://reviews.llvm.org/D16286 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

adek05 added a comment. Would you mind committing it for me, and I don't have a commit access yet. Also, could you take a look at http://reviews.llvm.org/D15444 with tests for clang-tidy related to this change? http://reviews.llvm.org/D15443 ___

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

adek05 updated this revision to Diff 44598. adek05 added a comment. Adding testcases in unittest/AST/SourceLocationTest.cpp as suggested by @aaronballman Interestingly, without my change tests for function declarations pass. Only member functions fail: tools/clang/unittests/AST/ASTTests

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

adek05 added a comment. I think this won't work. If there is a problem with the expression inside `throw` or `noexcept` specifier, it will be highlighted inside the parens, never trying to actually access the end location of the function declaration. It would be enough if there is a

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

adek05 added reviewers: aaron.ballman, jroelofs. adek05 added a comment. Ping http://reviews.llvm.org/D15443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15486: [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers]

adek05 added a comment. @aaron.ballman I think this could be hard to achieve without an extra note if you have something like: cat test2.c int main() { char *c = 'a'; char volatile** cc = cc = } test2.c:2:15: warning: incompatible integer to pointer

Re: [PATCH] D15486: [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers]

adek05 added inline comments. Comment at: lib/Sema/SemaPseudoObject.cpp:739-751 @@ -738,15 +738,15 @@ // C++ class type. if (!S.getLangOpts().CPlusPlus || !op->getType()->isRecordType()) { QualType paramType = (*Setter->param_begin())->getType()

Re: [PATCH] D15444: [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers

adek05 updated this revision to Diff 42568. adek05 added a comment. Moved tests to clang-tidy test suite following Eugene.Zelenko suggestion. http://reviews.llvm.org/D15444 Files: test/clang-tidy/modernize-use-override.cpp Index: test/clang-tidy/modernize-use-override.cpp

Re: [PATCH] D15444: [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers

adek05 added a comment. I need a brave soul to review http://reviews.llvm.org/D15443 too, so if you know who else could take a look at it feel free to add people there. http://reviews.llvm.org/D15444 ___ cfe-commits mailing list

Re: [PATCH] D15444: [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers

adek05 added a comment. I don't see any tests for AddOverride in tests/clang-tidy yet. Is clang-tidy linking everything that clang-modernizer has? If so, I can create another patch which just moves these tests over. http://reviews.llvm.org/D15444