https://github.com/boomanaiden154 approved this pull request.
https://github.com/llvm/llvm-project/pull/157728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 approved this pull request.
https://github.com/llvm/llvm-project/pull/157572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
boomanaiden154 wrote:
7ca9631d5cf099ddc88db5785e257382363923dc
https://github.com/llvm/llvm-project/pull/156904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Aiden Grossman
Date: 2025-09-05T21:00:11Z
New Revision: 7ca9631d5cf099ddc88db5785e257382363923dc
URL:
https://github.com/llvm/llvm-project/commit/7ca9631d5cf099ddc88db5785e257382363923dc
DIFF:
https://github.com/llvm/llvm-project/commit/7ca9631d5cf099ddc88db5785e257382363923dc.diff
LOG
boomanaiden154 wrote:
Some of these are failing because AIX also has a different `sed` implementation.
https://github.com/llvm/llvm-project/pull/156904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
boomanaiden154 wrote:
> This seems to break some bots (running without lit's internal shell) since -u
> isn't a portable option on env:
That's pretty annoying. I guess it isn't required by any of the POSIX
standards, but every single platform we have builbots for (even Solaris!)
supports `env
https://github.com/boomanaiden154 approved this pull request.
https://github.com/llvm/llvm-project/pull/156950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/156939
>From 98bd89996f855daa04d3b13dc30b263a542d9976 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 4 Sep 2025 17:57:37 +
Subject: [PATCH 1/2] [lit] Add support for env -i
env -i is needed for so
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/156905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/156904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/156904
>From d42e179a7b6cfe60db40d452442d06766f9a7886 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 4 Sep 2025 15:02:43 +
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in
@@ -10,7 +8,9 @@
// RUN: echo "@subdir/cfg-s2" > %t/workdir/cfg-1
// RUN: echo "-Wundefined-var-template" > %t/workdir/subdir/cfg-s2
//
-// RUN: ( cd %t && %clang --config=workdir/cfg-1 -c -### %s 2>&1 | FileCheck
%s -check-prefix CHECK-REL )
+// RUN: pushd %t
+// RUN: %clang
@@ -10,7 +8,9 @@
// RUN: echo "@subdir/cfg-s2" > %t/workdir/cfg-1
// RUN: echo "-Wundefined-var-template" > %t/workdir/subdir/cfg-s2
//
-// RUN: ( cd %t && %clang --config=workdir/cfg-1 -c -### %s 2>&1 | FileCheck
%s -check-prefix CHECK-REL )
+// RUN: pushd %t
+// RUN: %clang
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/156904
This patch rewrites a couple tsts that fail when running with lit's
internal shell enabled due to assumptions about setting environment
variables. There were a couple cases where there was an implict env.
https://github.com/boomanaiden154 requested changes to this pull request.
If you have bots for this, please address specific failures rather than
grepping through the entire monorepo for these constructs. A bunch of the files
you have hit here (like the ones related to CI) will never be run as
https://github.com/boomanaiden154 milestoned
https://github.com/llvm/llvm-project/pull/155957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
boomanaiden154 wrote:
/cherry-pick 7fca1f841b4c226d50ab7bad64de5db225d4193b
https://github.com/llvm/llvm-project/pull/155957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/155957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/155957
Currently the clang CMake caches use FE PGO for instrumentation
(LLVM_BUILD_INSTRUMENTED=ON). However, IRPGO is generally regarded as better
for performance. I am measuring about a 1.5% performance gain
boomanaiden154 wrote:
@AlexMaclean This broke a lot of buildbots (including premerge), most likely
due to a midair collision. Can you update the test or revert?
https://github.com/llvm/llvm-project/pull/155198
___
cfe-commits mailing list
cfe-commits@
https://github.com/boomanaiden154 auto_merge_enabled
https://github.com/llvm/llvm-project/pull/155247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/155247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/155247
>From 3050cce28fc06b81cca19a5f7e2e4ce7590a2985 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon, 25 Aug 2025 14:05:54 +
Subject: [PATCH] [clang-format] Use proper flags for git diff-tree
>From
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/155247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/155247
>From local testing, git diff-tree does not support three dot diffs correctly,
>instead expecting the --merge-base flag to be passed along with two commits.
>This patch updates the git-clang-format scrip
boomanaiden154 wrote:
It looks like it's only the libc++ build with modules enabled that failed. It
should reproduce with a libc++ runtimes build with the flags in
https://github.com/llvm/llvm-project/blob/17eb05ddd3b0db41d69af9318a6a43760ee15910/.ci/monolithic-linux.sh#L94
set.
If you can't
https://github.com/boomanaiden154 approved this pull request.
LGTM. Thanks for the fast response.
https://github.com/llvm/llvm-project/pull/154767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
boomanaiden154 wrote:
I'm pretty sure the libc++ failure is related. We're getting consistent
failures on the premerge buildbot after this change landed:
1. https://lab.llvm.org/staging/#/builders/192/builds/1329
2. https://lab.llvm.org/staging/#/builders/192/builds/1330
https://github.com/llv
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/154217
This patch makes it so that builtins for the aux triple only get enabled if
they are marked as supported by the current language options. Otherwise we
define them regardless of the language mode. This ca
boomanaiden154 wrote:
> Though I note that we try to test any components that are actually modified,
> and this doesn't happen for the rewriter, so it gets no tests at all.
We do this at the project level rather than at the level of individual options.
The only exception we make is for ClangIR
boomanaiden154 wrote:
If it's a waste of most user's time to enable it, it's probably a waste of
premerge CI resources to test it there?
Differing the configuration significantly between what people get locally by
default and what runs in CI also creates a confusing user experience.
Overall I
https://github.com/boomanaiden154 commented:
The CI changes should probably be split out.
And if test coverage is important here, why doesn't this option default to on?
https://github.com/llvm/llvm-project/pull/152845
___
cfe-commits mailing list
cfe-
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/152556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -345,10 +345,15 @@ static __inline int __get_cpuid_count (unsigned int
__leaf,
// In some configurations, __cpuidex is defined as a builtin (primarily
// -fms-extensions) which will conflict with the __cpuidex definition below.
#if !(__has_builtin(__cpuidex))
+// In some ca
boomanaiden154 wrote:
This is a specific carve-out which I'm not a huge fan of, but it doesn't seem
like there's any systematic way to identify builtins tied to the aux triple, so
I think this makes sense for now.
https://github.com/llvm/llvm-project/pull/152556
___
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/152556
The landing of #126324 made it so that __has_builtin returns false for aux
triple builtins. CUDA offloading can sometimes compile where the host is in the
aux triple (ie x86_64). This patch explicitly ca
boomanaiden154 wrote:
This is the cc1 invocation that is causing things to fail (on the example
provided in the comment above):
```
/home/gha/llvm-project/build/bin/clang-22 -cc1 -triple nvptx64-nvidia-cuda
-aux-triple x86_64-unknown-linux-gnu -fsyntax-only -disable-free
-clear-ast-before-back
https://github.com/boomanaiden154 approved this pull request.
https://github.com/llvm/llvm-project/pull/152345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Aiden Grossman
Date: 2025-08-03T16:07:36Z
New Revision: 90f1e04954daff087166c1072ad908d62e6ac6c9
URL:
https://github.com/llvm/llvm-project/commit/90f1e04954daff087166c1072ad908d62e6ac6c9
DIFF:
https://github.com/llvm/llvm-project/commit/90f1e04954daff087166c1072ad908d62e6ac6c9.diff
LOG
Author: Aiden Grossman
Date: 2025-08-02T20:08:53Z
New Revision: b7b501e54c1e711fb838a2e881ec1e6d99ce2e38
URL:
https://github.com/llvm/llvm-project/commit/b7b501e54c1e711fb838a2e881ec1e6d99ce2e38
DIFF:
https://github.com/llvm/llvm-project/commit/b7b501e54c1e711fb838a2e881ec1e6d99ce2e38.diff
LOG
Author: Aiden Grossman
Date: 2025-08-01T17:30:24Z
New Revision: 4c80193a58a5c24e2bbebe291feb406191c4e2ab
URL:
https://github.com/llvm/llvm-project/commit/4c80193a58a5c24e2bbebe291feb406191c4e2ab
DIFF:
https://github.com/llvm/llvm-project/commit/4c80193a58a5c24e2bbebe291feb406191c4e2ab.diff
LOG
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/151614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/151614
>From bcf0fbab986c548840941da523987c8a8d5bedad Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 31 Jul 2025 23:55:14 +
Subject: [PATCH 1/3] [clang] Remove %T from tests
This patch removes %T
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/151615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,10 +1,12 @@
-// RUN: %clangxx -S -ftime-trace -ftime-trace-granularity=0 -o
%T/check-time-trace-ParseDeclarationOrFunctionDefinition %s
-// RUN: cat %T/check-time-trace-ParseDeclarationOrFunctionDefinition.json \
+// RUN: mkdir -p %t.dir
+// RUN: %clangxx -S -ftime-trace -f
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/151614
>From bcf0fbab986c548840941da523987c8a8d5bedad Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Thu, 31 Jul 2025 23:55:14 +
Subject: [PATCH 1/2] [clang] Remove %T from tests
This patch removes %T
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/151615
This patch removes the use of %T from crash-report-modules.m. %T has been
deprecated for about seven years, and is to be avoided as it can lead to races
between tests.
Posting this one as a separate pat
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/151614
This patch removes %T from clang lit tests. %T has been deprecated for about
seven years and is not reccomended as it is not unique to each test, which can
lead to races. This patch is intended to remove
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/151538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 ready_for_review
https://github.com/llvm/llvm-project/pull/151538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
boomanaiden154 wrote:
@evelez7 Do you have more details on what exactly you did within Graphite? Did
you try to merge multiple PRs in a stack or just the bottom one?
https://github.com/llvm/llvm-project/pull/150647
___
cfe-commits mailing list
cfe-com
boomanaiden154 wrote:
> Not sure if you know anything about this but maybe you can point me to
> someone who does. I think the newly required CI rules don't play nice with
> Graphite auto-merging. Graphites constantly rebases the branch when trying to
> merge, which will cause CI to trigger ag
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/148743
>From f511f7a3fbb802c59c7cbbe489355d93f9ab725a Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Mon, 14 Jul 2025 22:37:28 +
Subject: [PATCH 1/2] [CI][Github] Switch windows to server 2022
This pat
boomanaiden154 wrote:
https://github.com/llvm/llvm-project/blob/b5dbf8210a57b986b9802304745f4c5c108cf37b/libcxx/test/libcxx/language.support/support.c.headers/support.c.headers.other/math.lerp.verify.cpp#L9
Looks like this has occurred before and is just handled by disabling the test
on the lib
boomanaiden154 wrote:
Subsumed by 1fd7e4c517141ddfb527e7560e02fd5856244971.
https://github.com/llvm/llvm-project/pull/136078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/136078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/130522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/130522
This patch makes the assertion (that is currently in a comment) that validates
that names mangled by clang can be demangled by LLVM actually compile/work.
There were some minor issues that needed to be f
https://github.com/boomanaiden154 approved this pull request.
Changes to `__cpuidex_conflict.c` LGTM. I will put that on my TODO list.
https://github.com/llvm/llvm-project/pull/121839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
@@ -1818,8 +1819,21 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) {
// usual allocation and deallocation functions. Required by libc++
return 201802;
default:
+// We may get here because of aux builtins which may not be
+
https://github.com/boomanaiden154 approved this pull request.
Is the cleanup just running `black`? Would be better committed separately in my
opinion. Either way, LGTM for both the cleanup and the test change.
https://github.com/llvm/llvm-project/pull/119666
boomanaiden154 wrote:
> Hm, or it's not related to the testcase, but it happens every time we build
> now due to
> https://github.com/llvm/llvm-project/commit/6bec1806c9cc90f6e72fc04698f4221c86c5f95e
That's more likely to be due to #111513. That got reverted. If it's still an
issue here, let
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/118154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 ready_for_review
https://github.com/llvm/llvm-project/pull/118154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
boomanaiden154 wrote:
Closing in favor of #111513 / #118154.
https://github.com/llvm/llvm-project/pull/113739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/113739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
boomanaiden154 wrote:
> That and to also ensure that the edited Format.h doesn't break the python
> script.
Makes sense. #118154 would cover that too.
> If we are to leave the generated part of the rst file in the repo,
> https://github.com/llvm/llvm-project/pull/111513 would satisfy my
> re
boomanaiden154 wrote:
> Whenever I review a pull request that has edited Format.h, I always fetch the
> PR and run the python script to ensure that the generated rst file matches
> the one in git. I don't think there's a way around that.
Thinking about this a bit more, I think we can probably
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/118154
This patch adds a lit test to clang format to ensure that the
ClangFormatStyleOptions doc page has been updated appropriately. The test just
runs the automatic update script and diffs the outputs to ensu
boomanaiden154 wrote:
> I'd personally like a solution that doesn't remove the
> ClangFormatStyleOptions.rst from the review
Could we just test that the output looks as expected? I think it would be
pretty easy to write a lit test that asserts all of the output is as expected.
That would then
boomanaiden154 wrote:
> I'm not concerned about how much time it takes to run. I want to add it to
> clangFormat's dependencies if it doesn't run every time I do ninja
> FormatTests.
I've updated the patch so that we only rerun the python script if the
dependencies change. I've added a `.temp
boomanaiden154 wrote:
> can we have clang-format-style-options rebuilt only when it's outdated, i.e.
> only if at least one of the following has been updated?
We can, but it requires more changes that I'm not sure are worth doing given
that this step takes essentially zero time compared to reg
@@ -143,8 +143,17 @@ if (LLVM_ENABLE_SPHINX)
gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs
../include/clang/Basic/Diagnostic.td "${docs_targets}")
gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs
../include/clang/Driver/ClangOptionDocs.td
@@ -143,8 +143,17 @@ if (LLVM_ENABLE_SPHINX)
gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs
../include/clang/Basic/Diagnostic.td "${docs_targets}")
gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs
../include/clang/Driver/ClangOptionDocs.td
boomanaiden154 wrote:
#113739 should fix this problem by just adding the options as part of the build
and omitting them from the documentation source.
https://github.com/llvm/llvm-project/pull/111513
___
cfe-commits mailing list
cfe-commits@lists.llvm
https://github.com/boomanaiden154 commented:
Two minor comments. Script otherwise seems reasonable enough to me.
https://github.com/llvm/llvm-project/pull/113447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
boomanaiden154 wrote:
> True, however for libc++ the benefits are smaller because we run only libc++
> specific job in the BuildKite job. I've never had trouble with figuring out
> what part of a job has caused failures. Either way, like I said I'm fine with
> the patch, it seems like an impro
@@ -0,0 +1,328 @@
+# Script to parse many JUnit XML result files and send a report to the
buildkite
+# agent as an annotation.
+#
+# To run the unittests:
+# python3 -m unittest discover -p generate_test_report.py
+
+import argparse
+import unittest
+from io import StringIO
+from
boomanaiden154 wrote:
> I'd rather not do that. Commenting on the PR should be done very rarely,
> especially for CI failures, since it clutters the PR and Github already has a
> builtin system for presenting CI failures.
I think this is something that needs to be discussed further when we act
@@ -0,0 +1,328 @@
+# Script to parse many JUnit XML result files and send a report to the
buildkite
+# agent as an annotation.
+#
+# To run the unittests:
+# python3 -m unittest discover -p generate_test_report.py
+
+import argparse
+import unittest
+from io import StringIO
+from
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/113447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6,13 +6,23 @@
#include
+#if defined(__cplusplus) && (__cplusplus >= 201103L)
+constexpr bool match_m128(__m128 v, float x, float y, float z, float w) {
+ return v[0] == x && v[1] == y && v[2] == z && v[3] == w;
+}
+#define TEST_CONSTEXPR(...) static_assert(__VA_ARGS__)
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/112578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 approved this pull request.
This seems reasonable enough modulo refactoring test macros to a common spot if
reasonable.
This is certainly a lot cleaner than throwing all the constant expression tests
at the end of the file.
https://github.com/llvm/llvm-projec
boomanaiden154 wrote:
> Because only part of the doc is generated by dump_format_style.py.
It should still be possible to only include the non-generated parts in the repo
and then modify the script to add all the generated components on afterwards as
a build step? Not sure if I'm missing somet
https://github.com/boomanaiden154 approved this pull request.
LGTM.
Adding this to the default perf training I think makes quite a bit of sense
given the numbers reported. Not sure what thoughts others have on that though.
https://github.com/llvm/llvm-project/pull/111625
__
@@ -0,0 +1,2 @@
+RUN: %cmake -G %cmake_generator -B %t -S %llvm_src_dir
-DCMAKE_C_COMPILER=%clang -DCMAKE_CXX_COMPILER=%clang
-DCMAKE_CXX_FLAGS="--driver-mode=g++" -DCMAKE_BUILD_TYPE=Release
boomanaiden154 wrote:
Ah, makes sense. Seems reasonable enough to me!
https://github.com/boomanaiden154 commented:
This looks very interesting!
Thanks for taking the time to collect all the numbers. It definitely seems like
collecting proper profiles for BOLT is something that we want to do, at least
for the CI compiler, given the numbers here.
I'm assuming you
@@ -0,0 +1,2 @@
+RUN: %cmake -G %cmake_generator -B %t -S %llvm_src_dir
-DCMAKE_C_COMPILER=%clang -DCMAKE_CXX_COMPILER=%clang
-DCMAKE_CXX_FLAGS="--driver-mode=g++" -DCMAKE_BUILD_TYPE=Release
boomanaiden154 wrote:
Why the `--driver-mode=g++` flag here?
https://
@@ -34,8 +34,12 @@ config.test_format = lit.formats.ShTest(use_lit_shell == "0")
config.substitutions.append( ('%clang_cpp_skip_driver', ' %s %s %s ' %
(cc1_wrapper, config.clang, sysroot_flags)))
config.substitutions.append( ('%clang_cpp', ' %s --driver-mode=g++ %s ' %
(confi
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/111625
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
boomanaiden154 wrote:
> That's an excellent question, maybe @owenca will know! I should have asked in
> https://github.com/llvm/llvm-project/pull/96804#discussion_r1718407404; what
> I did instead was try to reason out an explanation based on what I could see,
> and I came up with two theories
https://github.com/boomanaiden154 requested changes to this pull request.
The documentation build workflow is not really the correct place to put this.
Also, why can't we just run the python script as part of building the docs
instead of committing the result of the script to the repository?
h
https://github.com/boomanaiden154 approved this pull request.
LGTM, assuming precommit CI passes.
https://github.com/llvm/llvm-project/pull/110384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
@@ -1151,6 +1151,25 @@ static const char
*getAMDProcessorTypeAndSubtype(unsigned Family,
break; // "znver4"
}
break; // family 19h
+ case 26:
boomanaiden154 wrote:
Oh, looks like I missed it. Sorry about that!
There's https://github.com/llvm/
@@ -1151,6 +1151,25 @@ static const char
*getAMDProcessorTypeAndSubtype(unsigned Family,
break; // "znver4"
}
break; // family 19h
+ case 26:
boomanaiden154 wrote:
I posted some patches a while ago to start unifying things so that there's a
s
@@ -1151,6 +1151,25 @@ static const char
*getAMDProcessorTypeAndSubtype(unsigned Family,
break; // "znver4"
}
break; // family 19h
+ case 26:
boomanaiden154 wrote:
Can you bump the equivalent code in `compiler-rt` too?
https://github.com/llvm
boomanaiden154 wrote:
> That PR is 3 months old? What are the odds or the timeline of it getting
> merged?
Probably whenever the author gets back to reviewers. There might be a couple
rounds of review before things get pushed through, but patches for two
subprojects have landed already.
The
https://github.com/boomanaiden154 edited
https://github.com/llvm/llvm-project/pull/80713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/97785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 199 matches
Mail list logo
