[PATCH] D157990: [clangd] Add --query-driver flag to clangd-indexer

tetsuo-cpp added a comment. Thanks for the review @nridge! I'd really appreciate if you could help me with the commit (I don't have commit access). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157990/new/ https://reviews.llvm.org/D157990

[PATCH] D157990: [clangd] Add --query-driver flag to clangd-indexer

tetsuo-cpp created this revision. tetsuo-cpp added reviewers: sammccall, nridge. tetsuo-cpp added projects: clang-tools-extra, All. Herald added subscribers: kadircet, arphaman. tetsuo-cpp requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. When using `clangd` for

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp added a comment. Friendly ping @njames93. Does this look ok to you? If so, could you please help me with the commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-commits mailing

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp marked an inline comment as done. tetsuo-cpp added a comment. @aaron.ballman Thanks! I took your suggestion and I think this looks cleaner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp updated this revision to Diff 280082. tetsuo-cpp added a comment. Cleanup check conditional. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 Files: clang-tools-extra/clang-tidy/bugprone/BoolPointerImplicitConversionCheck.cpp

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp added a comment. Friendly ping. Could I please get this looked at? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp added a comment. Friendly ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp updated this revision to Diff 276022. tetsuo-cpp added a comment. Address comments: Rename variables, remove unnecessary tests and avoid unnecessary check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 Files:

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp updated this revision to Diff 275592. tetsuo-cpp added a comment. Remove the unnecessary template. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 Files: clang-tools-extra/clang-tidy/bugprone/BoolPointerImplicitConversionCheck.cpp

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp created this revision. tetsuo-cpp added reviewers: njames93, MaskRay. tetsuo-cpp added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=45189 This patch is adding support for members to the

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

tetsuo-cpp added a comment. In D75901#1920397 , @njames93 wrote: > In D75901#1916119 , @tetsuo-cpp > wrote: > > > @njames93 @MaskRay > > Thanks for helping me with testing. I'll remember this for next time. > >

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

tetsuo-cpp marked an inline comment as done. tetsuo-cpp added a comment. @njames93 @MaskRay Thanks for helping me with testing. I'll remember this for next time. I also saw this pattern of retrieving `LangOptions` from an `ASTContext` in some other checks (`RedundantExpressionCheck` and

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

tetsuo-cpp updated this revision to Diff 249538. tetsuo-cpp added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75901/new/ https://reviews.llvm.org/D75901 Files: clang-tools-extra/clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

tetsuo-cpp created this revision. tetsuo-cpp added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. tetsuo-cpp added reviewers: njames93, MaskRay. Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=27702 I wasn't sure how this type of

[PATCH] D67037: [ClangFormat] Add new style option IndentGotoLabels

tetsuo-cpp added a comment. @MyDeveloperDay Thanks for your suggestions! I think it's better now. This is my first LLVM patch (hopefully first of many) so I don't have commit permissions yet. If you're still happy with this change, could you please commit on my behalf? Repository: rC Clang

[PATCH] D67037: [ClangFormat] Add new style option IndentGotoLabels

tetsuo-cpp updated this revision to Diff 219582. tetsuo-cpp added a comment. Addressed review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67037/new/ https://reviews.llvm.org/D67037 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D67037: [ClangFormat] Add new style option IndentGotoLabels

tetsuo-cpp added a comment. Friendly ping. Could I please get this looked at? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67037/new/ https://reviews.llvm.org/D67037 ___ cfe-commits mailing list

[PATCH] D67037: [ClangFormat] Add new style option IndentGotoLabels

tetsuo-cpp created this revision. tetsuo-cpp added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option determines whether goto labels are indented according to scope. Setting this option to false causes goto labels to be flushed to the left.