ayermolo wrote:
Fixed our internal foobar yesterday. Can close this.
https://github.com/llvm/llvm-project/pull/89266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayermolo wrote:
Thanks.
It's failing internally in our automatic multi stage build. Trying to dig into
it as part of my oncall. :)
https://github.com/llvm/llvm-project/pull/89266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ayermolo wrote:
I am seeing a cmake error in one of the build steps in our enviroment:
```
CMake Error at CMakeLists.txt:86 (get_property):
get_property could not find TARGET clang-resource-headers. Perhaps it has
not yet been created.
```
Reverting this diff internally made build pass.
ayermolo wrote:
@usx95 can you repro?
Also is there ETA on a fix, and if not can you revert this?
https://github.com/llvm/llvm-project/pull/85398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ayermolo wrote:
I think this commit is causing build failure when building clangd in debug mode
with clang built in release mode.
```
Instruction does not dominate all uses!
%K1104 = getelementptr inbounds %"struct.llvm::json::Object::KV", ptr
%arrayinit.begin1100, i32 0, i32 0, !dbg !93928
ayermolo wrote:
It's been 24 hours with no broken build bots. So I guess this one got it right.
:)
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/ayermolo closed
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayermolo wrote:
@dwblaikie ping
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,7 +11,6 @@
// NOINLINE-NOT: "-fsplit-dwarf-inlining"
// SPLIT-NOT: "-dumpdir"
// SPLIT: "-debug-info-kind=constructor"
-// SPLIT-SAME: "-ggnu-pubnames"
ayermolo wrote:
At least on my mac it passed. With that check.
I double checked, and this is
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,7 +11,6 @@
// NOINLINE-NOT: "-fsplit-dwarf-inlining"
// SPLIT-NOT: "-dumpdir"
// SPLIT: "-debug-info-kind=constructor"
-// SPLIT-SAME: "-ggnu-pubnames"
ayermolo wrote:
Oh I see!
Thanks for clarification.
That check should be there. I think it
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/83331
>From 7d58760a887fc935e2af670f8aa721cdd5946391 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Fri, 23 Feb 2024 14:52:04 -0800
Subject: [PATCH 1/2] [CLANG][DWARF] Do not emit -ggnu-pubnames for split
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,7 +11,6 @@
// NOINLINE-NOT: "-fsplit-dwarf-inlining"
// SPLIT-NOT: "-dumpdir"
// SPLIT: "-debug-info-kind=constructor"
-// SPLIT-SAME: "-ggnu-pubnames"
ayermolo wrote:
Sorry not sure I follow.
As discussed in original diff the idea is if
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/83331
>From 7d58760a887fc935e2af670f8aa721cdd5946391 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Fri, 23 Feb 2024 14:52:04 -0800
Subject: [PATCH] [CLANG][DWARF] Do not emit -ggnu-pubnames for split
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/83331
>From 668819ef921ecb4d0ef704c2269ea07acd1b5334 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Fri, 23 Feb 2024 14:52:04 -0800
Subject: [PATCH] [CLANG][DWARF] Do not emit -ggnu-pubnames for split
ayermolo wrote:
Another attempt. Had to return original
https://github.com/llvm/llvm-project/pull/82840 because it was breaking a test
on mac.
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo created
https://github.com/llvm/llvm-project/pull/83331
When -gsplit-dwarf is passed in clang emmmits -ggnu-pubnames which
results in
.debug_gnu_pubnames/..debug_gnu_pubtypes being generated.
This is used by GDB, but not by LLDB.
Changed so that these sections are
https://github.com/ayermolo closed
https://github.com/llvm/llvm-project/pull/83206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo closed
https://github.com/llvm/llvm-project/pull/83214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayermolo wrote:
revert https://github.com/llvm/llvm-project/pull/83214
https://github.com/llvm/llvm-project/pull/83206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo created
https://github.com/llvm/llvm-project/pull/83214
Reverts llvm/llvm-project#82840
>From 58007120dfbc69ccfdf04ae1eb71b30e3582b435 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich <43973793+ayerm...@users.noreply.github.com>
Date: Tue, 27 Feb 2024 16:40:45
ayermolo wrote:
> I don't know if this is correct.
>
> Maybe just add a triple to the problematic clang invocation for now and have
> this reviewed by a local expert while trunk isn't broken?
ok
https://github.com/llvm/llvm-project/pull/83206
___
ayermolo wrote:
https://github.com/llvm/llvm-project/pull/83206
https://github.com/llvm/llvm-project/pull/82840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayermolo wrote:
Test passes on mac
https://github.com/llvm/llvm-project/pull/83206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/ayermolo created
https://github.com/llvm/llvm-project/pull/83206
This is a fix for https://github.com/llvm/llvm-project/pull/82840. On mac
tunning is by default LLDB. If the flag was passed in to clang after that PR it
would not have been passed in by the driver.
>From
ayermolo wrote:
> It's been a few hours. Time to revert and analyze offline?
I think I have a fix. Just takes forever to setup and build on my laptop to
test it.
Basically I think mac defaults to LLDB tuning, and test that fails explicitly
passes the flag in.
ayermolo wrote:
> Looks this breaks tests on macOS: http://45.33.8.238/macm1/79435/step_7.txt
>
> Please take a look and revert for now if it takes a while to fix.
> Looks this breaks tests on macOS: http://45.33.8.238/macm1/79435/step_7.txt
>
> Please take a look and revert for now if it
https://github.com/ayermolo closed
https://github.com/llvm/llvm-project/pull/82840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/82840
>From 1ac054cc8d5ee99169547ae09da0411b6e8e48e8 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Fri, 23 Feb 2024 14:52:04 -0800
Subject: [PATCH 1/2] [CLANG][DWARF] Do not emit -ggnu-pubnames for split
ayermolo wrote:
Changed to tunning.
https://github.com/llvm/llvm-project/pull/82840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/82840
>From 714cc804f2716bbd3c666d8922403299e4c19893 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Fri, 23 Feb 2024 14:52:04 -0800
Subject: [PATCH 1/2] [CLANG][DWARF] Do not emit -ggnu-pubnames for split
https://github.com/ayermolo created
https://github.com/llvm/llvm-project/pull/82840
When -gsplit-dwarf is passed in clang emmmits -ggnu-pubnames which results in
.debug_gnu_pubnames/..debug_gnu_pubtypes being generated. For DWARF5 we have
functional .debug_names.
TBH not sure what the right
ayermolo wrote:
Hmm, interesting. Thanks for the fix.
https://github.com/llvm/llvm-project/pull/79238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayermolo wrote:
> However, the patch broke the [Solaris/sparcv9
> buildbot](https://lab.llvm.org/buildbot/#/builders/72/builds/1834):
>
> ```
> llc: error: unable to get target for 'x86_64-unknown-linux-gnu', see
> --version and --triple.
> ```
>
> The bot is configured to do a Sparc-only
ayermolo wrote:
> Could this be caused by the patch
> https://lab.llvm.org/buildbot/#/builders/236/builds/8673 ?
Passes for me locally. Also patch impacts .debug_names for DWARF. So highly
unlikely it would cause this test to fail.
https://github.com/llvm/llvm-project/pull/77511
https://github.com/ayermolo closed
https://github.com/llvm/llvm-project/pull/77511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/77511
>From 5e6ee63fabac0dabc692c00d3c017e2542c98273 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Tue, 9 Jan 2024 10:51:55 -0800
Subject: [PATCH 1/5] [LLVM][DWARF] Fix accelerator swtiching with TU
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/77511
>From 5e6ee63fabac0dabc692c00d3c017e2542c98273 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Tue, 9 Jan 2024 10:51:55 -0800
Subject: [PATCH 1/4] [LLVM][DWARF] Fix accelerator swtiching with TU
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/77511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/77511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/77511
>From 5e6ee63fabac0dabc692c00d3c017e2542c98273 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Tue, 9 Jan 2024 10:51:55 -0800
Subject: [PATCH 1/3] [LLVM][DWARF] Fix accelerator swtiching with TU
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/77511
>From 5e6ee63fabac0dabc692c00d3c017e2542c98273 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Tue, 9 Jan 2024 10:51:55 -0800
Subject: [PATCH 1/2] [LLVM][DWARF] Fix accelerator swtiching with TU
ayermolo wrote:
There is another bug on when we exit from addDwarfTypeUnitType. I need to
construct a small repro for it.
https://github.com/llvm/llvm-project/pull/77511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/ayermolo created
https://github.com/llvm/llvm-project/pull/77511
This bug is triggered when a TU is already created, and we process the same
DICompositeType at a top level. We would switch to TU accelerator table, but
would not switch back on early exit. As the result we
https://github.com/ayermolo created
https://github.com/llvm/llvm-project/pull/72729
Fixed handling of DWP as input. Before BOLT crashed. Now it will write out
correct CU, and all the TUs. Potential future improvement is to scan all the TUs
used in this CU, and only include those.
>From
https://github.com/ayermolo closed
https://github.com/llvm/llvm-project/pull/70512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/70512
>From 1c6a604df93b833c3bb9c7d34f4f27415592dbe5 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Thu, 5 Oct 2023 12:39:02 -0700
Subject: [PATCH] [LLVM][DWARF] Add support for monolithic types in
From: David Blaikie via Phabricator
Sent: Monday, December 7, 2020 11:08 AM
To: Alexander Yermolovich ; llvm-comm...@lists.llvm.org
Cc: Hongtao Yu ; jan_svob...@apple.com ;
steve...@apple.com ; dany.grumb...@gmail.com
; Wenlei He ; dexonsm...@apple.com
;
52 matches
Mail list logo
