[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

https://github.com/aganea closed https://github.com/llvm/llvm-project/pull/89950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

https://github.com/aganea updated https://github.com/llvm/llvm-project/pull/89950 >From 13c411018e491fc2be4f4118a56f9b8cf2e5b76f Mon Sep 17 00:00:00 2001 From: Alexandre Ganea Date: Wed, 17 Apr 2024 16:28:21 -0400 Subject: [PATCH 1/5] [clang-scan-deps] Expand response files before the

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

aganea wrote: @jansvoboda11 Do you see any further changes for this PR? Can I land it? https://github.com/llvm/llvm-project/pull/89950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

aganea wrote: Ping @jansvoboda11! Are you able to get back to this soon? LG generally, just missing a test case above. Thanks! https://github.com/llvm/llvm-project/pull/88800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Distinguish unresolved templates in UnresolvedLookupExpr (PR #89019)

aganea wrote: Hello, This causes a warning when building LLDB on Windows, `clang::BuiltinType::UnresolvedTemplate` isn't handled in the case in the file indicated below (sorry my locale is French). Would you have a chance to take a look @zyn0217 please? ``` [6325/7521] Building CXX object

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/89950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

@@ -792,10 +792,15 @@ int clang_scan_deps_main(int argc, char **argv, const llvm::ToolContext &) { llvm::cl::PrintOptionValues(); + // Expand response files in advance, so that we can "see" all the arguments + // when adjusting below. + auto ResponseExpander =

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

@@ -0,0 +1,36 @@ +// Check that the scanner can adjust arguments by reading .rsp files in advance. + +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: sed -e "s|DIR|%/t|g" %t/cdb.json.template > %t/cdb.json +// RUN: echo /Fo%t/tu.obj >> %t/args_nested.rsp

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

@@ -0,0 +1,36 @@ +// Check that the scanner can adjust arguments by reading .rsp files in advance. + +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: sed -e "s|DIR|%/t|g" %t/cdb.json.template > %t/cdb.json aganea wrote: As suggested. We're taking a

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

@@ -1069,7 +1069,7 @@ void Clang::AddPreprocessingOptions(Compilation , const JobAction , // If user provided -o, that is the dependency target, except // when we are only generating a dependency file. - Arg *OutputOpt = Args.getLastArg(options::OPT_o); +

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

https://github.com/aganea updated https://github.com/llvm/llvm-project/pull/89950 >From f2340c98c95e0d72516fc240ff268fead9f15391 Mon Sep 17 00:00:00 2001 From: Alexandre Ganea Date: Wed, 17 Apr 2024 16:28:21 -0400 Subject: [PATCH 1/5] [clang-scan-deps] Expand response files before the

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

aganea wrote: Thanks for pointing that out @MaskRay ! https://github.com/llvm/llvm-project/pull/88427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

https://github.com/aganea closed https://github.com/llvm/llvm-project/pull/88427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

aganea wrote: @jansvoboda11 PTAL. I've added handling of `/Fo` in the driver, and that solves my case without the .rsp expansion in `ClangScanDeps.cpp`. However if we pass `/E` to command-lines in the CDB, that change alone doesn't work anymore. This is because `Driver::GetNamedOutputPath()`

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

https://github.com/aganea updated https://github.com/llvm/llvm-project/pull/89950 >From f2340c98c95e0d72516fc240ff268fead9f15391 Mon Sep 17 00:00:00 2001 From: Alexandre Ganea Date: Wed, 17 Apr 2024 16:28:21 -0400 Subject: [PATCH 1/3] [clang-scan-deps] Expand response files before the

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

https://github.com/aganea updated https://github.com/llvm/llvm-project/pull/89950 >From f2340c98c95e0d72516fc240ff268fead9f15391 Mon Sep 17 00:00:00 2001 From: Alexandre Ganea Date: Wed, 17 Apr 2024 16:28:21 -0400 Subject: [PATCH 1/2] [clang-scan-deps] Expand response files before the

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

aganea wrote: The reason of this `/Fo` output path fiddling code is this: https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L1072-L1082 It's because that highlighted code doesn't handle the clang-cl case, it doesn't consider `/Fo`. Probably because most

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

aganea wrote: This is missing a test, I will add one. https://github.com/llvm/llvm-project/pull/89950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Expand response files before the argument adjuster (PR #89950)

https://github.com/aganea created https://github.com/llvm/llvm-project/pull/89950 Previously, since response (.rsp) files weren't expanded at the very beginning of clang-scan-deps, we only parsed the command-line as provided in the Clang .cdb file. Unfortunately, when using Unreal Engine,

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

aganea wrote: > LGTM, thanks! Thanks for the review! > (Out of interest, what machine are you seeing the contention with?) It's a ThreadRipper Pro 3975WX 32c/64t running on with Windows 11. https://github.com/llvm/llvm-project/pull/88427 ___

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

@@ -1293,6 +1293,10 @@ compileModuleImpl(CompilerInstance , SourceLocation ImportLoc, diag::remark_module_build_done) << ModuleName; + // Propagate the statistics to the parent FileManager. + if

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

https://github.com/aganea updated https://github.com/llvm/llvm-project/pull/88427 >From 1b11d526e2cde1df64c7c4e05b2698b6d40926c3 Mon Sep 17 00:00:00 2001 From: Alexandre Ganea Date: Thu, 11 Apr 2024 13:02:30 -0400 Subject: [PATCH 1/3] [clang-scan-deps] Fix atomic contention when updating

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

aganea wrote: > As an alternative approach: could we turn these into member variables, make > them non-atomic and take care to update the stats of the superior > `FileManager` whenever an inferior `FileManager` goes out of scope? (e.g. > after implicitly building a module) As suggested.

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

https://github.com/aganea updated https://github.com/llvm/llvm-project/pull/88427 >From 1b11d526e2cde1df64c7c4e05b2698b6d40926c3 Mon Sep 17 00:00:00 2001 From: Alexandre Ganea Date: Thu, 11 Apr 2024 13:02:30 -0400 Subject: [PATCH 1/2] [clang-scan-deps] Fix atomic contention when updating

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/88800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

@@ -201,11 +201,8 @@ const CachedRealPath ::CacheShard:: return *StoredRealPath; } -static bool shouldCacheStatFailures(StringRef Filename) { - StringRef Ext = llvm::sys::path::extension(Filename); - if (Ext.empty()) -return false; // This may be the module cache

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

@@ -362,7 +357,7 @@ DependencyScanningWorkerFilesystem::openFileForRead(const Twine ) { SmallString<256> OwnedFilename; StringRef Filename = Path.toStringRef(OwnedFilename); - if (Filename.ends_with(".pcm")) + if (shouldBypass(Filename)) aganea wrote:

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

@@ -174,3 +174,30 @@ TEST(DependencyScanningFilesystem, CacheStatOnExists) { EXPECT_EQ(InstrumentingFS->NumStatusCalls, 2u); EXPECT_EQ(InstrumentingFS->NumExistsCalls, 0u); } + +TEST(DependencyScanningFilesystem, CacheStatFailures) { + auto InMemoryFS =

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

aganea wrote: I think in the short term @jansvoboda11's suggestion should be good enough. Bit if we want `Statistics` to be always cheap, we should make them `thread_local` instead, not atomic. `getValue()` could do the "collection" of data over all active, or past threads. It would also

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/88427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/88427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Fix contention when updating `TrackingStatistic`s in hot code paths in `FileManager`. (PR #88427)

https://github.com/aganea created https://github.com/llvm/llvm-project/pull/88427 `FileManager::getDirectoryRef` and `FileManager::getFileRef` are hot code paths in `clang-scan-deps`. In these functions, we update a couple of atomic variables related to printing statistics, which causes

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

aganea wrote: > In the meantime, are you able to work around this for your non-modular > use-case by applying your change when building your own compiler downstream? Yes I fixed it in our downstream. I am more worried about other users, since the initial version that @hyp committed a while

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

aganea wrote: > > Not sure @jansvoboda11 perhaps if we want to cherry pick > > [b768a8c](https://github.com/llvm/llvm-project/commit/b768a8c1db85b9e84fd8b356570a3a8fbe37acf6) > > on `release/18.x`? Or should we land just a simple PR with just the > > function change above? > > I can try

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

@@ -201,6 +201,21 @@ class ErrorDummyFileSystem : public DummyFileSystem { } }; +/// A version of \c DummyFileSystem that aborts on \c status() to test that +/// \c exists() is being used. +class NoStatusDummyFileSystem : public DummyFileSystem { +public: + ErrorOr

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

https://github.com/aganea approved this pull request. Otherwise this PR LGTM. https://github.com/llvm/llvm-project/pull/88152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/88152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

aganea wrote: > This patch doesn`t improve my usage, it seems I'm hitting a different > codepath than you do. I'll investigate. Ah I see, the commit https://github.com/llvm/llvm-project/commit/b768a8c1db85b9e84fd8b356570a3a8fbe37acf6 didn't make it in time for the 18.x branch. The issue I'm

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

aganea wrote: This patch doesn`t improve my usage, it seems I'm hitting a different codepath than you do. I'll investigate. https://github.com/llvm/llvm-project/pull/88152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

@@ -270,6 +270,12 @@ DependencyScanningWorkerFilesystem::status(const Twine ) { return Result->getStatus(); } +bool +DependencyScanningWorkerFilesystem::exists(const Twine ) { + auto Status = status(Path); aganea wrote: The return type is unclear at

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

https://github.com/aganea commented: Thanks for the change! Quite interestingly I was just looking precisely at this issue today :smile: Things are worst on Windows, where mini-filter drivers kick-in and bring performance to its knees. I'll try your patch, see how that improves my usage!

[clang] [llvm] [clang][deps] Overload `Filesystem::exists` in `DependencyScanningFilesystem` to have it use cached `status` (PR #88152)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/88152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Rename `ThreadPool::getThreadCount()` to `getMaxConcurrency()` (NFC) (PR #82296)

https://github.com/aganea approved this pull request. Lg, thanks! https://github.com/llvm/llvm-project/pull/82296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ee15e2b - [clang] Silence warning when building with MSVC targetting x86

Author: Alexandre Ganea Date: 2024-01-25T09:34:17-05:00 New Revision: ee15e2bd32a4677c40d927c732b26d33f88d7865 URL: https://github.com/llvm/llvm-project/commit/ee15e2bd32a4677c40d927c732b26d33f88d7865 DIFF:

[clang-tools-extra] f33f5a0 - [clangd] Silence warning when compiling with MSVC targetting x86

Author: Alexandre Ganea Date: 2024-01-25T09:34:17-05:00 New Revision: f33f5a04e9feeb9b473694825d84da8322f87df9 URL: https://github.com/llvm/llvm-project/commit/f33f5a04e9feeb9b473694825d84da8322f87df9 DIFF:

[clang] 419d6ea - [clang] Silence warning when compiling with MSVC targetting x86

Author: Alexandre Ganea Date: 2024-01-25T09:34:17-05:00 New Revision: 419d6ea135dd205e1eaab368a58ae14f9f52f699 URL: https://github.com/llvm/llvm-project/commit/419d6ea135dd205e1eaab368a58ae14f9f52f699 DIFF:

[clang] [llvm] [clang][MBD] set up module build daemon infrastructure (PR #67562)

aganea wrote: Can you please send separate PRs for the Support changes? https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [lld] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

https://github.com/aganea closed https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [llvm] [clang] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [llvm] [clang] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [clang] [llvm] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

aganea wrote: @MaskRay Can you please take another look? https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [clang] [llvm] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [clang] [llvm] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

https://github.com/aganea updated https://github.com/llvm/llvm-project/pull/76306 >From 8187e95ea4e04793fbfc85045aa21f9633bbc03d Mon Sep 17 00:00:00 2001 From: Alexandre Ganea Date: Sat, 23 Dec 2023 19:17:06 -0500 Subject: [PATCH 1/2] [llvm-driver] Fix tool re-entrance on Windows. Previously,

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

@@ -3838,13 +3838,13 @@ void MicrosoftMangleContextImpl::mangleSEHFinallyBlock( Mangler.mangleName(EnclosingDecl); } -void MicrosoftMangleContextImpl::mangleTypeName( +void MicrosoftMangleContextImpl::mangleCanonicalTypeName( QualType T, raw_ostream , bool

[clang] Update GoogleTest to v1.14.0 (PR #65823)

aganea wrote: I managed to repro. It is actually this, still open, issue: https://github.com/microsoft/STL/issues/1066 https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Update GoogleTest to v1.14.0 (PR #65823)

aganea wrote: @zmodem I haven’t been able to repro with the recipe posted on https://crbug.com/1487548. I am using latest rpmalloc (main branch), latest VS 2022, latest WinSDK. I am running on Win11, on a AMD Ryzen9 CPU. Are you running on WinServer2022? Are able to give more precision on the

[clang] Update GoogleTest to v1.14.0 (PR #65823)

aganea wrote: @zmodem Can you add `ENABLE_ASSERTS` on [this line](https://github.com/llvm/llvm-project/blob/720e3bacbd9fdba05645a4d621d43ad712c44df3/llvm/lib/Support/CMakeLists.txt#L107) and run the test again, see if that gives something interesting?

[clang] eded23d - [Clang] Silence a "unused variable" warning when building with MSVC

Author: Alexandre Ganea Date: 2023-01-09T23:45:20-05:00 New Revision: eded23dfdaf050793b70351d5f42400016d57c15 URL: https://github.com/llvm/llvm-project/commit/eded23dfdaf050793b70351d5f42400016d57c15 DIFF:

[clang] ae918c7 - [clang-format] Add .inc extension to git-clang-format

Author: Alexandre Ganea Date: 2022-12-03T09:24:03-05:00 New Revision: ae918c78b51ae7e19053b9ae9deb9fee35084256 URL: https://github.com/llvm/llvm-project/commit/ae918c78b51ae7e19053b9ae9deb9fee35084256 DIFF:

[clang] 49e483d - [CodeView] Replace GHASH hasher by BLAKE3

Author: Alexandre Ganea Date: 2022-11-19T15:17:42-05:00 New Revision: 49e483d3d62f6f62beb323e9c4160bab9e0ad619 URL: https://github.com/llvm/llvm-project/commit/49e483d3d62f6f62beb323e9c4160bab9e0ad619 DIFF:

[clang] 0880b9d - [Clang][unittests] Silence trucation warning with MSVC 2022

Author: Alexandre Ganea Date: 2022-07-05T20:31:54-04:00 New Revision: 0880b9d52620ca3c46456095f6040a2e4de6c871 URL: https://github.com/llvm/llvm-project/commit/0880b9d52620ca3c46456095f6040a2e4de6c871 DIFF:

[clang] 18f230a - [Clang] Silence warning when building with MSVC 2022

Author: Alexandre Ganea Date: 2022-07-05T20:31:54-04:00 New Revision: 18f230a89aa234ac58be4fb8cee2bfa95ea67be4 URL: https://github.com/llvm/llvm-project/commit/18f230a89aa234ac58be4fb8cee2bfa95ea67be4 DIFF:

[clang] 5fa4cf8 - [Clang] Separate the 'debug-info-hotpatch' test in two parts: one for ARM and another for AArch64

Author: Alexandre Ganea Date: 2022-01-20T14:11:10-05:00 New Revision: 5fa4cf82dfa075e7983ce92d0042480b7b8f4fbc URL: https://github.com/llvm/llvm-project/commit/5fa4cf82dfa075e7983ce92d0042480b7b8f4fbc DIFF:

[clang] 5af2433 - [clang-cl] Support the /HOTPATCH flag

Author: Alexandre Ganea Date: 2022-01-20T12:57:19-05:00 New Revision: 5af2433e1794ebf7e58e848aa612c7912d71dc78 URL: https://github.com/llvm/llvm-project/commit/5af2433e1794ebf7e58e848aa612c7912d71dc78 DIFF:

[clang] aba5b91 - Re-land [CodeView] Add full repro to LF_BUILDINFO record

Author: Alexandre Ganea Date: 2022-01-19T19:44:37-05:00 New Revision: aba5b91b699c556da0ee04418321b581bd33611e URL: https://github.com/llvm/llvm-project/commit/aba5b91b699c556da0ee04418321b581bd33611e DIFF:

[clang] a5af260 - Silence warning with MSVC compiler.

Author: Alexandre Ganea Date: 2022-01-06T16:51:37-05:00 New Revision: a5af260d3e8b00a3353e813b73f83391edbef493 URL: https://github.com/llvm/llvm-project/commit/a5af260d3e8b00a3353e813b73f83391edbef493 DIFF:

[clang] e32936a - [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

Author: Alexandre Ganea Date: 2022-01-03T13:29:08-05:00 New Revision: e32936aef4a2e7da471e84b72d3be3499adf0a21 URL: https://github.com/llvm/llvm-project/commit/e32936aef4a2e7da471e84b72d3be3499adf0a21 DIFF:

[clang] a282ea4 - Reland - [CodeView] Emit S_OBJNAME record

Author: Alexandre Ganea Date: 2021-12-21T19:02:14-05:00 New Revision: a282ea4898efe2b2e57a93b44e90c9e497520cfb URL: https://github.com/llvm/llvm-project/commit/a282ea4898efe2b2e57a93b44e90c9e497520cfb DIFF:

[clang] 5bb5142 - Revert [CodeView] Emit S_OBJNAME record

Author: Alexandre Ganea Date: 2021-12-21T19:02:14-05:00 New Revision: 5bb5142e80c9c6eb1a948d6d2ff4834e4e69741f URL: https://github.com/llvm/llvm-project/commit/5bb5142e80c9c6eb1a948d6d2ff4834e4e69741f DIFF:

[clang] d26520f - [Clang] Own the CommandLineArgs in CodeGenOptions

Author: Alexandre Ganea Date: 2021-12-21T17:41:35-05:00 New Revision: d26520f6f78785b0c4c296a8a992f2adb656c6ec URL: https://github.com/llvm/llvm-project/commit/d26520f6f78785b0c4c296a8a992f2adb656c6ec DIFF:

[clang] cd407f6 - [Clang] Fix build by restricting debug-info-objname.cpp test to x86.

Author: Alexandre Ganea Date: 2021-12-21T12:22:25-05:00 New Revision: cd407f6e52b09cce2bef24c74b7f36fedc94991b URL: https://github.com/llvm/llvm-project/commit/cd407f6e52b09cce2bef24c74b7f36fedc94991b DIFF:

[clang] 00ec441 - [Clang] debug-info-objname.cpp test: explictly encode a x86 target when using %clang_cl to avoid falling back to a native CPU triple.

Author: Alexandre Ganea Date: 2021-12-21T11:54:19-05:00 New Revision: 00ec441253048f5e30540ea26bb0a28c42a5fc18 URL: https://github.com/llvm/llvm-project/commit/00ec441253048f5e30540ea26bb0a28c42a5fc18 DIFF:

[clang] abd1cbf - [Clang] Disable debug-info-objname.cpp test on Unix until I sort out the issue.

Author: Alexandre Ganea Date: 2021-12-21T10:32:43-05:00 New Revision: abd1cbf5e543f0f114d2742e109ead7d7ddbf9c4 URL: https://github.com/llvm/llvm-project/commit/abd1cbf5e543f0f114d2742e109ead7d7ddbf9c4 DIFF:

[clang] f44e3fb - [CodeView] Emit S_OBJNAME record

Author: Alexandre Ganea Date: 2021-12-21T09:26:36-05:00 New Revision: f44e3fbadd15bc851c6e3c2a40ddf5f0a502151a URL: https://github.com/llvm/llvm-project/commit/f44e3fbadd15bc851c6e3c2a40ddf5f0a502151a DIFF:

[clang] 199c397 - Revert "[clang-scan-deps] Add support for clang-cl"

Author: Alexandre Ganea Date: 2021-04-19T17:45:18-04:00 New Revision: 199c39748292cbc89cd148a0d8364ebb1014ec38 URL: https://github.com/llvm/llvm-project/commit/199c39748292cbc89cd148a0d8364ebb1014ec38 DIFF:

[clang] bb26fa8 - [clang-scan-deps] Add support for clang-cl

Author: Sylvain Audi Date: 2021-04-17T14:22:51-04:00 New Revision: bb26fa8c286bf524ed9235c3e293ad22ecf3e984 URL: https://github.com/llvm/llvm-project/commit/bb26fa8c286bf524ed9235c3e293ad22ecf3e984 DIFF: https://github.com/llvm/llvm-project/commit/bb26fa8c286bf524ed9235c3e293ad22ecf3e984.diff

[clang] 488a19d - [clang-scan-deps] Support double-dashes in clang command lines

Author: Sylvain Audi Date: 2021-04-17T14:22:51-04:00 New Revision: 488a19d00cbaec479f8c5c298556d2246978f9e6 URL: https://github.com/llvm/llvm-project/commit/488a19d00cbaec479f8c5c298556d2246978f9e6 DIFF: https://github.com/llvm/llvm-project/commit/488a19d00cbaec479f8c5c298556d2246978f9e6.diff

[clang] 8fbc05a - [Windows] Add test coverage for line endings when rewriting includes

Author: Alexandre Ganea Date: 2021-04-06T15:38:19-04:00 New Revision: 8fbc05acd5531a8bb74f689699e8de2788bcb769 URL: https://github.com/llvm/llvm-project/commit/8fbc05acd5531a8bb74f689699e8de2788bcb769 DIFF:

[clang] e030ce3 - [Tooling] Handle compilation databases containing commands with double dashes

Author: Janusz Nykiel Date: 2021-03-24T16:01:47-04:00 New Revision: e030ce3ec790a0017ec789b4f487afec99e1cac9 URL: https://github.com/llvm/llvm-project/commit/e030ce3ec790a0017ec789b4f487afec99e1cac9 DIFF: https://github.com/llvm/llvm-project/commit/e030ce3ec790a0017ec789b4f487afec99e1cac9.diff

[clang] 3854b81 - [Clang][Driver] Fix read-after-free when using /clang:

Author: Alexandre Ganea Date: 2021-01-07T15:15:13-05:00 New Revision: 3854b81b0fd23adc9bab91bf68918d102dc31f51 URL: https://github.com/llvm/llvm-project/commit/3854b81b0fd23adc9bab91bf68918d102dc31f51 DIFF:

[clang] d015445 - Silence warning: comparison of integers of different signs: 'const unsigned int' and 'const long' [-Wsign-compare]

Author: Alexandre Ganea Date: 2021-01-07T13:01:06-05:00 New Revision: d0154456e61c5ab79e25fc9b8bb684ebdca3a7c2 URL: https://github.com/llvm/llvm-project/commit/d0154456e61c5ab79e25fc9b8bb684ebdca3a7c2 DIFF:

[clang] 69132d1 - [Clang] Reverse test to save on indentation. NFC.

Author: Alexandre Ganea Date: 2020-12-23T19:24:53-05:00 New Revision: 69132d12deae749a8e4c9def5498ffa354ce1fa6 URL: https://github.com/llvm/llvm-project/commit/69132d12deae749a8e4c9def5498ffa354ce1fa6 DIFF:

[clang] 1dbf05f - [ThinLTO][Documentation] Mention possible values for concurrency flags

Author: Alexandre Ganea Date: 2020-10-13T09:57:58-04:00 New Revision: 1dbf05f5b44db17dcd8520b032e83061189ff4f8 URL: https://github.com/llvm/llvm-project/commit/1dbf05f5b44db17dcd8520b032e83061189ff4f8 DIFF:

[clang] 66face6 - Re-land [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Author: Alexandre Ganea Date: 2020-10-08T20:49:17-04:00 New Revision: 66face6aa0f5f68de56067b0dff3295e47fdf66c URL: https://github.com/llvm/llvm-project/commit/66face6aa0f5f68de56067b0dff3295e47fdf66c DIFF:

[clang] f5314d1 - [Support] On Unix, let the CrashRecoveryContext return the signal code

Author: Alexandre Ganea Date: 2020-09-24T08:21:43-04:00 New Revision: f5314d15af4f4514103ea12c74cb208538b8bef5 URL: https://github.com/llvm/llvm-project/commit/f5314d15af4f4514103ea12c74cb208538b8bef5 DIFF:

[clang] 33ce275 - [Clang] Fix tests following rG087047144210

Author: Alexandre Ganea Date: 2020-08-26T11:32:46-04:00 New Revision: 33ce275fc156c8b015acfad918937028b2cc235c URL: https://github.com/llvm/llvm-project/commit/33ce275fc156c8b015acfad918937028b2cc235c DIFF:

[clang] 98e01f5 - Revert "Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record"

Author: Alexandre Ganea Date: 2020-08-17T15:49:18-04:00 New Revision: 98e01f56b0a117f0f32ed2f9b7d61e85830c URL: https://github.com/llvm/llvm-project/commit/98e01f56b0a117f0f32ed2f9b7d61e85830c DIFF:

[clang] a3036b3 - Re-Re-land: [CodeView] Add full repro to LF_BUILDINFO record

Author: Alexandre Ganea Date: 2020-08-10T13:36:30-04:00 New Revision: a3036b386383f1c1e9d32c2c8dba995087959da3 URL: https://github.com/llvm/llvm-project/commit/a3036b386383f1c1e9d32c2c8dba995087959da3 DIFF:

RE: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

Thanks for letting me know Eric. What test fails exactly? What config? De : Eric Christopher Envoyé : July 10, 2020 7:04 PM À : reviews+d80833+public+da87cf0eabdca...@reviews.llvm.org; Alexandre Ganea via Phabricator Cc : Alexandre Ganea ; Hans Wennborg ; Adrian McCarthy ; Martin Storsjo ;

[clang] 41d2813 - [PDB] Attempt fix for debug-info-codeview-buildinfo.c test

Author: Alexandre Ganea Date: 2020-07-10T18:52:52-04:00 New Revision: 41d2813a5faea1c18b7d329109e0287c5cd9ffea URL: https://github.com/llvm/llvm-project/commit/41d2813a5faea1c18b7d329109e0287c5cd9ffea DIFF:

[clang] 2ae0df5 - [CodeView] Revert 8374bf43634725dc02a262a77b5f940fca25938c and 403f9537924b8910ed4f741ed96c61f5e657915b

Author: Alexandre Ganea Date: 2020-06-18T16:18:46-04:00 New Revision: 2ae0df5be7408a79524743762b6c74953f31b805 URL: https://github.com/llvm/llvm-project/commit/2ae0df5be7408a79524743762b6c74953f31b805 DIFF:

[clang] cab3fc5 - Fix linker error in clang-fuzzer following 89ea0b05207d45c145fb525df554b3b986ae379b.

Author: Alexandre Ganea Date: 2020-06-18T10:07:31-04:00 New Revision: cab3fc53d2e173243a462e9c8e914af58ddbeaba URL: https://github.com/llvm/llvm-project/commit/cab3fc53d2e173243a462e9c8e914af58ddbeaba DIFF:

[clang] 8374bf4 - [CodeView] Fix generated command-line expansion in LF_BUILDINFO. Fix the 'pdb' entry which was previously a null reference, now an empty string.

Author: Alexandre Ganea Date: 2020-06-18T10:07:30-04:00 New Revision: 8374bf43634725dc02a262a77b5f940fca25938c URL: https://github.com/llvm/llvm-project/commit/8374bf43634725dc02a262a77b5f940fca25938c DIFF:

[clang] 403f953 - [CodeView] Add full repro to LF_BUILDINFO record

Author: Alexandre Ganea Date: 2020-06-18T09:17:15-04:00 New Revision: 403f9537924b8910ed4f741ed96c61f5e657915b URL: https://github.com/llvm/llvm-project/commit/403f9537924b8910ed4f741ed96c61f5e657915b DIFF:

[clang] a45409d - [Clang] Move clang::Job::printArg to llvm::sys::printArg. NFCI.

Author: Alexandre Ganea Date: 2020-06-18T09:17:13-04:00 New Revision: a45409d8855a1e4538990507ef25e9b51c090193 URL: https://github.com/llvm/llvm-project/commit/a45409d8855a1e4538990507ef25e9b51c090193 DIFF:

[clang] 89ea0b0 - [MC] Pass down argv0 & cc1 cmd-line to the back-end and store in MCTargetOptions

Author: Alexandre Ganea Date: 2020-06-18T09:17:14-04:00 New Revision: 89ea0b05207d45c145fb525df554b3b986ae379b URL: https://github.com/llvm/llvm-project/commit/89ea0b05207d45c145fb525df554b3b986ae379b DIFF:

[clang] 3483cdc - [Sema] Silence warnings when targeting x86 with VS2019 16.5.4

Author: Alexandre Ganea Date: 2020-05-06T09:11:59-04:00 New Revision: 3483cdc8344d9c2c08c3f12490df54cfa63b6838 URL: https://github.com/llvm/llvm-project/commit/3483cdc8344d9c2c08c3f12490df54cfa63b6838 DIFF:

[clang] 3ab3f3c - After 09158252f777c2e2f06a86b154c44abcbcf9bb74, fix build when -DLLVM_ENABLE_THREADS=OFF

Author: Alexandre Ganea Date: 2020-03-28T13:54:58-04:00 New Revision: 3ab3f3c5d5825476dc1be15992f7c964629de688 URL: https://github.com/llvm/llvm-project/commit/3ab3f3c5d5825476dc1be15992f7c964629de688 DIFF:

[clang] 0915825 - [ThinLTO] Allow usage of all hardware threads in the system

Author: Alexandre Ganea Date: 2020-03-27T10:20:58-04:00 New Revision: 09158252f777c2e2f06a86b154c44abcbcf9bb74 URL: https://github.com/llvm/llvm-project/commit/09158252f777c2e2f06a86b154c44abcbcf9bb74 DIFF:

[clang] 5896e2d - [Clang] Fix HIP tests when running on Windows with the LLVM toolchain is in the path

Author: Alexandre Ganea Date: 2020-03-23T16:54:48-04:00 New Revision: 5896e2df45dab7680be321ee63903431a673817b URL: https://github.com/llvm/llvm-project/commit/5896e2df45dab7680be321ee63903431a673817b DIFF:

  1   2   >