[PATCH] D148958: Size and element numbers are often swapped when calling calloc

gAlfonso-bit updated this revision to Diff 534244. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148958/new/ https://reviews.llvm.org/D148958 Files: clang/test/Analysis/malloc.mm clang/test/Analysis/uninit-vals.m clang/test/CodeGen/alloc-size.c

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

gAlfonso-bit updated this revision to Diff 534242. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148958/new/ https://reviews.llvm.org/D148958 Files: clang/test/Analysis/malloc.mm clang/test/Analysis/uninit-vals.m clang/test/CodeGen/alloc-size.c

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

gAlfonso-bit created this revision. gAlfonso-bit added a reviewer: MaskRay. Herald added a subscriber: Enna1. Herald added projects: Flang, All. gAlfonso-bit requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, jdoerfert. Herald added projects: clang, Sanitizers.

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit added a comment. @MaskRay Could you please commit this for me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139547/new/ https://reviews.llvm.org/D139547 ___ cfe-commits mailing list

[PATCH] D139485: [LLVM] Remove redundant .c_str() and .get() calls where they are not needed.

gAlfonso-bit updated this revision to Diff 481954. Herald added subscribers: cfe-commits, arichardson, emaste. Herald added a project: clang-tools-extra. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139485/new/ https://reviews.llvm.org/D139485 Files:

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit added a comment. @MaskRay How may I get commit permissions if I may ask? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139547/new/ https://reviews.llvm.org/D139547 ___ cfe-commits mailing

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit added a comment. @MaskRay This should be a quickie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139547/new/ https://reviews.llvm.org/D139547 ___ cfe-commits mailing list

[PATCH] D139580: Run clang-tidy on clang-tidy

gAlfonso-bit created this revision. gAlfonso-bit added projects: LLVM, clang-format, clang-tools-extra. Herald added subscribers: kadircet, carlosgalvezp, arphaman, zzheng, javed.absar, kbarton, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. gAlfonso-bit requested

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit created this revision. gAlfonso-bit added a reviewer: MaskRay. gAlfonso-bit added projects: clang, LLVM. Herald added a subscriber: StephenFan. Herald added a project: All. gAlfonso-bit requested review of this revision. Herald added a subscriber: cfe-commits. For Darwin, the boolean

[PATCH] D112367: [Clang][AST] Temporarily undefine IBAction/IBOutlet ObjC macros in attribute headers

gAlfonso-bit abandoned this revision. gAlfonso-bit added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This change is no longer necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112367/new/

[PATCH] D112367: [Clang][AST] Temporarily undefine IBAction/IBOutlet ObjC macros in attribute headers

gAlfonso-bit created this revision. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Taken from a downstream fork: https://github.com/apple/llvm-project/pull/3461/files. IBAction and IBOutlet are defined when compiling with

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. @dexonsmith Could you please commit this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new/ https://reviews.llvm.org/D110068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 380958. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new/ https://reviews.llvm.org/D110068 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. Any updates? I do not have commit permissions. @ahatanak CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new/ https://reviews.llvm.org/D110068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. In D110068#3013636 , @dexonsmith wrote: > I'm a bit hesitant to trust lack of tests as proof that old FIXMEs can be > resolved safely. Can you add some background information about why this was > originally a specifier,

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. In D110068#3013636 , @dexonsmith wrote: > I'm a bit hesitant to trust lack of tests as proof that old FIXMEs can be > resolved safely. Can you add some background information about why this was > originally a specifier,

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 375035. gAlfonso-bit marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new/ https://reviews.llvm.org/D110068 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:161-163 +else if (const ArrayType *ATy = dyn_cast(BaseType)) BaseType = ATy->getElementType(); +else if (const FunctionType *FTy = BaseType->getAs()) dexonsmith wrote: >

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 373955. gAlfonso-bit added a comment. Rebased to upstream CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new/ https://reviews.llvm.org/D110068 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit created this revision. gAlfonso-bit added a reviewer: ahatanak. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no reason to have this here, (since all tests pass) and it isn't even a specifier anyway.

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne can you please please merge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372916. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinterTest.cpp

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinterTest.cpp

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372827. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinterTest.cpp

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 372770. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @Mordante Alfonso Gregory gfunni...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. @dgoldman I did it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372766. gAlfonso-bit added a comment. git-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 370957. gAlfonso-bit added a comment. Rebase to Main @ldionne CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 370955. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinterTest.cpp

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 370952. gAlfonso-bit added a comment. Added test to TypePrinter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. @dgoldman May I ask what tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. In D107775#2967134 , @dgoldman wrote: >> I put a case for it in the declprinter so it is handled appropriately so it >> would get the pointee type, whereas before this was neglected. >> >> Other than that, there should be

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne update? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. In D107775#2964937 , @dgoldman wrote: > Does this change the behavior of TypePrinter or DeclPrinter - not sure if > there are existing tests for those with ObjC code? I put a case for it in the declprinter so it is handled

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 367988. gAlfonso-bit added a reviewer: lhames. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. Passed every test in check-all! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

gAlfonso-bit added a comment. How do I request it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107477/new/ https://reviews.llvm.org/D107477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

gAlfonso-bit added a comment. gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107477/new/ https://reviews.llvm.org/D107477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. I don't think there are any other outstanding issues. Are we good to accept and merge? @ldionne CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 366931. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp Index: clang/lib/AST/TypePrinter.cpp

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366671. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 39. gAlfonso-bit added a comment. Rearranged if statements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne can we land this please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. In D107719#2946159 , @c-rhodes wrote: > In D107719#2945656 , @gAlfonso-bit > wrote: > >> Not sure about the timing of base patch, but maybe this patch is also >> candidate for llvm

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. @RKSimon could you commit for me please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. OK then we can just merge this in main only then CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366497. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 366524. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp Index:

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit updated this revision to Diff 366498. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h Index: clang/include/clang/AST/Type.h

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit updated this revision to Diff 366496. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h Index: clang/include/clang/AST/Type.h

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit updated this revision to Diff 366495. gAlfonso-bit added a comment. Herald added subscribers: llvm-commits, tstellar, mgorny. Herald added a reviewer: MaskRay. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 366451. gAlfonso-bit added a comment. Add ObjectPointerType to GetBaseType CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp Index:

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366014. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___ cfe-commits

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365802. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne is this ok? any other changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365507. gAlfonso-bit added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 365501. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. So does that mean this is ready to land? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365275. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. Alright. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit updated this revision to Diff 365249. gAlfonso-bit added a comment. Remove other changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h Index: clang/include/clang/AST/Type.h

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit created this revision. gAlfonso-bit added reviewers: clang, LLVM. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ObjCObjectPointer is NOT a type specifier, so remove it from the list Repository: rG LLVM

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365233. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/lib/Analysis/Consumed.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365224. gAlfonso-bit added a comment. Moved warnReturnTypestateForUnconsumableType back to SemaDeclCXX CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files:

[PATCH] D107717: [NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365039. Herald added a subscriber: JDevlieghere. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D107717: [NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit created this revision. gAlfonso-bit added a project: LLVM. Herald added subscribers: libcxx-commits, tstellar, mgorny. Herald added a reviewer: MaskRay. Herald added a project: libunwind. Herald added a reviewer: libunwind. gAlfonso-bit requested review of this revision. Herald added

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365064. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/lib/Analysis/Consumed.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365062. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/lib/Analysis/Consumed.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365061. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/lib/Analysis/Consumed.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365060. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Analysis/Consumed.cpp

[PATCH] D107723: Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit created this revision. Herald added a reviewer: aaron.ballman. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107723 Files:

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit updated this revision to Diff 365046. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit updated this revision to Diff 365045. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit updated this revision to Diff 365044. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit updated this revision to Diff 365043. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit updated this revision to Diff 365042. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit created this revision. gAlfonso-bit added projects: LLVM, clang. gAlfonso-bit requested review of this revision. Herald added a subscriber: cfe-commits. This includes removing ObjectiveC Object Pointers from the list of specifiers, as well as checking for C++ instead of using Scoped

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

gAlfonso-bit updated this revision to Diff 364584. gAlfonso-bit added a comment. Improved patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107477/new/ https://reviews.llvm.org/D107477 Files: clang/include/clang/AST/ComparisonCategories.h Index:

[PATCH] D107477: [LLVM][AST][NFC] Resolve Fixme: Make CXXRecordDecl *Record const.

gAlfonso-bit created this revision. gAlfonso-bit added a project: LLVM. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107477 Files:

[PATCH] D106899: [Support] Remove LLVM_ATTRIBUTE_NORETURN

gAlfonso-bit added a comment. Ok thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106899: [LLVM][NFC] Replace LLVM_ATTRIBUTE_NORETURN with [[noreturn]]

gAlfonso-bit added a comment. Still not passing (what is going on?) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106899: [LLVM][NFC] Replace LLVM_ATTRIBUTE_NORETURN with [[noreturn]]

gAlfonso-bit updated this revision to Diff 362780. gAlfonso-bit added a comment. Had to fix a clang-tidy issue for this to even compile CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 Files: clang-tools-extra/pp-trace/PPTrace.cpp

[PATCH] D106899: [LLVM][NFC] Replace LLVM_ATTRIBUTE_NORETURN with [[noreturn]]

gAlfonso-bit added a comment. I don't know why this is failing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106899: [LLVM][NFC] Replace LLVM_ATTRIBUTE_NORETURN with [[noreturn]]

gAlfonso-bit updated this revision to Diff 362533. gAlfonso-bit retitled this revision from "[LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly" to "[LLVM][NFC] Replace LLVM_ATTRIBUTE_NORETURN with [[noreturn]]". gAlfonso-bit added a comment. Removed Compiler.h changes

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit updated this revision to Diff 362492. gAlfonso-bit added a comment. Fix clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 Files: clang-tools-extra/pp-trace/PPTrace.cpp

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit added a comment. In D106899#2910655 , @MaskRay wrote: > I migrated all llvm/ files. You need to remove them from the patch. > > It is a good idea to drop the macro definition in > `llvm/include/llvm/Support/Compiler.h` separately. > > It

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit updated this revision to Diff 362437. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 Files: clang-tools-extra/pp-trace/PPTrace.cpp clang/utils/TableGen/ClangDiagnosticsEmitter.cpp

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit added a comment. Note: This is a candidate for cherry-picking onto the 13 branch since it was only partially done there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit added a comment. Also yes I rebased my fork so they don't clash with your changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit added a comment. @MaskRay I finished the migration to noreturn CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

gAlfonso-bit updated this revision to Diff 362398. gAlfonso-bit added a comment. Formatted ONLY the code I changed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106899/new/ https://reviews.llvm.org/D106899 Files: clang-tools-extra/pp-trace/PPTrace.cpp

[PATCH] D106899: [LLVM][NFC] Use C++ 14 and C11 noreturn specifier

gAlfonso-bit updated this revision to Diff 362371. gAlfonso-bit added a comment. Herald added subscribers: cfe-commits, ormris, lxfind, usaxena95, rupprecht, arphaman, steven_wu, hiraditya. Herald added a reviewer: jhenderson. Herald added a project: clang-tools-extra. Removed