[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. In D91944#2990234 , @cchen wrote: > @alokmishra.besu do you mind if I push the patch for solving those assertions > with rebase? The patch does not change the logic in your program and I've > made sure that the tests

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. In D91944#2540178 , @jdoerfert wrote: > There are no test cases anymore, as far as I can tell. Updated patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 321202. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 321194. alokmishra.besu added a comment. I've rebase this patch with the latest git code. All test cases pass. I've also applied this patch to a new git clone. It applies and builds successfully. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. In D91944#2505159 , @jdoerfert wrote: > In D91944#2485167 , @jdoerfert wrote: > >> Are the test all passing? > > Can we fix the failing tests so we can merge this? I will work on

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 314229. alokmishra.besu added a comment. Rebased with current branch to avoid patch failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files:

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. Emitting error instead of instantiation in clang/lib/Sema/TreeTransform.h. Added a TODO for future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 314224. alokmishra.besu marked an inline comment as done. alokmishra.besu added a comment. All clang test and clang-tidy pass. Ran clang-format on all code, except clang/include/clang/Serialization/ASTBitCodes.h which was formatting unrelated code

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:1952 - STMT_MS_DEPENDENT_EXISTS, // MSDependentExistsStmt - EXPR_LAMBDA,// LambdaExpr STMT_COROUTINE_BODY, jdoerfert wrote: >

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 309382. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:373 +/// +class OMPMetaDirective final : public OMPExecutableDirective { + friend class ASTStmtReader; ABataev wrote: > I think, metadirective should be a kind of a

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 309268. alokmishra.besu added a comment. Updated version of metadirective supporting OpenMP 5.0 features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files:

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. I have replied to the comments and will update the code accordingly. Some of the codes are intentionally left to be update in 5.1 implementation. Will add TODO comments there. I will revisit the implementation of getBestWhenMatchForContext and also add more

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu created this revision. alokmishra.besu added a project: OpenMP. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, martong, arphaman, guansong, hiraditya, yaxunl. Herald added projects: clang, LLVM. alokmishra.besu requested review of this revision. Herald added a

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 291449. alokmishra.besu added a comment. Updated patch to make it extendable to more selectors Implemented device_arch and implementation_vendor selectors as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu added a comment. In D76211#2212203 , @jdoerfert wrote: > Are you planning to add support for the actual OpenMP selectors as well? > All the other traits, scoring, etc. I left a comment below that points you to > the right place as we

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 255575. alokmishra.besu added a comment. Updated the test cases. Fixed an issue where correct code was not generated if directive variant was not provided in when/default clause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 252472. alokmishra.besu marked an inline comment as not done. alokmishra.besu added a comment. Updated the test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 250966. alokmishra.besu marked 6 inline comments as done. alokmishra.besu added a comment. Fixed formatting issues and replaced SmallVector with ArrayRef . Working on the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:350 + friend class ASTStmtReader; + Stmt* IfStmt; + ABataev wrote: > This must be a part of the tail-allocated data members, otherwise you won't > be able to correctly

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 250830. alokmishra.besu added a comment. Fixed build error and test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 Files:

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 250684. alokmishra.besu added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Adding test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu created this revision. alokmishra.besu added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, martong, jfb, arphaman, guansong, jholewinski. Herald added a project: clang. jdoerfert added a comment. I think you forgot to add the tests to the commit :) This is a