[PATCH] D149917: [lld][WebAssembly] Add --keep-section flag

kripken requested changes to this revision. kripken added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:154 + if (!WasmOptPath.empty()) { +CmdArgs.push_back("--keep-secton=target_features"); + }

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

kripken added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:175 +if (T.isOSEmscripten()) + resetDataLayout("e-m:e-p:32:32-i64:64-f128:64-n32:64-S128-ni:1"); +else Should this not be

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

kripken accepted this revision. kripken added a comment. This revision is now accepted and ready to land. I believe we have all agreed that this is the right path forward, and so this can land? Doing this change now in emscripten does not prevent us from changing the emscripten ABI again

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

kripken added a comment. In D104808#2836942 , @sunfish wrote: > Do we still intend to unify Emscripten's ABI with wasm32-unknown-unknown or > wasm32-wasi eventually? This is talking a step away from that. I definitely think we should unify them as much

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

kripken accepted this revision. kripken added a comment. This revision is now accepted and ready to land. I'm not very familiar with this code, but it looks right, and sgtm to add a warning here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77908: [WebAssembly] Enable nontrapping-fptoint for `default` cpu

kripken added a comment. In D77908#1977039 , @sbc100 wrote: > As a less controversial version of this change I could instead create a new > CPU called `current` and leave `generic` as is (basically leave it at mvp) > until we can agree that a features

[PATCH] D77908: [WebAssembly] Enable nontrapping-fptoint for `default` cpu

kripken added a comment. Is the general plan for LLVM documented somewhere? It's not obvious to me why something being in the wasm spec means it should be enabled by default in LLVM. (It's also not obvious to me that is wrong! I'm just not sure what the reasoning is here.) In particular,

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

kripken accepted this revision. kripken added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/AttrDocs.td:4173 +attribute for the WebAssembly target. This attribute may be attached to a +function declaration, where it

[PATCH] D40526: [WebAssembly] Change size_t to `unsigned long`

azakai added subscribers: sunfish, jgravelle-google. azakai added a comment. This has also shown up in a game engine middleware codebase, so it may be a broader issue - people seem to assume size_t is one of the int*_t types. Repository: rC Clang https://reviews.llvm.org/D40526