[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 added a comment. Thank You @ziqingluo-90! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155814/new/ https://reviews.llvm.org/D155814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 added a comment. Hi @ziqingluo-90 ! I don't have commit privileges, could you commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155814/new/ https://reviews.llvm.org/D155814 ___ cfe-commits mailing list

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

AMP999 added a comment. Sure, I just filed this as a GitHub issue in the following link: https://github.com/llvm/llvm-project/issues/64124 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151625/new/ https://reviews.llvm.org/D151625

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 added subscribers: gmail.com, Google.com. AMP999 added a comment. BTW my Email in one of my previous patches is inserted incorrectly. I appreciate if you could possibly fix that for me. my Email in this 0fd4175907b40fe63131482c162d7e0f76000521

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 added a comment. You're welcome! I don't have permission to commit so I'll send my Name and Email: Name: Amirreza Ashouri Email: ar.ashouri...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155814/new/ https://reviews.llvm.org/D155814

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

AMP999 added a comment. This attribute is trying to work around an issue with operator== instantiation, but according to https://cpplang.slack.com/archives/C6K47F8TT/p1689107603335019?thread_ts=1689107603.335019=C6K47F8TT the problem is actually a bug in Clang. Shouldn't the Clang bug be fixed

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 updated this revision to Diff 542972. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155814/new/ https://reviews.llvm.org/D155814 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp Index: clang/lib/Analysis/UnsafeBufferUsage.cpp

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 added a comment. By the way I don't have permissions to commit so I'll send you my name and email: Name: Amirreza Ashouri Email: ar.ashouri...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155714/new/

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 added a comment. I appreciate if you take a look at another patch I sent to address the ci build failure when calling `clang/utils/ci/run-buildbot check-format` caused by some extra white spaces. https://reviews.llvm.org/D155814 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 updated this revision to Diff 542909. AMP999 added a comment. An entry added to clang/docs/ReleaseNotes.rst Thank You for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155714/new/ https://reviews.llvm.org/D155714 Files:

[PATCH] D155814: Fix the linting problems which caused `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 created this revision. AMP999 added a reviewer: clang. AMP999 added a project: clang. Herald added a reviewer: NoQ. Herald added a project: All. AMP999 requested review of this revision. Herald added a subscriber: cfe-commits. `clang/utils/ci/run-buildbot check-format` command in build

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 updated this revision to Diff 542240. AMP999 added a comment. Revised the formatting of the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155714/new/ https://reviews.llvm.org/D155714 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 updated this revision to Diff 542136. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155714/new/ https://reviews.llvm.org/D155714 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/class/class.compare/class.compare.default/p1.cpp

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 created this revision. AMP999 added reviewers: clang, rsmith. AMP999 added a project: clang. Herald added a project: All. AMP999 requested review of this revision. Herald added a subscriber: cfe-commits. https://godbolt.org/z/cMKE3o1aG According to the issue