Re: r367675 - [OpenCL] Allow OpenCL C style vector initialization in C++

2019-08-05 Thread Anastasia Stulova via cfe-commits
Anastasia, This commit broke ARMv8 bots, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/14655/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Avector_literals_valid.cl Thanks, Yvan On Fri, 2 Aug 2019 at 13:18, Anastasia Stulova via cfe-commits wrote

r367823 - [OpenCL] Fix vector literal test broken in rL367675.

2019-08-05 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Aug 5 02:50:28 2019 New Revision: 367823 URL: http://llvm.org/viewvc/llvm-project?rev=367823=rev Log: [OpenCL] Fix vector literal test broken in rL367675. Avoid checking alignment unnecessary that is not portable among targets. Modified:

r367675 - [OpenCL] Allow OpenCL C style vector initialization in C++

2019-08-02 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Aug 2 04:19:35 2019 New Revision: 367675 URL: http://llvm.org/viewvc/llvm-project?rev=367675=rev Log: [OpenCL] Allow OpenCL C style vector initialization in C++ Allow creating vector literals from other vectors. float4 a = (float4)(1.0f, 2.0f, 3.0f, 4.0f); float4 v

r367008 - [OpenCL] Rename lang mode flag for C++ mode

2019-07-25 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Jul 25 04:04:29 2019 New Revision: 367008 URL: http://llvm.org/viewvc/llvm-project?rev=367008=rev Log: [OpenCL] Rename lang mode flag for C++ mode Rename lang mode flag to -cl-std=clc++/-cl-std=CLC++ or -std=clc++/-std=CLC++. This aligns with OpenCL C conversion and

Re: r366694 - [NFC] Relaxed regression tests for PR42665

2019-07-23 Thread Anastasia Stulova via cfe-commits
Great! Thanks! From: Hans Wennborg Sent: 23 July 2019 15:58 To: Anastasia Stulova Cc: Marco Antognini ; Clang Commits ; nd Subject: Re: r366694 - [NFC] Relaxed regression tests for PR42665 Merged them both in r366814. Thanks, Hans On Tue, Jul 23, 2019 at

Re: r366694 - [NFC] Relaxed regression tests for PR42665

2019-07-23 Thread Anastasia Stulova via cfe-commits
+ cfe-commits From: Anastasia Stulova Sent: 23 July 2019 15:16 To: Hans Wennborg Cc: Marco Antognini Subject: Re: r366694 - [NFC] Relaxed regression tests for PR42665 @Hans, would it be possible to merge this commit along with r366670 to the release 9.0?

r366421 - [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL

2019-07-18 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Jul 18 03:02:35 2019 New Revision: 366421 URL: http://llvm.org/viewvc/llvm-project?rev=366421=rev Log: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL Clang doesn't implement OpenCL C++, change the comments to reflect that. Differential Revision:

r366417 - [OpenCL][PR42033] Fix addr space deduction with template parameters

2019-07-18 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Jul 18 02:12:49 2019 New Revision: 366417 URL: http://llvm.org/viewvc/llvm-project?rev=366417=rev Log: [OpenCL][PR42033] Fix addr space deduction with template parameters If dependent types appear in pointers or references we allow addr space deduction because the addr

r366351 - [Docs][OpenCL] Documentation of C++ for OpenCL mode

2019-07-17 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Jul 17 10:21:31 2019 New Revision: 366351 URL: http://llvm.org/viewvc/llvm-project?rev=366351=rev Log: [Docs][OpenCL] Documentation of C++ for OpenCL mode Added documentation of C++ for OpenCL mode into Clang User Manual and Language Extensions document. Differential

r366063 - [OpenCL] Deduce addr space for pointee of dependent types in instantiation.

2019-07-15 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Jul 15 06:02:21 2019 New Revision: 366063 URL: http://llvm.org/viewvc/llvm-project?rev=366063=rev Log: [OpenCL] Deduce addr space for pointee of dependent types in instantiation. Since pointee doesn't require context sensitive addr space deduction it's easier to handle

r366059 - [OpenCL][PR41727] Prevent ICE on global dtors

2019-07-15 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Jul 15 04:58:10 2019 New Revision: 366059 URL: http://llvm.org/viewvc/llvm-project?rev=366059=rev Log: [OpenCL][PR41727] Prevent ICE on global dtors Pass NULL to pointer arg of __cxa_atexit if addr space is not matching with its param. This doesn't align yet with how

r364071 - [OpenCL][PR41963] Add generic addr space to old atomics in C++ mode

2019-06-21 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Jun 21 09:19:16 2019 New Revision: 364071 URL: http://llvm.org/viewvc/llvm-project?rev=364071=rev Log: [OpenCL][PR41963] Add generic addr space to old atomics in C++ mode Add overloads with generic address space pointer to old atomics. This is currently only added for

r364032 - [Sema] Fix diagnostic for addr spaces in reference binding

2019-06-21 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Jun 21 04:36:15 2019 New Revision: 364032 URL: http://llvm.org/viewvc/llvm-project?rev=364032=rev Log: [Sema] Fix diagnostic for addr spaces in reference binding Extend reference binding behavior to account for address spaces. Differential Revision:

r364023 - [Sema] Improved diagnostic for qualifiers in reference binding

2019-06-21 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Jun 21 03:50:02 2019 New Revision: 364023 URL: http://llvm.org/viewvc/llvm-project?rev=364023=rev Log: [Sema] Improved diagnostic for qualifiers in reference binding Improved wording and also simplified by using printing method from qualifiers. Differential Revision:

r363944 - [Sema] Diagnose addr space mismatch while constructing objects

2019-06-20 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Jun 20 09:23:28 2019 New Revision: 363944 URL: http://llvm.org/viewvc/llvm-project?rev=363944=rev Log: [Sema] Diagnose addr space mismatch while constructing objects If we construct an object in some arbitrary non-default addr space it should fail unless either: - There

r362623 - [Clang] Fix pretty printing of CUDA address spaces

2019-06-05 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Jun 5 10:29:00 2019 New Revision: 362623 URL: http://llvm.org/viewvc/llvm-project?rev=362623=rev Log: [Clang] Fix pretty printing of CUDA address spaces Patch by richardmembarth (Richard Membarth)! Differential Revision: https://reviews.llvm.org/D54258 Modified:

r362611 - [OpenCL][PR42031] Prevent deducing addr space in type alias.

2019-06-05 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Jun 5 07:50:01 2019 New Revision: 362611 URL: http://llvm.org/viewvc/llvm-project?rev=362611=rev Log: [OpenCL][PR42031] Prevent deducing addr space in type alias. Similar to typedefs we shouldn't deduce addr space in type alias. Differential Revision:

r362604 - [Sema] Prevent binding incompatible addr space ref to temporaries

2019-06-05 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Jun 5 07:03:34 2019 New Revision: 362604 URL: http://llvm.org/viewvc/llvm-project?rev=362604=rev Log: [Sema] Prevent binding incompatible addr space ref to temporaries References to arbitrary address spaces can't always be bound to temporaries. This change extends the

r362409 - [PR41567][Sema] Fixed cast kind in addr space conversions

2019-06-03 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Jun 3 08:42:36 2019 New Revision: 362409 URL: http://llvm.org/viewvc/llvm-project?rev=362409=rev Log: [PR41567][Sema] Fixed cast kind in addr space conversions This change sets missing cast kind correctly in the address space conversion case. Differential Revision:

r362102 - [OpenCL] Fix OpenCL/SPIR version metadata in C++ mode.

2019-05-30 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu May 30 08:18:07 2019 New Revision: 362102 URL: http://llvm.org/viewvc/llvm-project?rev=362102=rev Log: [OpenCL] Fix OpenCL/SPIR version metadata in C++ mode. C++ is derived from OpenCL v2.0 therefore set the versions identically. Differential Revision:

r360342 - [OpenCL] Make global ctor init function a kernel

2019-05-09 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu May 9 06:55:44 2019 New Revision: 360342 URL: http://llvm.org/viewvc/llvm-project?rev=360342=rev Log: [OpenCL] Make global ctor init function a kernel We need to be able to enqueue internal function that initializes global constructors on the host side. Therefore it

r360330 - [OpenCL] Switched CXX mode to be derived from C++17

2019-05-09 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu May 9 04:55:24 2019 New Revision: 360330 URL: http://llvm.org/viewvc/llvm-project?rev=360330=rev Log: [OpenCL] Switched CXX mode to be derived from C++17 Differential revision: https://reviews.llvm.org/D61506 Modified:

r360325 - [SPIR] Simplified target checking.

2019-05-09 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu May 9 03:25:45 2019 New Revision: 360325 URL: http://llvm.org/viewvc/llvm-project?rev=360325=rev Log: [SPIR] Simplified target checking. Switched to Triple::isSPIR() helper to simplify code. Patch by kpet (Kevin Petit)! Differential revision:

r360258 - [Sema][OpenCL] Make address space conversions a bit stricter.

2019-05-08 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed May 8 07:23:49 2019 New Revision: 360258 URL: http://llvm.org/viewvc/llvm-project?rev=360258=rev Log: [Sema][OpenCL] Make address space conversions a bit stricter. The semantics for converting nested pointers between address spaces are not very well defined. Some

r360152 - [OpenCL] Prevent mangling kernel functions.

2019-05-07 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue May 7 07:22:34 2019 New Revision: 360152 URL: http://llvm.org/viewvc/llvm-project?rev=360152=rev Log: [OpenCL] Prevent mangling kernel functions. Kernel function names have to be preserved as in the original source to be able to access them from the host API side.

r359798 - [OpenCL] Fix initialisation of this via pointer.

2019-05-02 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu May 2 09:10:50 2019 New Revision: 359798 URL: http://llvm.org/viewvc/llvm-project?rev=359798=rev Log: [OpenCL] Fix initialisation of this via pointer. When the expression used to initialise 'this' has a pointer type, check the address space of the pointee type instead

r359789 - [OpenCL] Deduce static data members to __global addr space.

2019-05-02 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu May 2 07:40:40 2019 New Revision: 359789 URL: http://llvm.org/viewvc/llvm-project?rev=359789=rev Log: [OpenCL] Deduce static data members to __global addr space. Similarly to static variables in OpenCL, static class data members should be deduced to __global addr

r357684 - [PR41157][OpenCL] Prevent implicit init of local addr space var in C++ mode.

2019-04-04 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Apr 4 04:08:51 2019 New Revision: 357684 URL: http://llvm.org/viewvc/llvm-project?rev=357684=rev Log: [PR41157][OpenCL] Prevent implicit init of local addr space var in C++ mode. Prevent adding initializers implicitly to variables declared in local address space. This

r357682 - [PR41276] Fixed incorrect generation of addr space cast for 'this' in C++.

2019-04-04 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Apr 4 03:48:36 2019 New Revision: 357682 URL: http://llvm.org/viewvc/llvm-project?rev=357682=rev Log: [PR41276] Fixed incorrect generation of addr space cast for 'this' in C++. Improved classification of address space cast when qualification conversion is performed -

r357162 - [PR41247] Fixed parsing of private keyword in C++.

2019-03-28 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Mar 28 04:47:14 2019 New Revision: 357162 URL: http://llvm.org/viewvc/llvm-project?rev=357162=rev Log: [PR41247] Fixed parsing of private keyword in C++. Fixed bug in C++ to prevent parsing 'private' as a valid address space qualifier. Differential Revision:

r356987 - [OpenCL] Allow variadic macros as Clang feature.

2019-03-26 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Mar 26 04:22:37 2019 New Revision: 356987 URL: http://llvm.org/viewvc/llvm-project?rev=356987=rev Log: [OpenCL] Allow variadic macros as Clang feature. Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td cfe/trunk/lib/Lex/PPDirectives.cpp

r356888 - [OpenCL] Allow addr space spelling without __ prefix in C++.

2019-03-25 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Mar 25 04:54:02 2019 New Revision: 356888 URL: http://llvm.org/viewvc/llvm-project?rev=356888=rev Log: [OpenCL] Allow addr space spelling without __ prefix in C++. For backwards compatibility we allow alternative spelling of address spaces - 'private', 'local',

r356479 - [OpenCL] Minor improvements in default header testing

2019-03-19 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Mar 19 10:09:06 2019 New Revision: 356479 URL: http://llvm.org/viewvc/llvm-project?rev=356479=rev Log: [OpenCL] Minor improvements in default header testing Differential Revision: https://reviews.llvm.org/D59544 Modified: cfe/trunk/test/Headers/opencl-c-header.cl

r356475 - [Sema] Adjust addr space of reference operand in compound assignment

2019-03-19 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Mar 19 09:50:21 2019 New Revision: 356475 URL: http://llvm.org/viewvc/llvm-project?rev=356475=rev Log: [Sema] Adjust addr space of reference operand in compound assignment When we create overloads for the builtin compound assignment operators we need to preserve address

r356450 - [OpenCL] Improved testing of default header.

2019-03-19 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Mar 19 06:04:17 2019 New Revision: 356450 URL: http://llvm.org/viewvc/llvm-project?rev=356450=rev Log: [OpenCL] Improved testing of default header. Improved some checks and moved testing of the default header in C++ mode into the Headers folder. Differential Revision:

r355915 - [PR41007][OpenCL] Allow printf in C++ mode.

2019-03-12 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Mar 12 05:46:56 2019 New Revision: 355915 URL: http://llvm.org/viewvc/llvm-project?rev=355915=rev Log: [PR41007][OpenCL] Allow printf in C++ mode. As for OpenCL C, we need to allow using printf and toolchain variadic functions (prefixed by "__") in C++ mode.

r355609 - [Sema] Change addr space diagnostics in casts to follow C++ style.

2019-03-07 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Mar 7 09:06:30 2019 New Revision: 355609 URL: http://llvm.org/viewvc/llvm-project?rev=355609=rev Log: [Sema] Change addr space diagnostics in casts to follow C++ style. This change adds a new diagnostic for mismatching address spaces to be used for C++ casts (only

r355608 - [PR40778][Sema] Adjust addr space of operands in builtin operators.

2019-03-07 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Mar 7 08:43:41 2019 New Revision: 355608 URL: http://llvm.org/viewvc/llvm-project?rev=355608=rev Log: [PR40778][Sema] Adjust addr space of operands in builtin operators. Adjust address space for references and pointer operands of builtin operators. Currently this

r355606 - [PR40778] Preserve addr space in Derived to Base cast.

2019-03-07 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Mar 7 08:23:15 2019 New Revision: 355606 URL: http://llvm.org/viewvc/llvm-project?rev=355606=rev Log: [PR40778] Preserve addr space in Derived to Base cast. The address space for the Base class pointer when up-casting from Derived should be taken from the Derived class

r355499 - [PR40778] Add addr space conversion when binding reference to a temporary.

2019-03-06 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Mar 6 05:02:41 2019 New Revision: 355499 URL: http://llvm.org/viewvc/llvm-project?rev=355499=rev Log: [PR40778] Add addr space conversion when binding reference to a temporary. This change fixes temporary materialization to happen in the right (default) address space

r354121 - [OpenCL][PR40707] Allow OpenCL C types in C++ mode.

2019-02-15 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Feb 15 04:07:57 2019 New Revision: 354121 URL: http://llvm.org/viewvc/llvm-project?rev=354121=rev Log: [OpenCL][PR40707] Allow OpenCL C types in C++ mode. Allow all OpenCL types to be parsed in C++ mode. Modified:

r353431 - [OpenCL][PR40603] In C++ preserve compatibility with OpenCL C v2.0

2019-02-07 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Feb 7 09:32:37 2019 New Revision: 353431 URL: http://llvm.org/viewvc/llvm-project?rev=353431=rev Log: [OpenCL][PR40603] In C++ preserve compatibility with OpenCL C v2.0 Valid OpenCL C code should still compile in C++ mode. This change enables extensions and OpenCL

r353160 - Fix ICE on reference binding with mismatching addr spaces.

2019-02-05 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Feb 5 03:32:58 2019 New Revision: 353160 URL: http://llvm.org/viewvc/llvm-project?rev=353160=rev Log: Fix ICE on reference binding with mismatching addr spaces. When we attempt to add an addr space qual to a type already qualified by an addr space ICE is triggered.

r352760 - [OpenCL] Fixed addr space manging test.

2019-01-31 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Jan 31 07:23:48 2019 New Revision: 352760 URL: http://llvm.org/viewvc/llvm-project?rev=352760=rev Log: [OpenCL] Fixed addr space manging test. Fixed typo in the Filecheck directive and changed the test to verify output correctly. Fixes PR40029! Modified:

r352617 - [OpenCL] Add generic addr space to the return of implicit assignment.

2019-01-30 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Jan 30 03:18:08 2019 New Revision: 352617 URL: http://llvm.org/viewvc/llvm-project?rev=352617=rev Log: [OpenCL] Add generic addr space to the return of implicit assignment. When creating the prototype of implicit assignment operators the returned reference to the class

r352349 - Rename getTypeQualifiers to getMethodQualifiers.

2019-01-28 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Jan 28 03:37:49 2019 New Revision: 352349 URL: http://llvm.org/viewvc/llvm-project?rev=352349=rev Log: Rename getTypeQualifiers to getMethodQualifiers. Use more descriptive name for the method qualifiers getter. Differential Revision: https://reviews.llvm.org/D56792

r351747 - [OpenCL] Allow address spaces as method qualifiers.

2019-01-21 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Jan 21 08:01:38 2019 New Revision: 351747 URL: http://llvm.org/viewvc/llvm-project?rev=351747=rev Log: [OpenCL] Allow address spaces as method qualifiers. Methods can now be qualified with address spaces to prevent undesirable conversions to generic or to provide custom

r351546 - [OpenCL] Fix overloading ranking rules for addrspace conversions.

2019-01-18 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Jan 18 03:38:16 2019 New Revision: 351546 URL: http://llvm.org/viewvc/llvm-project?rev=351546=rev Log: [OpenCL] Fix overloading ranking rules for addrspace conversions. Extend ranking to work with address spaces correctly when resolving overloads. Differential

r351053 - [OpenCL] Set generic addr space of 'this' in special class members.

2019-01-14 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Jan 14 03:44:22 2019 New Revision: 351053 URL: http://llvm.org/viewvc/llvm-project?rev=351053=rev Log: [OpenCL] Set generic addr space of 'this' in special class members. Set address spaces of 'this' param correctly for implicit special class members. This also changes

r350703 - Use DeclSpec for quals in DeclaratorChunk::FunctionTypeInfo.

2019-01-09 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Jan 9 03:25:09 2019 New Revision: 350703 URL: http://llvm.org/viewvc/llvm-project?rev=350703=rev Log: Use DeclSpec for quals in DeclaratorChunk::FunctionTypeInfo. Rather than duplicating data fields, use DeclSpec directly to store the qualifiers for the

r350386 - [Basic] Extend DiagnosticEngine to store and format Qualifiers.

2019-01-04 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Jan 4 03:50:36 2019 New Revision: 350386 URL: http://llvm.org/viewvc/llvm-project?rev=350386=rev Log: [Basic] Extend DiagnosticEngine to store and format Qualifiers. Qualifiers can now be streamed into the DiagnosticEngine using regular << operator. If Qualifiers are

r348382 - [OpenCL] Diagnose conflicting address spaces in templates.

2018-12-05 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Dec 5 09:02:22 2018 New Revision: 348382 URL: http://llvm.org/viewvc/llvm-project?rev=348382=rev Log: [OpenCL] Diagnose conflicting address spaces in templates. Added new diagnostic when templates are instantiated with different address space from the one provided in

r347865 - [OpenCL] Improve diags for addr spaces in templates

2018-11-29 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Nov 29 06:11:15 2018 New Revision: 347865 URL: http://llvm.org/viewvc/llvm-project?rev=347865=rev Log: [OpenCL] Improve diags for addr spaces in templates Fix ICEs on template instantiations that were leading to the creation of invalid code patterns with address spaces.

r347196 - Fixed uninitialized variable issue.

2018-11-19 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Nov 19 04:43:39 2018 New Revision: 347196 URL: http://llvm.org/viewvc/llvm-project?rev=347196=rev Log: Fixed uninitialized variable issue. This commit should fix failing bots. Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp

Re: r347189 - [OpenCL] Fix address space deduction in template args.

2018-11-19 Thread Anastasia Stulova via cfe-commits
at 12:02 PM Anastasia Stulova via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: stulova Date: Mon Nov 19 03:00:14 2018 New Revision: 347189 URL: http://llvm.org/viewvc/llvm-project?rev=347189=rev Log: [OpenCL] Fix address space deduction in template args. Don't deduce addre

r347189 - [OpenCL] Fix address space deduction in template args.

2018-11-19 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Nov 19 03:00:14 2018 New Revision: 347189 URL: http://llvm.org/viewvc/llvm-project?rev=347189=rev Log: [OpenCL] Fix address space deduction in template args. Don't deduce address spaces for non-pointer-like types in template args. Fixes PR38603! Differential Revision:

r347059 - [OpenCL] Enable address spaces for references in C++

2018-11-16 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Nov 16 08:22:56 2018 New Revision: 347059 URL: http://llvm.org/viewvc/llvm-project?rev=347059=rev Log: [OpenCL] Enable address spaces for references in C++ Added references to the addr spaces deduction and enabled CL2.0 features (program scope variables and storage

Re: r343653 - OpenCL: Mark printf format string argument

2018-10-29 Thread Anastasia Stulova via cfe-commits
It seems like it caused a bug: https://bugs.llvm.org/show_bug.cgi?id=39486 From: cfe-commits on behalf of Matt Arsenault via cfe-commits Sent: 03 October 2018 03:01 To: cfe-commits@lists.llvm.org Subject: r343653 - OpenCL: Mark printf format string argument

r344148 - [OpenCL] Fixed address space cast in C style cast of C++ parsing

2018-10-10 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Oct 10 09:05:22 2018 New Revision: 344148 URL: http://llvm.org/viewvc/llvm-project?rev=344148=rev Log: [OpenCL] Fixed address space cast in C style cast of C++ parsing C style cast in OpenCL C++ was ignoring the address space conversions from OpenCL C and as a result

r342885 - Revert "We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case."

2018-09-24 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Sep 24 07:21:56 2018 New Revision: 342885 URL: http://llvm.org/viewvc/llvm-project?rev=342885=rev Log: Revert "We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case." Discussed on cfe-commits (Week-of-Mon-20180820), this

Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

2018-08-24 Thread Anastasia Stulova via cfe-commits
, Anastasia Stulova via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Hi Richard, There was a change in the spec to disallow unprototyped functions, which was made this year. Unfortunately it seems it didn't make into the Khronos registry yet to appear publicly. I will chase

Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

2018-08-23 Thread Anastasia Stulova via cfe-commits
, 22 Aug 2018 at 06:55, Anastasia Stulova via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Hi Richard, > This is incorrect. Implicit function declarations declare unprototyped > functions, which are *not* variadic, and are in fact supported by Clang's > OpenCL language

Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

2018-08-22 Thread Anastasia Stulova via cfe-commits
tions as an extension in all C dialects. Remove OpenCL special case. On Tue, 21 Aug 2018 at 07:41, Anastasia Stulova via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: If there are no objections I would like to revert this old commit that coverts error about implicit function

Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

2018-08-21 Thread Anastasia Stulova via cfe-commits
L off-list and Richard proposed to use "-Werror=implicit-function-declaration" command line option if error is required. Will it work for you? Thanks, Alexey On Tue, Aug 21, 2018 at 5:41 PM Anastasia Stulova via cfe-commits wrote: > > If there are no objections I would like

Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

2018-08-21 Thread Anastasia Stulova via cfe-commits
If there are no objections I would like to revert this old commit that coverts error about implicit function declaration into a warning. We have decided to generate an error for this https://reviews.llvm.org/D31745 because for OpenCL variadic prototypes are disallowed (section 6.9.e,

r335362 - [OpenCL] Fixed parsing of address spaces for C++.

2018-06-22 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Jun 22 09:20:21 2018 New Revision: 335362 URL: http://llvm.org/viewvc/llvm-project?rev=335362=rev Log: [OpenCL] Fixed parsing of address spaces for C++. Added address space tokens to C++ parsing code to be able to parse declarations that start from an address space

r335358 - [Sema] Updated note for address spaces to print the type.

2018-06-22 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Jun 22 08:45:08 2018 New Revision: 335358 URL: http://llvm.org/viewvc/llvm-project?rev=335358=rev Log: [Sema] Updated note for address spaces to print the type. This allows to reuse the same diagnostic for OpenCL or CUDA. Modified:

r331877 - [OpenCL] Add constant address space to __func__ in AST.

2018-05-09 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed May 9 06:23:26 2018 New Revision: 331877 URL: http://llvm.org/viewvc/llvm-project?rev=331877=rev Log: [OpenCL] Add constant address space to __func__ in AST. Added string literal helper function to obtain the type attributed by a constant address space. Also fixed

r329911 - [OpenCL] Added -std/-cl-std=c++

2018-04-12 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Apr 12 07:17:04 2018 New Revision: 329911 URL: http://llvm.org/viewvc/llvm-project?rev=329911=rev Log: [OpenCL] Added -std/-cl-std=c++ This is std option for OpenCL C++ v1.0. Differential Revision: https://reviews.llvm.org/D45363 Modified:

Re: A proposal for adding OpenCL C++ support (Spec v2.2)

2018-03-23 Thread Anastasia Stulova via cfe-commits
There were no objections to this so far. I assume it means nobody is opposing this new feature. Just to give a bit more info and a chance for the last feedback. We don't plan to contribute the whole patch but only around 3K lines + tests. The overall changes will be smaller than OpenCL 2.0.

Re: r298369 - [OpenCL] Added diagnostic for checking length of vector

2017-10-12 Thread Anastasia Stulova via cfe-commits
I think this bit is a bit confusing to us. Some of our original OpenCL checks were removed in some places because in some cases OpenCL semantic was adopted elsewhere. But I think this should indeed go under OpenCL check. Thanks, Anastasia From: Bruno Cardoso

r314317 - [OpenCL] Fixed CL version in failing test.

2017-09-27 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Sep 27 10:03:35 2017 New Revision: 314317 URL: http://llvm.org/viewvc/llvm-project?rev=314317=rev Log: [OpenCL] Fixed CL version in failing test. Modified: cfe/trunk/test/CodeGenOpenCL/vectorLoadStore.cl Modified: cfe/trunk/test/CodeGenOpenCL/vectorLoadStore.cl

r314304 - [OpenCL] Handle address space conversion while setting type alignment.

2017-09-27 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Sep 27 07:37:00 2017 New Revision: 314304 URL: http://llvm.org/viewvc/llvm-project?rev=314304=rev Log: [OpenCL] Handle address space conversion while setting type alignment. Added missing addrspacecast case in alignment computation logic of pointer type emission in IR

r312728 - [OpenCL] Handle taking an address of block captures.

2017-09-07 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Sep 7 10:00:33 2017 New Revision: 312728 URL: http://llvm.org/viewvc/llvm-project?rev=312728=rev Log: [OpenCL] Handle taking an address of block captures. Block captures can have different physical locations in memory segments depending on the use case (as a function

r305798 - [OpenCL] Diagnose scoped address-space qualified variables

2017-06-20 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Jun 20 09:50:45 2017 New Revision: 305798 URL: http://llvm.org/viewvc/llvm-project?rev=305798=rev Log: [OpenCL] Diagnose scoped address-space qualified variables Produce an error if variables qualified with a local or a constant address space are not declared in the

r304708 - [OpenCL] Fix pipe size in TypeInfo.

2017-06-05 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Jun 5 06:27:03 2017 New Revision: 304708 URL: http://llvm.org/viewvc/llvm-project?rev=304708=rev Log: [OpenCL] Fix pipe size in TypeInfo. Pipes are now the size of pointers rather than the size of the type that they contain. Patch by Simon Perretta! Differential

r302435 - [Sema] Fix typos handling in an overloadable call.

2017-05-08 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon May 8 11:05:54 2017 New Revision: 302435 URL: http://llvm.org/viewvc/llvm-project?rev=302435=rev Log: [Sema] Fix typos handling in an overloadable call. In C typos in arguments in a call of an overloadable function lead to a failure of construction of CallExpr and

r300988 - [OpenCL] Fix semantic check of ndrange_t for device_side_enqueue.

2017-04-21 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Apr 21 10:13:24 2017 New Revision: 300988 URL: http://llvm.org/viewvc/llvm-project?rev=300988=rev Log: [OpenCL] Fix semantic check of ndrange_t for device_side_enqueue. Check unqualified type for ndrange argument in device_side_enqueue so device_side_enqueue accept

r299447 - [Bug 25404] Fix crash on typedef in OpenCL 2.0

2017-04-04 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Apr 4 11:50:46 2017 New Revision: 299447 URL: http://llvm.org/viewvc/llvm-project?rev=299447=rev Log: [Bug 25404] Fix crash on typedef in OpenCL 2.0 Fixed the assertion due to absence of source location for implicitly defined types (using addImplicitTypedef()). During

RE: r298976 - [OpenCL] Added parsing for OpenCL vector types.

2017-03-29 Thread Anastasia Stulova via cfe-commits
It seems like the following change causes the failures: diff --git a/lib/Parse/ParseExpr.cpp b/lib/Parse/ParseExpr.cpp index 4dcdfbf..e1439d6 100644 --- a/lib/Parse/ParseExpr.cpp +++ b/lib/Parse/ParseExpr.cpp @@ -2379,10 +2427,13 @@ Parser::ParseParenExpression(ParenParseOption , bool

r298709 - [OpenCL][Bug 10573] Don't set CXXOperatorNames flag

2017-03-24 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Mar 24 11:43:51 2017 New Revision: 298709 URL: http://llvm.org/viewvc/llvm-project?rev=298709=rev Log: [OpenCL][Bug 10573] Don't set CXXOperatorNames flag The flag CXXOperatorNames was overwritten unconditionally after being set for OpenCL. There seems to be no

r298256 - [OpenCL] Fix extension guards for atomic functions

2017-03-20 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Mar 20 10:02:54 2017 New Revision: 298256 URL: http://llvm.org/viewvc/llvm-project?rev=298256=rev Log: [OpenCL] Fix extension guards for atomic functions Review: D30830 Patch by James Price! Modified: cfe/trunk/lib/Headers/opencl-c.h Modified:

RE: r297468 - [OpenCL] Fix type compatibility check and generic AS mangling.

2017-03-13 Thread Anastasia Stulova via cfe-commits
l/logs/stdio Please have a look at it? Thanks Galina On Fri, Mar 10, 2017 at 7:23 AM, Anastasia Stulova via cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> wrote: Author: stulova Date: Fri Mar 10 09:23:07 2017 New Revision: 297468 URL: http://llvm.org/viewv

r297468 - [OpenCL] Fix type compatibility check and generic AS mangling.

2017-03-10 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Mar 10 09:23:07 2017 New Revision: 297468 URL: http://llvm.org/viewvc/llvm-project?rev=297468=rev Log: [OpenCL] Fix type compatibility check and generic AS mangling. 1. Reimplemented conditional operator so that it checks compatibility of unqualified pointees of the 2nd

RE: r295843 - [OpenCL] r600 needs OpenCL kernel calling convention

2017-02-23 Thread Anastasia Stulova via cfe-commits
Sure! No objections here! Thanks, Anastasia -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 22 February 2017 18:10 To: Jan Vesely Cc: cfe-commits; Matt Arsenault; Anastasia Stulova Subject: Re: r295843 - [OpenCL] r600 needs

RE: D29829: [OpenCL][Doc] Description for adding OpenCL vendor extension in user manual

2017-02-20 Thread Anastasia Stulova via cfe-commits
Perfect! Thanks! Anastasia -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 16 February 2017 17:22 To: Anastasia Stulova Cc: cfe-commits@lists.llvm.org Subject: Re: D29829: [OpenCL][Doc] Description for adding OpenCL vendor

RE: D29829: [OpenCL][Doc] Description for adding OpenCL vendor extension in user manual

2017-02-16 Thread Anastasia Stulova via cfe-commits
Hans, could we merge this documentation only change (r295313) in release40 branch. I can commit myself if needed. :) Thanks in advance, Anastasia -Original Message- From: Anastasia Stulova via Phabricator [mailto:revi...@reviews.llvm.org] Sent: 16 February 2017 14:15 To: Anastasia

r295313 - [OpenCL][Doc] Added OpenCL vendor extension description to user manual doc

2017-02-16 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Feb 16 06:49:29 2017 New Revision: 295313 URL: http://llvm.org/viewvc/llvm-project?rev=295313=rev Log: [OpenCL][Doc] Added OpenCL vendor extension description to user manual doc Added description of a new feature that allows to specify vendor extension in flexible way

r295311 - [OpenCL] Correct ndrange_t implementation

2017-02-16 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Feb 16 06:27:47 2017 New Revision: 295311 URL: http://llvm.org/viewvc/llvm-project?rev=295311=rev Log: [OpenCL] Correct ndrange_t implementation Removed ndrange_t as Clang builtin type and added as a struct type in the OpenCL header. Use type name to do the Sema

r295307 - [OpenCL] Disallow blocks capture other blocks (v2.0, s6.12.5)

2017-02-16 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Feb 16 05:13:30 2017 New Revision: 295307 URL: http://llvm.org/viewvc/llvm-project?rev=295307=rev Log: [OpenCL] Disallow blocks capture other blocks (v2.0, s6.12.5) Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaExpr.cpp

r294313 - [OpenCL] Accept logical NOT for pointer types in CL1.1

2017-02-07 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Feb 7 10:09:41 2017 New Revision: 294313 URL: http://llvm.org/viewvc/llvm-project?rev=294313=rev Log: [OpenCL] Accept logical NOT for pointer types in CL1.1 Fix for bug 30217 - incorrect error given for logical NOT operation with a pointer type: corrected sema check

RE: r285733 - clang/test/CodeGenOpenCL/convergent.cl: Satisfy -Asserts with "opt -instnamer".

2017-02-07 Thread Anastasia Stulova via cfe-commits
I don't understand why we need this extra step in testing now? Did anything fail? Thanks, Anastasia -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of NAKAMURA Takumi via cfe-commits Sent: 01 November 2016 20:08 To: cfe-commits@lists.llvm.org

r293286 - [OpenCL] Add missing address spaces in IR generation of blocks

2017-01-27 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Fri Jan 27 09:11:34 2017 New Revision: 293286 URL: http://llvm.org/viewvc/llvm-project?rev=293286=rev Log: [OpenCL] Add missing address spaces in IR generation of blocks Modify ObjC blocks impl wrt address spaces as follows: - keep default private address space for blocks

r293050 - [OpenCL] Diagnose write_only image3d when extension is disabled

2017-01-25 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Wed Jan 25 06:18:50 2017 New Revision: 293050 URL: http://llvm.org/viewvc/llvm-project?rev=293050=rev Log: [OpenCL] Diagnose write_only image3d when extension is disabled Prior to OpenCL 2.0, image3d_t can only be used with the write_only access qualifier when the

r292804 - [OpenCL] Improved enqueue_kernel diagnostic message

2017-01-23 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Mon Jan 23 11:12:36 2017 New Revision: 292804 URL: http://llvm.org/viewvc/llvm-project?rev=292804=rev Log: [OpenCL] Improved enqueue_kernel diagnostic message - Removed duplicated word typo. - Made coherent across multiple similar diagnostics. Modified:

RE: PATCH: re-enable OpenCL extensions

2017-01-19 Thread Anastasia Stulova via cfe-commits
As mentioned on cfe-dev as well, although it doesn't seem too critical it is generally not logical to enable all extensions by default because most of the targets don't even support OpenCL. But I understand your situation with using x86 or ARM backends in a generic way. Do you think this can be

r291780 - [Docs][OpenCL] Added OpenCL feature description to Clang documentation.

2017-01-12 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Thu Jan 12 11:52:22 2017 New Revision: 291780 URL: http://llvm.org/viewvc/llvm-project?rev=291780=rev Log: [Docs][OpenCL] Added OpenCL feature description to Clang documentation. Updated index and UsersManual with OpenCL description. Review: https://reviews.llvm.org/D28080

RE: [PATCH] D27334: [OpenCL] Ambiguous function call.

2016-12-06 Thread Anastasia Stulova via cfe-commits
I think we can’t avoid deviating from C/C++ implementation completely. But we should certainly try to avoid it in unnecessary situations as much as we can. In this case it seems like the spec enforces the rules for resolving the ambiguity that seems logical to me. Is this possibly a better way

RE: [PATCH] D27334: [OpenCL] Ambiguous function call.

2016-12-05 Thread Anastasia Stulova via cfe-commits
> Perhaps that is the problem (that there are two modes that do different > things)? Could we make the double overload be present but unselectable to > diagnose this problem in that mode too? If we could resolve the overload candidate to prefer ‘int -> float’ than ‘int->double’, it would work

r288163 - [OpenCL] Prevent generation of globals in non-constant AS for OpenCL.

2016-11-29 Thread Anastasia Stulova via cfe-commits
Author: stulova Date: Tue Nov 29 11:01:19 2016 New Revision: 288163 URL: http://llvm.org/viewvc/llvm-project?rev=288163=rev Log: [OpenCL] Prevent generation of globals in non-constant AS for OpenCL. Avoid using shortcut for const qualified non-constant address space aggregate variables while

<    1   2   3   4   5   6   >