[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG1285a495d588: [clang][pp] Handle attributes defined by plugin in __has_attribute (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144404: [clang] Extract function for generated part of clang::hasAttribute (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8629343a8b6c: [clang] Extract function for generated part of clang::hasAttribute (NFC) (authored by wanders). Repository: rG LLVM Github Monorepo

[PATCH] D144403: [clang] Extract attribute plugin instantiation to function (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5f1813defb5: [clang] Extract attribute plugin instantiation to function (NFC) (authored by wanders). Repository: rG LLVM Github Monorepo

[PATCH] D145769: [clang] Extract ParsedAttrInfo::hasSpelling method (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG446f78092ffa: [clang] Extract ParsedAttrInfo::hasSpelling method (NFC) (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144402: [clang] Move ParsedAttrInfo from Sema to Basic (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG383cfeee09d1: [clang] Move ParsedAttrInfo from Sema to Basic (NFC) (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

wanders added a comment. In D144405#4184964 , @erichkeane wrote: > So here's a potential idea for future development: It isn't > uncommon/untypical for an attribute to want to return something other than > '1', for 'version' (usually an integral

[PATCH] D145769: [clang] Extract ParsedAttrInfo::hasSpelling method (NFC)

wanders edited the summary of this revision. wanders updated this revision to Diff 504150. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145769/new/ https://reviews.llvm.org/D145769 Files: clang/include/clang/Basic/ParsedAttrInfo.h

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

wanders updated this revision to Diff 504152. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144405/new/ https://reviews.llvm.org/D144405 Files: clang/docs/ReleaseNotes.rst clang/examples/Attribute/Attribute.cpp clang/lib/Basic/Attributes.cpp

[PATCH] D144404: [clang] Extract function for generated part of clang::hasAttribute (NFC)

wanders updated this revision to Diff 504151. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144404/new/ https://reviews.llvm.org/D144404 Files: clang/lib/Basic/Attributes.cpp Index: clang/lib/Basic/Attributes.cpp

[PATCH] D144402: [clang] Move ParsedAttrInfo from Sema to Basic (NFC)

wanders added a comment. In D144402#4184749 , @erichkeane wrote: > I want to wait for @aaron.ballman to answer, but i think this is generally > OK. Note the motivation is the ability to check this from > __has_cpp_attribute/__has_c_attribute/etc. I

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

wanders added a comment. In D144405#4184726 , @erichkeane wrote: > Looks like this doesn't compile pre-commit, though no idea if that is a > patch-stack issue. Other than test, patch looks fine. Yeah, when uploading the new commit the stack was

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

wanders marked 2 inline comments as done. wanders added a comment. @erichkeane Patch stack now updated to include a method extraction of hasSpelling, and releasenote added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144405/new/

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

wanders edited the summary of this revision. wanders updated this revision to Diff 504045. wanders marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144405/new/ https://reviews.llvm.org/D144405 Files:

[PATCH] D144404: [clang] Extract function for generated part of clang::hasAttribute (NFC)

wanders edited the summary of this revision. wanders updated this revision to Diff 504044. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144404/new/ https://reviews.llvm.org/D144404 Files: clang/lib/Basic/Attributes.cpp Index:

[PATCH] D144403: [clang] Extract attribute plugin instantiation to function (NFC)

wanders edited the summary of this revision. wanders updated this revision to Diff 504042. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144403/new/ https://reviews.llvm.org/D144403 Files: clang/include/clang/Basic/ParsedAttrInfo.h

[PATCH] D145769: [clang] Extract ParsedAttrInfo::hasSpelling method (NFC)

wanders created this revision. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This intends to simplify this checking when it is done in more places. No functional change intended. Depends on D144403

[PATCH] D144402: [clang] Move ParsedAttrInfo from Sema to Basic (NFC)

wanders updated this revision to Diff 504041. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144402/new/ https://reviews.llvm.org/D144402 Files: clang/include/clang/Basic/ParsedAttrInfo.h clang/include/clang/Sema/ParsedAttr.h

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

wanders added inline comments. Comment at: clang/lib/Basic/Attributes.cpp:46 + for (auto : getAttributePluginInstances()) { +for (auto : AttrPlugin->Spellings) + if (S.Syntax == Syntax && S.NormalizedFullName == Name) erichkeane wrote: > I think this

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute r=aaron.ballman

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using attributes by plugins (both in

[PATCH] D144404: [clang] Extract function for generated part of clang::hasAttribute (NFC) r=aaron.ballman

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes it easier to add additional

[PATCH] D144403: [clang] Extract attribute plugin instantiation to function (NFC) r=aaron.ballman

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This moves the code to instantiate the attribute plugins to the same place where

[PATCH] D144402: [clang] Move ParsedAttrInfo from Sema to Basic (NFC) r=aaron.ballman

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This moves the ParsedAttrInfo class and the registry for attribute plugin to be

[PATCH] D127201: [clang] Add tests for statement expression in initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG657e954939c8: [clang] Add tests for statement expression in initializers (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders updated this revision to Diff 436561. wanders added a subscriber: kimgr. wanders added a comment. Updated diff with: - Release note - Cleaned up command line options in RUN commands - Fixed type mimatch pointed out by @kimgr (out of band) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders added a comment. In D127201#3578077 , @aaron.ballman wrote: > Thanks for adding some more test coverage! Would it be worth mentioning the > miscompile fix in the release notes more explicitly? Yes, might be a good idea, in particualar as some

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders added a comment. One week gentle ping. + added reviewers from the https://reviews.llvm.org/D111400 patch that fixed the bug these tests covers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127201/new/ https://reviews.llvm.org/D127201

[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

This revision was automatically updated to reflect the committed changes. Closed by commit rGff4abe755279: [scan-build-py] Fix exception on shutdown with sarif-html output format (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

wanders updated this revision to Diff 435999. wanders added a comment. Updated patch with full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126974/new/ https://reviews.llvm.org/D126974 Files:

[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

wanders added a comment. Gentle 1-week ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126974/new/ https://reviews.llvm.org/D126974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders created this revision. wanders added reviewers: cor3ntin, rsmith. wanders added a project: clang. Herald added a project: All. wanders requested review of this revision. Herald added a subscriber: cfe-commits. The commit 683e83c5

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

This revision was automatically updated to reflect the committed changes. wanders marked 2 inline comments as done. Closed by commit rGdd2362a8bab3: [clang] Allow const variables with weak attribute to be overridden (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

wanders created this revision. wanders added reviewers: phosek, isthismyaccount. Herald added a subscriber: whisperity. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When running scan-build-py's

[PATCH] D126804: [scan-build-py] Change scripts to explicitly require python3

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c1e487c4138: scan-build-py: Change scripts to explicitly require python3 (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126804/new/

[PATCH] D126804: [scan-build-py] Change scripts to explicitly require python3

wanders created this revision. wanders added reviewers: phosek, sylvestre.ledru. Herald added a subscriber: whisperity. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "#!" line in all scan-build-py

[PATCH] D126578: [clang] Add tests for (const) weak variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG86f9cf88cb06: [clang] Add tests for (const) weak variables (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126578/new/

[PATCH] D126578: [clang] Add tests for (const) weak variables

wanders added a comment. In D126578#3543994 , @aaron.ballman wrote: > Thanks for looking to improve our test coverage here! However, precommit CI > looks to be failing: Thanks for notifying me. It should be green now. Repository: rG LLVM Github

[PATCH] D126578: [clang] Add tests for (const) weak variables

wanders updated this revision to Diff 432742. wanders added a comment. Added explicit triple to hopefully make it pass on win. Made the new files clang-format clean. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126578/new/

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

wanders updated this revision to Diff 432669. wanders added a comment. Diff updated with release note + updated text in documentation as per jyknight's suggestion. Tests for existing behavior added in separate patch: https://reviews.llvm.org/D126578 Repository: rG LLVM Github Monorepo

[PATCH] D126578: [clang] Add tests for (const) weak variables

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds tests checking the behavior of const variables declared with weak

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

wanders added a comment. In D126324#3536785 , @aaron.ballman wrote: > The changes so far look sensible, but I think we should add some more tests > for a few situations. 1) Using a const weak symbol as a valid initializer > should be diagnosed (with a

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

wanders updated this revision to Diff 431933. wanders added a comment. Diff updated to be git-clang-format clean and to (hopefully) accommodate for differences in test output on w64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126324/new/

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

wanders created this revision. wanders added reviewers: lattner, jyknight, rsmith. wanders added a project: clang. Herald added a reviewer: aaron.ballman. Herald added a project: All. wanders requested review of this revision. Herald added a subscriber: cfe-commits. A variable with `weak`

[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

wanders added a comment. This looks sensible to me. But I'm not an expert in the area (and still not 100% clear on the purpose of the ignorelist) so can't really say if the added comments captures the intent accurately. Comment at: clang/test/Driver/embed-bitcode-elf.c:1 +//

[PATCH] D125961: [clang-format] Don't break lines after pragma region

wanders added a comment. There are other pragmas which include colon. How do they fare? Example https://docs.microsoft.com/en-us/cpp/preprocessor/warning?view=msvc-170 #pragma warning( disable : 4507 34; once : 4385; error : 164 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

wanders added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4760-4762 // reject options that shouldn't be supported in bitcode // also reject kernel/kext static const constexpr unsigned kBitcodeOptionIgnorelist[] = { This

[PATCH] D101139: Create install targets for scan-build-py.

wanders added a comment. I think this looks good. I can't vouch for the cmake changes. However there seems like diff is based on something that already has moved parts into libexec. It doesn't apply cleanly here - and buildkite seems to complain too. Make sure you have the complete diff.

[PATCH] D101139: Create install targets for scan-build-py.

wanders added a comment. In D101139#2743346 , @aabbaabb wrote: > Renamed lib to libexec and add custom rules to copy files to build output. That rename was a bit too fast I think. I would expect the libraries (libear & libscanbuild) to be in lib/. The

[PATCH] D101139: Create install targets for scan-build-py.

wanders added inline comments. Comment at: clang/tools/scan-build-py/CMakeLists.txt:8 + "bin/intercept-cc" + "bin/scan-build") + This overwrites the "bin/scan-build" that was installed from the scan-build (no -py) subdirectory. So with this

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG52ab7aa0ba5a: [clang-format] Add BitFieldColonSpacing option (authored by wanders). Repository: rG LLVM Github

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

wanders added a comment. In D84090#2162389 , @MyDeveloperDay wrote: > 2. then I can do `git clang-format`, this will fix up any files in the diff > that need formatting (you'll need to git add them again if they have) (I use

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

wanders updated this revision to Diff 279279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/ https://reviews.llvm.org/D84090 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

wanders updated this revision to Diff 279237. wanders retitled this revision from "[clang-format] Add SpaceAroundBitFieldColon option" to "[clang-format] Add BitFieldColonSpacing option". wanders edited the summary of this revision. wanders added a comment. Renamed option to

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

wanders marked an inline comment as done. wanders added a comment. In D84090#2160411 , @curdeius wrote: > The changes look good to me in general. I share your doubt though about > whether a bool flag is sufficient here. We've seen in the past a few times

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

wanders updated this revision to Diff 279010. wanders added a comment. - Regenerated rst - Fixed clang format errors - Added release note - Added bool parsing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/

[PATCH] D84103: [clang-format] Make sure rst documentation matches comments

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d7ec54170f9: [clang-format] Make sure rst documentation matches comments (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84103/new/

[PATCH] D84103: [clang-format] Make sure rst documentation matches comments

wanders created this revision. wanders added reviewers: MyDeveloperDay, JakeMerdichAMD. wanders added a project: clang-format. Herald added a project: clang. clang/docs/tools/dump_format_style.py is used to read the comments from clang/include/clang/Format/Format.h and update the contents of

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

wanders created this revision. wanders added reviewers: MyDeveloperDay, klimek. wanders added a project: clang-format. Herald added a project: clang. This new option allows controlling if there should be spaces around the ':' in a bitfield declaration. Decides if it should be the

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

wanders abandoned this revision. wanders added a comment. In D68569#2019895 , @MyDeveloperDay wrote: > Can we abandon this review now we have the style=file:? Yes, lets abandon this. Comment at: clang/lib/Format/Format.cpp:2606 +

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG86825dbe3306: [clang-format] Make .clang-format variants finding a loop (NFC) (authored by wanders). Changed prior to commit: https://reviews.llvm.org/D68568?vs=223488=228187#toc Repository: rG LLVM

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

wanders added a comment. In D68568#1735741 , @MyDeveloperDay wrote: > Do you need help landing this? Sorry that I havn't gotten back to this. I started looking into the "PathMatch" idea I floated in D68569

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

wanders added a comment. The "Language" option can not distinguish between C and C++. We have projects which contains both C and C++ code. Using different style (yes..) for C and C++. Our C++ headers are named hpp. In our toplevel we have the following symlinks .c.clang-format ->

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

wanders added a comment. This depends on https://reviews.llvm.org/D68568 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68569/new/ https://reviews.llvm.org/D68569 ___ cfe-commits mailing list

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

wanders created this revision. wanders added a reviewer: clang-format. wanders added a project: clang-format. Herald added a project: clang. E.g: When formatting foo.cpp it will look for .cpp.clang-format This makes it easy to different formatting for .c/.h files and .cpp/.hpp files

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

wanders created this revision. wanders added a reviewer: clang-format. wanders added a project: clang-format. Herald added a project: clang. No functional change intended Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68568 Files: clang/lib/Format/Format.cpp Index:

[PATCH] D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone

wanders abandoned this revision. wanders added a comment. I might revisit this later. But carrying this patch locally for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61627/new/ https://reviews.llvm.org/D61627

[PATCH] D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone

wanders added a comment. > Why are you interested in expending this list? I have a (kernel) that is compiled with `-mno-red-zone` and `-mcmodel=large` which I want to compile with `-fembed-bitcode` for a debugging tool that needs the bitcode. But I can carry these patches locally for now.

[PATCH] D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone

wanders added a comment. But running code that has been compiled with `-mno-red-zone` on a platform that guarantees that redzones are not stamped on should be fine as far as I can understand? The red zone is that the platform guarantees that it (e.g signal handlers, interrupts) will not use

[PATCH] D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone

wanders created this revision. wanders added reviewers: steven_wu, compnerd, rsmith. wanders added a project: clang. Herald added a subscriber: dexonsmith. The -mno-red-zone (and the option to cancel it out: -mred-zone) were not allowed to be combined with -fembed-bitcode. However this option has