[PATCH] D33029: [clang-format] add option for dangling parenthesis

2021-10-13 Thread Andrew Somerville via Phabricator via cfe-commits
catskul added inline comments. Comment at: include/clang/Format/Format.h:793 + /// \endcode + bool DanglingParenthesis; + seesemichaelj wrote: > catskul wrote: > > stringham wrote: > > > djasper wrote: > > > > stringham wrote: > > > > > djasper wrote: > > > >

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

2021-06-28 Thread Andrew Somerville via Phabricator via cfe-commits
catskul abandoned this revision. catskul added a comment. Abandoning because of: https://reviews.llvm.org/D104096 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90238/new/ https://reviews.llvm.org/D90238

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2021-05-06 Thread Andrew Somerville via Phabricator via cfe-commits
catskul added a comment. It's all good for me. Sorry for slow responses. My time to work on this is few and far between. I'm happy if anyone picks it up or any energy put into this. Would love to see it land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/

[PATCH] D90238: Update to D31635

2020-10-27 Thread Andrew Somerville via Phabricator via cfe-commits
catskul created this revision. catskul added a reviewer: clang-format. catskul added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. catskul requested review of this revision. I'm trying to get D31635 past the

[PATCH] D90232: Respond to review items and renew D14484 for merge possiblity

2020-10-27 Thread Andrew Somerville via Phabricator via cfe-commits
catskul created this revision. catskul added a reviewer: clang-format. catskul added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. catskul requested review of this revision. I'm trying to get D14484 past the

[PATCH] D90209: add test for PAS_Right + RAS_Left + commentedout '* &' example

2020-10-26 Thread Andrew Somerville via Phabricator via cfe-commits
catskul abandoned this revision. catskul added a comment. Accidental creation of diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90209/new/ https://reviews.llvm.org/D90209 ___ cfe-commits mailing

[PATCH] D90209: add test for PAS_Right + RAS_Left + commentedout '* &' example

2020-10-26 Thread Andrew Somerville via Phabricator via cfe-commits
catskul created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. catskul requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90209 Files: clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

2020-10-26 Thread Andrew Somerville via Phabricator via cfe-commits
catskul added a comment. @FStefanni, after managing to update this patch to work with the latest code, and trying out your example it appears this patch doesn't quite cover your case. I did manage to fix it to cover your case, but I suppose at this point I should ask @MyDeveloperDay and

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2020-10-26 Thread Andrew Somerville via Phabricator via cfe-commits
catskul added inline comments. Comment at: include/clang/Format/Format.h:793 + /// \endcode + bool DanglingParenthesis; + stringham wrote: > djasper wrote: > > stringham wrote: > > > djasper wrote: > > > > I don't think this is a name that anyone will

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2020-10-26 Thread Andrew Somerville via Phabricator via cfe-commits
catskul added a comment. @MyDeveloperDay I'm going to upload a re-based version of this. Should I rebase it off the top of master? Tip of 11? and/or create a new diff/review for each? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llvm.org/D33029

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

2020-10-15 Thread Andrew Somerville via Phabricator via cfe-commits
catskul added a comment. In D14484#2246171 , @FStefanni wrote: > Hi to all, > > I am also interested to this option, since match my personal style, but more > important, in my experience, this kind of formatting is very used. > I hope it will be

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2020-03-27 Thread Andrew Somerville via Phabricator via cfe-commits
catskul added a comment. @bbassi @MyDeveloperDay I'll buy whoever manages to land this feature a case of their favorite beer/beverage (max $50). Or $50 worth of girlscout cookies. : ) Just ping me when it lands and we can arrange the shipment. CHANGES SINCE LAST ACTION