Yes, I think so.
> On Jul 26, 2016, at 1:37 AM, Vassil Vassilev wrote:
>
> (forgot to click "reply all")
> Thanks! This is really handy interface. Would it make sense adding the same
> for NamespaceDecl for consistency?
> On 15/07/16 20:11, Argyrios Kyrtzidis via
akyrtzi added a comment.
Thanks for making the changes; I'd recommend to go ahead and commit and we can
iterate post-commit if necessary.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: akirtzidis
Date: Fri Jul 15 17:18:19 2016
New Revision: 275630
URL: http://llvm.org/viewvc/llvm-project?rev=275630&view=rev
Log:
[index] Create different USR if a property is a class property.
Avoids USR conflicts between class & instance properties of the same name.
Modified:
cfe/tr
> On Jul 15, 2016, at 1:03 PM, Argyrios Kyrtzidis wrote:
>
>>
>> On Jul 15, 2016, at 12:58 PM, Ben Langmuir > <mailto:blangm...@apple.com>> wrote:
>>
>>>
>>> On Jul 15, 2016, at 12:22 PM, Argyrios Kyrtzidis via cfe-commits
>>
Author: akirtzidis
Date: Fri Jul 15 15:40:24 2016
New Revision: 275609
URL: http://llvm.org/viewvc/llvm-project?rev=275609&view=rev
Log:
[test/objcmt] Add a follow-up test case for r275600.
Modified:
cfe/trunk/test/ARCMT/whitelisted/header1.h
cfe/trunk/test/ARCMT/whitelisted/header1.h.res
> On Jul 15, 2016, at 12:58 PM, Ben Langmuir wrote:
>
>>
>> On Jul 15, 2016, at 12:22 PM, Argyrios Kyrtzidis via cfe-commits
>> wrote:
>>
>> Author: akirtzidis
>> Date: Fri Jul 15 14:22:34 2016
>> New Revision: 275600
>>
>>
Author: akirtzidis
Date: Fri Jul 15 14:22:34 2016
New Revision: 275600
URL: http://llvm.org/viewvc/llvm-project?rev=275600&view=rev
Log:
[objcmt] Fix a buffer overflow crash than can occur while modernizing enums.
Note that due to the nature of the crash it requires libgmalloc or asan for it
to
Author: akirtzidis
Date: Fri Jul 15 13:11:27 2016
New Revision: 275589
URL: http://llvm.org/viewvc/llvm-project?rev=275589&view=rev
Log:
[objcmt] Don't add an #import of Foundation unnecessarily, if the NS_ENUM macro
is already defined.
Modified:
cfe/trunk/lib/ARCMigrate/ObjCMT.cpp
cfe/t
Author: akirtzidis
Date: Fri Jul 15 13:11:33 2016
New Revision: 275590
URL: http://llvm.org/viewvc/llvm-project?rev=275590&view=rev
Log:
[AST] Keep track of the left brace source location of a tag decl.
This is useful for source modification tools. There will be a follow-up commit
using it.
Mod
Author: akirtzidis
Date: Thu Jul 14 15:21:16 2016
New Revision: 275466
URL: http://llvm.org/viewvc/llvm-project?rev=275466&view=rev
Log:
[arcmt/objcmt] Fix ParentMap crash with invalid code.
rdar://22489560
Added:
cfe/trunk/test/ARCMT/objcmt-invalid-code.mm
cfe/trunk/test/ARCMT/objcmt-in
Author: akirtzidis
Date: Wed Jul 13 17:03:47 2016
New Revision: 275324
URL: http://llvm.org/viewvc/llvm-project?rev=275324&view=rev
Log:
[test] Add 'env' to fix test failures in windows bots.
Modified:
cfe/trunk/test/Index/pch-warn-as-error-code-split.cpp
Modified: cfe/trunk/test/Index/pch-w
Author: akirtzidis
Date: Wed Jul 13 15:35:26 2016
New Revision: 275313
URL: http://llvm.org/viewvc/llvm-project?rev=275313&view=rev
Log:
[PCH/preamble] Make sure that if the preamble/PCH was serialized with errors
that we set diagnostic engine state appropriately.
Otherwise there can be a crash
Author: akirtzidis
Date: Fri Jul 1 14:10:54 2016
New Revision: 274378
URL: http://llvm.org/viewvc/llvm-project?rev=274378&view=rev
Log:
[libclang] Sync-up the way top-level decls in an ASTUnit are handled with how
decls in a DeclContext are handled.
rdar://19775013
Modified:
cfe/trunk/test
Author: akirtzidis
Date: Thu Jun 30 20:17:02 2016
New Revision: 274314
URL: http://llvm.org/viewvc/llvm-project?rev=274314&view=rev
Log:
[CodeCompletion] Allow system headers providing private symbols with a single
underscore.
rdar://24677150
Modified:
cfe/trunk/lib/Sema/SemaCodeComplete.cp
Could you also check performance of creating a PCH file out of Cocoa.h ?
> On May 19, 2016, at 1:47 PM, Vedant Kumar wrote:
>
> vsk added a comment.
>
> I discussed this bug with Argyrios off-list, who lgtm'd on the condition that
> it doesn't introduce a performance regression. He suggested p
Author: akirtzidis
Date: Fri Apr 22 02:21:16 2016
New Revision: 267118
URL: http://llvm.org/viewvc/llvm-project?rev=267118&view=rev
Log:
[index] Add SymbolSubKinds for ObjC IB annotations.
Modified:
cfe/trunk/include/clang/Index/IndexSymbol.h
cfe/trunk/lib/Index/IndexSymbol.cpp
cfe/tr
Author: akirtzidis
Date: Fri Apr 22 02:21:10 2016
New Revision: 267117
URL: http://llvm.org/viewvc/llvm-project?rev=267117&view=rev
Log:
[index] Add a SymbolSubKind for an ObjC unit test.
Added:
cfe/trunk/test/Index/Core/index-subkinds.m
Modified:
cfe/trunk/include/clang/Index/IndexSymbol
Author: akirtzidis
Date: Fri Apr 22 02:21:04 2016
New Revision: 267116
URL: http://llvm.org/viewvc/llvm-project?rev=267116&view=rev
Log:
[index] Change SymbolCXXTemplateKind to a 'SymbolSubKinds' bitset.
This provides a more general and flexible way to annotate special symbols.
Modified:
cfe
Author: akirtzidis
Date: Thu Mar 31 15:18:22 2016
New Revision: 265042
URL: http://llvm.org/viewvc/llvm-project?rev=265042&view=rev
Log:
[index] Fix regression where ObjC method declarations may mistakenly get
indexed as definition.
rdar://25372906
Modified:
cfe/trunk/lib/Index/IndexingCont
The long-term intention of this was to separate user modules vs system modules,
so that you could have user modules generated in the project-specific build
directory while system modules would be in the global directory shared across
projects.
That way when you deleted the project build director
Author: akirtzidis
Date: Wed Mar 16 23:28:19 2016
New Revision: 263689
URL: http://llvm.org/viewvc/llvm-project?rev=263689&view=rev
Log:
[index] Make sure that declarations of builtin functions are indexed.
rdar://25154630
Modified:
cfe/trunk/lib/Index/IndexingContext.cpp
cfe/trunk/test/
If not addressing the issue with '-fmodule-name' could you revert removal of
original ‘-fmodule-implementation-of’ since we are depending on it ?
> On Mar 3, 2016, at 6:13 PM, Argyrios Kyrtzidis via cfe-commits
> wrote:
>
> Hey Richard,
>
> -fmodule-name emits b
> On Mar 8, 2016, at 6:28 PM, Ben Langmuir wrote:
>
>>
>> On Mar 8, 2016, at 6:12 PM, Argyrios Kyrtzidis via cfe-commits
>> wrote:
>>
>> Author: akirtzidis
>> Date: Tue Mar 8 20:12:40 2016
>> New Revision: 262984
>>
>> URL: ht
Author: akirtzidis
Date: Tue Mar 8 20:53:12 2016
New Revision: 262991
URL: http://llvm.org/viewvc/llvm-project?rev=262991&view=rev
Log:
[index] Add a message for the assertion, NFC.
Modified:
cfe/trunk/lib/Index/IndexingContext.cpp
Modified: cfe/trunk/lib/Index/IndexingContext.cpp
URL:
htt
Author: akirtzidis
Date: Tue Mar 8 20:12:46 2016
New Revision: 262985
URL: http://llvm.org/viewvc/llvm-project?rev=262985&view=rev
Log:
[index] libclang: Make sure to treat forward ObjC protocols as ObjCProtocolRef
declarations, and fix related crash.
rdar://25035376
Modified:
cfe/trunk/li
Author: akirtzidis
Date: Tue Mar 8 20:12:40 2016
New Revision: 262984
URL: http://llvm.org/viewvc/llvm-project?rev=262984&view=rev
Log:
[index] Fix assertion hit when indexing re-declarations of built-in functions.
Modified:
cfe/trunk/lib/Index/IndexingContext.cpp
cfe/trunk/test/Index/Co
Author: akirtzidis
Date: Fri Mar 4 01:17:53 2016
New Revision: 262695
URL: http://llvm.org/viewvc/llvm-project?rev=262695&view=rev
Log:
[index] Distinguish USRs of anonymous enums by using their first enumerator.
rdar://24609949.
Modified:
cfe/trunk/lib/Index/IndexingContext.cpp
cfe/tru
Author: akirtzidis
Date: Fri Mar 4 01:17:48 2016
New Revision: 262694
URL: http://llvm.org/viewvc/llvm-project?rev=262694&view=rev
Log:
[index] Include parameter types in the USRs for C functions marked with
'overloadable' attribute.
Modified:
cfe/trunk/lib/Index/USRGeneration.cpp
cfe/t
Author: akirtzidis
Date: Fri Mar 4 01:17:43 2016
New Revision: 262693
URL: http://llvm.org/viewvc/llvm-project?rev=262693&view=rev
Log:
[index] In ObjC++ handle objc type parameters for function USRs.
Added:
cfe/trunk/test/Index/Core/index-source.mm
Modified:
cfe/trunk/lib/Index/USRGener
Author: akirtzidis
Date: Thu Mar 3 22:24:32 2016
New Revision: 262686
URL: http://llvm.org/viewvc/llvm-project?rev=262686&view=rev
Log:
[index] Ignore ObjCTypeParamDecls during indexing.
Modified:
cfe/trunk/lib/Index/IndexingContext.cpp
cfe/trunk/test/Index/Core/index-source.m
Modified:
Mind if we keep -fmodule-implementation-of as an alias so that we can gradually
transition to -fmodule-name ?
> On Feb 19, 2016, at 2:25 PM, Richard Smith via cfe-commits
> wrote:
>
> Author: rsmith
> Date: Fri Feb 19 16:25:36 2016
> New Revision: 261372
>
> URL: http://llvm.org/viewvc/llvm-p
Author: akirtzidis
Date: Wed Mar 2 23:33:48 2016
New Revision: 262583
URL: http://llvm.org/viewvc/llvm-project?rev=262583&view=rev
Log:
[test] Re-enable asan on the test, stack usage should be lower.
Modified:
cfe/trunk/test/Index/index-many-logical-ops.c
Modified: cfe/trunk/test/Index/inde
Author: akirtzidis
Date: Wed Mar 2 23:33:54 2016
New Revision: 262584
URL: http://llvm.org/viewvc/llvm-project?rev=262584&view=rev
Log:
[index] Report references of ObjC super class/protocols in interfaces and
protocols.
Modified:
cfe/trunk/lib/Index/IndexDecl.cpp
cfe/trunk/test/Index/C
akyrtzi added a comment.
In http://reviews.llvm.org/D17820#366638, @milianw wrote:
> But, we currently always request code completion at a word start boundary so
> nothing would change for us. That said, I see how this patch could be seen as
> a breaking behavior change, and thus should probabl
akyrtzi added a comment.
We should not bake-in filtering into the clang CodeComplete API. What kind of
filtering to use should be on a higher level, different clients may want
different filtering, e.g. prefix filtering, fuzzy filtering, etc.
Repository:
rL LLVM
http://reviews.llvm.org/D1782
t;> llvm::PointerLikeTypeTraits > > >*) () from
>>>>>>> /usr/local/google/home/jlebar/code/llvm-complete/release/bin/../lib/libclang.so.3.9
>>>>>>> #17 0x751a880e in clang::RecursiveASTVisitor<(anonymous
>>>>&g
Author: akirtzidis
Date: Mon Feb 29 22:40:20 2016
New Revision: 262295
URL: http://llvm.org/viewvc/llvm-project?rev=262295&view=rev
Log:
[test] After r262290 reducing stack usage, try re-enabling asan on the related
test.
Modified:
cfe/trunk/test/Index/index-many-call-ops.cpp
Modified: cfe/
asan was also hitting stack overflow and I’m going to try re-enabling
for that test.
> On Feb 29, 2016, at 8:10 PM, David Blaikie wrote:
>
> Does this change any behavior? (missing test case?)
>
> On Mon, Feb 29, 2016 at 6:46 PM, Argyrios Kyrtzidis via cfe-commits
sitor<(anonymous
>>>> namespace)::BodyIndexer>::dataTraverseNode(clang::Stmt*,
>>>> llvm::SmallVectorImpl>>> llvm::PointerLikeTypeTraits,
>>>> llvm::PointerIntPairInfo>>> llvm::PointerLikeTypeTraits > > >*) () from
>>>> /
Author: akirtzidis
Date: Mon Feb 29 20:46:32 2016
New Revision: 262290
URL: http://llvm.org/viewvc/llvm-project?rev=262290&view=rev
Log:
[index] Fix issue where data visitation was disabled with C++ operator call
expressions, during indexing.
Modified:
cfe/trunk/lib/Index/IndexBody.cpp
Modi
eStmt(clang::Stmt*,
>>> llvm::SmallVectorImpl>> llvm::PointerLikeTypeTraits,
>>> llvm::PointerIntPairInfo>> llvm::PointerLikeTypeTraits > > >*) () from
>>> /usr/local/google/home/jlebar/code/llvm-complete/release/bin/../lib/libclang.so.3.9
>
Mon, Feb 29, 2016 at 3:03 PM, Argyrios Kyrtzidis wrote:
>> Is this still an issue after r260785 ?
>> Could you provide a stack trace ?
>>
>>> On Feb 29, 2016, at 2:27 PM, Justin Lebar wrote:
>>>
>>> Hi, I think this broke clang/test/Index/in
I'm just the first person to bother bisecting this...
> Maybe the test just needs to be pared down some?
>
> Please advise.
>
> Regards,
> -Justin
>
> On Sat, Feb 13, 2016 at 12:47 PM, Argyrios Kyrtzidis via cfe-commits
> wrote:
>> I guess refreshing the build
Author: akirtzidis
Date: Mon Feb 29 01:55:55 2016
New Revision: 262206
URL: http://llvm.org/viewvc/llvm-project?rev=262206&view=rev
Log:
[AST/RecursiveASTVisitor] Correction so that dataTraverseStmtPost will get
called after the statement has been visited.
Fixes the indexing client of this.
Mod
Author: akirtzidis
Date: Mon Feb 29 01:56:00 2016
New Revision: 262207
URL: http://llvm.org/viewvc/llvm-project?rev=262207&view=rev
Log:
[index] Add a caller relation for a call reference.
Modified:
cfe/trunk/include/clang/Index/IndexSymbol.h
cfe/trunk/lib/Index/IndexBody.cpp
cfe/trun
Author: akirtzidis
Date: Mon Feb 29 01:56:07 2016
New Revision: 262208
URL: http://llvm.org/viewvc/llvm-project?rev=262208&view=rev
Log:
[index] Print and test module import references.
Added:
cfe/trunk/test/Index/Core/Inputs/
cfe/trunk/test/Index/Core/Inputs/module/
cfe/trunk/test/In
Author: akirtzidis
Date: Mon Feb 29 01:55:51 2016
New Revision: 262205
URL: http://llvm.org/viewvc/llvm-project?rev=262205&view=rev
Log:
[index] Use ',' to separate symbol roles when printing.
Modified:
cfe/trunk/lib/Index/IndexSymbol.cpp
cfe/trunk/test/Index/Core/index-source.cpp
cfe
Author: akirtzidis
Date: Sat Feb 20 14:34:55 2016
New Revision: 261445
URL: http://llvm.org/viewvc/llvm-project?rev=261445&view=rev
Log:
[c-index-test] CMake: When installing c-index-test to a different prefix
directory, add an rpath so that
it can find libclang.
Modified:
cfe/trunk/tools/c-
akyrtzi added a comment.
Could you check if you can decouple VerifyDiagnosticConsumer from depending on
a particular DiagnosticsEngine ?
http://reviews.llvm.org/D17026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
akyrtzi added a comment.
I'm not sure removing all the Importer.FromDiag() calls is the right thing. You
are changing
Importer.FromDiag(D->getLocation(), diag::err_unsupported_ast_node)
to
Importer.ToDiag(SourceLocation(), diag::err_unsupported_ast_node)
and you lose the source location infor
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
If I apply just the test changes without the rest of the changes, I don't see
any failures, so I'm not sure these are effective tests.
http://reviews.llvm.org/D17029
___
cfe-commits mail
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
Doesn't this mean that _all_ of the Importer.FromDiag() calls will be ignored
by VerifyDiagnosticConsumer ? Why specifically change only this two and what
are we going to do with the others ?
This seems more like needing a fix higher
akyrtzi added a subscriber: akyrtzi.
akyrtzi accepted this revision.
akyrtzi added a reviewer: akyrtzi.
akyrtzi added a comment.
This revision is now accepted and ready to land.
LGTM, committed in r261274.
http://reviews.llvm.org/D16923
___
cfe-comm
Author: akirtzidis
Date: Thu Feb 18 17:08:36 2016
New Revision: 261274
URL: http://llvm.org/viewvc/llvm-project?rev=261274&view=rev
Log:
[ASTImporter] Implement missing VisitAccessSpecDecl function in ASTImporter
class.
Patch by Elisavet Sakellari!
Modified:
cfe/trunk/lib/AST/ASTImporter.cp
Author: akirtzidis
Date: Mon Feb 15 23:39:33 2016
New Revision: 260937
URL: http://llvm.org/viewvc/llvm-project?rev=260937&view=rev
Log:
[Frontend] Make sure WrapperFrontendAction updates CurrentInput after calling
BeginSourceFileAction.
I don't have a test case to add unfortunately.
Modified:
Author: akirtzidis
Date: Sun Feb 14 19:32:36 2016
New Revision: 260866
URL: http://llvm.org/viewvc/llvm-project?rev=260866&view=rev
Log:
[AST/index] Introduce an option 'SuppressTemplateArgsInCXXConstructors' in
printing policy.
Enable it for USRs and names when indexing.
Forward references can
Author: akirtzidis
Date: Sun Feb 14 16:38:38 2016
New Revision: 260861
URL: http://llvm.org/viewvc/llvm-project?rev=260861&view=rev
Log:
[test/Index] Set a specific target for the test.
Modified:
cfe/trunk/test/Index/Core/index-source.m
Modified: cfe/trunk/test/Index/Core/index-source.m
URL:
Author: akirtzidis
Date: Sun Feb 14 16:30:14 2016
New Revision: 260858
URL: http://llvm.org/viewvc/llvm-project?rev=260858&view=rev
Log:
[index] Factor libclang's functionality to determing the mangled name of
symbols into the clangIndex library.
Added:
cfe/trunk/include/clang/Index/CodegenN
Which configuration required them ?
I was under the impression CMake is passing the transitive libdeps.
> On Feb 14, 2016, at 1:19 AM, NAKAMURA Takumi via cfe-commits
> wrote:
>
> Author: chapuni
> Date: Sun Feb 14 03:19:04 2016
> New Revision: 260847
>
> URL: http://llvm.org/viewvc/llvm-proje
Thanks!
> On Feb 14, 2016, at 5:18 AM, Benjamin Kramer via cfe-commits
> wrote:
>
> Author: d0k
> Date: Sun Feb 14 07:18:06 2016
> New Revision: 260850
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260850&view=rev
> Log:
> Don't leak the ASTUnit when done with testing.
>
> Found by lsan.
>
nt modules.
>
> I think you should do;
> - Export C++ API in libclang. (But I don't expect it would work for win32)
> - Link libclang as static. Then c-index-test became the test that didn't
> test "libclang".
>
> On Sun, Feb 14, 2016 at 3:43
Author: akirtzidis
Date: Sun Feb 14 01:08:31 2016
New Revision: 260844
URL: http://llvm.org/viewvc/llvm-project?rev=260844&view=rev
Log:
[c-index-test] Fix a gcc build error.
Modified:
cfe/trunk/tools/c-index-test/core_main.cpp
Modified: cfe/trunk/tools/c-index-test/core_main.cpp
URL:
http:
Author: akirtzidis
Date: Sun Feb 14 00:53:20 2016
New Revision: 260843
URL: http://llvm.org/viewvc/llvm-project?rev=260843&view=rev
Log:
[index] Fix gcc builds.
Modified:
cfe/trunk/include/clang/Index/IndexingAction.h
cfe/trunk/tools/c-index-test/core_main.cpp
Modified: cfe/trunk/include
Author: akirtzidis
Date: Sun Feb 14 00:39:03 2016
New Revision: 260841
URL: http://llvm.org/viewvc/llvm-project?rev=260841&view=rev
Log:
[index] Allow calling createIndexingAction() without passing another action to
wrap over.
Modified:
cfe/trunk/include/clang/Index/IndexingAction.h
cfe/
Author: akirtzidis
Date: Sun Feb 14 00:39:11 2016
New Revision: 260842
URL: http://llvm.org/viewvc/llvm-project?rev=260842&view=rev
Log:
[index] Enhance c-index-test tool and have it link and test the clangIndex
library directly.
Added:
cfe/trunk/test/Index/Core/
cfe/trunk/test/Index/Cor
Author: akirtzidis
Date: Sat Feb 13 15:46:50 2016
New Revision: 260833
URL: http://llvm.org/viewvc/llvm-project?rev=260833&view=rev
Log:
[AST] Add a print() method in DeclarationName that accepts a PrintingPolicy.
Modified:
cfe/trunk/include/clang/AST/DeclarationName.h
cfe/trunk/lib/AST/D
v7-a15/stage1/tools/clang/clang.order:
>> file not recognized: File truncated
>>
>> I thought it was some build SNAFU, do you have some hint on what I need to
>> do to fix this ?
>>
>>> On Feb 13, 2016, at 7:48 AM, Renato Golin wrote:
>>>
>&
8 AM, Renato Golin wrote:
>>
>> On 12 February 2016 at 23:11, Argyrios Kyrtzidis via cfe-commits
>> wrote:
>>> Author: akirtzidis
>>> Date: Fri Feb 12 17:10:59 2016
>>> New Revision: 260760
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?
Feb 13, 2016, at 7:48 AM, Renato Golin wrote:
>
> On 12 February 2016 at 23:11, Argyrios Kyrtzidis via cfe-commits
> wrote:
>> Author: akirtzidis
>> Date: Fri Feb 12 17:10:59 2016
>> New Revision: 260760
>>
>> URL: http://llvm.org/viewvc/llvm-projec
Author: akirtzidis
Date: Fri Feb 12 23:17:15 2016
New Revision: 260807
URL: http://llvm.org/viewvc/llvm-project?rev=260807&view=rev
Log:
[index] Change some default parameters to fix an MSVC ICE.
Many thanks to Yunzhong Gao for tracking this down!
Modified:
cfe/trunk/lib/Index/IndexingContex
Author: akirtzidis
Date: Fri Feb 12 19:24:19 2016
New Revision: 260785
URL: http://llvm.org/viewvc/llvm-project?rev=260785&view=rev
Log:
[RecursiveASTVisitor] Introduce dataTraverseStmtPre()/dataTraverseStmtPost() to
allow clients to do before/after actions during data recursive visitation.
This
Author: akirtzidis
Date: Fri Feb 12 17:30:07 2016
New Revision: 260762
URL: http://llvm.org/viewvc/llvm-project?rev=260762&view=rev
Log:
[index] Add llvm/Support/DataTypes.h header to fix build failures in the bots.
Modified:
cfe/trunk/include/clang/Index/IndexSymbol.h
Modified: cfe/trunk/in
Author: akirtzidis
Date: Tue Feb 9 13:07:16 2016
New Revision: 260252
URL: http://llvm.org/viewvc/llvm-project?rev=260252&view=rev
Log:
[Frontend] Handle ASTConsumer::shouldSkipFunctionBody via the MultiplexConsumer.
Modified:
cfe/trunk/include/clang/Frontend/MultiplexConsumer.h
cfe/trun
Author: akirtzidis
Date: Tue Feb 9 13:07:24 2016
New Revision: 260255
URL: http://llvm.org/viewvc/llvm-project?rev=260255&view=rev
Log:
[libclang] indexing: make sure to not visit init-list expressions twice.
Modified:
cfe/trunk/test/Index/index-refs.cpp
cfe/trunk/tools/libclang/IndexBod
Author: akirtzidis
Date: Tue Feb 9 13:07:19 2016
New Revision: 260253
URL: http://llvm.org/viewvc/llvm-project?rev=260253&view=rev
Log:
[libclang] indexing: for a synthesized property reference have the parent be
the ObjC implementation decl.
Modified:
cfe/trunk/tools/libclang/IndexingConte
Author: akirtzidis
Date: Tue Feb 9 13:07:07 2016
New Revision: 260250
URL: http://llvm.org/viewvc/llvm-project?rev=260250&view=rev
Log:
[libclang] indexing: Have the semantic container of synthesized ObjC
getter/setter methods be the implementation decl.
Matches the behavior of other ObjC metho
Author: akirtzidis
Date: Tue Feb 9 13:07:13 2016
New Revision: 260251
URL: http://llvm.org/viewvc/llvm-project?rev=260251&view=rev
Log:
[ASTUnit] Change the parameter of ASTUnit::LoadFromCompilerInvocationAction to
accept a more general FrontendAction.
Modified:
cfe/trunk/include/clang/Fron
Author: akirtzidis
Date: Tue Feb 9 13:07:21 2016
New Revision: 260254
URL: http://llvm.org/viewvc/llvm-project?rev=260254&view=rev
Log:
[libclang] indexing: handle 'TopLevelDeclInObjCContainers' at the point where
they are reported.
It isn't much benefit and doesn't worth the complexity to try
;
> http://reviews.llvm.org/D4313 <http://reviews.llvm.org/D4313>
> http://reviews.llvm.org/D4312 <http://reviews.llvm.org/D4312>
>
> On Sun, Feb 7, 2016 at 11:28 AM, Argyrios Kyrtzidis via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: akirtz
Author: akirtzidis
Date: Sun Feb 7 13:28:36 2016
New Revision: 260048
URL: http://llvm.org/viewvc/llvm-project?rev=260048&view=rev
Log:
[Frontend] Make the memory management of FrontendAction pointers explicit by
using unique_ptr.
Modified:
cfe/trunk/include/clang/ARCMigrate/ARCMTActions.h
Author: akirtzidis
Date: Sun Feb 7 12:21:28 2016
New Revision: 260047
URL: http://llvm.org/viewvc/llvm-project?rev=260047&view=rev
Log:
[libclang] Add missing CINDEX_LINKAGE from a function.
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/include/clang-c/Index.h
URL:
http:/
Author: akirtzidis
Date: Fri Jan 29 19:51:20 2016
New Revision: 259287
URL: http://llvm.org/viewvc/llvm-project?rev=259287&view=rev
Log:
[SemaCXX] Fix crash-on-invalid while trying to deduce return type of a lambda.
rdar://22032373
Modified:
cfe/trunk/lib/Sema/SemaStmt.cpp
cfe/trunk/test
> On Jan 16, 2016, at 1:15 AM, Ismail Donmez wrote:
>
> On Sat, Jan 16, 2016 at 5:01 AM, Argyrios Kyrtzidis via cfe-commits
> wrote:
>> Author: akirtzidis
>> Date: Fri Jan 15 21:01:20 2016
>> New Revision: 257982
>>
>> URL: http://llvm.org/view
Author: akirtzidis
Date: Fri Jan 15 21:01:20 2016
New Revision: 257982
URL: http://llvm.org/viewvc/llvm-project?rev=257982&view=rev
Log:
[libclang] Add missing CINDEX_LINKAGE from some new APIs in Index.h.
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/include/clang-c/Index.
Author: akirtzidis
Date: Fri Jan 15 18:20:02 2016
New Revision: 257968
URL: http://llvm.org/viewvc/llvm-project?rev=257968&view=rev
Log:
[libclang] Introduce APIs for evaluating a cursor and checking if a macro is
builtin/function.
rdar://24091595
Added:
cfe/trunk/test/Index/evaluate-cursor
Tests need to be updated, for example:
clang/test/Index/remap-load.c:7:11: error: expected string not found in input
// CHECK: remap-load.c:2:10: BinaryOperator= Extent=[2:10 - 2:23]
^
:334:1: note: scanning from here
// CHECK: remap-load.c:2:10: BinaryOperator=+ Extent=[2:10 - 2:23]
^
:
akyrtzi added a comment.
Tests need to be updated, for example:
clang/test/Index/remap-load.c:7:11: error: expected string not found in input
// CHECK: remap-load.c:2:10: BinaryOperator= Extent=[2:10 - 2:23]
^
:334:1: note: scanning from here
// CHECK: remap-load.c:2:10: BinaryOperator=+ Exte
akyrtzi added a comment.
LGTM.
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LGTM.
> On Dec 12, 2015, at 5:25 PM, Bruno Cardoso Lopes
> wrote:
>
> bruno updated this revision to Diff 42649.
> bruno added a comment.
>
> Thanks Duncan and Argyrios, updated a patch with the suggestions!
>
>
> http://reviews.llvm.org/D15173
>
> Files:
> lib/Lex/PPCaching.cpp
> test/Pa
akyrtzi added a comment.
Also you need to add the functions in libclang.exports.
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Also you need to add the functions in libclang.exports.
> On Dec 9, 2015, at 12:47 PM, Argyrios Kyrtzidis wrote:
>
> akyrtzi added a comment.
>
> The patch causes tests to fail, please look into it.
>
>
> http://reviews.llvm.org/D10833
>
>
>
___
The patch causes tests to fail, please look into it.
> On Dec 8, 2015, at 10:20 PM, guibufolo+l...@gmail.com wrote:
>
> RedX2501 updated this revision to Diff 42267.
> RedX2501 added a comment.
>
> Added explicit integer assignment to enum to emphasize api contract behaviour.
>
>
> http://revi
akyrtzi added a comment.
The patch causes tests to fail, please look into it.
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
The patch does not apply cleanly, could you provide a more up-to-date one ?
> On Dec 6, 2015, at 11:46 PM, guibufolo+l...@gmail.com wrote:
>
> RedX2501 added a comment.
>
> Ping
>
>
> http://reviews.llvm.org/D10834
>
>
>
___
cfe-commits mailing l
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
The patch does not apply cleanly, could you provide a more up-to-date one ?
http://reviews.llvm.org/D10834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
For CX_BinaryOperatorKind please change the enumerators to have an explicit
integer assignment; this is to emphasize that they are API contract and should
not change with subsequent changes (someone may inadvertently add a new
enumerator in the middle which will implicitly change all the subsequ
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
For CX_BinaryOperatorKind please change the enumerators to have an explicit
integer assignment; this is to emphasize that they are API contract and should
not change with subsequent changes (someone may inadvertently add a new
enumer
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
Hi Bruno,
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Bruno,
> On Dec 2, 2015, at 7:29 PM, Bruno Cardoso Lopes
> wrote:
>
> bruno created this revision.
> bruno added reviewers: doug.gregor, akyrtzi.
> bruno added subscribers: cfe-commits, dexonsmith.
>
> Consider the following ObjC++ snippet:
>
> @protocol PA;
> @protocol PB;
>
> @class
> On Dec 7, 2015, at 12:16 AM, John McCall wrote:
>
> rjmccall added a reviewer: akyrtzi.
>
>
> Comment at: lib/AST/ASTContext.cpp:5424
> @@ -5410,1 +5423,3 @@
> +// FIXME: need to figure out what this is for __float128
> +case BuiltinType::Float128: return 'K';
>
201 - 300 of 331 matches
Mail list logo
