[PATCH] D137512: [clang] Add Swift support for MIPS

aschwaighofer added a comment. This looks good to me. Can you rebase your patch so that it applies on top of github.com:apple/llvm-project.git main? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137512/new/ https://reviews.llvm.org/D137512

[PATCH] D109451: Summary: Introduce a new frontend flag `-fswift-async-fp={auto|always|never}` that controls how code generation sets the Swift extended async frame info bit. There are three possibili

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf670c5aeeef0: Add a new frontend flag `-fswift-async-fp={auto|always|never}` (authored by aschwaighofer). Changed prior to commit:

[PATCH] D109451: Summary: Introduce a new frontend flag `-fswift-async-fp={auto|always|never}` that controls how code generation sets the Swift extended async frame info bit. There are three possibili

aschwaighofer created this revision. aschwaighofer added reviewers: doug.gregor, t.p.northover. Herald added subscribers: ormris, dexonsmith, dang. aschwaighofer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `auto`: the default, which

[PATCH] D107841: CodeGen: No need to check for isExternC if HasStrictReturn is already false

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9eb99d2e73b5: CodeGen: No need to check for isExternC if HasStrictReturn is already false (authored by aschwaighofer). Repository: rG LLVM Github

[PATCH] D107841: CodeGen: No need to check for isExternC if HasStrictReturn is already false

aschwaighofer created this revision. aschwaighofer added a reviewer: rjmccall. aschwaighofer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NFC intended. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107841 Files:

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

aschwaighofer accepted this revision. aschwaighofer added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96802/new/ https://reviews.llvm.org/D96802

[PATCH] D95814: [NFC] Simplify test to use multiple FileCheck prefixes.

aschwaighofer accepted this revision. aschwaighofer added a comment. This revision is now accepted and ready to land. LGTM Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95814/new/ https://reviews.llvm.org/D95814

[PATCH] D86218: Teach the swift calling convention about _Atomic types

This revision was automatically updated to reflect the committed changes. Closed by commit rG41634497d4fd: Teach the swift calling convention about _Atomic types (authored by aschwaighofer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/

[PATCH] D86218: Teach the swift calling convention about _Atomic types

aschwaighofer updated this revision to Diff 287055. aschwaighofer added a comment. Respect atomic padding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/ https://reviews.llvm.org/D86218 Files: clang/lib/CodeGen/SwiftCallingConv.cpp

[PATCH] D86218: Teach the swift calling convention about _Atomic types

aschwaighofer updated this revision to Diff 286575. aschwaighofer added a comment. Try to sooth clang-tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/ https://reviews.llvm.org/D86218 Files: clang/lib/CodeGen/SwiftCallingConv.cpp

[PATCH] D86218: Teach the swift calling convention about _Atomic types

aschwaighofer created this revision. aschwaighofer added a reviewer: rjmccall. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. aschwaighofer requested review of this revision. rdar://67351073 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86218

[PATCH] D81857: Fix ConstantAggregateBuilderBase::getRelativeOffset

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a8120ca9fb9: Fix ConstantAggregateBuilderBase::getRelativeOffset (authored by aschwaighofer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81857/new/

[PATCH] D81857: Fix ConstantAggregateBuilderBase::getRelativeOffset

aschwaighofer created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aschwaighofer added a reviewer: rjmccall. If a record has a mix of relative pointers and other fields they wouldn't necessarily be the same. Fallout from D77592

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

This revision was automatically updated to reflect the committed changes. Closed by commit rG153dadf3a3ca: [clang] CodeGen: Make getOrEmitProtocol public for Swift (authored by aschwaighofer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77077/new/

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer marked an inline comment as done. aschwaighofer added inline comments. Comment at: clang/lib/CodeGen/CGObjCRuntime.h:217 + /// ProtocolPtrTy. + virtual llvm::Constant *GetOrEmitProtocol(const ObjCProtocolDecl *PD) = 0; + rjmccall wrote: >

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer updated this revision to Diff 254171. aschwaighofer added a comment. - Implement for the GNU runtimes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77077/new/ https://reviews.llvm.org/D77077 Files:

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer marked an inline comment as done. aschwaighofer added inline comments. Comment at: clang/lib/CodeGen/CGObjCRuntime.h:217 + /// ProtocolPtrTy. + virtual llvm::Constant *GetOrEmitProtocol(const ObjCProtocolDecl *PD) = 0; + aschwaighofer wrote: >

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer marked an inline comment as done. aschwaighofer added inline comments. Comment at: clang/lib/CodeGen/CGObjCRuntime.h:217 + /// ProtocolPtrTy. + virtual llvm::Constant *GetOrEmitProtocol(const ObjCProtocolDecl *PD) = 0; + rjmccall wrote: > Can

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer marked an inline comment as done. aschwaighofer added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:148 + llvm::function_ref + createProtocolReference); } // end namespace CodeGen

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer updated this revision to Diff 253938. aschwaighofer added a comment. - Remove callback. Swift can inspect the generated IR and update it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77077/new/ https://reviews.llvm.org/D77077

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer updated this revision to Diff 253712. aschwaighofer added a comment. - Change API name to emitObjCProtocolObject. - Make stuff compile on current ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77077/new/

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer marked an inline comment as done. aschwaighofer added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:148 + llvm::function_ref + createProtocolReference); } // end namespace CodeGen

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer added a comment. > Can you explain the need for the callback? Are you expecting to use this for > Swift-declared protocols by synthesizing an ObjC protocol declaration for > them? I can see why you'd need a callback in that case. The objective C protocol references other

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Swift would like to use clang's abis to emit protocol declarations. It needs to a hook to register when inherited protocols are emitted. This commits adds the public API:

[PATCH] D46550: Support Swift calling convention for PPC64 targets

aschwaighofer accepted this revision. aschwaighofer added a comment. This revision is now accepted and ready to land. Looks good. Repository: rC Clang https://reviews.llvm.org/D46550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34454: SwiftCC: Perform physical layout when computing coercion types

aschwaighofer updated this revision to Diff 103459. aschwaighofer added a comment. Same patch bug with added diff context. https://reviews.llvm.org/D34454 Files: lib/CodeGen/SwiftCallingConv.cpp test/CodeGen/64bit-swiftcall.c Index: test/CodeGen/64bit-swiftcall.c

[PATCH] D34454: SwiftCC: Perform physical layout when computing coercion types

aschwaighofer updated this revision to Diff 103458. aschwaighofer retitled this revision from "SwiftAggregateLowering: Use type alloc size to determine the size of types" to "SwiftCC: Perform physical layout when computing coercion types". aschwaighofer edited the summary of this revision.

[PATCH] D34454: SwiftAggregateLowering: Use type alloc size to determine the size of types

aschwaighofer created this revision. The layout must be compatible with the input layout, offsets are defined in terms of offsets within a packed struct which are computed in terms of the alloc size of a type. Using the store size we would insert padding for the following type for example: