arpith-jacob marked an inline comment as done.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:69
@@ +68,3 @@
+ /// evaluates to false.
+ virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective
&D,
+StringRef ParentNa
arpith-jacob marked 9 inline comments as done.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:69
@@ +68,3 @@
+ /// evaluates to false.
+ virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective
&D,
+StringRef ParentNa
arpith-jacob updated this revision to Diff 50143.
arpith-jacob marked 2 inline comments as done.
arpith-jacob added a comment.
Stylistic changes to address feedback.
http://reviews.llvm.org/D17877
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMPRun
arpith-jacob marked 15 inline comments as done.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:348
@@ +347,2 @@
+ initializeEnvironment();
+}
This function will also handle global variables from the 'declare target'
construct in the future.
void CGOpenMPRunti
arpith-jacob updated this revision to Diff 49851.
arpith-jacob added a comment.
Addressed feedback; see inline comments for details.
http://reviews.llvm.org/D17877
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpe
arpith-jacob added a comment.
Thanks for the quick review! The test cases are the same as the CUDA version
so it should be fine.
http://reviews.llvm.org/D17890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
arpith-jacob created this revision.
arpith-jacob added a reviewer: jlebar.
arpith-jacob added subscribers: carlo.bertolli, sfantao, caomhin, cfe-commits.
Support for CUDA printf is exploited to support printf for an NVPTX OpenMP
device.
To reflect the support of both programming models, the file
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, hfinkel.
arpith-jacob added subscribers: cfe-commits, carlo.bertolli, sfantao, kkwli0,
caomhin, fraggamuffin.
Herald added a subscriber: jholewinski.
This patch adds base support for codegen of the target directive on the
arpith-jacob marked an inline comment as done.
arpith-jacob added a comment.
Alexey, I've made the change in the comments. Thanks very much for your time!
http://reviews.llvm.org/D16759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
arpith-jacob created this revision.
arpith-jacob added reviewers: hfinkel, kkwli0, sfantao, carlo.bertolli, ABataev.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
This patch enhances Sema to check for the following restriction:
OpenMP 4.5 [2.17 Nesting of Regions]
If a targe
arpith-jacob closed this revision.
arpith-jacob added a comment.
Committed revision 258832.
I had to modify test cases 'target_parallel_reduction_messages.cpp' and
'target_parallel_map_messages.cpp' to use the updated error messages from
patches recently committed to trunk.
http://reviews.llv
arpith-jacob marked 5 inline comments as done.
arpith-jacob added a comment.
Patch fixed.
http://reviews.llvm.org/D16527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arpith-jacob updated this revision to Diff 45856.
arpith-jacob added a comment.
Addressed fixes by Alexey Bataev. Thanks.
http://reviews.llvm.org/D16527
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/OpenMPKinds.def
include/clang/Bas
arpith-jacob created this revision.
arpith-jacob added reviewers: hfinkel, kkwli0, sfantao, carlo.bertolli, ABataev.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
This patch adds parsing + sema for the defaultmap clause associated with the
target directive (among others).
h
arpith-jacob added a comment.
Committed revision 258425.
Repository:
rL LLVM
http://reviews.llvm.org/D16341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arpith-jacob updated this revision to Diff 45532.
arpith-jacob added a comment.
Added template instantiation test case for all feasible tests.
http://reviews.llvm.org/D16401
Files:
include/clang/Basic/OpenMPKinds.def
test/OpenMP/target_exit_data_ast_print.cpp
test/OpenMP/target_exit_data_
arpith-jacob updated this revision to Diff 45525.
arpith-jacob added a comment.
Added template instantiation test case for all feasible tests.
http://reviews.llvm.org/D16400
Files:
include/clang/Basic/OpenMPKinds.def
test/OpenMP/target_enter_data_ast_print.cpp
test/OpenMP/target_enter_dat
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
Accept depend clause on target exit data directive in sema and add test cases.
http://reviews.llvm.org/D16401
F
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
Accept depend clause on target enter data directive in sema and add test cases.
http://reviews.llvm.org/D16400
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
Accept depend clause on target directive in sema and add test cases.
http://reviews.llvm.org/D16375
Files:
in
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
Accept nowait clause on target exit data directive in sema and add test cases.
http://reviews.llvm.org/D16362
F
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
Accept nowait clause on target enter data directive in sema and add test cases.
http://reviews.llvm.org/D16361
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, caomhin, fraggamuffin.
Allow nowait clause on target directive in sema and add test cases.
http://reviews.llvm.org/D16358
Files:
inc
arpith-jacob created this revision.
arpith-jacob added reviewers: kkwli0, hfinkel, ABataev, sfantao, carlo.bertolli.
arpith-jacob added subscribers: fraggamuffin, caomhin, cfe-commits.
OpenMP [2.10.1, Restrictions, p. 97]
At least one map clause must appear on the directive.
http://reviews.llvm.o
arpith-jacob marked 2 inline comments as done.
arpith-jacob added a comment.
http://reviews.llvm.org/D16280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arpith-jacob updated this revision to Diff 45227.
arpith-jacob added a comment.
Addressed comment:
Do not cast bool to unsigned, use (IsMapTypeImplicit ? 1 : 0) instead.
http://reviews.llvm.org/D16280
Files:
include/clang/AST/OpenMPClause.h
include/clang/Sema/Sema.h
lib/AST/OpenMPClause.c
arpith-jacob updated this revision to Diff 45226.
arpith-jacob added a comment.
Addressed comments from similar patch for 'target enter data' directive.
Added comment about 'target exit data'.
Removed parens around 0.
http://reviews.llvm.org/D16279
Files:
include/clang-c/Index.h
include/cl
arpith-jacob marked 4 inline comments as done.
arpith-jacob added a comment.
http://reviews.llvm.org/D15989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arpith-jacob updated this revision to Diff 45225.
arpith-jacob added a comment.
HasMapClause() is now static.
Removed comment about 'target exit data'.
Modified: just if(*I != nullptr && (*I)->getClauseKind() == OMPC_map)
Done: Remove parens around 0
http://reviews.llvm.org/D15989
Files:
incl
arpith-jacob created this revision.
arpith-jacob added reviewers: kkwli0, ABataev, sfantao, hfinkel, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, caomhin, fraggamuffin.
Support for the following OpenMP 4.5 restriction on 'target enter data' and
'target exit data':
- A map-type mus
arpith-jacob created this revision.
arpith-jacob added reviewers: kkwli0, sfantao, hfinkel, carlo.bertolli, ABataev.
arpith-jacob added subscribers: cfe-commits, caomhin, fraggamuffin.
Created a distinct patch for the 'target exit data' directive.
http://reviews.llvm.org/D16279
Files:
include/
arpith-jacob updated this revision to Diff 45075.
arpith-jacob added a comment.
Created a distinct patch for 'target enter data'.
Added nesting test cases where the unstructured statement is nested in various
regions.
Removed extraneous comments.
http://reviews.llvm.org/D15989
Files:
include
arpith-jacob updated this revision to Diff 45074.
arpith-jacob added a comment.
Created a distinct patch for 'target enter data'.
Added nesting test cases where the unstructured statement is nested in various
regions.
http://reviews.llvm.org/D15989
Files:
include/clang-c/Index.h
include/cl
arpith-jacob added inline comments.
Comment at: lib/Parse/ParseOpenMP.cpp:42
@@ -37,1 +41,3 @@
+ {OMPD_unknown /*target exit*/, OMPD_unknown /*data*/,
+ OMPD_target_exit_data},
{OMPD_for, OMPD_simd, OMPD_for_simd},
I have written this code based
arpith-jacob created this revision.
arpith-jacob added reviewers: kkwli0, sfantao, fraggamuffin, hfinkel, ABataev,
carlo.bertolli.
arpith-jacob added a subscriber: cfe-commits.
This patch adds parsing and sema support for "#pragma omp target enter data"
and "#pragma omp target exit data" directi
35 matches
Mail list logo
