awpandey updated this revision to Diff 247546.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73462/new/
https://reviews.llvm.org/D73462
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGenCXX/debug-info-template-parameter.cpp
llvm/include/llvm/IR/DIBuilder.h
awpandey updated this revision to Diff 245875.
awpandey marked 7 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73462/new/
https://reviews.llvm.org/D73462
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGenCXX/debug-info-template-parameter.cpp
awpandey added a comment.
Hi @aprantl, I have included all of your suggestions. Can I merge this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73462/new/
https://reviews.llvm.org/D73462
___
cfe-commits mailing list
awpandey updated this revision to Diff 244571.
awpandey marked 2 inline comments as done.
awpandey added a comment.
Hi @aprantl, I have added a test that two DITemplateTypeParameter only differ
in the isDefault parameter are not equal.
CHANGES SINCE LAST ACTION
awpandey added a comment.
Hi @aprantl , can you please inform me what extra changes should I make in this
patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73462/new/
https://reviews.llvm.org/D73462
___
cfe-commits mailing list
awpandey updated this revision to Diff 243509.
awpandey added a comment.
Herald added a subscriber: ormris.
@probinson I have reimplemented the feature by using DIFlags.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73261/new/
https://reviews.llvm.org/D73261
Files:
awpandey added a comment.
Thanks @dblaikie for all of your suggestions. I will commit this in 3 patches
after getting the green signal from @aprantl.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73462/new/
https://reviews.llvm.org/D73462
awpandey updated this revision to Diff 242514.
awpandey marked 3 inline comments as done.
awpandey added a comment.
@dblaikie, I have updated the test cases.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73462/new/
https://reviews.llvm.org/D73462
Files:
awpandey updated this revision to Diff 242250.
awpandey added a comment.
Hi @dblaikie, I removed the condition and put false as the third argument of
PrintBool. I have also removed the updated bitcode file.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73462/new/
awpandey updated this revision to Diff 241984.
awpandey marked 2 inline comments as done.
awpandey added a comment.
Thanks, @aprantl, and @dblaikie. I have added two new test cases as per your
suggestions. I have to update // dityperefs-3.8.ll// and
//dityperefs-3.8.ll.bc// because they are no
awpandey marked an inline comment as not done.
awpandey added a comment.
@aprantl Thanks for your valuable feedback.
I have a doubt. You need a .ll file its corresponding llvm bytecode generated
by current llvm (without my patch). Doest this ll file includes any checks? In
the round trip test
awpandey marked an inline comment as done and an inline comment as not done.
awpandey added inline comments.
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1808-1809
Record.push_back(VE.getMetadataOrNullID(N->getType()));
+ if (M.getDwarfVersion() >= 5)
+
awpandey updated this revision to Diff 241391.
awpandey marked 7 inline comments as done.
awpandey added a comment.
Hi @dblaikie, I have incorporated your suggestions (renaming variables, test
case modification).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73462/new/
awpandey updated this revision to Diff 241141.
awpandey added a comment.
Thanks @dblaikie for figuring out the missing feature. I have added support for
the non-type template parameter too. Please let me know if further
modifications are required. I will happily address them.
CHANGES SINCE
awpandey created this revision.
awpandey added reviewers: probinson, aprantl, dblaikie.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
This patch provides support for //DW_AT_default_value// based on template
parameter is default parameter or
awpandey updated this revision to Diff 240122.
awpandey marked 29 inline comments as done.
awpandey added a comment.
Hi @probinson, I have changed the patch according to your comments.
Is it necessary to use DIFlags? I am willing to do that but generally, it is
not welcomed because we have a
awpandey created this revision.
awpandey added reviewers: dblaikie, aprantl, probinson, jini.susan.george.
awpandey added projects: debug-info, LLVM, clang.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
This patch adds //dw_at_const_expr// flag for the constant variable or
awpandey updated this revision to Diff 237264.
awpandey added a comment.
@dblaikie I have added an LLVM test case and I will commit it like a different
patch.
I have also updated the clang test case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70524/new/
awpandey updated this revision to Diff 235998.
awpandey added a comment.
Herald added a subscriber: hiraditya.
@dblaikie Thanks a lot for the suggestions. I have made the changes such that
this will become consistent with your suggestions.
CHANGES SINCE LAST ACTION
awpandey updated this revision to Diff 233289.
awpandey added a comment.
@dblaikie . I have removed the redundant test case. What else should I do in
this patch?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70524/new/
https://reviews.llvm.org/D70524
Files:
awpandey marked an inline comment as done.
awpandey added a comment.
> It looks to me like there are a few tests for unspecified_type already:
>
> $ grep -r unspecified_type llvm/test
> llvm/test/Assembler/debug-info.ll:; CHECK-NEXT: !7 = !DIBasicType(tag:
> DW_TAG_unspecified_type, name:
awpandey updated this revision to Diff 232281.
awpandey marked 5 inline comments as done.
awpandey added a comment.
Hi @aprantl, I used variable as shown by you for showing links between the node.
@dblaikie I have shortened the test case based on your suggestions. There were
no test case for
awpandey updated this revision to Diff 231208.
awpandey marked 5 inline comments as done.
awpandey added a comment.
Hi @aprantl and @dblaikie. Currently, there is no test case for the
unspecified type, so I have added that in the regression test suite. Also, I
have incorporated all of your
awpandey updated this revision to Diff 231004.
awpandey added a comment.
Thanks @dblaikie. I have updated go and C bindings. I have also added the
release note for why these APIs are changing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70111/new/
https://reviews.llvm.org/D70111
awpandey marked 2 inline comments as done.
awpandey added a comment.
Thanks @aprantl for your suggestions. I have revised by patch based on that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70524/new/
https://reviews.llvm.org/D70524
___
awpandey updated this revision to Diff 230601.
awpandey marked 3 inline comments as done.
awpandey added a comment.
This revision includes
1. Added check for return type it is attached to the exact node we're expecting
it to.
2. Removed unnecessary strings and checks.
CHANGES SINCE LAST
awpandey added a comment.
I am considering this
- Will commit this without C bindings
- will give separate patch for C bindings and release notes (if necessary).
- will give another patch for Go bindings and release notes (if necessary).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
awpandey created this revision.
awpandey added reviewers: jini.susan.george, SouraVX, alok, aprantl, dblaikie.
awpandey added projects: clang, LLVM, debug-info.
Herald added subscribers: llvm-commits, cfe-commits, ormris.
This patch will provide support for auto return type for the C++ member
awpandey added a comment.
Hi @aprantl. Can we drop C binding for this feature ? What will be the impact
of this.
As noted by @sammccall this does not conform / break LLVM-C ABI?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70111/new/
awpandey added a comment.
Hi @aprantl. I had made the changes and my team member will commit this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70111/new/
https://reviews.llvm.org/D70111
___
cfe-commits mailing list
awpandey updated this revision to Diff 229544.
awpandey added a comment.
Thanks for your suggestion @aprantl. I have revised the data type based on your
suggestion. Please inform me if any other changes are required.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70111/new/
awpandey added inline comments.
Comment at: clang/test/CodeGenCXX/debug-info-template-align.cpp:8
+
+// CHECK: DIDerivedType(tag: DW_TAG_typedef, {{.*}}, align:
+
aprantl wrote:
> Do we need to hardcode the target here? Could we check for the specific align
>
awpandey updated this revision to Diff 229013.
awpandey marked 3 inline comments as done.
awpandey added a comment.
Herald added a reviewer: deadalnix.
@aprantl Thanks for the suggestion. Based on your suggestion I have done the
following changes
1. I have added alignment value as a check in
awpandey marked 8 inline comments as done.
awpandey added a comment.
Thank you @djtodoro for reviewing this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70111/new/
https://reviews.llvm.org/D70111
___
cfe-commits mailing list
awpandey updated this revision to Diff 228852.
awpandey added a comment.
Revised and address comments of @djtodoro
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70111/new/
https://reviews.llvm.org/D70111
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
awpandey created this revision.
awpandey added reviewers: aprantl, dblaikie, jini.susan.george, SouraVX, alok.
awpandey added a project: debug-info.
Herald added subscribers: llvm-commits, cfe-commits, ormris, hiraditya.
Herald added projects: clang, LLVM.
This patch, adds support for
36 matches
Mail list logo
