[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

beccadax accepted this revision. beccadax added a comment. This revision is now accepted and ready to land. The diagnostics are now much better—thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://reviews.llvm.org/D114003

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

beccadax added a comment. > My reading of > https://clang.llvm.org/docs/LanguageExtensions.html#specifying-an-attribute-for-multiple-declarations-pragma-clang-attribute > suggests that any() /could/ apply to everything. (`The any rule applies > attributes to all declarations that are matched

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

beccadax requested changes to this revision. beccadax added a comment. This revision now requires changes to proceed. err_lexing_string’s message is “failure when lexing a string”

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

beccadax added a comment. In D112773#3096185 , @aaron.ballman wrote: > `swift_attr` has no subjects, so this will attempt to spray the attribute > onto literally *everything*. That makes this incredibly risky to use with the > pragma approach (not to

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

beccadax created this revision. beccadax added a reviewer: arphaman. beccadax added a project: clang. Herald added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. beccadax requested review of this revision. Herald added a subscriber: cfe-commits. This change does what it says on