[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

bkramer added a comment. Reverted this in 88b7e06dcf9723d0869b0c6bee030b4140e4366d as it makes clang crash. Reduced test case in the commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144911: adding bf16 support to NVPTX

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I don't have much knowledge about the PTX ABI, but everything here makes perfect sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133574: [C2x] reject type definitions in offsetof

bkramer added a comment. GitHub finds around 1.9k instances of this pattern to compute `alignof`. There's a lot of duplicates and `#ifdefs` so the real number is going to be smaller, but it seems to be quite common. The annoying part is that there is no `_Alignof` in C99 so for many of those

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added a comment. In D140332#4005988 , @MaskRay wrote: > Can you push `using OptionalFileEntryRef = > CustomizableOptional;` and the renaming as a separate commit to > make this patch smaller? > There is

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:513 if (Opts.MaxBitIntWidth) -MaxBitIntWidth = Opts.MaxBitIntWidth; +MaxBitIntWidth = (unsigned)Opts.MaxBitIntWidth; barannikov88

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks. Let's land this now to unbreak things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

bkramer added a comment. Mind moving the test case from `llvm/test/CodeGen/AArch64` to `llvm/test/CodeGen/Hexagon`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525

[PATCH] D138792: [AArch64] Improve TargetParser API

bkramer added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.h:115-118 + ArchInfo(const ArchInfo &) = delete; + ArchInfo(const ArchInfo &&) = delete; + ArchInfo =(const ArchInfo ) = delete; + ArchInfo &=(const ArchInfo &) = delete;

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88eb3c62f25d: Add FP8 E4M3 support to APFloat. (authored by reedwm, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137760/new/ https://reviews.llvm.org/D137760

[PATCH] D132920: [clang] Silence a false positive GCC -Wunused-but-set-parameter warning with constexpr

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132920/new/ https://reviews.llvm.org/D132920

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

bkramer added a comment. In D130964#3694473 , @rjmccall wrote: > How are you actually implementing `__bf16` on these targets? There isn't > even hardware support for conversions. `bf16` -> `float` is really just a bit shift. The other direction gets

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571

[PATCH] D122173: [libc++][ranges] Implement ranges::transform

bkramer added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/ranges_transform.module.verify.cpp:1-15 +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM

[PATCH] D116037: [clang-include-fixer] Fix incorrect ranking because of dangling references

This revision was automatically updated to reflect the committed changes. Closed by commit rGcff192739bb6: [clang-include-fixer] Fix incorrect ranking because of dangling references (authored by danlark, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116037: [clang-include-fixer] Fix incorrect ranking because of dangling references

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116037/new/ https://reviews.llvm.org/D116037

[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109865/new/ https://reviews.llvm.org/D109865

[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107760/new/ https://reviews.llvm.org/D107760

[PATCH] D98816: PR49585: Emit the jump destination for a for loop 'continue' from within the scope of the condition variable.

bkramer added a comment. Invalid IR generation should be addressed by 19d2c65ddd757997785163709800f837857f686d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98816/new/

[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19d2c65ddd75: [CodeGen] Dont crash on for loops with cond variables and no increment (authored by bkramer). Repository: rG LLVM Github Monorepo

[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

bkramer added a comment. Landing this as it's a pretty bad crasher. Feel free to point out all my mistakes in post-commit review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98980/new/ https://reviews.llvm.org/D98980

[PATCH] D98980: [CodeGen] Don't crash on for loops with cond variables and no increment

bkramer created this revision. bkramer added reviewers: rupprecht, rjmccall, rsmith. bkramer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This looks like an oversight from a875721d8a2d

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. While it would be nice for `dereferenceable` to not imply nonnull, the implementation currently assumes it does and will speculate loads based on that. See

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

bkramer added a comment. In D17993#2409401 , @brooksmoses wrote: > So, I have bad news: This causes OpenJDK to segfault. The relevant code is > here: > https://github.com/openjdk/jdk/blob/master/src/hotspot/share/memory/arena.cpp#L311 > > void

[PATCH] D89708: Move clang/Tooling/Core/Lookup.h to clang/Tooling/Refactoring/Lookup.h

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89708/new/ https://reviews.llvm.org/D89708

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Nice, those relocations have annoyed me for years. I'm worried about whether the way you're accessing StaticDiagInfoDescriptionStringTable might be undefined behavior. I won't block this

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG4597e3bd475b: [libclang]: visit BindingDecl in DecompositionDecl (authored by milianw, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78214: [libclang]: visit C++17 if init statements

This revision was automatically updated to reflect the committed changes. Closed by commit rG08e181264318: [libclang]: visit C++17 if init statements (authored by milianw, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78214: [libclang]: visit C++17 if init statements

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78214/new/ https://reviews.llvm.org/D78214

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78213/new/ https://reviews.llvm.org/D78213

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b9c6c16c33d: Also look for devtoolset-9 gcc toolchain (authored by stephan.dollberg, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77420/new/ https://reviews.llvm.org/D77420

[PATCH] D76703: [ARM][CMSE] Fix clang/test/Driver/save-temps.c test.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76703/new/ https://reviews.llvm.org/D76703

[PATCH] D76272: Fix memtag test.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Right, we don't have names for values in release builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76272/new/

[PATCH] D74954: Add a basic tiling pass for parallel loops

bkramer updated this revision to Diff 246167. bkramer added a comment. Herald added a subscriber: wuzish. Herald added a reviewer: mclow.lists. - WTF phab? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74954/new/ https://reviews.llvm.org/D74954

[PATCH] D74954: Add a basic tiling pass for parallel loops

bkramer updated this revision to Diff 246166. bkramer marked 4 inline comments as done. bkramer added a comment. Herald added subscribers: libc-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, bader, kerbowa, csigg, usaxena95, jdoerfert, ormris, jsji, kadircet, rupprecht, jfb,

[PATCH] D74423: Use C++14-style return type deduction in clang.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74423/new/ https://reviews.llvm.org/D74423

[PATCH] D74414: Use std::foo_t rather than std::foo in clang.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74414/new/ https://reviews.llvm.org/D74414

[PATCH] D74412: Fix SFINAE in CFG.cpp.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74412/new/ https://reviews.llvm.org/D74412

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

bkramer accepted this revision. bkramer added a comment. Push and watch the bots Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74384/new/ https://reviews.llvm.org/D74384 ___ cfe-commits mailing list

[PATCH] D70902: Fix compatibility with python3 of clang-include-fixer.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa189ed25fbd: Fix compatibility with python3 of clang-include-fixer.py (authored by Yannick Brehon yanni...@google.com, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D70902: Fix compatibility with python3 of clang-include-fixer.py

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70902/new/ https://reviews.llvm.org/D70902

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer added a comment. In D70488#1753897 , @mcberg2017 wrote: > For us this would be an impediment as we have math models that want ieee > behavior while relaxing precision. Adding nnan or ninf would obstruct those > choices. Mind elaborating why

[PATCH] D70518: [clang-include-fixer] Suppress cmd prompt from Vim on Windows

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70518/new/ https://reviews.llvm.org/D70518

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer updated this revision to Diff 230245. bkramer added a comment. Fix condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70488/new/ https://reviews.llvm.org/D70488 Files: clang/test/CodeGen/builtins-systemz-zvector.c

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer created this revision. bkramer added a reviewer: spatel. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. Applies nnan, ninf and nsz. This allows more instructions to be folded away even with no fast math flags, e.g. (int)x * (b ? 1.0 : 0.0) -> b ? x :

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60201/new/ https://reviews.llvm.org/D60201 ___ cfe-commits mailing list

[PATCH] D59750: Rename directory housing clang-include-fixer to be eponymous

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg. Is the reference from libclang still around? Might need an update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59750/new/ https://reviews.llvm.org/D59750

[PATCH] D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types

bkramer created this revision. bkramer added reviewers: saugustine, ilya-biryukov. Herald added a subscriber: jlebar. Herald added a project: clang. We already handle pointers and references, member ptrs are just another special case. Fixes PR40732. Repository: rG LLVM Github Monorepo

[PATCH] D57442: [OpenGL] Fix test on PPC after r352540

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57442/new/ https://reviews.llvm.org/D57442 ___ cfe-commits

[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

bkramer accepted this revision. bkramer added inline comments. Comment at: lib/Lex/HeaderSearch.cpp:313 // check whether we'll have a suggestion for a module. - const FileEntry *File = getFileMgr().getFile(FileName, /*OpenFile=*/true); + const FileEntry *File =

[PATCH] D56665: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes).

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This makes sense to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56665/new/ https://reviews.llvm.org/D56665

[PATCH] D55415: Revert removal of tidy plugin support from libclang

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think that's a fair point for bringing it back for now. It's not supported though and we will get rid of it eventually. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. The performance difference on preprocessing huge files was tiny back then, doesn't surprise me that it disappeared. What did you test this on? Dropping it is fine with me. Repository:

[PATCH] D55415: Revert removal of tidy plugin support from libclang

bkramer added a comment. I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it

[PATCH] D52264: Deduplicate replacements from diagnostics.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D51921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + // For compatibility with old Status-based API. Prefer using Path directly. + StringRef getName() const { return Path; } +}; sammccall wrote: > sammccall wrote: > >

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + // For compatibility with old Status-based API. Prefer using Path directly. + StringRef getName() const { return Path; } +}; sammccall wrote: > Backwards-compatibility

[PATCH] D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I like it Repository: rC Clang https://reviews.llvm.org/D51729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D50168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

bkramer added a comment. Test case? Comment at: lib/CodeGen/CGBuiltin.cpp:1563 +Value *Result = Builder.CreateCall(F, {Tmp, Builder.getTrue()}); +if (Result->getType() != ResultType) + Result = Builder.CreateIntCast(Result, ResultType, /*isSigned*/true,

[PATCH] D50156: [test] Fix %hmaptool path for standalone builds

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, thanks Repository: rC Clang https://reviews.llvm.org/D50156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48873: [AST] Use llvm::TrailingObjects in CXXTryStmt

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D48873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D49274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:1080 + unsigned int r; + asm("vabsdiff2.u32.u32.u32.sat %0,%1,%2,0;" : "=r"(r) : "r"(__a), "r"(__b)); +

[PATCH] D49302: [AST] Various micro-optimizations in CXXInheritance

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. cool Repository: rC Clang https://reviews.llvm.org/D49302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49484: [CodeComplete] Allow getDeclaration on RK_Pattern result.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D49484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48845: [Sema] Add fixit for unused lambda captures

bkramer added inline comments. Comment at: test/FixIt/fixit-unused-lambda-capture.cpp:31 + // CHECK: [=,] { return i; }; +} This needs tests for: * capture initializers `[c = foo()] {};` * Capturing this `[this] {};` * Capturing *this `[*this] {};` * VLA

[PATCH] D47864: [python] Fix most Python binding unittests on Windows

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I don't know much about the python bindings, but this is probably fine. Repository: rC Clang https://reviews.llvm.org/D47864 ___

[PATCH] D47262: [VFS] Implement getRealPath in InMemoryFileSystem.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D47262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47074: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D47074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47060: [VFS] Implement getRealPath for OverlayFileSystem.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Basic/VirtualFileSystem.cpp:387 + SmallVectorImpl ) const { + // Not using overlays_begin/end because this method is

[PATCH] D46942: Add vfs::FileSystem::getRealPath

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. Please watch the windows buildbots carefully after landing this. Comment at: lib/Basic/FileManager.cpp:537 -#ifdef LLVM_ON_UNIX - char

[PATCH] D46148: [CUDA] Added -f[no-]cuda-short-ptr option

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D46148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D45603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44695: [clang-format] Partially revert r322749, replacing array with DenseSet

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I wouldn't say that this is more maintainable, but I'm not the maintainer of clang-format. Repository: rC Clang https://reviews.llvm.org/D44695

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer added a comment. I'd like to, but I don't know when I find time to rebase this thing after more than a year of waiting for review. https://reviews.llvm.org/D23130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43567: [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D43567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43371: [clang-include-fixer] Use add_clang_tool instead of add_clang_executable

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Removing FIXME seems right to me. Repository: rC Clang https://reviews.llvm.org/D42361 ___ cfe-commits mailing list

[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

bkramer added inline comments. Comment at: lib/Tooling/Tooling.cpp:404 if (CompileCommandsForFile.empty()) { // FIXME: There are two use cases here: doing a fuzzy // "find . -name '*.cc' |xargs tool" match, where as a user I don't care ioeric

[PATCH] D42577: [Lexer] Support adding working directory to relative search dir for #include shortening in HeaderSearch.

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Lex/HeaderSearch.h:708 + /// + /// \param WorkingDir If non-empty, this will be prepend to search directory + /// paths that are relative.

[PATCH] D42241: [CodeComplete] Fix completion in the middle of idents in macro calls

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think we can go ahead with this. I expect code completion in the middle of a token not to be used much though, so there might be more broken cases. Repository: rC Clang

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

bkramer added inline comments. Comment at: lib/Tooling/Tooling.cpp:404 if (CompileCommandsForFile.empty()) { // FIXME: There are two use cases here: doing a fuzzy // "find . -name '*.cc' |xargs tool" match, where as a user I don't care This

[PATCH] D42298: [clang-format] Fix shortening blocks in macros causing merged next line

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Format/UnwrappedLineFormatter.cpp:310 +MergedLines = tryMergeSimpleBlock(I - 1, E, Limit); +// If we managed to merge the block,

[PATCH] D42187: [clang-format] Adds a canonical delimiter to raw string formatting

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Format/ContinuationIndenter.cpp:1336 + unsigned OldSuffixSize = 2 + OldDelimiter.size(); + std::string RawText = +

[PATCH] D42189: [clang-format] Replace unordered_set with an array

bkramer accepted this revision. bkramer added a comment. lgtm Repository: rC Clang https://reviews.llvm.org/D42189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42189: [clang-format] Replace unordered_set with an array

bkramer added inline comments. Comment at: lib/Format/Format.cpp:1424 const AdditionalKeywords ) { -static const std::unordered_set FoundationIdentifiers = { +static const llvm::ArrayRef FoundationIdentifiers = { "CGFloat",

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

bkramer requested changes to this revision. bkramer added a comment. dump_ast_matchers.py should be working again now. Repository: rC Clang https://reviews.llvm.org/D42185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42185: [ASTMatcher] Add isScoped matcher for enumDecl.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D42167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

bkramer added inline comments. Comment at: clangd/ClangdServer.h:107 +/// A simple fixed-size thread pool implementation. +class SimpleThreadPool { public: What's so simple about it? Why not `clangd::ThreadPool`? Also there's `llvm::ThreadPool`, what's the

[PATCH] D42167: [clang-format] adds enclosing function detection to raw string formatting

bkramer added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1454 +// found. +static StringRef getEnclosingFunctionName(const FormatToken& Current) { + // Look for: 'function(' or 'function(' before Current. This function doesn't look

[PATCH] D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41788: [DeclPrinter] Fix two cases that crash clang -ast-print.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This should be fine. https://reviews.llvm.org/D41788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42098: [clang-format] Reorganize RawStringFormat based on language

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

bkramer added inline comments. Comment at: clangd/Compiler.h:39 +/// be consumed by the FrontendAction as it will have a pointer to the MainFile +/// buffer that will only be deleted if BeginSourceFile is called. std::unique_ptr prepareCompilerInstance( This

[PATCH] D42071: [Sema] Add a callback in VisibleDeclConsumer allowing client to know which DeclContext is going to visit.

bkramer added a comment. We should have a unit test for this, otherwise it's dead code. Comment at: include/clang/Sema/Lookup.h:791 + /// \param Ctx the context which Sema begins to visit. + virtual void BeginVisitContext(DeclContext *Ctx) {}; };

  1   2   3   >