r364774 - [ASTImporter] Silence unused variable warning in Release builds. NFC.

2019-07-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jul 1 07:33:26 2019 New Revision: 364774 URL: http://llvm.org/viewvc/llvm-project?rev=364774&view=rev Log: [ASTImporter] Silence unused variable warning in Release builds. NFC. Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL:

Re: r362551 - Convert MemberExpr creation and serialization to work the same way as

2019-06-05 Thread Benjamin Kramer via cfe-commits
It also crashes during clang selfhost with modules and libc++. Let me know if you need a precise reproducer command. I reverted this change and the dependent r362563 in r362597. On Wed, Jun 5, 2019 at 9:37 AM Martin Storsjö via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This broke buildi

r362597 - Revert "Factor out duplicated code building a MemberExpr and marking it" and "Convert MemberExpr creation and serialization to work the same way as"

2019-06-05 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jun 5 04:46:57 2019 New Revision: 362597 URL: http://llvm.org/viewvc/llvm-project?rev=362597&view=rev Log: Revert "Factor out duplicated code building a MemberExpr and marking it" and "Convert MemberExpr creation and serialization to work the same way as" This reverts comm

Re: r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

2019-05-30 Thread Benjamin Kramer via cfe-commits
Is this still necessary after r362062? On Thu, May 30, 2019 at 10:00 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: maskray > Date: Thu May 30 01:03:02 2019 > New Revision: 362067 > > URL: http://llvm.org/viewvc/llvm-project?rev=362067&view=rev > Log: > asm goto: f

r362062 - [AST] asm goto labels don't have constraints, don't try to copy them.

2019-05-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu May 30 00:21:08 2019 New Revision: 362062 URL: http://llvm.org/viewvc/llvm-project?rev=362062&view=rev Log: [AST] asm goto labels don't have constraints, don't try to copy them. Found by asan. Modified: cfe/trunk/lib/AST/Stmt.cpp Modified: cfe/trunk/lib/AST/Stmt.cpp UR

r357187 - Make helper functions static. NFC.

2019-03-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Mar 28 10:18:42 2019 New Revision: 357187 URL: http://llvm.org/viewvc/llvm-project?rev=357187&view=rev Log: Make helper functions static. NFC. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp cfe/trunk/lib/Sema/SemaOpenMP.cpp cfe/trunk/lib/StaticAnalyzer/Core/BugR

r356250 - Make getFullyQualifiedName qualify both the pointee and class type for member ptr types

2019-03-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Mar 15 04:09:41 2019 New Revision: 356250 URL: http://llvm.org/viewvc/llvm-project?rev=356250&view=rev Log: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types We already handle pointers and references, member ptrs are just another specia

r355819 - Remove an unnecessary -f when cp'ing to a file that was just deleted. NFC.

2019-03-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Mar 11 03:44:10 2019 New Revision: 355819 URL: http://llvm.org/viewvc/llvm-project?rev=355819&view=rev Log: Remove an unnecessary -f when cp'ing to a file that was just deleted. NFC. Modified: cfe/trunk/test/Modules/relative-import-path.c Modified: cfe/trunk/test/Module

r355816 - [Serialization] Add missing include

2019-03-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Mar 11 03:30:51 2019 New Revision: 355816 URL: http://llvm.org/viewvc/llvm-project?rev=355816&view=rev Log: [Serialization] Add missing include forward decl is not sufficient for destroying a unique_ptr. Modified: cfe/trunk/include/clang/Serialization/InMemoryModuleCach

r353705 - Make some helper functions static. NFC.

2019-02-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Feb 11 06:52:15 2019 New Revision: 353705 URL: http://llvm.org/viewvc/llvm-project?rev=353705&view=rev Log: Make some helper functions static. NFC. Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCount

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

2019-01-16 Thread Benjamin Kramer via cfe-commits
udes x86intrin.h >>>> transitively from . That's probably broken with all compilers :( >>>> >>>> On Tue, Jan 15, 2019 at 7:31 PM Craig Topper >>>> wrote: >>>> >>>>> Does V8 work with gcc which also has _xgetbv? Or is it

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

2019-01-15 Thread Benjamin Kramer via cfe-commits
_xgetbv a macro to make the patch work? >>> >>> ~Craig >>> >>> >>> On Tue, Jan 15, 2019 at 9:28 AM Benjamin Kramer via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> >>>> I rolled it back for now i

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

2019-01-15 Thread Benjamin Kramer via cfe-commits
to make the patch work? > > ~Craig > > > On Tue, Jan 15, 2019 at 9:28 AM Benjamin Kramer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I rolled it back for now in r351210, this pattern seems to be quite >> common even outside of v8. Let's figur

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

2019-01-15 Thread Benjamin Kramer via cfe-commits
I rolled it back for now in r351210, this pattern seems to be quite common even outside of v8. Let's figure out if we can keep the code working or if it needs to be fixed all over the place :( On Tue, Jan 15, 2019 at 3:02 PM Benjamin Kramer wrote: > I'm seeing breakages on v8 with this, it defin

r351210 - Revert "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

2019-01-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jan 15 09:23:36 2019 New Revision: 351210 URL: http://llvm.org/viewvc/llvm-project?rev=351210&view=rev Log: Revert "[X86] Make _xgetbv/_xsetbv on non-windows platforms" This reverts commit r351160. Breaks building v8. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.

Re: r350891 - Correct the source range returned from preprocessor callbacks.

2019-01-15 Thread Benjamin Kramer via cfe-commits
With this patch some ranges just come back empty. I rolled the change back in r351209, which also includes a test case that shows the empty ranges with this patch. On Thu, Jan 10, 2019 at 10:26 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Th

[clang-tools-extra] r351208 - Revert "Update clang-tools-extra for r350891 from Clang."

2019-01-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jan 15 09:20:04 2019 New Revision: 351208 URL: http://llvm.org/viewvc/llvm-project?rev=351208&view=rev Log: Revert "Update clang-tools-extra for r350891 from Clang." This reverts commit r350892. Modified: clang-tools-extra/trunk/test/modularize/ProblemsInconsistent.modu

r351209 - Revert "Correct the source range returned from preprocessor callbacks."

2019-01-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jan 15 09:20:05 2019 New Revision: 351209 URL: http://llvm.org/viewvc/llvm-project?rev=351209&view=rev Log: Revert "Correct the source range returned from preprocessor callbacks." This reverts commit r350891. Also add a test case that would return an empty string with r35089

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

2019-01-15 Thread Benjamin Kramer via cfe-commits
I'm seeing breakages on v8 with this, it defines its own _xgetbv. Any ideas what do do about this? https://chromium.googlesource.com/v8/v8.git/+/master/src/x64/assembler-x64.cc#36 src/x64/assembler-x64.cc:35:1: error: inline variables are incompatible with C++ standards before C++17 [-Werror,-Wc+

r351007 - [analyzer] Fix unused variable warnings in Release builds

2019-01-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jan 12 04:43:53 2019 New Revision: 351007 URL: http://llvm.org/viewvc/llvm-project?rev=351007&view=rev Log: [analyzer] Fix unused variable warnings in Release builds This was just an inlined version of isa. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp

r350529 - [Sema] Fix unused variable warning in Release builds

2019-01-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jan 7 07:22:08 2019 New Revision: 350529 URL: http://llvm.org/viewvc/llvm-project?rev=350529&view=rev Log: [Sema] Fix unused variable warning in Release builds Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp URL: http://llvm.o

r347496 - Remove the optional dependency from libclang to clang-tidy/include-fixer

2018-11-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Nov 23 07:02:33 2018 New Revision: 347496 URL: http://llvm.org/viewvc/llvm-project?rev=347496&view=rev Log: Remove the optional dependency from libclang to clang-tidy/include-fixer clangd does a better job on both of these, so don't slow down everyone's build for a poorly wo

[clang-tools-extra] r347496 - Remove the optional dependency from libclang to clang-tidy/include-fixer

2018-11-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Nov 23 07:02:33 2018 New Revision: 347496 URL: http://llvm.org/viewvc/llvm-project?rev=347496&view=rev Log: Remove the optional dependency from libclang to clang-tidy/include-fixer clangd does a better job on both of these, so don't slow down everyone's build for a poorly wo

[clang-tools-extra] r347460 - [clangd] Fix use-after-scope in unit test

2018-11-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Nov 22 04:54:25 2018 New Revision: 347460 URL: http://llvm.org/viewvc/llvm-project?rev=347460&view=rev Log: [clangd] Fix use-after-scope in unit test The scheduler holds a reference to `Proceed`, so it has to be destroyed after the scheduler. Found by asan. Modified: cl

Re: r347189 - [OpenCL] Fix address space deduction in template args.

2018-11-19 Thread Benjamin Kramer via cfe-commits
clang gives me this: llvm/tools/clang/lib/Sema/SemaType.cpp:7230:11: error: variable 'ImpAddr' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (D.getContext() == DeclaratorContext::TemplateArgContext) { ^~

[clang-tools-extra] r346608 - [clangd] Make ClangdFuzzer compile again.

2018-11-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Nov 11 03:09:58 2018 New Revision: 346608 URL: http://llvm.org/viewvc/llvm-project?rev=346608&view=rev Log: [clangd] Make ClangdFuzzer compile again. Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdF

r346130 - Reapply "Fix regression in behavior of clang -x c++-header -fmodule-name=XXX"

2018-11-05 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Nov 5 04:46:02 2018 New Revision: 346130 URL: http://llvm.org/viewvc/llvm-project?rev=346130&view=rev Log: Reapply "Fix regression in behavior of clang -x c++-header -fmodule-name=XXX" This reverts commit r345963. We have a path forward now. Original commit message: The dr

Re: r345833 - Logging: add CMake dependency so libAST can use OSLog analysis.

2018-11-01 Thread Benjamin Kramer via cfe-commits
This doesn't work. AST cannot depend on Analysis because Analysis already depends on AST. On Thu, Nov 1, 2018 at 3:24 PM Tim Northover via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: tnorthover > Date: Thu Nov 1 07:22:20 2018 > New Revision: 345833 > > URL: http://llvm.org/viewvc/

[clang-tools-extra] r344968 - [clang-tidy] Fix typo abls->absl.

2018-10-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 22 15:43:17 2018 New Revision: 344968 URL: http://llvm.org/viewvc/llvm-project?rev=344968&view=rev Log: [clang-tidy] Fix typo abls->absl. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-str-cat-append.rst Modified: clang-tools-extra/trunk/docs/clang

[clang-tools-extra] r344468 - Move some helpers from the global namespace into anonymous ones.

2018-10-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 13 15:18:22 2018 New Revision: 344468 URL: http://llvm.org/viewvc/llvm-project?rev=344468&view=rev Log: Move some helpers from the global namespace into anonymous ones. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified: clang-tools-extra/trunk/clang

r344468 - Move some helpers from the global namespace into anonymous ones.

2018-10-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 13 15:18:22 2018 New Revision: 344468 URL: http://llvm.org/viewvc/llvm-project?rev=344468&view=rev Log: Move some helpers from the global namespace into anonymous ones. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp cfe/trunk/lib/Static

r342909 - Fix the type of 1<<31 integer constants.

2018-09-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Sep 24 10:51:15 2018 New Revision: 342909 URL: http://llvm.org/viewvc/llvm-project?rev=342909&view=rev Log: Fix the type of 1<<31 integer constants. Shifting into the sign bit is technically undefined behavior. No known compiler exploits it though. Modified: cfe/trunk/i

[clang-tools-extra] r342252 - [modernize-use-transparent-functors] TypeLocs can be implicitly created, don't crash when encountering those.

2018-09-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Sep 14 11:05:30 2018 New Revision: 342252 URL: http://llvm.org/viewvc/llvm-project?rev=342252&view=rev Log: [modernize-use-transparent-functors] TypeLocs can be implicitly created, don't crash when encountering those. Modified: clang-tools-extra/trunk/clang-tidy/moderni

[clang-tools-extra] r342041 - [clang-tidy] Abseil: Add more directories that are slated for future absl expansion.

2018-09-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Sep 12 03:04:16 2018 New Revision: 342041 URL: http://llvm.org/viewvc/llvm-project?rev=342041&view=rev Log: [clang-tidy] Abseil: Add more directories that are slated for future absl expansion. Modified: clang-tools-extra/trunk/clang-tidy/abseil/AbseilMatcher.h Modified

[clang-tools-extra] r341929 - [clang-tidy] Insert absl::StrAppend when replacing StrCat.

2018-09-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Sep 11 05:19:45 2018 New Revision: 341929 URL: http://llvm.org/viewvc/llvm-project?rev=341929&view=rev Log: [clang-tidy] Insert absl::StrAppend when replacing StrCat. There might be no using decl for StrAppend around, inserting the qualified name is less likely to break thin

[clang-tools-extra] r341925 - [clang-tidy] Add a missing comma after "flags"

2018-09-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Sep 11 03:37:08 2018 New Revision: 341925 URL: http://llvm.org/viewvc/llvm-project?rev=341925&view=rev Log: [clang-tidy] Add a missing comma after "flags" Added: clang-tools-extra/trunk/test/clang-tidy/Inputs/absl/flags/ clang-tools-extra/trunk/test/clang-tidy/Inputs

[clang-tools-extra] r341643 - [clang-tidy] Abseil: Allow macros inside of absl to use internal absl things

2018-09-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Sep 7 02:25:23 2018 New Revision: 341643 URL: http://llvm.org/viewvc/llvm-project?rev=341643&view=rev Log: [clang-tidy] Abseil: Allow macros inside of absl to use internal absl things Modified: clang-tools-extra/trunk/clang-tidy/abseil/AbseilMatcher.h clang-tools-ex

r339031 - [Fixed Point Arithmetic] Remove unused include.

2018-08-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Aug 6 09:53:21 2018 New Revision: 339031 URL: http://llvm.org/viewvc/llvm-project?rev=339031&view=rev Log: [Fixed Point Arithmetic] Remove unused include. lib/Basic cannot depend on lib/AST. Modified: cfe/trunk/lib/Basic/FixedPoint.cpp Modified: cfe/trunk/lib/Basic/Fi

Re: r338455 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-08-01 Thread Benjamin Kramer via cfe-commits
It's pretty easy to make this crash $ cat memcpy.c void foo() { int a[1], b; memcpy((char*)a, (const char*)&b, (unsigned long)4); } $ clang memcpy.c llvm/include/llvm/ADT/SmallVector.h:178: const_reference llvm::SmallVectorTemplateCommon::back() const [T = clang::APValue::LValue PathEntry]: A

Re: r338299 - [DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL

2018-07-30 Thread Benjamin Kramer via cfe-commits
On Mon, Jul 30, 2018 at 10:37 PM Scott Linder via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: scott.linder > Date: Mon Jul 30 13:31:11 2018 > New Revision: 338299 > > URL: http://llvm.org/viewvc/llvm-project?rev=338299&view=rev > Log: > [DebugInfo][OpenCL] Generate correct block lit

r337862 - [Sema] Destroy tokens in DeclaratorChunk params

2018-07-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jul 24 15:47:16 2018 New Revision: 337862 URL: http://llvm.org/viewvc/llvm-project?rev=337862&view=rev Log: [Sema] Destroy tokens in DeclaratorChunk params Otherwise this leaks in some edge cases. Modified: cfe/trunk/include/clang/Sema/DeclSpec.h Modified: cfe/trunk/in

[clang-tools-extra] r337860 - [clangd] Guard fuzzer against empty inputs.

2018-07-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jul 24 14:50:06 2018 New Revision: 337860 URL: http://llvm.org/viewvc/llvm-project?rev=337860&view=rev Log: [clangd] Guard fuzzer against empty inputs. Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra/trunk/clangd/fuzzer/Clang

r337688 - [AST] Use llvm::TrailingObjects in CXXTryStmt

2018-07-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jul 23 05:45:24 2018 New Revision: 337688 URL: http://llvm.org/viewvc/llvm-project?rev=337688&view=rev Log: [AST] Use llvm::TrailingObjects in CXXTryStmt 1. Use llvm::TrailingObjects in CXXTryStmt instead of manually doing the reinterpret_casts + pointer arithmetic. This is

[clang-tools-extra] r337655 - [clangd] Unbreak fuzzer build.

2018-07-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Jul 22 08:55:57 2018 New Revision: 337655 URL: http://llvm.org/viewvc/llvm-project?rev=337655&view=rev Log: [clangd] Unbreak fuzzer build. Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp U

r337607 - [AST] Various micro-optimizations in CXXInheritance

2018-07-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jul 20 13:13:08 2018 New Revision: 337607 URL: http://llvm.org/viewvc/llvm-project?rev=337607&view=rev Log: [AST] Various micro-optimizations in CXXInheritance 1. Pack std::pair in CXXBasePaths::ClassSubobjects. 2. Use a SmallPtrSet instead of a SmallDenseSet for CXXBasePat

[clang-tools-extra] r337601 - [clangd] Fix racy use-after-scope in unittest

2018-07-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jul 20 11:45:25 2018 New Revision: 337601 URL: http://llvm.org/viewvc/llvm-project?rev=337601&view=rev Log: [clangd] Fix racy use-after-scope in unittest This only shows up with asan when the stars align in a bad way. Modified: clang-tools-extra/trunk/unittests/clangd/T

Re: r337152 - [Sema] Reword warning for constant captures that are not required

2018-07-17 Thread Benjamin Kramer via cfe-commits
Thanks for noticing. Reverted for now in r337278. The wording is still bad, but talking about ODR uses in there feels worse. On Tue, Jul 17, 2018 at 1:02 PM Malcolm Parsons wrote: > On Mon, 16 Jul 2018 at 10:57, Benjamin Kramer via cfe-commits > wrote: >

r337278 - Revert "[Sema] Reword warning for constant captures that are not required"

2018-07-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jul 17 06:17:01 2018 New Revision: 337278 URL: http://llvm.org/viewvc/llvm-project?rev=337278&view=rev Log: Revert "[Sema] Reword warning for constant captures that are not required" This reverts commit r337152. This applies to non-constants too. The real explanation is that

r337152 - [Sema] Reword warning for constant captures that are not required

2018-07-16 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jul 16 02:52:02 2018 New Revision: 337152 URL: http://llvm.org/viewvc/llvm-project?rev=337152&view=rev Log: [Sema] Reword warning for constant captures that are not required This is one of the darker corners of C++, make it clear that this is about constants and rephrase it

[clang-tools-extra] r337091 - [clang-tidy] Force exceptions to be enabled in test

2018-07-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jul 14 03:48:06 2018 New Revision: 337091 URL: http://llvm.org/viewvc/llvm-project?rev=337091&view=rev Log: [clang-tidy] Force exceptions to be enabled in test For targets that have them off by default. Modified: clang-tools-extra/trunk/test/clang-tidy/bugprone-exceptio

[clang-tools-extra] r336228 - [clangd] Replace UniqueFunction with llvm::unique_function.

2018-07-03 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jul 3 13:59:33 2018 New Revision: 336228 URL: http://llvm.org/viewvc/llvm-project?rev=336228&view=rev Log: [clangd] Replace UniqueFunction with llvm::unique_function. One implementation of this ought to be enough for everyone. Modified: clang-tools-extra/trunk/clangd/C

r335854 - Fix unittest build with GCC older than 5.

2018-06-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Jun 28 06:31:36 2018 New Revision: 335854 URL: http://llvm.org/viewvc/llvm-project?rev=335854&view=rev Log: Fix unittest build with GCC older than 5. Old GCCs have an annoying bug where RVO disables the automatic conversion to base for unique_ptr. Add a pessimizing std::move

r335382 - Reinstate quotes around the path to python that I accidentaly removed in r335330

2018-06-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 22 13:03:32 2018 New Revision: 335382 URL: http://llvm.org/viewvc/llvm-project?rev=335382&view=rev Log: Reinstate quotes around the path to python that I accidentaly removed in r335330 This broke users with spaces in the path, like C:\Program Files\Python Modified:

r335330 - [hmaptool] Turn %hmaptool into a proper substitution

2018-06-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 22 02:46:40 2018 New Revision: 335330 URL: http://llvm.org/viewvc/llvm-project?rev=335330&view=rev Log: [hmaptool] Turn %hmaptool into a proper substitution This is still super ugly, but at least it doesn't require working directories to just line up perfectly for python

r334619 - [Basic] Fix -Wreorder warning

2018-06-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jun 13 09:45:12 2018 New Revision: 334619 URL: http://llvm.org/viewvc/llvm-project?rev=334619&view=rev Log: [Basic] Fix -Wreorder warning Just use field initializers that don't suffer from this problem Modified: cfe/trunk/lib/Basic/Targets/PPC.h Modified: cfe/trunk/lib

r332400 - Move helper classes into anonymous namespaces. NFCI.

2018-05-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue May 15 14:26:47 2018 New Revision: 332400 URL: http://llvm.org/viewvc/llvm-project?rev=332400&view=rev Log: Move helper classes into anonymous namespaces. NFCI. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/trunk/lib/Serialization/ASTReaderDecl.cpp Modifie

[clang-tools-extra] r330754 - [clangd] Commit a heinous crime to make test hermetic and not depend on the standard library being around.

2018-04-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Apr 24 11:40:44 2018 New Revision: 330754 URL: http://llvm.org/viewvc/llvm-project?rev=330754&view=rev Log: [clangd] Commit a heinous crime to make test hermetic and not depend on the standard library being around. Added: clang-tools-extra/trunk/test/clangd/Inputs/

[clang-tools-extra] r330746 - [clangd] Initialize candidate count in unit test

2018-04-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Apr 24 10:57:53 2018 New Revision: 330746 URL: http://llvm.org/viewvc/llvm-project?rev=330746&view=rev Log: [clangd] Initialize candidate count in unit test Found by msan. Modified: clang-tools-extra/trunk/unittests/clangd/FindSymbolsTests.cpp Modified: clang-tools-ext

r330690 - [AST] Another attempt at fixing the ARM bots.

2018-04-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Apr 24 01:18:32 2018 New Revision: 330690 URL: http://llvm.org/viewvc/llvm-project?rev=330690&view=rev Log: [AST] Another attempt at fixing the ARM bots. Modified: cfe/trunk/test/SemaCXX/constexpr-string.cpp Modified: cfe/trunk/test/SemaCXX/constexpr-string.cpp URL: ht

r330689 - [AST] Use a bit of trickery to make test pass on platforms where wchar_t is unsigned.

2018-04-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Apr 24 00:53:10 2018 New Revision: 330689 URL: http://llvm.org/viewvc/llvm-project?rev=330689&view=rev Log: [AST] Use a bit of trickery to make test pass on platforms where wchar_t is unsigned. Modified: cfe/trunk/test/SemaCXX/constexpr-string.cpp Modified: cfe/trunk/t

r330656 - [AST] strcmp/memcmp always compares unsigned chars.

2018-04-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Apr 23 15:04:34 2018 New Revision: 330656 URL: http://llvm.org/viewvc/llvm-project?rev=330656&view=rev Log: [AST] strcmp/memcmp always compares unsigned chars. This makes it return the right result in a couple of edge cases. The wide versions always do the comparison on the

[clang-tools-extra] r330602 - [clangd] Fix Context::derive to actually call the right method.

2018-04-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Apr 23 08:27:42 2018 New Revision: 330602 URL: http://llvm.org/viewvc/llvm-project?rev=330602&view=rev Log: [clangd] Fix Context::derive to actually call the right method. C++ is weird. Modified: clang-tools-extra/trunk/clangd/Context.h Modified: clang-tools-extra/trun

[clang-tools-extra] r330599 - [clangd] Prune some dead declarations. No functionality change.

2018-04-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Apr 23 07:58:18 2018 New Revision: 330599 URL: http://llvm.org/viewvc/llvm-project?rev=330599&view=rev Log: [clangd] Prune some dead declarations. No functionality change. Modified: clang-tools-extra/trunk/clangd/Diagnostics.h clang-tools-extra/trunk/clangd/Trace.h

[clang-tools-extra] r330595 - [index] Fix methods that take a shared_ptr to just take a reference.

2018-04-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Apr 23 07:30:21 2018 New Revision: 330595 URL: http://llvm.org/viewvc/llvm-project?rev=330595&view=rev Log: [index] Fix methods that take a shared_ptr to just take a reference. There is no ownership here, passing a shared_ptr just adds confusion. No functionality change inte

r330595 - [index] Fix methods that take a shared_ptr to just take a reference.

2018-04-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Apr 23 07:30:21 2018 New Revision: 330595 URL: http://llvm.org/viewvc/llvm-project?rev=330595&view=rev Log: [index] Fix methods that take a shared_ptr to just take a reference. There is no ownership here, passing a shared_ptr just adds confusion. No functionality change inte

[clang-tools-extra] r329894 - [clang-apply-replacements] Always initialize FormatStyle.

2018-04-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Apr 12 03:35:24 2018 New Revision: 329894 URL: http://llvm.org/viewvc/llvm-project?rev=329894&view=rev Log: [clang-apply-replacements] Always initialize FormatStyle. The cleanup logic reads from this for cleanups even if reformatting is not requested. Found by msan. Modifi

[clang-tools-extra] r329292 - [clang-tidy] Remove google-runtime-member-string-references

2018-04-05 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Apr 5 07:51:01 2018 New Revision: 329292 URL: http://llvm.org/viewvc/llvm-project?rev=329292&view=rev Log: [clang-tidy] Remove google-runtime-member-string-references This is triggering on a pattern that's both too broad (const std::string& members can be used safely) and t

r329170 - Make helpers static. NFC.

2018-04-04 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Apr 4 04:45:11 2018 New Revision: 329170 URL: http://llvm.org/viewvc/llvm-project?rev=329170&view=rev Log: Make helpers static. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp cfe/trunk/lib/StaticAnalyzer/Core/WorkList.cpp Modified: cfe/tru

r328047 - [format] Eliminate global destructors.

2018-03-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Mar 20 14:52:19 2018 New Revision: 328047 URL: http://llvm.org/viewvc/llvm-project?rev=328047&view=rev Log: [format] Eliminate global destructors. Modified: cfe/trunk/lib/Format/BreakableToken.cpp cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Breaka

r328041 - [format] Initialize regex lazily

2018-03-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Mar 20 13:43:12 2018 New Revision: 328041 URL: http://llvm.org/viewvc/llvm-project?rev=328041&view=rev Log: [format] Initialize regex lazily No need to pay for this on program startup, and also no need to destroy it on process end. Modified: cfe/trunk/lib/Format/Namespa

Re: [PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2018-03-01 Thread Benjamin Kramer via cfe-commits
Frontend depends on StaticAnalyzerCore by including "clang/StaticAnalyzer/Core/Analyses.def". That's a clear layering violation, but cmake doesn't model header dependencies. Maybe Analyses.def should move into its own library. On Thu, Mar 1, 2018 at 3:07 PM Gábor Horváth via llvm-commits < llvm-c

r325468 - [Analyzer] Move UnexploredFirstStack into an anonymous namespace.

2018-02-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Feb 18 11:08:27 2018 New Revision: 325468 URL: http://llvm.org/viewvc/llvm-project?rev=325468&view=rev Log: [Analyzer] Move UnexploredFirstStack into an anonymous namespace. No functionality change intended. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp Mo

[clang-tools-extra] r325467 - [tidy] Move private ast matchers into anonymous namespaces to avoid ODR conflicts.

2018-02-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Feb 18 11:02:35 2018 New Revision: 325467 URL: http://llvm.org/viewvc/llvm-project?rev=325467&view=rev Log: [tidy] Move private ast matchers into anonymous namespaces to avoid ODR conflicts. No functionality change intended. Modified: clang-tools-extra/trunk/clang-tidy

[clang-tools-extra] r325298 - [include-fixer] Add more debug headers to the STL header list

2018-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Feb 15 13:37:29 2018 New Revision: 325298 URL: http://llvm.org/viewvc/llvm-project?rev=325298&view=rev Log: [include-fixer] Add more debug headers to the STL header list These are used for std::map/std::set in STL debug mode. Modified: clang-tools-extra/trunk/include-f

[clang-tools-extra] r324389 - [clangd] Make the premble tremble.

2018-02-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 6 12:08:23 2018 New Revision: 324389 URL: http://llvm.org/viewvc/llvm-project?rev=324389&view=rev Log: [clangd] Make the premble tremble. No functionality change. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/Clan

[clang-tools-extra] r324277 - [clangd] Add a cstring include for strerror.

2018-02-05 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Feb 5 14:10:39 2018 New Revision: 324277 URL: http://llvm.org/viewvc/llvm-project?rev=324277&view=rev Log: [clangd] Add a cstring include for strerror. Apparently this doesn't get included transitively on some systems. Modified: clang-tools-extra/trunk/clangd/Context.c

[clang-tools-extra] r324084 - [clang-tidy] Kill marco. No functionality change.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:39:07 2018 New Revision: 324084 URL: http://llvm.org/viewvc/llvm-project?rev=324084&view=rev Log: [clang-tidy] Kill marco. No functionality change. Modified: clang-tools-extra/trunk/clang-tidy/android/CloexecAccept4Check.cpp clang-tools-extra/trunk/clang-ti

[clang-tools-extra] r324083 - [clang-tidy] Widen anonymous namespace.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:39:00 2018 New Revision: 324083 URL: http://llvm.org/viewvc/llvm-project?rev=324083&view=rev Log: [clang-tidy] Widen anonymous namespace. The matchers in this check are prone to create ODR violations otherwise. No functionality change. Modified: clang-tools-ex

[clang-tools-extra] r324080 - [clang-tidy] Remove global constructor. No functionality change intended.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:23:24 2018 New Revision: 324080 URL: http://llvm.org/viewvc/llvm-project?rev=324080&view=rev Log: [clang-tidy] Remove global constructor. No functionality change intended. Modified: clang-tools-extra/trunk/clang-tidy/misc/RedundantExpressionCheck.cpp Modified:

[clang-tools-extra] r324079 - [clang-tidy] Don't reinvent the wheel, use existing log2 functions.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:23:21 2018 New Revision: 324079 URL: http://llvm.org/viewvc/llvm-project?rev=324079&view=rev Log: [clang-tidy] Don't reinvent the wheel, use existing log2 functions. This also makes the code ready for int128, even though I think it's currently impossible to get an

r323554 - Try to unbreak 32 bit builds after r323528.

2018-01-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jan 26 12:01:13 2018 New Revision: 323554 URL: http://llvm.org/viewvc/llvm-project?rev=323554&view=rev Log: Try to unbreak 32 bit builds after r323528. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/viewvc

r323528 - [AST] Use bit packing to reduce sizeof(TypedefNameDecl) from 88 to 80.

2018-01-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jan 26 06:14:11 2018 New Revision: 323528 URL: http://llvm.org/viewvc/llvm-project?rev=323528&view=rev Log: [AST] Use bit packing to reduce sizeof(TypedefNameDecl) from 88 to 80. We can stash the cached transparent tag bit in existing pointer padding. Everything coming out o

r323435 - Unused diagnostics can occur in tblgen.

2018-01-25 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Jan 25 07:57:22 2018 New Revision: 323435 URL: http://llvm.org/viewvc/llvm-project?rev=323435&view=rev Log: Unused diagnostics can occur in tblgen. Modified: cfe/trunk/utils/find-unused-diagnostics.sh Modified: cfe/trunk/utils/find-unused-diagnostics.sh URL: http://llv

r322783 - [ASTMatchers] Support generating docs for single-line matchers

2018-01-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 17 15:14:49 2018 New Revision: 322783 URL: http://llvm.org/viewvc/llvm-project?rev=322783&view=rev Log: [ASTMatchers] Support generating docs for single-line matchers clang-format likes this format. PR35989. Modified: cfe/trunk/docs/tools/dump_ast_matchers.py cf

r322779 - [Sema] Allow conversion between long double and __float128.

2018-01-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 17 14:56:57 2018 New Revision: 322779 URL: http://llvm.org/viewvc/llvm-project?rev=322779&view=rev Log: [Sema] Allow conversion between long double and __float128. We should only ban this if long double is a double double. x86's 80 bit long double is fine and supported b

r322687 - Update dump_ast_matchers for many recent changes.

2018-01-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 17 08:50:14 2018 New Revision: 322687 URL: http://llvm.org/viewvc/llvm-project?rev=322687&view=rev Log: Update dump_ast_matchers for many recent changes. The html file hasn't been updated in a long time so there are quite a few changes in there. No matchers were removed

r321960 - Remove outdated doxygen comment [-Wdocumentation]

2018-01-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Jan 7 01:11:16 2018 New Revision: 321960 URL: http://llvm.org/viewvc/llvm-project?rev=321960&view=rev Log: Remove outdated doxygen comment [-Wdocumentation] No functionality change. Modified: cfe/trunk/include/clang/Lex/ModuleMap.h Modified: cfe/trunk/include/clang/Le

r321948 - Add support for a limited subset of TS 18661-3 math builtins.

2018-01-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jan 6 13:49:54 2018 New Revision: 321948 URL: http://llvm.org/viewvc/llvm-project?rev=321948&view=rev Log: Add support for a limited subset of TS 18661-3 math builtins. These just overloads for _Float128. They're supported by GCC 7 and used by glibc. APFloat support is alre

r321626 - [Sema] Fix build with GCC

2018-01-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jan 1 09:07:23 2018 New Revision: 321626 URL: http://llvm.org/viewvc/llvm-project?rev=321626&view=rev Log: [Sema] Fix build with GCC tools/clang/lib/Sema/DeclSpec.cpp: In member function 'void clang::DeclSpec::Finish(clang::Sema&, const clang::PrintingPolicy&)': tools/clan

[clang-tools-extra] r321526 - Avoid int to string conversion in Twine or raw_ostream contexts.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 08:58:54 2017 New Revision: 321526 URL: http://llvm.org/viewvc/llvm-project?rev=321526&view=rev Log: Avoid int to string conversion in Twine or raw_ostream contexts. Some output changes from uppercase hex to lowercase hex, no other functionality change intended. Mod

r321526 - Avoid int to string conversion in Twine or raw_ostream contexts.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 08:58:54 2017 New Revision: 321526 URL: http://llvm.org/viewvc/llvm-project?rev=321526&view=rev Log: Avoid int to string conversion in Twine or raw_ostream contexts. Some output changes from uppercase hex to lowercase hex, no other functionality change intended. Mod

[clang-tools-extra] r321525 - [clangd] Get rid of unnecessary global variable. No functionality change.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 07:03:02 2017 New Revision: 321525 URL: http://llvm.org/viewvc/llvm-project?rev=321525&view=rev Log: [clangd] Get rid of unnecessary global variable. No functionality change. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp clang-tools-extra/trunk/clangd/

[clang-tools-extra] r321523 - [clangd] Simplify code. No functionality change intended.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 06:47:01 2017 New Revision: 321523 URL: http://llvm.org/viewvc/llvm-project?rev=321523&view=rev Log: [clangd] Simplify code. No functionality change intended. Modified: clang-tools-extra/trunk/clangd/index/FileIndex.cpp clang-tools-extra/trunk/clangd/index/Fil

r321429 - [AST] Inline CompoundStmt contents into the parent allocation.

2017-12-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Dec 24 08:24:20 2017 New Revision: 321429 URL: http://llvm.org/viewvc/llvm-project?rev=321429&view=rev Log: [AST] Inline CompoundStmt contents into the parent allocation. Saves a pointer on every CompoundStmt. Modified: cfe/trunk/include/clang/AST/Stmt.h cfe/trunk/l

r321428 - [AST] Convert AttributedStmt to llvm::TrailingObjects.

2017-12-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Dec 24 08:24:11 2017 New Revision: 321428 URL: http://llvm.org/viewvc/llvm-project?rev=321428&view=rev Log: [AST] Convert AttributedStmt to llvm::TrailingObjects. No functionality change intended. Modified: cfe/trunk/include/clang/AST/Stmt.h cfe/trunk/lib/AST/Stmt.c

r321425 - Make helpers static. No functionality change.

2017-12-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Dec 24 04:46:22 2017 New Revision: 321425 URL: http://llvm.org/viewvc/llvm-project?rev=321425&view=rev Log: Make helpers static. No functionality change. Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL: http://llvm.org/viewvc/l

[clang-tools-extra] r321286 - [clangd] Fix use after free.

2017-12-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 21 09:51:35 2017 New Revision: 321286 URL: http://llvm.org/viewvc/llvm-project?rev=321286&view=rev Log: [clangd] Fix use after free. Found by asan. Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified: clang-tools-extra/trunk/clangd/index/Sym

r320954 - Refactor overridden methods iteration to avoid double lookups.

2017-12-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Dec 17 15:52:45 2017 New Revision: 320954 URL: http://llvm.org/viewvc/llvm-project?rev=320954&view=rev Log: Refactor overridden methods iteration to avoid double lookups. Convert most uses to range-for loops. No functionality change intended. Modified: cfe/trunk/include

[clang-tools-extra] r319022 - Make helper function static. NFC.

2017-11-27 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Nov 27 04:48:26 2017 New Revision: 319022 URL: http://llvm.org/viewvc/llvm-project?rev=319022&view=rev Log: Make helper function static. NFC. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp Modified: clang-tools-extra/trunk/clangd/Protocol.cpp URL: http://llvm.or

Re: [clang-tools-extra] r318840 - [FindAllSymbols] Cache regexes, creating them is expensive

2017-11-23 Thread Benjamin Kramer via cfe-commits
>' requested here >>> __alloc_traits::__construct_backward(this->__alloc(), >>> this->__begin_, >>> this->__end_, __v.__begin_); >>> ^ >>> /usr/include/c++/v1/vector:1537:9: note: in instantiation of member >>> funct

<    1   2   3   4   5   6   7   8   9   10   >