Re: [PATCH] D19323: Fix cast compiler warning message in include-fixer.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rL LLVM http://reviews.llvm.org/D19323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r266870 - [include-fixer] Add a prototype for a new include fixing tool.

Author: d0k Date: Wed Apr 20 07:43:43 2016 New Revision: 266870 URL: http://llvm.org/viewvc/llvm-project?rev=266870=rev Log: [include-fixer] Add a prototype for a new include fixing tool. Summary: The goal of this tool is fairly simple, look up unknown identifiers in a global database and add

Re: [PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

bkramer marked 8 inline comments as done. Comment at: include-fixer/IncludeFixer.cpp:132 @@ +131,3 @@ + +private: + /// Query the database for a given identifier. klimek wrote: > Can we sort this so the public interface comes first? Also, why is the public >

Re: [PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

bkramer updated this revision to Diff 54344. bkramer added a comment. From now on you shall be known as InMemoryXrefsDB. http://reviews.llvm.org/D19314 Files: CMakeLists.txt include-fixer/CMakeLists.txt include-fixer/InMemoryXrefsDB.cpp include-fixer/InMemoryXrefsDB.h

Re: [PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

bkramer updated this revision to Diff 54342. bkramer added a comment. - FixedXrefsDB -> FakeXrefsDB - FakeXrefsDB is now configurable - Cosmetic & comment fixes. - Moved query to private methods. - Always insert new includes at the top, let clang-format sort out the rest (not yet implemented in

r266057 - Remove unused diagnostics. NFC.

Author: d0k Date: Tue Apr 12 06:49:52 2016 New Revision: 266057 URL: http://llvm.org/viewvc/llvm-project?rev=266057=rev Log: Remove unused diagnostics. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified:

Re: r265934 - [clang-format] Walk backwards from end() instead of forwards from rend().

On Mon, Apr 11, 2016 at 11:15 PM, Martin Probst wrote: >> > Was/is the 2 correct then? (if it was next(rbegin, 2) that'd be >> > equivalent >> > to prev(end, 3), yes?) >> >> I think it is from looking at the test case, looping in martin to see >> whether I'm right :) > > > At

Re: r265934 - [clang-format] Walk backwards from end() instead of forwards from rend().

On Mon, Apr 11, 2016 at 6:48 PM, David Blaikie <dblai...@gmail.com> wrote: > > > On Mon, Apr 11, 2016 at 5:19 AM, Benjamin Kramer via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: d0k >> Date: Mon Apr 11 07:19:19 2016 >> New Revisio

r265934 - [clang-format] Walk backwards from end() instead of forwards from rend().

Author: d0k Date: Mon Apr 11 07:19:19 2016 New Revision: 265934 URL: http://llvm.org/viewvc/llvm-project?rev=265934=rev Log: [clang-format] Walk backwards from end() instead of forwards from rend(). This should've been forwards from rbegin(), reverse iterators are just too confusing to be used

r265926 - Don't clutter the test directory with temporary IR files.

Author: d0k Date: Mon Apr 11 05:16:37 2016 New Revision: 265926 URL: http://llvm.org/viewvc/llvm-project?rev=265926=rev Log: Don't clutter the test directory with temporary IR files. -emit-llvm emits a file, -emit-llvm-only doesn't. Modified: cfe/trunk/test/Sema/attr-ifunc.c Modified:

r265918 - Remove redundant conditions of the form (A || (!A && B)) -> (A || B)

Author: d0k Date: Mon Apr 11 03:26:13 2016 New Revision: 265918 URL: http://llvm.org/viewvc/llvm-project?rev=265918=rev Log: Remove redundant conditions of the form (A || (!A && B)) -> (A || B) Found by cppcheck! PR27286 PR27287 PR27288 PR27289 Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp

[clang-tools-extra] r265680 - [clang-tidy] Remove unnecessary getName() on Decls and Types feeding into a DiagnosticBuilder

Author: d0k Date: Thu Apr 7 09:55:25 2016 New Revision: 265680 URL: http://llvm.org/viewvc/llvm-project?rev=265680=rev Log: [clang-tidy] Remove unnecessary getName() on Decls and Types feeding into a DiagnosticBuilder Going through a string removes some of the smarts of the diagnosic printer

r265654 - Move class into an anonymous namespace. NFC.

Author: d0k Date: Thu Apr 7 05:14:54 2016 New Revision: 265654 URL: http://llvm.org/viewvc/llvm-project?rev=265654=rev Log: Move class into an anonymous namespace. NFC. Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL:

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

bkramer added a subscriber: bkramer. Comment at: clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp:21 @@ +20,3 @@ +// Retrieve the character at offset |offset| of the string literal |SL|. +static unsigned int GetCharAt(const StringLiteral *SL, size_t offset) { + if (offset

Re: [PATCH] D4619: [SKX] Enabling SKX target (Skylake server chip) in clang

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This landed way back in http://reviews.llvm.org/rL214306. http://reviews.llvm.org/D4619 ___ cfe-commits mailing list

Re: [PATCH] D18319: Add a PragmaHandler Registry for plugins to add PragmaHandlers to

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. > OK to commit then? Yeah, looks good. Repository: rL LLVM http://reviews.llvm.org/D18319 ___ cfe-commits mailing list

r265126 - [Lexer] Let the compiler infer string lengths. No functionality change intended.

Author: d0k Date: Fri Apr 1 05:04:07 2016 New Revision: 265126 URL: http://llvm.org/viewvc/llvm-project?rev=265126=rev Log: [Lexer] Let the compiler infer string lengths. No functionality change intended. Modified: cfe/trunk/lib/Lex/Lexer.cpp Modified: cfe/trunk/lib/Lex/Lexer.cpp URL:

r265125 - [Lexer] Don't read out of bounds if a conflict marker is at the end of a file

Author: d0k Date: Fri Apr 1 04:58:45 2016 New Revision: 265125 URL: http://llvm.org/viewvc/llvm-project?rev=265125=rev Log: [Lexer] Don't read out of bounds if a conflict marker is at the end of a file This can happen as we look for '' while scanning tokens but then expect '\n' to tell

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

bkramer added a comment. If we really want to go down this route we should drop the exports file, putting random symbols in there is not going to fly. I'm not sure what that would break for libclang users though. Also make sure that your building without BUILD_SHARED_LIBS, otherwise you'll

[clang-tools-extra] r263900 - [clang-tidy] Update check for API change in r263895.

Author: d0k Date: Sun Mar 20 09:24:49 2016 New Revision: 263900 URL: http://llvm.org/viewvc/llvm-project?rev=263900=rev Log: [clang-tidy] Update check for API change in r263895. for range stmts now have split begin and ends, just apply OR to the condition. Should unbreak the build. Modified:

Re: r263893 - Reapply [2] [VFS] Add 'overlay-relative' field to YAML files

On Sun, Mar 20, 2016 at 3:08 AM, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Sat Mar 19 21:08:48 2016 > New Revision: 263893 > > URL: http://llvm.org/viewvc/llvm-project?rev=263893=rev > Log: > Reapply [2] [VFS] Add 'overlay-relative' field to

r263785 - Make LookupResult movable again.

Author: d0k Date: Fri Mar 18 08:31:00 2016 New Revision: 263785 URL: http://llvm.org/viewvc/llvm-project?rev=263785=rev Log: Make LookupResult movable again. We lost copy semantics in r263730, because it only worked for a few very specific cases. Move semantics don't have this issue. Sadly the

Re: r263785 - Make LookupResult movable again.

On Fri, Mar 18, 2016 at 5:10 PM, David Blaikie <dblai...@gmail.com> wrote: > > > On Fri, Mar 18, 2016 at 6:31 AM, Benjamin Kramer via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: d0k >> Date: Fri Mar 18 08:31:00 2016 >> New Revisio

r263718 - Use a simpler set of mock headers for the vfs+modules crash recovery tests.

Author: d0k Date: Thu Mar 17 11:19:51 2016 New Revision: 263718 URL: http://llvm.org/viewvc/llvm-project?rev=263718=rev Log: Use a simpler set of mock headers for the vfs+modules crash recovery tests. The System/ mock is large and too complex for this test. It can cause the tests to fail in

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

bkramer accepted this revision. bkramer added a comment. This looks good, thanks for the patch. When this goes in please watch the windows buildbots as plugin support on windows is somewhat broken and we may have to disable tests there. Also, while this is a strict improvement and should go in

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

On Mon, Mar 14, 2016 at 5:50 PM, Richard Smith <rich...@metafoo.co.uk> wrote: > On 14 Mar 2016 6:28 a.m., "Benjamin Kramer via cfe-commits" > <cfe-commits@lists.llvm.org> wrote: >> >> Author: d0k >> Date: Mon Mar 14 08:23:58 2016 >> New Rev

r263541 - Restrict the hack from r263429 to asan and msan.

Author: d0k Date: Tue Mar 15 04:41:39 2016 New Revision: 263541 URL: http://llvm.org/viewvc/llvm-project?rev=263541=rev Log: Restrict the hack from r263429 to asan and msan. The other sanitizers don't have backend passes that rely on value names. Avoid paying the compile time cost of names

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

; A long time ago I argued that the sanitizers should be using debug info >> instead of alloca names for this, and I really thought that they had >> implemented this... Is that not the case? >> >> It is really bad that the sanitizers are relying on this stuff... >>

r263436 - Revert "Recommitted r261634 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26715 at r263379."

Author: d0k Date: Mon Mar 14 09:58:28 2016 New Revision: 263436 URL: http://llvm.org/viewvc/llvm-project?rev=263436=rev Log: Revert "Recommitted r261634 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26715 at r263379." This reverts commit r263425. Breaks

r263429 - [Frontend] Disable value name discarding for all sanitizers.

Author: d0k Date: Mon Mar 14 08:23:58 2016 New Revision: 263429 URL: http://llvm.org/viewvc/llvm-project?rev=263429=rev Log: [Frontend] Disable value name discarding for all sanitizers. ASan also relies on names on allocas and will emit unhelpful output if they're not present. Just force-enable

Re: [PATCH] D18141: [clang-tidy] Fix "Name is not a simple identifier" assertion in `modernize-loop-convert` check.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good. Repository: rL LLVM http://reviews.llvm.org/D18141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17958: [clang-tidy] Make 'modernize-use-nullptr' check ignores NULL marcos used in other macros.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Patch looks good, only one cosmetic comment. Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:232 @@ +231,3 @@ + if (!getMacroAndArgLocations(StartLoc,

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

bkramer added a comment. GCC 6 is already doing this and people are already annotating their builds with -fno-delete-null-pointer-checks. Putting it under a different flag will break compatibility there :( http://reviews.llvm.org/D17993 ___

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

bkramer created this revision. bkramer added reviewers: rsmith, rjmccall. bkramer added a subscriber: cfe-commits. Also thread -f(no-)delete-null-pointer-checks through to CodeGen and make it disable this behavior. It's not a full implementation of that flag but it would be good to stay

Re: [PATCH] D17762: Fix an assertion failure in setPointOfInstantiation.

bkramer added a comment. I'm still not sure if this is the right way to fix it. Maybe @rsmith has an opinion? http://reviews.llvm.org/D17762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262716 - Move class into anonymous namespace. NFC.

Author: d0k Date: Fri Mar 4 08:18:52 2016 New Revision: 262716 URL: http://llvm.org/viewvc/llvm-project?rev=262716=rev Log: Move class into anonymous namespace. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp Modified:

Re: [PATCH] D17762: Fix an assertion failure in setPointOfInstantiation.

bkramer added a comment. This doesn't look right to me. Aborting tree transform on a bad source location seems just wrong. Where is the invalid source location coming from? Also the backtrace seems related to typo correction, maybe the bug is there? Repository: rL LLVM

r262596 - [libclang] Link clang-tidy plugin into libclang if present.

Author: d0k Date: Thu Mar 3 02:58:18 2016 New Revision: 262596 URL: http://llvm.org/viewvc/llvm-project?rev=262596=rev Log: [libclang] Link clang-tidy plugin into libclang if present. This is a sad workaround for the lack of plugin support in libclang. Depends on D17807, a tools-extra change

[clang-tools-extra] r262595 - [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

Author: d0k Date: Thu Mar 3 02:58:12 2016 New Revision: 262595 URL: http://llvm.org/viewvc/llvm-project?rev=262595=rev Log: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton. This doesn't really do much at the moment. You can load it via libclang and set the -checks via an extra command

Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

e to be cleaned up (like several have been with LLVM)) or > because they're project specific (either stylistically, or because they're > about some project specific API)) > > On Wed, Mar 2, 2016 at 6:47 AM, Benjamin Kramer via cfe-commits > <cfe-commits@lists.llvm.org> wro

[PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This doesn't really do much at the moment. You can load it via libclang and set the -checks via an extra command line argument as illustrated in the test case. Support for other options

[PATCH] D17808: [libclang] Link clang-tidy plugin into libclang if present.

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This is a sad workaround for the lack of plugin support in libclang. Depends on D17807, a tools-extra change that also contains the test case. This is designed to be easy to remove again if

Re: [PATCH] D17722: Make sure SLocEntry is an expansion before using getExpansion() method in SourceManager.

bkramer added a comment. This doesn't have a test case. Also I don't understand why this is the correct fix. If someone is calling one of those method with a file SourceLocation (as opposed to a macro SourceLocation) they should stop doing that. Repository: rL LLVM

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

On Thu, Feb 18, 2016 at 5:39 PM, David Blaikie wrote: > Thanks all! Which compiler flagged this? Wonder if/why Clang didn't flag it > for me? It was coming from GCC 4.9. Haven't checked if Clang also has this somewhere. > On Thu, Feb 18, 2016 at 5:27 AM, Phabricator via

r261217 - [Parse] Code complete expressions in bracket declarators.

Author: d0k Date: Thu Feb 18 09:30:24 2016 New Revision: 261217 URL: http://llvm.org/viewvc/llvm-project?rev=261217=rev Log: [Parse] Code complete expressions in bracket declarators. Currently we return no results when completing inside of the brackets in a 'char foo[]' declaration. Let the

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. LGTM, will commit it for you. http://reviews.llvm.org/D17375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

bkramer added a comment. I think this is the wrong solution. Per http://www.dwarfstd.org/ShowIssue.php?issue=140421.1 2. Calculate a secondary hash H' = (((S >> 32) & MASK(k)) | 1). [...] 4. Let H = (H + H') modulo M. Repeat at Step 3. So the OR has to happen before the ADD.

r260850 - Don't leak the ASTUnit when done with testing.

Author: d0k Date: Sun Feb 14 07:18:06 2016 New Revision: 260850 URL: http://llvm.org/viewvc/llvm-project?rev=260850=rev Log: Don't leak the ASTUnit when done with testing. Found by lsan. Modified: cfe/trunk/tools/c-index-test/core_main.cpp Modified:

r260815 - Reduce the number of implicit StringRef->std::string conversions by threading StringRef through more APIs.

Author: d0k Date: Sat Feb 13 07:42:54 2016 New Revision: 260815 URL: http://llvm.org/viewvc/llvm-project?rev=260815=rev Log: Reduce the number of implicit StringRef->std::string conversions by threading StringRef through more APIs. No functionality change intended. Modified:

r260814 - Fix use after free.

Author: d0k Date: Sat Feb 13 07:42:41 2016 New Revision: 260814 URL: http://llvm.org/viewvc/llvm-project?rev=260814=rev Log: Fix use after free. Found by asan. Modified: cfe/trunk/lib/Lex/Pragma.cpp Modified: cfe/trunk/lib/Lex/Pragma.cpp URL:

r260822 - Don't copy a DenseMap just to do lookup in it.

Author: d0k Date: Sat Feb 13 09:49:17 2016 New Revision: 260822 URL: http://llvm.org/viewvc/llvm-project?rev=260822=rev Log: Don't copy a DenseMap just to do lookup in it. Also remove the now unused isPodLike specialization. DenseMap only uses it for copies. Modified:

r260823 - RValue refs do not work that way.

Author: d0k Date: Sat Feb 13 10:00:13 2016 New Revision: 260823 URL: http://llvm.org/viewvc/llvm-project?rev=260823=rev Log: RValue refs do not work that way. Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL:

r260831 - Fix a leak in the generated code for attributes with strings.

Author: d0k Date: Sat Feb 13 12:11:49 2016 New Revision: 260831 URL: http://llvm.org/viewvc/llvm-project?rev=260831=rev Log: Fix a leak in the generated code for attributes with strings. Storing std::strings in attributes simply doesn't work, we never call the destructor. Use an array of

Re: [PATCH] D17163: [ASTMatchers] Add matcher hasAnyName.

bkramer added a subscriber: bkramer. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:644 @@ -643,2 +643,3 @@ explicit HasNameMatcher(StringRef Name); + explicit HasNameMatcher(ArrayRef Names); alexfh wrote: > Why not `ArrayRef`? That's an

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D15506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r259880 - Unbreak the cmake shared build.

Author: d0k Date: Fri Feb 5 05:38:50 2016 New Revision: 259880 URL: http://llvm.org/viewvc/llvm-project?rev=259880=rev Log: Unbreak the cmake shared build. Modified: clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt Modified: clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt

r259506 - [StaticAnalyzer] Pull SymExpr and SymbolData into its own header to avoid cyclic includes.

Author: d0k Date: Tue Feb 2 08:24:11 2016 New Revision: 259506 URL: http://llvm.org/viewvc/llvm-project?rev=259506=rev Log: [StaticAnalyzer] Pull SymExpr and SymbolData into its own header to avoid cyclic includes. Added: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SymExpr.h

r259507 - Make the remaining headers self-contained.

Author: d0k Date: Tue Feb 2 08:24:21 2016 New Revision: 259507 URL: http://llvm.org/viewvc/llvm-project?rev=259507=rev Log: Make the remaining headers self-contained. Modified: cfe/trunk/include/clang/AST/BaseSubobject.h cfe/trunk/include/clang/AST/DeclOpenMP.h

r259518 - Make CodeGen headers self-contained.

Author: d0k Date: Tue Feb 2 10:05:18 2016 New Revision: 259518 URL: http://llvm.org/viewvc/llvm-project?rev=259518=rev Log: Make CodeGen headers self-contained. Modified: cfe/trunk/lib/CodeGen/CGRecordLayout.h Modified: cfe/trunk/lib/CodeGen/CGRecordLayout.h URL:

r259490 - Make headers self-contained.

Author: d0k Date: Tue Feb 2 05:06:57 2016 New Revision: 259490 URL: http://llvm.org/viewvc/llvm-project?rev=259490=rev Log: Make headers self-contained. Modified: cfe/trunk/include/clang/Lex/HeaderMap.h cfe/trunk/include/clang/Lex/MacroArgs.h cfe/trunk/lib/Analysis/BodyFarm.h

r259489 - Move DebugInfoKind into its own header to cut the cyclic dependency edge from Driver to Frontend.

Author: d0k Date: Tue Feb 2 05:06:51 2016 New Revision: 259489 URL: http://llvm.org/viewvc/llvm-project?rev=259489=rev Log: Move DebugInfoKind into its own header to cut the cyclic dependency edge from Driver to Frontend. Added: cfe/trunk/include/clang/Driver/DebugInfoKind.h Modified:

r259376 - Move LocInfoType from Sema to AST.

Author: d0k Date: Mon Feb 1 11:42:01 2016 New Revision: 259376 URL: http://llvm.org/viewvc/llvm-project?rev=259376=rev Log: Move LocInfoType from Sema to AST. While transient and only used during parsing, LocInfoTypes are still used from ASTDumper and are part of the AST. Added:

r259355 - Remove the egregious PCHContainer layering hack that doesn't seem to be necessary anymore.

Author: d0k Date: Mon Feb 1 07:22:39 2016 New Revision: 259355 URL: http://llvm.org/viewvc/llvm-project?rev=259355=rev Log: Remove the egregious PCHContainer layering hack that doesn't seem to be necessary anymore. Modified: cfe/trunk/lib/Basic/FileManager.cpp

r259304 - [AST] Pull simple method inline.

Author: d0k Date: Sat Jan 30 06:16:23 2016 New Revision: 259304 URL: http://llvm.org/viewvc/llvm-project?rev=259304=rev Log: [AST] Pull simple method inline. Modified: cfe/trunk/include/clang/AST/ASTTypeTraits.h cfe/trunk/lib/AST/ASTTypeTraits.cpp Modified:

Re: [PATCH] D16718: Add an optional ToolName argument to runToolOnCodeWithArgs/buildASTFromCodeWithArgs.

bkramer updated this revision to Diff 46370. bkramer added a comment. Fix comment. http://reviews.llvm.org/D16718 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp unittests/ASTMatchers/ASTMatchersTest.h Index: unittests/ASTMatchers/ASTMatchersTest.h

[PATCH] D16718: Add an optional ToolName argument to runToolOnCodeWithArgs/buildASTFromCodeWithArgs.

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. This can be used as a way to modify argv[0] for a clang tool. http://reviews.llvm.org/D16718 Files: include/clang/Tooling/Tooling.h

r259187 - Add an optional ToolName argument to runToolOnCodeWithArgs/buildASTFromCodeWithArgs.

Author: d0k Date: Fri Jan 29 05:29:02 2016 New Revision: 259187 URL: http://llvm.org/viewvc/llvm-project?rev=259187=rev Log: Add an optional ToolName argument to runToolOnCodeWithArgs/buildASTFromCodeWithArgs. This can be used as a way to modify argv[0] for a clang tool. Differential Revision:

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

bkramer added a subscriber: bkramer. bkramer added a comment. Why are you re-adding all those Makefiles? http://reviews.llvm.org/D16529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r258918 - Update for LLVM change.

Author: d0k Date: Wed Jan 27 04:01:30 2016 New Revision: 258918 URL: http://llvm.org/viewvc/llvm-project?rev=258918=rev Log: Update for LLVM change. Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp cfe/trunk/tools/driver/cc1as_main.cpp Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp URL:

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

bkramer accepted this revision. bkramer added a reviewer: bkramer. bkramer added a comment. This revision is now accepted and ready to land. Looks good to me, but I don't really now CUDA. http://reviews.llvm.org/D16559 ___ cfe-commits mailing list

r258679 - Fix printing of types in initializers with suppressed tags.

Author: d0k Date: Mon Jan 25 04:34:06 2016 New Revision: 258679 URL: http://llvm.org/viewvc/llvm-project?rev=258679=rev Log: Fix printing of types in initializers with suppressed tags. Tag and specifier printing can be suppressed in Decl::printGroup, but these suppressions leak into the

Re: r257947 - Avoid self-assignment of SmallString, trigger UB behavior down the road.

On Fri, Jan 15, 2016 at 11:52 PM, David Blaikie via cfe-commits wrote: > > > On Fri, Jan 15, 2016 at 2:29 PM, Joerg Sonnenberger via cfe-commits > wrote: >> >> Author: joerg >> Date: Fri Jan 15 16:29:34 2016 >> New Revision: 257947 >> >>

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

On Mon, Jan 11, 2016 at 8:08 PM, Owen Anderson wrote: > >> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: >> >> >> >> On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits >> wrote: >> resistor created this

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer updated this revision to Diff 44472. bkramer added a comment. Why not both? http://reviews.llvm.org/D16058 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer created this revision. bkramer added a reviewer: djasper. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. As soon as a comment had whitespace changes inside of the token, we couldn't identify the whole comment as a trailing comment anymore and alignment stopped

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer updated this revision to Diff 44513. bkramer added a comment. - Moved newline check into replaceWhitespaceInToken - Removed duplicated TokenLength computation http://reviews.llvm.org/D16058 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer updated this revision to Diff 44508. bkramer added a comment. - Renamed flag to IsInsideToken and enabled it for all in-token replacements. - TokenLength now gets updated to contain all changes on the same line if they're in the same token. http://reviews.llvm.org/D16058 Files:

Re: r257260 - [vfs] Normalize working directory if requested.

Fixed in r257286, sorry for the breakage. On Sun, Jan 10, 2016 at 7:59 AM, Ismail Donmez wrote: > Hi, > >> + NormalizedFS.setCurrentWorkingDirectory("/b/c"); >> + NormalizedFS.setCurrentWorkingDirectory("."); >> + ASSERT_EQ("/b/c",

r257260 - [vfs] Normalize working directory if requested.

Author: d0k Date: Sat Jan 9 10:33:16 2016 New Revision: 257260 URL: http://llvm.org/viewvc/llvm-project?rev=257260=rev Log: [vfs] Normalize working directory if requested. FixedCompilationDatabase sets the working dir to "." by default. For chdir(".") this is a noop but this lead to

Re: r257259 - Make clang::format::reformat work with non 0-terminated strings.

On Sat, Jan 9, 2016 at 4:56 PM, Daniel Jasper via cfe-commits wrote: > Author: djasper > Date: Sat Jan 9 09:56:57 2016 > New Revision: 257259 > > URL: http://llvm.org/viewvc/llvm-project?rev=257259=rev > Log: > Make clang::format::reformat work with non 0-terminated

Re: [PATCH] D14329: Show inclusions from a preamble in clang_getInclusions.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Comment at: tools/libclang/CIndexInclusionStack.cpp:32 @@ -36,13 +31,3 @@ SmallVector InclusionStack; - unsigned n =

Re: [clang-tools-extra] r256562 - [clang-tidy] Fix a use-after-free bug found by asan

On Tue, Dec 29, 2015 at 5:14 PM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Tue Dec 29 10:14:38 2015 > New Revision: 256562 > > URL: http://llvm.org/viewvc/llvm-project?rev=256562=rev > Log: > [clang-tidy] Fix a use-after-free bug found by asan

r256377 - Replace llvm::utostr calls in Twine context with Twines. NFC.

Author: d0k Date: Thu Dec 24 04:07:37 2015 New Revision: 256377 URL: http://llvm.org/viewvc/llvm-project?rev=256377=rev Log: Replace llvm::utostr calls in Twine context with Twines. NFC. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk/lib/Basic/Targets.cpp Modified:

r255635 - [libclang] Add a flag to create the precompiled preamble on the first parse.

Author: d0k Date: Tue Dec 15 03:30:31 2015 New Revision: 255635 URL: http://llvm.org/viewvc/llvm-project?rev=255635=rev Log: [libclang] Add a flag to create the precompiled preamble on the first parse. Summary: The current default is to create the preamble on the first reparse, aka second parse.

[PATCH] D15490: [libclang] Add a flag to create the precompiled preamble on the first parse.

bkramer created this revision. bkramer added reviewers: doug.gregor, klimek. bkramer added a subscriber: cfe-commits. The current default is to create the preamble on the first reparse, aka second parse. This is useful for clients that do not want to block when opening a file because serializing

Re: [PATCH] D15490: [libclang] Add a flag to create the precompiled preamble on the first parse.

bkramer updated this revision to Diff 42749. bkramer added a comment. Add test case. http://reviews.llvm.org/D15490 Files: include/clang-c/Index.h include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp test/Index/complete-preamble.cpp tools/c-index-test/c-index-test.c

[PATCH] D15147: [clang-format] Reflow block comments when they're over the column limit

bkramer created this revision. bkramer added reviewers: djasper, klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. /* a * a*/ Now becomes /* * a a*/ instead of /* * a * a*/ This is implemented by glueing the next line on while

r254446 - Avoid picking up system headers in unittest by providing a fake libstdc++ with a ridiculously high version number.

Author: d0k Date: Tue Dec 1 13:42:07 2015 New Revision: 254446 URL: http://llvm.org/viewvc/llvm-project?rev=254446=rev Log: Avoid picking up system headers in unittest by providing a fake libstdc++ with a ridiculously high version number. The host libstdc++ may be horribly broken and we want

r253654 - Regenerate ASTMatchersReference without CRLF.

Author: d0k Date: Fri Nov 20 01:57:46 2015 New Revision: 253654 URL: http://llvm.org/viewvc/llvm-project?rev=253654=rev Log: Regenerate ASTMatchersReference without CRLF. Modified: cfe/trunk/docs/LibASTMatchersReference.html Modified: cfe/trunk/docs/LibASTMatchersReference.html URL:

r253466 - [libclang] Add entry points that take a full command line including argv[0].

Author: d0k Date: Wed Nov 18 10:14:27 2015 New Revision: 253466 URL: http://llvm.org/viewvc/llvm-project?rev=253466=rev Log: [libclang] Add entry points that take a full command line including argv[0]. This provides both a more uniform interface and makes libclang behave like clang tooling wrt

[PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This provides both a more uniform interface and makes libclang behave like clang tooling wrt relative paths against argv[0]. This is necessary for finding paths to a c++ standard library

Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

bkramer updated this revision to Diff 40269. bkramer added a comment. - Add a test case to make sure argv[0] handling actually works. - Clarify comments a bit. http://reviews.llvm.org/D14695 Files: include/clang-c/Index.h lib/Frontend/CreateInvocationFromCommandLine.cpp

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

bkramer added a comment. Can you try setting up the virtual files with the vfs::InMemoryFileSystem stuff? There are some examples how to set up with OverlayFileSystem in tree. InMemoryFileSystem was written with windows path separators in mind, I just never tried to run it on windows :)

Re: [PATCH] D13844: [libclang] Visit TypeAliasTemplateDecl

bkramer accepted this revision. bkramer added a comment. Looks good to me too, do you have commit access? http://reviews.llvm.org/D13844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r251514 - Put global classes into the appropriate namespace.

Author: d0k Date: Wed Oct 28 08:54:16 2015 New Revision: 251514 URL: http://llvm.org/viewvc/llvm-project?rev=251514=rev Log: Put global classes into the appropriate namespace. Most of the cases belong into an anonymous namespace. No functionality change intended. Modified:

r251528 - Move global classes into anonymous namespaces. NFC.

Author: d0k Date: Wed Oct 28 12:16:26 2015 New Revision: 251528 URL: http://llvm.org/viewvc/llvm-project?rev=251528=rev Log: Move global classes into anonymous namespaces. NFC. Modified: cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/CodeGen/CGCall.cpp Modified:

Re: [PATCH] D13891: Apply modernize-use-default to llvm.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Two minor comments, otherwise looks good: 1. beware of the GCC 4.7 issues and trivial class initializer issues we hit with this kind of changes earlier. 2. I prefer to leave

Re: [PATCH] D13920: Minor fix in ToolChainTest.cpp to allow user defined GCC toolchain.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This should be fine. Sorry for the breakage. http://reviews.llvm.org/D13920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r251432 - Remove unused diagnostic. NFC.

Author: d0k Date: Tue Oct 27 13:34:47 2015 New Revision: 251432 URL: http://llvm.org/viewvc/llvm-project?rev=251432=rev Log: Remove unused diagnostic. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td URL:

[clang-tools-extra] r251499 - [tidy] Remove stray iostream include from test.

Author: d0k Date: Wed Oct 28 00:16:37 2015 New Revision: 251499 URL: http://llvm.org/viewvc/llvm-project?rev=251499=rev Log: [tidy] Remove stray iostream include from test. It is unused and we cannot rely on standard headers being present while executing tests. Modified:

<    3   4   5   6   7   8   9   >