bbassi added a comment.
@MyDeveloperDay Thanks. This would be my first revision and I have few
questions before I start coding. Would you be able to answer those over email?
They are mainly about the design of clang-format and some existing options.
CHANGES SINCE LAST ACTION
bbassi added a comment.
@MyDeveloperDay hey, I am currently working on this, and adding a new option
called BreakBeforeClosingBracket. I have some questions to understand the
existing code, they might not be directly linked to this change so I am not
sure if this the best place to ask those
bbassi added a comment.
@MyDeveloperDay Can you please share your thoughts on my comment above?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D33029/new/
https://reviews.llvm.org/D33029
___
cfe-commits mailing list
bbassi added a comment.
I don't think that's quite right. Then you will also have to have a
`AlignWithDanglingParenthesis` for cases when people still want closing
parenthesis on new line but want parameters as well as closing parenthesis to
be aligned with opening parenthesis. I think we need
bbassi added a comment.
@stringham @MyDeveloperDay I have some questions.
- As some have pointed out DanglingParenthesis might be a confusing name, so
should we try to call it something like BreakBeforeClosingBracket? When this
option when is set to true we will always break before closing
bbassi added a comment.
@MyDeveloperDay Is someone working on fixing the breaking tests and merging it?
I need this feature so if someone isn't working on it already, I can take it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D33029/new/
https://reviews.llvm.org/D33029
